svn commit: r1740242 - in /tomcat/trunk/java/org/apache/catalina/tribes: group/ group/interceptors/ membership/ transport/ transport/bio/ transport/nio/

2016-04-21 Thread kfujino
Author: kfujino
Date: Thu Apr 21 07:09:45 2016
New Revision: 1740242

URL: http://svn.apache.org/viewvc?rev=1740242&view=rev
Log:
Revert r1740044.

Modified:
tomcat/trunk/java/org/apache/catalina/tribes/group/ChannelCoordinator.java

tomcat/trunk/java/org/apache/catalina/tribes/group/ChannelInterceptorBase.java

tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/MessageDispatchInterceptor.java

tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/TcpPingInterceptor.java
tomcat/trunk/java/org/apache/catalina/tribes/membership/McastService.java

tomcat/trunk/java/org/apache/catalina/tribes/membership/McastServiceImpl.java
tomcat/trunk/java/org/apache/catalina/tribes/transport/ReceiverBase.java

tomcat/trunk/java/org/apache/catalina/tribes/transport/ReplicationTransmitter.java
tomcat/trunk/java/org/apache/catalina/tribes/transport/bio/BioReceiver.java
tomcat/trunk/java/org/apache/catalina/tribes/transport/nio/NioReceiver.java

Modified: 
tomcat/trunk/java/org/apache/catalina/tribes/group/ChannelCoordinator.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/group/ChannelCoordinator.java?rev=1740242&r1=1740241&r2=1740242&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/tribes/group/ChannelCoordinator.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/tribes/group/ChannelCoordinator.java 
Thu Apr 21 07:09:45 2016
@@ -151,10 +151,10 @@ public class ChannelCoordinator extends
 //listens to with the local membership settings
 if ( Channel.SND_RX_SEQ==(svc & Channel.SND_RX_SEQ) ) {
 clusterReceiver.setMessageListener(this);
-clusterReceiver.setChannel(channel);
+clusterReceiver.setChannel(getChannel());
 clusterReceiver.start();
 //synchronize, big time FIXME
-Member localMember = channel.getLocalMember(false);
+Member localMember = getChannel().getLocalMember(false);
 if (localMember instanceof StaticMember) {
 // static member
 StaticMember staticMember = (StaticMember)localMember;
@@ -171,14 +171,14 @@ public class ChannelCoordinator extends
 valid = true;
 }
 if ( Channel.SND_TX_SEQ==(svc & Channel.SND_TX_SEQ) ) {
-clusterSender.setChannel(channel);
+clusterSender.setChannel(getChannel());
 clusterSender.start();
 valid = true;
 }
 
 if ( Channel.MBR_RX_SEQ==(svc & Channel.MBR_RX_SEQ) ) {
 membershipService.setMembershipListener(this);
-membershipService.setChannel(channel);
+membershipService.setChannel(getChannel());
 if (membershipService instanceof McastService) {
 ((McastService)membershipService).setMessageListener(this);
 }
@@ -186,7 +186,7 @@ public class ChannelCoordinator extends
 valid = true;
 }
 if ( Channel.MBR_TX_SEQ==(svc & Channel.MBR_TX_SEQ) ) {
-membershipService.setChannel(channel);
+membershipService.setChannel(getChannel());
 membershipService.start(MembershipService.MBR_TX);
 valid = true;
 }
@@ -247,7 +247,7 @@ public class ChannelCoordinator extends
 }
 
 startLevel = (startLevel & (~svc));
-channel = null;
+setChannel(null);
 } catch (Exception x) {
 throw new ChannelException(x);
 }

Modified: 
tomcat/trunk/java/org/apache/catalina/tribes/group/ChannelInterceptorBase.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/group/ChannelInterceptorBase.java?rev=1740242&r1=1740241&r2=1740242&view=diff
==
--- 
tomcat/trunk/java/org/apache/catalina/tribes/group/ChannelInterceptorBase.java 
(original)
+++ 
tomcat/trunk/java/org/apache/catalina/tribes/group/ChannelInterceptorBase.java 
Thu Apr 21 07:09:45 2016
@@ -29,7 +29,7 @@ public abstract class ChannelInterceptor
 
 private ChannelInterceptor next;
 private ChannelInterceptor previous;
-protected Channel channel;
+private Channel channel;
 //default value, always process
 protected int optionFlag = 0;
 

Modified: 
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/MessageDispatchInterceptor.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/MessageDispatchInterceptor.java?rev=1740242&r1=1740241&r2=1740242&view=diff
==
--- 
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/

svn commit: r1740243 - in /tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes: group/ group/interceptors/ membership/ transport/ transport/bio/ transport/nio/

2016-04-21 Thread kfujino
Author: kfujino
Date: Thu Apr 21 07:10:34 2016
New Revision: 1740243

URL: http://svn.apache.org/viewvc?rev=1740243&view=rev
Log:
Revert r1740045.

Modified:

tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/group/ChannelCoordinator.java

tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/group/ChannelInterceptorBase.java

tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/group/interceptors/MessageDispatchInterceptor.java

tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/group/interceptors/TcpPingInterceptor.java

tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/membership/McastService.java

tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/membership/McastServiceImpl.java

tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/transport/ReceiverBase.java

tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/transport/ReplicationTransmitter.java

tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/transport/bio/BioReceiver.java

tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/transport/nio/NioReceiver.java

Modified: 
tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/group/ChannelCoordinator.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/group/ChannelCoordinator.java?rev=1740243&r1=1740242&r2=1740243&view=diff
==
--- 
tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/group/ChannelCoordinator.java
 (original)
+++ 
tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/group/ChannelCoordinator.java
 Thu Apr 21 07:10:34 2016
@@ -151,10 +151,10 @@ public class ChannelCoordinator extends
 //listens to with the local membership settings
 if ( Channel.SND_RX_SEQ==(svc & Channel.SND_RX_SEQ) ) {
 clusterReceiver.setMessageListener(this);
-clusterReceiver.setChannel(channel);
+clusterReceiver.setChannel(getChannel());
 clusterReceiver.start();
 //synchronize, big time FIXME
-Member localMember = channel.getLocalMember(false);
+Member localMember = getChannel().getLocalMember(false);
 if (localMember instanceof StaticMember) {
 // static member
 StaticMember staticMember = (StaticMember)localMember;
@@ -171,14 +171,14 @@ public class ChannelCoordinator extends
 valid = true;
 }
 if ( Channel.SND_TX_SEQ==(svc & Channel.SND_TX_SEQ) ) {
-clusterSender.setChannel(channel);
+clusterSender.setChannel(getChannel());
 clusterSender.start();
 valid = true;
 }
 
 if ( Channel.MBR_RX_SEQ==(svc & Channel.MBR_RX_SEQ) ) {
 membershipService.setMembershipListener(this);
-membershipService.setChannel(channel);
+membershipService.setChannel(getChannel());
 if (membershipService instanceof McastService) {
 ((McastService)membershipService).setMessageListener(this);
 }
@@ -186,7 +186,7 @@ public class ChannelCoordinator extends
 valid = true;
 }
 if ( Channel.MBR_TX_SEQ==(svc & Channel.MBR_TX_SEQ) ) {
-membershipService.setChannel(channel);
+membershipService.setChannel(getChannel());
 membershipService.start(MembershipService.MBR_TX);
 valid = true;
 }
@@ -247,7 +247,7 @@ public class ChannelCoordinator extends
 }
 
 startLevel = (startLevel & (~svc));
-channel = null;
+setChannel(null);
 } catch (Exception x) {
 throw new ChannelException(x);
 }

Modified: 
tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/group/ChannelInterceptorBase.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/group/ChannelInterceptorBase.java?rev=1740243&r1=1740242&r2=1740243&view=diff
==
--- 
tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/group/ChannelInterceptorBase.java
 (original)
+++ 
tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/group/ChannelInterceptorBase.java
 Thu Apr 21 07:10:34 2016
@@ -29,7 +29,7 @@ public abstract class ChannelInterceptor
 
 private ChannelInterceptor next;
 private ChannelInterceptor previous;
-protected Channel channel;
+private Channel channel;
 //default value, always process
 protected int optionFlag = 0;
 

Modified: 
tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/group/interceptors/MessageDispatchInterceptor.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/group/interceptors/MessageDispatchInterceptor.java?rev=1740243&r1=1740242&r2

svn commit: r1740245 - in /tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes: group/ group/interceptors/ membership/ transport/ transport/bio/ transport/nio/

2016-04-21 Thread kfujino
Author: kfujino
Date: Thu Apr 21 07:11:23 2016
New Revision: 1740245

URL: http://svn.apache.org/viewvc?rev=1740245&view=rev
Log:
Revert r1740046.

Modified:

tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/group/ChannelCoordinator.java

tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/group/ChannelInterceptorBase.java

tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/MessageDispatchInterceptor.java

tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/TcpPingInterceptor.java

tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/membership/McastService.java

tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/membership/McastServiceImpl.java

tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/transport/ReceiverBase.java

tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/transport/ReplicationTransmitter.java

tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/transport/bio/BioReceiver.java

tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/transport/nio/NioReceiver.java

Modified: 
tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/group/ChannelCoordinator.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/group/ChannelCoordinator.java?rev=1740245&r1=1740244&r2=1740245&view=diff
==
--- 
tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/group/ChannelCoordinator.java
 (original)
+++ 
tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/group/ChannelCoordinator.java
 Thu Apr 21 07:11:23 2016
@@ -154,11 +154,11 @@ public class ChannelCoordinator extends
 if ( Channel.SND_RX_SEQ==(svc & Channel.SND_RX_SEQ) ) {
 clusterReceiver.setMessageListener(this);
 if (clusterReceiver instanceof ReceiverBase) {
-((ReceiverBase)clusterReceiver).setChannel(channel);
+((ReceiverBase)clusterReceiver).setChannel(getChannel());
 }
 clusterReceiver.start();
 //synchronize, big time FIXME
-Member localMember = channel.getLocalMember(false);
+Member localMember = getChannel().getLocalMember(false);
 if (localMember instanceof StaticMember) {
 // static member
 StaticMember staticMember = (StaticMember)localMember;
@@ -176,7 +176,7 @@ public class ChannelCoordinator extends
 }
 if ( Channel.SND_TX_SEQ==(svc & Channel.SND_TX_SEQ) ) {
 if (clusterSender instanceof ReplicationTransmitter) {
-
((ReplicationTransmitter)clusterSender).setChannel(channel);
+
((ReplicationTransmitter)clusterSender).setChannel(getChannel());
 }
 clusterSender.start();
 valid = true;
@@ -186,14 +186,14 @@ public class ChannelCoordinator extends
 membershipService.setMembershipListener(this);
 if (membershipService instanceof McastService) {
 ((McastService)membershipService).setMessageListener(this);
-((McastService)membershipService).setChannel(channel);
+((McastService)membershipService).setChannel(getChannel());
 }
 membershipService.start(MembershipService.MBR_RX);
 valid = true;
 }
 if ( Channel.MBR_TX_SEQ==(svc & Channel.MBR_TX_SEQ) ) {
 if (membershipService instanceof McastService) {
-((McastService)membershipService).setChannel(channel);
+((McastService)membershipService).setChannel(getChannel());
 }
 membershipService.start(MembershipService.MBR_TX);
 valid = true;
@@ -255,7 +255,7 @@ public class ChannelCoordinator extends
 }
 
 startLevel = (startLevel & (~svc));
-channel = null;
+setChannel(null);
 } catch (Exception x) {
 throw new ChannelException(x);
 }

Modified: 
tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/group/ChannelInterceptorBase.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/group/ChannelInterceptorBase.java?rev=1740245&r1=1740244&r2=1740245&view=diff
==
--- 
tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/group/ChannelInterceptorBase.java
 (original)
+++ 
tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/group/ChannelInterceptorBase.java
 Thu Apr 21 07:11:23 2016
@@ -29,7 +29,7 @@ public abstract class ChannelInterceptor
 
 private ChannelInterceptor next;
 private ChannelInterceptor previous;
-protected Channel channel;
+private Channel channel;
 //default value, always process
 

svn commit: r1740246 - in /tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes: group/ group/interceptors/ membership/ transport/ transport/bio/ transport/nio/

2016-04-21 Thread kfujino
Author: kfujino
Date: Thu Apr 21 07:12:24 2016
New Revision: 1740246

URL: http://svn.apache.org/viewvc?rev=1740246&view=rev
Log:
Revert r1740047.

Modified:

tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/group/ChannelCoordinator.java

tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/group/ChannelInterceptorBase.java

tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/MessageDispatch15Interceptor.java

tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/MessageDispatchInterceptor.java

tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/TcpPingInterceptor.java

tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/membership/McastService.java

tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/membership/McastServiceImpl.java

tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/transport/ReceiverBase.java

tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/transport/ReplicationTransmitter.java

tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/transport/bio/BioReceiver.java

tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/transport/nio/NioReceiver.java

Modified: 
tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/group/ChannelCoordinator.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/group/ChannelCoordinator.java?rev=1740246&r1=1740245&r2=1740246&view=diff
==
--- 
tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/group/ChannelCoordinator.java
 (original)
+++ 
tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/group/ChannelCoordinator.java
 Thu Apr 21 07:12:24 2016
@@ -144,11 +144,11 @@ public class ChannelCoordinator extends
 if ( Channel.SND_RX_SEQ==(svc & Channel.SND_RX_SEQ) ) {
 clusterReceiver.setMessageListener(this);
 if (clusterReceiver instanceof ReceiverBase) {
-((ReceiverBase)clusterReceiver).setChannel(channel);
+((ReceiverBase)clusterReceiver).setChannel(getChannel());
 }
 clusterReceiver.start();
 //synchronize, big time FIXME
-Member localMember = channel.getLocalMember(false);
+Member localMember = getChannel().getLocalMember(false);
 if (localMember instanceof StaticMember) {
 // static member
 StaticMember staticMember = (StaticMember)localMember;
@@ -167,7 +167,7 @@ public class ChannelCoordinator extends
 }
 if ( Channel.SND_TX_SEQ==(svc & Channel.SND_TX_SEQ) ) {
 if (clusterSender instanceof ReplicationTransmitter) {
-
((ReplicationTransmitter)clusterSender).setChannel(channel);
+
((ReplicationTransmitter)clusterSender).setChannel(getChannel());
 }
 valid = true;
 clusterSender.start();
@@ -177,14 +177,14 @@ public class ChannelCoordinator extends
 membershipService.setMembershipListener(this);
 if (membershipService instanceof McastService) {
 ((McastService)membershipService).setMessageListener(this);
-((McastService)membershipService).setChannel(channel);
+((McastService)membershipService).setChannel(getChannel());
 }
 membershipService.start(MembershipService.MBR_RX);
 valid = true;
 }
 if ( Channel.MBR_TX_SEQ==(svc & Channel.MBR_TX_SEQ) ) {
 if (membershipService instanceof McastService) {
-((McastService)membershipService).setChannel(channel);
+((McastService)membershipService).setChannel(getChannel());
 }
 membershipService.start(MembershipService.MBR_TX);
 valid = true;
@@ -246,7 +246,7 @@ public class ChannelCoordinator extends
 }
 
 startLevel = (startLevel & (~svc));
-channel = null;
+setChannel(null);
 }catch ( Exception x ) {
 throw new ChannelException(x);
 } finally {

Modified: 
tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/group/ChannelInterceptorBase.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/group/ChannelInterceptorBase.java?rev=1740246&r1=1740245&r2=1740246&view=diff
==
--- 
tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/group/ChannelInterceptorBase.java
 (original)
+++ 
tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/group/ChannelInterceptorBase.java
 Thu Apr 21 07:12:24 2016
@@ -30,7 +30,7 @@ public abstract class ChannelInterceptor
 
 private ChannelInterceptor next;
 private Channel

svn commit: r1740270 - /tomcat/trunk/java/org/apache/catalina/tribes/transport/ReceiverBase.java

2016-04-21 Thread kfujino
Author: kfujino
Date: Thu Apr 21 09:58:21 2016
New Revision: 1740270

URL: http://svn.apache.org/viewvc?rev=1740270&view=rev
Log:
Remove TODO

Modified:
tomcat/trunk/java/org/apache/catalina/tribes/transport/ReceiverBase.java

Modified: 
tomcat/trunk/java/org/apache/catalina/tribes/transport/ReceiverBase.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/transport/ReceiverBase.java?rev=1740270&r1=1740269&r2=1740270&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/tribes/transport/ReceiverBase.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/tribes/transport/ReceiverBase.java 
Thu Apr 21 09:58:21 2016
@@ -107,7 +107,6 @@ public abstract class ReceiverBase imple
  * getMessageListener
  *
  * @return MessageListener
- * TODO Implement this org.apache.catalina.tribes.ChannelReceiver method
  */
 @Override
 public MessageListener getMessageListener() {
@@ -117,7 +116,6 @@ public abstract class ReceiverBase imple
 /**
  *
  * @return The port
- * TODO Implement this org.apache.catalina.tribes.ChannelReceiver method
  */
 @Override
 public int getPort() {
@@ -136,7 +134,6 @@ public abstract class ReceiverBase imple
  * setMessageListener
  *
  * @param listener MessageListener
- * TODO Implement this org.apache.catalina.tribes.ChannelReceiver method
  */
 @Override
 public void setMessageListener(MessageListener listener) {



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1740271 - /tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/transport/ReceiverBase.java

2016-04-21 Thread kfujino
Author: kfujino
Date: Thu Apr 21 09:58:49 2016
New Revision: 1740271

URL: http://svn.apache.org/viewvc?rev=1740271&view=rev
Log:
Remove TODO

Modified:

tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/transport/ReceiverBase.java

Modified: 
tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/transport/ReceiverBase.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/transport/ReceiverBase.java?rev=1740271&r1=1740270&r2=1740271&view=diff
==
--- 
tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/transport/ReceiverBase.java
 (original)
+++ 
tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/transport/ReceiverBase.java
 Thu Apr 21 09:58:49 2016
@@ -107,7 +107,6 @@ public abstract class ReceiverBase imple
  * getMessageListener
  *
  * @return MessageListener
- * TODO Implement this org.apache.catalina.tribes.ChannelReceiver method
  */
 @Override
 public MessageListener getMessageListener() {
@@ -117,7 +116,6 @@ public abstract class ReceiverBase imple
 /**
  *
  * @return The port
- * TODO Implement this org.apache.catalina.tribes.ChannelReceiver method
  */
 @Override
 public int getPort() {
@@ -136,7 +134,6 @@ public abstract class ReceiverBase imple
  * setMessageListener
  *
  * @param listener MessageListener
- * TODO Implement this org.apache.catalina.tribes.ChannelReceiver method
  */
 @Override
 public void setMessageListener(MessageListener listener) {



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1740272 - /tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/transport/ReceiverBase.java

2016-04-21 Thread kfujino
Author: kfujino
Date: Thu Apr 21 09:59:46 2016
New Revision: 1740272

URL: http://svn.apache.org/viewvc?rev=1740272&view=rev
Log:
Remove TODO

Modified:

tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/transport/ReceiverBase.java

Modified: 
tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/transport/ReceiverBase.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/transport/ReceiverBase.java?rev=1740272&r1=1740271&r2=1740272&view=diff
==
--- 
tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/transport/ReceiverBase.java
 (original)
+++ 
tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/transport/ReceiverBase.java
 Thu Apr 21 09:59:46 2016
@@ -110,7 +110,6 @@ public abstract class ReceiverBase imple
  * getMessageListener
  *
  * @return MessageListener
- * TODO Implement this org.apache.catalina.tribes.ChannelReceiver method
  */
 @Override
 public MessageListener getMessageListener() {
@@ -120,7 +119,6 @@ public abstract class ReceiverBase imple
 /**
  *
  * @return The port
- * TODO Implement this org.apache.catalina.tribes.ChannelReceiver method
  */
 @Override
 public int getPort() {
@@ -139,7 +137,6 @@ public abstract class ReceiverBase imple
  * setMessageListener
  *
  * @param listener MessageListener
- * TODO Implement this org.apache.catalina.tribes.ChannelReceiver method
  */
 @Override
 public void setMessageListener(MessageListener listener) {



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1740273 - /tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/transport/ReceiverBase.java

2016-04-21 Thread kfujino
Author: kfujino
Date: Thu Apr 21 10:00:17 2016
New Revision: 1740273

URL: http://svn.apache.org/viewvc?rev=1740273&view=rev
Log:
Remove TODO

Modified:

tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/transport/ReceiverBase.java

Modified: 
tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/transport/ReceiverBase.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/transport/ReceiverBase.java?rev=1740273&r1=1740272&r2=1740273&view=diff
==
--- 
tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/transport/ReceiverBase.java
 (original)
+++ 
tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/transport/ReceiverBase.java
 Thu Apr 21 10:00:17 2016
@@ -118,7 +118,6 @@ public abstract class ReceiverBase imple
  * getMessageListener
  *
  * @return MessageListener
- * TODO Implement this org.apache.catalina.tribes.ChannelReceiver method
  */
 @Override
 public MessageListener getMessageListener() {
@@ -128,7 +127,6 @@ public abstract class ReceiverBase imple
 /**
  *
  * @return The port
- * TODO Implement this org.apache.catalina.tribes.ChannelReceiver method
  */
 @Override
 public int getPort() {
@@ -156,7 +154,6 @@ public abstract class ReceiverBase imple
  * setMessageListener
  *
  * @param listener MessageListener
- * TODO Implement this org.apache.catalina.tribes.ChannelReceiver method
  */
 @Override
 public void setMessageListener(MessageListener listener) {



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 59219] AsyncListener#onError not called on exception during async processing

2016-04-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59219

Abdessamed MANSOURI  changed:

   What|Removed |Added

  Attachment #33782|0   |1
is obsolete||

--- Comment #6 from Abdessamed MANSOURI  ---
Created attachment 33783
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=33783&action=edit
Unit test of bug 59219

This unit test checks 2 and 3 points.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 59219] AsyncListener#onError not called on exception during async processing

2016-04-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59219

Abdessamed MANSOURI  changed:

   What|Removed |Added

  Attachment #33783|0   |1
is obsolete||

--- Comment #7 from Abdessamed MANSOURI  ---
Created attachment 33784
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=33784&action=edit
Unit test of bug 59219

Unit test which checks point 2 and 3.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 59365] New: Locale sensitive assertions in TestSsl and TestCustomSsl

2016-04-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59365

Bug ID: 59365
   Summary: Locale sensitive assertions in TestSsl and
TestCustomSsl
   Product: Tomcat 9
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P2
 Component: Connectors
  Assignee: dev@tomcat.apache.org
  Reporter: ebo...@apache.org

The assertions in TestSsl and TestCustomSsl depend on the default locale and
fail on non english systems. The code checks for "Hello World!" in the output,
but on systems with a french locale the output contains "Salut le Monde!"
instead.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 59344] PEM file support for JSSE

2016-04-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59344

--- Comment #1 from Emmanuel Bourg  ---
Created attachment 33788
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=33788&action=edit
PEM support implementation

Here is a patch implementing this feature:
- SSLHostConfigCertificate is modified to accept certificateFile,
certificateChainFile and certificateKeyFile with JSSE
- The HTTP connector documentation is updated accordingly
- A new package private class org.apache.tomcat.util.net.jsse.PEMFile is added
to handle the PEM file parsing and decoding. It supports PKCS#8 private keys
only.
- JSSEUtil.getKeyManagers() is modified to create an in-memory keystore
initialized with the PEM files when the certificateFile is specified.
- TesterSupport is modified to make it possible to initialize SSL with PEM
files even when the APR connector isn't used.
- TestSsl is extended to test SSL with plain text and encrypted keys. It is
missing a test with a certificate chain file to cover all the cases (the test
certificate being self signed it has no intermediary CA).

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: svn commit: r1740047 - in /tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes: group/ group/interceptors/ membership/ transport/ transport/bio/ transport/nio/

2016-04-21 Thread Christopher Schultz
Konstantin,

On 4/20/16 5:15 AM, Konstantin Kolinko wrote:
> 2016-04-20 8:04 GMT+03:00  :
>> Author: kfujino
>> Date: Wed Apr 20 05:04:19 2016
>> New Revision: 1740047
>>
>> URL: http://svn.apache.org/viewvc?rev=1740047&view=rev
>> Log:
>> Change the channel field to protected.
>>
>> Modified:
>> 
>> tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/group/ChannelCoordinator.java
>> 
>> tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/group/ChannelInterceptorBase.java
>> 
>> tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/MessageDispatch15Interceptor.java
>> 
>> tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/MessageDispatchInterceptor.java
>> 
>> tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/TcpPingInterceptor.java
>> 
>> tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/membership/McastService.java
>> 
>> tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/membership/McastServiceImpl.java
>> 
>> tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/transport/ReceiverBase.java
>> 
>> tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/transport/ReplicationTransmitter.java
>> 
>> tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/transport/bio/BioReceiver.java
>> 
>> tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/transport/nio/NioReceiver.java
>>
>> Modified: 
>> tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/group/ChannelCoordinator.java
>> URL: 
>> http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/group/ChannelCoordinator.java?rev=1740047&r1=1740046&r2=1740047&view=diff
>> ==
>> --- 
>> tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/group/ChannelCoordinator.java
>>  (original)
>> +++ 
>> tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/group/ChannelCoordinator.java
>>  Wed Apr 20 05:04:19 2016
>> @@ -144,11 +144,11 @@ public class ChannelCoordinator extends
>>  if ( Channel.SND_RX_SEQ==(svc & Channel.SND_RX_SEQ) ) {
>>  clusterReceiver.setMessageListener(this);
>>  if (clusterReceiver instanceof ReceiverBase) {
>> -
>> ((ReceiverBase)clusterReceiver).setChannel(getChannel());
>> +((ReceiverBase)clusterReceiver).setChannel(channel);
>>  }
>>  clusterReceiver.start();
>>  //synchronize, big time FIXME
>> -Member localMember = getChannel().getLocalMember(false);
>> +Member localMember = channel.getLocalMember(false);
>>  if (localMember instanceof StaticMember) {
>>  // static member
>>  StaticMember staticMember = (StaticMember)localMember;
>> @@ -167,7 +167,7 @@ public class ChannelCoordinator extends
>>  }
>>  if ( Channel.SND_TX_SEQ==(svc & Channel.SND_TX_SEQ) ) {
>>  if (clusterSender instanceof ReplicationTransmitter) {
>> -
>> ((ReplicationTransmitter)clusterSender).setChannel(getChannel());
>> +
>> ((ReplicationTransmitter)clusterSender).setChannel(channel);
>>  }
>>  valid = true;
>>  clusterSender.start();
> 
> []
> 
> 
> What is the reason for this change ?  Are you tying to fix some bug here?
> 
> In general, I do not like this change.
> When the code uses getters it gives us more flexibility in the future,
> allowing to change the implementation.  In ReceiverBase class there
> are a lot of private fields. Why make 'channel' a protected one?

+1 to Konstantin's review. Making channel protected is okay (but might
be unnecessary), but the accessor methods should continue to be used.

-chris

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1740324 - in /tomcat/trunk/test/org/apache/tomcat/util/net: TestCustomSsl.java TestSsl.java

2016-04-21 Thread remm
Author: remm
Date: Thu Apr 21 14:16:24 2016
New Revision: 1740324

URL: http://svn.apache.org/viewvc?rev=1740324&view=rev
Log:
59365: Avoid basing the test on the only portion of the output that is 
internationalized.

Modified:
tomcat/trunk/test/org/apache/tomcat/util/net/TestCustomSsl.java
tomcat/trunk/test/org/apache/tomcat/util/net/TestSsl.java

Modified: tomcat/trunk/test/org/apache/tomcat/util/net/TestCustomSsl.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/tomcat/util/net/TestCustomSsl.java?rev=1740324&r1=1740323&r2=1740324&view=diff
==
--- tomcat/trunk/test/org/apache/tomcat/util/net/TestCustomSsl.java (original)
+++ tomcat/trunk/test/org/apache/tomcat/util/net/TestCustomSsl.java Thu Apr 21 
14:16:24 2016
@@ -82,7 +82,7 @@ public class TestCustomSsl extends Tomca
 tomcat.start();
 ByteChunk res = getUrl("https://localhost:"; + getPort() +
 "/examples/servlets/servlet/HelloWorldExample");
-assertTrue(res.toString().indexOf("Hello World!") > 0);
+assertTrue(res.toString().indexOf("") > 
0);
 }
 
 @Test

Modified: tomcat/trunk/test/org/apache/tomcat/util/net/TestSsl.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/tomcat/util/net/TestSsl.java?rev=1740324&r1=1740323&r2=1740324&view=diff
==
--- tomcat/trunk/test/org/apache/tomcat/util/net/TestSsl.java (original)
+++ tomcat/trunk/test/org/apache/tomcat/util/net/TestSsl.java Thu Apr 21 
14:16:24 2016
@@ -66,7 +66,7 @@ public class TestSsl extends TomcatBaseT
 tomcat.start();
 ByteChunk res = getUrl("https://localhost:"; + getPort() +
 "/examples/servlets/servlet/HelloWorldExample");
-assertTrue(res.toString().indexOf("Hello World!") > 0);
+assertTrue(res.toString().indexOf("") > 
0);
 }
 
 @Test
@@ -86,7 +86,7 @@ public class TestSsl extends TomcatBaseT
 tomcat.start();
 ByteChunk res = getUrl("https://localhost:"; + getPort() +
 "/examples/servlets/servlet/HelloWorldExample");
-assertTrue(res.toString().indexOf("Hello World!") > 0);
+assertTrue(res.toString().indexOf("") > 
0);
 }
 
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1740325 - in /tomcat/tc8.5.x/trunk: ./ test/org/apache/tomcat/util/net/TestCustomSsl.java test/org/apache/tomcat/util/net/TestSsl.java

2016-04-21 Thread remm
Author: remm
Date: Thu Apr 21 14:18:04 2016
New Revision: 1740325

URL: http://svn.apache.org/viewvc?rev=1740325&view=rev
Log:
59365: Avoid basing the test on the only portion of the output that is 
internationalized.

Modified:
tomcat/tc8.5.x/trunk/   (props changed)
tomcat/tc8.5.x/trunk/test/org/apache/tomcat/util/net/TestCustomSsl.java
tomcat/tc8.5.x/trunk/test/org/apache/tomcat/util/net/TestSsl.java

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Thu Apr 21 14:18:04 2016
@@ -1 +1 @@
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131
+/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324

Modified: 
tomcat/tc8.5.x/trunk/test/org/apache/tomcat/util/net/TestCustomSsl.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/test/org/apache/tomcat/util/net/TestCustomSsl.java?rev=1740325&r1=1740324&r2=1740325&view=diff
==
--- tomcat/tc8.5.x/trunk/test/org/apache/tomcat/util/net/TestCustomSsl.java 
(original)
+++ tomcat/tc8.5.x/trunk/test/org/apache/tomcat/util/net/TestCustomSsl.java Thu 
Apr 21 14:18:04 2016
@@ -82,7 +82,7 @@ public class TestCustomSsl extends Tomca
 tomcat.start();
 ByteChunk res = getUrl("https://localhost:"; + getPort() +
 "/examples/servlets/servlet/HelloWorldExample");
-assertTrue(res.toString().indexOf("Hello World!") > 0);
+assertTrue(res.toString().indexOf("") > 
0);
 }
 
 @Test

Modified: tomcat/tc8.5.x/trunk/test/org/apache/tomcat/util/net/TestSsl.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/test/org/apache/tomcat/util/net/TestSsl.java?rev=1740325&r1=1740324&r2=1740325&view=diff
==
--- tomcat/tc8.5.x/trunk/test/org/apache/tomcat/util/net/TestSsl.java (original)
+++ tomcat/tc8.5.x/trunk/test/org/apache/tomcat/util/net/TestSsl.java Thu Apr 
21 14:18:04 2016
@@ -66,7 +66,7 @@ public class TestSsl extends TomcatBaseT
 tomcat.start();
 ByteChunk res = getUrl("https://localhost:"; + getPort() +
 "/examples/servlets/servlet/HelloWorldExample");
-assertTrue(res.toString().indexOf("Hello World!") > 0);
+assertTrue(res.toString().indexOf("") > 
0);
 }
 
 @Test
@@ -86,7 +86,7 @@ public class TestSsl extends TomcatBaseT
 tomcat.start();
 ByteChunk res = getUrl("https://localhost:"; + getPort() +
 "/examples/servlets/servlet/HelloWorldExample");
-assertTrue(res.toString().indexOf("Hello World!") > 0);
+assertTrue(res.toString().indexOf("") > 
0);
 }
 
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1740326 - in /tomcat/tc8.0.x/trunk: ./ test/org/apache/tomcat/util/net/TestCustomSsl.java test/org/apache/tomcat/util/net/TestSsl.java

2016-04-21 Thread remm
Author: remm
Date: Thu Apr 21 14:18:45 2016
New Revision: 1740326

URL: http://svn.apache.org/viewvc?rev=1740326&view=rev
Log:
59365: Avoid basing the test on the only portion of the output that is 
internationalized.

Modified:
tomcat/tc8.0.x/trunk/   (props changed)
tomcat/tc8.0.x/trunk/test/org/apache/tomcat/util/net/TestCustomSsl.java
tomcat/tc8.0.x/trunk/test/org/apache/tomcat/util/net/TestSsl.java

Propchange: tomcat/tc8.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Thu Apr 21 14:18:45 2016
@@ -1,2 +1,2 @@
 /tomcat/tc8.5.x/trunk:1735042,1737966
-/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1637890,1637892,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886
 
,1644890,1644892,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1649973,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654513,1654515,1654517,1654522,1654524,1654725,1654735,1654766,1654785,1654851-1654852,1654978,1655122-1655124,1655126-1655127,1655129-1655130,1655132-1655133,1655312,1655351,1655438,1655441,1655454,168,1656087,1656299,1656319,1656331,1656345,1656350,1656590,1656648-1656650,1656657,1657041,1657054,1657374,1657492,1657510,1657565,1657580,1657584,1657586,1657589,1657
 
592,1657607,1657609,1657682,1657907,1658207,1658734,1658781,1658790,1658799,1658802,1658804,1658833,1658840,1658966,1659043,1659053,1659059,1659174,1659184,1659188-1659189,1659216,1659263,1659293,1659304,1659306-1659307,1659382,1659384,1659428,1659471,1659486,1659505,1659516,1659521,1659524,1659559,1659562,1659803,1659806,1659814,1659833,1659862,1659905,1659919,1659948,1659967,1659983-1659984,1660060,1660074,1660077,1660133,1660168,1660331-1660332,1660353,1660358,1660924,1661386,1661770,1661867,1661972,1661990,1662200,1662308-1662309,1662548,1662614,1662696,1662736,1662985,1662988-1662989,1663264,1663277,1663298,1663534,1663562,1663676,1663715,1663754,1663768,1663772,1663781,1663893,1663995,1664143,1664163,1664174,1664301,1664317,1664347,1664657,1664659,1664710,1664863-1664864,1664866,1665085,1665292,1665559,1665653,1665661,1665672,1665694,1665697,1665736,1665779,1665976-1665977,1665980-1665981,1665985-1665986,1665989,1665998,1666004,1666008,1666013,1666017,1666024,1666116,1666386-1
 
666387,1666494,1666496,1666552,1666569,1666579,137,149,1666757,1666966,1666972,1666985,1666995,1666997,1667292,1667402,1667406,1667546,1667615,1667630,1667636,1667688,1667764,1667871,1668026,1668135,1668193,1668593,1668596,1668630,1668639,1668843,1669353,1669370,1669451,1669800,1669838,1669876,1669882,1670394,1670433,1670591,1670598-1670600,1670610,1670631,1670719,1670724,1670726,1670730,1670940,1671112,1672272,1672284,1673754,1674294,1675461,1675486,1675594,1675830,1676231,1676250-1676251,1676364,1676381,1676393,1676479,1676525,1676552,1676615,1676630,1676634,1676721,1676926,1676943,1677140,1677802,1678011,1678162,1678174,1678339,1678426-1678427,1678694,1678701,1679534,1679708,1679710,1679716,1680034,1680246,1681056,1681123,1681138,1681280,1681283,1681286,1681450,1681697,1681699,1681701,1681729,1681770,1681779,1681793,1681807,1681837-1681838,1681854,1681862,1681958,1682028,1682033,1682311,1682315,1682317,1682320,1682324,1682330,1682842,1684172,1684366,1684383,1684526-168452
 
7,1684549-1684550,1685556,1685591,1685739,1685744,1685772,1685816,1685826,1685891,1687242,1687261,1687268,1687340,1687544,1687551,1688563,1688841,1688878,165,1688896,1688901,1689345-1689346,1689357,1689656,1689675-1689677,1689679,1689687,1689825,1689856,1689918,1690011,1690021,1690054,1690080,1690209,1691134,1691487,1691813,1692744-

svn commit: r1740327 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/tomcat/util/net/TestCustomSsl.java test/org/apache/tomcat/util/net/TestSsl.java

2016-04-21 Thread remm
Author: remm
Date: Thu Apr 21 14:19:17 2016
New Revision: 1740327

URL: http://svn.apache.org/viewvc?rev=1740327&view=rev
Log:
59365: Avoid basing the test on the only portion of the output that is 
internationalized.

Modified:
tomcat/tc7.0.x/trunk/   (props changed)
tomcat/tc7.0.x/trunk/test/org/apache/tomcat/util/net/TestCustomSsl.java
tomcat/tc7.0.x/trunk/test/org/apache/tomcat/util/net/TestSsl.java

Propchange: tomcat/tc7.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Thu Apr 21 14:19:17 2016
@@ -1,3 +1,3 @@
 
/tomcat/tc8.0.x/trunk:1636525,1637336,1637685,1637709,1638726,1640089,1640276,1640349,1640363,1640366,1640642,1640672,1640674,1640689,1640884,1641001,1641065,1641067,1641375,1641638,1641723,1641726,1641729-1641730,1641736,1641988,1642669-1642670,1642698,1642701,1643205,1643215,1643217,1643230,1643232,1643273,1643285,1643329-1643330,1643511,1643513,1643521,1643539,1643571,1643581-1643582,1643635,1643655,1643738,1643964,1644018,1644333,1644954,1644992,1645014,1645360,1645456,1645627,1645642,1645686,1645903-1645904,1645908-1645909,1645913,1645920,1646458,1646460-1646462,1646735,1646738-1646741,1646744,1646746,1646748-1646755,1646757,1646759-1646760,1647043,1648816,1651420-1651422,1651844,1652926,1652939-1652940,1652973,1653798,1653817,1653841,1654042,1654161,1654736,1654767,1654787,1656592,1659907,1662986,1663265,1663278,1663325,1663535,1663567,1663679,1663997,1664175,1664321,1664872,1665061,1665086,1666027,1666395,1666503,1666506,1666560,1666570,1666581,1666759,1666967,1666988,1667553
 
-1667555,1667558,1667617,1667633,1667637,1667747,1667767,1667873,1668028,1668137,1668634,1669432,1669801,1669840,1669895-1669896,1670398,1670435,1670592,1670605-1670607,1670609,1670632,1670720,1670725,1670727,1670731,1671114,1672273,1672285,1673759,1674220,1674295,1675469,1675488,1675595,1675831,1676232,1676367-1676369,1676382,1676394,1676483,1676556,1676635,1678178,1679536,1679988,1680256,1681124,1681182,1681730,1681840,1681864,1681869,1682010,1682034,1682047,1682052-1682053,1682062,1682064,1682070,1682312,1682325,1682331,1682386,1684367,1684385,1685759,1685774,1685827,1685892,1687341,1688904,1689358,1689657,1689921,1692850,1693093,1693108,1693324,1694060,1694115,1694291,1694427,1694431,1694503,1694549,1694789,1694873,1694881,1695356,1695372,1695823-1695825,1696200,1696281,1696379,1696468,1700608,1700871,1700897,1700978,1701094,1701124,1701608,1701668,1701676,1701766,1701944,1702248,1702252,1702314,1702390,1702723,1702725,1702728,1702730,1702733,1702735,1702737,1702739,1702742,1702
 
744,1702748,1702751,1702754,1702758,1702760,1702763,1702766,1708779,1708782,1708806,1709314,1709670,1710347,1710442,1710448,1710490,1710574,1710578,1712226,1712229,1712235,1712255,1712618,1712649,1712655,1712860,1712899,1712903,1712906,1712913,1712926,1712975,1713185,1713262,1713287,1713613,1713621,1713872,1713976,1713994,1713998,1714004,1714013,1714059,1714538,1714580,1715189,1715207,1715544,1715549,1715637,1715639-1715645,1715667,1715683,1715866,1715978,1715981,1716216-1716217,1716355,1716414,1716421,1717208-1717209,1717257,1717283,1717288,1717291,1717421,1717517,1717529,1718797,1718840-1718843,1719348,1719357-1719358,1719400,1719491,1719737,1720235,1720396,1720442,1720446,1720450,1720463,1720658-1720660,1720756,1720816,1721813,1721818,1721831,1721861,1721867,1721882,1722523,1722527,1722800,1722926,1722941,1722997,1723130,1723440,1723488,1723890,1724434,1724674,1724792,1724803,1724902,1725128,1725131,1725154,1725167,1725911,1725921,1725929,1725963-1725965,1725970,1725974,1726171-1
 
726173,1726175,1726179-1726182,1726190-1726191,1726195-1726200,1726203,1726226,1726576,1726630,1726992,1727029,1727037,1727671,1727676,1727900,1728028,1728092,1728439,1728449,1729186,1729362,1731009,1731303,1731867,1731872,1731874,1731876,1731885,1731947,1731955,1731959,1731977,1731984,1732360,1732490,1732672,1732902,1733166,1733603,1733619,1733735,1733752,1733764,1733915,1733941,1733964,1734115,1734133,1734261,1734421,1734531,1736286,1737967,1738173,1738182,1738992,1739039,1739089-1739091,1739294,1739777,1739821,1739981
 
/tomcat/tc8.5.x/trunk:1735579,1736839,1737199,1737966,1738042,1738044,1738162,1738165,1738178,1739157,1739173,1739177,1739476,1740132
-/tomcat/trunk:1156115-1157160,1157162-1157859,1157862-1157942,1157945-1160347,1160349-1163716,1163718-1166689,1166691-1174340,1174342-1175596,1175598-1175611,1175613-1175932,1175934-1177783,1177785-1177980,1178006-1180720,1180722-1183094,1183096-1187753,1187755,1187775,1187801,1187806,1187809,1187826-1188312,1188314-1188401,1188646-1188840,1188842-1190176,1190178-1195223,1195225-1195953,1195955,1195957-1201238,1201240-1203345,1203347-1206623,1206625-1208046,1208073,1208096,1208114,1208145,1208772,1209194-1212125,1212127-1220291,1220293,1220295-1221321,1221323-1222329,1222332-1222401,1222405-1222795,1222850-1222950,1222969-1225326,1225328-1225463,1225465,1225627,1225629-1226534,1226536-1228908,1228911-12

[Bug 59365] Locale sensitive assertions in TestSsl and TestCustomSsl

2016-04-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59365

Remy Maucherat  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #1 from Remy Maucherat  ---
That was unfortunate since it's the only portion of the Servlet output that is
internationalized. It will be fixed in the next 9M5 build, although I'm not
adding it to the changelog since the impact is so minimal.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 59344] PEM file support for JSSE

2016-04-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59344

Emmanuel Bourg  changed:

   What|Removed |Added

  Attachment #33788|0   |1
is obsolete||

--- Comment #3 from Emmanuel Bourg  ---
Created attachment 33789
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=33789&action=edit
PEM support implementation

Updated TestSsl to match the changes made in r1740324.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 59344] PEM file support for JSSE

2016-04-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59344

--- Comment #2 from Remy Maucherat  ---
Oh ok, that was unexpected. I'm a bit sceptical about the usefulness since JSSE
is mostly useless in 9 (no ALPN), but if it works, why not.

About the documentation, more changes are needed and it shouldn't be changed
this way. I would like to keep the two configuration types clearly separate, so
a host configuration should use either OpenSSL or JSSE configuration types, but
not a mix of both.

Note: you apparently missed the possibility to use JSSE with OpenSSL, which is
basically the recommended setup now. It supports both JSSE and OpenSSL
configuration types.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 59365] Locale sensitive assertions in TestSsl and TestCustomSsl

2016-04-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59365

Emmanuel Bourg  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

--- Comment #2 from Emmanuel Bourg  ---
Thank you for the quick fix.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 59344] PEM file support for JSSE

2016-04-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59344

--- Comment #4 from Emmanuel Bourg  ---
Thank you for the review Remy. My use case is mostly for HTTP/1.1, I agree this
feature is less interesting for HTTP/2, until Java 9 is available and supports
ALPN I guess.

The patch supports a configuration like this one:

  

  

  

That's similar to the parameters accepted for the HTTP/2 connector. Are you
suggesting a different set of parameters for this case?

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 59344] PEM file support for JSSE

2016-04-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59344

--- Comment #5 from Remy Maucherat  ---
Unless you have a tomcat-native phobia, I think you should just install it.
Then Tomcat will use OpenSSL and you would be better off than with JSSE.

I'm quite sure you didn't try it since your testsuite changes break that.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 59365] Locale sensitive assertions in TestSsl and TestCustomSsl

2016-04-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59365

Konstantin Kolinko  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|VERIFIED|REOPENED

--- Comment #3 from Konstantin Kolinko  ---
Searching for HelloWorldExample in test/**/*.java, there are other occurrences
of such checks,  including TestTomcat.testSingleWebapp() which is present in
all versions down to Tomcat 6.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 59344] PEM file support for JSSE

2016-04-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59344

--- Comment #6 from Emmanuel Bourg  ---
Indeed, I've never had the need for tomcat-native so far. I'm going to check
the regression with OpenSSL.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 59344] PEM file support for JSSE

2016-04-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59344

--- Comment #7 from Remy Maucherat  ---
It's only a testsuite issue, so I'll look it up eventually. Otherwise the patch
interacts properly with the OpenSSL support.

To run the tests with OpenSSL, you can add this in build.properties:
test.sslImplementation=org.apache.tomcat.util.net.openssl.OpenSSLImplementation

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 59344] PEM file support for JSSE

2016-04-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59344

--- Comment #8 from Emmanuel Bourg  ---
On Windows 7 I copied openssl.exe in the base directory and tcnative-1.dll into
bin/native and then ran:

   ant test-apr -Dtest.openssl.path=openssl.exe -Dtest.name=**/*Ssl*

and the tests passed.

With:

   ant test-nio -Dtest.openssl.path=openssl.exe
-Dtest.sslImplementation=org.apache.tomcat.util.net.openssl.OpenSSLIm
plementation -Dtest.name=**/*Ssl*

I get a SSLException "Error initializing SSL context" caused by "Invalid Server
SSL Protocol (error:140A90F1:SSL routines:SSL_CTX_new:unable to load ssl2 md5
routines)". Is this the error you encountered?

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 59344] PEM file support for JSSE

2016-04-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59344

--- Comment #9 from Remy Maucherat  ---
Yes, that's the test error.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 59219] AsyncListener#onError not called on exception during async processing

2016-04-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59219

--- Comment #8 from Mark Thomas  ---
Thanks for the patch. It is being looked at. Currently I'm seeing odd behaviour
on Windows so I want to test it on another platform.

I do have some basic feedback at this point. Expect some more when once I have
test test working:
1. Use separate methods for separate tests. It makes it easier to determine
which tests are failing.
2. We aim to keep the code warning free. If you use Eclipse, checkout the
configuration settings we use under res/ide-support/eclipse
3. It looks like you should be able to re-use the existing tracking listener.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 59219] AsyncListener#onError not called on exception during async processing

2016-04-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59219

--- Comment #9 from Mark Thomas  ---
And some more:
4. The wait loop logic is wrong.
   - It will always wait 5s even if the output is correct
   - If output in incorrect it will enter an infinite loop
5. It is clearer to define an explicit Wrapper insatnce and then call
   setAsyncSupported(true) on that.
6. The test doesn't pass. This actually highlights a bug in the fix (regression
   in the fix for point 2 when the fix for point 3 was made) which just goes to
   demonstrate the usefulness of test cases.

I have all this fixed locally but I think it would be useful for you to try and
fix these issues yourself.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 59344] PEM file support for JSSE

2016-04-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59344

Emmanuel Bourg  changed:

   What|Removed |Added

  Attachment #33789|0   |1
is obsolete||

--- Comment #10 from Emmanuel Bourg  ---
Created attachment 33792
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=33792&action=edit
PEM support implementation

TesterSupport.initSslWithPEM() now sets the sslImplementationName connector
attribute when the test.sslImplementation property is set. This fixes the
exception with the testSimpleSslWith*PEM() tests.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Interest in splitting-off SSLSocketFactory customizers?

2016-04-21 Thread Christopher Schultz
All,

Bump

Thanks,
-chris

On 4/10/16 4:08 PM, Christopher Schultz wrote:
> All,
> 
> Lately, I've found myself re-writing the same code to customize an
> SSLSocketFactory for a variety of clients I've been writing. Of course,
> I have, at this point, written a re-usable library that I generally use,
> but when I want to give-away the code to someone else, it's a little
> nicer to have it all in one package, etc. and not have too much hidden
> in a separate library.
> 
> This week, I'm looking at adding cipher-suite blacklisting (e.g. "never
> use MD5") and I started thinking about Tomcat's OpenSSL-style cipher
> suite parsing code.
> 
> I'm starting to think that, much like the Digester, this code would be
> very useful to anyone writing a Java application that needs to customize
> TLS connections.
> 
> Is anyone else (also) interested in possibly spinning-off Tomcat's
> SSLSocketFactory management code into a separate library? Basically, I
> was thinking that we could consolidate Tomcat's code (which is already
> pretty segregated) that handles the following operations:
> 
> - trust managers
> - key managers
> - CRLs
> - protocol selection (actually enabling/disabling SSLv3, TLSv1, TLSv1.1,
> etc.)
> - cipher suite selection
> - anything else?
> 
> Since we are now supporting JSSE+OpenSSL, that could even be bundled in
> there, so clients could request OpenSSL-backed crypto if they want.
> 
> In my case, I'm particularly interested in supporting clients
> (SSLSocketFactory), but certainly supporting servers
> (SSLServerSocketFactory) makes a lot of sense, too, since a lot of the
> code is the same ... just slightly different plumbing.
> 
> Ultimately, I was going to suggest a fairly simple public API like this:
> 
> public class SocketFactoryBuilder {
>   public SSLSocketFactory createClientFactory([supported protocols],
> [cipher suite specs], [client cert store / client cert spec], [crl],
> [hostname verifier]);
> 
>   public SSLServerSocketFactory createServerFactory([supported
> protocols], [cipher suite specs], [server keystore], [client trust store]);
> }
> 
> There are many ways one might want to specify the various stores (e.g.
> filename, InputStream, etc.) so those might be overloaded to support
> various combinations of things for convenience.
> 
> Any thoughts?
> 
> -chris
> 



signature.asc
Description: OpenPGP digital signature


Re: Interest in splitting-off SSLSocketFactory customizers?

2016-04-21 Thread Rémy Maucherat
2016-04-21 21:49 GMT+02:00 Christopher Schultz :

> All,
>
> Bump
>
> Not interested :)

Rémy


[Bug 55554] NoSuchMethodError on ConcurrentHashMap$KeySetView

2016-04-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=4

--- Comment #4 from romain.manni-bucau  ---
Just a quick note if anyone encounters it again: some rpm of tomcat are created
recompiling tomcat and I let you guess what can happen in such a process: a JDK
8 can be used. Typically the one of Feb 22 has this manifest:

Manifest-Version: 1.0
Ant-Version: Apache Ant 1.9.6
Created-By: 1.8.0_72-b15 (Oracle Corporation)
Specification-Title: Apache Tomcat
Specification-Version: 8.0
Specification-Vendor: Apache Software Foundation
Implementation-Title: Apache Tomcat
Implementation-Version: 8.0.32
Implementation-Vendor: Apache Software Foundation
X-Compile-Source-JDK: 1.7
X-Compile-Target-JDK: 1.7

Which can justifies this error.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GUMP@vmgump]: Project tomcat-tc8.0.x-test-apr (in module tomcat-8.0.x) failed

2016-04-21 Thread Bill Barker
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-tc8.0.x-test-apr has an issue affecting its community 
integration.
This issue affects 1 projects,
 and has been outstanding for 17 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-tc8.0.x-test-apr :  Tomcat 8.x, a web server implementing the Java 
Servlet 3.1,
...


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-8.0.x/tomcat-tc8.0.x-test-apr/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
commons-daemon.native.src.tgz.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
tomcat-native.tar.gz.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-8.0.x/output/logs-APR
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-8.0.x/output/test-tmp-APR/logs
 -WARNING- No directory 
[/srv/gump/public/workspace/tomcat-8.0.x/output/test-tmp-APR/logs]



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-8.0.x/tomcat-tc8.0.x-test-apr/gump_work/build_tomcat-8.0.x_tomcat-tc8.0.x-test-apr.html
Work Name: build_tomcat-8.0.x_tomcat-tc8.0.x-test-apr (Type: Build)
Work ended in a state of : Failed
Elapsed: 38 mins 18 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.3-SNAPSHOT.jar
 -Dtest.reports=output/logs-APR 
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20160422-native-src.tar.gz
 -Dexamples.sources.skip=true 
-Dbase.path=/srv/gump/public/workspace/tomcat-8.0.x/tomcat-build-libs 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.5-201506032000/ecj-4.5.jar 
-Dtest.apr.loc=/srv/gump/public/workspace/tomcat-native-12/dest-20160422/lib 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20160422.jar
 
-Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20160422-native-src.tar.gz
 -Dtest.temp=
 output/test-tmp-APR -Dtest.accesslog=true -Dexecute.test.nio=false 
-Dtest.openssl.path=/srv/gump/public/workspace/openssl-1.0.2/dest-20160422/bin/openssl
 -Dexecute.test.bio=false -Dexecute.test.apr=true 
-Dtest.excludePerformance=true -Dexecute.test.nio2=false 
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-3.5-SNAPSHOT.jar
 -Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar 
-Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-8.0.x]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-8.0.x/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/servlet-api.ja
 
r:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina-tribes.jar:/srv/gump/public/works

[GUMP@vmgump]: Project tomcat-tc8.0.x-test-nio (in module tomcat-8.0.x) failed

2016-04-21 Thread Bill Barker
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-tc8.0.x-test-nio has an issue affecting its community 
integration.
This issue affects 1 projects,
 and has been outstanding for 17 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-tc8.0.x-test-nio :  Tomcat 8.x, a web server implementing the Java 
Servlet 3.1,
...


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-8.0.x/tomcat-tc8.0.x-test-nio/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
commons-daemon.native.src.tgz.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
tomcat-native.tar.gz.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-8.0.x/output/logs-NIO
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-8.0.x/output/test-tmp-NIO/logs
 -WARNING- No directory 
[/srv/gump/public/workspace/tomcat-8.0.x/output/test-tmp-NIO/logs]



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-8.0.x/tomcat-tc8.0.x-test-nio/gump_work/build_tomcat-8.0.x_tomcat-tc8.0.x-test-nio.html
Work Name: build_tomcat-8.0.x_tomcat-tc8.0.x-test-nio (Type: Build)
Work ended in a state of : Failed
Elapsed: 39 mins 32 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.3-SNAPSHOT.jar
 -Dtest.reports=output/logs-NIO 
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20160422-native-src.tar.gz
 -Dexamples.sources.skip=true 
-Dbase.path=/srv/gump/public/workspace/tomcat-8.0.x/tomcat-build-libs 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.5-201506032000/ecj-4.5.jar 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20160422.jar
 
-Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20160422-native-src.tar.gz
 -Dtest.temp=output/test-tmp-NIO -Dtest.accesslog=true -Dexecute.test.nio=true 
-Dtest.open
 ssl.path=/srv/gump/public/workspace/openssl-1.0.2/dest-20160422/bin/openssl 
-Dexecute.test.bio=false -Dexecute.test.apr=false 
-Dtest.excludePerformance=true -Dexecute.test.nio2=false 
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-3.5-SNAPSHOT.jar
 -Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar 
-Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-8.0.x]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-8.0.x/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/servlet-api.ja
 
r:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/