https://bz.apache.org/bugzilla/show_bug.cgi?id=59219

--- Comment #9 from Mark Thomas <ma...@apache.org> ---
And some more:
4. The wait loop logic is wrong.
   - It will always wait 5s even if the output is correct
   - If output in incorrect it will enter an infinite loop
5. It is clearer to define an explicit Wrapper insatnce and then call
   setAsyncSupported(true) on that.
6. The test doesn't pass. This actually highlights a bug in the fix (regression
   in the fix for point 2 when the fix for point 3 was made) which just goes to
   demonstrate the usefulness of test cases.

I have all this fixed locally but I think it would be useful for you to try and
fix these issues yourself.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to