Re: Files to exclude from buildbot rat tests
2016-02-16 0:15 GMT+03:00 Mark Thomas : > On 15/02/2016 08:04, Gav wrote: >> HI All, >> >> markt has added some exclusions recently that are preventing a successful >> rat run on buildbot. > > Huh? You told me it was failing and asked me to exclude some files. > >> (More accurately the xml file produced is malformed due to inclusions of >> bad headers) >> >> Here are what I can see as the remaining invalid files; adding these to the >> rat-excludes file should enable a succesful run for tomcat 7,8 and trunk >> (9). >> >> >> tomcat-7-trunk - output/dist/src/res/side_left.bmp > > Added **/*.bmp > >> tomcat-7-trunk - >> output/dist/src/webapps/docs/tribes/leader-election-message-arrives.dia > > Added **/*.dia > >> tomcat-trunk - output/dist/side_left.bmp > > Already excluded but I extended to to **/*.bmp Re: http://svn.apache.org/viewvc?rev=1730614&view=rev 1. Only Tomcat 7 and Tomcat 9 configurations were updated, but not Tomcat 8. 2. I see that the "**/*.bmp" pattern does work. (I feared that it does not.) As such, our rat-excludes.txt files can be simplified a lot. 3. Steps to reproduce the original problem: I do not see any failures being reported by Buildbot ([1] -> tomcat-trunk -> build number -> "shell_5 RAT Report Complete" step) neither before nor after the change, but the issue that Gav reported here can be observed manually by the following steps: - Go to http://tomcat.apache.org/ci.html#Buildbot [1] -> "Published files" link - Download rat-output.xml - Try to open it in a web browser (or XML editor). The file is malformed. - If you view through the file, there are some blocks of binary data - For Tomcat 9 those binary blocks are header samples from *.dia files, e.g. [[[ ]]] For Tomcat 8 there are samples from *.bmp files as well. The rat-output.xml file for Tomcat 9 does not have string ".bmp" in it, but Tomcat 8 one has it. So the exclusion pattern **/*.bmp used in Tomcat 9 works successfully. [1] http://tomcat.apache.org/ci.html#Buildbot Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1730647 - /tomcat/trunk/res/rat/rat-excludes.txt
Author: kkolinko Date: Tue Feb 16 09:58:42 2016 New Revision: 1730647 URL: http://svn.apache.org/viewvc?rev=1730647&view=rev Log: Update and simplify rat-excludes.txt file, used by RAT report generation at ASF Buildbot. Modified: tomcat/trunk/res/rat/rat-excludes.txt Modified: tomcat/trunk/res/rat/rat-excludes.txt URL: http://svn.apache.org/viewvc/tomcat/trunk/res/rat/rat-excludes.txt?rev=1730647&r1=1730646&r2=1730647&view=diff == --- tomcat/trunk/res/rat/rat-excludes.txt (original) +++ tomcat/trunk/res/rat/rat-excludes.txt Tue Feb 16 09:58:42 2016 @@ -15,15 +15,17 @@ This is excludes file for Apache RAT tool run by ASF Buildbot, - http://incubator.apache.org/rat/ + http://creadur.apache.org/rat/ The following files are excluded: + - log files and other temporary files generated during testing + - *.html files in documentation are generated from XML sources - - *.md5 files are generated and cannot contain license + - *.md5, *.sha/*.sha1 files are generated and cannot contain license - - *.manifest JAR manifest files cannot contain license + - *.manifest, MANIFEST.MF JAR manifest files cannot contain license - package-list and script.js files in API documentation (javadoc) are generated @@ -35,8 +37,6 @@ - local build configuration files - - *.mdl are Rational Rose data files and cannot contain comments - - file fragments that are combined during the build process and therefore can not contain a license header in every fragment @@ -47,46 +47,23 @@ - files used simply to ensure directories are not empty - - *.bmp files + - *.mdl are Rational Rose data files and cannot contain comments + - *.bmp, *.dia files are binary + +output/build/logs/* -output/build/webapps/docs/*.html -output/build/webapps/docs/appdev/*.html -output/build/webapps/docs/architecture/*.html -output/build/webapps/docs/config/*.html -output/build/webapps/docs/funcspecs/*.html -output/build/webapps/docs/tribes/*.html +output/build/webapps/docs/**/*.html +output/dist/webapps/docs/**/*.html output/deployer/deployer-howto.html -output/dist/webapps/docs/*.html -output/dist/webapps/docs/appdev/*.html -output/dist/webapps/docs/architecture/*.html -output/dist/webapps/docs/config/*.html -output/dist/webapps/docs/funcspecs/*.html -output/dist/webapps/docs/tribes/*.html - -output/embed/*.md5 -output/extras/*.md5 -output/release/v9.0.0-dev/bin/*.md5 -output/release/v9.0.0-dev/bin/embed/*.md5 -output/release/v9.0.0-dev/bin/extras/*.md5 -output/release/v9.0.0-dev/src/*.md5 - -modules/jdbc-pool/resources/MANIFEST.MF -output/dist/src/modules/jdbc-pool/resources/MANIFEST.MF -output/dist/src/res/META-INF/*.manifest -output/jdbc-pool/resources/MANIFEST.MF -output/manifests/*.manifest -res/META-INF/*.manifest - -output/dist/webapps/docs/api/package-list -output/dist/webapps/docs/api/script.js -output/dist/webapps/docs/elapi/package-list -output/dist/webapps/docs/elapi/script.js -output/dist/webapps/docs/jspapi/package-list -output/dist/webapps/docs/jspapi/script.js -output/dist/webapps/docs/servletapi/package-list -output/dist/webapps/docs/servletapi/script.js -output/dist/webapps/docs/websocketapi/package-list -output/dist/webapps/docs/websocketapi/script.js + +**/*.md5 +**/*.sha1 + +**/MANIFEST.MF +**/*.manifest + +output/dist/webapps/docs/*/package-list +output/dist/webapps/docs/*/script.js output/dist/src/test/webapp/bug53257/*.txt output/dist/src/test/webapp/bug53257/foo bar/foobar.txt @@ -101,18 +78,10 @@ test/webresources/dir1/d1/d1-f1.txt test/webresources/dir1/d2/d2-f1.txt test/webresources/dir1/*.txt -webapps/examples/WEB-INF/classes/websocket/echo/servers.json -output/build/webapps/examples/WEB-INF/classes/websocket/echo/servers.json -output/dist/src/webapps/examples/WEB-INF/classes/websocket/echo/servers.json -output/dist/webapps/examples/WEB-INF/classes/websocket/echo/servers.json +**/*.json build.properties -output/build/webapps/docs/architecture/requestProcess/roseModel.mdl -output/dist/src/webapps/docs/architecture/requestProcess/roseModel.mdl -output/dist/webapps/docs/architecture/requestProcess/roseModel.mdl -webapps/docs/architecture/requestProcess/roseModel.mdl - output/dist/confinstall/tomcat-users_2.xml output/dist/src/res/confinstall/tomcat-users_2.xml res/confinstall/tomcat-users_2.xml @@ -186,4 +155,6 @@ res/checkstyle/header-al2.txt output/dist/temp/safeToDelete.tmp +**/*.mdl **/*.bmp +**/*.dia - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1730649 - /tomcat/trunk/res/rat/rat-excludes.txt
Author: kkolinko Date: Tue Feb 16 10:29:51 2016 New Revision: 1730649 URL: http://svn.apache.org/viewvc?rev=1730649&view=rev Log: Exclusion of *.dia files was successful. Exclusion of output/build/logs/** was not successful. Try a different pattern. Modified: tomcat/trunk/res/rat/rat-excludes.txt Modified: tomcat/trunk/res/rat/rat-excludes.txt URL: http://svn.apache.org/viewvc/tomcat/trunk/res/rat/rat-excludes.txt?rev=1730649&r1=1730648&r2=1730649&view=diff == --- tomcat/trunk/res/rat/rat-excludes.txt (original) +++ tomcat/trunk/res/rat/rat-excludes.txt Tue Feb 16 10:29:51 2016 @@ -50,7 +50,7 @@ - *.mdl are Rational Rose data files and cannot contain comments - *.bmp, *.dia files are binary -output/build/logs/* +output/build/logs/*.txt output/build/webapps/docs/**/*.html output/dist/webapps/docs/**/*.html - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1730653 - /tomcat/trunk/res/rat/rat-excludes.txt
Author: kkolinko Date: Tue Feb 16 10:49:28 2016 New Revision: 1730653 URL: http://svn.apache.org/viewvc?rev=1730653&view=rev Log: Revert r1730649. I think it is not needed. The rat-output.html file for the build before r1730649 was generated after some delay (~20 minutes) and does not have those /log/*.txt files. Add a comment about *.git etc. image files, that do not need configuration. Modified: tomcat/trunk/res/rat/rat-excludes.txt Modified: tomcat/trunk/res/rat/rat-excludes.txt URL: http://svn.apache.org/viewvc/tomcat/trunk/res/rat/rat-excludes.txt?rev=1730653&r1=1730652&r2=1730653&view=diff == --- tomcat/trunk/res/rat/rat-excludes.txt (original) +++ tomcat/trunk/res/rat/rat-excludes.txt Tue Feb 16 10:49:28 2016 @@ -49,8 +49,10 @@ - *.mdl are Rational Rose data files and cannot contain comments - *.bmp, *.dia files are binary +(*.git, *.jpg are also binary, but are automatically detected by RAT as +ones, so no explicit configuration is needed) -output/build/logs/*.txt +output/build/logs/* output/build/webapps/docs/**/*.html output/dist/webapps/docs/**/*.html - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1730658 - /tomcat/trunk/res/rat/rat-excludes.txt
Author: kkolinko Date: Tue Feb 16 11:13:12 2016 New Revision: 1730658 URL: http://svn.apache.org/viewvc?rev=1730658&view=rev Log: Simplify: remove *.mdl pattern. There are no *.mdl files in current Tomcat 7/8/9, as request processing diagrams were updated and are now in a different format. There is such file in Tomcat 6 (\webapps\docs\architecture\requestProcess\roseModel.mdl) Modified: tomcat/trunk/res/rat/rat-excludes.txt Modified: tomcat/trunk/res/rat/rat-excludes.txt URL: http://svn.apache.org/viewvc/tomcat/trunk/res/rat/rat-excludes.txt?rev=1730658&r1=1730657&r2=1730658&view=diff == --- tomcat/trunk/res/rat/rat-excludes.txt (original) +++ tomcat/trunk/res/rat/rat-excludes.txt Tue Feb 16 11:13:12 2016 @@ -47,7 +47,6 @@ - files used simply to ensure directories are not empty - - *.mdl are Rational Rose data files and cannot contain comments - *.bmp, *.dia files are binary (*.git, *.jpg are also binary, but are automatically detected by RAT as ones, so no explicit configuration is needed) @@ -157,6 +156,5 @@ res/checkstyle/header-al2.txt output/dist/temp/safeToDelete.tmp -**/*.mdl **/*.bmp **/*.dia - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1730659 - /tomcat/trunk/res/rat/rat-excludes.txt
Author: kkolinko Date: Tue Feb 16 11:17:47 2016 New Revision: 1730659 URL: http://svn.apache.org/viewvc?rev=1730659&view=rev Log: Correct a typo. Modified: tomcat/trunk/res/rat/rat-excludes.txt Modified: tomcat/trunk/res/rat/rat-excludes.txt URL: http://svn.apache.org/viewvc/tomcat/trunk/res/rat/rat-excludes.txt?rev=1730659&r1=1730658&r2=1730659&view=diff == --- tomcat/trunk/res/rat/rat-excludes.txt (original) +++ tomcat/trunk/res/rat/rat-excludes.txt Tue Feb 16 11:17:47 2016 @@ -48,7 +48,7 @@ - files used simply to ensure directories are not empty - *.bmp, *.dia files are binary -(*.git, *.jpg are also binary, but are automatically detected by RAT as +(*.gif, *.jpg are also binary, but are automatically detected by RAT as ones, so no explicit configuration is needed) output/build/logs/* - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1730660 - /tomcat/tc8.0.x/trunk/res/rat/rat-excludes.txt
Author: kkolinko Date: Tue Feb 16 11:24:27 2016 New Revision: 1730660 URL: http://svn.apache.org/viewvc?rev=1730660&view=rev Log: Update rat-excludes.txt, aligning with Tomcat trunk Modified: tomcat/tc8.0.x/trunk/res/rat/rat-excludes.txt Modified: tomcat/tc8.0.x/trunk/res/rat/rat-excludes.txt URL: http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/res/rat/rat-excludes.txt?rev=1730660&r1=1730659&r2=1730660&view=diff == --- tomcat/tc8.0.x/trunk/res/rat/rat-excludes.txt (original) +++ tomcat/tc8.0.x/trunk/res/rat/rat-excludes.txt Tue Feb 16 11:24:27 2016 @@ -15,61 +15,74 @@ This is excludes file for Apache RAT tool run by ASF Buildbot, - http://incubator.apache.org/rat/ + http://creadur.apache.org/rat/ The following files are excluded: + - log files and other temporary files generated during testing + - *.html files in documentation are generated from XML sources - - *.md5 files are generated and cannot contain license + - *.md5, *.sha/*.sha1 files are generated and cannot contain license - - *.manifest JAR manifest files cannot contain license + - *.manifest, MANIFEST.MF JAR manifest files cannot contain license - package-list files in API documentation (javadoc) are generated - other trivial test files, such as textual files containing only "OK' string, - are also excluded. +are also excluded. - JSON files (RFC7159) are data and cannot contain comments + - local build configuration files + + - file fragments that are combined during the build process and therefore can +not contain a license header in every fragment + + - Checkstyle configuration file that defines how to check for the presence of +ALv2 headers + + - files used simply to ensure directories are not empty + + - *.bmp, *.dia files are binary +(*.gif, *.jpg are also binary, but are automatically detected by RAT as +ones, so no explicit configuration is needed) + - unused modules -output/build/webapps/docs/*.html -output/build/webapps/docs/appdev/*.html -output/build/webapps/docs/architecture/*.html -output/build/webapps/docs/config/*.html -output/build/webapps/docs/funcspecs/*.html -output/build/webapps/docs/tribes/*.html +output/build/logs/* + +output/build/webapps/docs/**/*.html +output/dist/webapps/docs/**/*.html output/deployer/deployer-howto.html -output/dist/webapps/docs/*.html -output/dist/webapps/docs/appdev/*.html -output/dist/webapps/docs/architecture/*.html -output/dist/webapps/docs/config/*.html -output/dist/webapps/docs/funcspecs/*.html -output/dist/webapps/docs/tribes/*.html - -output/embed/*.md5 -output/extras/*.md5 - -modules/jdbc-pool/resources/MANIFEST.MF -output/dist/src/modules/jdbc-pool/resources/MANIFEST.MF -output/dist/src/res/META-INF/*.manifest -output/jdbc-pool/resources/MANIFEST.MF -output/manifests/*.manifest -res/META-INF/*.manifest - -output/dist/webapps/docs/api/package-list -output/dist/webapps/docs/elapi/package-list -output/dist/webapps/docs/jspapi/package-list -output/dist/webapps/docs/servletapi/package-list + +**/*.md5 +**/*.sha1 + +**/MANIFEST.MF +**/*.manifest + +output/dist/webapps/docs/*/package-list output/dist/src/test/webapp/bug53257/*.txt output/dist/src/test/webapp-fragments/WEB-INF/classes/*.txt test/webapp/bug53257/*.txt test/webapp-fragments/WEB-INF/classes/*.txt -webapps/examples/WEB-INF/classes/websocket/echo/servers.json -output/build/webapps/examples/WEB-INF/classes/websocket/echo/servers.json -output/dist/webapps/examples/WEB-INF/classes/websocket/echo/servers.json +**/*.json + +build.properties + +output/dist/confinstall/tomcat-users_2.xml +output/dist/src/res/confinstall/tomcat-users_2.xml +res/confinstall/tomcat-users_2.xml + +output/dist/src/res/checkstyle/header-al2.txt +res/checkstyle/header-al2.txt + +output/dist/temp/safeToDelete.tmp + +**/*.bmp +**/*.dia -modules/tomcat-lite/* \ No newline at end of file +modules/tomcat-lite/* - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 59010] Disabling socketBuffer with "-1" doesn't cause exception on linux
https://bz.apache.org/bugzilla/show_bug.cgi?id=59010 Rashmi changed: What|Removed |Added CC||rashmikatag...@in.ibm.com -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 59010] New: Disabling socketBuffer with "-1" doesn't cause exception on linux
https://bz.apache.org/bugzilla/show_bug.cgi?id=59010
Bug ID: 59010
Summary: Disabling socketBuffer with "-1" doesn't cause
exception on linux
Product: Tomcat 7
Version: 7.0.54
Hardware: PC
OS: Linux
Status: NEW
Severity: normal
Priority: P2
Component: Catalina
Assignee: dev@tomcat.apache.org
Reporter: rashmikatag...@in.ibm.com
I have implemented a service using Http11Protocol and I have disabled the
socketBuffer for the object by setting its value to "-1". When the client
disconnects before the server responds, then on windows I see the exception:
SEVERE: Error processing request
java.net.SocketException: Unrecognized Windows Sockets error: 0: socket write
er
ror
at java.net.SocketOutputStream.socketWrite(SocketOutputStream.java:125)
at java.net.SocketOutputStream.write(SocketOutputStream.java:171)
at
org.apache.coyote.http11.InternalOutputBuffer$OutputStreamOutputBuffe
r.doWrite(InternalOutputBuffer.java:243)
at
org.apache.coyote.http11.filters.IdentityOutputFilter.doWrite(Identit
yOutputFilter.java:84)
at
org.apache.coyote.http11.AbstractOutputBuffer.doWrite(AbstractOutputB
uffer.java:192)
at org.apache.coyote.Response.doWrite(Response.java:499)
at dummyAdapter.service(dummyAdapter.java:49)
But on linux, I don't see any exception raised.
My listener looks like this:
public class TomcatCipherTst {
public static void main(String[] args) throws Exception {
Http11Protocol h1p = new BrokerProtocolHandler();
h1p.setSocketBuffer(-1);
h1p.setMaxKeepAliveRequests(-1);
Adapter ac = new dummyAdapter();
h1p.setAdapter(ac);
h1p.setPort(7677);
h1p.init();
h1p.start();
boolean status = ((BrokerProtocolHandler)h1p).getEndpoint().isRunning();
System.out.println("status = " + status);
Thread.sleep(100);
}
}
My adapter service implementation looks like this:
public class dummyAdapter implements Adapter {
public boolean asyncDispatch(Request arg0, Response arg1, SocketStatus arg2)
throws Exception {
return false;
}
public boolean event(Request arg0, Response arg1, SocketStatus arg2)
throws Exception {
return false;
}
public String getDomain() {
return null;
}
public void log(Request arg0, Response arg1, long arg2) {
}
public void service(Request req, Response res) throws Exception {
System.out.println("We got em");
Thread.sleep(3000);
String resp = new String("We got request for |" +
req.requestURI().toString() + "|");
ByteChunk bc = new ByteChunk();
byte[] respBA = resp.getBytes("utf-8");
bc.setBytes(respBA, 0, respBA.length);
res.setContentLength(respBA.length);
res.doWrite(bc);
res.finish();
}
public void checkRecycled(Request arg0, Response arg1) {
}
public void errorDispatch(Request arg0, Response arg1) {
}
}
BrokerProtocolHandler is:
public class BrokerProtocolHandler extends
org.apache.coyote.http11.Http11Protocol
{
public BrokerProtocolHandler() {
super();
}
public AbstractEndpoint getEndpoint() {
return endpoint;
}
}
Can you please take a look at this and help us understand why there is no
exception on linux?
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [RESULT][VOTE] Release Apache Tomcat 7.0.68
Hi, 2016-02-09 9:18 GMT+02:00 Violeta Georgieva : > > The proposed Apache Tomcat 7.0.68 release is now available for voting. > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.68/ > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1064/ > The svn tag is: > http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_68/ > > The proposed 7.0.68 release is: > [ ] Broken - do not release > [ ] Stable - go ahead and release as 7.0.68 Stable +1 (binding): violetagg, mgrigorov, kfujino, fschumacher No other voters were cast. The vote has passed. I'll do the release shortly and announce it once the mirrors catch up. > Regards, > Violeta
svn commit: r1730665 - /tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
Author: violetagg Date: Tue Feb 16 12:02:12 2016 New Revision: 1730665 URL: http://svn.apache.org/viewvc?rev=1730665&view=rev Log: Update the release date for 7.0.68 Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1730665&r1=1730664&r2=1730665&view=diff == --- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original) +++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Tue Feb 16 12:02:12 2016 @@ -59,7 +59,7 @@ --> - + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1730669 - /tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
Author: violetagg Date: Tue Feb 16 12:09:19 2016 New Revision: 1730669 URL: http://svn.apache.org/viewvc?rev=1730669&view=rev Log: Update the release date for 6.0.45 Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml?rev=1730669&r1=1730668&r2=1730669&view=diff == --- tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml (original) +++ tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Tue Feb 16 12:09:19 2016 @@ -53,7 +53,7 @@ - + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r12408 - /dev/tomcat/tomcat-7/v7.0.68/ /release/tomcat/tomcat-7/v7.0.68/
Author: violetagg Date: Tue Feb 16 12:11:30 2016 New Revision: 12408 Log: Release Tomcat 7.0.68 Added: release/tomcat/tomcat-7/v7.0.68/ - copied from r12407, dev/tomcat/tomcat-7/v7.0.68/ Removed: dev/tomcat/tomcat-7/v7.0.68/ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Files to exclude from buildbot rat tests
2016-02-16 12:40 GMT+03:00 Konstantin Kolinko : > 2016-02-16 0:15 GMT+03:00 Mark Thomas : >> On 15/02/2016 08:04, Gav wrote: >>> HI All, >>> >>> markt has added some exclusions recently that are preventing a successful >>> rat run on buildbot. >> >> Huh? You told me it was failing and asked me to exclude some files. >> >>> (More accurately the xml file produced is malformed due to inclusions of >>> bad headers) >>> While Tomcat can exclude *.bmp and *.dia files, the questions are 1) RAT should not generate a broken XML file. 2) RAT successfully detects *.gif, *.woff as binary. Why does it fail to detect *.bmp? *.dia ? For 1) I filed this issue for RAT project: https://issues.apache.org/jira/browse/RAT-211 Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1730671 - /tomcat/tc8.0.x/trunk/conf/tomcat-users.xsd
Author: kkolinko Date: Tue Feb 16 12:25:13 2016 New Revision: 1730671 URL: http://svn.apache.org/viewvc?rev=1730671&view=rev Log: Add license to tomcat-users.xsd This backports part of r1641174 Modified: tomcat/tc8.0.x/trunk/conf/tomcat-users.xsd Modified: tomcat/tc8.0.x/trunk/conf/tomcat-users.xsd URL: http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/conf/tomcat-users.xsd?rev=1730671&r1=1730670&r2=1730671&view=diff == --- tomcat/tc8.0.x/trunk/conf/tomcat-users.xsd (original) +++ tomcat/tc8.0.x/trunk/conf/tomcat-users.xsd Tue Feb 16 12:25:13 2016 @@ -1,4 +1,20 @@ + http://www.w3.org/2001/XMLSchema"; targetNamespace="http://tomcat.apache.org/xml"; xmlns:users="http://tomcat.apache.org/xml"; - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1730676 - /tomcat/trunk/webapps/docs/changelog.xml
Author: violetagg Date: Tue Feb 16 12:37:34 2016 New Revision: 1730676 URL: http://svn.apache.org/viewvc?rev=1730676&view=rev Log: Fix typo Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1730676&r1=1730675&r2=1730676&view=diff == --- tomcat/trunk/webapps/docs/changelog.xml (original) +++ tomcat/trunk/webapps/docs/changelog.xml Tue Feb 16 12:37:34 2016 @@ -146,7 +146,7 @@ invalid location. (markt) -58827: Remove remains of JSR-77 implementaion. (markt) +58827: Remove remains of JSR-77 implementation. (markt) 58946: Ensure that the request parameter map remains - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1730680 - /tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
Author: violetagg Date: Tue Feb 16 12:46:50 2016 New Revision: 1730680 URL: http://svn.apache.org/viewvc?rev=1730680&view=rev Log: Fix typo Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml?rev=1730680&r1=1730679&r2=1730680&view=diff == --- tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml (original) +++ tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Tue Feb 16 12:46:50 2016 @@ -217,7 +217,7 @@ 58631: Correct the continuation character use in the Windows -Service How-To page of the documenation web application. (markt) +Service How-To page of the documentation web application. (markt) Correct some typos in the JNDI resources How-To. (markt) @@ -1086,7 +1086,7 @@ Update to Eclipse JDT Compiler 4.3.1. (markt) -Update the Apache Jakarta JSTL implementation used by the exmaples web +Update the Apache Jakarta JSTL implementation used by the examples web application to 1.1.2. (markt) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 58244] two way SSL loses client certificate after a few requests
https://bz.apache.org/bugzilla/show_bug.cgi?id=58244 --- Comment #12 from Christopher Schultz --- David, you still haven't said whether this is a case of the browser not sending the certificate or the servlet ignoring it when it's sent. Using Wireshark should allow you to do that. If the browser does not send the certificate, the only way for Tomcat to deal with that would be to store the certificate (and chain?) somewhere along with a mapping to the TLS session identifier (which should ALWAYS be available). If a TLS session re-start occurs, the client cert should be presented again, and there should be continuity, there. Please confirm also that, when the cert disappears, that your TLS and HTTP sessions are not interrupted. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 59001] Unable to load jar files when they have exclamation in the path
https://bz.apache.org/bugzilla/show_bug.cgi?id=59001 Christopher Schultz changed: What|Removed |Added OS||All --- Comment #1 from Christopher Schultz --- Typically, the ! character means that the sought resource is actually inside of a JAR file. The URL you have has a ! after an on-disk path, but not one that (looks like it) is a JAR file (G:\TEST). That looks like an invalid JAR URL to me. Or has Tomcat built a bad URL out of some other path? Or, are you saying that your on-disk path is actually "G:\TEST!Maven!"? This may be a pathological use case, but neither NTFS nor any of the *NIX filesystems I checked have any prohibition against ! characters, which are special for JAR URLs. (None of those filesystems prohibit # marks, either, which could potentially be a problem.) -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: NIO + JSSE + NIO + OpenSSL
Rémy, On 2/14/16 5:36 PM, Rémy Maucherat wrote: > 2016-02-14 22:45 GMT+01:00 Mark Thomas : > >> All, >> >> In preparation for the connector selection webinar next week, I just did >> a quick test of NIO + JSSE and NIO + OpenSSL. >> >> I was working with 9.0.x trunk including my JASPIC patch >> >> NIO + JSSE ~8200 requests/second >> >> Add the native lib to $CATALINA_BASE/bin and restart. >> No other changes at all. >> >> NIO + OpenSSL ~12300 requests/second >> >> >> Simply dropping in the native library improves TLS performance by >> roughly 50%. >> >> Kudos to remm and jfclere. >> > > Thanks ! > > SSL tests are difficult however, what do you use ? Direct buffers help > OpenSSL a lot for example (socket.directBuffer and socket.directSslBuffer > to true). Also one important item is to make sure the tests all use the > same cipher, especially with ab (JSSE might not use the same cipher as > OpenSSL), something like: ab -k -Z "AES128-GCM-SHA256" forces testing of > this common AES-GCM cipher. Newer and more secure ciphers are often way > slower, no surprise there. +1 Make sure that the same cipher suite(s) are in use for these tests. > Last, APR is still significantly faster for me, which is rather normal. Agreed. JSSE adds-in a bunch of API layers whereas the APR connector is almost straight-to-OpenSSL. I think it will always have a performance advantage. (Especially because OpenSSL itself is finally slimming-down after decades of cruft.) > It's not that critical at this performance level, probably, but it's here > to stay. It just needs a good bit of real-world testing to make sure we have all the corner-cases handled. -chris - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 59013] New: In 8.0.32, WebappClassLoaderBase.filter throws StringIndexOutOfBoundsException for "org"
https://bz.apache.org/bugzilla/show_bug.cgi?id=59013 Bug ID: 59013 Summary: In 8.0.32, WebappClassLoaderBase.filter throws StringIndexOutOfBoundsException for "org" Product: Tomcat 8 Version: 8.0.32 Hardware: Macintosh OS: Mac OS X 10.1 Status: NEW Severity: normal Priority: P2 Component: Manager Assignee: dev@tomcat.apache.org Reporter: max.tardiv...@ca.com As of 8.0.32, WebappClassLoaderBase.filter() now looks for "org" in the class name, but if the class name happens to be just "org", it throws a StringIndexOutOfBoundsException at line 2780. This may seem minor (who's got a class called "org"?) but it's not, because applications that use Rhino will hit this problem very quickly. When loading a class a.b.c.MyClass, Rhino will try to load each package, i.e. a, then a.b, then a.b.c, then finally a.b.c.MyClass. So if you try to load a class that's in a org package, you get the exception. The fix should be simple: if the class name starts with "org", do *not* assume that it's longer than 3 characters. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 58999] StringIndexOutOfBoundsException WebAppClassLoaderBase.filter()
https://bz.apache.org/bugzilla/show_bug.cgi?id=58999 Violeta Georgieva changed: What|Removed |Added CC||max.tardiv...@ca.com --- Comment #12 from Violeta Georgieva --- *** Bug 59013 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 59013] In 8.0.32, WebappClassLoaderBase.filter throws StringIndexOutOfBoundsException for "org"
https://bz.apache.org/bugzilla/show_bug.cgi?id=59013 Violeta Georgieva changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Violeta Georgieva --- *** This bug has been marked as a duplicate of bug 58999 *** -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1730711 - /tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/AuthConfigFactoryImpl.java
Author: markt
Date: Tue Feb 16 16:52:23 2016
New Revision: 1730711
URL: http://svn.apache.org/viewvc?rev=1730711&view=rev
Log:
Don't need to trigger auto-registration since the provider will be registered a
few lines later.
Modified:
tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/AuthConfigFactoryImpl.java
Modified:
tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/AuthConfigFactoryImpl.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/AuthConfigFactoryImpl.java?rev=1730711&r1=1730710&r2=1730711&view=diff
==
---
tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/AuthConfigFactoryImpl.java
(original)
+++
tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/AuthConfigFactoryImpl.java
Tue Feb 16 16:52:23 2016
@@ -104,7 +104,7 @@ public class AuthConfigFactoryImpl exten
try {
clazz = Class.forName(className);
Constructor constructor = clazz.getConstructor(Map.class,
AuthConfigFactory.class);
-provider = (AuthConfigProvider)
constructor.newInstance(properties, this);
+provider = (AuthConfigProvider)
constructor.newInstance(properties, null);
} catch (ClassNotFoundException | NoSuchMethodException |
InstantiationException |
IllegalAccessException | IllegalArgumentException |
InvocationTargetException e) {
throw new SecurityException(e);
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
JASPIC progress
All, I picked an OAuth module at random ([1]) and tried it with the current JASPIC implementation. The good news is that it worked. However, that project only provides the ServerAuthModule. That means there is no AuthConfigProvider, ServerAuthConfig or ServerAuthContext. I have thrown together some simple implementations to test the module. What I intend to do next is make them more robust so they can be added to Tomcat's JASPIC implementation. The general idea is that with the right entries in jaspic-providers.xml, you will be able to configure a web application to use JASPIC and any ServerAuthModule of your choice. I might try and extend support to multiple modules. It depends how tricky it gets. For more complex requirements, users always have the option of extending the basic ones Tomcat provides or writing their own. I also still need to document all this. Mark [1] https://github.com/phillipgreenii/google-oauth-2.0-serverauthmodule - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 59014] New: No CloseMessage because of WebSocket connection has been closed
https://bz.apache.org/bugzilla/show_bug.cgi?id=59014
Bug ID: 59014
Summary: No CloseMessage because of WebSocket connection has
been closed
Product: Tomcat 8
Version: 8.0.32
Hardware: PC
OS: All
Status: NEW
Severity: major
Priority: P2
Component: WebSocket
Assignee: dev@tomcat.apache.org
Reporter: abi...@pivotal.io
In our test-cases we would like to handle
Endpoint.onClose(Session session, CloseReason closeReason) {}
But looks the code isn't reachable.
WsSession does:
state = State.CLOSED_SENT;
...
sendCloseMessage(closeReasonMessage);
Where we have the code like in WsRemoteEndpointImplBase.startMessageBlock:
FutureToSendHandler f2sh = new FutureToSendHandler(wsSession);
startMessage(opCode, payload, last, f2sh);
try {
if (timeout == -1) {
f2sh.get();
} else {
f2sh.get(timeout, TimeUnit.MILLISECONDS);
}
That f2sh.get() does this:
wsSession.registerFuture(this);
where:
if (isOpen()) {
futures.put(f2sh, f2sh);
}
is false because our state is State.CLOSED_SENT not like:
state == State.OPEN || state == State.SENDING_CLOSED
Therefore we never get result from that Future and our onClose() test fail.
You can find more info in the bug57489, especially
https://bz.apache.org/bugzilla/show_bug.cgi?id=58624#c13 and its attachment.
The related Spring Integration JIRA: https://jira.spring.io/browse/INT-3909.
Thank you in advance!
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1730728 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/valves/rewrite/Substitution.java test/org/apache/catalina/valves/rewrite/TestRewriteValve.java webapps/docs/changelog.xml
Author: fschumacher Date: Tue Feb 16 18:23:32 2016 New Revision: 1730728 URL: http://svn.apache.org/viewvc?rev=1730728&view=rev Log: Make checking for var and map replacement in RewriteValve a bit stricter and correct detection of colon in var replacement. Merge r1730612 from /tomcat/trunk Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/java/org/apache/catalina/valves/rewrite/Substitution.java tomcat/tc8.0.x/trunk/test/org/apache/catalina/valves/rewrite/TestRewriteValve.java tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml Propchange: tomcat/tc8.0.x/trunk/ -- --- svn:mergeinfo (original) +++ svn:mergeinfo Tue Feb 16 18:23:32 2016 @@ -1 +1 @@ -/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1637890,1637892,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886 ,1644890,1644892,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1649973,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654513,1654515,1654517,1654522,1654524,1654725,1654735,1654766,1654785,1654851-1654852,1654978,1655122-1655124,1655126-1655127,1655129-1655130,1655132-1655133,1655312,1655351,1655438,1655441,1655454,168,1656087,1656299,1656319,1656331,1656345,1656350,1656590,1656648-1656650,1656657,1657041,1657054,1657374,1657492,1657510,1657565,1657580,1657584,1657586,1657589,1657 592,1657607,1657609,1657682,1657907,1658207,1658734,1658781,1658790,1658799,1658802,1658804,1658833,1658840,1658966,1659043,1659053,1659059,1659174,1659184,1659188-1659189,1659216,1659263,1659293,1659304,1659306-1659307,1659382,1659384,1659428,1659471,1659486,1659505,1659516,1659521,1659524,1659559,1659562,1659803,1659806,1659814,1659833,1659862,1659905,1659919,1659948,1659967,1659983-1659984,1660060,1660074,1660077,1660133,1660168,1660331-1660332,1660353,1660358,1660924,1661386,1661770,1661867,1661972,1661990,1662200,1662308-1662309,1662548,1662614,1662696,1662736,1662985,1662988-1662989,1663264,1663277,1663298,1663534,1663562,1663676,1663715,1663754,1663768,1663772,1663781,1663893,1663995,1664143,1664163,1664174,1664301,1664317,1664347,1664657,1664659,1664710,1664863-1664864,1664866,1665085,1665292,1665559,1665653,1665661,1665672,1665694,1665697,1665736,1665779,1665976-1665977,1665980-1665981,1665985-1665986,1665989,1665998,1666004,1666008,1666013,1666017,1666024,1666116,1666386-1 666387,1666494,1666496,1666552,1666569,1666579,137,149,1666757,1666966,1666972,1666985,1666995,1666997,1667292,1667402,1667406,1667546,1667615,1667630,1667636,1667688,1667764,1667871,1668026,1668135,1668193,1668593,1668596,1668630,1668639,1668843,1669353,1669370,1669451,1669800,1669838,1669876,1669882,1670394,1670433,1670591,1670598-1670600,1670610,1670631,1670719,1670724,1670726,1670730,1670940,1671112,1672272,1672284,1673754,1674294,1675461,1675486,1675594,1675830,1676231,1676250-1676251,1676364,1676381,1676393,1676479,1676525,1676552,1676615,1676630,1676634,1676721,1676926,1676943,1677140,1677802,1678011,1678162,1678174,1678339,1678426-1678427,1678694,1678701,1679534,1679708,1679710,1679716,1680034,1680246,1681056,1681123,1681138,1681280,1681283,1681286,1681450,1681697,1681699,1681701,1681729,1681770,1681779,1681793,1681807,1681837-1681838,1681854,1681862,1681958,1682028,1682033,1682311,1682315,1682317,1682320,1682324,1682330,1682842,1684172,1684366,1684383,1684526-168452 7,1684549-1684550,1685556,1685591,1685739,1685744,1685772,1685816,1685826,1685891,1687242,1687261,1687268,1687340,1687551,1688563,1688841,1688878,165,1688896,1688901,1689345-1689346,1689357,1689656,1689675-1689677,1689679,16
[Bug 59015] New: Endless loop in APR poller during connector shutdown
https://bz.apache.org/bugzilla/show_bug.cgi?id=59015 Bug ID: 59015 Summary: Endless loop in APR poller during connector shutdown Product: Tomcat 8 Version: trunk Hardware: PC Status: NEW Severity: normal Priority: P2 Component: Connectors Assignee: dev@tomcat.apache.org Reporter: rainer.j...@kippdata.de While running the TC 8 test suite and endless loop int he APR poller occured during the test org.apache.catalina.core.TestStandardWrapper. The situation might be a race condition that is not related to the specific test. Code was TC 8 HEAD plus APR 1.2.4 based on OpenSSL 1.0.2f and APR 1.5.2. Platform Sun Solaris 10 Sparc. The machine was pretty busy, when the problem occured. Error message occuring before the loop starts (only one such message): [junit] 16-Feb-2016 17:30:31.285 SEVERE [http-apr-127.0.0.1-auto-6-Poller] org.apache.tomcat.util.net.AprEndpoint$Poller.run Poller failed with error [9] : [Bad file number] Relevant stacks: main seems to hang in [junit] "main" prio=3 tid=0x0002a400 nid=0x2 runnable [0xfdf7d000] [junit]java.lang.Thread.State: RUNNABLE [junit] at org.apache.tomcat.jni.Pool.destroy(Native Method) [junit] at org.apache.tomcat.util.net.AprEndpoint$Sendfile.destroy(AprEndpoint.java:2147) [junit] at org.apache.tomcat.util.net.AprEndpoint.stopInternal(AprEndpoint.java:781) [junit] at org.apache.tomcat.util.net.AbstractEndpoint.stop(AbstractEndpoint.java:814) [junit] at org.apache.coyote.AbstractProtocol.stop(AbstractProtocol.java:517) [junit] at org.apache.catalina.connector.Connector.stopInternal(Connector.java:1011) [junit] at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:224) [junit] - locked <0xe6337060> (a org.apache.catalina.connector.Connector) [junit] at org.apache.catalina.core.StandardService.stopInternal(StandardService.java:517) [junit] - locked <0xe633eb28> (a java.lang.Object) [junit] at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:224) [junit] - locked <0xe633ea58> (a org.apache.catalina.core.StandardService) [junit] at org.apache.catalina.core.StandardServer.stopInternal(StandardServer.java:790) [junit] at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:224) [junit] - locked <0xe633e2c8> (a org.apache.catalina.core.StandardServer) [junit] at org.apache.catalina.startup.Tomcat.stop(Tomcat.java:355) [junit] at org.apache.catalina.startup.TomcatBaseTest.tearDown(TomcatBaseTest.java:218) Poller seems to loop, whenever I look it is in: [junit] "http-apr-127.0.0.1-auto-6-Poller" daemon prio=3 tid=0x004fbc00 nid=0x4d runnable [0xb2aff000] [junit]java.lang.Thread.State: RUNNABLE [junit] at org.apache.tomcat.jni.Poll.create(Native Method) [junit] at org.apache.tomcat.util.net.AprEndpoint.allocatePoller(AprEndpoint.java:881) [junit] at org.apache.tomcat.util.net.AprEndpoint$Poller.run(AprEndpoint.java:1988) [junit] at java.lang.Thread.run(Thread.java:745) [junit] Regards, Rainer -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 59015] Endless loop in APR poller during connector shutdown
https://bz.apache.org/bugzilla/show_bug.cgi?id=59015 Rainer Jung changed: What|Removed |Added OS||All --- Comment #1 from Rainer Jung --- Additional info: - truss does not show any system call activity. - unfortunately I forgot to use pstack to get info about the native frames -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 59001] Unable to load jar files when they have exclamation in the path
https://bz.apache.org/bugzilla/show_bug.cgi?id=59001 --- Comment #2 from Jayashankar Karnam --- My disk path is "G:\TEST!Maven!\..." Indeed, it is a corner use case. Is there any reason why tomcat is solely relying on "!" to identify end of the string? When we know that is the path to find specified resource, why "!" in the end? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1730748 - in /tomcat/trunk/java/org/apache/catalina/authenticator/jaspic: LocalStrings.properties SimpleAuthConfigProvider.java SimpleServerAuthConfig.java SimpleServerAuthContext.java
Author: markt
Date: Tue Feb 16 20:47:09 2016
New Revision: 1730748
URL: http://svn.apache.org/viewvc?rev=1730748&view=rev
Log:
Add simple implementations that can use used, via configuration, when working
with 3rd-party providers that only provide a ServerAuthModule implementation.
Added:
tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/SimpleAuthConfigProvider.java
(with props)
tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/SimpleServerAuthConfig.java
(with props)
tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/SimpleServerAuthContext.java
(with props)
Modified:
tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/LocalStrings.properties
Modified:
tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/LocalStrings.properties
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/LocalStrings.properties?rev=1730748&r1=1730747&r2=1730748&view=diff
==
---
tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/LocalStrings.properties
(original)
+++
tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/LocalStrings.properties
Tue Feb 16 20:47:09 2016
@@ -23,4 +23,6 @@ jaspicAuthenticator.authenticate=Authent
persistentProviderRegistrations.deleteFail=The temporary file [{0}] cannot be
deleted
persistentProviderRegistrations.existsDeleteFail=The temporary file [{0}]
already exists and cannot be deleted
-persistentProviderRegistrations.moveFail=Failed to move [{0}] to [{1}]
\ No newline at end of file
+persistentProviderRegistrations.moveFail=Failed to move [{0}] to [{1}]
+
+simpleServerAuthConfig.noModules="No ServerAuthModules configured"
\ No newline at end of file
Added:
tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/SimpleAuthConfigProvider.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/SimpleAuthConfigProvider.java?rev=1730748&view=auto
==
---
tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/SimpleAuthConfigProvider.java
(added)
+++
tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/SimpleAuthConfigProvider.java
Tue Feb 16 20:47:09 2016
@@ -0,0 +1,89 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.catalina.authenticator.jaspic;
+
+import java.util.Map;
+
+import javax.security.auth.callback.CallbackHandler;
+import javax.security.auth.message.AuthException;
+import javax.security.auth.message.config.AuthConfigFactory;
+import javax.security.auth.message.config.AuthConfigProvider;
+import javax.security.auth.message.config.ClientAuthConfig;
+import javax.security.auth.message.config.ServerAuthConfig;
+
+/**
+ * Basic implementation primarily intended for use when using third-party
+ * {@link javax.security.auth.message.module.ServerAuthModule} implementations
+ * that only provide the module.
+ */
+public class SimpleAuthConfigProvider implements AuthConfigProvider {
+
+private final Map properties;
+
+private volatile ServerAuthConfig serverAuthConfig;
+
+public SimpleAuthConfigProvider(Map properties,
AuthConfigFactory factory) {
+this.properties = properties;
+if (factory != null) {
+factory.registerConfigProvider(this, null, null, "Automatic
registration");
+}
+}
+
+
+/**
+ * {@inheritDoc}
+ *
+ * This implementation does not support client-side authentication and
+ * therefore always returns {@code null}.
+ */
+@Override
+public ClientAuthConfig getClientAuthConfig(String layer, String
appContext,
+CallbackHandler handler) throws AuthException {
+return null;
+}
+
+
+@Override
+public ServerAuthConfig getServerAuthConfig(String layer, String
appContext,
+CallbackHandler handler) throws AuthException {
+ServerAuthConfig serverAuthConfig = this.serverAuthConfig;
+if (serverAuthConfig == null) {
+synchronized (this) {
+if (this.serverAuthConfig == null) {
+
svn commit: r1730757 - in /tomcat/trunk/webapps/docs/config: jaspic.xml project.xml
Author: markt Date: Tue Feb 16 21:38:10 2016 New Revision: 1730757 URL: http://svn.apache.org/viewvc?rev=1730757&view=rev Log: Add JASPIC documentation Added: tomcat/trunk/webapps/docs/config/jaspic.xml (with props) Modified: tomcat/trunk/webapps/docs/config/project.xml Added: tomcat/trunk/webapps/docs/config/jaspic.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/config/jaspic.xml?rev=1730757&view=auto == --- tomcat/trunk/webapps/docs/config/jaspic.xml (added) +++ tomcat/trunk/webapps/docs/config/jaspic.xml Tue Feb 16 21:38:10 2016 @@ -0,0 +1,172 @@ + + + +]> + + + &project; + + +JASPIC + + + + + + + + + + + Tomcat implements JASPIC 1.1 Maintenance Release B + (https://www.jcp.org/en/jsr/detail?id=196";>JSR 196). The + implementation is primarily intended to enable the integration of 3rd party + JASPIC authentication implementations with Tomcat. + + JASPIC may be configured dynamically by an application or statically via + the $CATALINA_BASE/jaspic-providers.xml configuration file. + If present, a JASPIC configuration will over-ride any +present in web.xml. + + + + + + + +If the 3rd party implementation includes an +AuthConfigProvider then a web application can be configured to +use it by nesting the following inside the + element in +$CATALINA_BASE/jaspic-providers.xml. + + +The name and description attributes are not +used by Tomcat. + +The className attribute must be the fully qualified class +name of the AuthConfigProvider. The implementation may be +packaged with the web application or in Tomcat's +$CATALINA_BASE/lib directory. + +The layer attribute must be HttpServlet. + +The appContext attribute must be exactly the concatenation +of: + + The engine name + The forward slash character + The host name + A single space + The context path + + +If the AuthConfigProvider supports configuration via +properties these may be specified via elements +nesting inside the element. + + + + + +The the 3rd party implementation only provides an +ServerAuthModule then it will be necessary to provide a number +os supporting classes. These may be a custom implementation or, +alternatively, Tomcat provides a simple wrapper implementation for +ServerAuthModules. + + +Tomcat's wrapper for ServerAuthModule can be configured +by nesting the following inside the + element in +$CATALINA_BASE/jaspic-providers.xml. + + +The configuration is similar to the AuthConfigProvider in +the previous section but with some key differences. + +The className attribute must be + org.apache.catalina.authenticator.jaspic.AuthConfigProviderImpl. + +The ServerAuthModule(s) are specified via properties. The +property name must be +org.apache.catalina.authenticator.jaspic.ServerAuthModule.n +where n is the index of the module. The index must start at 1 +an increment in steps of 1 until all modules are defined. The value of the +property must be the fully qualified class name of the module. + + + + + + + This is not an exhaustive list. The Tomcat community welcomes contributions + that add to this section. + + + +The source code for this module along with the +https://github.com/phillipgreenii/google-oauth-2.0-serverauthmodule";>documentation +which includes details of the necessary Google API configuration is +available on GitHub. + +A sample configuration for using this module with Tomcat would look like +this: + + + + + + + + Propchange: tomcat/trunk/webapps/docs/config/jaspic.xml -- svn:eol-style = native Modified: tomcat/trunk/webapps/docs/config/project.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/config/project.xml?rev=1730757&r1=1730756&r2=1730757&view=diff == --- tomcat/trunk/webapps/docs/config/project.xml (original) +++ tomcat/trunk/webapps/docs/config/project.xml Tue Feb 16 21:38:10 2016 @@ -89,6 +89,7 @@ + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 54503] SAML2 based single sign on
https://bz.apache.org/bugzilla/show_bug.cgi?id=54503 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #5 from Mark Thomas --- This isn't going to be added to the core Tomcat distribution but as of Tomcat 9 (9.0.0.M4 onwards) Tomcat supports JASPIC which provides a pluggable mechanism for authentication. Given the relatively low level of interest, a 3rd-party JASPIC module looks like the way to go for SAML. If you do go this route then do let the Tomcat team know if you find any issues in the JASPIC implementation and we'll get them fixed. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 59001] Unable to load jar files when they have exclamation in the path
https://bz.apache.org/bugzilla/show_bug.cgi?id=59001 --- Comment #3 from Christopher Schultz --- Honestly, I'm surprised that it's failing where it is: I would have expected it to fail saying that "G:\TEST" didn't exist. This isn't Tomcat doing this; it's the combination of a large number of components all of which are using URLs for certain purposes. There are many many corner cases where the JRE itself will fall-over even if Tomcat wasn't involved. I don't believe Tomcat massages any of the URLs it's processing, so there may be an opportunity for Tomcat to escape the ! characters in an on-disk filename (i.e. "!" -> "%21"). But like I said, there's always more and more edge-cases and encoding once means possibly encoding multiple times (and sometimes having to decode a few times, too). It's just a giant mess. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 59001] Unable to load jar files when they have exclamation in the path
https://bz.apache.org/bugzilla/show_bug.cgi?id=59001 --- Comment #4 from Jayashankar Karnam --- JarURLConnection is responsible for the mishap. As per java doc "!/" is a terminator for the jar file. That's the reason why it is failing at G:/TEST!Maven not G:/TEST And whatever comes after the "!/" becomes the context within the jar. Java doc link - https://docs.oracle.com/javase/7/docs/api/java/net/JarURLConnection.html Sorry for the confusion. -Jay -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1730784 - /tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java
Author: olamy
Date: Wed Feb 17 04:06:41 2016
New Revision: 1730784
URL: http://svn.apache.org/viewvc?rev=1730784&view=rev
Log:
[MTOMCAT-255]
Modified:
tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java
Modified:
tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java
URL:
http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java?rev=1730784&r1=1730783&r2=1730784&view=diff
==
---
tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java
(original)
+++
tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java
Wed Feb 17 04:06:41 2016
@@ -724,6 +724,13 @@ public abstract class AbstractRunMojo
( (StandardJarScanner) jarScanner ).setScanAllDirectories(
jarScanAllDirectories );
}
+// https://issues.apache.org/jira/browse/MTOMCAT-255
+if(context instanceof StandardContext)
+{
+((StandardContext) context).setAddWebinfClassesResources(true);
+((StandardContext) context).setAliases( "/WEB-INF/classes=" +
project.getBuild().getOutputDirectory());
+}
+
return context;
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Commented] (MTOMCAT-255) Getting "Target Unreachable, identifier 'pessoaBean' resolved to null" on tomcat:run but not in tomcat:run-war
[ https://issues.apache.org/jira/browse/MTOMCAT-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15149815#comment-15149815 ] Hudson commented on MTOMCAT-255: FAILURE: Integrated in TomcatMavenPlugin-mvn3.x-windows #7 (See [https://builds.apache.org/job/TomcatMavenPlugin-mvn3.x-windows/7/]) [MTOMCAT-255] (olamy: [http://svn.apache.org/viewvc/?view=rev&rev=1730784]) * tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java > Getting "Target Unreachable, identifier 'pessoaBean' resolved to null" on > tomcat:run but not in tomcat:run-war > -- > > Key: MTOMCAT-255 > URL: https://issues.apache.org/jira/browse/MTOMCAT-255 > Project: Apache Tomcat Maven Plugin > Issue Type: Bug > Components: tomcat7 >Affects Versions: 2.2 > Environment: gilberto.andrade@A37710:~$ mvn -version > Apache Maven 3.0.4 (r1232337; 2012-01-17 05:44:56-0300) > Maven home: /home/gilberto.andrade/bin/maven > Java version: 1.7.0_45, vendor: Oracle Corporation > Java home: /usr/java/jdk1.7.0_45/jre > Default locale: pt_BR, platform encoding: UTF-8 > OS name: "linux", version: "3.7.10-1.24-desktop", arch: "amd64", family: > "unix" >Reporter: Gilberto C Andrade >Assignee: Olivier Lamy (*$^¨%`£) >Priority: Minor > Fix For: 2.3 > > Attachments: MTOMCAT-255.patch, MTOMCAT-255.zip > > > Simple JSF 2.2 project with just one manage bean(PessoaMb) and one xhtml page. > 1 Run mvn clean tomcat7:run > 2 hitting http://localhost:8080/MTOMCAT-255/pessoaView.xhtml > 3 enter some value on field or click the consultar button > The same steps works when using tomcat7:run-war. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1730787 - /tomcat/maven-plugin/branches/tc8.x/tomcat8-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat8/run/RunMojo.java
Author: olamy
Date: Wed Feb 17 04:22:54 2016
New Revision: 1730787
URL: http://svn.apache.org/viewvc?rev=1730787&view=rev
Log:
Merge branch 'MTOMCAT-302' into tc8.x
fixed #21
Modified:
tomcat/maven-plugin/branches/tc8.x/tomcat8-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat8/run/RunMojo.java
Modified:
tomcat/maven-plugin/branches/tc8.x/tomcat8-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat8/run/RunMojo.java
URL:
http://svn.apache.org/viewvc/tomcat/maven-plugin/branches/tc8.x/tomcat8-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat8/run/RunMojo.java?rev=1730787&r1=1730786&r2=1730787&view=diff
==
---
tomcat/maven-plugin/branches/tc8.x/tomcat8-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat8/run/RunMojo.java
(original)
+++
tomcat/maven-plugin/branches/tc8.x/tomcat8-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat8/run/RunMojo.java
Wed Feb 17 04:22:54 2016
@@ -627,7 +627,7 @@ public class RunMojo
for ( String file : files )
{
-paths.add( file );
+paths.add( path + file );
}
return paths;
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Resolved] (MTOMCAT-302) Tomcat 8: Invalid resource paths added when scanning for TLDs
[ https://issues.apache.org/jira/browse/MTOMCAT-302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy (*$^¨%`£) resolved MTOMCAT-302. Resolution: Fixed Assignee: Olivier Lamy (*$^¨%`£) thanks for the pull request! > Tomcat 8: Invalid resource paths added when scanning for TLDs > - > > Key: MTOMCAT-302 > URL: https://issues.apache.org/jira/browse/MTOMCAT-302 > Project: Apache Tomcat Maven Plugin > Issue Type: Dependency upgrade >Reporter: Rupert Madden-Abbott >Assignee: Olivier Lamy (*$^¨%`£) >Priority: Blocker > Fix For: 3.0 > > > Tomcat 8 now requires that all resource paths begin with "/". > However, in org.apache.tomcat.maven.plugin.tomcat8.run.RunMojo, there is an > anonymous class extending > org.apache.tomcat.maven.plugin.tomcat8.run.AbstractRunMojo.MyDirContext. > This overrides the method listWebAppPaths and the implementation will return > file names, which do not begin with "/". > This will result in an error if you place a tld file in your WEB-INF > directory. Doing this will cause listWebAppPaths to return your tld file, > which then causes an error as the path is not valid. > One solution would be to alter this method so it appended the path relative > to the classpath, to each file. This seems to be how the equivalent method in > org.apache.catalina.webresources.DirResourceSet works. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1730788 - /tomcat/maven-plugin/branches/tc8.x/pom.xml
Author: olamy Date: Wed Feb 17 04:25:11 2016 New Revision: 1730788 URL: http://svn.apache.org/viewvc?rev=1730788&view=rev Log: add contributor Signed-off-by: olivier lamy Modified: tomcat/maven-plugin/branches/tc8.x/pom.xml Modified: tomcat/maven-plugin/branches/tc8.x/pom.xml URL: http://svn.apache.org/viewvc/tomcat/maven-plugin/branches/tc8.x/pom.xml?rev=1730788&r1=1730787&r2=1730788&view=diff == --- tomcat/maven-plugin/branches/tc8.x/pom.xml (original) +++ tomcat/maven-plugin/branches/tc8.x/pom.xml Wed Feb 17 04:25:11 2016 @@ -186,6 +186,9 @@ Xavier Dury + + Rupert Madden-Abbott + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Commented] (MTOMCAT-255) Getting "Target Unreachable, identifier 'pessoaBean' resolved to null" on tomcat:run but not in tomcat:run-war
[ https://issues.apache.org/jira/browse/MTOMCAT-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15149852#comment-15149852 ] Hudson commented on MTOMCAT-255: FAILURE: Integrated in TomcatMavenPlugin-mvn3.x #291 (See [https://builds.apache.org/job/TomcatMavenPlugin-mvn3.x/291/]) [MTOMCAT-255] (olamy: [http://svn.apache.org/viewvc/?view=rev&rev=1730784]) * tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java > Getting "Target Unreachable, identifier 'pessoaBean' resolved to null" on > tomcat:run but not in tomcat:run-war > -- > > Key: MTOMCAT-255 > URL: https://issues.apache.org/jira/browse/MTOMCAT-255 > Project: Apache Tomcat Maven Plugin > Issue Type: Bug > Components: tomcat7 >Affects Versions: 2.2 > Environment: gilberto.andrade@A37710:~$ mvn -version > Apache Maven 3.0.4 (r1232337; 2012-01-17 05:44:56-0300) > Maven home: /home/gilberto.andrade/bin/maven > Java version: 1.7.0_45, vendor: Oracle Corporation > Java home: /usr/java/jdk1.7.0_45/jre > Default locale: pt_BR, platform encoding: UTF-8 > OS name: "linux", version: "3.7.10-1.24-desktop", arch: "amd64", family: > "unix" >Reporter: Gilberto C Andrade >Assignee: Olivier Lamy (*$^¨%`£) >Priority: Minor > Fix For: 2.3 > > Attachments: MTOMCAT-255.patch, MTOMCAT-255.zip > > > Simple JSF 2.2 project with just one manage bean(PessoaMb) and one xhtml page. > 1 Run mvn clean tomcat7:run > 2 hitting http://localhost:8080/MTOMCAT-255/pessoaView.xhtml > 3 enter some value on field or click the consultar button > The same steps works when using tomcat7:run-war. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
