JAR update request
Hi, Please could the Eclipse JDT jar be updated to version P20140317-1600 as this is now required by the Tomcat builds (to pick up Java 8 support). I did try to do this myself but I don't have sudo on vmgump so I couldn't make the change. Cheers, Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56148] support (multiple) ocsp stapling
https://issues.apache.org/bugzilla/show_bug.cgi?id=56148 Violeta Georgieva changed: What|Removed |Added Severity|normal |enhancement -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: JAR update request
On 2014-03-20, Mark Thomas wrote: > Please could the Eclipse JDT jar be updated to version P20140317-1600 as > this is now required by the Tomcat builds (to pick up Java 8 support). I would if I knew how to obtain it - I'm not an eclipse user myself, so I'd appreciate a download location that doesn't force me to download a full Eclipse distribution :-) Stefan - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: JAR update request
On 20/03/2014 08:36, Stefan Bodewig wrote: > On 2014-03-20, Mark Thomas wrote: > >> Please could the Eclipse JDT jar be updated to version P20140317-1600 as >> this is now required by the Tomcat builds (to pick up Java 8 support). > > I would if I knew how to obtain it - I'm not an eclipse user myself, so > I'd appreciate a download location that doesn't force me to download a > full Eclipse distribution :-) Thanks. The direct download link is: http://download.eclipse.org/eclipse/downloads/drops4/P20140317-1600/ecj-P20140317-1600.jar Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: JAR update request
On 2014-03-20, Mark Thomas wrote: > On 20/03/2014 08:36, Stefan Bodewig wrote: >> On 2014-03-20, Mark Thomas wrote: >>> Please could the Eclipse JDT jar be updated to version P20140317-1600 as >>> this is now required by the Tomcat builds (to pick up Java 8 support). >> I would if I knew how to obtain it - I'm not an eclipse user myself, so >> I'd appreciate a download location that doesn't force me to download a >> full Eclipse distribution :-) > Thanks. The direct download link is: > http://download.eclipse.org/eclipse/downloads/drops4/P20140317-1600/ecj-P20140317-1600.jar Should be available on the next build, unless my inferior knowledge or my slipping fingers messed things up, that is :-) Stefan - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56293] New: WebappClassLoader does not cache META-INF/services which leads to performance issues
https://issues.apache.org/bugzilla/show_bug.cgi?id=56293 Bug ID: 56293 Summary: WebappClassLoader does not cache META-INF/services which leads to performance issues Product: Tomcat 7 Version: 7.0.28 Hardware: PC Status: NEW Severity: normal Priority: P2 Component: Catalina Assignee: dev@tomcat.apache.org Reporter: michael.thi...@saxsys.de Since Tomcat 7.0.28, the WebappClassLoader does not cache any resources on the classpath except .class and .properties files (see https://issues.apache.org/bugzilla/show_bug.cgi?id=53081). This leads to a massive performance problem in applications that contain .jars on the classpath that use the ServiceLoader mechanism of Java 6 to bind concrete XML readers and writers to their respective interfaces, since every time the concrete instance is loaded, the WebappClassLoader has to open the .jar to read which concrete implementation is used. A possible solution might be that caching is enabled for all resources that reside in the META-INF/services folder. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 54475] SMAP broken in Java 8 for JSP compile
https://issues.apache.org/bugzilla/show_bug.cgi?id=54475 Robbie Gibson changed: What|Removed |Added CC||robbie_use...@yahoo.co.uk --- Comment #5 from Robbie Gibson --- Created attachment 31415 --> https://issues.apache.org/bugzilla/attachment.cgi?id=31415&action=edit Failing servlet I downloaded JDK 1.8.0 (1.8.0-b132) and Ant 1.9.3. I downloaded Tomcat 7.0.52 and set up web.xml as specified, then removed ecj-4.3.1.jar and added tools.jar from the JDK and ant.jar, ant-launcher.jar from the Ant distribution. I am able to reproduce the failure with the attached servlet. Note that compiling servlets using JDK 1.8.0 works fine as long as the servlet files don't contain any lambdas, so removing the '.filter (s -> s.length () == 5)' causes the servlet to be correctly served. Adding a lambda causes the Java 8 compiler to add an InvokeDynamic target to the constant pool and triggers the SMAP failure. http://docs.oracle.com/javase/specs/jvms/se7/html/jvms-4.html#jvms-4.4 The exact exception is: java.io.IOException: unexpected tag: 18 at org.apache.jasper.compiler.SmapUtil$SDEInstaller.copyConstantPool(SmapUtil.java:431) at org.apache.jasper.compiler.SmapUtil$SDEInstaller.addSDE(SmapUtil.java:248) at org.apache.jasper.compiler.SmapUtil$SDEInstaller.(SmapUtil.java:220) at org.apache.jasper.compiler.SmapUtil$SDEInstaller.install(SmapUtil.java:199) at org.apache.jasper.compiler.SmapUtil.installSmap(SmapUtil.java:163) at org.apache.jasper.compiler.AntCompiler.generateClass(AntCompiler.java:284) at org.apache.jasper.compiler.Compiler.compile(Compiler.java:378) at org.apache.jasper.compiler.Compiler.compile(Compiler.java:353) at org.apache.jasper.compiler.Compiler.compile(Compiler.java:340) at org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:657) at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:357) at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:390) at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:334) at javax.servlet.http.HttpServlet.service(HttpServlet.java:727) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:303) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208) at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208) at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:220) at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:122) at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:501) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:170) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:98) at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:950) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:116) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:408) at org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1040) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:607) at org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:315) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:744) -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.4
2014-03-19 22:14 GMT+01:00 Mark Thomas : > [X] Beta - go ahead and release as 8.0.4 (beta) > [ ] Stable - go ahead and release as 8.0.4 (stable) > > This looks good enough to me to be Stable, but with this many fixes included it is likely there will be a couple hotfixes needed. I won't complain if it is released as Stable though. Rémy
[Bug 56293] WebappClassLoader does not cache META-INF/services which leads to performance issues
https://issues.apache.org/bugzilla/show_bug.cgi?id=56293 Mark Thomas changed: What|Removed |Added OS||All --- Comment #1 from Mark Thomas --- Neither the problem nor the solution appear to be that simple. Looking at the ServiceLoader code, the contents of META-INF/services aren't read using the method where the caching was removed. Can you put together a simple test case that demonstrates this issue? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 54475] SMAP broken in Java 8 for JSP compile
https://issues.apache.org/bugzilla/show_bug.cgi?id=54475 Mark Thomas changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|INVALID |--- --- Comment #6 from Mark Thomas --- Looks like we have something to fix here. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 54475] SMAP broken in Java 8 for JSP compile
https://issues.apache.org/bugzilla/show_bug.cgi?id=54475 --- Comment #7 from Robbie Gibson --- Created attachment 31416 --> https://issues.apache.org/bugzilla/attachment.cgi?id=31416&action=edit Proposed patch to alleviate crash behaviour I propose the following very simple patch to stop the crashing. I suppose there is some more work to do to verify the SMAP data with Java 8 classfiles. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.4
On 2014-03-19, 5:14 PM, Mark Thomas wrote: http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_4/ The proposed 8.0.4 release is: [ ] Broken - do not release [ ] Alpha - go ahead and release as 8.0.4 (alpha) [ ] Beta - go ahead and release as 8.0.4 (beta) [X] Stable - go ahead and release as 8.0.4 (stable) Tested WebSocket (jsr356) and AsyncContext, with all major Browsers and WebSocket Client. -- Jeanfrancois Cheers, Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.4
On Thu, Mar 20, 2014 at 3:35 PM, Jeanfrancois Arcand wrote: > > On 2014-03-19, 5:14 PM, Mark Thomas wrote: > >> http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_4/ >> >> The proposed 8.0.4 release is: >> [ ] Broken - do not release >> [ ] Alpha - go ahead and release as 8.0.4 (alpha) >> [ ] Beta - go ahead and release as 8.0.4 (beta) >> [X] Stable - go ahead and release as 8.0.4 (stable) >> > Tested WebSocket (jsr356) and AsyncContext, with all major Browsers and > WebSocket Client. > > -- Jeanfrancois > > >> Cheers, >> >> Mark >> >> [X] Stable - go ahead and release as 8.0.4 (stable) Martin Grigorov Wicket Training and Consulting > - >> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >> For additional commands, e-mail: dev-h...@tomcat.apache.org >> >> > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
svn commit: r1579623 - in /tomcat/trunk: build.properties.default res/maven/mvn.properties.default webapps/docs/changelog.xml
Author: markt Date: Thu Mar 20 13:49:26 2014 New Revision: 1579623 URL: http://svn.apache.org/r1579623 Log: Prep for next release Modified: tomcat/trunk/build.properties.default tomcat/trunk/res/maven/mvn.properties.default tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/build.properties.default URL: http://svn.apache.org/viewvc/tomcat/trunk/build.properties.default?rev=1579623&r1=1579622&r2=1579623&view=diff == --- tomcat/trunk/build.properties.default (original) +++ tomcat/trunk/build.properties.default Thu Mar 20 13:49:26 2014 @@ -25,7 +25,7 @@ # - Version Control Flags - version.major=8 version.minor=0 -version.build=4 +version.build=5 version.patch=0 version.suffix=-dev Modified: tomcat/trunk/res/maven/mvn.properties.default URL: http://svn.apache.org/viewvc/tomcat/trunk/res/maven/mvn.properties.default?rev=1579623&r1=1579622&r2=1579623&view=diff == --- tomcat/trunk/res/maven/mvn.properties.default (original) +++ tomcat/trunk/res/maven/mvn.properties.default Thu Mar 20 13:49:26 2014 @@ -35,7 +35,7 @@ maven.asf.release.repo.url=https://repos maven.asf.release.repo.repositoryId=apache.releases # Release version info -maven.asf.release.deploy.version=8.0.4 +maven.asf.release.deploy.version=8.0.5 #Where do we load the libraries from tomcat.lib.path=../../output/build/lib Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1579623&r1=1579622&r2=1579623&view=diff == --- tomcat/trunk/webapps/docs/changelog.xml (original) +++ tomcat/trunk/webapps/docs/changelog.xml Thu Mar 20 13:49:26 2014 @@ -44,6 +44,8 @@ They eventually become mixed with the numbered issues. (I.e., numbered issues to not "pop up" wrt. others). --> + + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1579626 - in /tomcat/trunk: java/org/apache/jasper/compiler/SmapUtil.java webapps/docs/changelog.xml
Author: markt
Date: Thu Mar 20 13:53:56 2014
New Revision: 1579626
URL: http://svn.apache.org/r1579626
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54475
Add Java 8 support to SMAP generation for JSPs.
Patch by Robbie Gibson.
Modified:
tomcat/trunk/java/org/apache/jasper/compiler/SmapUtil.java
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/java/org/apache/jasper/compiler/SmapUtil.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/compiler/SmapUtil.java?rev=1579626&r1=1579625&r2=1579626&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/compiler/SmapUtil.java (original)
+++ tomcat/trunk/java/org/apache/jasper/compiler/SmapUtil.java Thu Mar 20
13:53:56 2014
@@ -395,18 +395,25 @@ public class SmapUtil {
int tag = readU1();
writeU1(tag);
switch (tag) {
-case 7 : // Class
-case 8 : // String
+case 7 : // Class
+case 8 : // String
+case 16 : // MethodType
if (log.isDebugEnabled())
log.debug(i + " copying 2 bytes");
copy(2);
break;
-case 9 : // Field
+case 15 : // MethodHandle
+if (log.isDebugEnabled())
+log.debug(i + " copying 3 bytes");
+copy(3);
+break;
+case 9 : // Field
case 10 : // Method
case 11 : // InterfaceMethod
-case 3 : // Integer
-case 4 : // Float
+case 3 : // Integer
+case 4 : // Float
case 12 : // NameAndType
+case 18 : // InvokeDynamic
if (log.isDebugEnabled())
log.debug(i + " copying 4 bytes");
copy(4);
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1579626&r1=1579625&r2=1579626&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Thu Mar 20 13:53:56 2014
@@ -45,6 +45,14 @@
issues to not "pop up" wrt. others).
-->
+
+
+
+54475: Add Java 8 support to SMAP generation for JSPs. Patch
+by Robbie Gibson. (markt)
+
+
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.4
On 19/03/2014 21:14, Mark Thomas wrote: > [X] Beta - go ahead and release as 8.0.4 (beta) Unit tests pass for BIO, NIO and APR on Windows, OSX and Linux Unit tests pass for NIO2 on OSX and Linux Unit tests hang for NIO2 on Windows (not an issue since NIO2 is still experimental) Beta because: - the cookie issues still need to be resolved - there are a lot of big changes in this release But I think we are getting close to stable. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.4
2014-03-20 14:58 GMT+01:00 Mark Thomas : > Unit tests hang for NIO2 on Windows (not an issue since NIO2 is still > experimental) > I got curious so I installed Java on my Windows. This didn't hang for me, and there were no failures on the "big" IO tests. Platform: Java 8 + Win 8.1-64 + your 8.0.4 source bundle (88s overdose ah) Issues: - Some tests fails on i18n on HTTP status other than 200 (I'll try to fix that) - Some SSL tests fail - Some other fails elsewhere (EL, org.apache.jasper.tagplugins.jstl.core.TestForEach compilation error, a UTF8 fail) So all except the i18n look caused by using Java 8. Complete FAIL list (except status line i18n): TEST-javax.el.TestResourceBundleELResolver.NIO2.txt:FAILED TEST-org.apache.catalina.startup.TestTomcat.NIO2.txt:FAILED TEST-org.apache.jasper.tagplugins.jstl.core.TestForEach.NIO2.txt:FAILED TEST-org.apache.jasper.tagplugins.jstl.core.TestForEach.NIO2.txt:FAILED TEST-org.apache.tomcat.util.buf.TestUtf8.NIO2.txt:FAILED TEST-org.apache.tomcat.util.net.TestCustomSsl.NIO2.txt:FAILED TEST-org.apache.tomcat.util.net.TestSsl.NIO2.txt:FAILED TEST-org.apache.tomcat.util.net.TestSsl.NIO2.txt:FAILED Rémy
svn commit: r1579662 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/jasper/compiler/SmapUtil.java webapps/docs/changelog.xml
Author: markt
Date: Thu Mar 20 15:24:50 2014
New Revision: 1579662
URL: http://svn.apache.org/r1579662
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54475
Add Java 8 support to SMAP generation for JSPs.
Patch by Robbie Gibson.
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/jasper/compiler/SmapUtil.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
Propchange: tomcat/tc7.0.x/trunk/
--
Merged /tomcat/trunk:r1579626
Modified: tomcat/tc7.0.x/trunk/java/org/apache/jasper/compiler/SmapUtil.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/jasper/compiler/SmapUtil.java?rev=1579662&r1=1579661&r2=1579662&view=diff
==
--- tomcat/tc7.0.x/trunk/java/org/apache/jasper/compiler/SmapUtil.java
(original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/jasper/compiler/SmapUtil.java Thu Mar
20 15:24:50 2014
@@ -392,18 +392,25 @@ public class SmapUtil {
int tag = readU1();
writeU1(tag);
switch (tag) {
-case 7 : // Class
-case 8 : // String
+case 7 : // Class
+case 8 : // String
+case 16 : // MethodType
if (log.isDebugEnabled())
log.debug(i + " copying 2 bytes");
copy(2);
break;
-case 9 : // Field
+case 15 : // MethodHandle
+if (log.isDebugEnabled())
+log.debug(i + " copying 3 bytes");
+copy(3);
+break;
+case 9 : // Field
case 10 : // Method
case 11 : // InterfaceMethod
-case 3 : // Integer
-case 4 : // Float
+case 3 : // Integer
+case 4 : // Float
case 12 : // NameAndType
+case 18 : // InvokeDynamic
if (log.isDebugEnabled())
log.debug(i + " copying 4 bytes");
copy(4);
Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1579662&r1=1579661&r2=1579662&view=diff
==
--- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Thu Mar 20 15:24:50 2014
@@ -55,6 +55,7 @@
They eventually become mixed with the numbered issues. (I.e., numbered
issues to not "pop up" wrt. others).
-->
+<<< .working
@@ -129,6 +130,10 @@
+54475: Add Java 8 support to SMAP generation for JSPs. Patch
+by Robbie Gibson. (markt)
+
+
55483: Improve handing of overloaded methods and
constructors
in expression language implementation. (markt)
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1579663 - /tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
Author: markt Date: Thu Mar 20 15:28:48 2014 New Revision: 1579663 URL: http://svn.apache.org/r1579663 Log: Fix merge Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1579663&r1=1579662&r2=1579663&view=diff == --- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original) +++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Thu Mar 20 15:28:48 2014 @@ -55,7 +55,6 @@ They eventually become mixed with the numbered issues. (I.e., numbered issues to not "pop up" wrt. others). --> -<<< .working - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1579664 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Thu Mar 20 15:32:44 2014 New Revision: 1579664 URL: http://svn.apache.org/r1579664 Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1579664&r1=1579663&r2=1579664&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Mar 20 15:32:44 2014 @@ -63,6 +63,13 @@ PATCHES PROPOSED TO BACKPORT: +1: markt -1: +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54475 + Add Java 8 support to SMAP generation for JSPs. + Patch by Robbie Gibson. + http://people.apache.org/~markt/patches/2014-03-20-smap-java8-tc6-v1.patch + +1: markt + -1: + PATCHES/ISSUES THAT ARE STALLED: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56293] WebappClassLoader does not cache META-INF/services which leads to performance issues
https://issues.apache.org/bugzilla/show_bug.cgi?id=56293 --- Comment #2 from Michael Thiele --- Created attachment 31417 --> https://issues.apache.org/bugzilla/attachment.cgi?id=31417&action=edit Example .war and maven projects for the META-INF/services caching problem I have built a small example of what happens in our code. Deployment in Tomcat 7.0.27 and 7.0.28 should render different results (time needed is increased by factor 10 with META-INF/services) when accessing the root path, e.g., http://localhost:8080/tomcat.caching-0.0.1-SNAPSHOT/. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1579672 - in /tomcat/trunk/test/org/apache: catalina/comet/TestCometProcessor.java catalina/startup/TomcatBaseTest.java coyote/http11/upgrade/TestUpgrade.java
Author: remm
Date: Thu Mar 20 15:51:58 2014
New Revision: 1579672
URL: http://svn.apache.org/r1579672
Log:
Handle possible status line i18n in tests.
Modified:
tomcat/trunk/test/org/apache/catalina/comet/TestCometProcessor.java
tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java
tomcat/trunk/test/org/apache/coyote/http11/upgrade/TestUpgrade.java
Modified: tomcat/trunk/test/org/apache/catalina/comet/TestCometProcessor.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/comet/TestCometProcessor.java?rev=1579672&r1=1579671&r2=1579672&view=diff
==
--- tomcat/trunk/test/org/apache/catalina/comet/TestCometProcessor.java
(original)
+++ tomcat/trunk/test/org/apache/catalina/comet/TestCometProcessor.java Thu Mar
20 15:51:58 2014
@@ -340,7 +340,7 @@ public class TestCometProcessor extends
// Failure at any later stage and the response headers (including
// the 200 response code will already have been sent to the client
if (SimpleCometServlet.FAIL_ON_BEGIN.equals(initParam)) {
-assertEquals("HTTP/1.1 500 Internal Server Error",
response[0]);
+assertEquals("500", getStatusCode(response[0]));
alv.validateAccessLog(1, 500, 0, 1000);
} else {
assertEquals("HTTP/1.1 200 OK", response[0]);
Modified: tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java?rev=1579672&r1=1579671&r2=1579672&view=diff
==
--- tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java (original)
+++ tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java Thu Mar
20 15:51:58 2014
@@ -400,6 +400,14 @@ public abstract class TomcatBaseTest ext
return rc;
}
+protected static String getStatusCode(String statusLine) {
+if (statusLine == null || statusLine.length() < 12) {
+return statusLine;
+} else {
+return statusLine.substring(9, 12);
+}
+}
+
private static class TomcatWithFastSessionIDs extends Tomcat {
@Override
Modified: tomcat/trunk/test/org/apache/coyote/http11/upgrade/TestUpgrade.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/coyote/http11/upgrade/TestUpgrade.java?rev=1579672&r1=1579671&r2=1579672&view=diff
==
--- tomcat/trunk/test/org/apache/coyote/http11/upgrade/TestUpgrade.java
(original)
+++ tomcat/trunk/test/org/apache/coyote/http11/upgrade/TestUpgrade.java Thu Mar
20 15:51:58 2014
@@ -180,8 +180,7 @@ public class TestUpgrade extends TomcatB
String status = reader.readLine();
Assert.assertNotNull(status);
-Assert.assertEquals("HTTP/1.1 101 Switching Protocols",
-status.substring(0, 32));
+Assert.assertEquals("101", getStatusCode(status));
// Skip the remaining response headers
String line = reader.readLine();
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
buildbot failure in ASF Buildbot on tomcat-7-trunk
The Buildbot has detected a new failure on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/1823 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source Stamp: [branch tomcat/tc7.0.x/trunk] 1579663 Blamelist: markt BUILD FAILED: failed compile_1 sincerely, -The Buildbot
buildbot failure in ASF Buildbot on tomcat-trunk
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/5618 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source Stamp: [branch tomcat/trunk] 1579626 Blamelist: markt BUILD FAILED: failed compile_1 sincerely, -The Buildbot
[Bug 56293] WebappClassLoader does not cache META-INF/services which leads to performance issues
https://issues.apache.org/bugzilla/show_bug.cgi?id=56293 --- Comment #3 from Mark Thomas --- Thanks for the test case. It appears that the ServiceLoader code isn't used and it is clear that the code path where caching was removed is used. I agree that caching the contents META-INF/services id probably the way to go but I think there will need to be some form of limit just in case there is a large file there for some strange reason. I'm looking into a fix now. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1579704 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: kkolinko Date: Thu Mar 20 18:37:04 2014 New Revision: 1579704 URL: http://svn.apache.org/r1579704 Log: votes Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1579704&r1=1579703&r2=1579704&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Mar 20 18:37:04 2014 @@ -38,12 +38,21 @@ PATCHES PROPOSED TO BACKPORT: * Fix possible overflow when parsing long values from a byte array. http://people.apache.org/~markt/patches/2014-03-18-ascii-tc6.patch - +1: markt + +1: markt, kkolinko -1: * Add Java 8 support to Jasper's default configuration http://people.apache.org/~markt/patches/2014-03-19-Jasper-Java8-tc6-v1.patch +1: markt + +0: kkolinko: + - See r1557990. There are noTldJars lists in TldConfig, TldLocationsCache + that have to be updated. Maybe add support for "ecj-*.jar" pattern + there? (If not, then just add "4.3.2" and "P20140317-1600" versions). + + - Technically CompilerOptions.VERSION_1_8 is a String constant "1.8", + so it will be inlined at compile time. At runtime Jasper will be + compatible with any earlier versions of ecj 4.3.x. + Thus I am OK with this change. -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56265 @@ -54,7 +63,7 @@ PATCHES PROPOSED TO BACKPORT: * Update tc-native to 1.1.29 http://people.apache.org/~markt/patches/2014-03-19-tc-native-tc6-v1.patch - +1: markt + +1: markt, kkolinko -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56275 @@ -67,7 +76,7 @@ PATCHES PROPOSED TO BACKPORT: Add Java 8 support to SMAP generation for JSPs. Patch by Robbie Gibson. http://people.apache.org/~markt/patches/2014-03-20-smap-java8-tc6-v1.patch - +1: markt + +1: markt, kkolinko -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56027] Unable to use TCN on RHEL6 boxes if box is booted in fips mode
https://issues.apache.org/bugzilla/show_bug.cgi?id=56027 --- Comment #13 from Christopher Schultz --- (In reply to Ben Mason from comment #12) > ...that will not fix problem #2, > correct? I am seeing that on SLES 11 as well. Do you need someone to > contribute a fix for #2, or is someone working on that? I'm out of my element, there. If you've got a proposal and are willing to work on a patch, please do so. The assertion that 512-bit RSA is not valid for FIPS mode certainly seems reasonable. AFAIK, there's nothing in FIPS that established an *upper* limit on key size, or that the implementation must actually use clearly inferior algorithms. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
buildbot success in ASF Buildbot on tomcat-trunk
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/5619 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source Stamp: [branch tomcat/trunk] 1579672 Blamelist: remm Build succeeded! sincerely, -The Buildbot
[Bug 53367] Database failure may cause pool to hang
https://issues.apache.org/bugzilla/show_bug.cgi?id=53367 --- Comment #7 from Christopher Schultz --- How about Tomcat 7.0.52 -- the latest? Also, you haven't provided any indication that this is a problem with the pool... it could just be misuse of the pool. You'll need configuration, thread dumps, etc. to justify reopening this bug. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1579428 - /tomcat/tc6.0.x/trunk/STATUS.txt
Mark, On 3/19/14, 6:35 PM, ma...@apache.org wrote: > Author: markt > Date: Wed Mar 19 22:35:46 2014 > New Revision: 1579428 > > URL: http://svn.apache.org/r1579428 > Log: > Proposal > > Modified: > tomcat/tc6.0.x/trunk/STATUS.txt > > Modified: tomcat/tc6.0.x/trunk/STATUS.txt > URL: > http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1579428&r1=1579427&r2=1579428&view=diff > == > --- tomcat/tc6.0.x/trunk/STATUS.txt (original) > +++ tomcat/tc6.0.x/trunk/STATUS.txt Wed Mar 19 22:35:46 2014 > @@ -57,6 +57,12 @@ PATCHES PROPOSED TO BACKPORT: >+1: markt >-1: > > +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56275 > + Fix memory leak if a Filter throws an exception during its destroy() method > + http://people.apache.org/~markt/patches/2014-03-19-bug56275-tc6-v1.patch > + +1: markt > + -1: > + I can't seem to find the original patch against Tomcat 7.0 to ask about this, but I wanted to know who you removed the setFilterDef method -- it seemed to provide the useful service of decommissioning any Filter that had already been started. Is that something that never actually happens? Thanks, -chris signature.asc Description: OpenPGP digital signature
Re: svn commit: r1579428 - /tomcat/tc6.0.x/trunk/STATUS.txt
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 20/03/2014 19:58, Christopher Schultz wrote: > Mark, > > On 3/19/14, 6:35 PM, ma...@apache.org wrote: >> Author: markt Date: Wed Mar 19 22:35:46 2014 New Revision: >> 1579428 >> >> URL: http://svn.apache.org/r1579428 Log: Proposal >> >> Modified: tomcat/tc6.0.x/trunk/STATUS.txt >> >> Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: >> http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1579428&r1=1579427&r2=1579428&view=diff >> >> == >> --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ >> tomcat/tc6.0.x/trunk/STATUS.txt Wed Mar 19 22:35:46 2014 @@ -57,6 >> +57,12 @@ PATCHES PROPOSED TO BACKPORT: +1: markt -1: >> >> +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56275 + >> Fix memory leak if a Filter throws an exception during its >> destroy() method + >> http://people.apache.org/~markt/patches/2014-03-19-bug56275-tc6-v1.patch >> >> + +1: markt >> + -1: + > > I can't seem to find the original patch against Tomcat 7.0 to ask > about this, The web interface is probably the easiest way to find that. (There are actually several patches pulled into this one). > but I wanted to know who you removed the setFilterDef method -- it > seemed to provide the useful service of decommissioning any Filter > that had already been started. Is that something that never > actually happens? Correct. It was never called. Mark -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (MingW32) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTK0jcAAoJEBDAHFovYFnn8l4P/2qT0nxVsjnxL8N99nLowbPa eLa5MJJkAB2c2yumfdGChLudMt0eYO3R0GtWJLo2K/Xb8/xO8txfKh1D6jNJRFR2 os/+lzB21pFXiP0qpmZewFpI+RHpN4UoN3CHzsOnLotONK9tOLrtbgIZlnnk57QW fSe86782UE+zHsAD/qH80Kkcnx9SQNmVO6e1onvIFSuroCHBx+cJg1Io0GPQf0BX jCMAIlgoZ5h9KpSRH5RCC6I1XbfTw35lklT62NSHHeAeGwCuKkBTTHYufwKa4y0v QE+o5UMox5glm6G7jEVMEuREx1DXj9RBIccq7XIgO+gW5hGBkzikaKz7cYVUwuNw SzjtMUD7fFlpA6keFN3MTiBLhjlXDZA49lp5hRHzygm6SVmidarPINIIqD9WJxDc sTNBt5vi1zxwRUS/qJhjDnqv+FNCcWWIEb2O5VnR5yTux5a7J6t+XpxHzcwAg31g WOJoGYls5tpMUDAEvny0Jh6WLYDu3l2EBIl/Ysh3IXIKPSCoR6wb++EMsxzP2yJE S3zp3ol07xiU1NPctyf00OGjb+7pAMG+qUsEu2+WrPWJzy+h49XYQSjzJDaY+G8F aKPIRx1qLydBddIyM0zThgd0/a//rOUX7OMBvdvFijUrQxmT/WTn4OrM/d3aSCI2 PA9RuJp04dEN9cPl242B =gssg -END PGP SIGNATURE- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56027] Unable to use TCN on RHEL6 boxes if box is booted in fips mode
https://issues.apache.org/bugzilla/show_bug.cgi?id=56027 --- Comment #14 from Rob Sanders --- I remember reading some of the SSL docs that certain key lengths may be invalid for regular use, they are valid for key agreement/establishment. Quoting from the somewhat confusing section 2.6.2 of the OpenSSL FIPS140 Userguide (v2.0) PDF: === Algorithms Available in FIPS Mode Only the algorithms listed in tables 4a and 4b of the Security Policy are allowed in FIPS mode. Note that Diffie-Hellman and RSA are allowed in FIPS mode for key agreement and key establishment even though they are “Non-Approved” for that purpose. RSA for sign and verify is “Approved” and hence also allowed, along with all the other Approved algorithms listed in that table === Rather than hardcode in TCN what approved keys are, is there a way to ask the underlying openssl implementation what *it* thinks are acceptable? I don't have an answer for that. What I did to make things work back in January was comment out the 512 bit RSA key generation in TCN before building (along with adding a check to see if FIPS mode was already set). -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1579735 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: schultz Date: Thu Mar 20 21:03:19 2014 New Revision: 1579735 URL: http://svn.apache.org/r1579735 Log: Votes Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1579735&r1=1579734&r2=1579735&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Mar 20 21:03:19 2014 @@ -34,11 +34,18 @@ PATCHES PROPOSED TO BACKPORT: entities. http://people.apache.org/~markt/patches/2014-03-17-globalXsltFile-tc6-v1.patch +1: markt + -1: schultz: The idea of the patch is fine: I'm actually +1. + I have some small nits: + 1. DocumentBuilderFactory is not thread-safe, and shouldn't + be shared. 2. Two instances of swallowing IOException + when closing File streams. We should at least log a warning. + It looks like there is an opportinity to use StringBuilder + instead of StringBuffer, there, too, if you want. -1: * Fix possible overflow when parsing long values from a byte array. http://people.apache.org/~markt/patches/2014-03-18-ascii-tc6.patch - +1: markt, kkolinko + +1: markt, kkolinko, schultz -1: * Add Java 8 support to Jasper's default configuration @@ -63,20 +70,20 @@ PATCHES PROPOSED TO BACKPORT: * Update tc-native to 1.1.29 http://people.apache.org/~markt/patches/2014-03-19-tc-native-tc6-v1.patch - +1: markt, kkolinko + +1: markt, kkolinko, schultz -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56275 Fix memory leak if a Filter throws an exception during its destroy() method http://people.apache.org/~markt/patches/2014-03-19-bug56275-tc6-v1.patch - +1: markt + +1: markt, schultz -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54475 Add Java 8 support to SMAP generation for JSPs. Patch by Robbie Gibson. http://people.apache.org/~markt/patches/2014-03-20-smap-java8-tc6-v1.patch - +1: markt, kkolinko + +1: markt, kkolinko, schultz -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.4
Hi, 2014-03-19 23:14 GMT+02:00 Mark Thomas : > > The proposed Apache Tomcat 8.0.4 release is now available for voting. > > The main changes since 8.0.3 are: > - Update Eclipse JDT compiler to enable full Java 8 support for JSPs in > the default configuration > - Add new, experimental HTTP and AJP connectors based on NIO2 > - Update the default connection pooling based on a repackaged Commons > DBCP 2 to use the Commons DBCP 2.0 release > > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.4/ > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1008/ > The svn tag is: > http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_4/ > > The proposed 8.0.4 release is: > [ ] Broken - do not release > [ ] Alpha - go ahead and release as 8.0.4 (alpha) > [X] Beta - go ahead and release as 8.0.4 (beta) > [ ] Stable - go ahead and release as 8.0.4 (stable) Checked with applications that use the new specifications features. Regards, Violeta > Cheers, > > Mark > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org >
Time for Tomcat 7.0.53
Hi, I will tag Tomcat 7.0.53 later today. If you want to add something in addition, reply here. Regards Violeta
