svn commit: r1395940 - in /tomcat/site/trunk: ./ docs/ xdocs/

2012-10-09 Thread markt
Author: markt
Date: Tue Oct  9 10:14:35 2012
New Revision: 1395940

URL: http://svn.apache.org/viewvc?rev=1395940&view=rev
Log:
Updates (apart from docs) for 7.0.32 release

Modified:
tomcat/site/trunk/build.properties.default
tomcat/site/trunk/docs/doap_Tomcat.rdf
tomcat/site/trunk/docs/download-70.html
tomcat/site/trunk/docs/index.html
tomcat/site/trunk/docs/migration-7.html
tomcat/site/trunk/docs/oldnews.html
tomcat/site/trunk/docs/whichversion.html
tomcat/site/trunk/xdocs/doap_Tomcat.rdf
tomcat/site/trunk/xdocs/download-70.xml
tomcat/site/trunk/xdocs/index.xml
tomcat/site/trunk/xdocs/migration-7.xml
tomcat/site/trunk/xdocs/oldnews.xml
tomcat/site/trunk/xdocs/whichversion.xml

Modified: tomcat/site/trunk/build.properties.default
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/build.properties.default?rev=1395940&r1=1395939&r2=1395940&view=diff
==
--- tomcat/site/trunk/build.properties.default (original)
+++ tomcat/site/trunk/build.properties.default Tue Oct  9 10:14:35 2012
@@ -38,7 +38,7 @@ tomcat.loc=http://www.apache.org/dist/to
 # - Tomcat versions -
 tomcat55=5.5.35
 tomcat60=6.0.35
-tomcat70=7.0.30
+tomcat70=7.0.32
 
 
 # - Download destination -

Modified: tomcat/site/trunk/docs/doap_Tomcat.rdf
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/doap_Tomcat.rdf?rev=1395940&r1=1395939&r2=1395940&view=diff
==
--- tomcat/site/trunk/docs/doap_Tomcat.rdf (original)
+++ tomcat/site/trunk/docs/doap_Tomcat.rdf Tue Oct  9 10:14:35 2012
@@ -55,8 +55,8 @@
 
   
 Latest Stable 7.0.x Release
-2012-09-06
-7.0.30
+2012-10-09
+7.0.32
   
 
 

Modified: tomcat/site/trunk/docs/download-70.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/download-70.html?rev=1395940&r1=1395939&r2=1395940&view=diff
==
--- tomcat/site/trunk/docs/download-70.html (original)
+++ tomcat/site/trunk/docs/download-70.html Tue Oct  9 10:14:35 2012
@@ -218,8 +218,8 @@
 
 
 http://www.apache.org/dist/tomcat/tomcat-7/KEYS";>KEYS |
-7.0.30 |
-Browse 
|
+7.0.32 |
+Browse 
|
 http://archive.apache.org/dist/tomcat/tomcat-7";>Archives
   
 
@@ -307,7 +307,7 @@
 
 
 
-7.0.30
+7.0.32
 
 
 
@@ -316,8 +316,8 @@
   
 
   
-Please see the 
-  README
+Please see the 
+  README
   file for packaging information.  It explains what every distribution 
contains.
   
 
@@ -338,44 +338,44 @@
   
 
 
-zip 
-(http://www.apache.org/dist/tomcat/tomcat-7/v7.0.30/bin/apache-tomcat-7.0.30.zip.asc";>pgp,
 
-http://www.apache.org/dist/tomcat/tomcat-7/v7.0.30/bin/apache-tomcat-7.0.30.zip.md5";>md5)
+zip 
+(http://www.apache.org/dist/tomcat/tomcat-7/v7.0.32/bin/apache-tomcat-7.0.32.zip.asc";>pgp,
 
+http://www.apache.org/dist/tomcat/tomcat-7/v7.0.32/bin/apache-tomcat-7.0.32.zip.md5";>md5)
   
   
 
 
-tar.gz 
-(http://www.apache.org/dist/tomcat/tomcat-7/v7.0.30/bin/apache-tomcat-7.0.30.tar.gz.asc";>pgp,
 
-http://www.apache.org/dist/tomcat/tomcat-7/v7.0.30/bin/apache-tomcat-7.0.30.tar.gz.md5";>md5)
+tar.gz 
+(http://www.apache.org/dist/tomcat/tomcat-7/v7.0.32/bin/apache-tomcat-7.0.32.tar.gz.asc";>pgp,
 
+http://www.apache.org/dist/tomcat/tomcat-7/v7.0.32/bin/apache-tomcat-7.0.32.tar.gz.md5";>md5)
   
   
 
 
-32-bit Windows zip 
-(http://www.apache.org/dist/tomcat/tomcat-7/v7.0.30/bin/apache-tomcat-7.0.30-windows-x86.zip.asc";>pgp,
 
-http://www.apache.org/dist/tomcat/tomcat-7/v7.0.30/bin/apache-tomcat-7.0.30-windows-x86.zip.md5";>md5)
+32-bit Windows zip 
+(http://www.apache.org/dist/tomcat/tomcat-7/v7.0.32/bin/apache-tomcat-7.0.32-windows-x86.zip.asc";>pgp,
 
+http://www.apache.org/dist/tomcat/tomcat-7/v7.0.32/bin/apache-tomcat-7.0.32-windows-x86.zip.md5";>md5)
   
   
 
 
-64-bit Windows zip 
-(http://www.apache.org/dist/tomcat/tomcat-7/v7.0.30/bin/apache-tomcat-7.0.30-windows-x64.zip.asc";>pgp,
 
-http://www.apache.org/dist/tomcat/tomcat-7/v7.0.30/bin/apache-tomcat-7.0.30-windows-x64.zip.md5";>md5)
+64-bit Windows zip 
+(http://www.apache.org/dist/tomcat/tomcat-7/v7.0.32/bin/apache-tomcat-7.0.32-windows-x64.zip.asc";>pgp,
 
+http://www.apache.org/dist/tomcat/tomcat-7/v7.0.32/bin/apache-tomcat-7.0.32-windows-x64.zip.md5";>md5)
   
   
 
 
-64-bit Itanium Windows zip 
-(http://www.apache.org/dist/tomcat/tomcat-7/v7.0.30/bin/apache-tomcat-7.0.30-windows-i64.zip.asc";>pgp,
 
-http:/

svn commit: r1395942 - in /tomcat/site/trunk/docs/tomcat-7.0-doc: ./ api/ api/org/apache/catalina/ api/org/apache/catalina/ant/ api/org/apache/catalina/ant/jmx/ api/org/apache/catalina/authenticator/

2012-10-09 Thread markt
Author: markt
Date: Tue Oct  9 10:27:21 2012
New Revision: 1395942

URL: http://svn.apache.org/viewvc?rev=1395942&view=rev
Log:
Update docs for Tomcat 7.0.32


[This commit notification would consist of 51 parts, 
which exceeds the limit of 50 ones, so it was shortened to the summary.]

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1395945 - /tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

2012-10-09 Thread markt
Author: markt
Date: Tue Oct  9 10:35:56 2012
New Revision: 1395945

URL: http://svn.apache.org/viewvc?rev=1395945&view=rev
Log:
Announcement will go out once web site syncs

Modified:
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1395945&r1=1395944&r2=1395945&view=diff
==
--- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Tue Oct  9 10:35:56 2012
@@ -53,7 +53,7 @@
   They eventually become mixed with the numbered issues. (I.e., numbered
   issues to not "pop up" wrt. others).
 -->
-
+
   
 
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 5.5.36

2012-10-09 Thread Mark Thomas
Ping.

One more PMC +1 is required for this release.

Mark

On 05/10/2012 14:49, Mark Thomas wrote:
> The proposed Apache Tomcat 5.5.36 release is now available for voting.
> 
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-5/v5.5.36/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc5.5.x/tags/TOMCAT_5_5_36/
> 
> The proposed 5.5.36 release is:
> [ ] Broken - do not release
> [ ] Stable - go ahead and release as 5.5.36 Stable
> 
> Note that this is expected to be the last 5.5.x release.
> 
> Cheers,
> 
> Mark
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[ANN] Apache Tomcat 7.0.32 released

2012-10-09 Thread Mark Thomas
The Apache Tomcat team announces the immediate availability of Apache
Tomcat 7.0.32.

Apache Tomcat is an open source software implementation of the Java
Servlet and JavaServer Pages technologies.

This release contains a small number of bug fixes and improvements
compared to version 7.0.30. The notable changes include:
- A new option to automatically remove old, unused versions (ones where
  there are no longer any active sessions) of applications deployed
  using parallel deployment.
- Faster parsing of JSPs.
- Making the members and deployer associated with a cluster visible via
  JMX.

Please refer to the change log for the complete list of changes:
http://tomcat.apache.org/tomcat-7.0-doc/changelog.html

Note: This version has 4 zip binaries: a generic one and three
  bundled with Tomcat native binaries for Windows operating systems
  running on different CPU architectures.

Note: If you use the APR/native AJP or HTTP connector you *must* upgrade
  to version 1.1.24 or later of the AJP/native library

Downloads:
http://tomcat.apache.org/download-70.cgi

Migration guides from Apache Tomcat 5.5.x and 6.0.x:
http://tomcat.apache.org/migration.html

Thank you,

-- The Apache Tomcat Team

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 5.5.36

2012-10-09 Thread Konstantin Kolinko
2012/10/5 Mark Thomas :
> The proposed Apache Tomcat 5.5.36 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-5/v5.5.36/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc5.5.x/tags/TOMCAT_5_5_36/
>
> The proposed 5.5.36 release is:
> [ ] Broken - do not release
> [x] Stable - go ahead and release as 5.5.36 Stable
>

Content of distributive files is OK. No changes / omissions noted.

Regarding files on dist.a.o:
1. There exists
/repos/dist/release/tomcat/tomcat-5/README.html

Note that has to be manually updated to mention the new version once
the release is published.

2. There is no README.html in
/repos/dist/dev/tomcat/tomcat-5/v5.5.36/
but there was one in 5.5.35
/repos/dist/release/tomcat/tomcat-5/v5.5.35/


Tested zip and exe binary distributions using Win XP JDK 6u35 32-bit,
running with security manager enabled, with BIO and APR connectors
(Native 1.1.24).

All is OK.

The "Thread Dump" command on Tomcat service manager icon in the tray
area fails with "Unable to open the Event Mutex". It is a known issue
in Apache Commons Daemon 1.0.10,
https://issues.apache.org/jira/browse/DAEMON-252

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GUMP@vmgump]: Project tomcat-taglibs-standard (in module tomcat-taglibs) failed

2012-10-09 Thread Gump
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-taglibs-standard has an issue affecting its community 
integration.
This issue affects 2 projects,
 and has been outstanding for 122 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-taglibs-standard :  Standard Taglib
- tomcat-taglibs-standard-install :  JSP Taglibs


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-taglibs/tomcat-taglibs-standard/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -INFO- Optional dependency httpunit failed with reason build failed
 -DEBUG- (Apache Gump generated) Apache Maven Settings in: 
/srv/gump/public/workspace/tomcat-taglibs/standard/gump_mvn_settings.xml
 -INFO- Failed with reason build failed
 -DEBUG- Maven POM in: 
/srv/gump/public/workspace/tomcat-taglibs/standard/pom.xml
 -INFO- Failed to extract fallback artifacts from Gump Repository



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-taglibs/tomcat-taglibs-standard/gump_work/build_tomcat-taglibs_tomcat-taglibs-standard.html
Work Name: build_tomcat-taglibs_tomcat-taglibs-standard (Type: Build)
Work ended in a state of : Failed
Elapsed: 23 secs
Command Line: /opt/maven2/bin/mvn --batch-mode -DskipTests=true --settings 
/srv/gump/public/workspace/tomcat-taglibs/standard/gump_mvn_settings.xml 
install 
[Working Directory: /srv/gump/public/workspace/tomcat-taglibs/standard]
M2_HOME: /opt/maven2
-
[INFO] [compiler:compile {execution: default-compile}]
[INFO] Nothing to compile - all classes are up to date
[debug] execute contextualize
[INFO] [resources:testResources {execution: default-testResources}]
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 
/srv/gump/public/workspace/tomcat-taglibs/standard/spec/src/test/resources
[INFO] Copying 3 resources
[INFO] [compiler:testCompile {execution: default-testCompile}]
[INFO] No sources to compile
[INFO] [surefire:test {execution: default-test}]
[INFO] Tests are skipped.
[INFO] [bundle:bundle {execution: default-bundle}]
[INFO] [install:install {execution: default-install}]
[INFO] Installing 
/srv/gump/public/workspace/tomcat-taglibs/standard/spec/target/taglibs-standard-spec-1.2-SNAPSHOT.jar
 to 
/srv/gump/public/workspace/mvnlocalrepo/shared/org/apache/taglibs/taglibs-standard-spec/1.2-SNAPSHOT/taglibs-standard-spec-1.2-SNAPSHOT.jar
[INFO] [bundle:install {execution: default-install}]
[INFO] Parsing 
file:/srv/gump/public/workspace/mvnlocalrepo/shared/repository.xml
[INFO] Installing 
org/apache/taglibs/taglibs-standard-spec/1.2-SNAPSHOT/taglibs-standard-spec-1.2-SNAPSHOT.jar
[INFO] Writing OBR metadata
[INFO] 
[INFO] Building JSTL Implementation
[INFO]task-segment: [install]
[INFO] 
[INFO] [remote-resources:process {execution: default}]
[INFO] snapshot org.apache.taglibs:taglibs-standard-spec:1.2-SNAPSHOT: checking 
for updates from apache.snapshots
[debug] execute contextualize
[INFO] [resources:resources {execution: default-resources}]
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 14 resources
[INFO] Copying 3 resources
[INFO] [compiler:compile {execution: default-compile}]
[INFO] Compiling 96 source files to 
/srv/gump/public/workspace/tomcat-taglibs/standard/impl/target/classes
[INFO] -
[ERROR] COMPILATION ERROR : 
[INFO] -
[ERROR] 
/srv/gump/public/workspace/tomcat-taglibs/standard/impl/src/main/java/org/apache/taglibs/standard/tag/common/sql/DataSourceWrapper.java:[38,7]
 error: DataSourceWrapper is not abstract and does not override abstract method 
getParentLogger() in CommonDataSource
[INFO] 1 error
[INFO] -
[INFO] 
[ERROR] BUILD FAILURE
[INFO] 
[INFO] Compilation failure
/srv/gump/public/workspace/tomcat-taglibs/standard/impl/src/main/java/org/apache/taglibs/standard/tag/common/sql/DataSourceWrapper.java:[38,7]
 error: DataSourceWrapper is not abstract and does not override abstract method 
getParentLogger() in CommonDataSource

[INFO] 
[INFO] For more information, run Maven with the -e switch
[INFO] --

svn commit: r901 - /dev/tomcat/tomcat-5/v5.5.36/README.html

2012-10-09 Thread markt
Author: markt
Date: Tue Oct  9 17:13:20 2012
New Revision: 901

Log:
Add missing file noted in review from kkolinko

Added:
dev/tomcat/tomcat-5/v5.5.36/README.html
  - copied, changed from r806, release/tomcat/tomcat-5/v5.5.35/README.html

Copied: dev/tomcat/tomcat-5/v5.5.36/README.html (from r806, 
release/tomcat/tomcat-5/v5.5.35/README.html)
==
--- release/tomcat/tomcat-5/v5.5.35/README.html (original)
+++ dev/tomcat/tomcat-5/v5.5.36/README.html Tue Oct  9 17:13:20 2012
@@ -15,12 +15,12 @@
   limitations under the License.
 -->
 
-Apache Tomcat 5.5.35
+Apache Tomcat 5.5.36
 
 
 
 
-Apache Tomcat 5.5.35
+Apache Tomcat 5.5.36
 
 Useful references:
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r901 - /dev/tomcat/tomcat-5/v5.5.36/README.html

2012-10-09 Thread markt
Author: markt
Date: Tue Oct  9 17:13:20 2012
New Revision: 901

Log:
Add missing file noted in review from kkolinko

Added:
dev/tomcat/tomcat-5/v5.5.36/README.html
  - copied, changed from r806, release/tomcat/tomcat-5/v5.5.35/README.html

Copied: dev/tomcat/tomcat-5/v5.5.36/README.html (from r806, 
release/tomcat/tomcat-5/v5.5.35/README.html)
==
--- release/tomcat/tomcat-5/v5.5.35/README.html (original)
+++ dev/tomcat/tomcat-5/v5.5.36/README.html Tue Oct  9 17:13:20 2012
@@ -15,12 +15,12 @@
   limitations under the License.
 -->
 
-Apache Tomcat 5.5.35
+Apache Tomcat 5.5.36
 
 
 
 
-Apache Tomcat 5.5.35
+Apache Tomcat 5.5.36
 
 Useful references:
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 5.5.36

2012-10-09 Thread Mark Thomas
On 09/10/2012 13:58, Konstantin Kolinko wrote:
> 2012/10/5 Mark Thomas :
>> The proposed Apache Tomcat 5.5.36 release is now available for voting.
>>
>> It can be obtained from:
>> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-5/v5.5.36/
>> The svn tag is:
>> http://svn.apache.org/repos/asf/tomcat/tc5.5.x/tags/TOMCAT_5_5_36/
>>
>> The proposed 5.5.36 release is:
>> [ ] Broken - do not release
>> [x] Stable - go ahead and release as 5.5.36 Stable
>>
> 
> Content of distributive files is OK. No changes / omissions noted.
> 
> Regarding files on dist.a.o:
> 1. There exists
> /repos/dist/release/tomcat/tomcat-5/README.html
> 
> Note that has to be manually updated to mention the new version once
> the release is published.

Will do.

> 2. There is no README.html in
> /repos/dist/dev/tomcat/tomcat-5/v5.5.36/
> but there was one in 5.5.35
> /repos/dist/release/tomcat/tomcat-5/v5.5.35/

Fixed.

Thanks.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[VOTE][RESULT] Release Apache Tomcat 5.5.36

2012-10-09 Thread Mark Thomas
+1 (binding): markt, rjung, kkolinko

No other votes were cast.

The vote therefore passes. I'll start the release process.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r902 - /dev/tomcat/tomcat-5/v5.5.36/ /release/tomcat/tomcat-5/v5.5.36/

2012-10-09 Thread markt
Author: markt
Date: Tue Oct  9 17:17:46 2012
New Revision: 902

Log:
Release 5.5.36

Added:
release/tomcat/tomcat-5/v5.5.36/
  - copied from r901, dev/tomcat/tomcat-5/v5.5.36/
Removed:
dev/tomcat/tomcat-5/v5.5.36/


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r902 - /dev/tomcat/tomcat-5/v5.5.36/ /release/tomcat/tomcat-5/v5.5.36/

2012-10-09 Thread markt
Author: markt
Date: Tue Oct  9 17:17:46 2012
New Revision: 902

Log:
Release 5.5.36

Added:
release/tomcat/tomcat-5/v5.5.36/
  - copied from r901, dev/tomcat/tomcat-5/v5.5.36/
Removed:
dev/tomcat/tomcat-5/v5.5.36/


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 53986] New: Comment end tag preceded directly by a dash causes JSP fail compilation

2012-10-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53986

  Priority: P2
Bug ID: 53986
  Assignee: dev@tomcat.apache.org
   Summary: Comment end tag preceded directly by a dash causes JSP
fail compilation
  Severity: normal
Classification: Unclassified
  Reporter: steve.ra...@yahoo.com
  Hardware: PC
Status: NEW
   Version: 7.0.32
 Component: Jasper
   Product: Tomcat 7

Created attachment 29466
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=29466&action=edit
JSP file to reproduce compilation error

I have a JSP file that contained a comment line as follows:
<%--- comment ---%>

Such a JSP compiles in Tomcat 7.0.30, but it does not compile in 7.0.32.  I’ve
attached a copy of a test file, which compiles in 7.0.30, but not in 7.0.32. 
The only related change I see in the release notes is
https://issues.apache.org/bugzilla/show_bug.cgi?id=53713.  

>From reading the JSP 2.2 spec, it appears that absent a specific comment about
whitespace, the rules of XML shall apply, which effectively means whitespace is
ignored.  This would seem to indicate this could be a regression introduced in
7.0.32, but since the spec is somewhat vague in the section about comments, 

ERROR 09 Oct 2012 11:15:25,190 [http-bio-8080-exec-8]
[com.liferay.portal.log.Co
mmonsLogImpl.error(52)] org.apache.jasper.JasperException:
/html/portal/layout/v
iew/portlet.jsp (line: 48, column: 6) Unterminated <%-- tag
at
org.apache.jasper.compiler.DefaultErrorHandler.jspError(DefaultErrorH
andler.java:42)
at
org.apache.jasper.compiler.ErrorDispatcher.dispatch(ErrorDispatcher.j
ava:408)
at
org.apache.jasper.compiler.ErrorDispatcher.jspError(ErrorDispatcher.j
ava:133)
at org.apache.jasper.compiler.Parser.parseComment(Parser.java:615)
at org.apache.jasper.compiler.Parser.parseElements(Parser.java:1425)
at org.apache.jasper.compiler.Parser.parse(Parser.java:138)
at
org.apache.jasper.compiler.ParserController.doParse(ParserController.
java:242)
at
org.apache.jasper.compiler.ParserController.parse(ParserController.ja
va:102)
at org.apache.jasper.compiler.Compiler.generateJava(Compiler.java:198)
at org.apache.jasper.compiler.Compiler.compile(Compiler.java:373)
at org.apache.jasper.compiler.Compiler.compile(Compiler.java:353)
at org.apache.jasper.compiler.Compiler.compile(Compiler.java:340)
at
org.apache.jasper.JspCompilationContext.compile(JspCompilationContext
.java:646)
at
org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper
.java:357)
at
org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:3
90)
at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:334)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:722)
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(Appl
icationFilterChain.java:305)
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationF
ilterChain.java:210)
at com.liferay.filters.strip.StripFilter.doFilter(StripFilter.java:260)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 53987] New: Log uncovered HTTP methods in combined security constraints

2012-10-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53987

  Priority: P2
Bug ID: 53987
  Assignee: dev@tomcat.apache.org
   Summary: Log uncovered HTTP methods in combined security
constraints
  Severity: enhancement
Classification: Unclassified
OS: Windows Server 2003
  Reporter: ma...@apache.org
  Hardware: PC
Status: NEW
   Version: trunk
 Component: Catalina
   Product: Tomcat 8

It is usually an error (and a security hole) if security constraints are
defined for some but not all HTTP methods for a given URL. If such a situation
is detected on web application start, log it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 53986] Comment end tag preceded directly by a dash causes JSP fail compilation

2012-10-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53986

Christopher Schultz  changed:

   What|Removed |Added

  Attachment #29466|application/octet-stream|text/plain
  mime type||

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Resources - Custom URL scheme for unified access

2012-10-09 Thread Mark Thomas
On 09/09/2012 20:13, Mark Thomas wrote:
> This is issue e) in Konstantin's comments in TOMCAT-NEXT.txt



> I think this boils down to "Is there a requirement for a scheme that
> provides unified URLs?" While it does hide the details of where stuff is
> from an application, if does so with a layer of indirection and that has
> a performance cost. Note: Performance / caching is a separate issue and
> I have already created a separate thread for that.

Aside: I haven't looked at what the overhead for implementing this might
be yet.

> If this feature is required, it can be added by modifying / wrapping the
> StandardRoot implementation. Currently, I think the only reason we might
> need this is if we need caching for performance then we'll need a custom
> URL scheme to ensure access via URLs goes through the cache. Therefore,
> in my view, resolving this issue depends on determining if caching (in a
> similar manner to the current implementation) is required.

Caching is definitely required. So, do we need to provide a custom URL
scheme?

Pros:
- Apps that use URLs would benefit from the cache

Neutral
- Hides real location and type of resource

Cons:
- Overhead
- URLs require encoding / decoding

If we do go this route I'd like to change the scheme from "jndi://" to
"tomcat://". This is for several reasons:
- I believe there was a complaint that "jndi://" clashed with another
  component.
- It makes clear the old and the new are very different and not
  compatible.


I'm very much on the fence at the moment as I don't have any hard
evidence for either the costs or the benefits of implementing this. I'm
leaning towards leaving this as a TBD, putting out an early milestone /
release candidate and getting some user feedback on performance.

Thoughts?

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 53986] Comment end tag preceded directly by a dash causes JSP fail compilation

2012-10-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53986

Christopher Schultz  changed:

   What|Removed |Added

 OS||All

--- Comment #1 from Christopher Schultz  ---
Confirmed broken in 7.0.32, working in 7.0.30.

I played-around with it a bit and it appears that any odd number of - symbols
before %> will cause the page to fail to compile (the original example has 7 -
symbols before the final %> in the comment).

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 53986] Comment end tag preceded directly by a dash causes JSP fail compilation

2012-10-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53986

--- Comment #2 from Christopher Schultz  ---
I thought there might be language in the spec to say that (like XML) the string
"--" cannot appear in the comment itself but that's not the case.

>From the 2.2 spec:
"
JSP.1.5.1.2 JSP Comments

A JSP comment is of the form
<%-- anything but a closing --%> ... --%>

The body of the content is ignored completely.
"

So this is both a regression and a spec violation.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Resources - merging back the changes

2012-10-09 Thread Mark Thomas
I believe from the various threads on the Resources implementation for
Tomcat 8 there is agreement that:

- DirContext is not the right basis for the Resources API
- Refactoring is required to simplify the multiple 'add-ons' and to
  provide a sound basis for overlays (which may slip to Servlet 3.2)
- Any Resources implementation must provide in-memory caching

The sandbox Resources implementation addresses all of the above and
passes the Servlet and JSP TCKs as well as all the unit tests.

Given the above, is there any objection to merging the changes made in
the sandbox back to trunk?

Note that the following TODOs remain:
- Provide an option to exclude selected resources from the cache
- Remove the DirContext code
- Review the use of trailing '/'
- Determine if a custom URL scheme is required (and implement if it is)
- Review the interaction of WebappClassLoader and Resources to see if
  there current work-arounds are a) still required b) implemented
  efficiently

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 53986] Comment end tag preceded directly by a dash causes JSP fail compilation

2012-10-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53986

--- Comment #3 from Mark Thomas  ---
Possible cause: r1381417

I haven't looked into this yet but that is where I'd start.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Resources - Custom URL scheme for unified access

2012-10-09 Thread Remy Maucherat
On Tue, 2012-10-09 at 22:19 +0100, Mark Thomas wrote:
> If we do go this route I'd like to change the scheme from "jndi://" to
> "tomcat://". This is for several reasons:
> - I believe there was a complaint that "jndi://" clashed with another
>   component.
> - It makes clear the old and the new are very different and not
>   compatible.

Not sure if it clashed with something, but the main reason it was
"jndi://" is because the API used was JNDI. So use something else,
"tomcat://" sounds good.

Rémy



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 53986] Comment end tag preceded directly by a dash causes JSP fail compilation

2012-10-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53986

--- Comment #4 from Christopher Schultz  ---
(In reply to comment #3)
> Possible cause: r1381417

Reverting that patch resolves the issue in 7.0.x/trunk, so the regression
appears to be in there. I'm not sure where, though.

Steve, a workaround might be replacing "([^-])---%>" with "\1--%>" in
your JSPs (or just stick with 7.0.30 for the time being).

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [Bug 53986] Comment end tag preceded directly by a dash causes JSP fail compilation

2012-10-09 Thread Christopher Schultz
All,

On 10/9/12 6:07 PM, bugzi...@apache.org wrote:
> https://issues.apache.org/bugzilla/show_bug.cgi?id=53986
> 
> --- Comment #4 from Christopher Schultz  ---
> (In reply to comment #3)
>> Possible cause: r1381417
> 
> Reverting that patch resolves the issue in 7.0.x/trunk, so the regression
> appears to be in there. I'm not sure where, though.

Given that r1381417 breaks comment-parsing, should we just revert the
whole thing? I have a test case set up that currently fails in
7.0.x/trunk but runs correctly with r1381417 reverted.

My plan is to commit the revert of r1381417 plus the test case, then
mark the original bug as reopened and ask the original author of the
patch if they might look into why comments aren't working properly. The
addition of the aforementioned test case should help.

-chris



signature.asc
Description: OpenPGP digital signature


[Bug 53986] Comment end tag preceded directly by a dash causes JSP fail compilation

2012-10-09 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53986

--- Comment #5 from Steve Ratay  ---
(In reply to comment #4)

Thanks Chris.  I actually only had a single JSP with this problem, so I already
fixed the JSP and am up and running on 7.0.32.  However, since it appeared to
be a regression from the previous version I thought it best to report the
issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org