Bug report for Tomcat 5 [2012/07/29]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |52579|New|Reg|2012-02-02|Tomcat5.5.35?Java1.5 cannot return proper value of| |53050|New|Nor|2012-04-09|org.apache.catalina.session.ManagerBase has issues| +-+---+---+--+--+ | Total2 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Tomcat 7 [2012/07/29]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |16579|New|Enh|2003-01-30|documentation page layout/style breaks wrapping to| |18500|New|Enh|2003-03-30|Host aliases to match by regular expression | |28039|Opn|Enh|2004-03-30|Cluster Support for SingleSignOn | |40728|Inf|Enh|2006-10-11|Catalina MBeans use non-serializable classes | |40881|Opn|Enh|2006-11-02|Unable to receive message through TCP channel -> | |41007|Opn|Enh|2006-11-20|Can't define customized 503 error page| |43866|New|Enh|2007-11-14|add support for session attribute propagation with| |43925|Opn|Enh|2007-11-21|org.apache.jasper.runtime.BodyContentImpl causing | |44216|New|Enh|2008-01-11|Don't reuse session ID even if emptySessionPath=tr| |48550|Inf|Enh|2010-01-14|Update examples and default server.xml to use UTF-| |49395|New|Enh|2010-06-06|manager.findLeaks : display the date when the leak| |49589|New|Enh|2010-07-12|Tag handlers with constant attribute values are al| |49785|New|Enh|2010-08-19|Enabling TLS for JNDIRealm| |49821|New|Enh|2010-08-25|Tomcat CLI| |50019|New|Enh|2010-09-28|Adding JNDI "lookup-name" support In XML and Resou| |50175|New|Enh|2010-10-28|Enhance memory leak detection by selectively apply| |50234|New|Enh|2010-11-08|JspC use servlet 3.0 features | |50504|New|Enh|2010-12-21|Allow setting query string character set trough re| |50670|New|Enh|2011-01-27|Tribes | RpcChannel | Add option to specify extern| |51195|New|Enh|2011-05-13|"Find leaks" reports a false positive memory/class| |51294|Opn|Enh|2011-05-30|Since 7.0.12 do not work option unpackWARs=true fo| |51423|Inf|Enh|2011-06-23|[Patch] to add a path and a version parameters to | |51463|New|Enh|2011-07-01|Tomcat.setBaseDir (package org.apache.catalina.st| |51496|New|Enh|2011-07-11|NSIS - Warn that duplicate service name will resul| |51497|New|Enh|2011-07-11|Use canonical IPv6 text representation in logs| |51526|New|Enh|2011-07-18|Process web application context config with embedd| |51587|New|Enh|2011-07-29|Implement status and uptime commands | |51953|New|Enh|2011-10-04|Proposal: netmask filtering valve and filter | |52092|New|Enh|2011-10-26|Please make AsyncFileHandler and OneLineFormatter | |52235|New|Enh|2011-11-23|Please do a bit of SEO tuning for the web site| |52236|New|Enh|2011-11-23|Idea: support 'overlays' shaped like Maven overlay| |52323|New|Enh|2011-12-13|Cobertura test code coverage support for build.xml| |52381|New|Enh|2011-12-22|Please add OSGi metadata | |52448|New|Enh|2012-01-11|Cache jar indexes in WebappClassLoader to speed up| |52489|New|Enh|2012-01-19|Enhancement request for code signing of war files | |52558|New|Enh|2012-01-30|CometConnectionManagerValve is adding non-serializ| |52688|New|Enh|2012-02-16|Add ability to remove old access log files| |52751|Opn|Enh|2012-02-23|Optimized configuration of the system info display| |52777|New|Enh|2012-02-27|Automatically shut down old versions in parallel d| |52952|New|Enh|2012-03-20|Improve ExtensionValidator handling for embedded s| |53085|New|Enh|2012-04-16|[perf] [concurrency] DefaultInstanceManager.annota| |53387|New|Enh|2012-06-08|SSI: Allow to use $1 to get result of regular expr| |53411|Opn|Enh|2012-06-13|NullPointerException in org.apache.tomcat.util.buf| |53469|Opn|Nor|2012-06-26|possible bug in Response.normalize(CharChunk cc) | |53492|New|Enh|2012-07-01|Make JspC shell multithreaded | |53535|New|Nor|2012-07-11|Out of memory while performing ContextConfig.webCo| |53541|New|Maj|2012-07-12|Bug in virtual webapp feature. Custom tags badly s| |53545|New|Maj|2012-07-13|jsp:forward action to static resources causes Ille| |53553|New|Enh|2012-07-16|[PATCH] Deploy uploaded WAR with context.xml from | |53574|New|Nor|2012-07-20|metadata-complete="true" and servlet defined as js| |53602|New|Enh|2012-07-25|Support for HTTP status code 451 | |53606|
Bug report for Tomcat 6 [2012/07/29]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |41679|New|Enh|2007-02-22|SemaphoreValve should be able to filter on url pat| |41883|Ass|Enh|2007-03-18|use abstract wrapper instead of plain X509Certific| |43001|New|Enh|2007-07-30|JspC lacks setMappedFile and setDie for use in Ant| |43400|New|Enh|2007-09-14|enum support for tag libs | |43548|Opn|Enh|2007-10-04|xml schema for tomcat-users.xml | |43682|New|Enh|2007-10-23|JULI: web-inf/classes/logging.properties to suppor| |43742|New|Enh|2007-10-30|.tag compiles performed one at a time -- extremel| |43979|New|Enh|2007-11-27|Add abstraction for Java and Classfile output | |44199|New|Enh|2008-01-10|expose current backlog queue size | |44225|New|Enh|2008-01-14|SSL connector tries to load the private keystore f| |44284|New|Enh|2008-01-23|Support java.lang.Iterable in c:forEach tag | |44294|New|Enh|2008-01-25|Support for EL functions with varargs | |44645|New|Enh|2008-03-20|[Patch] JNDIRealm - Doesn't support JNDI "java.nam| |44787|New|Enh|2008-04-09|provide more error context on "java.lang.IllegalSt| |44818|New|Enh|2008-04-13|tomcat hangs with GET when content-length is defin| |45014|New|Enh|2008-05-15|Request and Response classes should have wrappers | |45282|New|Enh|2008-06-25|NioReceiver doesn't close cleanly, leaving sockets| |45428|New|Enh|2008-07-18|warn if the tomcat stop doesn't complete | |45832|New|Enh|2008-09-18|add DIGEST authentication support to Ant tasks| |45878|New|Enh|2008-09-24|Generated jars do not contain proper manifests or | |45879|Opn|Enh|2008-09-24|Windows installer fails to install NOTICE and RELE| |45931|Opn|Enh|2008-10-01|trimSpaces incorrectly modifies output| |46173|New|Enh|2008-11-09|Small patch for manager app: Setting an optional c| |46263|New|Enh|2008-11-21|Tomcat reloading of context.xml does not update do| |46284|New|Enh|2008-11-24|Add flag to DeltaManager that blocks processing cl| |46350|New|Enh|2008-12-05|Maven repository should contain source bundles| |46727|New|Enh|2009-02-17|DefaultServlet - serving multiple encodings | |46902|New|Enh|2009-03-24|LoginValve to bypass restrictions of j_security_ch| |47214|New|Enh|2009-05-17|Inner classes that are explicitly referenced - sho| |47242|New|Enh|2009-05-22|request for AJP command line client | |47281|New|Enh|2009-05-28|Efficiency of the JDBCStore | |47407|New|Enh|2009-06-23|HttpSessionListener doesn't operate in the session| |47467|New|Enh|2009-07-02|Deployment of the war file by URL when contextpath| |47785|Opn|Enh|2009-09-04|Cluster MBean not registered | |47834|New|Enh|2009-09-14|TldConfig throws Exception when exploring unpacked| |47919|New|Enh|2009-09-30|Log Tomcat & Java environment variables in additio| |48358|Opn|Enh|2009-12-09|JSP-unloading reloaded| |48543|New|Enh|2010-01-14|[Patch] More flexibility in specifying -Dcatalina.| |48672|New|Enh|2010-02-03|Tomcat Virtual Host Manager (/host-manager) have b| |48674|New|Enh|2010-02-03|Tomcat Virtual Host Manager application doesn't pe| |48743|New|Enh|2010-02-15|Make the SLEEP variable in catalina.sh settable fr| |48899|New|Enh|2010-03-12|Guess URI charset should solve lot of problems| |48922|New|Enh|2010-03-16|org.apache.catalina.connector.Request clone static| |48928|New|Enh|2010-03-17|An alternative solution to preloading classes when| |49161|New|Enh|2010-04-21|Unknown Publisher when installing tomcat 6.0.26 | |49176|Opn|Enh|2010-04-23|Jasper in Dev Mode Is Memory Inefficient | |49464|New|Enh|2010-06-18|DefaultServlet and CharacterEncoding | |49531|New|Enh|2010-06-30|singlesignon failover not working on DeltaManager/| |49804|New|Enh|2010-08-23|Allow Embedded.redirectStreams value to be configu| |49939|New|Enh|2010-09-16|Expose a method via JMX which empties the webapp f| |49943|New|Enh|2010-09-16|Logging (via juli) does not reread configuration c| |50285|
Bug report for Taglibs [2012/07/29]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |38193|Ass|Enh|2006-01-09|[RDC] BuiltIn Grammar support for Field | |38600|Ass|Enh|2006-02-10|[RDC] Enable RDCs to be used in X+V markup (X+RDC)| |42413|New|Enh|2007-05-14|[PATCH] Log Taglib enhancements | |46052|New|Nor|2008-10-21|SetLocaleSupport is slow to initialize when many l| |48333|New|Enh|2009-12-02|TLD generator | +-+---+---+--+--+ | Total5 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Tomcat Connectors [2012/07/29]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |34526|Opn|Nor|2005-04-19|Truncated content in decompressed requests from mo| |35959|Opn|Enh|2005-08-01|mod_jk not independant of UseCanonicalName| |43303|New|Enh|2007-09-04|Versioning under Windows not reported by many conn| |43968|Inf|Enh|2007-11-26|[patch] support ipv6 with mod_jk | |44290|Inf|Nor|2008-01-24|mod_jk/1.2.26: retry is not useful for an importan| |44349|Inf|Maj|2008-02-04|mod_jk/1.2.26 module does not read worker.status.s| |44379|New|Enh|2008-02-07|convert the output of strftime into UTF-8 | |44454|New|Nor|2008-02-19|busy count reported in mod_jk inflated, causes inc| |44571|New|Enh|2008-03-10|Limits busy per worker to a threshold | |45063|New|Nor|2008-05-22|JK-1.2.26 IIS ISAPI filter issue when running diff| |45313|New|Nor|2008-06-30|mod_jk 1.2.26 & apache 2.2.9 static compiled on so| |46337|New|Nor|2008-12-04|real worker name is wrong | |46676|New|Enh|2009-02-09|Configurable test request for Watchdog thread | |46767|New|Enh|2009-02-25|mod_jk to send DECLINED in case no fail-over tomca| |47327|New|Enh|2009-06-07|remote_user not logged in apache logfile | |47617|Inf|Enh|2009-07-31|include time spent doing ajp_get_endpoint() in err| |47678|New|Cri|2009-08-11|Unable to allocate shared memory when using isapi_| |47714|New|Cri|2009-08-20|Reponse mixed between users | |47750|New|Maj|2009-08-27|Loss of worker settings when changing via jkstatus| |47795|New|Maj|2009-09-07|service sticky_session not being set correctly wit| |47840|Inf|Min|2009-09-14|A broken worker name is written in the log file. | |48191|New|Maj|2009-11-13|Problem with mod_jk 1.2.28 - Can not render up the| |48460|New|Nor|2009-12-30|mod_proxy_ajp document has three misleading portio| |48490|New|Nor|2010-01-05|Changing a node to stopped in uriworkermap.propert| |48513|New|Enh|2010-01-09|IIS Quick setup instructions | |48564|New|Nor|2010-01-18|Unable to turn off retries for LB worker | |48830|New|Nor|2010-03-01|IIS shutdown blocked in endpoint service when serv| |48891|Opn|Enh|2010-03-11|Missing EOL-style settings in tomcat/jk/trunk | |49035|New|Maj|2010-04-01|data lost when post a multipart/form-data form| |49063|New|Enh|2010-04-07|Please add JkStripSession status in jk-status work| |49135|New|Enh|2010-04-16|SPDY Connector for The Tomcat | |49469|New|Enh|2010-06-19|Workers status page has negative number of connect| |49732|Opn|Nor|2010-08-10|reply_timeout can't wait forever. | |49822|New|Enh|2010-08-25|Add hash lb worker method | |49903|New|Enh|2010-09-09|Make workers file reloadable | |50186|New|Nor|2010-10-31|Wrong documentation of connection_pool_timeout / c| |52334|New|Maj|2011-12-14|recover_time is not properly used | |52483|New|Enh|2012-01-18|Print JkOptions's options in log file and jkstatus| |52651|New|Nor|2012-02-13|JKSHMFile size limitation | |53324|Opn|Nor|2012-05-30|Starting with mod_jk 1.2.35 I cannot modify worker| |53542|New|Min|2012-07-13|Spelling mistake on 503 service unavailable page | +-+---+---+--+--+ | Total 41 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Tomcat Native [2012/07/29]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |45392|New|Nor|2008-07-14|No OCSP support for client SSL verification | |46179|Opn|Maj|2008-11-10|apr ssl client authentication | |48655|Inf|Nor|2010-02-02|Active multipart downloads prevent tomcat shutdown| |49038|Inf|Nor|2010-04-02|Crash in tcnative | |51655|New|Nor|2011-08-12|Index page does not say what native does | |51813|New|Cri|2011-09-14|Tomcat randomly crashes with [libtcnative-1.so.1+0| |52153|New|Maj|2011-11-08|periodic JVM crash (access violation) on buffer fl| |52231|New|Nor|2011-11-23|Ant Tasks need to reflect changes in manager comma| |52319|New|Maj|2011-12-12|Tomcat 6 crashes with [libapr-1.so.0+0x196da] sig| |52627|New|Min|2012-02-08|Segmentation fault in org.apache.tomcat.jni.File.i| |52856|New|Maj|2012-03-08|High CPU load when the underlying socket error in | |53110|New|Cri|2012-04-20|Access Violation Error while creating SHM | |53481|New|Nor|2012-06-28|Support SSL_OP_CIPHER_SERVER_PREFERENCE / SSLHonor| |53605|New|Nor|2012-07-26|use tcnative-1.1.24 Tomcat shutdown still crash | +-+---+---+--+--+ | Total 14 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Tomcat Modules [2012/07/29]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |48240|New|Nor|2009-11-19|Tomcat-Lite missing @Override markers | |48268|New|Nor|2009-11-23|Patch to fix generics in tomcat-lite | |48861|New|Nor|2010-03-04|Files without AL headers | |49685|New|Nor|2010-08-02|Unsafe synchronization in class ManagedBean | |49686|New|Nor|2010-08-02|Using an instance lock to protect static shared da| |50571|Inf|Nor|2011-01-11|Tomcat 7 JDBC connection pool exception enhancemen| |51595|Inf|Nor|2011-08-01|org.apache.tomcat.jdbc.pool.jmx.ConnectionPool sho| |51879|Inf|Enh|2011-09-22|Improve access to Native Connection Methods | |52024|Inf|Enh|2011-10-13|Custom interceptor to support automatic failover o| |52318|Inf|Cri|2011-12-11|Version in tomcat-jdbc POM is conflicted with Vers| |53088|Opn|Min|2012-04-17|Give PoolCleaner TimerTask a better name | |53198|New|Cri|2012-05-07|'driverClassName' Data Source Property Being Manda| |53199|Inf|Enh|2012-05-07|Refactor ConnectionPool to use ScheduledExecutorSe| |53200|New|Enh|2012-05-07|Be able to use SlowQueryReport without reporting f| |53565|New|Min|2012-07-18|deprecated| +-+---+---+--+--+ | Total 15 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: tomcat 7.0.29 startup time
Hi Mark,
thanks for the clarifications, highly appreciated!
As far as the empty goes: After reading the spec again
I've been down to that route as well. So far it didn't work out. Maybe I've
just done something wrong - will revisit and try again. Should the
only affect the jars with web-fragments, or does it
disable scanning of all jars then?
I also discovered another possible impact:
Our scenario is to use 1 tomcat installation as 'quasi EAR' container. We use
the shared.loader in conf/catalina.properties and set it to our own
${catalina.home}/applib directory which contains all our shared libraries
(myfaces, openwebbeans, openjpa, ...).
For what I did understand by reading the servlet-3.0 spec is that only
fragments and classes in either WEB-INF/classes or WEB-INF/lib/*.jar shall get
scanned by tomcat, right? But it seems that also all our shared.loader jars
will get scanned as well. I have not explicitly debugged thru, but from the
startup times I see no other explanation as our WARs contain almost no jars.
If I set the jarToSkip=*.jar then the boot time is back to normal.
Is there an explanation in the servlet spec, or does tomcat scan a bit too much
yet?
txs and LieGrue,
strub
- Original Message -
> From: Mark Thomas
> To: Tomcat Developers List
> Cc:
> Sent: Saturday, July 28, 2012 2:36 AM
> Subject: Re: tomcat 7.0.29 startup time
>
> On 28/07/2012 00:25, Mark Thomas wrote:
>> On 25/07/2012 17:00, Mark Struberg wrote:
>>> Hi Lords and Ladies!
>>>
>>> I'm currently wrangling with a doubled boot time on tomcat7.0.29 in
>>> comparison to 7.0.28 (12 webapps in my tc: 7.0.28 < 45s, 7.0.29 >
>>> 90s).
>>>
>>> I'm aware that 7.0.29 now does the scanning for
>>> ServletContainerInitializer even if version=2.5 is specified. But
>>> there shall no class scanning be performed if
>>> metadata-complete="true" is set, right?
>>
>> Wrong. I don't like this but the intent of the Servlet 3.0 EG was:
>> - ServletContainerInitializer cannot be disabled
>> - If a ServletContainerInitializer is found, then class-scanning will
>> take place
>>
>>> Any ideas how we can ease the pain quickly?
>>
>> The only option I see is a custom (non-spec compliant) Tomcat specific
>> feature that disables all of this.
>
> Ah. See the latest developments on
> http://java.net/jira/browse/SERVLET_SPEC-36
>
> Using an absolute ordering that specifies no fragments along with
> metadata-complete=true should do the trick.
>
> Mark
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1366822 - /tomcat/tc7.0.x/trunk/java/org/apache/catalina/connector/Response.java
Author: kkolinko Date: Sun Jul 29 12:05:55 2012 New Revision: 1366822 URL: http://svn.apache.org/viewvc?rev=1366822&view=rev Log: Add @Deprecate annotation, aligning code with javadoc, as prompted by Eclipse. It is followup to r1360851. Modified: tomcat/tc7.0.x/trunk/java/org/apache/catalina/connector/Response.java Modified: tomcat/tc7.0.x/trunk/java/org/apache/catalina/connector/Response.java URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/connector/Response.java?rev=1366822&r1=1366821&r2=1366822&view=diff == --- tomcat/tc7.0.x/trunk/java/org/apache/catalina/connector/Response.java (original) +++ tomcat/tc7.0.x/trunk/java/org/apache/catalina/connector/Response.java Sun Jul 29 12:05:55 2012 @@ -128,6 +128,7 @@ public class Response * Associated Catalina connector. * @deprecated Unused */ +@Deprecated protected Connector connector; /** - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: tomcat 7.0.29 startup time
tried the empty absolute ordering again and it doesn't seem to help. I fear
that @HandlesTypes again has higher precedence than the web-fragment
ordering/disabling.
LieGrue,
strub
- Original Message -
> From: Mark Struberg
> To: Tomcat Developers List
> Cc:
> Sent: Sunday, July 29, 2012 1:14 PM
> Subject: Re: tomcat 7.0.29 startup time
>
> Hi Mark,
>
> thanks for the clarifications, highly appreciated!
>
> As far as the empty goes: After reading the spec
> again I've been down to that route as well. So far it didn't work out.
> Maybe I've just done something wrong - will revisit and try again. Should
> the only affect the jars with web-fragments, or does
> it disable scanning of all jars then?
>
>
>
> I also discovered another possible impact:
>
> Our scenario is to use 1 tomcat installation as 'quasi EAR' container.
> We use the shared.loader in conf/catalina.properties and set it to our own
> ${catalina.home}/applib directory which contains all our shared libraries
> (myfaces, openwebbeans, openjpa, ...).
> For what I did understand by reading the servlet-3.0 spec is that only
> fragments
> and classes in either WEB-INF/classes or WEB-INF/lib/*.jar shall get scanned
> by
> tomcat, right? But it seems that also all our shared.loader jars will get
> scanned as well. I have not explicitly debugged thru, but from the startup
> times
> I see no other explanation as our WARs contain almost no jars.
>
> If I set the jarToSkip=*.jar then the boot time is back to normal.
>
>
> Is there an explanation in the servlet spec, or does tomcat scan a bit too
> much
> yet?
>
>
> txs and LieGrue,
> strub
>
>
>
> - Original Message -
>> From: Mark Thomas
>> To: Tomcat Developers List
>> Cc:
>> Sent: Saturday, July 28, 2012 2:36 AM
>> Subject: Re: tomcat 7.0.29 startup time
>>
>> On 28/07/2012 00:25, Mark Thomas wrote:
>>> On 25/07/2012 17:00, Mark Struberg wrote:
Hi Lords and Ladies!
I'm currently wrangling with a doubled boot time on
> tomcat7.0.29 in
comparison to 7.0.28 (12 webapps in my tc: 7.0.28 < 45s, 7.0.29
>>
90s).
I'm aware that 7.0.29 now does the scanning for
ServletContainerInitializer even if version=2.5 is specified. But
there shall no class scanning be performed if
metadata-complete="true" is set, right?
>>>
>>> Wrong. I don't like this but the intent of the Servlet 3.0 EG was:
>>> - ServletContainerInitializer cannot be disabled
>>> - If a ServletContainerInitializer is found, then class-scanning will
>>> take place
>>>
Any ideas how we can ease the pain quickly?
>>>
>>> The only option I see is a custom (non-spec compliant) Tomcat specific
>>> feature that disables all of this.
>>
>> Ah. See the latest developments on
>> http://java.net/jira/browse/SERVLET_SPEC-36
>>
>> Using an absolute ordering that specifies no fragments along with
>> metadata-complete=true should do the trick.
>>
>> Mark
>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: tomcat 7.0.29 startup time
Mark Struberg wrote:
>tried the empty absolute ordering again and it doesn't seem to help. I
>fear that @HandlesTypes again has higher precedence than the
>web-fragment ordering/disabling.
The 'clarification' from the EG is post the last release. I'm pretty sure some
code changes are required. Feel free to open a bz issue so this isn't forgotten.
Mark
>
>LieGrue,
>strub
>
>
>
>- Original Message -
>> From: Mark Struberg
>> To: Tomcat Developers List
>> Cc:
>> Sent: Sunday, July 29, 2012 1:14 PM
>> Subject: Re: tomcat 7.0.29 startup time
>>
>> Hi Mark,
>>
>> thanks for the clarifications, highly appreciated!
>>
>> As far as the empty goes: After reading the spec
>
>> again I've been down to that route as well. So far it didn't work
>out.
>> Maybe I've just done something wrong - will revisit and try again.
>Should
>> the only affect the jars with web-fragments, or
>does
>> it disable scanning of all jars then?
>>
>>
>>
>> I also discovered another possible impact:
>>
>> Our scenario is to use 1 tomcat installation as 'quasi EAR'
>container.
>> We use the shared.loader in conf/catalina.properties and set it to
>our own
>> ${catalina.home}/applib directory which contains all our shared
>libraries
>> (myfaces, openwebbeans, openjpa, ...).
>> For what I did understand by reading the servlet-3.0 spec is that
>only fragments
>> and classes in either WEB-INF/classes or WEB-INF/lib/*.jar shall get
>scanned by
>> tomcat, right? But it seems that also all our shared.loader jars will
>get
>> scanned as well. I have not explicitly debugged thru, but from the
>startup times
>> I see no other explanation as our WARs contain almost no jars.
>>
>> If I set the jarToSkip=*.jar then the boot time is back to normal.
>>
>>
>> Is there an explanation in the servlet spec, or does tomcat scan a
>bit too much
>> yet?
>>
>>
>> txs and LieGrue,
>> strub
>>
>>
>>
>> - Original Message -
>>> From: Mark Thomas
>>> To: Tomcat Developers List
>>> Cc:
>>> Sent: Saturday, July 28, 2012 2:36 AM
>>> Subject: Re: tomcat 7.0.29 startup time
>>>
>>> On 28/07/2012 00:25, Mark Thomas wrote:
On 25/07/2012 17:00, Mark Struberg wrote:
> Hi Lords and Ladies!
>
> I'm currently wrangling with a doubled boot time on
>> tomcat7.0.29 in
> comparison to 7.0.28 (12 webapps in my tc: 7.0.28 < 45s, 7.0.29
>>>
> 90s).
>
> I'm aware that 7.0.29 now does the scanning for
> ServletContainerInitializer even if version=2.5 is specified.
>But
> there shall no class scanning be performed if
> metadata-complete="true" is set, right?
Wrong. I don't like this but the intent of the Servlet 3.0 EG
>was:
- ServletContainerInitializer cannot be disabled
- If a ServletContainerInitializer is found, then class-scanning
>will
take place
> Any ideas how we can ease the pain quickly?
The only option I see is a custom (non-spec compliant) Tomcat
>specific
feature that disables all of this.
>>>
>>> Ah. See the latest developments on
>>> http://java.net/jira/browse/SERVLET_SPEC-36
>>>
>>> Using an absolute ordering that specifies no fragments along with
>>> metadata-complete=true should do the trick.
>>>
>>> Mark
>>>
>>>
>>>
>-
>>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>
>
>-
>To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>For additional commands, e-mail: dev-h...@tomcat.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1366885 - in /tomcat/trunk/java/org/apache/catalina/tribes/io: BufferPool.java BufferPool15Impl.java DirectByteArrayOutputStream.java XByteBuffer.java
Author: markt
Date: Sun Jul 29 18:26:51 2012
New Revision: 1366885
URL: http://svn.apache.org/viewvc?rev=1366885&view=rev
Log:
Partial code clean-up for o.a.catalina.tribes
- Add final prompted by UCDetector
- Java 7 use of <>
Modified:
tomcat/trunk/java/org/apache/catalina/tribes/io/BufferPool.java
tomcat/trunk/java/org/apache/catalina/tribes/io/BufferPool15Impl.java
tomcat/trunk/java/org/apache/catalina/tribes/io/DirectByteArrayOutputStream.java
tomcat/trunk/java/org/apache/catalina/tribes/io/XByteBuffer.java
Modified: tomcat/trunk/java/org/apache/catalina/tribes/io/BufferPool.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/io/BufferPool.java?rev=1366885&r1=1366884&r2=1366885&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/tribes/io/BufferPool.java (original)
+++ tomcat/trunk/java/org/apache/catalina/tribes/io/BufferPool.java Sun Jul 29
18:26:51 2012
@@ -34,7 +34,7 @@ public class BufferPool {
protected static volatile BufferPool instance = null;
-protected BufferPoolAPI pool = null;
+protected final BufferPoolAPI pool;
private BufferPool(BufferPoolAPI pool) {
this.pool = pool;
Modified: tomcat/trunk/java/org/apache/catalina/tribes/io/BufferPool15Impl.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/io/BufferPool15Impl.java?rev=1366885&r1=1366884&r2=1366885&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/tribes/io/BufferPool15Impl.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/tribes/io/BufferPool15Impl.java Sun
Jul 29 18:26:51 2012
@@ -26,8 +26,9 @@ import java.util.concurrent.atomic.Atomi
*/
class BufferPool15Impl implements BufferPool.BufferPoolAPI {
protected int maxSize;
-protected AtomicInteger size = new AtomicInteger(0);
-protected ConcurrentLinkedQueue queue = new
ConcurrentLinkedQueue();
+protected final AtomicInteger size = new AtomicInteger(0);
+protected final ConcurrentLinkedQueue queue =
+new ConcurrentLinkedQueue<>();
@Override
public void setMaxSize(int bytes) {
Modified:
tomcat/trunk/java/org/apache/catalina/tribes/io/DirectByteArrayOutputStream.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/io/DirectByteArrayOutputStream.java?rev=1366885&r1=1366884&r2=1366885&view=diff
==
---
tomcat/trunk/java/org/apache/catalina/tribes/io/DirectByteArrayOutputStream.java
(original)
+++
tomcat/trunk/java/org/apache/catalina/tribes/io/DirectByteArrayOutputStream.java
Sun Jul 29 18:26:51 2012
@@ -28,7 +28,7 @@ import java.io.OutputStream;
*/
public class DirectByteArrayOutputStream extends OutputStream {
-private XByteBuffer buffer;
+private final XByteBuffer buffer;
public DirectByteArrayOutputStream(int size) {
buffer = new XByteBuffer(size,false);
Modified: tomcat/trunk/java/org/apache/catalina/tribes/io/XByteBuffer.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/io/XByteBuffer.java?rev=1366885&r1=1366884&r2=1366885&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/tribes/io/XByteBuffer.java (original)
+++ tomcat/trunk/java/org/apache/catalina/tribes/io/XByteBuffer.java Sun Jul 29
18:26:51 2012
@@ -554,7 +554,7 @@ public class XByteBuffer
return deserialize(data,offset,length,null);
}
-private static AtomicInteger invokecount = new AtomicInteger(0);
+private static final AtomicInteger invokecount = new AtomicInteger(0);
public static Serializable deserialize(byte[] data, int offset, int
length, ClassLoader[] cls)
throws IOException, ClassNotFoundException, ClassCastException {
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1366889 - /tomcat/trunk/java/org/apache/catalina/tribes/io/XByteBuffer.java
Author: markt
Date: Sun Jul 29 19:03:46 2012
New Revision: 1366889
URL: http://svn.apache.org/viewvc?rev=1366889&view=rev
Log:
Remove deprecated code
Modified:
tomcat/trunk/java/org/apache/catalina/tribes/io/XByteBuffer.java
Modified: tomcat/trunk/java/org/apache/catalina/tribes/io/XByteBuffer.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/io/XByteBuffer.java?rev=1366889&r1=1366888&r2=1366889&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/tribes/io/XByteBuffer.java (original)
+++ tomcat/trunk/java/org/apache/catalina/tribes/io/XByteBuffer.java Sun Jul 29
19:03:46 2012
@@ -422,15 +422,7 @@ public class XByteBuffer
* Converts a boolean to a 1-byte array
* @param bool - the integer
* @return - 1-byte array
- * @deprecated use toBytes(boolean,byte[],int)
*/
-@Deprecated
-public static byte[] toBytes(boolean bool) {
-byte[] b = new byte[1] ;
-return toBytes(bool,b,0);
-
-}
-
public static byte[] toBytes(boolean bool, byte[] data, int offset) {
data[offset] = (byte)(bool?1:0);
return data;
@@ -451,13 +443,7 @@ public class XByteBuffer
* Converts an integer to four bytes
* @param n - the integer
* @return - four bytes in an array
- * @deprecated use toBytes(int,byte[],int)
*/
-@Deprecated
-public static byte[] toBytes(int n) {
-return toBytes(n,new byte[4],0);
-}
-
public static byte[] toBytes(int n,byte[] b, int offset) {
b[offset+3] = (byte) (n);
n >>>= 8;
@@ -473,12 +459,7 @@ public class XByteBuffer
* Converts an long to eight bytes
* @param n - the long
* @return - eight bytes in an array
- * @deprecated use toBytes(long,byte[],int)
*/
-@Deprecated
-public static byte[] toBytes(long n) {
-return toBytes(n,new byte[8],0);
-}
public static byte[] toBytes(long n, byte[] b, int offset) {
b[offset+7] = (byte) (n);
n >>>= 8;
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1366896 - /tomcat/trunk/java/org/apache/catalina/tribes/io/BufferPool.java
Author: markt
Date: Sun Jul 29 19:15:54 2012
New Revision: 1366896
URL: http://svn.apache.org/viewvc?rev=1366896&view=rev
Log:
Simplify since minimum Java version is now >= 1.5
Modified:
tomcat/trunk/java/org/apache/catalina/tribes/io/BufferPool.java
Modified: tomcat/trunk/java/org/apache/catalina/tribes/io/BufferPool.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/io/BufferPool.java?rev=1366896&r1=1366895&r2=1366896&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/tribes/io/BufferPool.java (original)
+++ tomcat/trunk/java/org/apache/catalina/tribes/io/BufferPool.java Sun Jul 29
19:15:54 2012
@@ -55,27 +55,18 @@ public class BufferPool {
public static BufferPool getBufferPool() {
-if ( (instance == null) ) {
+if (instance == null) {
synchronized (BufferPool.class) {
-if ( instance == null ) {
- BufferPoolAPI pool = null;
- Class clazz = null;
- try {
- // TODO Is this approach still required?
- clazz =
Class.forName("org.apache.catalina.tribes.io.BufferPool15Impl");
- pool = (BufferPoolAPI)clazz.newInstance();
- } catch ( Throwable x ) {
- log.warn("Unable to initilize BufferPool, not pooling
XByteBuffer objects:"+x.getMessage());
- if ( log.isDebugEnabled() ) log.debug("Unable to
initilize BufferPool, not pooling XByteBuffer objects:",x);
- }
- if (pool != null) {
- pool.setMaxSize(DEFAULT_POOL_SIZE);
- log.info("Created a buffer pool with max
size:"+DEFAULT_POOL_SIZE+" bytes of
type:"+(clazz!=null?clazz.getName():"null"));
- instance = new BufferPool(pool);
- }
-}//end if
-}//sync
-}//end if
+if (instance == null) {
+ BufferPoolAPI pool = new BufferPool15Impl();
+ pool.setMaxSize(DEFAULT_POOL_SIZE);
+ log.info("Created a buffer pool with max size:" +
+ DEFAULT_POOL_SIZE + " bytes of type: " +
+ pool.getClass().getName());
+ instance = new BufferPool(pool);
+}
+}
+}
return instance;
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1366910 - /tomcat/trunk/java/org/apache/catalina/tribes/io/ReplicationStream.java
Author: markt
Date: Sun Jul 29 19:26:41 2012
New Revision: 1366910
URL: http://svn.apache.org/viewvc?rev=1366910&view=rev
Log:
FindBugs: Fix potential NPE
Modified:
tomcat/trunk/java/org/apache/catalina/tribes/io/ReplicationStream.java
Modified: tomcat/trunk/java/org/apache/catalina/tribes/io/ReplicationStream.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/io/ReplicationStream.java?rev=1366910&r1=1366909&r2=1366910&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/tribes/io/ReplicationStream.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/tribes/io/ReplicationStream.java Sun
Jul 29 19:26:41 2012
@@ -104,7 +104,12 @@ public final class ReplicationStream ext
protected Class resolveProxyClass(String[] interfaces)
throws IOException, ClassNotFoundException {
-ClassLoader latestLoader = (classLoaders!=null &&
classLoaders.length==0)?null:classLoaders[0];
+ClassLoader latestLoader;
+if (classLoaders != null && classLoaders.length > 0) {
+latestLoader = classLoaders[0];
+} else {
+latestLoader = null;
+}
ClassLoader nonPublicLoader = null;
boolean hasNonPublicInterface = false;
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1366914 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/tribes/io/ReplicationStream.java webapps/docs/changelog.xml
Author: markt
Date: Sun Jul 29 19:32:20 2012
New Revision: 1366914
URL: http://svn.apache.org/viewvc?rev=1366914&view=rev
Log:
FindBugs: Fix potential NPE
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/io/ReplicationStream.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
Propchange: tomcat/tc7.0.x/trunk/
--
Merged /tomcat/trunk:r1366910
Modified:
tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/io/ReplicationStream.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/io/ReplicationStream.java?rev=1366914&r1=1366913&r2=1366914&view=diff
==
---
tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/io/ReplicationStream.java
(original)
+++
tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/io/ReplicationStream.java
Sun Jul 29 19:32:20 2012
@@ -105,7 +105,12 @@ public final class ReplicationStream ext
protected Class resolveProxyClass(String[] interfaces)
throws IOException, ClassNotFoundException {
-ClassLoader latestLoader = (classLoaders!=null &&
classLoaders.length==0)?null:classLoaders[0];
+ClassLoader latestLoader;
+if (classLoaders != null && classLoaders.length > 0) {
+latestLoader = classLoaders[0];
+} else {
+latestLoader = null;
+}
ClassLoader nonPublicLoader = null;
boolean hasNonPublicInterface = false;
Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1366914&r1=1366913&r2=1366914&view=diff
==
--- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Sun Jul 29 19:32:20 2012
@@ -121,6 +121,14 @@
+
+
+
+Avoid potential NPE identified by Find Bugs in
+org.apache.catalina.tribes.io.ReplicationStream. (markt)
+
+
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1366945 - in /tomcat/trunk: java/org/apache/catalina/connector/Response.java test/org/apache/catalina/connector/TestResponse.java
Author: markt
Date: Sun Jul 29 20:29:20 2012
New Revision: 1366945
URL: http://svn.apache.org/viewvc?rev=1366945&view=rev
Log:
Partial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=53469
If the relative URL can't be made absolute, do not encode it and return it as is
Modified:
tomcat/trunk/java/org/apache/catalina/connector/Response.java
tomcat/trunk/test/org/apache/catalina/connector/TestResponse.java
Modified: tomcat/trunk/java/org/apache/catalina/connector/Response.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/Response.java?rev=1366945&r1=1366944&r2=1366945&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/connector/Response.java (original)
+++ tomcat/trunk/java/org/apache/catalina/connector/Response.java Sun Jul 29
20:29:20 2012
@@ -1134,7 +1134,14 @@ public class Response
@Override
public String encodeURL(String url) {
-String absolute = toAbsolute(url);
+String absolute;
+try {
+absolute = toAbsolute(url);
+} catch (IllegalArgumentException iae) {
+// Relative URL
+return url;
+}
+
if (isEncodeable(absolute)) {
// W3c spec clearly said
if (url.equalsIgnoreCase("")) {
@@ -1702,7 +1709,7 @@ public class Response
if (index < 0) {
break;
}
-// Prevent from going outside our context
+// Can't go above the server root
if (index == startIndex) {
throw new IllegalArgumentException();
}
@@ -1719,7 +1726,7 @@ public class Response
index = index2;
}
-// Add the query string (if present) back in
+// Add the query string and/or fragment (if present) back in
if (truncateCC != null) {
try {
cc.append(truncateCC, 0, truncateCC.length);
Modified: tomcat/trunk/test/org/apache/catalina/connector/TestResponse.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/connector/TestResponse.java?rev=1366945&r1=1366944&r2=1366945&view=diff
==
--- tomcat/trunk/test/org/apache/catalina/connector/TestResponse.java (original)
+++ tomcat/trunk/test/org/apache/catalina/connector/TestResponse.java Sun Jul
29 20:29:20 2012
@@ -364,6 +364,30 @@ public class TestResponse extends Tomcat
}
+@Test
+public void testBug53469a() throws Exception {
+Request req = new TesterMockRequest();
+Response resp = new Response();
+resp.setRequest(req);
+
+String result = resp.encodeURL("../bar.html");
+
+Assert.assertEquals("../bar.html", result);
+}
+
+
+@Test
+public void testBug53469b() throws Exception {
+Request req = new TesterMockRequest();
+Response resp = new Response();
+resp.setRequest(req);
+
+String result = resp.encodeURL("../../../../bar.html");
+
+Assert.assertEquals("../../../../bar.html", result);
+}
+
+
private static final class Bug52811Servlet extends HttpServlet {
private static final long serialVersionUID = 1L;
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1366946 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/connector/Response.java test/org/apache/catalina/connector/TestResponse.java webapps/docs/changelog.xml
Author: markt
Date: Sun Jul 29 20:33:16 2012
New Revision: 1366946
URL: http://svn.apache.org/viewvc?rev=1366946&view=rev
Log:
Partial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=53469
If the relative URL can't be made absolute, do not encode it and return it as is
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/catalina/connector/Response.java
tomcat/tc7.0.x/trunk/test/org/apache/catalina/connector/TestResponse.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
Propchange: tomcat/tc7.0.x/trunk/
--
Merged /tomcat/trunk:r1366945
Modified: tomcat/tc7.0.x/trunk/java/org/apache/catalina/connector/Response.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/connector/Response.java?rev=1366946&r1=1366945&r2=1366946&view=diff
==
--- tomcat/tc7.0.x/trunk/java/org/apache/catalina/connector/Response.java
(original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/catalina/connector/Response.java Sun
Jul 29 20:33:16 2012
@@ -1242,7 +1242,14 @@ public class Response
@Override
public String encodeURL(String url) {
-String absolute = toAbsolute(url);
+String absolute;
+try {
+absolute = toAbsolute(url);
+} catch (IllegalArgumentException iae) {
+// Relative URL
+return url;
+}
+
if (isEncodeable(absolute)) {
// W3c spec clearly said
if (url.equalsIgnoreCase("")) {
@@ -1810,7 +1817,7 @@ public class Response
if (index < 0) {
break;
}
-// Prevent from going outside our context
+// Can't go above the server root
if (index == startIndex) {
throw new IllegalArgumentException();
}
@@ -1827,7 +1834,7 @@ public class Response
index = index2;
}
-// Add the query string (if present) back in
+// Add the query string and/or fragment (if present) back in
if (truncateCC != null) {
try {
cc.append(truncateCC, 0, truncateCC.length);
Modified:
tomcat/tc7.0.x/trunk/test/org/apache/catalina/connector/TestResponse.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/test/org/apache/catalina/connector/TestResponse.java?rev=1366946&r1=1366945&r2=1366946&view=diff
==
--- tomcat/tc7.0.x/trunk/test/org/apache/catalina/connector/TestResponse.java
(original)
+++ tomcat/tc7.0.x/trunk/test/org/apache/catalina/connector/TestResponse.java
Sun Jul 29 20:33:16 2012
@@ -364,6 +364,30 @@ public class TestResponse extends Tomcat
}
+@Test
+public void testBug53469a() throws Exception {
+Request req = new TesterMockRequest();
+Response resp = new Response();
+resp.setRequest(req);
+
+String result = resp.encodeURL("../bar.html");
+
+Assert.assertEquals("../bar.html", result);
+}
+
+
+@Test
+public void testBug53469b() throws Exception {
+Request req = new TesterMockRequest();
+Response resp = new Response();
+resp.setRequest(req);
+
+String result = resp.encodeURL("../../../../bar.html");
+
+Assert.assertEquals("../../../../bar.html", result);
+}
+
+
private static final class Bug52811Servlet extends HttpServlet {
private static final long serialVersionUID = 1L;
Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1366946&r1=1366945&r2=1366946&view=diff
==
--- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Sun Jul 29 20:33:16 2012
@@ -63,6 +63,13 @@
when request processing completes. (kkolinko)
+53469: If a URL passed to
+javax.servlet.http.HttpServletResponse.encodeURL() cannot
+be made absolute, never encode it and return it unchanged. Previously,
+the fix for 53062 meant than an
+IllegalArgumentException was thrown. (markt)
+
+
53498: Fix atomicity bugs in use of concurrent collections.
Based on a patch by Yu Lin. (markt)
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53469] possible bug in Response.normalize(CharChunk cc)
https://issues.apache.org/bugzilla/show_bug.cgi?id=53469 --- Comment #16 from Mark Thomas --- I have fixed the IAE in trunk and 7.0.x. I am leaving this open while I wait for clarification from the Servlet EG as to how relative URLs passed to encodeURL should be treated. See http://java.net/jira/browse/SERVLET_SPEC-43 -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1366953 - /tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java
Author: markt
Date: Sun Jul 29 21:21:08 2012
New Revision: 1366953
URL: http://svn.apache.org/viewvc?rev=1366953&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53535
Reduce memory footprint when performing class scanning on Context start.
Patch provided by Cedomir Igaly
Modified:
tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java
Modified: tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java?rev=1366953&r1=1366952&r2=1366953&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java (original)
+++ tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java Sun Jul 29
21:21:08 2012
@@ -2122,10 +2122,8 @@ public class ContextConfig implements Li
private void populateSCIsForCacheEntry(JavaClassCacheEntry cacheEntry) {
Set result = new HashSet<>();
-JavaClass javaClass = cacheEntry.getJavaClass();
-
// Super class
-String superClassName = javaClass.getSuperclassName();
+String superClassName = cacheEntry.getSuperclassName();
JavaClassCacheEntry superClassCacheEntry =
javaClassCache.get(superClassName);
@@ -2145,7 +2143,7 @@ public class ContextConfig implements Li
result.addAll(getSCIsForClass(superClassName));
// Interfaces
-for (String interfaceName : javaClass.getInterfaceNames()) {
+for (String interfaceName : cacheEntry.getInterfaceNames()) {
JavaClassCacheEntry interfaceEntry =
javaClassCache.get(interfaceName);
// A null could mean that the class not present in application or
@@ -2589,15 +2587,23 @@ public class ContextConfig implements Li
}
private static class JavaClassCacheEntry {
-private final JavaClass javaClass;
+public final String superclassName;
+
+public final String[] interfaceNames;
+
private Set sciSet = null;
public JavaClassCacheEntry(JavaClass javaClass) {
-this.javaClass = javaClass;
+superclassName = javaClass.getSuperclassName();
+interfaceNames = javaClass.getInterfaceNames();
+}
+
+public String getSuperclassName() {
+return superclassName;
}
-public JavaClass getJavaClass() {
-return javaClass;
+public String[] getInterfaceNames() {
+return interfaceNames;
}
public Set getSciSet() {
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1366955 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/startup/ContextConfig.java webapps/docs/changelog.xml
Author: markt
Date: Sun Jul 29 21:23:13 2012
New Revision: 1366955
URL: http://svn.apache.org/viewvc?rev=1366955&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53535
Reduce memory footprint when performing class scanning on Context start.
Patch provided by Cedomir Igaly
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/catalina/startup/ContextConfig.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
Propchange: tomcat/tc7.0.x/trunk/
--
Merged /tomcat/trunk:r1366953
Modified:
tomcat/tc7.0.x/trunk/java/org/apache/catalina/startup/ContextConfig.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/startup/ContextConfig.java?rev=1366955&r1=1366954&r2=1366955&view=diff
==
--- tomcat/tc7.0.x/trunk/java/org/apache/catalina/startup/ContextConfig.java
(original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/catalina/startup/ContextConfig.java
Sun Jul 29 21:23:13 2012
@@ -2211,10 +2211,8 @@ public class ContextConfig implements Li
Set result =
new HashSet();
-JavaClass javaClass = cacheEntry.getJavaClass();
-
// Super class
-String superClassName = javaClass.getSuperclassName();
+String superClassName = cacheEntry.getSuperclassName();
JavaClassCacheEntry superClassCacheEntry =
javaClassCache.get(superClassName);
@@ -2234,7 +2232,7 @@ public class ContextConfig implements Li
result.addAll(getSCIsForClass(superClassName));
// Interfaces
-for (String interfaceName : javaClass.getInterfaceNames()) {
+for (String interfaceName : cacheEntry.getInterfaceNames()) {
JavaClassCacheEntry interfaceEntry =
javaClassCache.get(interfaceName);
// A null could mean that the class not present in application or
@@ -2678,15 +2676,23 @@ public class ContextConfig implements Li
}
private static class JavaClassCacheEntry {
-private final JavaClass javaClass;
+public final String superclassName;
+
+public final String[] interfaceNames;
+
private Set sciSet = null;
public JavaClassCacheEntry(JavaClass javaClass) {
-this.javaClass = javaClass;
+superclassName = javaClass.getSuperclassName();
+interfaceNames = javaClass.getInterfaceNames();
+}
+
+public String getSuperclassName() {
+return superclassName;
}
-public JavaClass getJavaClass() {
-return javaClass;
+public String[] getInterfaceNames() {
+return interfaceNames;
}
public Set getSciSet() {
Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1366955&r1=1366954&r2=1366955&view=diff
==
--- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Sun Jul 29 21:23:13 2012
@@ -85,6 +85,10 @@
Add some HTTP status codes registered at IANA. (rjung)
+
+53535: Reduce memory footprint when performing class
scanning
+on Context start. Patch provided by Cedomir Igaly. (markt)
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53615] java.lang.OutOfMemoryError: GC overhead limit exceeded after upgrading from 7.0.28 to 7.0.29
https://issues.apache.org/bugzilla/show_bug.cgi?id=53615 Bug 53615 depends on bug 53535, which changed state. Bug 53535 Summary: Out of memory while performing ContextConfig.webConfig https://issues.apache.org/bugzilla/show_bug.cgi?id=53535 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53535] Out of memory while performing ContextConfig.webConfig
https://issues.apache.org/bugzilla/show_bug.cgi?id=53535 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #4 from Mark Thomas --- Thanks for the patch. It has been applied to trunk and 7.0.x and will be included in 7.0.30 onwards. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1366956 - /tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
Author: markt Date: Sun Jul 29 21:30:49 2012 New Revision: 1366956 URL: http://svn.apache.org/viewvc?rev=1366956&view=rev Log: Add missing entry Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1366956&r1=1366955&r2=1366956&view=diff == --- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original) +++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Sun Jul 29 21:30:49 2012 @@ -340,6 +340,12 @@ (markt) +53047: If a JDBC Realm or DataSource Realm is configured for +an all roles mode that only requires authorization (and no roles) and no +role table or column is defined, don't populate the Principal's roles. +(markt) + + 53056: Add APR version number to tcnative version INFO log message. (schultz) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53047] JDBCRealm allRolesMode="authOnly" still needs role table
https://issues.apache.org/bugzilla/show_bug.cgi?id=53047 --- Comment #12 from Mark Thomas --- See comment #10 The changelog entry was missed. This has been fixed. http://svn.apache.org/viewvc?view=revision&revision=1348499 http://svn.apache.org/viewvc?view=revision&revision=1366956 -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53409] Request class actively restricts sending parameters in the body unless using POST
https://issues.apache.org/bugzilla/show_bug.cgi?id=53409 Mark Thomas changed: What|Removed |Added OS||All Severity|normal |enhancement --- Comment #1 from Mark Thomas --- Note that the restriction is as a result of the Servlet specification (SRV 3.1). -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1366959 - /tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/TcpPingInterceptor.java
Author: markt
Date: Sun Jul 29 21:47:24 2012
New Revision: 1366959
URL: http://svn.apache.org/viewvc?rev=1366959&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53606
Fix possible NPE when sending pings between cluster nodes
Based on a patch by F.Arnoud
Modified:
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/TcpPingInterceptor.java
Modified:
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/TcpPingInterceptor.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/TcpPingInterceptor.java?rev=1366959&r1=1366958&r2=1366959&view=diff
==
---
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/TcpPingInterceptor.java
(original)
+++
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/TcpPingInterceptor.java
Sun Jul 29 21:47:24 2012
@@ -122,13 +122,16 @@ public class TcpPingInterceptor extends
}
protected void sendPing() {
-if (failureDetector.get() != null) {
+TcpFailureDetector tcpFailureDetector =
+failureDetector != null ? failureDetector.get() : null;
+if (tcpFailureDetector != null) {
// We have a reference to the failure detector
// Piggy back on it
-failureDetector.get().checkMembers(true);
+tcpFailureDetector.checkMembers(true);
} else {
-StaticMembershipInterceptor smi = staticMembers.get();
-if (staticOnly && smi != null) {
+StaticMembershipInterceptor smi =
+staticOnly && staticMembers != null ? staticMembers.get()
: null;
+if (smi != null) {
sendPingMessage(smi.getMembers());
} else {
sendPingMessage(getMembers());
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1366961 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/tribes/group/interceptors/TcpPingInterceptor.java webapps/docs/changelog.xml
Author: markt
Date: Sun Jul 29 21:51:06 2012
New Revision: 1366961
URL: http://svn.apache.org/viewvc?rev=1366961&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53606
Fix possible NPE when sending pings between cluster nodes
Based on a patch by F.Arnoud
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/TcpPingInterceptor.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
Propchange: tomcat/tc7.0.x/trunk/
--
Merged /tomcat/trunk:r1366959
Modified:
tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/TcpPingInterceptor.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/TcpPingInterceptor.java?rev=1366961&r1=1366960&r2=1366961&view=diff
==
---
tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/TcpPingInterceptor.java
(original)
+++
tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/TcpPingInterceptor.java
Sun Jul 29 21:51:06 2012
@@ -122,13 +122,17 @@ public class TcpPingInterceptor extends
}
protected void sendPing() {
-if (failureDetector.get()!=null) {
-//we have a reference to the failure detector
-//piggy back on that dude
-failureDetector.get().checkMembers(true);
-}else {
-if (staticOnly && staticMembers.get()!=null) {
-sendPingMessage(staticMembers.get().getMembers());
+TcpFailureDetector tcpFailureDetector =
+failureDetector != null ? failureDetector.get() : null;
+if (tcpFailureDetector != null) {
+// We have a reference to the failure detector
+// Piggy back on it
+tcpFailureDetector.checkMembers(true);
+} else {
+StaticMembershipInterceptor smi =
+staticOnly && staticMembers != null ? staticMembers.get()
: null;
+if (smi != null) {
+sendPingMessage(smi.getMembers());
} else {
sendPingMessage(getMembers());
}
Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1366961&r1=1366960&r2=1366961&view=diff
==
--- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Sun Jul 29 21:51:06 2012
@@ -138,6 +138,10 @@
Avoid potential NPE identified by Find Bugs in
org.apache.catalina.tribes.io.ReplicationStream. (markt)
+
+53606: Fix potential NPE in TcpPingInterceptor.
+Based on a patch by F. Arnoud. (markt)
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53606] NullPointerException in TcpPingInterceptor
https://issues.apache.org/bugzilla/show_bug.cgi?id=53606 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED Severity|blocker |normal --- Comment #5 from Mark Thomas --- Fixed in trunk and 7.0.x and will be included in 7.0.30 onwards. Thanks for the patch. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53606] NullPointerException in TcpPingInterceptor
https://issues.apache.org/bugzilla/show_bug.cgi?id=53606 Mark Thomas changed: What|Removed |Added Status|RESOLVED|REOPENED Component|Cluster |Cluster Resolution|FIXED |--- Product|Tomcat 7|Tomcat 6 Target Milestone|--- |default --- Comment #6 from Mark Thomas --- Whoops. Re-open for Tomcat 6. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53409] Request class actively restricts sending parameters in the body unless using POST
https://issues.apache.org/bugzilla/show_bug.cgi?id=53409 --- Comment #2 from Konstantin Kolinko --- If you want to backport the "parseBodyMethods" Connectors' attribute to Tomcat 6, someone (you?) has to prepare a patch for Tomcat 6 in unified diff format (as documented elsewhere), and attach it here or better to issue 48692 of which this one is a duplicate. The code to start is in r1041892, though there were minor changes to it later. http://svn.apache.org/viewvc?view=revision&revision=1041892 -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [Proposal] Preparatory refactoring for Resource handling refactoring
2012/6/17 Mark Thomas : > On 16/06/2012 19:18, Mark Thomas wrote: >> >> >> Konstantin Kolinko wrote: >> >>> 2012/6/16 Mark Thomas : > URLs are needed per Servlet API, so they cannot be removed. > Does our "jndi" schema need DirContext as underlying > implementation? Our jndi scheme was used to provide access to resources. I believe >>> all of that will now go. > I noticed the following commit in archives: > http://svn.apache.org/viewvc?view=revision&revision=1137646 so > we have to deal with such schema combinations as "jar:jndi:". No we won't. We only hadf to deal with URLs like that because we generated them. >>> >>> How are you going to implement ServletContext.getResource(String): >>> URL >>> >>> without a custom URL scheme (be it named "jndi" or somehow else)? >>> >>> For file resources it might be possible to produce the "actual" >>> URL pointing to a JAR entry or to a file (leaving aside the >>> question of whether it exposes too much details), but you cannot >>> do so with directories, as entries in a directory can be assembled >>> from several sources. >> >> My intention was to use the URL for the actual resource. For >> directories, I'll use the first matching dir I find although I need >> to re-read the spec and Javadoc to make sure there aren't any nasty >> surprises waiting to trip me up. > > Having re-read the specification and Javadoc, I don't see anything of > concern. Additional pairs of eyes wouldn't hurt though. > > How to handle getResource() for a directory that exists in one or more > overlays and/or the main WAR is an interesting question. I'll be sure to > raise it within the Servlet EG when we get back to that question. > If we remove JNDI stuff from resource handling, one of "challenges" might be to re-implement DefaultServlet using only Servlet API methods. Well, if the former is not possible, it might use the new resources API (that you are going to implement instead of jndi one) and be thus still tied with Tomcat internals... If one reimplements DefaultServlet, one of the tasks would be to generate directory listings. Those include file size and file timestamp. One needs to obtain URL of a resource, open its URLConnection and ask those attributes. One good thing with "jndi:" URLs returned via Servlet API is that they are backed by an instance of ProxyDirContext class and it has a cache (*). If we change implementation and return "true" URLs, they will bypass the cache. I suspect that using a "jar:" URL directly (in case of an unpacked WAR file) may have poor performance. Other good thing is that you can create relative URLs as "new URL(Url, String)", which inherits URLStreamHandler instance from the original URL, and thus inherits access to ProxyDirContext instance. If it is a "jndi" URL it will have access to the full resources hierarchy of the web application. If it is a "true" URL, it will be limited to its origin file system. The above two are the reasons why I think that in Tomcat 8 we cannot return "true" URLs from ServletContext.getResource(String) method and must still support the "jndi:" or some other proprietary URL schema. (*) for reference: TTL of entries in ProxyDirContext#cache is by default 5 seconds (5000). If the time has elapsed, the resource is revalidated by comparing its timestamp with original one The TTL is configured via ProxyDirContext constructor <- BaseDirContext#cacheTTL <- StandardContext#cacheTTL and thus is configurable on a . http://tomcat.apache.org/tomcat-7.0-doc/config/context.html Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GUMP@vmgump]: Project tomcat-trunk-validate-eoln (in module tomcat-trunk) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-validate-eoln has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 33 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-trunk-validate-eoln : Tomcat 8.x, a web server implementing Java Servlet 3.1, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate-eoln/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -INFO- Failed with reason build failed The following work was performed: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate-eoln/gump_work/build_tomcat-trunk_tomcat-trunk-validate-eoln.html Work Name: build_tomcat-trunk_tomcat-trunk-validate-eoln (Type: Build) Work ended in a state of : Failed Elapsed: 1 sec Command Line: /usr/lib/jvm/java-6-openjdk/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml validate-eoln [Working Directory: /srv/gump/public/workspace/tomcat-trunk] CLASSPATH: /usr/lib/jvm/java-6-openjdk/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/classes:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar - Buildfile: /srv/gump/public/workspace/tomcat-trunk/build.xml build-prepare: [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/classes [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/build [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/build/bin [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/build/conf [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/build/lib [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/build/logs [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/build/temp [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/build/webapps compile-prepare: [copy] Copying 1 file to /srv/gump/public/workspace/tomcat-trunk/java/org/apache/catalina/startup [copy] Copying 1 file to /srv/gump/public/workspace/tomcat-trunk/webapps/docs validate-eoln: [javac] Compiling 1 source file to /srv/gump/public/workspace/tomcat-trunk/output/classes [javac] javac: invalid target release: 1.7 [javac] Usage: javac [javac] use -help for a list of possible options BUILD FAILED /srv/gump/public/workspace/tomcat-trunk/build.xml:523: Compile failed; see the compiler error output for details. Total time: 1 second - To subscribe to this information via syndicated feeds: - RSS: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate-eoln/rss.xml - Atom: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate-eoln/atom.xml == Gump Tracking Only === Produced by Apache Gump(TM) version 2.3. Gump Run 1130072012, vmgump.apache.org:vmgump:1130072012 Gump E-mail Identifier (unique within run) #6. -- Apache Gump http://gump.apache.org/ [Instance: vmgump] - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GUMP@vmgump]: Project tomcat-trunk-dbcp (in module tomcat-trunk) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-dbcp has an issue affecting its community integration. This issue affects 3 projects, and has been outstanding for 33 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-trunk : Tomcat 8.x, a web server implementing Java Servlet 3.1, ... - tomcat-trunk-dbcp : Tomcat 8.x, a web server implementing Java Servlet 3.1, ... - tomcat-trunk-test : Tomcat 8.x, a web server implementing Java Servlet 3.1, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-dbcp/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -INFO- Made directory [/srv/gump/public/workspace/tomcat-trunk/tomcat-deps] -INFO- Failed with reason build failed -INFO- Failed to extract fallback artifacts from Gump Repository The following work was performed: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-dbcp/gump_work/build_tomcat-trunk_tomcat-trunk-dbcp.html Work Name: build_tomcat-trunk_tomcat-trunk-dbcp (Type: Build) Work ended in a state of : Failed Elapsed: 2 secs Command Line: /usr/lib/jvm/java-6-openjdk/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Dcommons-pool.home=/srv/gump/public/workspace/commons-pool-1.x -Dcommons-dbcp.home=/srv/gump/public/workspace/commons-dbcp-1.x -Dtomcat-dbcp.jar=/srv/gump/public/workspace/tomcat-trunk/tomcat-deps/tomcat-dbcp-30072012.jar -Dtomcat-dbcp.home=/srv/gump/public/workspace/tomcat-trunk/tomcat-deps build-tomcat-dbcp [Working Directory: /srv/gump/public/workspace/tomcat-trunk] CLASSPATH: /usr/lib/jvm/java-6-openjdk/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/packages/jta-spec1_0_1/jta-spec1_0_1.jar - Buildfile: /srv/gump/public/workspace/tomcat-trunk/build.xml build-prepare: [delete] Deleting directory /srv/gump/public/workspace/tomcat-trunk/output/build/temp [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/build/temp build-manifests: [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/manifests [copy] Copying 12 files to /srv/gump/public/workspace/tomcat-trunk/output/manifests build-tomcat-dbcp: [copy] Copying 70 files to /srv/gump/public/workspace/tomcat-trunk/tomcat-deps [patch] patching file src/java/org/apache/commons/dbcp/DelegatingCallableStatement.java [patch] Hunk #1 succeeded at 661 (offset -113 lines). [patch] patching file src/java/org/apache/commons/dbcp/cpdsadapter/DriverAdapterCPDS.java [patch] patching file src/java/org/apache/commons/dbcp/DelegatingResultSet.java [patch] Hunk #1 succeeded at 1079 (offset -195 lines). [patch] patching file src/java/org/apache/commons/dbcp/PoolingDataSource.java [patch] Hunk #1 succeeded at 437 (offset -52 lines). [patch] patching file src/java/org/apache/commons/dbcp/DelegatingConnection.java [patch] Hunk #1 succeeded at 678 (offset -126 lines). [patch] patching file src/java/org/apache/commons/dbcp/PoolingDriver.java [patch] Hunk #1 succeeded at 497 (offset -4 lines). [patch] patching file src/java/org/apache/commons/dbcp/DelegatingStatement.java [patch] Hunk #1 succeeded at 484 (offset -45 lines). [patch] patching file src/java/org/apache/commons/dbcp/DelegatingDatabaseMetaData.java [patch] Hunk #1 succeeded at 1204 (offset -173 lines). [patch] patching file src/java/org/apache/commons/dbcp/BasicDataSource.java [patch] Hunk #1 succeeded at 28 with fuzz 1. [patch] Hunk #2 succeeded at 1782 (offset -19 lines). [patch] patching file src/java/org/apache/commons/dbcp/datasources/InstanceKeyDataSource.java [patch] Hunk #1 succeeded at 887 (offset -1 lines). [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/tomcat-deps/src/java/org/apache/tomcat/dbcp [move] Moving 75 files to /srv/gump/public/workspace/tomcat-trunk/tomcat-deps/src/java/org/apache/tomcat/dbcp [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/tomcat-deps/classes [javac] Compiling 66 source files to /srv
[GUMP@vmgump]: Project tomcat-tc7.0.x-validate (in module tomcat-7.0.x) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc7.0.x-validate has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 33 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-tc7.0.x-validate : Tomcat 7.x, a web server implementing Java Servlet 3.0, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-validate/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on checkstyle exists, no need to add for property checkstyle.jar. -INFO- Failed with reason build failed The following work was performed: http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-validate/gump_work/build_tomcat-7.0.x_tomcat-tc7.0.x-validate.html Work Name: build_tomcat-7.0.x_tomcat-tc7.0.x-validate (Type: Build) Work ended in a state of : Failed Elapsed: 1 sec Command Line: /usr/lib/jvm/java-6-openjdk/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Dcheckstyle.jar=/srv/gump/public/workspace/checkstyle/target/checkstyle-5.6-SNAPSHOT.jar -Dexecute.validate=true validate [Working Directory: /srv/gump/public/workspace/tomcat-7.0.x] CLASSPATH: /usr/lib/jvm/java-6-openjdk/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-5.6-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-30072012.jar:/srv/gump/public/workspace/apache-commons/cli/target/commons-cli-1.3-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/exec/target/commons-exec-1.1.1-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/validator/dist/commons-validator-30072012.jar:/srv/gump/public/workspace/junit/dist/junit-30072012.jar:/srv/gump /public/workspace/junit/dist/junit-dep-30072012.jar:/srv/gump/public/workspace/google-guava/guava/target/guava-*[0-9T].jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-30072012.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-30072012.jar:/srv/gump/public/workspace/commons-collections-3.x/target/commons-collections-3.3-SNAPSHOT.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/jdom/build/jdom.jar:/srv/gump/public/workspace/velocity-engine/bin/velocity-30072012.jar:/srv/gump/public/workspace/velocity-engine/bin/velocity-30072012-dep.jar - download-validate: proxyflags: setproxy: testexist: [echo] Testing for /srv/gump/public/workspace/checkstyle/target/checkstyle-5.6-SNAPSHOT.jar downloadzip: validate: [mkdir] Created dir: /srv/gump/public/workspace/tomcat-7.0.x/output/res/checkstyle BUILD FAILED /srv/gump/public/workspace/tomcat-7.0.x/build.xml:450: Could not create type checkstyle due to java.lang.NoClassDefFoundError: com/google/common/collect/Lists at com.puppycrawl.tools.checkstyle.CheckStyleTask.(CheckStyleTask.java:78) at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:57) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.lang.reflect.Constructor.newInstance(Constructor.java:532) at org.apache.tools.ant.AntTypeDefinition.innerCreateAndSet(AntTypeDefinition.java:328) at org.apache.tools.ant.AntTypeDefinition.createAndSet(AntTypeDefinition.java:274) at org.apache.tools.ant.AntTypeDefinition.icreate(AntTypeDefinition.java:219) at org.apache.tools.ant.AntTypeDefinition.create(AntTypeDefinition.java:206) at org.apache.tools.ant.ComponentHelper.createComponent(ComponentHelper.java:286) at org.apache.tools.ant.ComponentHelper.createComponent(ComponentHelper.java:264) at org.apache.tools.ant.UnknownElement.makeObject(UnknownElement.java:417) at org.apache.tools.ant.UnknownElement.maybeConfigure(UnknownElement.java:163) at org.apache.tools.ant.Task.perform(Task.java:347)
[GUMP@vmgump]: Project tomcat-trunk-validate (in module tomcat-trunk) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-validate has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 33 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-trunk-validate : Tomcat 8.x, a web server implementing Java Servlet 3.1, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on checkstyle exists, no need to add for property checkstyle.jar. -INFO- Failed with reason build failed The following work was performed: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/gump_work/build_tomcat-trunk_tomcat-trunk-validate.html Work Name: build_tomcat-trunk_tomcat-trunk-validate (Type: Build) Work ended in a state of : Failed Elapsed: 1 sec Command Line: /usr/lib/jvm/java-6-openjdk/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Dcheckstyle.jar=/srv/gump/public/workspace/checkstyle/target/checkstyle-5.6-SNAPSHOT.jar -Dexecute.validate=true validate [Working Directory: /srv/gump/public/workspace/tomcat-trunk] CLASSPATH: /usr/lib/jvm/java-6-openjdk/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-5.6-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-30072012.jar:/srv/gump/public/workspace/apache-commons/cli/target/commons-cli-1.3-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/exec/target/commons-exec-1.1.1-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/validator/dist/commons-validator-30072012.jar:/srv/gump/public/workspace/junit/dist/junit-30072012.jar:/srv/gump /public/workspace/junit/dist/junit-dep-30072012.jar:/srv/gump/public/workspace/google-guava/guava/target/guava-*[0-9T].jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-30072012.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-30072012.jar:/srv/gump/public/workspace/commons-collections-3.x/target/commons-collections-3.3-SNAPSHOT.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/jdom/build/jdom.jar:/srv/gump/public/workspace/velocity-engine/bin/velocity-30072012.jar:/srv/gump/public/workspace/velocity-engine/bin/velocity-30072012-dep.jar:/srv/gump/packages/javamail-1.4/mail.jar:/srv/gump/packages/javamail-1.4/lib/mailapi.jar:/srv/gump/packages/jaf-1.1ea/activation.jar - download-validate: proxyflags: setproxy: testexist: [echo] Testing for /srv/gump/public/workspace/checkstyle/target/checkstyle-5.6-SNAPSHOT.jar downloadzip: validate: [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/res/checkstyle BUILD FAILED /srv/gump/public/workspace/tomcat-trunk/build.xml:461: Could not create type checkstyle due to java.lang.NoClassDefFoundError: com/google/common/collect/Lists at com.puppycrawl.tools.checkstyle.CheckStyleTask.(CheckStyleTask.java:78) at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:57) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.lang.reflect.Constructor.newInstance(Constructor.java:532) at org.apache.tools.ant.AntTypeDefinition.innerCreateAndSet(AntTypeDefinition.java:328) at org.apache.tools.ant.AntTypeDefinition.createAndSet(AntTypeDefinition.java:274) at org.apache.tools.ant.AntTypeDefinition.icreate(AntTypeDefinition.java:219) at org.apache.tools.ant.AntTypeDefinition.create(AntTypeDefinition.java:206) at org.apache.tools.ant.ComponentHelper.createComponent(ComponentHelper.java:286) at org.apache.tools.ant.ComponentHelper.createComponent(ComponentHelper.java:264) at org.apache.tools.ant.UnknownElement.makeObject(UnknownElement.java:417) at org.apache.tools.an
