Bug report for Tomcat 6 [2011/07/31]

2011-07-31 Thread bugzilla
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|41679|New|Enh|2007-02-22|SemaphoreValve should be able to filter on url pat|
|41883|Ass|Enh|2007-03-18|use abstract wrapper instead of plain X509Certific|
|43001|New|Enh|2007-07-30|JspC lacks setMappedFile and setDie for use in Ant|
|43400|New|Enh|2007-09-14|enum support for tag libs |
|43548|Opn|Enh|2007-10-04|xml schema for tomcat-users.xml   |
|43682|New|Enh|2007-10-23|JULI: web-inf/classes/logging.properties to suppor|
|43742|New|Enh|2007-10-30|.tag compiles  performed one at a time -- extremel|
|43979|New|Enh|2007-11-27|Add abstraction for Java and Classfile output |
|44199|New|Enh|2008-01-10|expose current backlog queue size |
|44225|New|Enh|2008-01-14|SSL connector tries to load the private keystore f|
|44264|New|Enh|2008-01-18|Clustering - Support for disabling multicasting an|
|44284|New|Enh|2008-01-23|Support java.lang.Iterable in c:forEach tag   |
|44294|New|Enh|2008-01-25|Support for EL functions with varargs |
|44312|New|Enh|2008-01-28|Warn when overwritting docBase of the default Host|
|44645|New|Enh|2008-03-20|[Patch] JNDIRealm - Doesn't support JNDI "java.nam|
|44787|New|Enh|2008-04-09|provide more error context on "java.lang.IllegalSt|
|44818|New|Enh|2008-04-13|tomcat hangs with GET when content-length is defin|
|45014|New|Enh|2008-05-15|Request and Response classes should have wrappers |
|45282|New|Enh|2008-06-25|NioReceiver doesn't close cleanly, leaving sockets|
|45283|Opn|Enh|2008-06-25|Provide a JSR196 implementation   |
|45428|New|Enh|2008-07-18|warn if the tomcat stop doesn't complete  |
|45832|New|Enh|2008-09-18|add DIGEST authentication support to Ant tasks|
|45871|New|Enh|2008-09-23|Support for salted and digested patches in DataSou|
|45878|New|Enh|2008-09-24|Generated jars do not contain proper manifests or |
|45879|Opn|Enh|2008-09-24|Windows installer fails to install NOTICE and RELE|
|45931|Opn|Enh|2008-10-01|trimSpaces incorrectly modifies output|
|45995|New|Enh|2008-10-13|RFE - MIME type extension not case sensitive  |
|46173|New|Enh|2008-11-09|Small patch for manager app: Setting an optional c|
|46263|New|Enh|2008-11-21|Tomcat reloading of context does not update contex|
|46264|New|Enh|2008-11-21|Shutting down tomcat with large number of contexts|
|46284|New|Enh|2008-11-24|Add flag to DeltaManager that blocks processing cl|
|46350|New|Enh|2008-12-05|Maven repository should contain source bundles|
|46497|New|Enh|2009-01-08|Install Tomcat Deployer/ANT on Windows Platform   |
|46655|New|Enh|2009-02-03|keystore's password handler   |
|46727|New|Enh|2009-02-17|DefaultServlet - serving multiple encodings   |
|46902|New|Enh|2009-03-24|LoginValve to bypass restrictions of j_security_ch|
|47214|New|Enh|2009-05-17|Inner classes that are explicitly referenced - sho|
|47230|New|Enh|2009-05-21|Include sample cert attributes for SSL connectors |
|47242|New|Enh|2009-05-22|request for AJP command line client   |
|47281|New|Enh|2009-05-28|Efficiency of the JDBCStore   |
|47407|New|Enh|2009-06-23|HttpSessionListener doesn't operate in the session|
|47467|New|Enh|2009-07-02|Deployment of the war file by URL when contextpath|
|47785|Opn|Enh|2009-09-04|Cluster MBean not registered  |
|47834|New|Enh|2009-09-14|TldConfig throws Exception when exploring unpacked|
|47880|New|Enh|2009-09-20|Lack of +x permissions on script files results cry|
|47919|New|Enh|2009-09-30|Log Tomcat & Java environment variables in additio|
|48543|New|Enh|2010-01-14|[Patch] More flexibility in specifying -Dcatalina.|
|48600|Opn|Enh|2010-01-22|Performance issue with tags   |
|48672|New|Enh|2010-02-03|Tomcat Virtual Host Manager (/host-manager) have b|
|48674|New|Enh|2010-02-03|Tomcat Virtual Host Manager application doesn't pe|
|48743|New|Enh|2010-02-15|Make the SLEEP variable in catalina.sh settable fr|
|48899|

Bug report for Tomcat 5 [2011/07/31]

2011-07-31 Thread bugzilla
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|28039|Opn|Enh|2004-03-30|Cluster Support for SingleSignOn  |
|33262|Opn|Enh|2005-01-27|Service Manager autostart should check for adminis|
|36362|New|Nor|2005-08-25|missing check for Java reserved keywords in tag fi|
|36837|Inf|Enh|2005-09-28|Looking for ProxyHandler implementation of Http re|
|38216|Inf|Enh|2006-01-10|Extend Jmxproxy to allow call of MBean Operations |
|40510|New|Enh|2006-09-14|installer does not create shortcuts for all users |
|40728|New|Enh|2006-10-11|Catalina MBeans use non-serializable classes  |
|40766|New|Enh|2006-10-16|Using an unsecure jsessionid with mod_proxy_ajp ov|
|40881|Opn|Enh|2006-11-02|Unable to receive message through  TCP channel -> |
|41007|Opn|Enh|2006-11-20|Can't define customized 503 error page|
|41179|New|Enh|2006-12-15|400 Bad Request response during auto re-deployment|
|41227|Opn|Enh|2006-12-21|When the jasper compiler fails to compile a JSP, i|
|41673|New|Enh|2007-02-21|Jasper output the message of compiling error using|
|41697|Ver|Enh|2007-02-25|make visible in debug output if charset from brows|
|41718|New|Enh|2007-02-27|Status 302 response to GET request has no body whe|
|43866|New|Enh|2007-11-14|add support for session attribute propagation with|
|43925|Opn|Enh|2007-11-21|org.apache.jasper.runtime.BodyContentImpl causing |
|44216|New|Enh|2008-01-11|Don't reuse session ID even if emptySessionPath=tr|
|44904|New|Enh|2008-04-29|Provide warning message when DataSource's maxActiv|
|45052|New|Enh|2008-05-21|Provide read only access for certain role in Manag|
|45882|New|Enh|2008-09-24|Ensure all jars have full manifests and N & L file|
|47203|New|Enh|2009-05-15|Make JMXAdaptorLifecycleListener Java 1.4 compatib|
|48717|Opn|Reg|2010-02-09|Session listeners not called on cluster node start|
|50744|Opn|Maj|2011-02-09|When Tomcat was updated from version 5.5.27 to 5.5|
|51042|New|Nor|2011-04-08|HttpSessionListener.sessionCreated() is called a s|
|51073|New|Maj|2011-04-16|Misconfigured SSLProtocol with an AprEndpoint sile|
|51473|New|Nor|2011-07-05|SecurityConfig?set "package.definition" security p|
|51550|Opn|Nor|2011-07-25|Empty response instead of error page for IllegalSt|
+-+---+---+--+--+
| Total   28 bugs   |
+---+

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Bug report for Tomcat Connectors [2011/07/31]

2011-07-31 Thread bugzilla
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|34526|Opn|Nor|2005-04-19|Truncated content in decompressed requests from mo|
|35959|Opn|Enh|2005-08-01|mod_jk not independant of UseCanonicalName|
|39967|Inf|Nor|2006-07-05|mod_jk gives segmentation fault when apache is sta|
|40208|Inf|Nor|2006-08-08|Request-Dump when ErrorDocument in httpd.conf is a|
|42366|Inf|Nor|2007-05-09|Memory leak in newer mod_jk version when connectio|
|43303|New|Enh|2007-09-04|Versioning under Windows not reported by many conn|
|43968|New|Enh|2007-11-26|[patch] support ipv6 with mod_jk  |
|44290|New|Nor|2008-01-24|mod_jk/1.2.26: retry is not useful for an importan|
|44349|New|Maj|2008-02-04|mod_jk/1.2.26 module does not read worker.status.s|
|44379|New|Enh|2008-02-07|convert the output of strftime into UTF-8 |
|44454|New|Nor|2008-02-19|busy count reported in mod_jk inflated, causes inc|
|44571|New|Enh|2008-03-10|Limits busy per worker to a threshold |
|45063|New|Nor|2008-05-22|JK-1.2.26 IIS ISAPI filter issue when running diff|
|45313|New|Nor|2008-06-30|mod_jk 1.2.26 & apache 2.2.9 static compiled on so|
|45395|New|Min|2008-07-14|MsgAjp dump method does not dump packet when being|
|46337|New|Nor|2008-12-04|real worker name is wrong |
|46406|New|Enh|2008-12-16|Supporting relative paths in isapi_redirect.proper|
|46676|New|Enh|2009-02-09|Configurable test request for Watchdog thread |
|46767|New|Enh|2009-02-25|mod_jk to send DECLINED in case no fail-over tomca|
|47038|New|Enh|2009-04-15|USE_FLOCK_LK redefined compiler warning when using|
|47327|New|Enh|2009-06-07|remote_user not logged in apache logfile  |
|47617|New|Enh|2009-07-31|include time spent doing ajp_get_endpoint() in err|
|47678|New|Cri|2009-08-11|Unable to allocate shared memory when using isapi_|
|47714|New|Cri|2009-08-20|Reponse mixed between users   |
|47750|New|Maj|2009-08-27|Loss of worker settings when changing via jkstatus|
|47795|New|Maj|2009-09-07|service sticky_session not being set correctly wit|
|47840|Inf|Min|2009-09-14|A broken worker name is written in the log file.  |
|48191|New|Maj|2009-11-13|Problem with mod_jk 1.2.28 - Can not render up the|
|48460|New|Nor|2009-12-30|mod_proxy_ajp document has three misleading portio|
|48490|New|Nor|2010-01-05|Changing a node to stopped in uriworkermap.propert|
|48513|New|Enh|2010-01-09|IIS Quick setup instructions  |
|48564|New|Nor|2010-01-18|Unable to turn off retries for LB worker  |
|48830|New|Nor|2010-03-01|IIS shutdown blocked in endpoint service when serv|
|48891|Opn|Enh|2010-03-11|Missing EOL-style settings in tomcat/jk/trunk |
|49035|New|Maj|2010-04-01|data lost when post a multipart/form-data form|
|49048|New|Nor|2010-04-05|ACL not applied to redirect URLs  |
|49063|New|Enh|2010-04-07|Please add JkStripSession status in jk-status work|
|49135|New|Enh|2010-04-16|SPDY Connector for The Tomcat |
|49413|Opn|Reg|2010-06-09|Apache Mod_jk 1.2.30 is shutting down communicatio|
|49469|New|Enh|2010-06-19|Workers status page has negative number of connect|
|49732|Opn|Nor|2010-08-10|reply_timeout can't wait forever. |
|49822|New|Enh|2010-08-25|Add hash lb worker method |
|49903|New|Enh|2010-09-09|Make workers file reloadable  |
|50186|New|Nor|2010-10-31|Wrong documentation of connection_pool_timeout / c|
|50233|New|Cri|2010-11-08|support long URLs (more than 2048)|
|50385|New|Trv|2010-11-30|There's a Spanish Inquisition error in the documen|
|50511|Inf|Nor|2010-12-22|WARNING about Internal Dummy Connection of Apache |
|50694|New|Nor|2011-01-31|ModJK NSAPI inserted headers case sensitivity issu|
|51235|Inf|Maj|2011-05-20|Access Violation in httpd.exe originating in mod_j|
|51253|New|Nor|2011-05-24|use_server_errors for status 401 does not forward |
|51261|New|Nor|2011-05-25|JK cannt support ipv6 |
|51326|

Bug report for Tomcat 7 [2011/07/31]

2011-07-31 Thread bugzilla
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|10021|New|Enh|2002-06-19|Include upgrade option in installer   |
|16579|New|Enh|2003-01-30|documentation page layout/style breaks wrapping to|
|18500|New|Enh|2003-03-30|Host aliases to match by regular expression (trivi|
|48358|Opn|Enh|2009-12-09|JSP-unloading reloaded|
|48550|Inf|Enh|2010-01-14|Update examples and default server.xml to use UTF-|
|48892|New|Enh|2010-03-11|Use URIEncoding from server.xml for decoding post |
|49290|New|Enh|2010-05-14|Using a JarScanner with scanAllDirectories=true ca|
|49395|New|Enh|2010-06-06|manager.findLeaks : display the date when the leak|
|49589|New|Enh|2010-07-12|Tag handlers with constant attribute values are al|
|49683|New|Enh|2010-08-01|Separate keep-alive and connection timeout with AP|
|49785|New|Enh|2010-08-19|Enabling TLS for JNDIRealm|
|49821|New|Enh|2010-08-25|Tomcat CLI|
|50019|New|Enh|2010-09-28|Adding JNDI "lookup-name" support In XML and Resou|
|50175|New|Enh|2010-10-28|Enhance memory leak detection by selectively apply|
|50234|New|Enh|2010-11-08|JspC use servlet 3.0 features |
|50504|New|Enh|2010-12-21|Allow setting query string character set trough re|
|50570|New|Enh|2011-01-11|Allow explicit use of FIPS mode in APR lifecycle l|
|50670|New|Enh|2011-01-27|Tribes | RpcChannel | Add option to specify extern|
|50923|New|Enh|2011-03-13|Difficult to pick out valid values from config des|
|50949|New|Enh|2011-03-20|Allow configuration of service name, AJP port, ser|
|51181|New|Enh|2011-05-10|Add support for Web Sockets   |
|51195|New|Enh|2011-05-13|"Find leaks" reports a false positive memory/class|
|51334|New|Enh|2011-06-07|Web SSO support based on WS-Federation Passive Req|
|51408|Opn|Enh|2011-06-21|String.getBytes() and new String(byte[]) use defau|
|51423|Inf|Enh|2011-06-23|[Patch] to add a path and a version parameters to |
|51463|New|Enh|2011-07-01|Tomcat.setBaseDir  (package org.apache.catalina.st|
|51496|New|Enh|2011-07-11|NSIS - Warn that duplicate service name will resul|
|51497|New|Enh|2011-07-11|Use canonical IPv6 text representation in logs|
|51500|New|Enh|2011-07-12|NSIS - Allow configuration of more service propert|
|51526|New|Enh|2011-07-18|Process web application context config with embedd|
|51584|New|Maj|2011-07-29|Crash (infinite loop) when files starting with '#'|
|51586|New|Nor|2011-07-29|ContextConfig.checkHandlesTypes() doesn't check fo|
|51587|New|Enh|2011-07-29|Implement status and uptime commands  |
+-+---+---+--+--+
| Total   33 bugs   |
+---+

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Bug report for Taglibs [2011/07/31]

2011-07-31 Thread bugzilla
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|38193|Ass|Enh|2006-01-09|[RDC] BuiltIn Grammar support for Field   |
|38600|Ass|Enh|2006-02-10|[RDC] Enable RDCs to be used in X+V markup (X+RDC)|
|42413|New|Enh|2007-05-14|[PATCH] Log Taglib enhancements   |
|46052|New|Nor|2008-10-21|SetLocaleSupport is slow to initialize when many l|
|48333|New|Enh|2009-12-02|TLD generator |
|50825|New|Nor|2011-02-24|Site still has links to Jakarta for mailing lists |
|51234|New|Nor|2011-05-20|NumberFormatException in fmt:formatNumber tag |
|51382|New|Maj|2011-06-15|Link to download pages are broken |
+-+---+---+--+--+
| Total8 bugs   |
+---+

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Bug report for Tomcat Modules [2011/07/31]

2011-07-31 Thread bugzilla
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|48240|New|Nor|2009-11-19|Tomcat-Lite missing @Override markers |
|48268|New|Nor|2009-11-23|Patch to fix generics in tomcat-lite  |
|48861|New|Nor|2010-03-04|Files without AL headers  |
|49685|New|Nor|2010-08-02|Unsafe synchronization in class ManagedBean   |
|49686|New|Nor|2010-08-02|Using an instance lock to protect static shared da|
|49953|Opn|Nor|2010-09-17|Missing @Override annotations |
|50565|New|Min|2011-01-10|Static variables should be accessed in a static wa|
|50566|New|Nor|2011-01-10|Duplicate assignment to connection variable   |
|50571|Inf|Nor|2011-01-11|Tomcat 7 JDBC connection pool exception enhancemen|
|50660|New|Min|2011-01-26|Improve validationQuery error handling|
|50860|New|Nor|2011-03-03|In case of invalid or empty slqQuery connection ar|
|50864|New|Nor|2011-03-03|Reconfigure pool on the fly using JMX |
|51139|New|Nor|2011-05-01|Possible bug in code related to "validatorClassNam|
|51198|New|Nor|2011-05-13|Trunk Version : Performance enhancement in Connect|
|51237|New|Nor|2011-05-20|SlowQueryReport interceptor does not log anything |
|51388|New|Enh|2011-06-16|SlowQueryReport should respect Statement.getQueryT|
|51582|New|Nor|2011-07-29|NPE in SlowQueryReport|
|51583|New|Nor|2011-07-29|ConnectionPool.close() always waits one second unn|
+-+---+---+--+--+
| Total   18 bugs   |
+---+

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Bug report for Tomcat Native [2011/07/31]

2011-07-31 Thread bugzilla
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|45392|New|Nor|2008-07-14|No OCSP support for client SSL verification   |
|46179|Opn|Maj|2008-11-10|apr ssl client authentication |
|48655|Inf|Nor|2010-02-02|Active multipart downloads prevent tomcat shutdown|
|49038|Inf|Nor|2010-04-02|Crash in tcnative |
|51477|Opn|Enh|2011-07-05|Support all protocol combinations in SSLProtocol o|
+-+---+---+--+--+
| Total5 bugs   |
+---+

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1152593 - in /tomcat/trunk: java/org/apache/naming/resources/DirContextURLConnection.java webapps/docs/changelog.xml

2011-07-31 Thread markt
Author: markt
Date: Sun Jul 31 16:59:39 2011
New Revision: 1152593

URL: http://svn.apache.org/viewvc?rev=1152593&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51584
Ensure file paths are encoded/decoded when translated to/from URLs so special 
characters don't cause issues.

Modified:
tomcat/trunk/java/org/apache/naming/resources/DirContextURLConnection.java
tomcat/trunk/webapps/docs/changelog.xml

Modified: 
tomcat/trunk/java/org/apache/naming/resources/DirContextURLConnection.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/naming/resources/DirContextURLConnection.java?rev=1152593&r1=1152592&r2=1152593&view=diff
==
--- tomcat/trunk/java/org/apache/naming/resources/DirContextURLConnection.java 
(original)
+++ tomcat/trunk/java/org/apache/naming/resources/DirContextURLConnection.java 
Sun Jul 31 16:59:39 2011
@@ -22,6 +22,8 @@ import java.io.IOException;
 import java.io.InputStream;
 import java.net.URL;
 import java.net.URLConnection;
+import java.net.URLDecoder;
+import java.net.URLEncoder;
 import java.security.Permission;
 import java.util.ArrayList;
 import java.util.Collections;
@@ -153,6 +155,7 @@ public class DirContextURLConnection 
 path = path.substring(contextPath.length());
 }
 }
+path = URLDecoder.decode(path, "UTF-8");
 object = context.lookup(path);
 attributes = context.getAttributes(path);
 if (object instanceof Resource)
@@ -385,7 +388,8 @@ public class DirContextURLConnection 
 
 // Reopen resource
 try {
-resource = (Resource) context.lookup(getURL().getFile());
+resource = (Resource) context.lookup(
+URLDecoder.decode(getURL().getFile(), "UTF-8"));
 } catch (NamingException e) {
 // Ignore
 }
@@ -445,7 +449,8 @@ public class DirContextURLConnection 
 context.list(file.substring(start));
 while (enumeration.hasMoreElements()) {
 NameClassPair ncp = enumeration.nextElement();
-result.addElement(ncp.getName());
+result.addElement(
+URLEncoder.encode(ncp.getName(), "UTF-8"));
 }
 } catch (NamingException e) {
 // Unexpected exception

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1152593&r1=1152592&r2=1152593&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Sun Jul 31 16:59:39 2011
@@ -95,6 +95,11 @@
 the current request thread name. Based on a patch from Felix 
Schumacher.
 (timw)
   
+  
+51584: Ensure file paths are encoded/decoded when translated
+to/from URLs when working with resources from a Context so special
+characters don't cause issues. (markt)
+  
 
   
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 51584] Crash (infinite loop) when files starting with '#' are in the library tree

2011-07-31 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51584

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED
 OS/Version||All

--- Comment #1 from Mark Thomas  2011-07-31 17:00:49 UTC ---
Thanks for the report.

The fix needs to be at a lower level than the patch you suggest to address the
root cause rather than one of the symptoms.

The patch has been applied to 7.0.x and will be included in 7.0.20 onwards.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1152595 - in /tomcat/trunk: java/org/apache/catalina/startup/ContextConfig.java webapps/docs/changelog.xml

2011-07-31 Thread markt
Author: markt
Date: Sun Jul 31 17:08:43 2011
New Revision: 1152595

URL: http://svn.apache.org/viewvc?rev=1152595&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51586
Expand error handling to cover anything that is recoverable (or might be 
recoverable) when loading classes during HandlesTypes processing.

Modified:
tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java?rev=1152595&r1=1152594&r2=1152595&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java (original)
+++ tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java Sun Jul 31 
17:08:43 2011
@@ -2016,6 +2016,11 @@ public class ContextConfig
 log.warn(sm.getString("contextConfig.invalidSciHandlesTypes",
 className), e);
 return;
+} catch (Throwable t) {
+ExceptionUtils.handleThrowable(t);
+log.warn(sm.getString("contextConfig.invalidSciHandlesTypes",
+className), t);
+return;
 }
 
 if (clazz.isAnnotation()) {

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1152595&r1=1152594&r2=1152595&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Sun Jul 31 17:08:43 2011
@@ -100,6 +100,11 @@
 to/from URLs when working with resources from a Context so special
 characters don't cause issues. (markt)
   
+  
+51586: Expand error handling to cover anything that is
+recoverable (or might be recoverable) when loading classes during
+HandlesTypes processing. (markt)
+  
 
   
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 51586] ContextConfig.checkHandlesTypes() doesn't check for VerifyError when loading class

2011-07-31 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51586

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED
 OS/Version||All

--- Comment #1 from Mark Thomas  2011-07-31 17:10:48 UTC ---
Thanks for the report. I expanded the exception handle most eventualities. If
an unhandled exception happens now, the Tomcat instance will have much bigger
problems than a failed annotation scan (and is probably on its way to
crashing).

The fix is in 7.0.x and will be included in 7.0.20 onwards.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Servlet 3.1, Tomcat 8 etc.

2011-07-31 Thread Mark Thomas
On 26/07/2011 18:30, Mark Thomas wrote:
> The Servlet EG is starting to discuss changes to the Servlet API for
> 3.1. It would be useful if the option existed to implement some of these
> changes in Tomcat trunk. The benefits of this are:
> - we can see how feasible the API changes are to implement
> - users can try out the new APIs (assuming we do a Tomcat 8 alpha release)

Thanks to all those that responded. I have been through the thread and
have reported the result of the discussion below.

> Therefore, after the next Tomcat 7 release, I would like to do the
> following:
> - Copy tomcat/trunk to tomcat/tc7.0.x/trunk

No objections.

> - Start making Servlet API changes to tomcat/trunk

Overall, there were no objections but there were some queries on why
this was necessary / could it be delayed / should it be on a separate
branch.

I agree that there is a risk that truck gets too experimental or too far
away from what everyone is comfortable with. There are three aspects to
separating trunk and 7.0.x:
a) spec changes
b) re-factoring
c) new features

b) & c) should not get too experimental. If we stick to small
incremental commits we can call a halt if things go to far and revert as
required.

a) might get experimental. My suggestion is to work with trunk for now
but move to a branch if there are any new features that require lots of
changes or something where the EG is undecided on and there may be
significant changes.

> Assuming that there are no objections to that plan, that leads to a
> couple of other questions.
> 
> 1. Should tomcat/tc7.0.x/trunk be RTC or CTR?

The balance of opinion was for CTR for now. I suspect the balance will
shift towards RTC over time. I suggest we revisit this in ~3 months.

> 2. With tomcat/trunk becoming the basis for Tomcat 8, I would like to
> see earlier and more frequent alpha/beta releases than we had for Tomcat
> 7. That would increase the effective number of versions we are
> supporting. With that in mind, should we announce end of support for
> 5.5.x with the last release expected in ~12 months time?

No objections. There was a query about providing just security fixes for
a further year. My suggestion is that we announce 5.5.x End-Of-Life ASAP
with a date of 31 August 2012 with a caveat (as there is with 3.x, 4.x
and 5.0.x) that a committer may choose to release 5.5.x after that date
but that any release should not be expected or relied upon.

Assuming there are no objections, I'll create 7.0.x during the next
7.0.x release and announce EOL for 5.5.x in a week or so.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1152601 - in /tomcat/trunk: java/org/apache/catalina/valves/AccessLogValve.java webapps/docs/changelog.xml

2011-07-31 Thread markt
Author: markt
Date: Sun Jul 31 17:39:25 2011
New Revision: 1152601

URL: http://svn.apache.org/viewvc?rev=1152601&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51588
Make it easier to extend the AccessLogValve to add support for custom elements.

Modified:
tomcat/trunk/java/org/apache/catalina/valves/AccessLogValve.java
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/catalina/valves/AccessLogValve.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/AccessLogValve.java?rev=1152601&r1=1152600&r2=1152601&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/valves/AccessLogValve.java (original)
+++ tomcat/trunk/java/org/apache/catalina/valves/AccessLogValve.java Sun Jul 31 
17:39:25 2011
@@ -1912,7 +1912,7 @@ public class AccessLogValve extends Valv
 /**
  * create an AccessLogElement implementation which needs header string
  */
-private AccessLogElement createAccessLogElement(String header, char 
pattern) {
+protected AccessLogElement createAccessLogElement(String header, char 
pattern) {
 switch (pattern) {
 case 'i':
 return new HeaderElement(header);
@@ -1934,7 +1934,7 @@ public class AccessLogValve extends Valv
 /**
  * create an AccessLogElement implementation
  */
-private AccessLogElement createAccessLogElement(char pattern) {
+protected AccessLogElement createAccessLogElement(char pattern) {
 switch (pattern) {
 case 'a':
 return new RemoteAddrElement();

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1152601&r1=1152600&r2=1152601&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Sun Jul 31 17:39:25 2011
@@ -105,6 +105,10 @@
 recoverable (or might be recoverable) when loading classes during
 HandlesTypes processing. (markt)
   
+  
+51588: Make it easier to extend the AccessLogValve to add
+support for custom elements. (markt)
+  
 
   
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1152602 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-07-31 Thread markt
Author: markt
Date: Sun Jul 31 17:41:15 2011
New Revision: 1152602

URL: http://svn.apache.org/viewvc?rev=1152602&view=rev
Log:
Proposal

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1152602&r1=1152601&r2=1152602&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Sun Jul 31 17:41:15 2011
@@ -182,3 +182,9 @@ PATCHES PROPOSED TO BACKPORT:
   (note: The only change to NioEndpoint is adding a sync)
   +1: markt
   -1:
+
+* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51588
+  Make it easier to extend the AccessLogValve to add support for custom 
elements
+  http://svn.apache.org/viewvc?rev=1152601&view=rev
+  +1: markt
+  -1:



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 51588] Change access modifiers in AccessLogValve to make it easier to extend

2011-07-31 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51588

--- Comment #4 from Mark Thomas  2011-07-31 17:41:17 UTC ---
Methods changed in 7.0.x and will be included in 7.0.20 onwards.

Same change proposed for 6.0.x.

Even if Tomcat does support this particular use case, the general one of
extensibility is a valid one.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Strange problem in TC7 manager

2011-07-31 Thread Rainer Jung
Reproduction:

- add manager-jmx and manager-status to tomcat-users.xml
- Start TC 7 trunk
- As first request call http://localhost:8080/manager/jmxproxy
  Response OK
- As second request call http://localhost:8080/manager/manager/all
  Response Exception:

javax.servlet.ServletException: java.lang.NullPointerException

org.apache.catalina.manager.StatusManagerServlet.doGet(StatusManagerServlet.java:305)
javax.servlet.http.HttpServlet.service(HttpServlet.java:621)
javax.servlet.http.HttpServlet.service(HttpServlet.java:722)

org.apache.catalina.filters.SetCharacterEncodingFilter.doFilter(SetCharacterEncodingFilter.java:108)

root cause

java.lang.NullPointerException

org.apache.catalina.manager.StatusTransformer.writeDetailedState(StatusTransformer.java:553)

org.apache.catalina.manager.StatusManagerServlet.doGet(StatusManagerServlet.java:300)
javax.servlet.http.HttpServlet.service(HttpServlet.java:621)
javax.servlet.http.HttpServlet.service(HttpServlet.java:722)

org.apache.catalina.filters.SetCharacterEncodingFilter.doFilter(SetCharacterEncodingFilter.java:108)

In fact mBeanServer in StatusManagerServlet is null.

If you call /manager/status/all first, then it'll be OK, even after
jmxproxy. Adding some debug log shows, that init() in
StatusManagerServlet, which sets MBeanServer is called for another
instance, than the actual call to doGet(), which stills has MBeanServer
set to null.

Any idea what's happening here?

Regards,

Rainer


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1152610 - /tomcat/trunk/test/org/apache/catalina/comet/TestCometProcessor.java

2011-07-31 Thread markt
Author: markt
Date: Sun Jul 31 18:21:56 2011
New Revision: 1152610

URL: http://svn.apache.org/viewvc?rev=1152610&view=rev
Log:
Remove unnecessary call. Reduce timeout.

Modified:
tomcat/trunk/test/org/apache/catalina/comet/TestCometProcessor.java

Modified: tomcat/trunk/test/org/apache/catalina/comet/TestCometProcessor.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/comet/TestCometProcessor.java?rev=1152610&r1=1152609&r2=1152610&view=diff
==
--- tomcat/trunk/test/org/apache/catalina/comet/TestCometProcessor.java 
(original)
+++ tomcat/trunk/test/org/apache/catalina/comet/TestCometProcessor.java Sun Jul 
31 18:21:56 2011
@@ -131,7 +131,7 @@ public class TestCometProcessor extends 
 // Create connection to Comet servlet
 final Socket socket =
 SocketFactory.getDefault().createSocket("localhost", getPort());
-socket.setSoTimeout(6);
+socket.setSoTimeout(1);
 
 final OutputStream os = socket.getOutputStream();
 String requestLine = "POST http://localhost:"; + getPort() +
@@ -143,7 +143,6 @@ public class TestCometProcessor extends 
 PingWriterThread writeThread = new PingWriterThread(100, os);
 writeThread.start();
 
-socket.setSoTimeout(6);
 InputStream is = socket.getInputStream();
 ResponseReaderThread readThread = new ResponseReaderThread(is);
 readThread.start();



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Strange problem in TC7 manager

2011-07-31 Thread Mark Thomas
On 31/07/2011 18:57, Rainer Jung wrote:
> Reproduction:
> 
> - add manager-jmx and manager-status to tomcat-users.xml
> - Start TC 7 trunk
> - As first request call http://localhost:8080/manager/jmxproxy
>   Response OK
> - As second request call http://localhost:8080/manager/manager/all
>   Response Exception:
> 
> javax.servlet.ServletException: java.lang.NullPointerException
>   
> org.apache.catalina.manager.StatusManagerServlet.doGet(StatusManagerServlet.java:305)
>   javax.servlet.http.HttpServlet.service(HttpServlet.java:621)
>   javax.servlet.http.HttpServlet.service(HttpServlet.java:722)
>   
> org.apache.catalina.filters.SetCharacterEncodingFilter.doFilter(SetCharacterEncodingFilter.java:108)
> 
> root cause
> 
> java.lang.NullPointerException
>   
> org.apache.catalina.manager.StatusTransformer.writeDetailedState(StatusTransformer.java:553)
>   
> org.apache.catalina.manager.StatusManagerServlet.doGet(StatusManagerServlet.java:300)
>   javax.servlet.http.HttpServlet.service(HttpServlet.java:621)
>   javax.servlet.http.HttpServlet.service(HttpServlet.java:722)
>   
> org.apache.catalina.filters.SetCharacterEncodingFilter.doFilter(SetCharacterEncodingFilter.java:108)
> 
> In fact mBeanServer in StatusManagerServlet is null.
> 
> If you call /manager/status/all first, then it'll be OK, even after
> jmxproxy. Adding some debug log shows, that init() in
> StatusManagerServlet, which sets MBeanServer is called for another
> instance, than the actual call to doGet(), which stills has MBeanServer
> set to null.
> 
> Any idea what's happening here?

Not yet, although it is probably my fault :)

I can reproduce this, looking in more detail now...

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Strange problem in TC7 manager

2011-07-31 Thread Mark Thomas
On 31/07/2011 19:29, Mark Thomas wrote:
> On 31/07/2011 18:57, Rainer Jung wrote:
>> Any idea what's happening here?
> 
> Not yet, although it is probably my fault :)
> 
> I can reproduce this, looking in more detail now...

The problem is that calling isSingleThreadModel (triggered by reading
the JMX attributes) triggers creation of an instance that is then thrown
away but the instanceInitialized flag is set. When the first request is
received a new instance is created but not initialized.

I#ll see if I can come up with a patch. I cam also see a couple of other
ways this could go wrong. I'll try and fix those too.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Strange problem in TC7 manager

2011-07-31 Thread Rainer Jung
On 31.07.2011 20:45, Mark Thomas wrote:
> On 31/07/2011 19:29, Mark Thomas wrote:
>> On 31/07/2011 18:57, Rainer Jung wrote:
>>> Any idea what's happening here?
>>
>> Not yet, although it is probably my fault :)
>>
>> I can reproduce this, looking in more detail now...
> 
> The problem is that calling isSingleThreadModel (triggered by reading
> the JMX attributes) triggers creation of an instance that is then thrown
> away but the instanceInitialized flag is set. When the first request is
> received a new instance is created but not initialized.
> 
> I#ll see if I can come up with a patch. I cam also see a couple of other
> ways this could go wrong. I'll try and fix those too.

Thank's for investigating, interesting explanation.

Unfortunately it is not completely unlikely, that a jmxproxy dump is
done early after startup. e.g. as part of monitoring or availability check.

Found it while testing tcnative ...

Regards,

Rainer

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1152621 - in /tomcat/trunk: java/org/apache/catalina/core/StandardWrapper.java webapps/docs/changelog.xml

2011-07-31 Thread markt
Author: markt
Date: Sun Jul 31 19:34:14 2011
New Revision: 1152621

URL: http://svn.apache.org/viewvc?rev=1152621&view=rev
Log:
Ensure that calls to StandardWrapper methods() that may trigger creation of a 
Servlet instance always do so in way that correctly instantiates a Servlet 
instance.

Modified:
tomcat/trunk/java/org/apache/catalina/core/StandardWrapper.java
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/catalina/core/StandardWrapper.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/StandardWrapper.java?rev=1152621&r1=1152620&r2=1152621&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/StandardWrapper.java (original)
+++ tomcat/trunk/java/org/apache/catalina/core/StandardWrapper.java Sun Jul 31 
19:34:14 2011
@@ -566,8 +566,18 @@ public class StandardWrapper extends Con
  */
 public boolean isSingleThreadModel() {
 
+// Short-cuts
+// If singleThreadModel is true, must have already checked this
+// If instance != null, must have already loaded 
+if (singleThreadModel || instance != null) {
+return singleThreadModel;
+}
+
+// The logic to determine this safely is more complex than one might
+// expect. allocate() already has the necessary logic so re-use it.
 try {
-loadServlet();
+Servlet s = allocate();
+deallocate(s);
 } catch (Throwable t) {
 ExceptionUtils.handleThrowable(t);
 }
@@ -608,7 +618,9 @@ public class StandardWrapper extends Con
 @Override
 public String[] getServletMethods() throws ServletException {
 
-Class servletClazz = loadServlet().getClass();
+instance = loadServlet();
+
+Class servletClazz = instance.getClass();
 if (!javax.servlet.http.HttpServlet.class.isAssignableFrom(
 servletClazz)) {
 return DEFAULT_SERVLET_METHODS;

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1152621&r1=1152620&r2=1152621&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Sun Jul 31 19:34:14 2011
@@ -109,6 +109,11 @@
 51588: Make it easier to extend the AccessLogValve to add
 support for custom elements. (markt)
   
+  
+Ensure that calls to StandardWrapper methods() that may trigger 
creation
+of a Servlet instance always do so in way that correctly instantiates a
+Servlet instance. (markt)
+  
 
   
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat Native 1.1.22

2011-07-31 Thread Rainer Jung
On 29.07.2011 12:06, jean-frederic clere wrote:
> [X] Stable - no major issues, no regressions
> [ ] Beta   - at least one significant issue -- tell us what it is
> [ ] Alpha  - multiple significant issues -- tell us what they are

Detailed results ("-" indicates things which we could improve). Sorry
for the long list, but I didn't check tcnative thoroughly for a long
time. Overall I'm still +1 for stable, because I didn't find
regressions. But there is room for improvement.

+ Tested with Java 1.6.0_26 (but configured against Java 1.5),
  APR 1.4.5 and OpenSSL 1.0.1d
+ Platforms Solaris 8+10 Sparc, SLES 10, 32 and 64 Bits,
  RHEL 5 64 Bits
+ MD5 OK
- No SHA1, should be added for the future
+ signatures OK
+ key in KEYS file
- KEYS file is contained in the source distribution,
  I think it would be better to remove it there, because
  people should *not* check the key against one in the untrusted
  download.
+ gz and zip for sources consistent
- Except for diferent permissions: zip seems to also contain group
  write permissions. Not a real problem, but it's a bit strange
  that perms differ between the archive.
  Weren't they build on the same system with the same user?
+ source dist consistent with svn tag
- Except for the following pieces missing in the source dist:
  - jnirelease.sh
  - xdocs (but sources contain docs generated from xdocs)
  I suggets for the future we also include the script and the xdocs
  to make source dist more complete and self-contained.
- README.txt: is very short (not very helpful).
  Also: paths beginning with examples/ miss a leading "jni/"
- native/BUILDING: suggests to "ant echo-example", but it is
  "ant run-echo"
- file jni/native/srclib/VERSIONS: what's the reason for this file?
  The contents seem outdated and it seems not to get used anywhere
- docs/news could get an update for 2011
- config-guess and config.sub are more recent than the ones
  from the APR you crated the source against (good) but still
  quite old ('2008-01-23' instead is '2011-06-03'). That's an issue
  for people trying to build tcnative on very new platforms,
  which are then not detected correctly by those config scripts.
- Binaries build against old APR 1.3.12 (recent ist 1.4.5)
  and OpenSSL 0.9.8r (recent ist 1.0.1d).
  Is that intentional?
+ recreated release with jnirelease script, results are
  consistent with source dist, except for minor expected diffs in
  CHANGELOG.txt, build-outputs.mk and generated docs
  (whitespace and attribute ordering)
- Warnings during "make":

src/ssl.c: In function 'ssl_rand_make':
src/ssl.c:469: warning: value computed is not used

src/file.c: In function 'Java_org_apache_tomcat_jni_File_writev':
src/file.c:384: warning: pointer targets in assignment differ in signedness
src/file.c:390: warning: pointer targets in passing argument 3 of
'(*e)->ReleaseByteArrayElements' differ in signedness
src/file.c: In function 'Java_org_apache_tomcat_jni_File_writevFull':
src/file.c:418: warning: pointer targets in assignment differ in signedness
src/file.c:428: warning: pointer targets in passing argument 3 of
'(*e)->ReleaseByteArrayElements' differ in signedness

src/network.c: In function 'Java_org_apache_tomcat_jni_Socket_sendv':
src/network.c:668: warning: pointer targets in assignment differ in
signedness
src/network.c:674: warning: pointer targets in passing argument 3 of
'(*e)->ReleaseByteArrayElements' differ in signedness
src/network.c: In function 'Java_org_apache_tomcat_jni_Socket_sendfile':
src/network.c:1220: warning: pointer targets in assignment differ in
signedness
src/network.c:1225: warning: pointer targets in assignment differ in
signedness
src/network.c:1243: warning: pointer targets in passing argument 3 of
'(*e)->ReleaseByteArrayElements' differ in signedness
src/network.c:1247: warning: pointer targets in passing argument 3 of
'(*e)->ReleaseByteArrayElements' differ in signedness

The JNI functions take a jbyte*, which is a signed char* on my Solaris
system. Whereas the iovec iov_base is a caddr_t, which is a char*.

+ make succeds and builds lib
+ all unit tests contained in TC 7 head run successful with
  APR connector and this version of tcative

Concerning the Java classes in the source distribution:

- it is unclear to me, why they are still distributed.
  Aren't the official sources in trunk/java/org/apache/tomcat/jni?
  Note that they are not identical and the tcnative version of the
  classes is not maintained any more. So we should no longer distribute
  them. Either remove from the distribution, or distribute the TC 7
  ones. If we remove them, what about the test and examples classes?
  I think they have no other home.
- ant part of build:
  - build.xml and build.properties contain version number 1.1.17
  - No mentioning of running "ant download" before tests
  - ant test fails in lie 85 of SocketServerTestSuite.java, because
on my system the checking for precisely 2 milliseconds won't work.
The call returns after 11 millis not afte

svn commit: r1152640 - /tomcat/native/trunk/native/build/lineends.pl

2011-07-31 Thread rjung
Author: rjung
Date: Sun Jul 31 21:25:14 2011
New Revision: 1152640

URL: http://svn.apache.org/viewvc?rev=1152640&view=rev
Log:
Set svn:executable for perl script.

Modified:
tomcat/native/trunk/native/build/lineends.pl   (props changed)

Propchange: tomcat/native/trunk/native/build/lineends.pl
--
svn:executable = *



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1152641 - /tomcat/native/branches/1.1.x/native/build/lineends.pl

2011-07-31 Thread rjung
Author: rjung
Date: Sun Jul 31 21:25:25 2011
New Revision: 1152641

URL: http://svn.apache.org/viewvc?rev=1152641&view=rev
Log:
Set svn:executable for perl script.

Modified:
tomcat/native/branches/1.1.x/native/build/lineends.pl   (props changed)

Propchange: tomcat/native/branches/1.1.x/native/build/lineends.pl
--
svn:executable = *



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1152648 - /tomcat/native/trunk/native/BUILDING

2011-07-31 Thread rjung
Author: rjung
Date: Sun Jul 31 21:32:22 2011
New Revision: 1152648

URL: http://svn.apache.org/viewvc?rev=1152648&view=rev
Log:
Fix name of run-echo ant task in "BUILDING".

Modified:
tomcat/native/trunk/native/BUILDING

Modified: tomcat/native/trunk/native/BUILDING
URL: 
http://svn.apache.org/viewvc/tomcat/native/trunk/native/BUILDING?rev=1152648&r1=1152647&r2=1152648&view=diff
==
--- tomcat/native/trunk/native/BUILDING (original)
+++ tomcat/native/trunk/native/BUILDING Sun Jul 31 21:32:22 2011
@@ -30,7 +30,7 @@
   cd ..
   ant jar
   Run one of the example (the echo one):
-  ant echo-example
+  ant run-echo
  
   Using it in Tomcat:
   1 - In  use of conf/server.xml:



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1152649 - /tomcat/native/branches/1.1.x/native/BUILDING

2011-07-31 Thread rjung
Author: rjung
Date: Sun Jul 31 21:32:33 2011
New Revision: 1152649

URL: http://svn.apache.org/viewvc?rev=1152649&view=rev
Log:
Fix name of run-echo ant task in "BUILDING".

Modified:
tomcat/native/branches/1.1.x/native/BUILDING

Modified: tomcat/native/branches/1.1.x/native/BUILDING
URL: 
http://svn.apache.org/viewvc/tomcat/native/branches/1.1.x/native/BUILDING?rev=1152649&r1=1152648&r2=1152649&view=diff
==
--- tomcat/native/branches/1.1.x/native/BUILDING (original)
+++ tomcat/native/branches/1.1.x/native/BUILDING Sun Jul 31 21:32:33 2011
@@ -30,7 +30,7 @@
   cd ..
   ant jar
   Run one of the example (the echo one):
-  ant echo-example
+  ant run-echo
  
   Using it in Tomcat:
   1 - In  use of conf/server.xml:



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Tomcat Wiki] Update of "HowTo" by KonstantinKolinko

2011-07-31 Thread Apache Wiki
Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change 
notification.

The "HowTo" page has been changed by KonstantinKolinko:
http://wiki.apache.org/tomcat/HowTo?action=diff&rev1=109&rev2=110

Comment:
Tweaks to "How do I contribute to Tomcat's documentation" answer

  However, ''do not'' add questions without answers to this page. If you have a 
question about how to do something in Tomcat which has not been addressed yet, 
ask the [[http://tomcat.apache.org/lists.html#tomcat-users|tomcat-user list]]. 
Once you've figured out how to fix your problem, come back and update the Wiki 
to allow the rest of us to benefit from what you've learned!
  
  == How do I contribute to Tomcat's documentation? ==
- - Download the source bundle or grab the source XML file from 
[[http://tomcat.apache.org/svn.html|Subversion repository]].  The docs are in 
the webapps/docs subdirectory.  They are in XML format and get processed into 
the HTML documentation as part of the Tomcat release.
  
+ Download the source bundle or grab the source XML file from 
[[http://tomcat.apache.org/svn.html|Subversion repository]]. If you are not 
familiar with Subversion, see http://www.apache.org/dev/contributors.html.
+ 
+ The docs are in the webapps/docs subdirectory.  They are in XML format and 
get processed into the HTML documentation as part of the Tomcat release.
+ 
- - Edit the documentation XML file(s) as you wish.  The xdocs format is 
self-explanatory: use normal HTML markup, and add  or  
tags as you see fit.  Look at the existing docs as examples.  Make sure you use 
valid XML markup.
+ Edit the documentation XML file(s) as you wish.  The xdocs format is 
self-explanatory: use normal HTML markup, and add {{{}}} or 
{{{}}} tags as you see fit.  Look at the existing docs as examples. 
 Make sure you use valid XML markup.
  
- - Open a Bugzilla enhancement item with the explanation of your enhancements, 
and attach a {{{svn diff}}} or {{{diff -u}}} format of your patch.  We will 
evaluate and commit your patch as needed.  Note that the Tomcat web site is 
updated with every release, so that documentation changes will not be visible 
until next Tomcat release.
- 
- - If you're interested in previewing your changes, you will need to follow 
the directions for building Tomcat yourself.  The docs will be generated in the 
webapps/docs directory just like with any normal Tomcat distributions.
+ If you're interested in previewing your changes, you will need to follow the 
directions for building Tomcat yourself.  The docs will be generated in the 
webapps/docs directory just like with any normal Tomcat distributions.
  
- - Documentation for current (unreleased) versions of Tomcat 6 and Tomcat 7 is 
published by ASF Buildbot. See links on the 
[[http://tomcat.apache.org/ci.html|buildbot]] page on Apache Tomcat web site.
+ Open a Bugzilla enhancement item with the explanation of your enhancements, 
and attach a {{{svn diff}}} or {{{diff -u}}} format of your patch.  We will 
evaluate and commit your patch as needed.
  
- - If you're not familiar with how to grab files from Subversion, see 
http://www.apache.org/dev/contributors.html.
+ Note, that the Tomcat web site is updated with every release, so that 
documentation changes will not be visible until next Tomcat release. It is 
possible to view documentation for unreleased versions of Tomcat 7 and Tomcat 
6, that is published by ASF Buildbot. See links on the 
[[http://tomcat.apache.org/ci.html|buildbot]] page on Apache Tomcat web site.
  
  
  = Installation =

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Tomcat Wiki] Update of "HowTo" by KonstantinKolinko

2011-07-31 Thread Apache Wiki
Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change 
notification.

The "HowTo" page has been changed by KonstantinKolinko:
http://wiki.apache.org/tomcat/HowTo?action=diff&rev1=110&rev2=111

Comment:
Add horizontal bars between sections

  
  Note, that the Tomcat web site is updated with every release, so that 
documentation changes will not be visible until next Tomcat release. It is 
possible to view documentation for unreleased versions of Tomcat 7 and Tomcat 
6, that is published by ASF Buildbot. See links on the 
[[http://tomcat.apache.org/ci.html|buildbot]] page on Apache Tomcat web site.
  
- 
+ 
  = Installation =
  
  == How do I set up and run Tomcat on Macintosh OS X? ==
@@ -101, +101 @@

  }}}
  
  
- 
+ 
  = Configuration =
  
  == How do I set up multiple sites sharing the same war application/war file? 
==
@@ -333, +333 @@

  See TomcatDevelopmentVirtualHosts
  
  
- 
+ 
  = Programming =
  
  == How do call tomcat ant tasks to deploy webapps? ==
@@ -622, +622 @@

  == How do I use DataSourceRealms for authentication and authorization? ==
  See TomcatDataSourceRealms
  
- 
+ 
  = Troubleshooting =
  
  == Tomcat crashed! What do I do now? ==

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 51581] APR wrapper compilation error

2011-07-31 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51581

--- Comment #2 from zhangyu1...@yahoo.com 2011-08-01 04:05:37 UTC ---
solution: compile openssl with shared option.

all problem solved.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org