Author: markt
Date: Sun Jul 31 17:39:25 2011
New Revision: 1152601

URL: http://svn.apache.org/viewvc?rev=1152601&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51588
Make it easier to extend the AccessLogValve to add support for custom elements.

Modified:
    tomcat/trunk/java/org/apache/catalina/valves/AccessLogValve.java
    tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/catalina/valves/AccessLogValve.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/AccessLogValve.java?rev=1152601&r1=1152600&r2=1152601&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/valves/AccessLogValve.java (original)
+++ tomcat/trunk/java/org/apache/catalina/valves/AccessLogValve.java Sun Jul 31 
17:39:25 2011
@@ -1912,7 +1912,7 @@ public class AccessLogValve extends Valv
     /**
      * create an AccessLogElement implementation which needs header string
      */
-    private AccessLogElement createAccessLogElement(String header, char 
pattern) {
+    protected AccessLogElement createAccessLogElement(String header, char 
pattern) {
         switch (pattern) {
         case 'i':
             return new HeaderElement(header);
@@ -1934,7 +1934,7 @@ public class AccessLogValve extends Valv
     /**
      * create an AccessLogElement implementation
      */
-    private AccessLogElement createAccessLogElement(char pattern) {
+    protected AccessLogElement createAccessLogElement(char pattern) {
         switch (pattern) {
         case 'a':
             return new RemoteAddrElement();

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1152601&r1=1152600&r2=1152601&view=diff
==============================================================================
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Sun Jul 31 17:39:25 2011
@@ -105,6 +105,10 @@
         recoverable (or might be recoverable) when loading classes during
         HandlesTypes processing. (markt)
       </fix>
+      <fix>
+        <bug>51588</bug>: Make it easier to extend the AccessLogValve to add
+        support for custom elements. (markt)
+      </fix>
     </changelog>
   </subsection>
   <subsection name="Coyote">



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to