unsuscribe
unsuscribe -- Sháníte letenky na pracovní cestu, dovolenou či jen na výlet? Na http://letenky.volny.cz si zajisté vyberete. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1148216 - /tomcat/trunk/java/org/apache/coyote/ajp/AjpAprProcessor.java
Author: jfclere
Date: Tue Jul 19 08:06:46 2011
New Revision: 1148216
URL: http://svn.apache.org/viewvc?rev=1148216&view=rev
Log:
Fix for PR49595
Modified:
tomcat/trunk/java/org/apache/coyote/ajp/AjpAprProcessor.java
Modified: tomcat/trunk/java/org/apache/coyote/ajp/AjpAprProcessor.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/ajp/AjpAprProcessor.java?rev=1148216&r1=1148215&r2=1148216&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/ajp/AjpAprProcessor.java (original)
+++ tomcat/trunk/java/org/apache/coyote/ajp/AjpAprProcessor.java Tue Jul 19
08:06:46 2011
@@ -507,13 +507,13 @@ public class AjpAprProcessor extends Abs
long socketRef = socket.getSocket().longValue();
if (outputBuffer.position() > 0) {
-if (Socket.sendbb(socketRef, 0, outputBuffer.position()) < 0) {
+if ((socketRef != 0) && Socket.sendbb(socketRef, 0,
outputBuffer.position()) < 0) {
throw new IOException(sm.getString("ajpprocessor.failedsend"));
}
outputBuffer.clear();
}
// Send explicit flush message
-if (explicit && !finished) {
+if (explicit && !finished && (socketRef != 0)) {
if (Socket.send(socketRef, flushMessageArray, 0,
flushMessageArray.length) < 0) {
throw new
IOException(sm.getString("ajpprocessor.failedflush"));
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1148219 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: jfclere Date: Tue Jul 19 08:09:46 2011 New Revision: 1148219 URL: http://svn.apache.org/viewvc?rev=1148219&view=rev Log: Proposed fix for 49595. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1148219&r1=1148218&r2=1148219&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Jul 19 08:09:46 2011 @@ -232,3 +232,8 @@ PATCHES PROPOSED TO BACKPORT: https://issues.apache.org/bugzilla/attachment.cgi?id=27280 (JMX) +1: kkolinko, markt, kfujino -1: + +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49595 + http://svn.apache.org/viewvc?rev=1148216&view=rev + +1: jfclere + -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49595] Tomcat crashes in tcnative-1.dll frequently
https://issues.apache.org/bugzilla/show_bug.cgi?id=49595 jfclere changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #5 from jfclere 2011-07-19 08:15:40 UTC --- Fix by 1148216, Back port proposed. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1148242 - /tomcat/trunk/webapps/docs/changelog.xml
Author: markt Date: Tue Jul 19 09:03:41 2011 New Revision: 1148242 URL: http://svn.apache.org/viewvc?rev=1148242&view=rev Log: Add section title Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1148242&r1=1148241&r2=1148242&view=diff == --- tomcat/trunk/webapps/docs/changelog.xml (original) +++ tomcat/trunk/webapps/docs/changelog.xml Tue Jul 19 09:03:41 2011 @@ -76,7 +76,7 @@ - + 51503: Add additional validation to Windows installer that - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1148245 - in /tomcat/trunk/test/org/apache/tomcat/util/scan: ./ TestJarScanner.java
Author: rjung
Date: Tue Jul 19 09:14:09 2011
New Revision: 1148245
URL: http://svn.apache.org/viewvc?rev=1148245&view=rev
Log:
Add test cases for syntax checking of jarsToSkip.
Added:
tomcat/trunk/test/org/apache/tomcat/util/scan/
tomcat/trunk/test/org/apache/tomcat/util/scan/TestJarScanner.java (with
props)
Added: tomcat/trunk/test/org/apache/tomcat/util/scan/TestJarScanner.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/tomcat/util/scan/TestJarScanner.java?rev=1148245&view=auto
==
--- tomcat/trunk/test/org/apache/tomcat/util/scan/TestJarScanner.java (added)
+++ tomcat/trunk/test/org/apache/tomcat/util/scan/TestJarScanner.java Tue Jul
19 09:14:09 2011
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.tomcat.util.scan;
+
+import java.util.StringTokenizer;
+
+import org.apache.catalina.startup.TomcatBaseTest;
+
+public class TestJarScanner extends TomcatBaseTest {
+
+public void testJarsToSkipFormat() {
+
+String jarList = System.getProperty(Constants.SKIP_JARS_PROPERTY);
+assertNotNull("Jar skip list is null", jarList);
+assertFalse("Jar skip list is empty", jarList.isEmpty());
+StringTokenizer tokenizer = new StringTokenizer(jarList, ",");
+String token;
+while (tokenizer.hasMoreElements()) {
+token = tokenizer.nextToken();
+assertTrue("token '" + token + "' does not end with \".jar\"",
+ token.endsWith(".jar"));
+assertEquals("token '" + token + "' contains sub string \".jar\"" +
+ " or separator \",\" is missing",
+ token.length() - ".jar".length(),
+ token.indexOf(".jar"));
+}
+}
+}
Propchange: tomcat/trunk/test/org/apache/tomcat/util/scan/TestJarScanner.java
--
svn:eol-style = native
Propchange: tomcat/trunk/test/org/apache/tomcat/util/scan/TestJarScanner.java
--
svn:keywords = Author Date Id Revision
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1146623 - in /tomcat/trunk: conf/catalina.properties webapps/docs/changelog.xml
On 14.07.2011 12:08, Konstantin Kolinko wrote: > 2011/7/14 : >> Author: kkolinko >> Date: Thu Jul 14 09:58:31 2011 >> New Revision: 1146623 >> >> URL: http://svn.apache.org/viewvc?rev=1146623&view=rev >> Log: >> Corrected typo in the value of tomcat.util.scan.DefaultJarScanner.jarsToSkip >> property >> >> Modified: >>tomcat/trunk/conf/catalina.properties >>tomcat/trunk/webapps/docs/changelog.xml >> > > >> tomcat-api.jar,tomcat-util.jar,tomcat-coyote.jar,tomcat-dbcp.jar,\ >> >> tomcat-i18n-en.jar,tomcat-i18n-es.jar,tomcat-i18n-fr.jar,tomcat-i18n-ja.jar,\ >> tomcat-juli-adapters.jar,catalina-jmx-remote.jar,catalina-ws.jar,\ >> -tomcat-jdbc.jar\ >> +tomcat-jdbc.jar,\ >> commons-beanutils*.jar,commons-codec*.jar,commons-collections*.jar,\ >> commons-dbcp*.jar,commons-digester*.jar,commons-fileupload*.jar,\ >> >> commons-httpclient*.jar,commons-io*.jar,commons-lang*.jar,commons-logging*.jar,\ > > It would be nice to add a Test to our testsuite to test that any > ".jar" in this property value is followed by comma: > either by (optional spaces and comma) or by (end of line). I added some test cases in r1148245. They check, whether all tokens (splitted along comma) end with ".jar" and whether there is another ".jar" inside the token. I don't currently tolerate trailing or leading spaces, because I'm not sure, what the current impl does with them. Will check later, but not critical now, since our default "jarsTiSkip" value doesn't contain such whitespace. Regards, Rainer - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1148249 - /tomcat/trunk/webapps/docs/changelog.xml
Author: markt Date: Tue Jul 19 09:22:22 2011 New Revision: 1148249 URL: http://svn.apache.org/viewvc?rev=1148249&view=rev Log: Add release date for 7.0.19 Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1148249&r1=1148248&r2=1148249&view=diff == --- tomcat/trunk/webapps/docs/changelog.xml (original) +++ tomcat/trunk/webapps/docs/changelog.xml Tue Jul 19 09:22:22 2011 @@ -86,7 +86,7 @@ - + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1148252 - in /tomcat/site/trunk: docs/ xdocs/
Author: markt Date: Tue Jul 19 09:30:08 2011 New Revision: 1148252 URL: http://svn.apache.org/viewvc?rev=1148252&view=rev Log: Update for 7.0.19 release Modified: tomcat/site/trunk/docs/doap_Tomcat.rdf tomcat/site/trunk/docs/download-70.html tomcat/site/trunk/docs/index.html tomcat/site/trunk/docs/oldnews.html tomcat/site/trunk/docs/security-7.html tomcat/site/trunk/docs/whichversion.html tomcat/site/trunk/xdocs/doap_Tomcat.rdf tomcat/site/trunk/xdocs/download-70.xml tomcat/site/trunk/xdocs/index.xml tomcat/site/trunk/xdocs/oldnews.xml tomcat/site/trunk/xdocs/security-7.xml tomcat/site/trunk/xdocs/whichversion.xml Modified: tomcat/site/trunk/docs/doap_Tomcat.rdf URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/doap_Tomcat.rdf?rev=1148252&r1=1148251&r2=1148252&view=diff == --- tomcat/site/trunk/docs/doap_Tomcat.rdf (original) +++ tomcat/site/trunk/docs/doap_Tomcat.rdf Tue Jul 19 09:30:08 2011 @@ -55,8 +55,8 @@ Latest Stable 7.0.x Release -2011-06-17 -7.0.16 +2011-07-19 +7.0.19 Modified: tomcat/site/trunk/docs/download-70.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/download-70.html?rev=1148252&r1=1148251&r2=1148252&view=diff == --- tomcat/site/trunk/docs/download-70.html (original) +++ tomcat/site/trunk/docs/download-70.html Tue Jul 19 09:30:08 2011 @@ -241,8 +241,8 @@ http://www.apache.org/dist/tomcat/tomcat-7/KEYS";>KEYS | -7.0.16 | -Browse | +7.0.19 | +Browse | http://archive.apache.org/dist/tomcat/tomcat-7";>Archives @@ -342,8 +342,8 @@ - -7.0.16 + +7.0.19 @@ -353,8 +353,8 @@ - Please see the - README + Please see the + README file for packaging information. It explains what every distribution contains. @@ -378,95 +378,95 @@ Core: -zip -(http://www.apache.org/dist/tomcat/tomcat-7/v7.0.16/bin/apache-tomcat-7.0.16.zip.asc";>pgp, -http://www.apache.org/dist/tomcat/tomcat-7/v7.0.16/bin/apache-tomcat-7.0.16.zip.md5";>md5) +zip +(http://www.apache.org/dist/tomcat/tomcat-7/v7.0.19/bin/apache-tomcat-7.0.19.zip.asc";>pgp, +http://www.apache.org/dist/tomcat/tomcat-7/v7.0.19/bin/apache-tomcat-7.0.19.zip.md5";>md5) -tar.gz -(http://www.apache.org/dist/tomcat/tomcat-7/v7.0.16/bin/apache-tomcat-7.0.16.tar.gz.asc";>pgp, -http://www.apache.org/dist/tomcat/tomcat-7/v7.0.16/bin/apache-tomcat-7.0.16.tar.gz.md5";>md5) +tar.gz +(http://www.apache.org/dist/tomcat/tomcat-7/v7.0.19/bin/apache-tomcat-7.0.19.tar.gz.asc";>pgp, +http://www.apache.org/dist/tomcat/tomcat-7/v7.0.19/bin/apache-tomcat-7.0.19.tar.gz.md5";>md5) -32-bit Windows zip -(http://www.apache.org/dist/tomcat/tomcat-7/v7.0.16/bin/apache-tomcat-7.0.16-windows-x86.zip.asc";>pgp, -http://www.apache.org/dist/tomcat/tomcat-7/v7.0.16/bin/apache-tomcat-7.0.16-windows-x86.zip.md5";>md5) +32-bit Windows zip +(http://www.apache.org/dist/tomcat/tomcat-7/v7.0.19/bin/apache-tomcat-7.0.19-windows-x86.zip.asc";>pgp, +http://www.apache.org/dist/tomcat/tomcat-7/v7.0.19/bin/apache-tomcat-7.0.19-windows-x86.zip.md5";>md5) -64-bit Windows zip -(http://www.apache.org/dist/tomcat/tomcat-7/v7.0.16/bin/apache-tomcat-7.0.16-windows-x64.zip.asc";>pgp, -http://www.apache.org/dist/tomcat/tomcat-7/v7.0.16/bin/apache-tomcat-7.0.16-windows-x64.zip.md5";>md5) +64-bit Windows zip +(http://www.apache.org/dist/tomcat/tomcat-7/v7.0.19/bin/apache-tomcat-7.0.19-windows-x64.zip.asc";>pgp, +http://www.apache.org/dist/tomcat/tomcat-7/v7.0.19/bin/apache-tomcat-7.0.19-windows-x64.zip.md5";>md5) -64-bit Itanium Windows zip -(http://www.apache.org/dist/tomcat/tomcat-7/v7.0.16/bin/apache-tomcat-7.0.16-windows-i64.zip.asc";>pgp, -http://www.apache.org/dist/tomcat/tomcat-7/v7.0.16/bin/apache-tomcat-7.0.16-windows-i64.zip.md5";>md5) +64-bit Itanium Windows zip +(http://www.apache.org/dist/tomcat/tomcat-7/v7.0.19/bin/apache-tomcat-7.0.19-windows-i64.zip.asc";>pgp, +http://www.apache.org/dist/tomcat/tomcat-7/v7.0.19/bin/apache-tomcat-7.0.19-windows-i64.zip.md5";>md5) -32-bit/64-bit Windows Service Installer -(http://www.apache.org/dist/tomcat/tomcat-7/v7.0.16/bin/apache-tomcat-7.0.16.exe.asc";>pgp, -http://www.apac
svn commit: r1148254 - /tomcat/trunk/java/org/apache/coyote/http11/InternalAprInputBuffer.java
Author: jfclere
Date: Tue Jul 19 09:36:08 2011
New Revision: 1148254
URL: http://svn.apache.org/viewvc?rev=1148254&view=rev
Log:
Fix for PR50394
Modified:
tomcat/trunk/java/org/apache/coyote/http11/InternalAprInputBuffer.java
Modified: tomcat/trunk/java/org/apache/coyote/http11/InternalAprInputBuffer.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/InternalAprInputBuffer.java?rev=1148254&r1=1148253&r2=1148254&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http11/InternalAprInputBuffer.java
(original)
+++ tomcat/trunk/java/org/apache/coyote/http11/InternalAprInputBuffer.java Tue
Jul 19 09:36:08 2011
@@ -587,6 +587,8 @@ public class InternalAprInputBuffer exte
bbuf.get(buf, pos, nRead);
lastValid = pos + nRead;
} else {
+if ((-nRead) == Status.APR_EOF)
+return false;
if ((-nRead) == Status.ETIMEDOUT || (-nRead) == Status.TIMEUP)
{
throw new
SocketTimeoutException(sm.getString("iib.failedread"));
} else {
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1148255 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: jfclere Date: Tue Jul 19 09:38:13 2011 New Revision: 1148255 URL: http://svn.apache.org/viewvc?rev=1148255&view=rev Log: Fix for PR50394 Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1148255&r1=1148254&r2=1148255&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Jul 19 09:38:13 2011 @@ -237,3 +237,7 @@ PATCHES PROPOSED TO BACKPORT: http://svn.apache.org/viewvc?rev=1148216&view=rev +1: jfclere -1: + +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50394 + http://svn.apache.org/viewvc?rev=1148254&view=rev + +1: jfclere - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50394] InternalAprInputBuffer.fill() doesn't deal correctly with EOF
https://issues.apache.org/bugzilla/show_bug.cgi?id=50394 jfclere changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||FIXED --- Comment #3 from jfclere 2011-07-19 09:39:49 UTC --- Fix by 1148254 backport proposed. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51521] java.net.SocketException: Broken pipe
https://issues.apache.org/bugzilla/show_bug.cgi?id=51521 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Comment #1 from Mark Thomas 2011-07-19 09:41:23 UTC --- Bugzilla is not a support forum. Please use the users mailing list. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51056] Disable / drop support for SSLv2
https://issues.apache.org/bugzilla/show_bug.cgi?id=51056 jfclere changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #2 from jfclere 2011-07-19 10:12:41 UTC --- Could you attached a diff -u. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51056] Disable / drop support for SSLv2
https://issues.apache.org/bugzilla/show_bug.cgi?id=51056 --- Comment #3 from Rainer Jung 2011-07-19 11:09:30 UTC --- I'm not so sure, that the library should drop support, but I would be +1 to support only SSLv3 and TLSv1 by default in Tomcat if not explicitely configured for something else (e.g. with +SSLv2). The change will be an incompatible though, but probably OK because of security concerns. Regards, Rainer -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[ANN] Apache Tomcat 7.0.19 released
The Apache Tomcat team announces the immediate availability of Apache Tomcat 7.0.19 Apache Tomcat 7.0.19 includes security fixes, bug fixes and the following new features compared to version 7.0.16: - JSP recompilation is now triggered by any change (backwards as well as forwards) in the last modified time of the JSP or any of its dependencies - Support for installing multiple instances with the Windows Installer - Include jdbc-pool (an alternative database connection pool) Please refer to the change log for the complete list of changes: http://tomcat.apache.org/tomcat-7.0-doc/changelog.html The following known issues in 7.0.19 are noteworthy: - The AJP NIO connector does not use persistent connections. To workaround this, use a large value for connectionTimeout - There is a typo in the list of JARs to skip in catalina.properties Apply http://s.apache.org/catalina.properties-r1146623 to fix it Note that this version has 4 zip binaries: a generic one and three bundled with Tomcat native binaries for Windows operating systems running on different CPU architectures. Downloads: http://tomcat.apache.org/download-70.cgi Migration guide from Apache Tomcat 5.5.x and 6.0.x: http://tomcat.apache.org/migration.html Thank you, -- The Apache Tomcat Team - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51526] Process web application context config with embedded Tomcat.addWebApp(...)
https://issues.apache.org/bugzilla/show_bug.cgi?id=51526 Mark Thomas changed: What|Removed |Added Severity|normal |enhancement --- Comment #1 from Mark Thomas 2011-07-19 11:27:26 UTC --- Enhancement requests with patches tend to get resolved faster than those without. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1148277 - in /tomcat/trunk: java/org/apache/catalina/startup/WebRuleSet.java webapps/docs/changelog.xml
Author: markt Date: Tue Jul 19 11:41:08 2011 New Revision: 1148277 URL: http://svn.apache.org/viewvc?rev=1148277&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51518 Correct error in web.xml parsing rules for the tag when using absolute ordering. Modified: tomcat/trunk/java/org/apache/catalina/startup/WebRuleSet.java tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/java/org/apache/catalina/startup/WebRuleSet.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/startup/WebRuleSet.java?rev=1148277&r1=1148276&r2=1148277&view=diff == --- tomcat/trunk/java/org/apache/catalina/startup/WebRuleSet.java (original) +++ tomcat/trunk/java/org/apache/catalina/startup/WebRuleSet.java Tue Jul 19 11:41:08 2011 @@ -180,7 +180,7 @@ public class WebRuleSet extends RuleSetB new RelativeOrderingRule()); digester.addCallMethod(fullPrefix + "/absolute-ordering/name", "addAbsoluteOrdering", 0); -digester.addCallMethod(fullPrefix + "/absolute-ordering/name/others", +digester.addCallMethod(fullPrefix + "/absolute-ordering/others", "addAbsoluteOrderingOthers"); } Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1148277&r1=1148276&r2=1148277&view=diff == --- tomcat/trunk/webapps/docs/changelog.xml (original) +++ tomcat/trunk/webapps/docs/changelog.xml Tue Jul 19 11:41:08 2011 @@ -62,6 +62,10 @@ caused tomcat-jdbc.jar and commons-beanutils*.jar to be not ignored when scanning jars for tag libraries. (kkolinko) + +51518: Correct error in web.xml parsing rules for the +tag when using absolute ordering. (markt) + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51518] "/absolute-ordering/name/others" should not include "name" element
https://issues.apache.org/bugzilla/show_bug.cgi?id=51518 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #1 from Mark Thomas 2011-07-19 11:41:42 UTC --- Fixed in 7.0.x and will be included in 7.0.20 onwards. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1148288 - /tomcat/trunk/webapps/docs/changelog.xml
Author: jfclere Date: Tue Jul 19 12:11:18 2011 New Revision: 1148288 URL: http://svn.apache.org/viewvc?rev=1148288&view=rev Log: Add changelog for 1148254 and 1148216 Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1148288&r1=1148287&r2=1148288&view=diff == --- tomcat/trunk/webapps/docs/changelog.xml (original) +++ tomcat/trunk/webapps/docs/changelog.xml Tue Jul 19 12:11:18 2011 @@ -71,6 +71,14 @@ +50394: Return -1 instead throwing exception when +EOF (jfclere) + + +49595: Prevent JVM crash with native when flushing +a closed socket (jfclere) + + Correctly handle a connectionTimeout value of -1 (no timeout) for the HTTP NIO and AJP NIO connectors. (markt) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51523] ClassNotFoundException when loading TLD listeners
https://issues.apache.org/bugzilla/show_bug.cgi?id=51523 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WORKSFORME --- Comment #1 from Mark Thomas 2011-07-19 13:47:15 UTC --- This works for me with a simple test case and I'd be surprised if the TCKs didn't cover this as well (although I haven't checked). This is most likely a configuration error, possibly an issue with the TLD and/.or web.xml since Tomcat 7 is stricter about validating these. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1148321 - /tomcat/trunk/webapps/docs/changelog.xml
Author: markt Date: Tue Jul 19 13:51:42 2011 New Revision: 1148321 URL: http://svn.apache.org/viewvc?rev=1148321&view=rev Log: Add info on which connectors these fixes apply to. Correct order. Add periods to the end of the sentences. Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1148321&r1=1148320&r2=1148321&view=diff == --- tomcat/trunk/webapps/docs/changelog.xml (original) +++ tomcat/trunk/webapps/docs/changelog.xml Tue Jul 19 13:51:42 2011 @@ -71,12 +71,13 @@ -50394: Return -1 instead throwing exception when -EOF (jfclere) +49595: Prevent JVM crash with the AJP APR connector when +flushing a closed socket. (jfclere) -49595: Prevent JVM crash with native when flushing -a closed socket (jfclere) +50394: Return -1 instead throwing an exception when +encountering an EOF while processing an input stream with the HTTP APR +connector. (jfclere) Correctly handle a connectionTimeout value of -1 (no timeout) for the - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51523] ClassNotFoundException when loading TLD listeners
https://issues.apache.org/bugzilla/show_bug.cgi?id=51523 Alonso changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|WORKSFORME | --- Comment #2 from Alonso 2011-07-19 13:54:41 UTC --- I should be more specific in my previous post. As you can see at logfile the exception message is: java.lang.ClassNotFoundException: net.sf.jasperreports.jsf.config.ConfigurationStartupListener and the listener definition in TLD is as follows: net.sf.jasperreports.jsf.config.ConfigurationStartupListener So, Tomcat 7 is not trimming blanks at the string which has been read from the TLD file. I think it should be considered as a bug no matter how stricter Tomcat 7 had become validating the TLD file, since TLD is still valid with or without those blanks. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51523] ClassNotFoundException when loading TLD listeners
https://issues.apache.org/bugzilla/show_bug.cgi?id=51523 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||WORKSFORME --- Comment #3 from Mark Thomas 2011-07-19 14:12:24 UTC --- This works for me with the blanks present as well. This still looks like a configuration error and the users list is the place to get help. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51523] ClassNotFoundException when loading TLD listeners
https://issues.apache.org/bugzilla/show_bug.cgi?id=51523 Alonso changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|WORKSFORME | --- Comment #4 from Alonso 2011-07-19 14:29:12 UTC --- Sorry for being so pedant, but I'm not asking for help, I'm reporting a bug because if I modify the TLD inside the jar file (removing blanks), repack it and deploy the same webapp with the modified jar, then the application is started up without problems. I didn't posted previously whithout check that first. Please, review the code at the component which loads TLD files since I'm pretty sure that it is not trimming blanks a that string. I'm using Tomcat 7.0.16 and this library: https://sourceforge.net/projects/jasperreportjsf/ Kind regards. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51523] ClassNotFoundException when loading TLD listeners
https://issues.apache.org/bugzilla/show_bug.cgi?id=51523 --- Comment #5 from Mark Thomas 2011-07-19 15:49:55 UTC --- Hmm. I still can't reproduce this even with that library. Trying with 7.0.16 rather than trunk... That reproduced it. Very odd. I don't recall any changes since 7.0.16 that fixed this. Trying with 7.0.19. That also reproduces it... Even stranger. The changes between 7.0.19 and trunk are minimal and seem unrelated to this. Still digging... -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51400] Use of "new String(byte[] b, String enc)" hits Sun JVM bottleneck
https://issues.apache.org/bugzilla/show_bug.cgi?id=51400 --- Comment #28 from Ismael Juma 2011-07-19 15:56:24 UTC --- Note that there have been changes in this area in Java 7: "Using Charset as the parameter does not bring you any performance benefit (in fact it's slower and bloat) in most use scenarios, use it with caution." http://blogs.oracle.com/xuemingshen/entry/faster_new_string_bytes_cs The blog above talks about single-byte encodings, but there has been a follow-up commit for UTF-8 earlier this year. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51523] ClassNotFoundException when loading TLD listeners
https://issues.apache.org/bugzilla/show_bug.cgi?id=51523 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||INVALID --- Comment #6 from Mark Thomas 2011-07-19 17:00:09 UTC --- Tracked it down. The TLD provided by the JAR you are using is invalid. If you follow the definitions in the XSDs you'll eventually see that leading and trailing whitespace should not be present. Since this is an invalid TLD Tomcat will not be adding a work-around for this. Tomcat very rarely adds workarounds for bugs in third-party applications/libraries. The reason I wasn't seeing it is that I always run Tomcat with -Dorg.apache.catalina.STRICT_SERVLET_COMPLIANCE="true" Amongst other things, this configures the XML parsers to use the slower but specification compliant settings of validation=true and namespaceAware=true. With these settings the parsers remove leading and trailing whitespace. One work-around that is available to you is to enable STRICT_SERVLET_COMPLIANCE or configure appropriate XML validation for the specific context. Help with either of those options is available on the users mailing list. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1148471 - in /tomcat/trunk: java/org/apache/catalina/filters/CsrfPreventionFilter.java test/org/apache/catalina/filters/TestCsrfPreventionFilter2.java webapps/docs/changelog.xml
Author: markt
Date: Tue Jul 19 18:20:23 2011
New Revision: 1148471
URL: http://svn.apache.org/viewvc?rev=1148471&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51509
Fix potential concurrency issue in CSRF prevention filter that may lead to some
requests failing that should not.
Added:
tomcat/trunk/test/org/apache/catalina/filters/TestCsrfPreventionFilter2.java
(with props)
Modified:
tomcat/trunk/java/org/apache/catalina/filters/CsrfPreventionFilter.java
tomcat/trunk/webapps/docs/changelog.xml
Modified:
tomcat/trunk/java/org/apache/catalina/filters/CsrfPreventionFilter.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/filters/CsrfPreventionFilter.java?rev=1148471&r1=1148470&r2=1148471&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/filters/CsrfPreventionFilter.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/filters/CsrfPreventionFilter.java Tue
Jul 19 18:20:23 2011
@@ -310,11 +310,15 @@ public class CsrfPreventionFilter extend
}
public void add(T key) {
-cache.put(key, null);
+synchronized (cache) {
+cache.put(key, null);
+}
}
-
+
public boolean contains(T key) {
-return cache.containsKey(key);
+synchronized (cache) {
+return cache.containsKey(key);
+}
}
}
}
Added:
tomcat/trunk/test/org/apache/catalina/filters/TestCsrfPreventionFilter2.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/filters/TestCsrfPreventionFilter2.java?rev=1148471&view=auto
==
---
tomcat/trunk/test/org/apache/catalina/filters/TestCsrfPreventionFilter2.java
(added)
+++
tomcat/trunk/test/org/apache/catalina/filters/TestCsrfPreventionFilter2.java
Tue Jul 19 18:20:23 2011
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.catalina.filters;
+
+import junit.framework.TestCase;
+
+import org.apache.catalina.filters.CsrfPreventionFilter.LruCache;
+
+public class TestCsrfPreventionFilter2 extends TestCase {
+
+/**
+ * When this test fails, it tends to enter a long running loop but it will
+ * eventually finish (after ~70s on a 8-core Windows box).
+ */
+public void testLruCacheConcurrency() throws Exception {
+int threadCount = 2;
+long iterationCount = 10L;
+
+assertTrue(threadCount > 1);
+
+LruCache cache = new LruCache(threadCount - 1);
+
+LruTestThread[] threads = new LruTestThread[threadCount];
+for (int i = 0; i < threadCount; i++) {
+threads[i] = new LruTestThread(cache, iterationCount);
+}
+
+for (int i = 0; i < threadCount; i++) {
+threads[i].start();
+}
+
+for (int i = 0; i < threadCount; i++) {
+threads[i].join();
+}
+
+for (int i = 0; i < threadCount; i++) {
+assertTrue(threads[i].getResult());
+}
+
+}
+
+private static class LruTestThread extends Thread {
+private final LruCache cache;
+private long iterationCount = 0;
+private volatile boolean result = false;
+
+public LruTestThread(LruCache cache, long iterationCount) {
+this.cache = cache;
+this.iterationCount = iterationCount;
+}
+
+public boolean getResult() {
+return result;
+}
+
+@Override
+public void run() {
+String test = getName();
+try {
+for (long i = 0; i < iterationCount; i++) {
+cache.add(test + i);
+if (!cache.contains(test + i)) {
+// Expected
+}
+}
+} catch (Exception e) {
+e.printStackTrace();
+return;
+}
+result = true;
+}
+}
+}
Propchange:
tomcat/trunk/test/org/apache/catalina/filters/TestC
DO NOT REPLY [Bug 51509] Csrf Prevention Filter's LruCache is not thread save
https://issues.apache.org/bugzilla/show_bug.cgi?id=51509 Mark Thomas changed: What|Removed |Added Summary|Csrf Prevention Filter`s|Csrf Prevention Filter's |LruCache is not thread save |LruCache is not thread save OS/Version||All --- Comment #1 from Mark Thomas 2011-07-19 18:21:59 UTC --- Fixed in 7.0.x and will be included in 7.0.20 onwards. Proposed for 6.0.x. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1148472 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Tue Jul 19 18:22:39 2011 New Revision: 1148472 URL: http://svn.apache.org/viewvc?rev=1148472&view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1148472&r1=1148471&r2=1148472&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Jul 19 18:22:39 2011 @@ -241,3 +241,10 @@ PATCHES PROPOSED TO BACKPORT: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50394 http://svn.apache.org/viewvc?rev=1148254&view=rev +1: jfclere + +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51509 + Correct concurrency issue in CSRF prevention filter + http://svn.apache.org/viewvc?rev=1148471&view=rev + +1: markt + -1: + \ No newline at end of file - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51531] New: Eclipse .classpath references old ECJ version
https://issues.apache.org/bugzilla/show_bug.cgi?id=51531 Bug #: 51531 Summary: Eclipse .classpath references old ECJ version Product: Tomcat 7 Version: trunk Platform: All OS/Version: All Status: NEW Severity: normal Priority: P2 Component: Integration AssignedTo: dev@tomcat.apache.org ReportedBy: i...@ianbrandt.com Classification: Unclassified The ECJ version referenced by the current Eclipse .classpath resource on trunk is 3.6.2. The reference Ant build uses ECJ 3.7. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51531] Eclipse .classpath references old ECJ version
https://issues.apache.org/bugzilla/show_bug.cgi?id=51531 --- Comment #1 from Ian Brandt 2011-07-19 18:26:26 UTC --- Created attachment 27299 --> https://issues.apache.org/bugzilla/attachment.cgi?id=27299 Patch to correct the Eclipse .classpath ECJ version. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51526] Process web application context config with embedded Tomcat.addWebApp(...)
https://issues.apache.org/bugzilla/show_bug.cgi?id=51526 --- Comment #2 from Ian Brandt 2011-07-19 18:31:25 UTC --- (In reply to comment #1) > Enhancement requests with patches tend to get resolved faster than those > without. Certainly. As I'm just getting acquainted with Tomcat internals I have some questions as to the "right" way to implement this. I'll take them up on the tomcat-dev mailing list. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1148483 - in /tomcat/trunk: res/ide-support/eclipse/eclipse.classpath webapps/docs/changelog.xml
Author: markt Date: Tue Jul 19 18:49:03 2011 New Revision: 1148483 URL: http://svn.apache.org/viewvc?rev=1148483&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51531 Update for ecj 3.7 Modified: tomcat/trunk/res/ide-support/eclipse/eclipse.classpath tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/res/ide-support/eclipse/eclipse.classpath URL: http://svn.apache.org/viewvc/tomcat/trunk/res/ide-support/eclipse/eclipse.classpath?rev=1148483&r1=1148482&r2=1148483&view=diff == --- tomcat/trunk/res/ide-support/eclipse/eclipse.classpath (original) +++ tomcat/trunk/res/ide-support/eclipse/eclipse.classpath Tue Jul 19 18:49:03 2011 @@ -25,6 +25,6 @@ - + Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1148483&r1=1148482&r2=1148483&view=diff == --- tomcat/trunk/webapps/docs/changelog.xml (original) +++ tomcat/trunk/webapps/docs/changelog.xml Tue Jul 19 18:49:03 2011 @@ -100,6 +100,10 @@ ensure that the shutdown port, HTTP port and AJP port are all specified during the install process. (markt) + +51531: Update sample Eclipse classpath file to reflect +updated ECJ jar. Patch provided by Ian Brandt. (markt) + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51531] Eclipse .classpath references old ECJ version
https://issues.apache.org/bugzilla/show_bug.cgi?id=51531 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #2 from Mark Thomas 2011-07-19 18:49:23 UTC --- Thanks for the patch. This has been fixed in trunk and will be included in 7.0.20 onwards. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1148491 - in /tomcat/trunk/webapps/docs: changelog.xml config/systemprops.xml
Author: markt Date: Tue Jul 19 19:19:45 2011 New Revision: 1148491 URL: http://svn.apache.org/viewvc?rev=1148491&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51516 Correct property to change SSO session cookie name Modified: tomcat/trunk/webapps/docs/changelog.xml tomcat/trunk/webapps/docs/config/systemprops.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1148491&r1=1148490&r2=1148491&view=diff == --- tomcat/trunk/webapps/docs/changelog.xml (original) +++ tomcat/trunk/webapps/docs/changelog.xml Tue Jul 19 19:19:45 2011 @@ -93,6 +93,15 @@ + + + +51516: Correct documentation web application to show correct +system property name for changing the name of the SSO session cookie. +(markt) + + + Modified: tomcat/trunk/webapps/docs/config/systemprops.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/config/systemprops.xml?rev=1148491&r1=1148490&r2=1148491&view=diff == --- tomcat/trunk/webapps/docs/config/systemprops.xml (original) +++ tomcat/trunk/webapps/docs/config/systemprops.xml Tue Jul 19 19:19:45 2011 @@ -406,7 +406,8 @@ - + An alternative name for the single sign on session cookie. Defaults to JSESSIONIDSSO. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1148492 - in /tomcat/tc6.0.x/trunk/webapps/docs: changelog.xml config/systemprops.xml
Author: markt Date: Tue Jul 19 19:21:51 2011 New Revision: 1148492 URL: http://svn.apache.org/viewvc?rev=1148492&view=rev Log: CTR: Documentation Correct property to change SSO session cookie name Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml tomcat/tc6.0.x/trunk/webapps/docs/config/systemprops.xml Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml?rev=1148492&r1=1148491&r2=1148492&view=diff == --- tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml (original) +++ tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Tue Jul 19 19:21:51 2011 @@ -280,6 +280,11 @@ 51443: Document the notifySessionListenersOnReplication attribute for the DeltaManager. (markt) + +51516: Correct documentation web application to show correct +system property name for changing the name of the SSO session cookie. +(markt) + Modified: tomcat/tc6.0.x/trunk/webapps/docs/config/systemprops.xml URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/config/systemprops.xml?rev=1148492&r1=1148491&r2=1148492&view=diff == --- tomcat/tc6.0.x/trunk/webapps/docs/config/systemprops.xml (original) +++ tomcat/tc6.0.x/trunk/webapps/docs/config/systemprops.xml Tue Jul 19 19:21:51 2011 @@ -366,7 +366,8 @@ change this. - + An alternative name for the single sign on session cookie. Defaults to JSESSIONIDSSO. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51516] org.apache.catalina.SSO_SESSION_COOKIE_NAME vs org.apache.catalina.authenticator.Constants.SSO_SESSION_COOKIE_NAME
https://issues.apache.org/bugzilla/show_bug.cgi?id=51516 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #1 from Mark Thomas 2011-07-19 19:26:13 UTC --- Thanks for the report. This has been fixed in 7.0.x and 6.0.x and will be included in 7.0.20 and 6.0.33 respectively. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51056] Disable / drop support for SSLv2
https://issues.apache.org/bugzilla/show_bug.cgi?id=51056 --- Comment #4 from drazzib 2011-07-19 20:18:26 UTC --- Hi, @jfclere: Could you explain a little bit more your issue with format of current patch attached to this Bugzilla ? AFAIK, it's in udiff format and I'm able to apply it with a "patch -p1 < drop_sslv2_support.diff". @Rainer Jung: SSLv2 is disabled in IE7, Opera and Firefox since 2006. So one day or another you'll have to drop support for it :) Best regards, -- Damien Raude-Morvan -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51532] New: Performance Issue when retriving JAR files during TLD file parsing.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51532
Bug #: 51532
Summary: Performance Issue when retriving JAR files during TLD
file parsing.
Product: Tomcat 7
Version: 7.0.19
Platform: PC
Status: NEW
Severity: normal
Priority: P2
Component: Jasper
AssignedTo: dev@tomcat.apache.org
ReportedBy: rsto...@haesoft.com
Classification: Unclassified
Migrating from Tomcat 6.0.29 to 7.0.19 a large performance hit was noticed on
pages containing lots of custom tags. Page rendering time jumped by an order of
magnitude.
Profiling the webapp through Netbeans, we narrowed down the problem to the
getJarFile() method inside org.apache.jasper.compiler.ParseController.
Screenshots of the Profiler Hotspots and Call Tree from both versions of Tomcat
are available here: http://imgur.com/a/ZmeWM
The URL path used to load the JAR file has changed from Tomcat 6. Below are the
values as output by the debugger:
Tomcat 6:
"file:/C:/svn/[PATH_TO_PROJECT]/server/target/snapshot/WEB-INF/lib/[OUR_JAR].jar!/"
Tomcat 7: "jndi:/localhost/snapshot/WEB-INF/lib/[OUR_JAR].jar!/"
A comparison of the getJarFile() methods shows few differences aside from the
URL path that could contribute to the problem:
Tomcat 7: org.apache.jasper.compiler.JarURLResource
public JarFile getJarFile() throws IOException {
URL jarFileUrl = new URL("jar:" + jarUrl + "!/");
JarURLConnection conn = (JarURLConnection) jarFileUrl.openConnection();
conn.setUseCaches(false);
conn.connect();
return conn.getJarFile();
}
Tomcat 6: org.apache.japser.compiler.ParserController
private JarFile getJarFile(URL jarFileUrl) throws IOException {
JarFile jarFile = null;
if (jarFileUrl != null) {
JarURLConnection conn = (JarURLConnection) jarFileUrl.openConnection();
conn.setUseCaches(false);
conn.connect();
jarFile = conn.getJarFile();
}
return jarFile;
}
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51532] Performance Issue when retriving JAR files during TLD file parsing.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51532 rsto...@haesoft.com changed: What|Removed |Added CC||rsto...@haesoft.com OS/Version||All -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51532] Performance Issue when retriving JAR files during TLD file parsing.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51532 --- Comment #1 from Konstantin Kolinko 2011-07-19 22:18:17 UTC --- For reference, thread on @users before opening this issue: http://tomcat.markmail.org/thread/ol7lvks3ex4xikp5 http://marc.info/?t=13111073945&r=1&w=2 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51463] Tomcat.setBaseDir (package org.apache.catalina.startup) should use temp directory as default instead of current directory
https://issues.apache.org/bugzilla/show_bug.cgi?id=51463 Ian Brandt changed: What|Removed |Added CC||i...@ianbrandt.com -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51056] Disable / drop support for SSLv2
https://issues.apache.org/bugzilla/show_bug.cgi?id=51056 --- Comment #5 from Konstantin Kolinko 2011-07-19 23:43:25 UTC --- Created attachment 27300 --> https://issues.apache.org/bugzilla/attachment.cgi?id=27300 Drop SSLv2 support in native examples To apply the patch one has to remove those "a/jni" and "b/jni" prefixes that do not match the svn source layout. There were changes in sslcontext.c recently, so the patch does not apply cleanly anymore. Anyway, 1) tc-native is still used on old systems, like Tomcat 5.5, and thus I don't feel comfortable removing this feature. Maybe consider this for trunk of tc-native or postpone until native 1.2 is more near? Maybe make this code conditional using some #define, e.g. OpenSSL version? 2) +1 to disable it by default in java code in Tomcat The patch also updates tc-native examples. I am attaching a part of Damien Raude-Morvan's patch that modifies the examples, against 1.1.x branch of tomcat/native. Regarding the examples: * examples/org/apache/tomcat/jni/SSLServer.java: OK for the change * examples/org/apache/tomcat/jni/SSL.properties: -1: First, if I understand the old value correctly, it enables "ALL" ciphers, then shifts SSLv2 to the end of the list by priority. Removing SSLv2 moves it to the front of the list and that is wrong. To disable it, one can write !SSLv2 Second, the old value matches whatever default is in Apache HTTPD 2.2, see http://httpd.apache.org/docs/2.2/mod/mod_ssl.html#sslciphersuite Apache HTTPD 2.3 docs say that default depends on OpenSSL version, without providing further specifics. I do not see the value in the code - I think it comes from OpenSSL. OpenSSL docs say that the default value is DEFAULT and it is determined at compile time. http://www.openssl.org/docs/apps/ciphers.html#CIPHER_STRINGS Apparently for OpenSSL 1.0.0 the correct value to be used as default will be literally "DEFAULT". The above mentioned OpenSSL docs say that for 1.0.0 the default value is normally "ALL:!aNULL:!eNULL". This is not true for the copy of OpenSSL 1.0.0d that I have. The command to list ciphers, "openssl ciphers -v " does not list SSLv2 ciphers for DEFAULT, but does mention one SSLv2 cipher for "ALL:!aNULL:!eNULL". -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
