On 14.07.2011 12:08, Konstantin Kolinko wrote: > 2011/7/14 <kkoli...@apache.org>: >> Author: kkolinko >> Date: Thu Jul 14 09:58:31 2011 >> New Revision: 1146623 >> >> URL: http://svn.apache.org/viewvc?rev=1146623&view=rev >> Log: >> Corrected typo in the value of tomcat.util.scan.DefaultJarScanner.jarsToSkip >> property >> >> Modified: >> tomcat/trunk/conf/catalina.properties >> tomcat/trunk/webapps/docs/changelog.xml >> > > >> tomcat-api.jar,tomcat-util.jar,tomcat-coyote.jar,tomcat-dbcp.jar,\ >> >> tomcat-i18n-en.jar,tomcat-i18n-es.jar,tomcat-i18n-fr.jar,tomcat-i18n-ja.jar,\ >> tomcat-juli-adapters.jar,catalina-jmx-remote.jar,catalina-ws.jar,\ >> -tomcat-jdbc.jar\ >> +tomcat-jdbc.jar,\ >> commons-beanutils*.jar,commons-codec*.jar,commons-collections*.jar,\ >> commons-dbcp*.jar,commons-digester*.jar,commons-fileupload*.jar,\ >> >> commons-httpclient*.jar,commons-io*.jar,commons-lang*.jar,commons-logging*.jar,\ > > It would be nice to add a Test to our testsuite to test that any > ".jar" in this property value is followed by comma: > either by (optional spaces and comma) or by (end of line).
I added some test cases in r1148245. They check, whether all tokens (splitted along comma) end with ".jar" and whether there is another ".jar" inside the token. I don't currently tolerate trailing or leading spaces, because I'm not sure, what the current impl does with them. Will check later, but not critical now, since our default "jarsTiSkip" value doesn't contain such whitespace. Regards, Rainer --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
