DO NOT REPLY [Bug 50547] New: The CHANGE_SESSION_ID message that received during cluster session synchronization is dropped.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50547 Summary: The CHANGE_SESSION_ID message that received during cluster session synchronization is dropped. Product: Tomcat 7 Version: trunk Platform: All OS/Version: All Status: NEW Severity: normal Priority: P2 Component: Cluster AssignedTo: dev@tomcat.apache.org ReportedBy: kfuj...@apache.org Neither CHANGE_SESSION_ID message nor SESSION_EXPIRED message set timestamp. If these messages are received during cluster sessions synchronization in DeltaManager startup, because the timestamp is not set, they are dropped. I made a patch that add timestamp for CHANGE_SESSION_ID and SESSION_EXPIRED message. Best Regards. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50547] The CHANGE_SESSION_ID message that received during cluster session synchronization is dropped.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50547 --- Comment #1 from Keiichi Fujino 2011-01-06 03:49:24 EST --- Created an attachment (id=26461) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26461) I made a patch. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1055798 - in /tomcat/trunk: java/org/apache/catalina/ha/session/DeltaManager.java webapps/docs/changelog.xml
Author: kfujino
Date: Thu Jan 6 09:17:28 2011
New Revision: 1055798
URL: http://svn.apache.org/viewvc?rev=1055798&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50547.
Add time stamp for CHANGE_SESSION_ID and SESSION_EXPIRED message.
Modified:
tomcat/trunk/java/org/apache/catalina/ha/session/DeltaManager.java
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/java/org/apache/catalina/ha/session/DeltaManager.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ha/session/DeltaManager.java?rev=1055798&r1=1055797&r2=1055798&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/ha/session/DeltaManager.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/ha/session/DeltaManager.java Thu Jan
6 09:17:28 2011
@@ -547,6 +547,7 @@ public CatalinaCluster getCluster() {
SessionMessage.EVT_CHANGE_SESSION_ID, data,
orgSessionID, orgSessionID + "-"
+ System.currentTimeMillis());
+msg.setTimestamp(System.currentTimeMillis());
counterSend_EVT_CHANGE_SESSION_ID++;
send(msg);
} catch (IOException e) {
@@ -1164,6 +1165,7 @@ public CatalinaCluster getCluster() {
protected void sessionExpired(String id) {
counterSend_EVT_SESSION_EXPIRED++ ;
SessionMessage msg = new
SessionMessageImpl(getName(),SessionMessage.EVT_SESSION_EXPIRED, null, id, id+
"-EXPIRED-MSG");
+msg.setTimestamp(System.currentTimeMillis());
if (log.isDebugEnabled())
log.debug(sm.getString("deltaManager.createMessage.expire",getName(), id));
send(msg);
}
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1055798&r1=1055797&r2=1055798&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Thu Jan 6 09:17:28 2011
@@ -245,6 +245,10 @@
50503: When web application has a version, Engine level
Clustering works correctly. (kfujino)
+
+50547: Add time stamp for CHANGE_SESSION_ID message and
+SESSION_EXPIRED message. (kfujino)
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50547] The CHANGE_SESSION_ID message that received during cluster session synchronization is dropped.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50547 Keiichi Fujino changed: What|Removed |Added Component|Cluster |Cluster Version|trunk |unspecified Product|Tomcat 7|Tomcat 6 Target Milestone|--- |default --- Comment #2 from Keiichi Fujino 2011-01-06 04:22:24 EST --- Fixed in 7.0.x and will be in 7.0.6 onwards. Proposed for 6.0.x and 5.5.x -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1055801 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: kfujino Date: Thu Jan 6 09:28:13 2011 New Revision: 1055801 URL: http://svn.apache.org/viewvc?rev=1055801&view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1055801&r1=1055800&r2=1055801&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Jan 6 09:28:13 2011 @@ -280,3 +280,9 @@ PATCHES PROPOSED TO BACKPORT: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/RemoteIpValve.java?r1=1055482&r2=1055481&pathrev=1055482 +1: markt -1: + +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50547 + Add time stamp for CHANGE_SESSION_ID and SESSION_EXPIRED message. + http://svn.apache.org/viewvc?view=revision&revision=1055798 + +1: kfujino + -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1055803 - /tomcat/tc5.5.x/trunk/STATUS.txt
Author: kfujino Date: Thu Jan 6 09:30:07 2011 New Revision: 1055803 URL: http://svn.apache.org/viewvc?rev=1055803&view=rev Log: Proposal Modified: tomcat/tc5.5.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=1055803&r1=1055802&r2=1055803&view=diff == --- tomcat/tc5.5.x/trunk/STATUS.txt (original) +++ tomcat/tc5.5.x/trunk/STATUS.txt Thu Jan 6 09:30:07 2011 @@ -101,3 +101,9 @@ PATCHES PROPOSED TO BACKPORT: http://svn.apache.org/viewvc?rev=1044987&view=rev +1: kkolinko -1: + +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50547 + Add time stamp for CHANGE_SESSION_ID and SESSION_EXPIRED message. + http://svn.apache.org/viewvc?view=revision&revision=1055798 + +1: kfujino + -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 38372] tcnative-1.dll response overflow corruption, partial pages
https://issues.apache.org/bugzilla/show_bug.cgi?id=38372 jfclere changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution||WORKSFORME -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 41361] Content lost when read by a slow client.
https://issues.apache.org/bugzilla/show_bug.cgi?id=41361 jfclere changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WORKSFORME -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 42090] tcnative badly handles some OpenSSL disconnections.
https://issues.apache.org/bugzilla/show_bug.cgi?id=42090 jfclere changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46041] Tomcat service is terminated unexpectedly (tcnative-1.dll)
https://issues.apache.org/bugzilla/show_bug.cgi?id=46041 jfclere changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WORKSFORME -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46179] apr ssl client authentication
https://issues.apache.org/bugzilla/show_bug.cgi?id=46179 jfclere changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WORKSFORME --- Comment #1 from jfclere 2011-01-06 05:17:55 EST --- SSLVerifyDepth="10" You don't have root certificate for CA so you should use 1. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46571] tcnative blocks in APR poll on Solaris
https://issues.apache.org/bugzilla/show_bug.cgi?id=46571 jfclere changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #12 from jfclere 2011-01-06 05:21:44 EST --- ./native/srclib/VERSIONS tells: - APR 1.3.9, http://apr.apache.org -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1055776 - /tomcat/native/branches/1.1.x/xdocs/miscellaneous/changelog.xml
On 06.01.2011 08:42, jfcl...@apache.org wrote: Author: jfclere Date: Thu Jan 6 07:42:48 2011 New Revision: 1055776 URL: http://svn.apache.org/viewvc?rev=1055776&view=rev Log: Add missing information. Modified: tomcat/native/branches/1.1.x/xdocs/miscellaneous/changelog.xml Modified: tomcat/native/branches/1.1.x/xdocs/miscellaneous/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/native/branches/1.1.x/xdocs/miscellaneous/changelog.xml?rev=1055776&r1=1055775&r2=1055776&view=diff == --- tomcat/native/branches/1.1.x/xdocs/miscellaneous/changelog.xml (original) +++ tomcat/native/branches/1.1.x/xdocs/miscellaneous/changelog.xml Thu Jan 6 07:42:48 2011 @@ -39,6 +39,15 @@ + Update copyright year. (rjung) + It's up to you, but I think it is not common to mention such formal trivialities in the changelog. Regards, Rainer - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1055834 - /tomcat/native/branches/1.1.x/xdocs/miscellaneous/changelog.xml
Author: jfclere Date: Thu Jan 6 11:30:11 2011 New Revision: 1055834 URL: http://svn.apache.org/viewvc?rev=1055834&view=rev Log: Remove trivial stuff. Modified: tomcat/native/branches/1.1.x/xdocs/miscellaneous/changelog.xml Modified: tomcat/native/branches/1.1.x/xdocs/miscellaneous/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/native/branches/1.1.x/xdocs/miscellaneous/changelog.xml?rev=1055834&r1=1055833&r2=1055834&view=diff == --- tomcat/native/branches/1.1.x/xdocs/miscellaneous/changelog.xml (original) +++ tomcat/native/branches/1.1.x/xdocs/miscellaneous/changelog.xml Thu Jan 6 11:30:11 2011 @@ -39,12 +39,6 @@ - Update copyright year. (rjung) - - - Add tm logo. (mturk) - - Make the non blocking write really no blocking. (jfclere) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
ThreadLocal Clear References Problem
Hello folks Could you see the problem in https://issues.apache.org/jira/browse/MYFACES-3006? Thanks for your comments! --Gurkan - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46179] apr ssl client authentication
https://issues.apache.org/bugzilla/show_bug.cgi?id=46179 --- Comment #2 from Pawel Jasinski 2011-01-06 08:57:11 EST --- I am a bit confused. As far as I am concerned the correct config file with chain of 2 certificates is provided: all-cacerts.pem This file contains root certificate: Issuer: CN=REtest-RootCA, OU=Certification Authorities, OU=NEO, O=RUAG Subject: CN=REtest-RootCA, OU=Certification Authorities, OU=NEO, O=RUAG Electronics, C=CH -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 47319] With APR, getRemoteHost() returns NULL for unknown clients
https://issues.apache.org/bugzilla/show_bug.cgi?id=47319 jfclere changed: What|Removed |Added Component|Library |Connectors Product|Tomcat Native |Tomcat 7 --- Comment #1 from jfclere 2011-01-06 09:01:16 EST --- In fact that needs to be fixed in java/org/apache/coyote/http11/Http11AprProcessor.java -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46179] apr ssl client authentication
https://issues.apache.org/bugzilla/show_bug.cgi?id=46179 --- Comment #3 from Pawel Jasinski 2011-01-06 09:04:40 EST --- I am a bit confused. As far as I am concerned the correct configuration file with chain of 2 certificates is provided: all-cacerts.pem This file contains root certificate: Issuer: CN=REtest-RootCA ... Subject: CN=REtest-RootCA ... If I set the SSLVerifyDepth to 1, it verifies only the CA1 certificate Shall we say that chained certificates in this particular case are not supported? Is there any other way to supply the chained certificate to apr/ssl? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46179] apr ssl client authentication
https://issues.apache.org/bugzilla/show_bug.cgi?id=46179 Pawel Jasinski changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|WORKSFORME | -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50550] New: PropFind 404 error after MkCol succes
https://issues.apache.org/bugzilla/show_bug.cgi?id=50550 Summary: PropFind 404 error after MkCol succes Product: Tomcat 5 Version: 5.5.31 Platform: PC OS/Version: Windows XP Status: NEW Severity: normal Priority: P2 Component: Servlets:WebDAV AssignedTo: dev@tomcat.apache.org ReportedBy: maarten.van.hulsen...@gmail.com A propfind call on a resource returns a 404 error when executed after a mkcol for the same resource. The mkcol should be preceeded with a propfind to trigger the issue. Steps to reproduce - See the following access log; 127.0.0.1 - - [06/Jan/2011:14:09:19 +0100] "PROPFIND /webdav/output/f469e3d6-e536-4072-82da-d989acaf57a2/ HTTP/1.1" 404 1084 127.0.0.1 - - [06/Jan/2011:14:09:19 +0100] "MKCOL /webdav/output/f469e3d6-e536-4072-82da-d989acaf57a2/ HTTP/1.1" 201 - 127.0.0.1 - - [06/Jan/2011:14:09:19 +0100] "PROPFIND /webdav/output/f469e3d6-e536-4072-82da-d989acaf57a2/ HTTP/1.1" 404 1084 When the first request would be omitted, the third request would have been succesful, as the following access log shows; 127.0.0.1 - - [06/Jan/2011:14:10:39 +0100] "MKCOL /webdav/output/81a97360-ea49-44d3-b764-d8c7e60e885e/ HTTP/1.1" 201 - 127.0.0.1 - - [06/Jan/2011:14:10:39 +0100] "PROPFIND /webdav/output/81a97360-ea49-44d3-b764-d8c7e60e885e/ HTTP/1.1" 207 628 Note: After a few seconds, the response to propfind for that resource is OK again. This suggests this has to do with caching. Note2: This situation sounds similar to call 21288 (FIXED - 'DirContext caching problem with Dreamweaver 6 when recursively creating directories'). Reproducable using a jackrabbit client; HttpClient client = new HttpClient(); String newDir = "http://localhost:8080/webdav/output/"; + UUID.randomUUID() + "/"; // Comment out this request to make second propfind succesful HttpMethod propFindMethod1 = new PropFindMethod(newDir); client.executeMethod(propFindMethod1); propFindMethod1.releaseConnection(); HttpMethod mkcolMethod = new MkColMethod(newDir); client.executeMethod(mkcolMethod); mkcolMethod.releaseConnection(); HttpMethod propFindMethod = new PropFindMethod(newDir); client.executeMethod(propFindMethod); propFindMethod.releaseConnection(); -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1055888 - /tomcat/native/branches/1.1.x/java/org/apache/tomcat/jni/Address.java
Author: jfclere
Date: Thu Jan 6 14:14:38 2011
New Revision: 1055888
URL: http://svn.apache.org/viewvc?rev=1055888&view=rev
Log:
Fix for 47851.
Modified:
tomcat/native/branches/1.1.x/java/org/apache/tomcat/jni/Address.java
Modified: tomcat/native/branches/1.1.x/java/org/apache/tomcat/jni/Address.java
URL:
http://svn.apache.org/viewvc/tomcat/native/branches/1.1.x/java/org/apache/tomcat/jni/Address.java?rev=1055888&r1=1055887&r2=1055888&view=diff
==
--- tomcat/native/branches/1.1.x/java/org/apache/tomcat/jni/Address.java
(original)
+++ tomcat/native/branches/1.1.x/java/org/apache/tomcat/jni/Address.java Thu
Jan 6 14:14:38 2011
@@ -25,7 +25,7 @@ package org.apache.tomcat.jni;
public class Address {
-static public String APR_ANYADDR = "0.0.0.0";
+static public final String APR_ANYADDR = "0.0.0.0";
/**
* Fill the Sockaddr class from apr_sockaddr_t
* @param info Sockaddr class to fill
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 47851] thread-safety issues in the TC native Java code
https://issues.apache.org/bugzilla/show_bug.cgi?id=47851 jfclere changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #1 from jfclere 2011-01-06 09:14:44 EST --- the APR_ANYADDR = "0.0.0.0" is OK. the rest wrong. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1055907 - in /tomcat/native/branches/1.1.x: native/src/ssl.c xdocs/miscellaneous/changelog.xml
Author: jfclere
Date: Thu Jan 6 15:12:31 2011
New Revision: 1055907
URL: http://svn.apache.org/viewvc?rev=1055907&view=rev
Log:
Fix for bug 48253.
Modified:
tomcat/native/branches/1.1.x/native/src/ssl.c
tomcat/native/branches/1.1.x/xdocs/miscellaneous/changelog.xml
Modified: tomcat/native/branches/1.1.x/native/src/ssl.c
URL:
http://svn.apache.org/viewvc/tomcat/native/branches/1.1.x/native/src/ssl.c?rev=1055907&r1=1055906&r2=1055907&view=diff
==
--- tomcat/native/branches/1.1.x/native/src/ssl.c (original)
+++ tomcat/native/branches/1.1.x/native/src/ssl.c Thu Jan 6 15:12:31 2011
@@ -37,6 +37,18 @@ ENGINE *tcn_ssl_engine = NULL;
void *SSL_temp_keys[SSL_TMP_KEY_MAX];
tcn_pass_cb_t tcn_password_callback;
+/* Global reference to the pool used by the dynamic mutexes */
+static apr_pool_t *dynlockpool = NULL;
+
+/* Dynamic lock structure */
+struct CRYPTO_dynlock_value {
+apr_pool_t *pool;
+const char* file;
+int line;
+apr_thread_mutex_t *mutex;
+};
+
+
/*
* Handle the Temporary RSA Keys and DH Params
*/
@@ -215,11 +227,94 @@ static apr_status_t ssl_thread_cleanup(v
UNREFERENCED(data);
CRYPTO_set_locking_callback(NULL);
CRYPTO_set_id_callback(NULL);
+CRYPTO_set_dynlock_create_callback(NULL);
+CRYPTO_set_dynlock_lock_callback(NULL);
+CRYPTO_set_dynlock_destroy_callback(NULL);
+
+dynlockpool = NULL;
+
/* Let the registered mutex cleanups do their own thing
*/
return APR_SUCCESS;
}
+/*
+ * Dynamic lock creation callback
+ */
+static struct CRYPTO_dynlock_value *ssl_dyn_create_function(const char *file,
+ int line)
+{
+struct CRYPTO_dynlock_value *value;
+apr_pool_t *p;
+apr_status_t rv;
+
+/*
+ * We need a pool to allocate our mutex. Since we can't clear
+ * allocated memory from a pool, create a subpool that we can blow
+ * away in the destruction callback.
+ */
+rv = apr_pool_create(&p, dynlockpool);
+if (rv != APR_SUCCESS) {
+/* TODO log that fprintf(stderr, "Failed to create subpool for dynamic
lock"); */
+return NULL;
+}
+
+value = (struct CRYPTO_dynlock_value *)apr_palloc(p,
+ sizeof(struct
CRYPTO_dynlock_value));
+if (!value) {
+/* TODO log that fprintf(stderr, "Failed to allocate dynamic lock
structure"); */
+return NULL;
+}
+
+value->pool = p;
+/* Keep our own copy of the place from which we were created,
+ using our own pool. */
+value->file = apr_pstrdup(p, file);
+value->line = line;
+rv = apr_thread_mutex_create(&(value->mutex), APR_THREAD_MUTEX_DEFAULT,
+p);
+if (rv != APR_SUCCESS) {
+/* TODO log that fprintf(stderr, "Failed to create thread mutex for
dynamic lock"); */
+apr_pool_destroy(p);
+return NULL;
+}
+return value;
+}
+
+/*
+ * Dynamic locking and unlocking function
+ */
+
+static void ssl_dyn_lock_function(int mode, struct CRYPTO_dynlock_value *l,
+ const char *file, int line)
+{
+apr_status_t rv;
+
+if (mode & CRYPTO_LOCK) {
+rv = apr_thread_mutex_lock(l->mutex);
+}
+else {
+rv = apr_thread_mutex_unlock(l->mutex);
+}
+}
+
+/*
+ * Dynamic lock destruction callback
+ */
+static void ssl_dyn_destroy_function(struct CRYPTO_dynlock_value *l,
+ const char *file, int line)
+{
+apr_status_t rv;
+rv = apr_thread_mutex_destroy(l->mutex);
+if (rv != APR_SUCCESS) {
+/* TODO log that fprintf(stderr, "Failed to destroy mutex for dynamic
lock %s:%d", l->file, l->line); */
+}
+
+/* Trust that whomever owned the CRYPTO_dynlock_value we were
+ * passed has no future use for it...
+ */
+apr_pool_destroy(l->pool);
+}
static void ssl_thread_setup(apr_pool_t *p)
{
int i;
@@ -235,6 +330,14 @@ static void ssl_thread_setup(apr_pool_t
CRYPTO_set_id_callback(ssl_thread_id);
CRYPTO_set_locking_callback(ssl_thread_lock);
+/* Set up dynamic locking scaffolding for OpenSSL to use at its
+ * convenience.
+ */
+dynlockpool = p;
+CRYPTO_set_dynlock_create_callback(ssl_dyn_create_function);
+CRYPTO_set_dynlock_lock_callback(ssl_dyn_lock_function);
+CRYPTO_set_dynlock_destroy_callback(ssl_dyn_destroy_function);
+
apr_pool_cleanup_register(p, NULL, ssl_thread_cleanup,
apr_pool_cleanup_null);
}
@@ -404,6 +507,9 @@ TCN_IMPLEMENT_CALL(jint, SSL, initialize
OPENSSL_load_builtin_modules();
#endif
+/* Initialize thread support */
+ssl_thread_setup(tcn_global_pool);
+
#ifndef OPENSSL_NO_ENGINE
if (J2S(engine)) {
ENGINE *ee = NULL;
@@ -457,8 +563,6 @@ TCN_IMPLEMENT_CALL(jint, SSL, initialize
apr_pool_cleanup_register(tcn_global_pool, NULL,
DO NOT REPLY [Bug 48253] Tomcat Native patch - adding dynamic locking callbacks for openssl engines
https://issues.apache.org/bugzilla/show_bug.cgi?id=48253 jfclere changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1055925 - in /tomcat/site/trunk: docs/migration.html xdocs/migration.xml
Author: markt Date: Thu Jan 6 16:07:28 2011 New Revision: 1055925 URL: http://svn.apache.org/viewvc?rev=1055925&view=rev Log: Add info on regex changes Modified: tomcat/site/trunk/docs/migration.html tomcat/site/trunk/xdocs/migration.xml Modified: tomcat/site/trunk/docs/migration.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/migration.html?rev=1055925&r1=1055924&r2=1055925&view=diff == --- tomcat/site/trunk/docs/migration.html (original) +++ tomcat/site/trunk/docs/migration.html Thu Jan 6 16:07:28 2011 @@ -233,6 +233,9 @@ Java 6 required +General configuration + + Deployment @@ -627,6 +630,37 @@ compatibility problems. + + + + +General configuration + + + + + + + + +All configuration options that use regular expression now require a +single regular expression (using java.util.regex) rather than a +list of comma-separated or semi-colon-separated expressions. + + + + + + + + + + + + + + + Deployment Modified: tomcat/site/trunk/xdocs/migration.xml URL: http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/migration.xml?rev=1055925&r1=1055924&r2=1055925&view=diff == --- tomcat/site/trunk/xdocs/migration.xml (original) +++ tomcat/site/trunk/xdocs/migration.xml Thu Jan 6 16:07:28 2011 @@ -115,6 +115,14 @@ compatibility problems. + + +All configuration options that use regular expression now require a +single regular expression (using java.util.regex) rather than a +list of comma-separated or semi-colon-separated expressions. + + + XML context descriptors are no longer extracted from deployed WARs and - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49556] the proc.create function used args as env to get the element count,
https://issues.apache.org/bugzilla/show_bug.cgi?id=49556 jfclere changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #1 from jfclere 2011-01-06 11:48:10 EST --- What are you trying to do? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49557] index erro in the loop to get the env info in the proc.create function
https://issues.apache.org/bugzilla/show_bug.cgi?id=49557 jfclere changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #1 from jfclere 2011-01-06 11:49:54 EST --- What are you trying to do? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1055938 - in /tomcat/trunk: java/org/apache/coyote/http11/Http11AprProcessor.java webapps/docs/changelog.xml
Author: markt
Date: Thu Jan 6 17:02:27 2011
New Revision: 1055938
URL: http://svn.apache.org/viewvc?rev=1055938&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47319
Don't return null for getRemoteHost() if the IP address cannot be resolved.
Modified:
tomcat/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java?rev=1055938&r1=1055937&r2=1055938&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java
(original)
+++ tomcat/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java Thu Jan
6 17:02:27 2011
@@ -464,6 +464,9 @@ public class Http11AprProcessor extends
try {
long sa = Address.get(Socket.APR_REMOTE, socketRef);
remoteHost = Address.getnameinfo(sa, 0);
+if (remoteHost == null) {
+remoteHost = Address.getip(sa);
+}
} catch (Exception e) {
log.warn(sm.getString("http11processor.socket.info"), e);
}
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1055938&r1=1055937&r2=1055938&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Thu Jan 6 17:02:27 2011
@@ -188,6 +188,12 @@
+
+47319: Return the client's IP address rather than null
+for calls to getRemoteHost() when the APR connector is
+used with enableLookups="true" but the IP
address
+is not resolveable. (markt)
+
50108: Add get/set methods for Connector property
minSpareThreads. Patch provided by Eiji Takahashi. (markt)
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1055941 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Thu Jan 6 17:06:38 2011 New Revision: 1055941 URL: http://svn.apache.org/viewvc?rev=1055941&view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1055941&r1=1055940&r2=1055941&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Jan 6 17:06:38 2011 @@ -286,3 +286,9 @@ PATCHES PROPOSED TO BACKPORT: http://svn.apache.org/viewvc?view=revision&revision=1055798 +1: kfujino -1: + +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47319 + Return IP address rather than null for getRemoteHost() and the APR connector + http://people.apache.org/~markt/patches/2011-01-06-bug47319-tc6.patch + +1: markt + -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 47319] With APR, getRemoteHost() returns NULL for unknown clients
https://issues.apache.org/bugzilla/show_bug.cgi?id=47319 Mark Thomas changed: What|Removed |Added Component|Connectors |Connectors Version|unspecified |6.0.29 Product|Tomcat 7|Tomcat 6 Target Milestone|--- |default --- Comment #2 from Mark Thomas 2011-01-06 12:07:03 EST --- Fixed in 7.0.x and will be included in 7.0.6 onwards. Proposed for 6.0.x -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1055943 - in /tomcat/native/branches/1.1.x: native/os/win32/registry.c xdocs/miscellaneous/changelog.xml
Author: jfclere Date: Thu Jan 6 17:10:09 2011 New Revision: 1055943 URL: http://svn.apache.org/viewvc?rev=1055943&view=rev Log: Fix for 49851. Modified: tomcat/native/branches/1.1.x/native/os/win32/registry.c tomcat/native/branches/1.1.x/xdocs/miscellaneous/changelog.xml Modified: tomcat/native/branches/1.1.x/native/os/win32/registry.c URL: http://svn.apache.org/viewvc/tomcat/native/branches/1.1.x/native/os/win32/registry.c?rev=1055943&r1=1055942&r2=1055943&view=diff == --- tomcat/native/branches/1.1.x/native/os/win32/registry.c (original) +++ tomcat/native/branches/1.1.x/native/os/win32/registry.c Thu Jan 6 17:10:09 2011 @@ -767,6 +767,7 @@ TCN_IMPLEMENT_CALL(jint, Registry, delet rv = EBADF; goto cleanup; } +TCN_INIT_WSTRING(name); if (only_if_empty) rv = SHDeleteEmptyKeyW(TCN_KEYS[root].k, J2W(name)); else @@ -784,6 +785,7 @@ TCN_IMPLEMENT_CALL(jint, Registry, delet tcn_nt_registry_t *k = J2P(key, tcn_nt_registry_t *); UNREFERENCED(o); +TCN_INIT_WSTRING(name); rv = RegDeleteValueW(k->key, J2W(name)); TCN_FREE_WSTRING(name); return (jint)rv; Modified: tomcat/native/branches/1.1.x/xdocs/miscellaneous/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/native/branches/1.1.x/xdocs/miscellaneous/changelog.xml?rev=1055943&r1=1055942&r2=1055943&view=diff == --- tomcat/native/branches/1.1.x/xdocs/miscellaneous/changelog.xml (original) +++ tomcat/native/branches/1.1.x/xdocs/miscellaneous/changelog.xml Thu Jan 6 17:10:09 2011 @@ -39,6 +39,9 @@ + 49851: JNI Registry.deleteKey and Registry.deleteValue corrupt Windows registry. (jfclere) + + 48253: adding dynamic locking callbacks for openssl engines. (jfclere) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49851] JNI Registry.deleteKey and Registry.deleteValue corrupt Windows registry
https://issues.apache.org/bugzilla/show_bug.cgi?id=49851 jfclere changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50135] IPV6 problem: unable to connect from other host
https://issues.apache.org/bugzilla/show_bug.cgi?id=50135 jfclere changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WORKSFORME OS/Version||All --- Comment #4 from jfclere 2011-01-06 12:14:14 EST --- that is a user list question not a bug -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1055951 - /tomcat/trunk/java/org/apache/catalina/servlets/WebdavServlet.java
Author: markt
Date: Thu Jan 6 17:29:01 2011
New Revision: 1055951
URL: http://svn.apache.org/viewvc?rev=1055951&view=rev
Log:
Fix a couple of FindBugs niggles
Modified:
tomcat/trunk/java/org/apache/catalina/servlets/WebdavServlet.java
Modified: tomcat/trunk/java/org/apache/catalina/servlets/WebdavServlet.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/servlets/WebdavServlet.java?rev=1055951&r1=1055950&r2=1055951&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/servlets/WebdavServlet.java (original)
+++ tomcat/trunk/java/org/apache/catalina/servlets/WebdavServlet.java Thu Jan
6 17:29:01 2011
@@ -2706,18 +2706,23 @@ public class WebdavServlet
@Override
public String toString() {
-String result = "Type:" + type + "\n";
-result += "Scope:" + scope + "\n";
-result += "Depth:" + depth + "\n";
-result += "Owner:" + owner + "\n";
-result += "Expiration:"
-+ FastHttpDateFormat.formatDate(expiresAt, null) + "\n";
+StringBuilder result = new StringBuilder("Type:");
+result.append(type);
+result.append("\nScope:");
+result.append(scope);
+result.append("\nDepth:");
+result.append(depth);
+result.append("\nOwner:");
+result.append(owner);
+result.append("\nExpiration:");
+result.append(FastHttpDateFormat.formatDate(expiresAt, null));
Enumeration tokensList = tokens.elements();
while (tokensList.hasMoreElements()) {
-result += "Token:" + tokensList.nextElement() + "\n";
+result.append("\nToken:");
+result.append(tokensList.nextElement());
}
-return result;
-
+result.append("\n");
+return result.toString();
}
@@ -2797,7 +2802,7 @@ public class WebdavServlet
* called with false. External references are filtered out for
* security reasons. See CVE-2007-5461.
*/
-private class WebdavResolver implements EntityResolver {
+private static class WebdavResolver implements EntityResolver {
private ServletContext context;
public WebdavResolver(ServletContext theContext) {
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: ThreadLocal Clear References Problem
Gurkan, On 1/6/2011 7:08 AM, Gurkan Erdogdu wrote: > Could you see the problem in > https://issues.apache.org/jira/browse/MYFACES-3006? So, you are stopping a second application from the code shown in the bug? Can you post a working example? -chris signature.asc Description: OpenPGP digital signature
DO NOT REPLY [Bug 50552] New: Ant Tasks give a null pointer exception when an error occurs, masking true error
https://issues.apache.org/bugzilla/show_bug.cgi?id=50552 Summary: Ant Tasks give a null pointer exception when an error occurs, masking true error Product: Tomcat 7 Version: unspecified Platform: All OS/Version: All Status: NEW Severity: normal Priority: P2 Component: Integration AssignedTo: dev@tomcat.apache.org ReportedBy: chris.rim...@nominet.org.uk Created an attachment (id=26463) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26463) Fix to abstract catalina task class to set up redirector correctly Using the Ant List Task with outputproperty set causes a null pointer exception in the event of any error. For example, if tomcat is not running or the url given is incorrect. Since the bug is in a base class, this probably affects all the ant tasks. The bug is due to the fact that the code to clean up the redirector is called in the finally block, but the equivalent code to set it up is not. This problem is also present in Tomcat 6. The attached patch fixes the problem. With the patch in place, using the list task when tomcat is down gives "Connection refused" instead. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1055975 - in /tomcat/trunk: java/org/apache/naming/resources/ProxyDirContext.java webapps/docs/changelog.xml
Author: markt
Date: Thu Jan 6 18:09:23 2011
New Revision: 1055975
URL: http://svn.apache.org/viewvc?rev=1055975&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50550
Make sure PROPFIND,MKCOL,PROPFIND returns 404,201,207 rather than 404,201,404
Modified:
tomcat/trunk/java/org/apache/naming/resources/ProxyDirContext.java
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/java/org/apache/naming/resources/ProxyDirContext.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/naming/resources/ProxyDirContext.java?rev=1055975&r1=1055974&r2=1055975&view=diff
==
--- tomcat/trunk/java/org/apache/naming/resources/ProxyDirContext.java
(original)
+++ tomcat/trunk/java/org/apache/naming/resources/ProxyDirContext.java Thu Jan
6 18:09:23 2011
@@ -1694,10 +1694,16 @@ public class ProxyDirContext implements
if (cache == null)
return false;
synchronized (cache) {
-return cache.unload(name);
+boolean result = cache.unload(name);
+// To ensure correct operation, particularly of WebDAV, unload
+// the resource with and without a trailing /
+if (name.endsWith("/")) {
+cache.unload(name.substring(0, name.length() -1));
+} else {
+cache.unload(name + "/");
+}
+return result;
}
}
-
-
}
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1055975&r1=1055974&r2=1055975&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Thu Jan 6 18:09:23 2011
@@ -184,6 +184,11 @@
than a list of comma-separated or semi-colon-separated expressions.
(markt)
+
+50550: When a new directory is created (e.g. via WebDAV)
+ensure that a subsequent request for that directory does not result in
a
+404 response. (markt)
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1055976 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Thu Jan 6 18:10:41 2011 New Revision: 1055976 URL: http://svn.apache.org/viewvc?rev=1055976&view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1055976&r1=1055975&r2=1055976&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Jan 6 18:10:41 2011 @@ -292,3 +292,9 @@ PATCHES PROPOSED TO BACKPORT: http://people.apache.org/~markt/patches/2011-01-06-bug47319-tc6.patch +1: markt -1: + +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50550 + Requests for a newly created directory using MKCOL should not result in a 404 + http://svn.apache.org/viewvc?rev=1055975&view=rev + +1: markt + -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1055977 - /tomcat/tc5.5.x/trunk/STATUS.txt
Author: markt Date: Thu Jan 6 18:12:15 2011 New Revision: 1055977 URL: http://svn.apache.org/viewvc?rev=1055977&view=rev Log: Proposal Modified: tomcat/tc5.5.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=1055977&r1=1055976&r2=1055977&view=diff == --- tomcat/tc5.5.x/trunk/STATUS.txt (original) +++ tomcat/tc5.5.x/trunk/STATUS.txt Thu Jan 6 18:12:15 2011 @@ -107,3 +107,10 @@ PATCHES PROPOSED TO BACKPORT: http://svn.apache.org/viewvc?view=revision&revision=1055798 +1: kfujino -1: + +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50550 + Requests for a newly created directory using MKCOL should not result in a 404 + http://svn.apache.org/viewvc?rev=1055975&view=rev + +1: markt + -1: + \ No newline at end of file - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50550] PropFind 404 error after MkCol succes
https://issues.apache.org/bugzilla/show_bug.cgi?id=50550 --- Comment #1 from Mark Thomas 2011-01-06 13:12:33 EST --- Fixed in 7.0.x and will be included in 7.0.6 onwards. Proposed for 6.0.x and 5.5.x. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1055989 - in /tomcat/trunk: java/org/apache/naming/factory/DataSourceLinkFactory.java webapps/docs/changelog.xml webapps/docs/config/context.xml
Author: fhanik
Date: Thu Jan 6 18:22:34 2011
New Revision: 1055989
URL: http://svn.apache.org/viewvc?rev=1055989&view=rev
Log:
https://issues.apache.org/bugzilla/show_bug.cgi?id=49543
Add the ability to specify a data source link, to use a shared datasource with
per application credentials
Added:
tomcat/trunk/java/org/apache/naming/factory/DataSourceLinkFactory.java
(with props)
Modified:
tomcat/trunk/webapps/docs/changelog.xml
tomcat/trunk/webapps/docs/config/context.xml
Added: tomcat/trunk/java/org/apache/naming/factory/DataSourceLinkFactory.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/naming/factory/DataSourceLinkFactory.java?rev=1055989&view=auto
==
--- tomcat/trunk/java/org/apache/naming/factory/DataSourceLinkFactory.java
(added)
+++ tomcat/trunk/java/org/apache/naming/factory/DataSourceLinkFactory.java Thu
Jan 6 18:22:34 2011
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+package org.apache.naming.factory;
+
+import java.lang.reflect.Constructor;
+import java.lang.reflect.InvocationHandler;
+import java.lang.reflect.InvocationTargetException;
+import java.lang.reflect.Method;
+import java.lang.reflect.Proxy;
+import java.sql.SQLException;
+import java.util.Hashtable;
+
+import javax.naming.Context;
+import javax.naming.Name;
+import javax.naming.NamingException;
+import javax.naming.RefAddr;
+import javax.naming.Reference;
+import javax.naming.spi.ObjectFactory;
+import javax.sql.DataSource;
+
+import org.apache.naming.ResourceLinkRef;
+
+
+
+/**
+ * Object factory for resource links for shared data sources.
+ *
+ * @author Filip Hanik
+ * @version $Id: ResourceLinkFactory.java 939311 2010-04-29 14:01:02Z kkolinko
$
+ */
+
+public class DataSourceLinkFactory extends ResourceLinkFactory
+implements ObjectFactory {
+
+
+// -- ObjectFactory Methods
+
+
+/**
+ * Create a new DataSource instance.
+ *
+ * @param obj The reference object describing the DataSource
+ */
+public Object getObjectInstance(Object obj, Name name, Context nameCtx,
+Hashtable environment)
+throws NamingException {
+Object result = super.getObjectInstance(obj, name, nameCtx,
environment);
+// Can we process this request?
+if (result!=null) {
+Reference ref = (Reference) obj;
+
+RefAddr userAttr = ref.get("username");
+RefAddr passAttr = ref.get("password");
+if (userAttr.getContent()!=null && passAttr.getContent()!=null) {
+result =
wrapDataSource(result,userAttr.getContent().toString(),
passAttr.getContent().toString());
+}
+}
+return result;
+}
+
+protected Object wrapDataSource(Object datasource, String username, String
password) throws NamingException {
+try {
+Class proxyClass =
Proxy.getProxyClass(datasource.getClass().getClassLoader(),
datasource.getClass().getInterfaces());
+Constructor proxyConstructor = proxyClass.getConstructor(new
Class[] { InvocationHandler.class });
+DataSourceHandler handler = new
DataSourceHandler((DataSource)datasource, username, password);
+return proxyConstructor.newInstance(handler);
+}catch (Exception x) {
+if (x instanceof NamingException) throw (NamingException)x;
+else {
+NamingException nx = new NamingException(x.getMessage());
+nx.initCause(x);
+throw nx;
+}
+}
+}
+
+/**
+ * Simple wrapper class that will allow a user to configure a ResourceLink
for a data source
+ * so that when {...@link javax.sql.DataSource#getConnection()} is called,
it will invoke
+ * {...@link javax.sql.DataSource#getConnection(String, String)} with the
preconfigured username and password.
+ */
+public static class DataSourceHandler implements InvocationHandler {
+DataSource ds;
+String username;
+String password;
+public DataSo
DO NOT REPLY [Bug 49543] Request for a "shared" datasource configuration as in DBCP
https://issues.apache.org/bugzilla/show_bug.cgi?id=49543 Filip Hanik changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #4 from Filip Hanik 2011-01-06 13:24:43 EST --- You can now do this with any configured data source as long as the data source itself supports getConnection(String,String) This was committed in http://svn.apache.org/viewvc?view=revision&revision=1055989 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50552] Ant Tasks give a null pointer exception when an error occurs, masking true error
https://issues.apache.org/bugzilla/show_bug.cgi?id=50552 --- Comment #1 from Christopher Schultz 2011-01-06 14:09:05 EST --- Confirmed in Tomcat 7 trunk: Results in the following output: bug50552test: BUILD FAILED /home/cschultz/projects/diagnosis/build.xml:1434: java.lang.NullPointerException at org.apache.tools.ant.taskdefs.Redirector.complete(Redirector.java:906) at org.apache.catalina.ant.BaseRedirectorHelperTask.closeRedirector(BaseRedirectorHelperTask.java:267) at org.apache.catalina.ant.AbstractCatalinaTask.execute(AbstractCatalinaTask.java:272) at org.apache.catalina.ant.AbstractCatalinaTask.execute(AbstractCatalinaTask.java:149) at org.apache.catalina.ant.ListTask.execute(ListTask.java:51) at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:291) at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) at org.apache.tools.ant.Task.perform(Task.java:348) at org.apache.tools.ant.Target.execute(Target.java:390) at org.apache.tools.ant.Target.performTasks(Target.java:411) at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1397) at org.apache.tools.ant.Project.executeTarget(Project.java:1366) at org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41) at org.apache.tools.ant.Project.executeTargets(Project.java:1249) at org.apache.tools.ant.Main.runBuild(Main.java:801) at org.apache.tools.ant.Main.startAnt(Main.java:218) at org.apache.tools.ant.launch.Launcher.run(Launcher.java:280) at org.apache.tools.ant.launch.Launcher.main(Launcher.java:109) -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1056020 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: fhanik Date: Thu Jan 6 19:26:45 2011 New Revision: 1056020 URL: http://svn.apache.org/viewvc?rev=1056020&view=rev Log: votes Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1056020&r1=1056019&r2=1056020&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Jan 6 19:26:45 2011 @@ -171,7 +171,7 @@ PATCHES PROPOSED TO BACKPORT: this patched tc6 version on top of it: http://people.apache.org/~kkolinko/patches/2010-12-02_tc6_tomcat-nsi-of-tc7_vs_tc6.diff ) - +1: kkolinko, markt + +1: kkolinko, markt, fhanik -1: * Backport JSP unloading patch (BZ48358). @@ -205,7 +205,7 @@ PATCHES PROPOSED TO BACKPORT: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50201 Handle ROOT webapp redeployment, host start/stop etc for default access log http://people.apache.org/~kkolinko/patches/2010-12-07_tc6_bug50201.patch - +1: kkolinko, markt + +1: kkolinko, markt, fhanik -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48973 @@ -235,6 +235,7 @@ PATCHES PROPOSED TO BACKPORT: http://svn.apache.org/viewvc?view=revision&revision=1042447 http://svn.apache.org/viewvc?view=revision&revision=1042494 +1: kkolinko + 0: fhanik - don't see a need to change any line wrappings, it just causes clutter in the SVN diffs, but if it floats your boat :) -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50413 @@ -260,41 +261,49 @@ PATCHES PROPOSED TO BACKPORT: Use correct coercions for EL arithmetic operations. Based on a patch by Brian Weisleder http://svn.apache.org/viewvc?rev=1055055&view=rev - +1: markt + +1: markt, fhanik -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50527 Improve error message http://svn.apache.org/viewvc?rev=1055236&view=rev - +1: markt, jfclere + +1: markt, jfclere, fhanik -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50467 Avoid NOE that causes NIO poller to fail http://svn.apache.org/viewvc?rev=1055458&view=rev +1: markt + +1: fhanik - fix indentation -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50453 Correct handle multiple X-Forwarded-For headers in RemoteIpValve http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/RemoteIpValve.java?r1=1055482&r2=1055481&pathrev=1055482 - +1: markt + +1: markt, fhanik -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50547 Add time stamp for CHANGE_SESSION_ID and SESSION_EXPIRED message. http://svn.apache.org/viewvc?view=revision&revision=1055798 - +1: kfujino + +1: kfujino, fhanik -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47319 Return IP address rather than null for getRemoteHost() and the APR connector http://people.apache.org/~markt/patches/2011-01-06-bug47319-tc6.patch - +1: markt + +1: markt, fhanik -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50550 Requests for a newly created directory using MKCOL should not result in a 404 http://svn.apache.org/viewvc?rev=1055975&view=rev +1: markt + +1: fhanik - what does the boolean 'result' signify if the first unload() is false, and the second is true? -1: + +* Add helper class to allow a shared data source with different credentials + http://svn.apache.org/viewvc?view=revision&revision=1055989 + +1: fhanik + -1: + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50554] New: Bad use of getClass() could potentially lead to concurrency bugs in future
https://issues.apache.org/bugzilla/show_bug.cgi?id=50554 Summary: Bad use of getClass() could potentially lead to concurrency bugs in future Product: Tomcat 7 Version: trunk Platform: All OS/Version: All Status: NEW Severity: normal Priority: P2 Component: Catalina AssignedTo: dev@tomcat.apache.org ReportedBy: reprogram...@gmail.com The method org.apache.naming.java.javaURLContextFactory.getInitialContext(Hashtable) has a synchronized block on getClass(). Using getClass() as lock is a bug pattern because if some class subclasses javaURLContextFactory and getInitialContext gets called on an instance of such a subclass, getClass() will return a different Class object for that instance. Locking different objects for different classes is usually not the expected behavior. Therefore, I suggest to remove this bug pattern by simply replacing getClass() by javaURLContextFactory.class. See https://www.securecoding.cert.org/confluence/display/java/LCK02-J.+Do+not+synchronize+on+the+class+object+returned+by+getClass%28%29 for more information about this bug pattern. Keshmesh (https://github.com/reprogrammer/keshmesh/) is an Eclipse plugin that analyzes the source code of Java programs to detect concurrency bug patterns such the one I reported. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50554] Bad use of getClass() could potentially lead to concurrency bugs in future
https://issues.apache.org/bugzilla/show_bug.cgi?id=50554 Mohsen Vakilian changed: What|Removed |Added CC||reprogram...@gmail.com -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1056091 - /tomcat/trunk/java/org/apache/naming/factory/DataSourceLinkFactory.java
Author: kkolinko
Date: Thu Jan 6 21:38:35 2011
New Revision: 1056091
URL: http://svn.apache.org/viewvc?rev=1056091&view=rev
Log:
Followup to r1055989
Do not use $Id if svn:keywords property is not set.
BTW, @author tags are deprecated, aren't they?
Modified:
tomcat/trunk/java/org/apache/naming/factory/DataSourceLinkFactory.java
Modified: tomcat/trunk/java/org/apache/naming/factory/DataSourceLinkFactory.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/naming/factory/DataSourceLinkFactory.java?rev=1056091&r1=1056090&r2=1056091&view=diff
==
--- tomcat/trunk/java/org/apache/naming/factory/DataSourceLinkFactory.java
(original)
+++ tomcat/trunk/java/org/apache/naming/factory/DataSourceLinkFactory.java Thu
Jan 6 21:38:35 2011
@@ -42,9 +42,7 @@ import org.apache.naming.ResourceLinkRef
* Object factory for resource links for shared data sources.
*
* @author Filip Hanik
- * @version $Id: ResourceLinkFactory.java 939311 2010-04-29 14:01:02Z kkolinko
$
*/
-
public class DataSourceLinkFactory extends ResourceLinkFactory
implements ObjectFactory {
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50552] Ant Tasks give a null pointer exception when an error occurs, masking true error
https://issues.apache.org/bugzilla/show_bug.cgi?id=50552 --- Comment #2 from Christopher Schultz 2011-01-06 16:39:45 EST --- A couple of comments: 1. This patch looks like it will fix the problem, though there are other options (see below) 2. Isn't this a bug in ant because it doesn't do NULL checking? 3. Does output redirection /ever/ work? AbstractCatalinaTask.execute /never/ opens the redirector (BaseRedirectorHelperTask.openRedirector), yet calls BaseRedirectorHelperTask.closeRedirector in the finally block, unconditionally. I think this can be fixed in one of several ways: 1. Use Chris Rimmer's patch 2. Modify BaseRedirectorHelperTask.closeRedirector to ensure that the streams have been opened before calling Redirector.complete 3. Have ant add null checking to Redirector.complete Finally, it probably makes sense for AbstractCatalinaTask.execute to open these redirection streams at some point, which it does not appear to be doing, hence my question #3 above. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50552] Ant Tasks give a null pointer exception when an error occurs, masking true error
https://issues.apache.org/bugzilla/show_bug.cgi?id=50552 --- Comment #3 from Christopher Schultz 2011-01-06 16:41:15 EST --- FYI I can confirm that when outputProperty is set and there are no errors, the output property /does/ get the contents of the manager task's reply. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49953] Missing @Override annotations
https://issues.apache.org/bugzilla/show_bug.cgi?id=49953 Filip Hanik changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WONTFIX --- Comment #1 from Filip Hanik 2011-01-06 16:50:37 EST --- For now the goal was to still be able to compile the core with 1.5, until that changes,we can defer this issue -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: ThreadLocal Clear References Problem
2011/1/6 Gurkan Erdogdu : > Hello folks > > Could you see the problem in > https://issues.apache.org/jira/browse/MYFACES-3006? > > Thanks for your comments! > Read all that is written at [1] and ask on the users@ list of Tomcat. It is surely not a myfaces issue (neither a "major" one if it were). It is also offtopic here on d...@. As [1] says, do not forget to mention what exact version of Tomcat you are using. [1] http://tomcat.apache.org/lists.html Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50552] Ant Tasks give a null pointer exception when an error occurs, masking true error
https://issues.apache.org/bugzilla/show_bug.cgi?id=50552
--- Comment #4 from Christopher Schultz
2011-01-06 16:58:20 EST ---
It looks like this works properly in the sunny-day scenario because
BaseRedirectorHelperTask.handleOutput is typically called, which properly opens
the redirector:
protected void handleOutput(String output) {
if (redirectOutput) {
if (redirectOutPrintStream == null) {
openRedirector();
}
redirectOutPrintStream.println(output);
if (alwaysLog) {
log(output, Project.MSG_INFO);
}
In the error case, AbstractCatalinaTask.execute does this:
if (isFailOnError()) {
throw new BuildException(e);
} else {
handleErrorOutput(e.getMessage());
}
The BuildException doesn't get caught by the currently-running exception
handler (for java.lang.Exception) and then the finally block is called, which
attempts to close the redirector, ultimately resulting in this NPE.
I believe this bug might be better solved by modifying
BaseRedirectorHelperTask.closeRedirector in this way:
try {
-if (redirectOutput) {
+if (redirectOutput && redirectOutPrintStream != null) {
redirector.complete();
}
This makes BaseRedirectorHelperTask.closeRedirector safer internally and
doesn't rely on the client (AbstractCatalinaTask, in this case) to be extra
careful about state.
Another option would be:
try {
if (redirectOutput) {
+ if (redirectOutPrintStream == null) {
+openRedirector();
+ }
redirector.complete();
}
I'm open to suggestions, since I don't really know how all this stuff should
work. I'm in favor of a solution where a class manages it's state as much as
possible rather than relying on client code (even a subclass) to be careful
about such things.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49953] Missing @Override annotations
https://issues.apache.org/bugzilla/show_bug.cgi?id=49953 --- Comment #2 from Christopher Schultz 2011-01-06 17:03:14 EST --- The @override annotation was introduced in 1.5, so this shouldn't be a problem. Did you mean 1.4? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Need for protocols and standards.
Dear Apache Tomcat Developers, I would appreciate your comments on a paper that is entitled NEED FOR PROTOCOLS AND STANDARDS FOR A DECENTRALIZED WEB SEARCH PARADIGM. ABSTRACT: This paper proposes to create a new paradigm on services for information search on the web, involving new protocols and standards. For more than one decade, the current paradigm has consisted in services that have been provided by a small number of private companies on an advertising business scheme, mainly. This concentration involves a number of risks and disadvantages to WWW users. One of the risks is the service vulnerability because of the large dependence on the infrastructure of one or two providers. Scalability might become into a concern because of the huge increasing of information on the WWW. The current paradigm also involves economical and political disadvantages because the providers decide which websites are allowed to be listed or not as well as their rankings; this can bias the search results. Therefore, this paper aims to suggest general lines for research and development for a new, global, non-for-profit, paradigm for crawling, indexing and searching information on the WWW. I hope that it can be useful to the developer community in the webserver software field. Please feel free to download it from this link: http://www.unsis.edu.mx/~coria/publications/coria_need_for_protocols_standards_15oct2010.pdf I look forward to your comments. Thanks in advance, sergio r. coria Sergio R. Coria Professor/Researcher University of the Sierra Sur (UNSIS) http://www.unsis.edu.mx/~coria/ E-mails: srco2...@yahoo.com, co...@unsis.edu.mx Mexico - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50556] New: improve JreMemoryLeakPreventionListener against leak caused by LdapPoolManager
https://issues.apache.org/bugzilla/show_bug.cgi?id=50556 Summary: improve JreMemoryLeakPreventionListener against leak caused by LdapPoolManager Product: Tomcat 7 Version: 7.0.5 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P2 Component: Catalina AssignedTo: dev@tomcat.apache.org ReportedBy: sylvain.laur...@gmail.com When class com.sun.jndi.ldap.LdapPoolManager is initialized, if if the system property com.sun.jndi.ldap.connect.pool.timeout is set to a value greater than 0, a PoolCleaner thread is spawned, without fixing a specific context class loader. If the initialization of the class is triggered by a web application, its class loader will be used by the PoolCleaner thread. If that web app is stopped, its class loader will leak. We can improve JreMemoryLeakPreventionListener to prevent that leak. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1056101 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: kkolinko Date: Thu Jan 6 22:17:58 2011 New Revision: 1056101 URL: http://svn.apache.org/viewvc?rev=1056101&view=rev Log: comment Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1056101&r1=1056100&r2=1056101&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Jan 6 22:17:58 2011 @@ -236,6 +236,11 @@ PATCHES PROPOSED TO BACKPORT: http://svn.apache.org/viewvc?view=revision&revision=1042494 +1: kkolinko 0: fhanik - don't see a need to change any line wrappings, it just causes clutter in the SVN diffs, but if it floats your boat :) + kkolinko: The above three additional patches (two by silvain and one by markt) + are trivial and IMHO qualify as CTR, so no actual need to vote for them. + I've put them here so that they are not forgotten. Is there anything else + that Mark does not like with his "-0" ? I do not see anything else + in http://markmail.org/message/mnowpijhnxg554t5 -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50413 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50556] improve JreMemoryLeakPreventionListener against leak caused by LdapPoolManager
https://issues.apache.org/bugzilla/show_bug.cgi?id=50556 --- Comment #1 from Christopher Schultz 2011-01-06 17:41:57 EST --- What are our opportunities to initialize this class before webapp code gets involved? Is this something that is safe to initialize during Tomcat startup, or will cause negative effects for the webapp(s) using LDAP services? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50556] improve JreMemoryLeakPreventionListener against leak caused by LdapPoolManager
https://issues.apache.org/bugzilla/show_bug.cgi?id=50556 --- Comment #2 from Sylvain Laurent 2011-01-06 17:48:01 EST --- the JreMemoryLeakPreventionListener is there to initialize such leaking classes. And yes, it is safe to initialize com.sun.jndi.ldap.LdapPoolManager during tomcat startup. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50556] improve JreMemoryLeakPreventionListener against leak caused by LdapPoolManager
https://issues.apache.org/bugzilla/show_bug.cgi?id=50556 --- Comment #3 from Christopher Schultz 2011-01-06 17:55:20 EST --- (In reply to comment #2) > the JreMemoryLeakPreventionListener is there to initialize such leaking > classes. Yup, I've worked on it. > And yes, it is safe to initialize com.sun.jndi.ldap.LdapPoolManager during > tomcat startup. Excellent: just initialize the class inside of the CTTL push/pop that's already in there and you should be okay. I guess you'd only have to do it if com.sun.jndi.ldap.connect.pool.timeout > 0, though system properties can be changed at runtime, so it might be a good idea to temporarily set it to 1 if it's currently 0, init the class, then set it back. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49557] index erro in the loop to get the env info in the proc.create function
https://issues.apache.org/bugzilla/show_bug.cgi?id=49557 Konstantin Kolinko changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #2 from Konstantin Kolinko 2011-01-06 18:15:41 EST --- He tries to launch an external program with a Proc.create() call, I think. I see two problems in the current implementation of Proc::create in proc.c of native 1.1: 1) if (env) es = (*e)->GetArrayLength(e, args); calculates the length of the "args" array, where "env" array is expected. I think it is the actual cause of access violation error. 2) s_env[i+1] = tcn_get_string(e, str); as OP noted, should be s_env[i] = tcn_get_string(e, str); Note, that if the "[i+1]" in the code were correct, there is s_env[i++] = apr_psprintf(p, TCN_PARENT_IDE "=%d", getpid()); assignment later, that will overwrite the last env. variable value in that case. This is probably not an error: I see a cycle of free() calls to clear calls for s_env values. I do not see a free() call for the value assigned with s_env[i++] = apr_psprintf(p, TCN_PARENT_IDE "=%d", getpid()); Probably that is not needed, because it was allocated from a pool? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49557] index erro in the loop to get the env info in the proc.create function
https://issues.apache.org/bugzilla/show_bug.cgi?id=49557 --- Comment #3 from Konstantin Kolinko 2011-01-06 18:17:54 EST --- Created an attachment (id=26464) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26464) Patch for proc.c of native/1.1.x. (not tested) -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49953] Missing @Override annotations
https://issues.apache.org/bugzilla/show_bug.cgi?id=49953 Sebb changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|WONTFIX | --- Comment #3 from Sebb 2011-01-06 18:36:44 EST --- Note that jdbc does not currently compile with Java 1.5, because several files use @Override annotations for implementations of interface methods. Such overrides require Java 1.6. Both Java 1.5 and Java 1.6 support @Override annotations for "true" method overrides. So I don't see why the proposed patch cannot be applied, as it will work with both Java 1.5 and 1.6. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Tomcat Wiki] Update of "HowTo" by Roger Mbiama Assogo
Dear Wiki user,
You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change
notification.
The "HowTo" page has been changed by Roger Mbiama Assogo.
http://wiki.apache.org/tomcat/HowTo?action=diff&rev1=95&rev2=96
--
index.jsp
}}}
- The default servlet attempts to load the `index.*` files in the order listed.
You may easily override the `index.jsp` file by creating an index.html file at
`$TOMCAT_HOME/webapps/ROOT`. It's somewhat common for that file to contain a
new static home page or a redirect to a servlet's main page. A redirect would
look like:
+ The default servlet attempts to load the `index.*` files in the order listed.
You may easily override the `index.jsp` file by creating an index.html file at
`$TOMCAT_HOME/angosso.net/ROOT`. It's somewhat common for that file to contain
a new static home page or a redirect to a servlet's main page. A redirect would
look like:
{{{
- http://mydomain.com/some/path/to/servlet/homepage/";>
+ http://angosso.net/some/path/to/servlet/homepage/";>
@@ -442, +442 @@
* Enter the following in myapp.xml:
{{{
-
+
}}}
- . This assumes you have a web application containing WEB-INF in
'''c:/workspace/myapp/WebRoot'''
+ . This assumes you have a web application containing WEB-INF in
'''c:/workspace/angosso.net/WebRoot'''
* Create two environment variables:
@@ -628, +628 @@
1. Copy ''c:\temp\apache-tomcat-5.5.17\conf\Catalina\localhost\admin.xml''
to the directory ''c:\Program Files\Apache Software Foundation\Tomcat
5.5\conf\Catalina\localhost''.
- 1. Copy the entire directory tree
''c:\temp\apache-tomcat-5.5.17\server\webapps\admin''
+ 1. Copy the entire directory tree
''c:\temp\apache-tomcat-5.5.17\server\angosso.net\admin''
to the directory ''c:\Program Files\Apache Software Foundation\Tomcat
5.5\server\webapps''. This is an overlay, so \server\webapps is just pointing
you to the \server\webapps, and the admin directory with its contents will be
the only thing you see added there.
@@ -679, +679 @@
import java.io.IOException;
import java.io.OutputStream;
import java.net.Socket;
- import javax.xml.parsers.DocumentBuilderFactory;
+ import javax.xml.parsers.AngossoBuilderFactory;
import javax.xml.parsers.ParserConfigurationException;
import org.w3c.dom.Document;
import org.w3c.dom.Element;
@@ -830, +830 @@
and Google and Yahoo are your friends.
== How do I make my web application be the Tomcat default application ? ==
- Congratulations. You have created and tested a first web application
(traditionally called "mywebapp"), users can access it via the URL
"http://myhost.company.com/mywebapp";. You are very proud and satisfied. But
now, how do you change the setup, so that "mywebapp" gets called when the user
enters the URL "http://myhost.company.com"; ?
+ Congratulations. You have created and tested a first web application
(traditionally called "mywebapp"), users can access it via the URL
"http://www.angosso.net/mywebapp";. You are very proud and satisfied. But
now, how do you change the setup, so that "mywebapp" gets called when the user
enters the URL "http://www.angosso.net"; ?
- The pages and code of your "mywebapp" application currently reside in
(CATALINA_BASE)/webapps/mywebapp/. In a standard Tomcat installation, you will
notice that under the same directory (CATALINA_BASE)/webapps/, there is a
directory called ROOT (the capitals are important, even under Windows). That
is the residence of the ''current'' Tomcat default application, the one that is
called right now when a user calls up "http://myhost.company.com[:port]";. The
trick is to put your application in its place.
+ The pages and code of your "Angosso" application currently reside in
(CATALINA_BASE)/www/angosso/default.aspx In a standard Tomcat installation, you
will notice that under the same directory (CATALINA_BASE)/angosso.net/, there
is a directory called ROOT (the capitals are important, even under Windows).
That is the residence of the ''current'' Tomcat default application, the one
that is called right now when a user calls up "http://www.angosso.net[:8080]";.
The trick is to put your application in its place.
- First stop Tomcat.<> Then before you replace the current default
application, it may be a good idea to make a copy of it somewhere else.<>
Then delete everything under the ROOT directory, and move everything that was
previously under the (CATALINA_BASE)/webapps/mywebapp/ directory, toward this
(CATALINA_BASE)/webapps/ROOT directory. In other words, what was previously
.../mywebapp/WEB-INF should now be .../ROOT/WEB-INF (and not
.../ROOT/mywebapp/WEB-INF).
+ First stop Tomcat.<> Then before you replace the current default
application, it may be a good idea to make a copy of it somewhere else.<>
Then delete everything under the ROOT directory, and move everything that
svn commit: r1056125 - in /tomcat/trunk/modules/jdbc-pool: .classpath java/org/apache/tomcat/jdbc/pool/ConnectionPool.java test/org/apache/tomcat/jdbc/test/Async0IdleTestBug50477.java
Author: fhanik
Date: Thu Jan 6 23:53:11 2011
New Revision: 1056125
URL: http://svn.apache.org/viewvc?rev=1056125&view=rev
Log:
Fix bug https://issues.apache.org/bugzilla/show_bug.cgi?id=50477
Added:
tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/Async0IdleTestBug50477.java
(with props)
Modified:
tomcat/trunk/modules/jdbc-pool/.classpath
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
Modified: tomcat/trunk/modules/jdbc-pool/.classpath
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/.classpath?rev=1056125&r1=1056124&r2=1056125&view=diff
==
--- tomcat/trunk/modules/jdbc-pool/.classpath (original)
+++ tomcat/trunk/modules/jdbc-pool/.classpath Thu Jan 6 23:53:11 2011
@@ -6,5 +6,6 @@
+
Modified:
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java?rev=1056125&r1=1056124&r2=1056125&view=diff
==
---
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
(original)
+++
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
Thu Jan 6 23:53:11 2011
@@ -140,6 +140,10 @@ public class ConnectionPool {
* @throws SQLException
*/
public Future getConnectionAsync() throws SQLException {
+PooledConnection pc = this.borrowConnection(0, null, null);
+if (pc!=null) {
+return new ConnectionFuture(pc);
+}
//we can only retrieve a future if the underlying queue supports it.
if (idle instanceof FairBlockingQueue) {
Future pcf =
((FairBlockingQueue)idle).pollAsync();
@@ -1040,15 +1044,21 @@ public class ConnectionPool {
Connection result = null;
SQLException cause = null;
AtomicBoolean cancelled = new AtomicBoolean(false);
+volatile PooledConnection pc = null;
public ConnectionFuture(Future pcf) {
this.pcFuture = pcf;
}
+public ConnectionFuture(PooledConnection pc) {
+this.pc = pc;
+}
/**
* {...@inheritdoc}
*/
public boolean cancel(boolean mayInterruptIfRunning) {
-if ((!cancelled.get()) && cancelled.compareAndSet(false, true)) {
+if (pc!=null) {
+return false;
+} else if ((!cancelled.get()) && cancelled.compareAndSet(false,
true)) {
//cancel by retrieving the connection and returning it to the
pool
ConnectionPool.this.cancellator.execute(this);
}
@@ -1070,7 +1080,7 @@ public class ConnectionPool {
* {...@inheritdoc}
*/
public Connection get(long timeout, TimeUnit unit) throws
InterruptedException, ExecutionException, TimeoutException {
-PooledConnection pc = pcFuture.get(timeout,unit);
+PooledConnection pc =
this.pc!=null?this.pc:pcFuture.get(timeout,unit);
if (pc!=null) {
if (result!=null) return result;
if (configured.compareAndSet(false, true)) {
@@ -1097,14 +1107,14 @@ public class ConnectionPool {
* {...@inheritdoc}
*/
public boolean isCancelled() {
-return pcFuture.isCancelled() || cancelled.get();
+return pc==null && (pcFuture.isCancelled() || cancelled.get());
}
/**
* {...@inheritdoc}
*/
public boolean isDone() {
-return pcFuture.isDone();
+return pc!=null || pcFuture.isDone();
}
/**
Added:
tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/Async0IdleTestBug50477.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/Async0IdleTestBug50477.java?rev=1056125&view=auto
==
---
tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/Async0IdleTestBug50477.java
(added)
+++
tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/Async0IdleTestBug50477.java
Thu Jan 6 23:53:11 2011
@@ -0,0 +1,50 @@
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by ap
DO NOT REPLY [Bug 50477] If you set 0 to initialSize, can't obtain Connection by using getConnectionAsync method.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50477 Filip Hanik changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #1 from Filip Hanik 2011-01-06 18:54:09 EST --- Thank you for the report. Sorry for the delay. Fixed in revision http://svn.apache.org/viewvc?view=revision&revision=1056125 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Tomcat Wiki] Update of "Roger Mbiama Assogo" by Roger Mbiama Assogo
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "Roger Mbiama Assogo" page has been changed by Roger Mbiama Assogo. http://wiki.apache.org/tomcat/Roger%20Mbiama%20Assogo -- New page: ##language:fr == Roger == Email: <> ... CategoryHomepage - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
HowTo reverted to revision 95 on Tomcat Wiki
Dear wiki user,
You have subscribed to a wiki page "Tomcat Wiki" for change notification.
The page HowTo has been reverted to revision 95 by ChuckCaldarale.
The comment on this change is: Spam removal..
http://wiki.apache.org/tomcat/HowTo?action=diff&rev1=96&rev2=97
--
index.jsp
}}}
- The default servlet attempts to load the `index.*` files in the order listed.
You may easily override the `index.jsp` file by creating an index.html file at
`$TOMCAT_HOME/angosso.net/ROOT`. It's somewhat common for that file to contain
a new static home page or a redirect to a servlet's main page. A redirect would
look like:
+ The default servlet attempts to load the `index.*` files in the order listed.
You may easily override the `index.jsp` file by creating an index.html file at
`$TOMCAT_HOME/webapps/ROOT`. It's somewhat common for that file to contain a
new static home page or a redirect to a servlet's main page. A redirect would
look like:
{{{
- http://angosso.net/some/path/to/servlet/homepage/";>
+ http://mydomain.com/some/path/to/servlet/homepage/";>
@@ -442, +442 @@
* Enter the following in myapp.xml:
{{{
-
+
}}}
- . This assumes you have a web application containing WEB-INF in
'''c:/workspace/angosso.net/WebRoot'''
+ . This assumes you have a web application containing WEB-INF in
'''c:/workspace/myapp/WebRoot'''
* Create two environment variables:
@@ -628, +628 @@
1. Copy ''c:\temp\apache-tomcat-5.5.17\conf\Catalina\localhost\admin.xml''
to the directory ''c:\Program Files\Apache Software Foundation\Tomcat
5.5\conf\Catalina\localhost''.
- 1. Copy the entire directory tree
''c:\temp\apache-tomcat-5.5.17\server\angosso.net\admin''
+ 1. Copy the entire directory tree
''c:\temp\apache-tomcat-5.5.17\server\webapps\admin''
to the directory ''c:\Program Files\Apache Software Foundation\Tomcat
5.5\server\webapps''. This is an overlay, so \server\webapps is just pointing
you to the \server\webapps, and the admin directory with its contents will be
the only thing you see added there.
@@ -679, +679 @@
import java.io.IOException;
import java.io.OutputStream;
import java.net.Socket;
- import javax.xml.parsers.AngossoBuilderFactory;
+ import javax.xml.parsers.DocumentBuilderFactory;
import javax.xml.parsers.ParserConfigurationException;
import org.w3c.dom.Document;
import org.w3c.dom.Element;
@@ -830, +830 @@
and Google and Yahoo are your friends.
== How do I make my web application be the Tomcat default application ? ==
- Congratulations. You have created and tested a first web application
(traditionally called "mywebapp"), users can access it via the URL
"http://www.angosso.net/mywebapp";. You are very proud and satisfied. But
now, how do you change the setup, so that "mywebapp" gets called when the user
enters the URL "http://www.angosso.net"; ?
+ Congratulations. You have created and tested a first web application
(traditionally called "mywebapp"), users can access it via the URL
"http://myhost.company.com/mywebapp";. You are very proud and satisfied. But
now, how do you change the setup, so that "mywebapp" gets called when the user
enters the URL "http://myhost.company.com"; ?
- The pages and code of your "Angosso" application currently reside in
(CATALINA_BASE)/www/angosso/default.aspx In a standard Tomcat installation, you
will notice that under the same directory (CATALINA_BASE)/angosso.net/, there
is a directory called ROOT (the capitals are important, even under Windows).
That is the residence of the ''current'' Tomcat default application, the one
that is called right now when a user calls up "http://www.angosso.net[:8080]";.
The trick is to put your application in its place.
+ The pages and code of your "mywebapp" application currently reside in
(CATALINA_BASE)/webapps/mywebapp/. In a standard Tomcat installation, you will
notice that under the same directory (CATALINA_BASE)/webapps/, there is a
directory called ROOT (the capitals are important, even under Windows). That
is the residence of the ''current'' Tomcat default application, the one that is
called right now when a user calls up "http://myhost.company.com[:port]";. The
trick is to put your application in its place.
- First stop Tomcat.<> Then before you replace the current default
application, it may be a good idea to make a copy of it somewhere else.<>
Then delete everything under the ROOT directory, and move everything that was
previously under the (CATALINA_BASE)/angosso.net/default.aspx/ directory,
toward this (CATALINA_BASE)/angosso.net/ROOT directory. In other words, what
was previously .../angosso.net/WEB-INF should now be .../ROOT/WEB-INF (and not
.../ROOT/mywebapp/WEB-INF).
+ First stop Tomcat.<> Then before you replace the current default
application, it may be a good idea to make a copy of it somewhere else.<>
Then delete everything un
Page Roger Mbiama Assogo deleted from Tomcat Wiki
Dear wiki user, You have subscribed to a wiki page "Tomcat Wiki" for change notification. The page "Roger Mbiama Assogo" has been deleted by ChuckCaldarale. The comment on this change is: Spam removal.. http://wiki.apache.org/tomcat/Roger%20Mbiama%20Assogo - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49953] Missing @Override annotations
https://issues.apache.org/bugzilla/show_bug.cgi?id=49953
Filip Hanik changed:
What|Removed |Added
Status|REOPENED|RESOLVED
Resolution||LATER
--- Comment #4 from Filip Hanik 2011-01-06 18:59:36 EST ---
Not true
public interface Itest {
public void foo();
}
public class test implements Itest {
@Override
public void foo() {
}
}
will not compile in Java 5
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Tomcat Wiki] Update of "CategoryHomepage" by Roger Mbi ama Assogo
Dear Wiki user,
You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change
notification.
The "CategoryHomepage" page has been changed by Roger Mbiama Assogo.
http://wiki.apache.org/tomcat/CategoryHomepage?action=diff&rev1=2&rev2=3
--
##language:en
- A category for WikiHomePage''s.
+ A category for WikiHomePage'''Angosso'''s.
Note that such pages are "owned" by the respective person, and should not be
edited by others, except to leave a message to that person. To do so, just
append your message to the page, after four dashes like so:
{{{
- Just saying Hi! -- JürgenHermann
+ Just saying Hi! -- Mbiama
}}}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
CategoryHomepage reverted to revision 2 on Tomcat Wiki
Dear wiki user,
You have subscribed to a wiki page "Tomcat Wiki" for change notification.
The page CategoryHomepage has been reverted to revision 2 by ChuckCaldarale.
The comment on this change is: Spam removal..
http://wiki.apache.org/tomcat/CategoryHomepage?action=diff&rev1=3&rev2=4
--
##language:en
- A category for WikiHomePage'''Angosso'''s.
+ A category for WikiHomePage''s.
Note that such pages are "owned" by the respective person, and should not be
edited by others, except to leave a message to that person. To do so, just
append your message to the page, after four dashes like so:
{{{
- Just saying Hi! -- Mbiama
+ Just saying Hi! -- JürgenHermann
}}}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: DO NOT REPLY [Bug 48253] Tomcat Native patch - adding dynamic locking callbacks for openssl engines
On 1:59 PM, bugzi...@apache.org wrote: https://issues.apache.org/bugzilla/show_bug.cgi?id=48253 jfclere changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED Forgive me, but I did not see any notes added to this bug. Does this mean the patch as submitted has been implemented or has a different patch/update resolved the same issue? I'm not too familiar with how the Tomcat project implements these updates as I spend most of my time on the d...@httpd.apache.org list and have had an eye on this bug report for some time now. -- Daniel Ruggeri - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Tomcat Wiki] Update of "JNDI_HowTo" by Roger Mbiama Assogo
Dear Wiki user,
You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change
notification.
The "JNDI_HowTo" page has been changed by Roger Mbiama Assogo.
http://wiki.apache.org/tomcat/JNDI_HowTo?action=diff&rev1=5&rev2=6
--
- ##language:en
+ ##language:fr
== Lotus Domino ==
{{{
ldap://ldap.company.com:389";
+connectionURL="ldap://ldap.Angosso.net:389";
-roleSearch="(member={0})"
+roleSearch="(member={0})"
roleName="cn"
userSearch="(cn={0})" />
}}}
-
== Oracle Internet Directory (OID) ==
{{{
ldap://ldap.company.com:389";
+connectionURL="ldap://ldap.angosso.net:389";
-roleBase="cn=Groups,dc=company,dc=com"
+roleBase="cn=Groups,dc=angosso,dc=com"
-roleSearch="(uniquemember={0})"
+roleSearch="(uniquemember={0})"
roleName="cn"
-userBase="cn=Users,dc=company,dc=com"
+userBase="cn=Users,dc=angosso,dc=com"
userSearch="(uid={0})" />
}}}
-
== Microsoft Active Directory ==
{{{
ldap://ldap.company.com:3268";
+connectionURL="ldap://ldap.angosso.net:3268";
-authentication="simple"
+authentication="http://www.angosso.net/default.aspx";
referrals="follow"
-connectionName="cn=LDAPUser,ou=Service Accounts,dc=company,dc=com"
+connectionName="cn=LDAPUser,ou=Service Accounts,dc=angosso,dc=com"
-connectionPassword="VerySecretPassword"
+connectionPassword="VerySecretPassword"
userSearch="(sAMAccountName={0})"
-userBase="dc=company,dc=com"
+userBase="dc=angosso,dc=com"
userSubtree="true"
-roleSearch="(member={0})"
+roleSearch="(member={0})"
-roleName="cn"
+roleName="cn"
roleSubtree="true"
-roleBase="dc=company,dc=com" />
+roleBase="dc=angosso,dc=net" />
}}}
-
- The port number (3268) connects to the global catalog. This is important
because 389 might throw errors when getting referrals. (It sends a referral to
ldap://company.com:389.) With this setting we don't have to change anything in
/etc/hosts.
+ The port number (3268) connects to the global catalog. This is important
because 389 might throw errors when getting referrals. (It sends a referral to
ldap://angosso.net:389.) With this setting we don't have to change anything in
/etc/hosts.
For a reference on startTLS, see Self:JNDI_startTLs_HowTo
- [[CategoryFAQ|CategoryFAQ]]
+ [[CategoryFAQ]]
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Tomcat Wiki] Trivial Update of "HowTo" by KonstantinKo linko
Dear Wiki user,
You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change
notification.
The "HowTo" page has been changed by KonstantinKolinko.
The comment on this change is: Correct a typo.
http://wiki.apache.org/tomcat/HowTo?action=diff&rev1=97&rev2=98
--
* Enter the following in myapp.xml:
{{{
-
+
}}}
. This assumes you have a web application containing WEB-INF in
'''c:/workspace/myapp/WebRoot'''
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
JNDI_HowTo reverted to revision 5 on Tomcat Wiki
Dear wiki user,
You have subscribed to a wiki page "Tomcat Wiki" for change notification.
The page JNDI_HowTo has been reverted to revision 5 by KonstantinKolinko.
The comment on this change is: Revert spam.
http://wiki.apache.org/tomcat/JNDI_HowTo?action=diff&rev1=6&rev2=7
--
- ##language:fr
+ ##language:en
== Lotus Domino ==
{{{
ldap://ldap.Angosso.net:389";
+connectionURL="ldap://ldap.company.com:389";
-roleSearch="(member={0})"
+roleSearch="(member={0})"
roleName="cn"
userSearch="(cn={0})" />
}}}
+
== Oracle Internet Directory (OID) ==
{{{
ldap://ldap.angosso.net:389";
+connectionURL="ldap://ldap.company.com:389";
-roleBase="cn=Groups,dc=angosso,dc=com"
+roleBase="cn=Groups,dc=company,dc=com"
-roleSearch="(uniquemember={0})"
+roleSearch="(uniquemember={0})"
roleName="cn"
-userBase="cn=Users,dc=angosso,dc=com"
+userBase="cn=Users,dc=company,dc=com"
userSearch="(uid={0})" />
}}}
+
== Microsoft Active Directory ==
{{{
ldap://ldap.angosso.net:3268";
+connectionURL="ldap://ldap.company.com:3268";
-authentication="http://www.angosso.net/default.aspx";
+authentication="simple"
referrals="follow"
-connectionName="cn=LDAPUser,ou=Service Accounts,dc=angosso,dc=com"
+connectionName="cn=LDAPUser,ou=Service Accounts,dc=company,dc=com"
-connectionPassword="VerySecretPassword"
+connectionPassword="VerySecretPassword"
userSearch="(sAMAccountName={0})"
-userBase="dc=angosso,dc=com"
+userBase="dc=company,dc=com"
userSubtree="true"
-roleSearch="(member={0})"
+roleSearch="(member={0})"
-roleName="cn"
+roleName="cn"
roleSubtree="true"
-roleBase="dc=angosso,dc=net" />
+roleBase="dc=company,dc=com" />
}}}
+
- The port number (3268) connects to the global catalog. This is important
because 389 might throw errors when getting referrals. (It sends a referral to
ldap://angosso.net:389.) With this setting we don't have to change anything in
/etc/hosts.
+ The port number (3268) connects to the global catalog. This is important
because 389 might throw errors when getting referrals. (It sends a referral to
ldap://company.com:389.) With this setting we don't have to change anything in
/etc/hosts.
For a reference on startTLS, see Self:JNDI_startTLs_HowTo
- [[CategoryFAQ]]
+ [[CategoryFAQ|CategoryFAQ]]
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49953] Missing @Override annotations
https://issues.apache.org/bugzilla/show_bug.cgi?id=49953
Sebb changed:
What|Removed |Added
Status|RESOLVED|REOPENED
Resolution|LATER |
--- Comment #5 from Sebb 2011-01-06 20:06:49 EST ---
(In reply to comment #4)
> Not true
>
> public interface Itest {
> public void foo();
> }
>
> public class test implements Itest {
> @Override
> public void foo() {
> }
> }
>
> will not compile in Java 5
Exactly, overrides of interface methods require Java 1.6.
This is the case for many of the existing @Overrides in DataSourceProxy,
PoolProperties and ConnectionPool and others, which is one of the reasons jdbc
pool won't compile currently with Java 5.
Does this mean that those @Overrides should be removed?
However, AFAICT the patch only adds overrides for methods which override
superclass methods, so will compile with Java 1.5.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Page MAARB_HowTo deleted from Tomcat Wiki
Dear wiki user, You have subscribed to a wiki page "Tomcat Wiki" for change notification. The page "MAARB_HowTo" has been deleted by KonstantinKolinko. The comment on this change is: Delete this spam-infested copy of JNDI_HowTo. The original JNDI_HowTo is still in place.. http://wiki.apache.org/tomcat/MAARB_HowTo - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1056155 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: kfujino Date: Fri Jan 7 01:43:22 2011 New Revision: 1056155 URL: http://svn.apache.org/viewvc?rev=1056155&view=rev Log: my votes Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1056155&r1=1056154&r2=1056155&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Fri Jan 7 01:43:22 2011 @@ -246,7 +246,7 @@ PATCHES PROPOSED TO BACKPORT: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50413 Ensure 304s are not returned when using static files as error pages http://people.apache.org/~markt/patches/2011-01-04-bug50413-tc6.patch - +1: markt, jfclere + +1: markt, jfclere, kfujino -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48822 @@ -266,19 +266,19 @@ PATCHES PROPOSED TO BACKPORT: Use correct coercions for EL arithmetic operations. Based on a patch by Brian Weisleder http://svn.apache.org/viewvc?rev=1055055&view=rev - +1: markt, fhanik + +1: markt, fhanik, kfujino -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50527 Improve error message http://svn.apache.org/viewvc?rev=1055236&view=rev - +1: markt, jfclere, fhanik + +1: markt, jfclere, fhanik, kfujino -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50467 Avoid NOE that causes NIO poller to fail http://svn.apache.org/viewvc?rev=1055458&view=rev - +1: markt + +1: markt, kfujino +1: fhanik - fix indentation -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1056166 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: funkman Date: Fri Jan 7 02:18:15 2011 New Revision: 1056166 URL: http://svn.apache.org/viewvc?rev=1056166&view=rev Log: some +1's Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1056166&r1=1056165&r2=1056166&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Fri Jan 7 02:18:15 2011 @@ -62,7 +62,7 @@ PATCHES PROPOSED TO BACKPORT: resources already present in the webapp. http://svn.apache.org/viewvc?view=revision&revision=936825 http://people.apache.org/~rjung/patches/2010-05-14-loader-backport-r936825.patch - +1: rjung + +1: rjung, funkman -1: -0: kkolinko: The patch itself is OK, but I think having a synonym will cause confusion. I'd prefer not to invent a new name, but mention the @@ -74,7 +74,7 @@ PATCHES PROPOSED TO BACKPORT: http://svn.apache.org/viewvc?rev=961948&view=rev http://svn.apache.org/viewvc?rev=963106&view=rev http://svn.apache.org/viewvc?rev=966863&view=rev - +1: markt, kkolinko + +1: markt, kkolinko,funkman -1: kkolinko: I was worried that ELFunctionMapper$PrivilegedGetTccl should be preloaded in o.a.jasper.security.SecurityClassLoad, @@ -95,7 +95,7 @@ PATCHES PROPOSED TO BACKPORT: http://svn.apache.org/viewvc?rev=1004415&view=rev http://svn.apache.org/viewvc?rev=1004912&view=rev (fix for includes) +1: timw - +1: markt, kkolinko if http://svn.apache.org/viewvc?rev=1033897&view=rev + +1: markt, kkolinko,funkman if http://svn.apache.org/viewvc?rev=1033897&view=rev is also applied -1: @@ -226,7 +226,7 @@ PATCHES PROPOSED TO BACKPORT: Improve JreMemoryLeakPreventionListener to load javax.security.auth.login.Configuration to avoid redeployment leak. http://svn.apache.org/viewvc?rev=1042029&view=rev - +1: slaurent, kkolinko + +1: slaurent, kkolinko, funkman -0: markt - See http://markmail.org/message/mnowpijhnxg554t5 -1: @@ -285,30 +285,30 @@ PATCHES PROPOSED TO BACKPORT: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50453 Correct handle multiple X-Forwarded-For headers in RemoteIpValve http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/RemoteIpValve.java?r1=1055482&r2=1055481&pathrev=1055482 - +1: markt, fhanik + +1: markt, fhanik, funkman -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50547 Add time stamp for CHANGE_SESSION_ID and SESSION_EXPIRED message. http://svn.apache.org/viewvc?view=revision&revision=1055798 - +1: kfujino, fhanik + +1: kfujino, fhanik, funkman -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47319 Return IP address rather than null for getRemoteHost() and the APR connector http://people.apache.org/~markt/patches/2011-01-06-bug47319-tc6.patch - +1: markt, fhanik + +1: markt, fhanik, funkman -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50550 Requests for a newly created directory using MKCOL should not result in a 404 http://svn.apache.org/viewvc?rev=1055975&view=rev - +1: markt + +1: markt, funkman +1: fhanik - what does the boolean 'result' signify if the first unload() is false, and the second is true? -1: * Add helper class to allow a shared data source with different credentials http://svn.apache.org/viewvc?view=revision&revision=1055989 - +1: fhanik + +1: fhanik, funkman -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49556] the proc.create function used args as env to get the element count,
https://issues.apache.org/bugzilla/show_bug.cgi?id=49556 Konstantin Kolinko changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution||DUPLICATE --- Comment #2 from Konstantin Kolinko 2011-01-06 21:22:50 EST --- I mentioned it in https://issues.apache.org/bugzilla/show_bug.cgi?id=49557#c2 Let's use bug 49557 to track the issues in proc.create *** This bug has been marked as a duplicate of bug 49557 *** -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49557] index erro in the loop to get the env info in the proc.create function
https://issues.apache.org/bugzilla/show_bug.cgi?id=49557 --- Comment #4 from Konstantin Kolinko 2011-01-06 21:22:50 EST --- *** Bug 49556 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50557] New: Tomcat , Comet - Writes are getting blocked some time
https://issues.apache.org/bugzilla/show_bug.cgi?id=50557 Summary: Tomcat , Comet - Writes are getting blocked some time Product: Tomcat 6 Version: 6.0.20 Platform: PC OS/Version: Windows XP Status: NEW Severity: blocker Priority: P2 Component: Connectors AssignedTo: dev@tomcat.apache.org ReportedBy: nilimaj...@indigotx.com We are using Tomcat Comet Implementation for Stock Rates Streaming. We have taken care of all Synchronizing issues.. Sometimes , the Writer.Write gets blocked for about 2 minutes too Why does this block happen even when we have used NIO Http connector? Is there any way to time out? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
