https://issues.apache.org/bugzilla/show_bug.cgi?id=50552

--- Comment #2 from Christopher Schultz <ch...@christopherschultz.net> 
2011-01-06 16:39:45 EST ---
A couple of comments:

1. This patch looks like it will fix the problem, though there are other
options (see below)
2. Isn't this a bug in ant because it doesn't do NULL checking?
3. Does output redirection /ever/ work?

AbstractCatalinaTask.execute /never/ opens the redirector
(BaseRedirectorHelperTask.openRedirector), yet calls
BaseRedirectorHelperTask.closeRedirector in the finally block, unconditionally.

I think this can be fixed in one of several ways:

1. Use Chris Rimmer's patch
2. Modify BaseRedirectorHelperTask.closeRedirector to ensure that the streams
have been opened before calling Redirector.complete
3. Have ant add null checking to Redirector.complete

Finally, it probably makes sense for AbstractCatalinaTask.execute to open these
redirection streams at some point, which it does not appear to be doing, hence
my question #3 above.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to