DO NOT REPLY [Bug 49657] New: In CGI Mode, "executable" full path with spaces does not work
https://issues.apache.org/bugzilla/show_bug.cgi?id=49657 Summary: In CGI Mode, "executable" full path with spaces does not work Product: Tomcat 6 Version: 6.0.29 Platform: PC OS/Version: Windows Server 2003 Status: NEW Severity: normal Priority: P2 Component: Catalina AssignedTo: dev@tomcat.apache.org ReportedBy: jean.de.rat...@atempo.com In CGI mode, if you specify a full path for a command, containing blank, it does not work example : executable c:\Tools\mycommand is OK but executable c:\Program Files\mycommand does not work well with error like 7 juil. 2010 15:51:52 org.apache.catalina.core.ApplicationContext log INFO: cgi: runCGI (stderr):'C:\Program' is not recognized as an internal or external command, Need probably to add " in for cgiExcecutable in CGIServlet.java, like it is done for CmdAndArgs -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r966613 - in /tomcat/trunk: build.xml test/org/apache/catalina/startup/TestTomcatSSL.java test/org/apache/catalina/startup/TomcatBaseTest.java webapps/docs/changelog.xml
On 28.07.2010 07:44, Mladen Turk wrote: On 07/27/2010 08:00 PM, Mark Thomas wrote: What happens if you disable the terminateAPR call? Thanks. That was it. I changed the point where that was called and that fixed it although it did then highlight a huge delay (~30s) to shutdown the connector. I've got to the bottom of that too and am currently testing a patch. One other reason for a potential core on shutdown is the accept call. I did however some nasty tricks to prevent that directly in native, but the bottom line is that acceptor should be broken before its pool gets destroyed. With APR 1.4.x there is a new pool pre-cleanup hook that would allow to effectively handle those situations, but it would also mean that native won't work on pre 1.4.x APR's If it is important, we could use that for TC 7 using a newer tcnative branch? Regards, Rainer - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r966613 - in /tomcat/trunk: build.xml test/org/apache/catalina/startup/TestTomcatSSL.java test/org/apache/catalina/startup/TomcatBaseTest.java webapps/docs/changelog.xml
On 07/28/2010 10:23 AM, Rainer Jung wrote: With APR 1.4.x there is a new pool pre-cleanup hook that would allow to effectively handle those situations, but it would also mean that native won't work on pre 1.4.x APR's If it is important, we could use that for TC 7 using a newer tcnative branch? Well, actually I introduced the pre-cleanups with APR 1.3.x, so we would need to increase the dependency to that APR version. Newer branch would be appropriate only with APR 2.x dependency in which case our native void be tcnative-2 not tcnative-1 thought. Using pre-cleanups wouldn't require the api change, so even tcnative-1 with pre 1.3.x APR would work (in some cases performing core on shutdown obviously) Regards -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[g...@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test has an issue affecting its community integration. This issue affects 1 projects. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-trunk-test : Java Servlet 3.0, Java Server Pages 2.2 & Expression Languag... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on tomcat-trunk-dbcp exists, no need to add for property tomcat-dbcp-src.jar. -DEBUG- Dependency on commons-daemon exists, no need to add for property commons-daemon.native.src.tgz. -DEBUG- Dependency on commons-daemon exists, no need to add for property tomcat-native.tar.gz. -DEBUG- Dependency on tomcat-trunk-dbcp exists, no need to add for property tomcat-dbcp.home. -INFO- Failed with reason build failed -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-trunk/output/build/logs The following work was performed: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/gump_work/build_tomcat-trunk_tomcat-trunk-test.html Work Name: build_tomcat-trunk_tomcat-trunk-test (Type: Build) Work ended in a state of : Failed Elapsed: 6 mins 49 secs Command Line: /usr/lib/jvm/java-6-sun/bin/java -Djava.awt.headless=true org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Dbuild.sysclasspath=only -Djunit.jar=/srv/gump/public/workspace/junit/dist/junit-28072010.jar -Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-28072010-native-src.tar.gz -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-28072010-native-src.tar.gz -Dexamples.sources.skip=true -Dtomcat-dbcp.home=/srv/gump/public/workspace/tomcat-trunk/tomcat-deps -Djdt.jar=/srv/gump/packages/eclipse/plugins/org.eclipse.jdt.core_3.4.2/jdtcore.jar -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-28072010.jar -Dtomcat-dbcp-src.jar=/srv/gump/public/workspace/tomcat-trunk/tomcat-deps/tomcat-dbcp-src.jar -Dcommons-pool.home=/srv/gump/public/workspace/apache-commons/pool -Dcommons-dbcp.home=/srv/gump/public/workspa ce/apache-commons/dbcp -Dcheckstyle.jar=/srv/gump/public/workspace/checkstyle/target/dist/checkstyle-28072010/checkstyle-all-28072010.jar -Dtomcat-dbcp.jar=/srv/gump/public/workspace/tomcat-trunk/tomcat-deps/tomcat-dbcp-28072010.jar test [Working Directory: /srv/gump/public/workspace/tomcat-trunk] CLASSPATH: /usr/lib/jvm/java-6-sun/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/packages/junit3.8.1/junit.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.jar:/srv/gum p/public/workspace/tomcat-trunk/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-util.jar:/srv/gump/packages/javamail-1.4/mail.jar:/srv/gump/packages/javamail-1.4/lib/mailapi.jar:/srv/gump/packages/jaf-1.1ea/activation.jar:/srv/gump/packages/eclipse/plugins/org.eclipse.jdt.core_3.4.2/jdtcore.jar: /srv/gump/public/workspace/tomcat-trunk/tomcat-deps/tomcat-dbcp-28072010.jar:/srv/
svn commit: r980106 - in /tomcat/trunk: build.properties.default build.xml
Author: markt
Date: Wed Jul 28 15:58:30 2010
New Revision: 980106
URL: http://svn.apache.org/viewvc?rev=980106&view=rev
Log:
Only download Checkstyle if it is going to be used
Add note the Checkstyle is LGPL
Add option (off by default) to fail test target as soon as one test fails.
Modified:
tomcat/trunk/build.properties.default
tomcat/trunk/build.xml
Modified: tomcat/trunk/build.properties.default
URL:
http://svn.apache.org/viewvc/tomcat/trunk/build.properties.default?rev=980106&r1=980105&r2=980106&view=diff
==
--- tomcat/trunk/build.properties.default (original)
+++ tomcat/trunk/build.properties.default Wed Jul 28 15:58:30 2010
@@ -32,11 +32,13 @@ version.patch=0
version.suffix=-dev
# - Build control flags -
+# Note enabling validation uses Checkstyle which is LGPL licensed
execute.validate=false
execute.test.bio=true
execute.test.nio=true
# Still requires APR/native library to be present
execute.test.apr=true
+test.haltonfailure=false
# - Default Base Path for Dependent Packages -
# Please note this path must be absolute, not relative,
Modified: tomcat/trunk/build.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/build.xml?rev=980106&r1=980105&r2=980106&view=diff
==
--- tomcat/trunk/build.xml (original)
+++ tomcat/trunk/build.xml Wed Jul 28 15:58:30 2010
@@ -997,9 +997,11 @@
-
+
@@ -1911,7 +1913,8 @@ Apache Tomcat ${version} native binaries
+ description="Download components necessary to validate source"
+ if="${execute.validate}">
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r966882 - in /tomcat/trunk: build.properties.default build.xml checkstyle.xml webapps/docs/changelog.xml
On 28/07/2010 03:38, Bill Barker wrote: > This is probably cruelty against dead horses, but shouldn't the > download target be conditional as well? Since checkstyle is LGPL > licensed, I really don't think that we should be installing it by > default for anyone that wants to build Tomcat. That works for me. > Being an extremist on > this issue, I would actually prefer that we remove the download-validate > target. This would mean that anyone that wants to use it has to have > installed it already, and so have accepted the LGPL license. I for one, > expect that when I download an Apache product, that it will only install > compatibly licensed software. At least not without warning me otherwise. > > This is a -0: vent. There is nothing wrong from a licensing stand point > on how we are using it. I added a comment in build.properties just above the option you need to override to enable validation. Hopefully that is a reasonable compromise. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r964219 [1/2] - in /tomcat/trunk: java/org/apache/catalina/filters/ test/org/apache/catalina/filters/ webapps/docs/ webapps/docs/config/
On 27/07/2010 14:16, Remy Maucherat wrote: > On Wed, 2010-07-14 at 22:11 +, ma...@apache.org wrote: >> Author: markt >> Date: Wed Jul 14 22:11:30 2010 >> New Revision: 964219 >> >> URL: http://svn.apache.org/viewvc?rev=964219&view=rev >> Log: >> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48998 >> Add the ExpiresFilter, a port of mod_expires >> Patch provided by Cyrille Le Clerc > > Isn't the amount of logging high in this filter ? Esp in > getExpirationDate. I didn't try to run it, simply browsing through the > code. Agreed. Those error level messages should be debug in that method. The rest of the class looks OK. I'll fix that in a sec... Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r980111 - /tomcat/trunk/java/org/apache/catalina/filters/ExpiresFilter.java
Author: markt
Date: Wed Jul 28 16:14:03 2010
New Revision: 980111
URL: http://svn.apache.org/viewvc?rev=980111&view=rev
Log:
Reduce log level for debug messages from error to debug
Modified:
tomcat/trunk/java/org/apache/catalina/filters/ExpiresFilter.java
Modified: tomcat/trunk/java/org/apache/catalina/filters/ExpiresFilter.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/filters/ExpiresFilter.java?rev=980111&r1=980110&r2=980111&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/filters/ExpiresFilter.java (original)
+++ tomcat/trunk/java/org/apache/catalina/filters/ExpiresFilter.java Wed Jul 28
16:14:03 2010
@@ -1234,8 +1234,8 @@ public class ExpiresFilter extends Filte
ExpiresConfiguration configuration =
expiresConfigurationByContentType.get(contentType);
if (configuration != null) {
Date result = getExpirationDate(configuration, response);
-if (log.isErrorEnabled()) {
-log.error(sm.getString(
+if (log.isDebugEnabled()) {
+log.debug(sm.getString(
"expiresFilter.useMatchingConfiguration",
configuration, contentType, contentType, result));
}
@@ -1249,8 +1249,8 @@ public class ExpiresFilter extends Filte
if (configuration != null) {
Date result = getExpirationDate(configuration, response);
-if (log.isErrorEnabled()) {
-log.error(sm.getString(
+if (log.isDebugEnabled()) {
+log.debug(sm.getString(
"expiresFilter.useMatchingConfiguration",
configuration, contentTypeWithoutCharset,
contentType, result));
@@ -1265,8 +1265,8 @@ public class ExpiresFilter extends Filte
configuration = expiresConfigurationByContentType.get(majorType);
if (configuration != null) {
Date result = getExpirationDate(configuration, response);
-if (log.isErrorEnabled()) {
-log.error(sm.getString(
+if (log.isDebugEnabled()) {
+log.debug(sm.getString(
"expiresFilter.useMatchingConfiguration",
configuration, majorType, contentType, result));
}
@@ -1277,15 +1277,15 @@ public class ExpiresFilter extends Filte
if (defaultExpiresConfiguration != null) {
Date result = getExpirationDate(defaultExpiresConfiguration,
response);
-if (log.isErrorEnabled()) {
-log.error(sm.getString("expiresFilter.useDefaultConfiguration",
+if (log.isDebugEnabled()) {
+log.debug(sm.getString("expiresFilter.useDefaultConfiguration",
defaultExpiresConfiguration, contentType, result));
}
return result;
}
-if (log.isErrorEnabled()) {
-log.error(sm.getString(
+if (log.isDebugEnabled()) {
+log.debug(sm.getString(
"expiresFilter.noExpirationConfiguredForContentType",
contentType));
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r966613 - in /tomcat/trunk: build.xml test/org/apache/catalina/startup/TestTomcatSSL.java test/org/apache/catalina/startup/TomcatBaseTest.java webapps/docs/changelog.xml
On 28/07/2010 10:52, Mladen Turk wrote: > On 07/28/2010 10:23 AM, Rainer Jung wrote: >>> >>> With APR 1.4.x there is a new pool pre-cleanup hook >>> that would allow to effectively handle those situations, >>> but it would also mean that native won't work on pre 1.4.x APR's >> >> If it is important, we could use that for TC 7 using a newer tcnative >> branch? >> > > Well, actually I introduced the pre-cleanups with APR 1.3.x, > so we would need to increase the dependency to that APR version. > > Newer branch would be appropriate only with APR 2.x dependency > in which case our native void be tcnative-2 not tcnative-1 > thought. > > Using pre-cleanups wouldn't require the api change, so > even tcnative-1 with pre 1.3.x APR would work > (in some cases performing core on shutdown obviously) I don't pretend to know enough about native code to be able to help out with this but from my experience with the tests anything that we can do to make native more robust, particularly on shut down, would be great. There is still at least one test failing and I suspect it is due to failing to shut down APR/native correctly. I'll try and get to that later today. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r966613 - in /tomcat/trunk: build.xml test/org/apache/catalina/startup/TestTomcatSSL.java test/org/apache/catalina/startup/TomcatBaseTest.java webapps/docs/changelog.xml
On 07/28/2010 06:18 PM, Mark Thomas wrote: On 28/07/2010 10:52, Mladen Turk wrote: Using pre-cleanups wouldn't require the api change, so even tcnative-1 with pre 1.3.x APR would work (in some cases performing core on shutdown obviously) I don't pretend to know enough about native code to be able to help out with this but from my experience with the tests anything that we can do to make native more robust, particularly on shut down, would be great. Agreed. We would eventually need an APR versioning policy anyhow. Having at least 1.3.x as required would solve the shutdown problems, while having 1.4.x would allow to use the new poll_wakeup API simplifying the poller code by an order of magnitude, and also increasing the performance. 1.4 also uses new WSAPoll on windows (if running under Vista and up) which allows huge number of sockets in the poller without the need for multiple 1k size pollsets (I tested that with 16k sockets in one poller) So my vote would be 1.4.x as minimum APR version required. Regards -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Question about tests in tomcat/trunk not backported to tomcat 6 and 7 trunk
Hi, We've been bitten by bug 49598 in tomcat 6.0.28 and we were happy when the 6.0.29 was released. After the 6.0.29 release, I tried to find the JUnit test case for this bug in the http://svn.apache.org/repos/asf/tomcat/tc6.0.x/trunk/ but it was only in the http://svn.apache.org/repos/asf/tomcat/trunk/ (http://svn.apache.org/repos/asf/tomcat/trunk/test/org/apache/catalina/connector/TestResponse.java). Is there a reason why ? I was thinking that it will be usefull to also have tests backported in tomcat/tc(6|7).0.x . Regards, Franck - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Question about tests in tomcat/trunk not backported to tomcat 6 and 7 trunk
On 28/07/2010 23:21, Franck Arnulfo wrote: > Hi, > > We've been bitten by bug 49598 in tomcat 6.0.28 and we were happy when > the 6.0.29 was released. > After the 6.0.29 release, I tried to find the JUnit test case for this > bug in the http://svn.apache.org/repos/asf/tomcat/tc6.0.x/trunk/ but > it was only in the http://svn.apache.org/repos/asf/tomcat/trunk/ > (http://svn.apache.org/repos/asf/tomcat/trunk/test/org/apache/catalina/connector/TestResponse.java). > Is there a reason why ? I was thinking that it will be usefull to also > have tests backported in tomcat/tc(6|7).0.x . Currently, trunk is 7.0.x/trunk. That will change once 7.0.x becomes stable. 6.0.x/trunk doesn't have the necessary support classes and can't without API changes which would rightly be vetoed. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r980260 - /tomcat/trunk/java/org/apache/coyote/http11/Http11AprProtocol.java
Author: markt
Date: Wed Jul 28 22:55:08 2010
New Revision: 980260
URL: http://svn.apache.org/viewvc?rev=980260&view=rev
Log:
Fix a failing test with the APR connector. Handle async requests that timeout.
Modified:
tomcat/trunk/java/org/apache/coyote/http11/Http11AprProtocol.java
Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11AprProtocol.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/Http11AprProtocol.java?rev=980260&r1=980259&r2=980260&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http11/Http11AprProtocol.java (original)
+++ tomcat/trunk/java/org/apache/coyote/http11/Http11AprProtocol.java Wed Jul
28 22:55:08 2010
@@ -526,39 +526,42 @@ public class Http11AprProtocol implement
SocketState state = SocketState.CLOSED;
if (result != null) {
-// Call the appropriate event
-try {
-state = result.event(status);
-} catch (java.net.SocketException e) {
-// SocketExceptions are normal
-Http11AprProtocol.log.debug
-(sm.getString
-("http11protocol.proto.socketexception.debug"), e);
-} catch (java.io.IOException e) {
-// IOExceptions are normal
-Http11AprProtocol.log.debug
-(sm.getString
-("http11protocol.proto.ioexception.debug"), e);
-}
-// Future developers: if you discover any other
-// rare-but-nonfatal exceptions, catch them here, and log as
-// above.
-catch (Throwable e) {
-// any other exception or error is odd. Here we log it
-// with "ERROR" level, so it will show up even on
-// less-than-verbose logs.
-Http11AprProtocol.log.error
-(sm.getString("http11protocol.proto.error"), e);
-} finally {
-if (state != SocketState.LONG) {
-connections.remove(Long.valueOf(socket));
-recycledProcessors.offer(result);
-if (state == SocketState.OPEN) {
-proto.endpoint.getPoller().add(socket);
+if (result.comet) {
+// Call the appropriate event
+try {
+state = result.event(status);
+} catch (java.net.SocketException e) {
+// SocketExceptions are normal
+Http11AprProtocol.log.debug(sm.getString(
+"http11protocol.proto.socketexception.debug"),
+e);
+} catch (java.io.IOException e) {
+// IOExceptions are normal
+Http11AprProtocol.log.debug(sm.getString(
+"http11protocol.proto.ioexception.debug"), e);
+}
+// Future developers: if you discover any other
+// rare-but-nonfatal exceptions, catch them here, and log
as
+// above.
+catch (Throwable e) {
+// any other exception or error is odd. Here we log it
+// with "ERROR" level, so it will show up even on
+// less-than-verbose logs.
+Http11AprProtocol.log.error(sm.getString(
+"http11protocol.proto.error"), e);
+} finally {
+if (state != SocketState.LONG) {
+connections.remove(Long.valueOf(socket));
+recycledProcessors.offer(result);
+if (state == SocketState.OPEN) {
+proto.endpoint.getPoller().add(socket);
+}
+} else {
+proto.endpoint.getCometPoller().add(socket);
}
-} else {
-proto.endpoint.getCometPoller().add(socket);
}
+} else if (result.async) {
+state = asyncDispatch(socket, status);
}
}
return state;
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r980262 - /tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java
Author: markt
Date: Wed Jul 28 23:03:40 2010
New Revision: 980262
URL: http://svn.apache.org/viewvc?rev=980262&view=rev
Log:
Make life easier when debugging failing tests
Modified:
tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java
Modified: tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java?rev=980262&r1=980261&r2=980262&view=diff
==
--- tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java (original)
+++ tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java Wed Jul
28 23:03:40 2010
@@ -130,6 +130,7 @@ public abstract class TomcatBaseTest ext
StandardServer server = (StandardServer) tomcat.getServer();
AprLifecycleListener listener = new AprLifecycleListener();
server.addLifecycleListener(listener);
+connector.setAttribute("pollerThreadCount", Integer.valueOf(1));
}
tomcat.setBaseDir(tempDir.getAbsolutePath());
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r980106 - in /tomcat/trunk: build.properties.default build.xml
wrote in message
news:20100728155830.a602f2388...@eris.apache.org...
Author: markt
Date: Wed Jul 28 15:58:30 2010
New Revision: 980106
URL: http://svn.apache.org/viewvc?rev=980106&view=rev
Log:
Only download Checkstyle if it is going to be used
Add note the Checkstyle is LGPL
Add option (off by default) to fail test target as soon as one test fails.
Thanks.
Gump is now set up to nag the list if any checkstyle rules are failing (just
as it is doing for unit tests).
Modified:
tomcat/trunk/build.properties.default
tomcat/trunk/build.xml
Modified: tomcat/trunk/build.properties.default
URL:
http://svn.apache.org/viewvc/tomcat/trunk/build.properties.default?rev=980106&r1=980105&r2=980106&view=diff
==
--- tomcat/trunk/build.properties.default (original)
+++ tomcat/trunk/build.properties.default Wed Jul 28 15:58:30 2010
@@ -32,11 +32,13 @@ version.patch=0
version.suffix=-dev
# - Build control flags -
+# Note enabling validation uses Checkstyle which is LGPL licensed
execute.validate=false
execute.test.bio=true
execute.test.nio=true
# Still requires APR/native library to be present
execute.test.apr=true
+test.haltonfailure=false
# - Default Base Path for Dependent Packages -
# Please note this path must be absolute, not relative,
Modified: tomcat/trunk/build.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/build.xml?rev=980106&r1=980105&r2=980106&view=diff
==
--- tomcat/trunk/build.xml (original)
+++ tomcat/trunk/build.xml Wed Jul 28 15:58:30 2010
@@ -997,9 +997,11 @@
if="test.entry"/>
-- errorproperty="test.result.error"
failureproperty="test.result.failure"
- >
+
@@ -1911,7 +1913,8 @@ Apache Tomcat ${version} native binaries
- description="Download components necessary to validate source"
>
+ description="Download components necessary to validate source"
+if="${execute.validate}">
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[g...@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test has an issue affecting its community integration. This issue affects 1 projects. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-trunk-test : Java Servlet 3.0, Java Server Pages 2.2 & Expression Languag... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on tomcat-trunk-dbcp exists, no need to add for property tomcat-dbcp-src.jar. -DEBUG- Dependency on commons-daemon exists, no need to add for property commons-daemon.native.src.tgz. -DEBUG- Dependency on commons-daemon exists, no need to add for property tomcat-native.tar.gz. -DEBUG- Dependency on tomcat-trunk-dbcp exists, no need to add for property tomcat-dbcp.home. -INFO- Failed with reason build failed -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-trunk/output/build/logs The following work was performed: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/gump_work/build_tomcat-trunk_tomcat-trunk-test.html Work Name: build_tomcat-trunk_tomcat-trunk-test (Type: Build) Work ended in a state of : Failed Elapsed: 6 mins 40 secs Command Line: /usr/lib/jvm/java-6-sun/bin/java -Djava.awt.headless=true org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Dbuild.sysclasspath=only -Djunit.jar=/srv/gump/public/workspace/junit/dist/junit-28072010.jar -Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-28072010-native-src.tar.gz -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-28072010-native-src.tar.gz -Dexamples.sources.skip=true -Dtomcat-dbcp.home=/srv/gump/public/workspace/tomcat-trunk/tomcat-deps -Djdt.jar=/srv/gump/packages/eclipse/plugins/org.eclipse.jdt.core_3.4.2/jdtcore.jar -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-28072010.jar -Dtomcat-dbcp-src.jar=/srv/gump/public/workspace/tomcat-trunk/tomcat-deps/tomcat-dbcp-src.jar -Dcommons-pool.home=/srv/gump/public/workspace/apache-commons/pool -Dcommons-dbcp.home=/srv/gump/public/workspa ce/apache-commons/dbcp -Dcheckstyle.jar=/srv/gump/public/workspace/checkstyle/target/dist/checkstyle-28072010/checkstyle-all-28072010.jar -Dtomcat-dbcp.jar=/srv/gump/public/workspace/tomcat-trunk/tomcat-deps/tomcat-dbcp-28072010.jar test [Working Directory: /srv/gump/public/workspace/tomcat-trunk] CLASSPATH: /usr/lib/jvm/java-6-sun/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/packages/junit3.8.1/junit.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.jar:/srv/gum p/public/workspace/tomcat-trunk/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-util.jar:/srv/gump/packages/javamail-1.4/mail.jar:/srv/gump/packages/javamail-1.4/lib/mailapi.jar:/srv/gump/packages/jaf-1.1ea/activation.jar:/srv/gump/packages/eclipse/plugins/org.eclipse.jdt.core_3.4.2/jdtcore.jar: /srv/gump/public/workspace/tomcat-trunk/tomcat-deps/tomcat-dbcp-28072010.jar:/srv/
