On 28/07/2010 10:52, Mladen Turk wrote: > On 07/28/2010 10:23 AM, Rainer Jung wrote: >>> >>> With APR 1.4.x there is a new pool pre-cleanup hook >>> that would allow to effectively handle those situations, >>> but it would also mean that native won't work on pre 1.4.x APR's >> >> If it is important, we could use that for TC 7 using a newer tcnative >> branch? >> > > Well, actually I introduced the pre-cleanups with APR 1.3.x, > so we would need to increase the dependency to that APR version. > > Newer branch would be appropriate only with APR 2.x dependency > in which case our native void be tcnative-2 not tcnative-1 > thought. > > Using pre-cleanups wouldn't require the api change, so > even tcnative-1 with pre 1.3.x APR would work > (in some cases performing core on shutdown obviously)
I don't pretend to know enough about native code to be able to help out with this but from my experience with the tests anything that we can do to make native more robust, particularly on shut down, would be great. There is still at least one test failing and I suspect it is due to failing to shut down APR/native correctly. I'll try and get to that later today. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
