Tomcat 7 Maven Artifacts
Hi folks, Our project OpenWebBeans has a dependency on Tomcat 7 artifacts. We are going to release OWB. Where is the Tomcat 7 Beta Maven artifacts? Thanks; Gurkan OpenWebBeans PMC Chair
Re: Tomcat 7 Maven Artifacts
On 04/07/2010 11:43, Gurkan Erdogdu wrote: Hi folks, Our project OpenWebBeans has a dependency on Tomcat 7 artifacts. We are going to release OWB. Where is the Tomcat 7 Beta Maven artifacts? They haven't been uploaded yet. I should be able to upload them later this week. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
RTF and fixcrlf during build
The fixcrlf handling of RTF files when packed into the source distribution has changed as a side effect of http://svn.apache.org/viewvc?view=revision&revision=893572 It was "don't change" before and "fix" after. It seems the RTF spec is at least unclear about correct line endings with a tendency to implicitely assume CRLF. I would favor not touching the RTF files, so to remove "**/*.rtf" from the patternset. Any other opinion or RTF experiences? The only RTF file we have at the moment is res/License.rtf. Regards, Rainer - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r960317 - /tomcat/trunk/webapps/docs/changelog.xml
Author: pero Date: Sun Jul 4 10:47:12 2010 New Revision: 960317 URL: http://svn.apache.org/viewvc?rev=960317&view=rev Log: Fix indentation... Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=960317&r1=960316&r2=960317&view=diff == --- tomcat/trunk/webapps/docs/changelog.xml (original) +++ tomcat/trunk/webapps/docs/changelog.xml Sun Jul 4 10:47:12 2010 @@ -38,8 +38,8 @@ -49528: HttpServletRequest.isAsyncStarted() now returns true when a Runnable is started! -Reported by Pieter Libin (pero) +49528: HttpServletRequest.isAsyncStarted() now returns true when a Runnable is started. +Bug reported by Pieter Libin. (pero) GSOC 2010. Continue work to align MBean descriptors with reality. Patch - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r960318 - /tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java
Author: pero
Date: Sun Jul 4 10:50:53 2010
New Revision: 960318
URL: http://svn.apache.org/viewvc?rev=960318&view=rev
Log:
no functional change.
reformating and fix some checkstyle warnings
Modified:
tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java
Modified: tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java?rev=960318&r1=960317&r2=960318&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java (original)
+++ tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java Sun Jul 4
10:50:53 2010
@@ -1,13 +1,13 @@
-/*
+/**
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
- *
+ *
* http://www.apache.org/licenses/LICENSE-2.0
- *
+ *
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -40,19 +40,21 @@ import org.apache.catalina.connector.Req
import org.apache.coyote.ActionCode;
import org.apache.juli.logging.Log;
import org.apache.juli.logging.LogFactory;
+
/**
- *
+ *
* @author fhanik
*
*/
public class AsyncContextImpl implements AsyncContext {
-
+
public static enum AsyncState {
-NOT_STARTED, STARTED, DISPATCHING, DISPATCHED, COMPLETING, TIMING_OUT,
ERROR_DISPATCHING
+NOT_STARTED, STARTED, DISPATCHING,
+DISPATCHED, COMPLETING, TIMING_OUT, ERROR_DISPATCHING
}
-
+
private static final Log log = LogFactory.getLog(AsyncContextImpl.class);
-
+
private ServletRequest servletRequest = null;
private ServletResponse servletResponse = null;
private List listeners = new
ArrayList();
@@ -62,12 +64,15 @@ public class AsyncContextImpl implements
private AtomicReference state = new
AtomicReference(AsyncState.NOT_STARTED);
private long timeout = -1;
private AsyncEvent event = null;
-
+
private Request request;
-
+
public AsyncContextImpl(Request request) {
if (log.isDebugEnabled()) {
-log.debug("AsyncContext
created["+request.getRequestURI()+"?"+request.getQueryString()+"]", new
DebugException());
+log.debug("AsyncContext created["
++ request.getRequestURI()
++ "?" + request.getQueryString() + "]",
+new DebugException());
}
//TODO SERVLET3 - async
this.request = request;
@@ -76,81 +81,102 @@ public class AsyncContextImpl implements
@Override
public void complete() {
if (log.isDebugEnabled()) {
-log.debug("AsyncContext Complete Called["+state.get()+";
"+request.getRequestURI()+"?"+request.getQueryString()+"]", new
DebugException());
+log.debug("AsyncContext Complete Called["
++ state.get() + "; "
++ request.getRequestURI()
++ "?" + request.getQueryString() + "]",
+new DebugException());
}
-if (state.get()==AsyncState.COMPLETING) {
+if (state.get() == AsyncState.COMPLETING) {
//do nothing
-} else if (state.compareAndSet(AsyncState.DISPATCHED,
AsyncState.COMPLETING) ||
- state.compareAndSet(AsyncState.STARTED,
AsyncState.COMPLETING)) {
+} else if (state.compareAndSet(AsyncState.DISPATCHED,
AsyncState.COMPLETING)
+ || state.compareAndSet(AsyncState.STARTED,
AsyncState.COMPLETING)) {
// TODO SERVLET3 - async
AtomicBoolean dispatched = new AtomicBoolean(false);
-
request.getCoyoteRequest().action(ActionCode.ACTION_ASYNC_COMPLETE,dispatched);
-if (!dispatched.get()) doInternalComplete(false);
+request.getCoyoteRequest().action(
+ActionCode.ACTION_ASYNC_COMPLETE, dispatched);
+if (!dispatched.get()) {
+doInternalComplete(false);
+}
} else {
-throw new IllegalStateException("Complete not allowed. Invalid
state:"+state.get());
+throw new IllegalStateException(
+"Complete not allowed. Invalid state:" + state.get());
}
-
+
}
@Override
public void dispatch() {
-HttpServletRequest sr = (HttpServletRequest)getServletRequest();
+HttpServletRequest sr = (HttpServletRequest) getServletRequest();
String path = sr.getRe
Re: svn commit: r960283 - in /tomcat/trunk: java/org/apache/catalina/core/AsyncContextImpl.java test/org/apache/catalina/core/TestAsyncContextImpl.java webapps/docs/changelog.xml
Hi Rainer,
source of AsyncContextImpl has a lot of open checkstyle warnings. I
check my eclipse
but all formatter use space instead tabs. Very strange...
Peter
Am 04.07.2010 um 01:17 schrieb Rainer Jung:
Hi Peter,
On 04.07.2010 00:48, p...@apache.org wrote:
Author: pero
Date: Sat Jul 3 22:48:16 2010
New Revision: 960283
URL: http://svn.apache.org/viewvc?rev=960283&view=rev
Log:
Fix Bug 49528 - HttpServletRequest.isAsyncStarted() returns false
when a Runnable is started
Add isDebugEnabled statements.
Todo: Why we doesn't start directly a container thread with
asyncContext.start()?
Currently we start user runnable as an internal forward.
Added:
tomcat/trunk/test/org/apache/catalina/core/
TestAsyncContextImpl.java (with props)
Modified:
tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/java/org/apache/catalina/core/
AsyncContextImpl.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java?rev=960283&r1=960282&r2=960283&view=diff
=
=
=
=
=
=
=
=
=
=
--- tomcat/trunk/java/org/apache/catalina/core/
AsyncContextImpl.java (original)
+++ tomcat/trunk/java/org/apache/catalina/core/
AsyncContextImpl.java Sat Jul 3 22:48:16 2010
@@ -253,7 +253,7 @@ public class AsyncContextImpl implements
}
public boolean isStarted() {
-return (state.get() == AsyncState.STARTED || state.get()
== AsyncState.DISPATCHING);
+return (state.get() == AsyncState.STARTED || state.get()
== AsyncState.DISPATCHING || state.get() == AsyncState.DISPATCHED);
}
public void setStarted(Context context) {
@@ -292,7 +292,8 @@ public class AsyncContextImpl implements
public void doInternalDispatch() throws ServletException,
IOException {
if (this.state.compareAndSet(AsyncState.TIMING_OUT,
AsyncState.COMPLETING)) {
-log.debug("TIMING OUT!");
+ if( log.isDebugEnabled())
+ log.debug("TIMING OUT!");
Style nitpicks:
- indentation wrong, maybe tabs involved
- spacing around "if"
boolean listenerInvoked = false;
for (AsyncListenerWrapper listener : listeners) {
listener.fireOnTimeout(event);
@@ -303,15 +304,18 @@ public class AsyncContextImpl implements
}
doInternalComplete(true);
} else if
(this.state.compareAndSet(AsyncState.ERROR_DISPATCHING,
AsyncState.COMPLETING)) {
-log.debug("ON ERROR!");
+if( log.isDebugEnabled())
+log.debug("ON ERROR!");
- spacing around "if"
boolean listenerInvoked = false;
for (AsyncListenerWrapper listener : listeners) {
try {
listener.fireOnError(event);
}catch (IllegalStateException x) {
-log.debug("Listener invoked invalid state.",x);
+if( log.isDebugEnabled())
+log.debug("Listener invoked invalid
state.",x);
- spacing around "if"
}catch (Exception x) {
-log.debug("Exception during onError.",x);
+if(log.isDebugEnabled())
+log.debug("Exception during onError.",x);
- spacing around "if"
}
listenerInvoked = true;
}
Added: tomcat/trunk/test/org/apache/catalina/core/
TestAsyncContextImpl.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java?rev=960283&view=auto
=
=
=
=
=
=
=
=
=
=
--- tomcat/trunk/test/org/apache/catalina/core/
TestAsyncContextImpl.java (added)
+++ tomcat/trunk/test/org/apache/catalina/core/
TestAsyncContextImpl.java Sat Jul 3 22:48:16 2010
+private BUG49528Servlet createTestApp(Tomcat tomcat) {
+// Must have a real docBase - just use temp
+File docBase = new
File(System.getProperty("java.io.tmpdir"));
+
+// Create the folder that will trigger the redirect
+File foo = new File(docBase, "async");
+if (!foo.exists()&& !foo.mkdirs()) {
- spacing around "&&"
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=960283&r1=960282&r2=960283&view=diff
=
=
=
=
=
=
=
=
=
=
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Sat Jul 3 22:48:16 2010
@@ -38,6 +38,10 @@
+49528: HttpServletRequest.isAsyncStarted() now returns
true when a Runnable is started!
+Reported by Pieter Libin (pero)
+
+
- indentation
- no need for exclamation mark
Regards,
Rainer
-
Bug report for Taglibs [2010/07/04]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |27717|New|Maj|2004-03-16| very slow in JSTL 1.1 | |33934|New|Cri|2005-03-09|[standard] memory leak in jstl c:set tag | |38193|Ass|Enh|2006-01-09|[RDC] BuiltIn Grammar support for Field | |38600|Ass|Enh|2006-02-10|[RDC] Enable RDCs to be used in X+V markup (X+RDC)| |42413|New|Nor|2007-05-14|[PATCH] Log Taglib enhancements | |43640|New|Nor|2007-10-16|Move the tests package to JUnit | |45197|Ass|Nor|2008-06-12|Need to support the JSTL 1.2 specification| |46052|New|Nor|2008-10-21|SetLocaleSupport is slow to initialize when many l| |48333|New|Nor|2009-12-02|TLD generator | |48773|New|Nor|2010-02-19|DataSourceWrapper and DriverManager problems | |49292|New|Nor|2010-05-14|Memory leak in org.apache.taglibs.standard.lang.js| +-+---+---+--+--+ | Total 11 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Tomcat Native [2010/07/04]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |38372|Inf|Cri|2006-01-25|tcnative-1.dll response overflow corruption, parti| |41361|New|Nor|2007-01-14|Content lost when read by a slow client. | |42090|New|Cri|2007-04-11|tcnative badly handles some OpenSSL disconnections| |45392|New|Nor|2008-07-14|No OCSP support for client SSL verification | |46041|New|Cri|2008-10-20|Tomcat service is terminated unexpectedly (tcnativ| |46179|New|Maj|2008-11-10|apr ssl client authentication | |46571|New|Nor|2009-01-21|tcnative blocks in APR poll on Solaris| |47319|New|Nor|2009-06-05|With APR, getRemoteHost() returns NULL for unknown| |47851|New|Nor|2009-09-16|thread-safety issues in the TC native Java code | |48253|New|Min|2009-11-20|Tomcat Native patch - adding dynamic locking callb| |48655|New|Nor|2010-02-02|Active multipart downloads prevent tomcat shutdown| |49038|Inf|Nor|2010-04-02|Crash in tcnative | +-+---+---+--+--+ | Total 12 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Tomcat 5 [2010/07/04]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |27122|Opn|Enh|2004-02-20|IE plugins cannot access components through Tomcat| |28039|Opn|Enh|2004-03-30|Cluster Support for SingleSignOn | |29494|Inf|Enh|2004-06-10|No way to set PATH when running as a service on Wi| |33262|Inf|Enh|2005-01-27|Service Manager autostart should check for adminis| |33453|Opn|Enh|2005-02-08|Jasper should recompile JSP files whose datestamps| |33671|Opn|Enh|2005-02-21|Manual Windows service installation with custom na| |34801|New|Enh|2005-05-08|PATCH: CGIServlet does not terminate child after a| |34805|Ass|Enh|2005-05-08|warn about invalid security constraint url pattern| |34868|Ass|Enh|2005-05-11|allow to register a trust store for a session that| |35054|Inf|Enh|2005-05-25|warn if appBase is not existing as a File or direc| |36133|Inf|Enh|2005-08-10|Support JSS SSL implementation| |36362|New|Enh|2005-08-25|missing check for Java reserved keywords in tag fi| |36569|Inf|Enh|2005-09-09|Redirects produce illegal URL's | |36837|Inf|Enh|2005-09-28|Looking for ProxyHandler implementation of Http re| |36922|Inf|Enh|2005-10-04|setup.sh file mis-advertised and missing | |37018|Ass|Enh|2005-10-11|Document how to use tomcat-SSL with a pkcs11 token| |37334|Inf|Enh|2005-11-02|Realm digest property not aligned with the adminis| |37485|Inf|Enh|2005-11-14|I'd like to run init SQL after JDBC Connection cre| |38216|Inf|Enh|2006-01-10|Extend Jmxproxy to allow call of MBean Operations | |38268|Inf|Enh|2006-01-13|User friendly: Need submit button on adding/deleti| |38360|Inf|Enh|2006-01-24|Domain for session cookies| |38546|Inf|Enh|2006-02-07|Google bot sends invalid If-Modifed-Since Header, | |38577|Inf|Enh|2006-02-08|Enhance logging of security failures | |38916|Inf|Enh|2006-03-10|HttpServletRequest cannot handle multipart request| |39053|Inf|Enh|2006-03-21|include Tomcat embedded sample| |39740|New|Enh|2006-06-07|semi-colon ; isn't allowed as a query argument sep| |39862|Inf|Enh|2006-06-22|provide support for protocol-independent GenericSe| |40211|Inf|Enh|2006-08-08|Compiled JSP don't indent HTML code | |40222|Inf|Enh|2006-08-09|Default Tomcat configuration alows easy session hi| |40402|New|Enh|2006-09-03|Manager should display Exceptions | |40510|New|Enh|2006-09-14|installer does not create shortcuts for all users | |40712|New|Enh|2006-10-10|Realm admin error.| |40728|Inf|Enh|2006-10-11|Catalina MBeans use non-serializable classes | |40766|New|Enh|2006-10-16|Using an unsecure jsessionid with mod_proxy_ajp ov| |40881|Opn|Enh|2006-11-02|Unable to receive message through TCP channel -> | |41007|Opn|Enh|2006-11-20|Can't define customized 503 error page| |41179|New|Enh|2006-12-15|400 Bad Request response during auto re-deployment| |41227|Opn|Enh|2006-12-21|When the jasper compiler fails to compile a JSP, i| |41337|Opn|Enh|2007-01-10|Display an error page if no cert is available on C| |41496|New|Enh|2007-01-30|set a security provider for jsse in a connector co| |41498|New|Enh|2007-01-30|allRolesMode Realm configuration option not docume| |41539|Inf|Enh|2007-02-05|NullPointerException during Embedded tomcat restar| |41673|New|Enh|2007-02-21|Jasper output the message of compiling error using| |41697|Ver|Enh|2007-02-25|make visible in debug output if charset from brows| |41709|Inf|Enh|2007-02-26|When calling the API that relates to the buffer af| |41718|New|Enh|2007-02-27|Status 302 response to GET request has no body whe| |42416|New|Enh|2007-05-14|Tomcat startup hangs and AJP13 connector port 8009| |43423|New|Enh|2007-09-18|catalina.sh -force too fast | |43538|New|Enh|2007-10-02|[patch] Show the hostname and IP address in the ma| |43796|Inf|Enh|2007-11-05|Add MIME type mapping for the "log" extension | |43866|New|Enh|2007-11-14|add support for session attribute propagation with| |43925|
Bug report for Tomcat 6 [2010/07/04]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |39661|Opn|Enh|2006-05-25|Please document JULI FileHandler configuration pro| |41128|Inf|Enh|2006-12-07|Reference to java Thread name from RequestProcesso| |41679|New|Enh|2007-02-22|SemaphoreValve should be able to filter on url pat| |41791|New|Enh|2007-03-07|Tomcat behaves inconsistently concerning flush-pac| |41883|Ass|Enh|2007-03-18|use abstract wrapper instead of plain X509Certific| |41944|New|Enh|2007-03-25|Start running the RAT tool to see where we're miss| |41992|New|Enh|2007-03-30|Need ability to set OS process title | |42463|New|Enh|2007-05-20|"crossContext" and classloader issues - pls amend | |43001|New|Enh|2007-07-30|JspC lacks setMappedFile and setDie for use in Ant| |43003|New|Enh|2007-07-30|Separate dependent component download and build ta| |43400|New|Enh|2007-09-14|enum support for tag libs | |43497|New|Enh|2007-09-26|Add ability to escape rendered output of JSP expre| |43548|Opn|Enh|2007-10-04|xml schema for tomcat-users.xml | |43642|New|Enh|2007-10-17|Add prestartminSpareThreads attribute for Executor| |43682|New|Enh|2007-10-23|JULI: web-inf/classes/logging.properties to suppor| |43742|New|Enh|2007-10-30|.tag compiles performed one at a time -- extremel| |43790|Ass|Enh|2007-11-03|concurrent access issue on TagHandlerPool | |43979|New|Enh|2007-11-27|Add abstraction for Java and Classfile output | |44047|New|Enh|2007-12-10|Provide a way for Tomcat to serve up error pages w| |44106|New|Enh|2007-12-19|autodeploy configures directories which do not con| |44199|New|Enh|2008-01-10|expose current backlog queue size | |44225|New|Enh|2008-01-14|SSL connector tries to load the private keystore f| |44264|New|Enh|2008-01-18|Clustering - Support for disabling multicasting an| |44284|New|Enh|2008-01-23|Support java.lang.Iterable in c:forEach tag | |44294|New|Enh|2008-01-25|Support for EL functions with varargs | |44299|New|Enh|2008-01-26|Provider manager app with a log out button| |44312|New|Enh|2008-01-28|Warn when overwritting docBase of the default Host| |44598|New|Enh|2008-03-13|JAASRealm is suppressing Exceptions | |44645|New|Enh|2008-03-20|[Patch] JNDIRealm - Doesn't support JNDI "java.nam| |44787|New|Enh|2008-04-09|provide more error context on "java.lang.IllegalSt| |44818|New|Enh|2008-04-13|tomcat hangs with GET when content-length is defin| |45014|New|Enh|2008-05-15|Request and Response classes should have wrappers | |45282|New|Enh|2008-06-25|NioReceiver doesn't close cleanly, leaving sockets| |45283|Opn|Enh|2008-06-25|Allow multiple authenticators to be added to pipel| |45428|New|Enh|2008-07-18|warn if the tomcat stop doesn't complete | |45654|New|Enh|2008-08-19|use static methods and attributes in a direct way!| |45731|New|Enh|2008-09-02|Enhancement request : pluggable httpsession cache | |45832|New|Enh|2008-09-18|add DIGEST authentication support to Ant tasks| |45871|New|Enh|2008-09-23|Support for salted and digested patches in DataSou| |45878|New|Enh|2008-09-24|Generated jars do not contain proper manifests or | |45879|Opn|Enh|2008-09-24|Windows installer fails to install NOTICE and RELE| |45931|Opn|Enh|2008-10-01|trimSpaces incorrectly modifies output| |45995|New|Enh|2008-10-13|RFE - MIME type extension not case sensitive | |46173|New|Enh|2008-11-09|Small patch for manager app: Setting an optional c| |46263|New|Enh|2008-11-21|Tomcat reloading of context does not update contex| |46264|New|Enh|2008-11-21|Shutting down tomcat with large number of contexts| |46284|New|Enh|2008-11-24|Add flag to DeltaManager that blocks processing cl| |46350|New|Enh|2008-12-05|Maven repository should contain source bundles| |46451|New|Enh|2008-12-30|Configure svn:bugtraq properties | |46461|New|Enh|2009-01-01|fail graceful on dns changes for connectors/hosts | |46497|New|Enh|2009-01-08|Install Tomcat Deployer/ANT on Windows Platform | |46558|
Bug report for Tomcat 7 [2010/07/04]
+---+
| Bugzilla Bug ID |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) |
| | +-+
| | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major |
| | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial |
| | | +-+
| | | | Date Posted |
| | | | +--+
| | | | | Description |
| | | | | |
|48240|New|Nor|2009-11-19|Tomcat-Lite missing @Override markers |
|48268|New|Nor|2009-11-23|Patch to fix generics in tomcat-lite |
|48297|New|Nor|2009-11-28|webservices.ServiceRefFactory.initHandlerChain add|
|48550|New|Enh|2010-01-14|Update examples and default server.xml to use UTF-|
|48648|New|Nor|2010-01-31|Blank page (dropped connection) when running TC7 w|
|48692|New|Enh|2010-02-07|Provide option to parse application/x-www-form-url|
|48817|New|Nor|2010-02-25|Skip validation query and use JDBC API for validat|
|48837|New|Enh|2010-03-01|Memory leaks protection does not cure leaks trigge|
|48861|New|Nor|2010-03-04|Files without AL headers |
|48870|New|Enh|2010-03-08|avoid parallel arrays of base types |
|48891|New|Enh|2010-03-11|Missing EOL-style settings in tomcat/jk/trunk |
|48892|New|Enh|2010-03-11|Use URIEncoding from server.xml for decoding post |
|48998|New|Enh|2010-03-26|Proposal : port mod_expires in java as ExpiresFilt|
|49000|New|Enh|2010-03-26|Cookie parsing bug when an empty value has an equa|
|49100|New|Enh|2010-04-12|Mutable public constants: MemberImpl.TRIBES_MBR_BE|
|49101|New|Enh|2010-04-12|All constants in tribes.transport.Constants are mu|
|49102|New|Enh|2010-04-12|coyote.ajp.Constants - 3 "constant" arrays are mut|
|49125|New|Enh|2010-04-14|toString on byte[] array probably is not correct |
|49126|New|Enh|2010-04-14|jasper.compiler.Generator.createJspId() can genera|
|49127|New|Enh|2010-04-14|SimpleTcpReplicationManager.startInternal() ignore|
|49128|New|Enh|2010-04-14|loader.WebappClassLoader.start() ignores Exception|
|49130|New|Enh|2010-04-14|NSIS - clarify that service is always installed |
|49142|New|Enh|2010-04-16|Missing serialVersionUIDs |
|49159|New|Enh|2010-04-20|Improve ThreadLocal memory leak clean-up |
|49165|New|Enh|2010-04-21|Enhancement - Allow %{TIME_FORMAT}t As Configurati|
|49180|New|Enh|2010-04-24|Add option to disable log rotation in FileHandler.|
|49182|New|Enh|2010-04-24|Documentation patch for setclasspath.sh |
|49234|New|Nor|2010-04-30|JMX Descriptor Modifications |
|49268|New|Enh|2010-05-10|Use checkstyle to enforce common code style |
|49284|New|Enh|2010-05-12|Implement SSL renegotiation for the NIO connector |
|49290|New|Enh|2010-05-14|Using a JarScanner with scanAllDirectories=true ca|
|49295|New|Enh|2010-05-14|JMXAccessorTask.getProperties() - return Propertie|
|49297|New|Min|2010-05-15|Whitespace absence is allowed before attribute nam|
|49317|New|Enh|2010-05-20|org.apache.catalina.util.Base64 interface needs re|
|49318|New|Enh|2010-05-20|add a Negotiate (Kerberos/NTLM) authenticator / in|
|49395|New|Enh|2010-06-06|manager.findLeaks : display the date when the leak|
|49426|New|Nor|2010-06-11|Manager app wrongly localized |
|49428|New|Nor|2010-06-11|Fix WebDAV mounts from Windows Mini-Redirector cli|
|49442|New|Enh|2010-06-15|Make StringManager fields final |
|49478|New|Enh|2010-06-21|Add encoding parameter to AddDefaultCharSetFilter |
|49503|New|Nor|2010-06-25|Connectors do not bind to their ports in Catalina.|
|49543|New|Nor|2010-07-02|Request for a "shared" datasource configuration as|
+-+---+---+--+--+
| Total 42 bugs |
+---+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Tomcat Connectors [2010/07/04]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |34526|Opn|Nor|2005-04-19|Truncated content in decompressed requests from mo| |35959|Opn|Enh|2005-08-01|mod_jk not independant of UseCanonicalName| |36155|Opn|Nor|2005-08-12|tomcat chooses wrong host if using mod_jk | |39967|Inf|Nor|2006-07-05|mod_jk gives segmentation fault when apache is sta| |40208|Inf|Nor|2006-08-08|Request-Dump when ErrorDocument in httpd.conf is a| |41170|Inf|Nor|2006-12-13|single crlf in header termination crashes app.| |41923|Opn|Nor|2007-03-21|Tomcat doesnt recognized client abort | |42366|Inf|Nor|2007-05-09|Memory leak in newer mod_jk version when connectio| |42554|Opn|Nor|2007-05-31|mod_ssl + mod_jk with status_worker does not work | |43303|New|Enh|2007-09-04|Versioning under Windows not reported by many conn| |43968|New|Enh|2007-11-26|[patch] support ipv6 with mod_jk | |44290|New|Nor|2008-01-24|mod_jk/1.2.26: retry is not useful for an importan| |44349|New|Maj|2008-02-04|mod_jk/1.2.26 module does not read worker.status.s| |44379|New|Enh|2008-02-07|convert the output of strftime into UTF-8 | |44454|New|Nor|2008-02-19|busy count reported in mod_jk inflated, causes inc| |44571|New|Enh|2008-03-10|Limits busy per worker to a threshold | |45063|New|Nor|2008-05-22|JK-1.2.26 IIS ISAPI filter issue when running diff| |45313|New|Nor|2008-06-30|mod_jk 1.2.26 & apache 2.2.9 static compiled on so| |45395|New|Min|2008-07-14|MsgAjp dump method does not dump packet when being| |46337|New|Nor|2008-12-04|real worker name is wrong | |46406|New|Enh|2008-12-16|Supporting relative paths in isapi_redirect.proper| |46676|New|Enh|2009-02-09|Configurable test request for Watchdog thread | |46767|New|Enh|2009-02-25|mod_jk to send DECLINED in case no fail-over tomca| |47038|New|Enh|2009-04-15|USE_FLOCK_LK redefined compiler warning when using| |47327|New|Enh|2009-06-07|remote_user not logged in apache logfile | |47617|New|Enh|2009-07-31|include time spent doing ajp_get_endpoint() in err| |47678|New|Nor|2009-08-11|Unable to allocate shared memory when using isapi_| |47679|New|Nor|2009-08-11|Not all headers get passed to Tomcat server from i| |47692|New|Reg|2009-08-12|Can not compile mod_jk with apache2.0.63 and tomca| |47714|New|Cri|2009-08-20|Reponse mixed between users | |47750|New|Maj|2009-08-27|Loss of worker settings when changing via jkstatus| |47795|New|Maj|2009-09-07|service sticky_session not being set correctly wit| |47840|Inf|Min|2009-09-14|A broken worker name is written in the log file. | |48191|New|Maj|2009-11-13|Problem with mod_jk 1.2.28 - Can not render up the| |48490|New|Nor|2010-01-05|Changing a node to stopped in uriworkermap.propert| |48501|New|Enh|2010-01-07|Log rotation for ISAPI Redirector | |48513|New|Enh|2010-01-09|IIS Quick setup instructions | |48564|New|Nor|2010-01-18|Unable to turn off retries for LB worker | |48830|New|Nor|2010-03-01|IIS shutdown blocked in endpoint service when serv| |48925|New|Maj|2010-03-16|((ServletRequest) request).getLocalAddr() returns | |48940|New|Maj|2010-03-18|IIS to Tomcat occasionally fails on POST with T-E | |49035|New|Maj|2010-04-01|data lost when post a multipart/form-data form| |49048|New|Nor|2010-04-05|ACL not applied to redirect URLs | |49063|New|Enh|2010-04-07|Please add JkStripSession status in jk-status work| |49135|New|Enh|2010-04-16|SPDY Connector for The Tomcat | |49413|Opn|Reg|2010-06-09|Apache Mod_jk 1.2.30 is shutting down communicatio| |49469|New|Enh|2010-06-19|Workers status page has negative number of connect| |49511|New|Maj|2010-06-28|IIS 7.5 incorrect logging: pfc->pFilterContext is | +-+---+---+--+--+ | Total 48 bugs | +---+ --
Re: RTF and fixcrlf during build
2010/7/4 Rainer Jung : > The fixcrlf handling of RTF files when packed into the source distribution > has changed as a side effect of > > http://svn.apache.org/viewvc?view=revision&revision=893572 > > It was "don't change" before and "fix" after. > > It seems the RTF spec is at least unclear about correct line endings with a > tendency to implicitely assume CRLF. I would favor not touching the RTF > files, so to remove "**/*.rtf" from the patternset. > +1 to remove **/*.rtf We do not have svn:eol-style on those files, so there is no need to do crlf conversion on them. > Any other opinion or RTF experiences? > > The only RTF file we have at the moment is res/License.rtf. > The only important thing is whether the exe installer displays the files properly. The 5.5.30 and 6.0.28 display the license properly for me. A more important question is that these files should match the plain LICENSE files. I just checked the files and only 6.0.x is OK. 5.5.x: License.rtf comes from HTTPD. It mentions HTTPD subcomponents, not Tomcat ones. Running 5.5.30 installer another strange thing happens: the installer displays plain ASF license only. I suspect that it uses build/resources/INSTALLLICENSE, not License.rtf build/tomcat.nsi contains: !insertmacro MUI_PAGE_LICENSE INSTALLLICENSE (...) ;License dialog LicenseData License.rtf trunk: License.rtf and INSTALLLICENSE say about Eclipse JDT Java compiler, while LICENSE says about ecj-x.x.x.jar, License.rtf and INSTALLLICENSE do not include the CCDL license. 6.0.x: OK, LICENSE = INSTALLICENSE, and License.rtf matches them. In all 5.5.x, 6.0.x, trunk: I think LICENSE needs an empty line before "Common Public License version 1.0" Maybe we can be more specific to what subcomponents that license applies? Based on the above experience for 5.5.x, I suspect that we can get rid of License.rtf and INSTALLLICENSE files, and display the same LICENSE in the installer. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: RTF and fixcrlf during build
On 04/07/2010 12:00, Rainer Jung wrote: The fixcrlf handling of RTF files when packed into the source distribution has changed as a side effect of http://svn.apache.org/viewvc?view=revision&revision=893572 It was "don't change" before and "fix" after. It seems the RTF spec is at least unclear about correct line endings with a tendency to implicitely assume CRLF. I would favor not touching the RTF files, so to remove "**/*.rtf" from the patternset. +1. No objections here. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49528] HttpServletRequest.isAsyncStarted() returns false when a Runnable is started
https://issues.apache.org/bugzilla/show_bug.cgi?id=49528 Mark Thomas changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED | --- Comment #3 from Mark Thomas 2010-07-04 11:22:01 EDT --- The fix breaks the Servlet TCK and therefore will have to be reverted. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r960347 - in /tomcat/trunk: java/org/apache/catalina/core/AsyncContextImpl.java test/org/apache/catalina/core/TestAsyncContextImpl.java webapps/docs/changelog.xml
Author: markt
Date: Sun Jul 4 15:38:40 2010
New Revision: 960347
URL: http://svn.apache.org/viewvc?rev=960347&view=rev
Log:
Revert r960283, r960316, r960318. r960283 broke the spec and the other commits
were sufficiently tightly coupled to it that it was easier to revert all of
them than try to unpick them.
Removed:
tomcat/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java
Modified:
tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java?rev=960347&r1=960346&r2=960347&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java (original)
+++ tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java Sun Jul 4
15:38:40 2010
@@ -1,13 +1,13 @@
-/**
+/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
- *
+ *
* http://www.apache.org/licenses/LICENSE-2.0
- *
+ *
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -40,21 +40,19 @@ import org.apache.catalina.connector.Req
import org.apache.coyote.ActionCode;
import org.apache.juli.logging.Log;
import org.apache.juli.logging.LogFactory;
-
/**
- *
+ *
* @author fhanik
*
*/
public class AsyncContextImpl implements AsyncContext {
-
+
public static enum AsyncState {
-NOT_STARTED, STARTED, DISPATCHING,
-DISPATCHED, COMPLETING, TIMING_OUT, ERROR_DISPATCHING
+NOT_STARTED, STARTED, DISPATCHING, DISPATCHED, COMPLETING, TIMING_OUT,
ERROR_DISPATCHING
}
-
+
private static final Log log = LogFactory.getLog(AsyncContextImpl.class);
-
+
private ServletRequest servletRequest = null;
private ServletResponse servletResponse = null;
private List listeners = new
ArrayList();
@@ -64,15 +62,12 @@ public class AsyncContextImpl implements
private AtomicReference state = new
AtomicReference(AsyncState.NOT_STARTED);
private long timeout = -1;
private AsyncEvent event = null;
-
+
private Request request;
-
+
public AsyncContextImpl(Request request) {
if (log.isDebugEnabled()) {
-log.debug("AsyncContext created["
-+ request.getRequestURI()
-+ "?" + request.getQueryString() + "]",
-new DebugException());
+log.debug("AsyncContext
created["+request.getRequestURI()+"?"+request.getQueryString()+"]", new
DebugException());
}
//TODO SERVLET3 - async
this.request = request;
@@ -81,102 +76,81 @@ public class AsyncContextImpl implements
@Override
public void complete() {
if (log.isDebugEnabled()) {
-log.debug("AsyncContext Complete Called["
-+ state.get() + "; "
-+ request.getRequestURI()
-+ "?" + request.getQueryString() + "]",
-new DebugException());
+log.debug("AsyncContext Complete Called["+state.get()+";
"+request.getRequestURI()+"?"+request.getQueryString()+"]", new
DebugException());
}
-if (state.get() == AsyncState.COMPLETING) {
+if (state.get()==AsyncState.COMPLETING) {
//do nothing
-} else if (state.compareAndSet(AsyncState.DISPATCHED,
AsyncState.COMPLETING)
- || state.compareAndSet(AsyncState.STARTED,
AsyncState.COMPLETING)) {
+} else if (state.compareAndSet(AsyncState.DISPATCHED,
AsyncState.COMPLETING) ||
+ state.compareAndSet(AsyncState.STARTED,
AsyncState.COMPLETING)) {
// TODO SERVLET3 - async
AtomicBoolean dispatched = new AtomicBoolean(false);
-request.getCoyoteRequest().action(
-ActionCode.ACTION_ASYNC_COMPLETE, dispatched);
-if (!dispatched.get()) {
-doInternalComplete(false);
-}
+
request.getCoyoteRequest().action(ActionCode.ACTION_ASYNC_COMPLETE,dispatched);
+if (!dispatched.get()) doInternalComplete(false);
} else {
-throw new IllegalStateException(
-"Complete not allowed. Invalid state:" + state.get());
+throw new IllegalStateException("Complete not allowed. Invalid
state:"+state.get());
svn commit: r960348 - in /tomcat/trunk: java/org/apache/tomcat/util/net/JIoEndpoint.java test/org/apache/catalina/core/TestAsyncListener.java webapps/docs/changelog.xml
Author: markt Date: Sun Jul 4 15:44:45 2010 New Revision: 960348 URL: http://svn.apache.org/viewvc?rev=960348&view=rev Log: Revert r958362, r960083, r958406, r960069. r958362 broke the TCK tests and the other commits were sufficiently tightly coupled to it that it was easier to revert all of them than try to unpick them. Removed: tomcat/trunk/test/org/apache/catalina/core/TestAsyncListener.java Modified: tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java?rev=960348&r1=960347&r2=960348&view=diff == --- tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java (original) +++ tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java Sun Jul 4 15:44:45 2010 @@ -399,11 +399,6 @@ public class JIoEndpoint extends Abstrac acceptorThread.setDaemon(getDaemon()); acceptorThread.start(); } - -// Start async timeout thread -Thread timeoutThread = new Thread(new AsyncTimeout(),getName() + "-AsyncTimeout"); -timeoutThread.setDaemon(true); -timeoutThread.start(); } } Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=960348&r1=960347&r2=960348&view=diff == --- tomcat/trunk/webapps/docs/changelog.xml (original) +++ tomcat/trunk/webapps/docs/changelog.xml Sun Jul 4 15:44:45 2010 @@ -98,14 +98,6 @@ - - - -Start JioEndpoint timeout thread, to inform AsyncListner as async timeout is detected -and application thread doesn't finished the request. (pero) - - - - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r960350 - /tomcat/trunk/build.xml
Author: rjung Date: Sun Jul 4 16:01:43 2010 New Revision: 960350 URL: http://svn.apache.org/viewvc?rev=960350&view=rev Log: Remove *.rtf from fixcrlf patternset. No need for native line ends in RTF files. Their spec indicates they should use CRLF. Modified: tomcat/trunk/build.xml Modified: tomcat/trunk/build.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/build.xml?rev=960350&r1=960349&r2=960350&view=diff == --- tomcat/trunk/build.xml (original) +++ tomcat/trunk/build.xml Sun Jul 4 16:01:43 2010 @@ -213,7 +213,6 @@ - - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r960352 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: rjung Date: Sun Jul 4 16:06:50 2010 New Revision: 960352 URL: http://svn.apache.org/viewvc?rev=960352&view=rev Log: Propose. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=960352&r1=960351&r2=960352&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Sun Jul 4 16:06:50 2010 @@ -150,3 +150,13 @@ PATCHES PROPOSED TO BACKPORT: http://svn.apache.org/viewvc?rev=958615&view=rev +1: kkolinko -1: + +* Remove *.rtf from fixcrlf patternset. + No need for native line ends in RTF files. + Their spec indicates they should use CRLF. + Backport form trunk: + http://svn.apache.org/viewvc?rev=960350&view=rev + TC 6 patch: + http://people.apache.org/~rjung/patches/tc6-remove-rtf-from-fixcrlf.patch + +1: rjung + -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r960355 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: rjung Date: Sun Jul 4 16:19:07 2010 New Revision: 960355 URL: http://svn.apache.org/viewvc?rev=960355&view=rev Log: Vote. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=960355&r1=960354&r2=960355&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Sun Jul 4 16:19:07 2010 @@ -148,7 +148,7 @@ PATCHES PROPOSED TO BACKPORT: I propose the following patch, but without removing the "not for production" warning from JavaDoc: http://svn.apache.org/viewvc?rev=958615&view=rev - +1: kkolinko + +1: kkolinko, rjung -1: * Remove *.rtf from fixcrlf patternset. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: RTF and fixcrlf during build
On Jul 4, 2010, at 11:15 AM, Mark Thomas wrote: > On 04/07/2010 12:00, Rainer Jung wrote: >> The fixcrlf handling of RTF files when packed into the source >> distribution has changed as a side effect of >> >> http://svn.apache.org/viewvc?view=revision&revision=893572 >> >> It was "don't change" before and "fix" after. >> >> It seems the RTF spec is at least unclear about correct line endings >> with a tendency to implicitely assume CRLF. I would favor not touching >> the RTF files, so to remove "**/*.rtf" from the patternset. > > +1. No objections here. > Agreed. +1 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49548] New: Refactoring SetSupport
https://issues.apache.org/bugzilla/show_bug.cgi?id=49548 Summary: Refactoring SetSupport Product: Taglibs Version: 1.2.0 Platform: PC Status: NEW Severity: enhancement Priority: P2 Component: Standard Taglib AssignedTo: dev@tomcat.apache.org ReportedBy: jboy...@apache.org This started with "add some more test cases for the setting code" and got more momentum. Patch primarily adds test cases and refactors the large "if" clause that sets the result into smaller methods. It also clears up IDE warnings (at least from IDEA). One side effect was I18N of the exception message for "SET_BAD_DEFERRED_SCOPE" This also required changing the POM so that the resources were included (that perhaps could have been a separate patch). We could also move the resource bundles to Maven's default of src/main/resources. I18N also needed access to the original value (which was not being retained) and in conjunction with that I replaced the "scopeSpecified" indicator with a check on whether the "scope" attribute is null. I also changed the comment where the exception is thrown when target is null. This can happen as target is a request-time attribute and the spec does define this behaviour. When setting a bean property, the for loop now exits after setting its property rather than continuing to iterate through all of them. This should have no impact unless a bean can have two PropertyDescriptors with the same name and I don't believe it can. Finally, all throws of JspException were replaced with JspTagException as these are errors coming from a Tag Handler rather than the JSP Engine itself. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49548] Refactoring SetSupport
https://issues.apache.org/bugzilla/show_bug.cgi?id=49548 --- Comment #1 from Jeremy Boynes 2010-07-04 12:23:01 EDT --- Created an attachment (id=25694) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25694) Refactors SetSupport -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[taglibs] Null handling in Functions
Different methods in our Functions implementation handle null parameters inconsistently; for example, toUpperCase does not perform any null check whereas indexOf does. If I grok the EL spec correctly, all String parameter values should be coerced by the rules in 1.18.2 which would guarantee that nulls are converted to "" and hence the null checks in the implementation are redundant. I confirmed that the EL implementation in Tomcat 7 [1] does this. My thought would be to remove them and rely on the JSP Engine to coerce correctly. If this isn't safe then we should add similar checks to the other methods. Thoughts? Thanks Jeremy [1] http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/el/lang/ELSupport.java?view=markup#l405 called from AstFunction#getValue - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Proposal: Some todo's at AsyncContext detected...
On 01.07.2010 18:42, Rainer Jung wrote: On 01.07.2010 17:20, Marc Guillemot wrote: jean-frederic clere wrote: ... I run a daily test and just looked to what breaks it and complain. Now I am looking to Peter's application to find what is broken. so you're the continuous integration server ;-) Can you publish break information or is it forbidden by the TCK license/agreement? Exact details are forbidden, but I'm sure there'll be some information The symptom is: it breaks "If this request has been dispatched using one of the AsyncContext.dispatch methods since it was put in asynchronous mode, this method returns false." which is part of the spec description of "public boolean isAsyncStarted()". Regards, Rainer - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Proposal: Some todo's at AsyncContext detected...
Hmm,
Spec says:
public boolean isAsyncStarted() - Returns true if async processing
has started on this request, and false otherwise. If this request has
been
dispatched using one of the AsyncContext.dispatch methods since it was
put in asynchronous mode, or a call to AsynContext.complete is made,
this
method returns false.
===
But the example with Bug 49528 don't call directly dispatch, it calls
AsyncContext.start().
At Tomcat we start doesn't start a Container Thread. We internally
call a doInternalDispatch at StandardWrapperValve
with the callee thread.
...
} else {
if (request.isAsyncDispatching()) {
//TODO SERVLET3 - async
((AsyncContextImpl)request.getAsyncContext()).doInternalDispatch();
...
I revert the fix, and correct the testcase.
Peter
Am 04.07.2010 um 21:23 schrieb Rainer Jung:
On 01.07.2010 18:42, Rainer Jung wrote:
On 01.07.2010 17:20, Marc Guillemot wrote:
jean-frederic clere wrote:
...
I run a daily test and just looked to what breaks it and complain.
Now I am looking to Peter's application to find what is broken.
so you're the continuous integration server ;-)
Can you publish break information or is it forbidden by the TCK
license/agreement?
Exact details are forbidden, but I'm sure there'll be some
information
The symptom is: it breaks
"If this request has been dispatched using one of the
AsyncContext.dispatch methods since it was put in asynchronous mode,
this method returns false."
which is part of the spec description of "public boolean
isAsyncStarted()".
Regards,
Rainer
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r960348 - in /tomcat/trunk: java/org/apache/tomcat/util/net/JIoEndpoint.java test/org/apache/catalina/core/TestAsyncListener.java webapps/docs/changelog.xml
Hi Mark, why you remove and doesn't correct the TestCases? Please, explain how a AsyncListner can receive onTimeout ? Peter Am 04.07.2010 um 17:44 schrieb ma...@apache.org: Author: markt Date: Sun Jul 4 15:44:45 2010 New Revision: 960348 URL: http://svn.apache.org/viewvc?rev=960348&view=rev Log: Revert r958362, r960083, r958406, r960069. r958362 broke the TCK tests and the other commits were sufficiently tightly coupled to it that it was easier to revert all of them than try to unpick them. Removed: tomcat/trunk/test/org/apache/catalina/core/TestAsyncListener.java Modified: tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/java/org/apache/tomcat/util/net/ JIoEndpoint.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java?rev=960348&r1=960347&r2=960348&view=diff = = = = = = = = == --- tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java (original) +++ tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java Sun Jul 4 15:44:45 2010 @@ -399,11 +399,6 @@ public class JIoEndpoint extends Abstrac acceptorThread.setDaemon(getDaemon()); acceptorThread.start(); } - -// Start async timeout thread -Thread timeoutThread = new Thread(new AsyncTimeout(),getName() + "-AsyncTimeout"); -timeoutThread.setDaemon(true); -timeoutThread.start(); } } Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=960348&r1=960347&r2=960348&view=diff = = = = = = = = == --- tomcat/trunk/webapps/docs/changelog.xml (original) +++ tomcat/trunk/webapps/docs/changelog.xml Sun Jul 4 15:44:45 2010 @@ -98,14 +98,6 @@ - - - -Start JioEndpoint timeout thread, to inform AsyncListner as async timeout is detected -and application thread doesn't finished the request. (pero) - - - - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r960391 - /tomcat/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java
Author: markt
Date: Sun Jul 4 20:34:02 2010
New Revision: 960391
URL: http://svn.apache.org/viewvc?rev=960391&view=rev
Log:
Add a test case for https://issues.apache.org/bugzilla/show_bug.cgi?id=49528
Added:
tomcat/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java
(with props)
Added: tomcat/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java?rev=960391&view=auto
==
--- tomcat/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java (added)
+++ tomcat/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java Sun
Jul 4 20:34:02 2010
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.catalina.core;
+
+import java.io.IOException;
+
+import javax.servlet.ServletException;
+import javax.servlet.http.HttpServlet;
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+
+import org.apache.catalina.Context;
+import org.apache.catalina.Wrapper;
+import org.apache.catalina.startup.Tomcat;
+import org.apache.catalina.startup.TomcatBaseTest;
+
+public class TestAsyncContextImpl extends TomcatBaseTest {
+
+public void testBug49528() throws Exception {
+// Setup Tomcat instance
+Tomcat tomcat = getTomcatInstance();
+
+// Must have a real docBase - just use temp
+Context ctx =
+tomcat.addContext("/", System.getProperty("java.io.tmpdir"));
+
+Bug49528Servlet servlet = new Bug49528Servlet();
+
+Wrapper wrapper = Tomcat.addServlet(ctx, "servlet", servlet);
+wrapper.setAsyncSupported(true);
+ctx.addServletMapping("/", "servlet");
+
+tomcat.start();
+
+// Call the servlet once
+getUrl("http://localhost:"; + getPort() + "/");
+
+assertEquals("", servlet.getErrors());
+}
+
+private static class Bug49528Servlet extends HttpServlet {
+
+private static final long serialVersionUID = 1L;
+
+private StringBuilder errors = new StringBuilder();
+
+public String getErrors() {
+return errors.toString();
+}
+
+@Override
+protected void doGet(final HttpServletRequest req,
+final HttpServletResponse resp)
+throws ServletException, IOException {
+
+confirmFalse("1", req);
+req.startAsync();
+confirmTrue("2", req);
+
+req.getAsyncContext().start(new Runnable() {
+@Override
+public void run() {
+try {
+confirmTrue("3", req);
+Thread.sleep(1000);
+confirmTrue("4", req);
+req.getAsyncContext().complete();
+confirmFalse("5", req);
+} catch (InterruptedException e) {
+// TODO Auto-generated catch block
+e.printStackTrace();
+}
+}
+});
+// Pointless method call so there is somewhere to put a break point
+// when debugging
+req.getMethod();
+}
+
+private void confirmFalse(String stage, HttpServletRequest req) {
+if (req.isAsyncStarted()) {
+errors.append("Stage " + stage +
+": Async started when not expected\n");
+}
+}
+
+private void confirmTrue(String stage, HttpServletRequest req) {
+if (!req.isAsyncStarted()) {
+errors.append("Stage " + stage +
+": Async not started when expected\n");
+}
+}
+
+}
+}
Propchange: tomcat/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java
--
svn:eol-style = native
-
To un
svn commit: r960392 - in /tomcat/trunk: java/org/apache/catalina/core/AsyncContextImpl.java webapps/docs/changelog.xml
Author: markt
Date: Sun Jul 4 20:38:41 2010
New Revision: 960392
URL: http://svn.apache.org/viewvc?rev=960392&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49528
AsyncContext.start() uses an internal dispatch but this should not have the
same side-effects as calling dispatch()
TCK and test cases passes with this patch
Modified:
tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java?rev=960392&r1=960391&r2=960392&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java (original)
+++ tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java Sun Jul 4
20:38:41 2010
@@ -48,7 +48,8 @@ import org.apache.juli.logging.LogFactor
public class AsyncContextImpl implements AsyncContext {
public static enum AsyncState {
-NOT_STARTED, STARTED, DISPATCHING, DISPATCHED, COMPLETING, TIMING_OUT,
ERROR_DISPATCHING
+NOT_STARTED, STARTED, DISPATCHING, DISPATCHING_INTERNAL, DISPATCHED,
+COMPLETING, TIMING_OUT, ERROR_DISPATCHING
}
private static final Log log = LogFactory.getLog(AsyncContextImpl.class);
@@ -178,8 +179,8 @@ public class AsyncContextImpl implements
log.debug("AsyncContext Start Called["+state.get()+";
"+request.getRequestURI()+"?"+request.getQueryString()+"]", new
DebugException());
}
-if (state.compareAndSet(AsyncState.STARTED, AsyncState.DISPATCHING) ||
-state.compareAndSet(AsyncState.DISPATCHED,
AsyncState.DISPATCHING)) {
+if (state.compareAndSet(AsyncState.STARTED,
AsyncState.DISPATCHING_INTERNAL) ||
+state.compareAndSet(AsyncState.DISPATCHED,
AsyncState.DISPATCHING_INTERNAL)) {
// TODO SERVLET3 - async
final ServletContext sctx =
getServletRequest().getServletContext();
Runnable r = new Runnable() {
@@ -333,6 +334,20 @@ public class AsyncContextImpl implements
dispatch = null;
}
}
+} else if (this.state.get() == AsyncState.DISPATCHING_INTERNAL) {
+if (this.dispatch!=null) {
+try {
+dispatch.run();
+} catch (RuntimeException x) {
+doInternalComplete(true);
+if (x.getCause() instanceof ServletException) throw
(ServletException)x.getCause();
+if (x.getCause() instanceof IOException) throw
(IOException)x.getCause();
+else throw new ServletException(x);
+} finally {
+dispatch = null;
+this.state.set(AsyncState.DISPATCHED);
+}
+}
} else if (this.state.get()==AsyncState.COMPLETING) {
doInternalComplete(false);
} else {
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=960392&r1=960391&r2=960392&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Sun Jul 4 20:38:41 2010
@@ -84,6 +84,13 @@
rather than an empty string. (markt)
+49528: Ensure AsyncContext.isAsyncStarted() returns the
+correct value after AsyncContext.start(). Tomcat implements this
+using an internal dispatch that requires slightly different treatment
+from a standard dispatch to ensure the correct value is returned.
+(markt)
+
+
49530: Contexts and Servlets not stopped when Tomcat is shut
down. (markt)
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49528] HttpServletRequest.isAsyncStarted() returns false when a Runnable is started
https://issues.apache.org/bugzilla/show_bug.cgi?id=49528 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||FIXED --- Comment #4 from Mark Thomas 2010-07-04 16:39:54 EDT --- I have reverted the original fix and applied a new fix that fixes the issue described here and still passes the Servlet TCK. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49543] Request for a "shared" datasource configuration as in DBCP
https://issues.apache.org/bugzilla/show_bug.cgi?id=49543 Mark Thomas changed: What|Removed |Added Severity|normal |enhancement --- Comment #2 from Mark Thomas 2010-07-04 16:43:55 EDT --- Marking as an enhancement. Since the original developer of this module is not available at the moment, there is unlikely to be any progress on this for several months. A patch would certainly help progress things. I would also note that keeping jdbc-pool simple and not to fully implement every feature in DBCP was a deliberate design decision. Any patch should bear this in mind and should ideally provide this feature as an optional extra that does not add any overhead for users that do not wish to use it. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r960393 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: kkolinko Date: Sun Jul 4 20:45:42 2010 New Revision: 960393 URL: http://svn.apache.org/viewvc?rev=960393&view=rev Log: vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=960393&r1=960392&r2=960393&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Sun Jul 4 20:45:42 2010 @@ -158,5 +158,5 @@ PATCHES PROPOSED TO BACKPORT: http://svn.apache.org/viewvc?rev=960350&view=rev TC 6 patch: http://people.apache.org/~rjung/patches/tc6-remove-rtf-from-fixcrlf.patch - +1: rjung + +1: rjung, kkolinko -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r960394 - /tomcat/trunk/webapps/docs/changelog.xml
Author: markt Date: Sun Jul 4 20:48:07 2010 New Revision: 960394 URL: http://svn.apache.org/viewvc?rev=960394&view=rev Log: Clean up Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=960394&r1=960393&r2=960394&view=diff == --- tomcat/trunk/webapps/docs/changelog.xml (original) +++ tomcat/trunk/webapps/docs/changelog.xml Sun Jul 4 20:48:07 2010 @@ -112,7 +112,7 @@ Correct over zealous type checking for EL in attributes that broke the -use of JSF convertors. (markt) +use of JSF converters. (markt) Correct algorithm used to identify correct method to use when a @@ -160,7 +160,7 @@ Switch the Host Manager application to the generic CSRF protection for the HTML interface and prevent started hosts from being started and -stopped hosts from being stopped. +stopped hosts from being stopped. (markt) 49518: Fix typo in extras documentation. (markt) @@ -183,7 +183,8 @@ Improve and document VirtualWebappLoader. (rjung) -43642: Add prestartminSpareThreads attribute for Executor. (jfclere) +43642: Add prestartminSpareThreads attribute for Executor. +(jfclere) Switch from AnnotationProcessor to InstanceManager. Patch provided by @@ -229,9 +230,9 @@ queue size and a timeout for adding jobs to the queue. (fhanik) -Add support for aliases to StandardContext. This allows content from other -directories and/or WAR files to be mapped to paths within the context. -(markt) +Add support for aliases to StandardContext. This allows content from +other directories and/or WAR files to be mapped to paths within the +context. (markt) Provide clearer definition of Lifecycle interface, particularly start @@ -296,8 +297,8 @@ Update EL support to the EL 2.2 specification. (markt) -787978 Use "1.6" as the default value for compilerSourceVM and compilerTargetVM -options of Jasper. (kkolinko) +787978 Use "1.6" as the default value for compilerSourceVM +and compilerTargetVM options of Jasper. (kkolinko) 48358: Add support for limiting the number of JSPs that are - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49428] Fix WebDAV mounts from Windows Mini-Redirector clients
https://issues.apache.org/bugzilla/show_bug.cgi?id=49428 --- Comment #2 from Mark Thomas 2010-07-04 18:08:41 EDT --- Please run the litmus test suite with your patch. Whilst the current implementation has some failures (and patches for those would be welcome too) the current patch for this issue causes additional failures. I have taken a quick look at what is going on with tcpmon from the Apache Axis project and it looks like xmlns:D="DAV:" is being added in some circumstances without D: then being added to some (all?) elements. I'd be happy to apply this patch once it does not add to the number of litmus failures. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 37449] Support multi-Realms at Engine element
https://issues.apache.org/bugzilla/show_bug.cgi?id=37449 --- Comment #9 from Bruno Braga 2010-07-04 18:12:55 EDT --- Created an attachment (id=25696) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25696) backport tomcat windows -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 37449] Support multi-Realms at Engine element
https://issues.apache.org/bugzilla/show_bug.cgi?id=37449 --- Comment #10 from Bruno Braga 2010-07-04 18:13:42 EDT --- Ok. IBM Rational Team Concert isn't officially supported on Tomcat 6 yet. So I get the Tomcat 6.0 and 5.5 source code and wrote a back-port for this feature (CombinedRealm). Now CombinedRealm can be used in Tomcat 5.5. Attached I am sending a new catalina.jar If someone wants to use to support multi-LDAP or LDAP + local user, should backup and replace the original file: JazzServer\server\tomcat\server\lib\catalina.jar The catalina.jar for windows and linux are different (size and content), so I considered it and made two catalina.jar. For information this backport change these files: org/apache/catalina/realm/LocalStrings.properties org/apache/catalina/realm/mbeans-descriptors.xml org/apache/catalina/realm/CombinedRealm.java org/apache/catalina/realm/RealmBase.java org/apache/catalina/startup/RealmRuleSet.java org/apache/catalina/startup/EngineRuleSet.java org/apache/catalina/startup/ContextRuleSet.java org/apache/catalina/startup/HostRuleSet.java Documentation is the same of Tomcat 6.0 and available at: http://tomcat.apache.org/tomcat-6.0-doc/realm-howto.html#CombinedRealm -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 37449] Support multi-Realms at Engine element
https://issues.apache.org/bugzilla/show_bug.cgi?id=37449 --- Comment #8 from Bruno Braga 2010-07-04 18:11:08 EDT --- Created an attachment (id=25695) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25695) backport tomcat linux -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r960416 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: kfujino Date: Mon Jul 5 01:07:45 2010 New Revision: 960416 URL: http://svn.apache.org/viewvc?rev=960416&view=rev Log: vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=960416&r1=960415&r2=960416&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Mon Jul 5 01:07:45 2010 @@ -148,7 +148,7 @@ PATCHES PROPOSED TO BACKPORT: I propose the following patch, but without removing the "not for production" warning from JavaDoc: http://svn.apache.org/viewvc?rev=958615&view=rev - +1: kkolinko, rjung + +1: kkolinko, rjung, kfujino -1: * Remove *.rtf from fixcrlf patternset. @@ -158,5 +158,5 @@ PATCHES PROPOSED TO BACKPORT: http://svn.apache.org/viewvc?rev=960350&view=rev TC 6 patch: http://people.apache.org/~rjung/patches/tc6-remove-rtf-from-fixcrlf.patch - +1: rjung, kkolinko + +1: rjung, kkolinko, kfujino -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 27717] very slow in JSTL 1.1
https://issues.apache.org/bugzilla/show_bug.cgi?id=27717 --- Comment #18 from Jeremy Boynes 2010-07-04 21:28:58 EDT --- (In reply to comment #17) > CachedXPathAPI says that: "A faster way is to precompile the XPaths using the > low-level API, and then just use the XPaths over and over". That sounds quite > attractive - each x:out could precompile an XPath and run it on its node. The > pain there is figuring out how to use the low level XPath API. Java5 introduced a standard XPath API that supports pre-compilation of XPath expressions. How about parsing the supplied XPath in the setter for the tag attribute and relying on tag pooling to avoid unnecessary recompilations? The API also provides for a XPathVariableResolver that could work with the ELResolver to handle variables present in the XPath expressions. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r960430 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: pero Date: Mon Jul 5 03:34:53 2010 New Revision: 960430 URL: http://svn.apache.org/viewvc?rev=960430&view=rev Log: Vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=960430&r1=960429&r2=960430&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Mon Jul 5 03:34:53 2010 @@ -100,7 +100,7 @@ PATCHES PROPOSED TO BACKPORT: Respect configurable search order in getURLs(). http://svn.apache.org/viewvc?view=revision&revision=936892 http://people.apache.org/~rjung/patches/2010-05-14-loader-backport-r936892.patch - +1: rjung, kkolinko + +1: rjung, kkolinko, pero -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49343 @@ -140,7 +140,7 @@ PATCHES PROPOSED TO BACKPORT: but using the new roles (manager-gui, admin-gui etc.) will not bypass the CSRF protection. http://people.apache.org/~markt/patches/2010-06-26-crsf-prevention-filter-tc6.patch - +1: markt + +1: markt, pero -1: * Add support for *.jar pattern in VirtualWebappLoader @@ -148,7 +148,7 @@ PATCHES PROPOSED TO BACKPORT: I propose the following patch, but without removing the "not for production" warning from JavaDoc: http://svn.apache.org/viewvc?rev=958615&view=rev - +1: kkolinko, rjung, kfujino + +1: kkolinko, rjung, kfujino, pero -1: * Remove *.rtf from fixcrlf patternset. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [taglibs] Null handling in Functions
Agreed on 1.18.2. For String params (and Number, Character and Boolean) it looks like Functions should be able to assume that they're null-safe. Hen On Sun, Jul 4, 2010 at 12:20 PM, Jeremy Boynes wrote: > Different methods in our Functions implementation handle null parameters > inconsistently; for example, toUpperCase does not perform any null check > whereas indexOf does. If I grok the EL spec correctly, all String parameter > values should be coerced by the rules in 1.18.2 which would guarantee that > nulls are converted to "" and hence the null checks in the implementation are > redundant. I confirmed that the EL implementation in Tomcat 7 [1] does this. > > My thought would be to remove them and rely on the JSP Engine to coerce > correctly. If this isn't safe then we should add similar checks to the other > methods. > > Thoughts? > Thanks > Jeremy > > [1] > http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/el/lang/ELSupport.java?view=markup#l405 > called from AstFunction#getValue > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Proposal: Some todo's at AsyncContext detected...
On 04.07.2010 22:11, Peter Roßbach wrote:
Hmm,
Spec says:
public boolean isAsyncStarted() - Returns true if async processing
has started on this request, and false otherwise. If this request has been
dispatched using one of the AsyncContext.dispatch methods since it was
put in asynchronous mode, or a call to AsynContext.complete is made, this
method returns false.
===
But the example with Bug 49528 don't call directly dispatch, it calls
AsyncContext.start().
At Tomcat we start doesn't start a Container Thread. We internally call
a doInternalDispatch at StandardWrapperValve
with the callee thread.
...
} else {
if (request.isAsyncDispatching()) {
//TODO SERVLET3 - async
((AsyncContextImpl)request.getAsyncContext()).doInternalDispatch();
...
I revert the fix, and correct the testcase.
I wasn't commenting a specific BZ issue or your test case. I was
commenting the TCK failure JFC noticed. It simply checks the cited
requirement on isAsyncStarted() and fails after your change that starts
the AsyncTimeout thread. Without your change it works.
Regards,
Rainer
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r960460 - in /tomcat/tc6.0.x/trunk: STATUS.txt dist.xml
Author: rjung Date: Mon Jul 5 06:55:26 2010 New Revision: 960460 URL: http://svn.apache.org/viewvc?rev=960460&view=rev Log: Remove *.rtf from fixcrlf patternset. No need for native line ends in RTF files. Their spec indicates they should use CRLF. Backport of r960350 from trunk. Modified: tomcat/tc6.0.x/trunk/STATUS.txt tomcat/tc6.0.x/trunk/dist.xml Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=960460&r1=960459&r2=960460&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Mon Jul 5 06:55:26 2010 @@ -150,13 +150,3 @@ PATCHES PROPOSED TO BACKPORT: http://svn.apache.org/viewvc?rev=958615&view=rev +1: kkolinko, rjung, kfujino, pero -1: - -* Remove *.rtf from fixcrlf patternset. - No need for native line ends in RTF files. - Their spec indicates they should use CRLF. - Backport form trunk: - http://svn.apache.org/viewvc?rev=960350&view=rev - TC 6 patch: - http://people.apache.org/~rjung/patches/tc6-remove-rtf-from-fixcrlf.patch - +1: rjung, kkolinko, kfujino - -1: Modified: tomcat/tc6.0.x/trunk/dist.xml URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/dist.xml?rev=960460&r1=960459&r2=960460&view=diff == --- tomcat/tc6.0.x/trunk/dist.xml (original) +++ tomcat/tc6.0.x/trunk/dist.xml Mon Jul 5 06:55:26 2010 @@ -123,7 +123,6 @@ - - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
