svn commit: r933140 - /tomcat/trunk/test/org/apache/el/parser/TestELParser.java
Author: markt
Date: Mon Apr 12 08:26:34 2010
New Revision: 933140
URL: http://svn.apache.org/viewvc?rev=933140&view=rev
Log:
Re-factor to allow easier addition of extra tests
Modified:
tomcat/trunk/test/org/apache/el/parser/TestELParser.java
Modified: tomcat/trunk/test/org/apache/el/parser/TestELParser.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/el/parser/TestELParser.java?rev=933140&r1=933139&r2=933140&view=diff
==
--- tomcat/trunk/test/org/apache/el/parser/TestELParser.java (original)
+++ tomcat/trunk/test/org/apache/el/parser/TestELParser.java Mon Apr 12
08:26:34 2010
@@ -28,15 +28,17 @@ import junit.framework.TestCase;
public class TestELParser extends TestCase {
public void testBug49081() {
+testExpression("#${1+1}", "#2");
+}
+
+private void testExpression(String expression, String expected) {
ExpressionFactory factory = ExpressionFactory.newInstance();
ELContext context = new ELContextImpl();
ValueExpression ve = factory.createValueExpression(
-context, "#${1+1}", String.class);
+context, expression, String.class);
-// First check the basics work
String result = (String) ve.getValue(context);
-assertEquals("#2", result);
+assertEquals(expected, result);
}
-
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r933141 - /tomcat/trunk/test/org/apache/el/parser/TestELParser.java
Author: markt
Date: Mon Apr 12 08:32:22 2010
New Revision: 933141
URL: http://svn.apache.org/viewvc?rev=933141&view=rev
Log:
Add some additional tests
Modified:
tomcat/trunk/test/org/apache/el/parser/TestELParser.java
Modified: tomcat/trunk/test/org/apache/el/parser/TestELParser.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/el/parser/TestELParser.java?rev=933141&r1=933140&r2=933141&view=diff
==
--- tomcat/trunk/test/org/apache/el/parser/TestELParser.java (original)
+++ tomcat/trunk/test/org/apache/el/parser/TestELParser.java Mon Apr 12
08:32:22 2010
@@ -28,8 +28,32 @@ import junit.framework.TestCase;
public class TestELParser extends TestCase {
public void testBug49081() {
+// OP's report
testExpression("#${1+1}", "#2");
-}
+
+// Variations on a theme
+testExpression("#", "#");
+testExpression("##", "##");
+testExpression("###", "###");
+testExpression("$", "$");
+testExpression("$$", "$$");
+testExpression("$$$", "$$$");
+testExpression("#$", "#$");
+testExpression("#$#", "#$#");
+testExpression("$#", "$#");
+testExpression("$#$", "$#$");
+
+testExpression("#{1+1}", "2");
+testExpression("##{1+1}", "#2");
+testExpression("###{1+1}", "##2");
+testExpression("${1+1}", "2");
+testExpression("$${1+1}", "$2");
+testExpression("$$${1+1}", "$$2");
+testExpression("#${1+1}", "#2");
+testExpression("#$#{1+1}", "#$2");
+testExpression("$#{1+1}", "$2");
+testExpression("$#${1+1}", "$#2");
+}
private void testExpression(String expression, String expected) {
ExpressionFactory factory = ExpressionFactory.newInstance();
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r933162 - /tomcat/trunk/java/javax/el/ExpressionFactory.java
Author: markt
Date: Mon Apr 12 09:26:39 2010
New Revision: 933162
URL: http://svn.apache.org/viewvc?rev=933162&view=rev
Log:
Partial fox for https://issues.apache.org/bugzilla/show_bug.cgi?id=49082
java.home may not include the final path separator
Modified:
tomcat/trunk/java/javax/el/ExpressionFactory.java
Modified: tomcat/trunk/java/javax/el/ExpressionFactory.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/javax/el/ExpressionFactory.java?rev=933162&r1=933161&r2=933162&view=diff
==
--- tomcat/trunk/java/javax/el/ExpressionFactory.java (original)
+++ tomcat/trunk/java/javax/el/ExpressionFactory.java Mon Apr 12 09:26:39 2010
@@ -63,8 +63,8 @@ public abstract class ExpressionFactory
new PrivilegedAction(){
@Override
public String run() {
-return System.getProperty("java.home") + "lib" +
-SEP + "el.properties";
+return System.getProperty("java.home") + SEP +
+"lib" + SEP + "el.properties";
}
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49082] ExpressionFactory.newInstance needs to be privileged
https://issues.apache.org/bugzilla/show_bug.cgi?id=49082 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #1 from Mark Thomas 2010-04-12 05:28:11 EDT --- Thanks for the report. The AccessControlException issue (and a couple of others) was fixed when the EL impl was tested with the TCK and a security manager. I've just fixed the missing separator issue. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r933165 - /tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
Author: markt
Date: Mon Apr 12 09:35:52 2010
New Revision: 933165
URL: http://svn.apache.org/viewvc?rev=933165&view=rev
Log:
Make public constant final
Modified:
tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
Modified: tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java?rev=933165&r1=933164&r2=933165&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java (original)
+++ tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java Mon Apr 12
09:35:52 2010
@@ -38,7 +38,7 @@ import java.sql.Timestamp;
public class ChannelData implements ChannelMessage {
public static final ChannelData[] EMPTY_DATA_ARRAY = new ChannelData[0];
-public static boolean USE_SECURE_RANDOM_FOR_UUID = false;
+public static final boolean USE_SECURE_RANDOM_FOR_UUID = false;
/**
* The options this message was sent with
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49089] ChannelData.USE_SECURE_RANDOM_FOR_UUID public static mutable field
https://issues.apache.org/bugzilla/show_bug.cgi?id=49089 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #1 from Mark Thomas 2010-04-12 05:36:02 EDT --- I've made it final. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r933167 - /tomcat/trunk/java/org/apache/jasper/tagplugins/jstl/Util.java
Author: markt
Date: Mon Apr 12 09:42:07 2010
New Revision: 933167
URL: http://svn.apache.org/viewvc?rev=933167&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49091
Reduce visibility
Modified:
tomcat/trunk/java/org/apache/jasper/tagplugins/jstl/Util.java
Modified: tomcat/trunk/java/org/apache/jasper/tagplugins/jstl/Util.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/tagplugins/jstl/Util.java?rev=933167&r1=933166&r2=933167&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/tagplugins/jstl/Util.java (original)
+++ tomcat/trunk/java/org/apache/jasper/tagplugins/jstl/Util.java Mon Apr 12
09:42:07 2010
@@ -50,7 +50,7 @@ public class Util {
public static final int HIGHEST_SPECIAL = '>';
-public static char[][] specialCharactersRepresentation = new
char[HIGHEST_SPECIAL + 1][];
+private static char[][] specialCharactersRepresentation = new
char[HIGHEST_SPECIAL + 1][];
static {
specialCharactersRepresentation['&'] = "&".toCharArray();
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49091] Util.specialCharactersRepresentation should be private
https://issues.apache.org/bugzilla/show_bug.cgi?id=49091 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #1 from Mark Thomas 2010-04-12 05:42:39 EDT --- Fixed in trunk. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r933168 - /tomcat/trunk/java/org/apache/tomcat/util/IntrospectionUtils.java
Author: markt
Date: Mon Apr 12 09:47:42 2010
New Revision: 933168
URL: http://svn.apache.org/viewvc?rev=933168&view=rev
Log:
Make constant final
Modified:
tomcat/trunk/java/org/apache/tomcat/util/IntrospectionUtils.java
Modified: tomcat/trunk/java/org/apache/tomcat/util/IntrospectionUtils.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/IntrospectionUtils.java?rev=933168&r1=933167&r2=933168&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/IntrospectionUtils.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/IntrospectionUtils.java Mon Apr 12
09:47:42 2010
@@ -231,7 +231,7 @@ public final class IntrospectionUtils {
}
}
-public static String PATH_SEPARATOR = System.getProperty("path.separator");
+public final static String PATH_SEPARATOR =
System.getProperty("path.separator");
/**
* Adds classpath entries from a vector of URL's to the "tc_path_add"
System
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49092] util.IntrospectionUtils.PATH_SEPARATOR should be final
https://issues.apache.org/bugzilla/show_bug.cgi?id=49092 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #1 from Mark Thomas 2010-04-12 05:48:02 EDT --- Fixed. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r933171 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt
Date: Mon Apr 12 10:17:55 2010
New Revision: 933171
URL: http://svn.apache.org/viewvc?rev=933171&view=rev
Log:
Proposal
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=933171&r1=933170&r2=933171&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Mon Apr 12 10:17:55 2010
@@ -249,3 +249,11 @@ PATCHES PROPOSED TO BACKPORT:
http://people.apache.org/~markt/patches/2010-04-08-bug48379.patch
+1: markt, kfujino
-1:
+
+* https://issues.apache.org/bugzilla/show_bug.cgi?id=49081
+ "#${1+1}" should evaluate to "#2"
+ http://svn.apache.org/viewvc?rev=932967&view=rev
+ Note that all files apart from ELParser.jjt are generated by javacc from the
+ changes to ELParser.jjt
+ +1: markt
+ -1:
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49081] EL expression preceded by a # in an attribute value of jsp documents
https://issues.apache.org/bugzilla/show_bug.cgi?id=49081 --- Comment #1 from Mark Thomas 2010-04-12 06:18:55 EDT --- This has been fixed in trunk and proposed for 6.0.x. Note that the root cause was a bug in the definition of literals in the EL spec. I have raised a bug against the EL spec for this. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Patch suggestion
On 11 April 2010 14:56, Pid * wrote:
>
> On 11 April 2010 00:17, Konstantin Kolinko wrote:
>
>> 2010/4/10 Pid :
>> > In lieu of of a Bugzilla enhancement (and hoping that I have the right
>> end
>> > of the stick).
>> >
>>
>> If I guess your intention correctly,
>> you want to prevent deployment of a war file that is still open for
>> writing?
>>
>
> Yes. I should have been more explicit. The patch was prompted by a message
> to the User list a little while ago.
> The user uploaded a .war directly to the webapps directory and was
> surprised to discover Tomcat throwing exceptions when it tried to deploy the
> incomplete file.
>
I suspect that the thread on the Users list "" is in the same category as
the problem I describe.
> If that is the case, then asking for modification time probably will
>> not work. The file properties in the file system are usually not
>> updated that frequently. Though that might differ between OSes. Also,
>> if the file is being transmitted over network, the update frequency
>> depends on how fast is the connection that is used to upload the file.
>>
>> As far as I remember my experience, I think that a file that is still
>> being written can be detected by asking its length. Such files can be
>> listed by shell to be of length 0.
>>
>> Needs more research and some summary across OSes though.
>>
>
> I will test Linux, OSX.
>
When uploading a war of 5Mb to an RHL linux server, a simple class which
monitors (every 100ms) the size of the file reports the current file size
changing as the bytes arrive in chunks of 16k, the file size remains the
same for 5-8 runs of the loop either before enough packets have arrived, or
the file system updates.
Which means waiting for maybe 1000ms to see a change, which isn't ideal as
KK points out.
p
> At least, if the war file is of length 0 it can be safely skipped for
>> obvious reasons.
>>
>> >try {
>> >Thread.sleep(500);
>> >}
>>
>> I do not like unconditionally sleeping for every file. 20 wars = 10
>> seconds to sleep, even if none of them is going to be deployed
>>
>
> Fair enough. If the file size detectably zero, then calling continue would
> be sufficient to prevent the attempt at deploying the war. I think it would
> be good to log a warning here too.
>
>
> p
>
>
>> Time could be compared against the interval between autoDeploy cycle
>> runs, if it is enabled, but there are also explicit calls from the
>> manager web application that must not be broken.
>>
>> The above is from my mind/memory. I have not researched it for this case.
>>
>> Best regards,
>> Konstantin Kolinko
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>
>>
>
>
> --
>
> --
> pidster.com
>
--
--
pidster.com
svn commit: r933179 - /tomcat/tc5.5.x/trunk/STATUS.txt
Author: jfclere Date: Mon Apr 12 10:26:58 2010 New Revision: 933179 URL: http://svn.apache.org/viewvc?rev=933179&view=rev Log: My votes. (the easy ones). Modified: tomcat/tc5.5.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=933179&r1=933178&r2=933179&view=diff == --- tomcat/tc5.5.x/trunk/STATUS.txt (original) +++ tomcat/tc5.5.x/trunk/STATUS.txt Mon Apr 12 10:26:58 2010 @@ -46,14 +46,14 @@ PATCHES PROPOSED TO BACKPORT: Fix compilation error with some nested tag files and simple tags https://issues.apache.org/bugzilla/show_bug.cgi?id=48616#c22 (https://issues.apache.org/bugzilla/attachment.cgi?id=24993) - +1: kkolinko, markt + +1: kkolinko, markt, jfclere -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=44041 Threading issue in class loading plus fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48694 a potential deadlock http://people.apache.org/~markt/patches/2010-03-25-bug44041.patch - +1: markt, kkolinko + +1: markt, kkolinko, jfclere -1: Mark ResourceEntry.loadedClass as volatile. @@ -124,5 +124,5 @@ PATCHES PROPOSED TO BACKPORT: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48843 Prevent possible deadlock for worker allocation in APR https://issues.apache.org/bugzilla/attachment.cgi?id=25226 - +1: kkolinko, markt + +1: kkolinko, markt, jfclere -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r933182 - /tomcat/tc5.5.x/trunk/STATUS.txt
Author: rjung Date: Mon Apr 12 10:31:00 2010 New Revision: 933182 URL: http://svn.apache.org/viewvc?rev=933182&view=rev Log: Vote. Modified: tomcat/tc5.5.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=933182&r1=933181&r2=933182&view=diff == --- tomcat/tc5.5.x/trunk/STATUS.txt (original) +++ tomcat/tc5.5.x/trunk/STATUS.txt Mon Apr 12 10:31:00 2010 @@ -58,7 +58,7 @@ PATCHES PROPOSED TO BACKPORT: Mark ResourceEntry.loadedClass as volatile. http://svn.apache.org/viewvc?rev=927877&view=rev - +1: kkolinko, markt + +1: kkolinko, markt, rjung -1: @@ -124,5 +124,5 @@ PATCHES PROPOSED TO BACKPORT: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48843 Prevent possible deadlock for worker allocation in APR https://issues.apache.org/bugzilla/attachment.cgi?id=25226 - +1: kkolinko, markt, jfclere + +1: kkolinko, markt, jfclere, rjung -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49086] Addition of Javadoc for Servlet 3.0 annotations
https://issues.apache.org/bugzilla/show_bug.cgi?id=49086 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #9 from Mark Thomas 2010-04-12 06:33:45 EDT --- Patches applied to trunk. Many thanks. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r933183 - in /tomcat/trunk/java/javax/servlet/annotation: HandlesTypes.java HttpConstraint.java HttpMethodConstraint.java MultipartConfig.java ServletSecurity.java WebFilter.java WebInitPa
Author: markt
Date: Mon Apr 12 10:34:09 2010
New Revision: 933183
URL: http://svn.apache.org/viewvc?rev=933183&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49086
Add Javadocs to javax.servlet.annotation
Patch provided by Pid.
Modified:
tomcat/trunk/java/javax/servlet/annotation/HandlesTypes.java
tomcat/trunk/java/javax/servlet/annotation/HttpConstraint.java
tomcat/trunk/java/javax/servlet/annotation/HttpMethodConstraint.java
tomcat/trunk/java/javax/servlet/annotation/MultipartConfig.java
tomcat/trunk/java/javax/servlet/annotation/ServletSecurity.java
tomcat/trunk/java/javax/servlet/annotation/WebFilter.java
tomcat/trunk/java/javax/servlet/annotation/WebInitParam.java
tomcat/trunk/java/javax/servlet/annotation/WebListener.java
tomcat/trunk/java/javax/servlet/annotation/WebServlet.java
Modified: tomcat/trunk/java/javax/servlet/annotation/HandlesTypes.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/javax/servlet/annotation/HandlesTypes.java?rev=933183&r1=933182&r2=933183&view=diff
==
--- tomcat/trunk/java/javax/servlet/annotation/HandlesTypes.java (original)
+++ tomcat/trunk/java/javax/servlet/annotation/HandlesTypes.java Mon Apr 12
10:34:09 2010
@@ -22,12 +22,19 @@ import java.lang.annotation.RetentionPol
import java.lang.annotation.Target;
/**
+ * This annotation is used to declare an array of application classes which are
+ * passed to a {...@link javax.servlet.ServletContainerInitializer}.
+ *
* @since Servlet 3.0
- * TODO SERVLET3 - Add comments
*/
@Target({ElementType.TYPE})
@Retention(RetentionPolicy.RUNTIME)
@SuppressWarnings("unchecked") // Spec API does not use generics
public @interface HandlesTypes {
+
+/**
+ * @return array of classes
+ */
Class[] value();
+
}
Modified: tomcat/trunk/java/javax/servlet/annotation/HttpConstraint.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/javax/servlet/annotation/HttpConstraint.java?rev=933183&r1=933182&r2=933183&view=diff
==
--- tomcat/trunk/java/javax/servlet/annotation/HttpConstraint.java (original)
+++ tomcat/trunk/java/javax/servlet/annotation/HttpConstraint.java Mon Apr 12
10:34:09 2010
@@ -24,13 +24,46 @@ import javax.servlet.annotation.ServletS
import javax.servlet.annotation.ServletSecurity.TransportGuarantee;
/**
+ * This annotation represents the security constraints that are applied to all
+ * requests with HTTP protocol method types that are not otherwise represented
+ * by a corresponding {...@link javax.servlet.annotation.HttpMethodConstraint}
in a
+ * {...@link javax.servlet.annotation.ServletSecurity} annotation.
+ *
* @since Servlet 3.0
- * TODO SERVLET3 - Add comments
*/
@Retention(RetentionPolicy.RUNTIME)
@Documented
public @interface HttpConstraint {
+
+/**
+ * The EmptyRoleSemantic determines the behaviour when the rolesAllowed
list
+ * is empty.
+ *
+ * @return empty role semantic
+ */
EmptyRoleSemantic value() default EmptyRoleSemantic.PERMIT;
+
+/**
+ * Determines whether SSL/TLS is required to process the current request.
+ *
+ * @return transport guarantee
+ */
TransportGuarantee transportGuarantee() default TransportGuarantee.NONE;
+
+/**
+ * The authorized roles' names. The container may discard duplicate role
+ * names during processing of the annotation. N.B. The String "*" does not
+ * have a special meaning if it occurs as a role name.
+ *
+ * @return array of names. The array may be of zero length, in which case
+ * the EmptyRoleSemantic applies; the returned value determines
+ * whether access is to be permitted or denied regardless of the
+ * identity and authentication state in either case, PERMIT or
DENY.
+ * Otherwise, when the array contains one or more role names access
+ * is permitted if the user a member of at least one of the named
+ * roles. The EmptyRoleSemantic is not applied in this case.
+ *
+ */
String[] rolesAllowed() default {};
+
}
Modified: tomcat/trunk/java/javax/servlet/annotation/HttpMethodConstraint.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/javax/servlet/annotation/HttpMethodConstraint.java?rev=933183&r1=933182&r2=933183&view=diff
==
--- tomcat/trunk/java/javax/servlet/annotation/HttpMethodConstraint.java
(original)
+++ tomcat/trunk/java/javax/servlet/annotation/HttpMethodConstraint.java Mon
Apr 12 10:34:09 2010
@@ -24,14 +24,51 @@ import javax.servlet.annotation.ServletS
import javax.servlet.annotation.ServletSecurity.TransportGuarantee;
/**
+ * Specific security constraints can be applied to different types of request,
+ * differentiated by the HTTP protocol me
DO NOT REPLY [Bug 48891] Missing EOL-style settings in tomcat/jk/trunk
https://issues.apache.org/bugzilla/show_bug.cgi?id=48891 --- Comment #1 from Mark Thomas 2010-04-12 06:40:14 EDT --- What compilation problems? I'm tempted to close this as WONTFIX. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r933188 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: rjung Date: Mon Apr 12 10:47:50 2010 New Revision: 933188 URL: http://svn.apache.org/viewvc?rev=933188&view=rev Log: Vote. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=933188&r1=933187&r2=933188&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Mon Apr 12 10:47:50 2010 @@ -215,14 +215,14 @@ PATCHES PROPOSED TO BACKPORT: Make clearing thread locals optional and disabled by default since it isn't thread-safe http://svn.apache.org/viewvc?rev=928798&view=rev - +1: markt, kkolinko + +1: markt, kkolinko, rjung -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48917 Correct name of mod_jk module in ApacheConfig https://issues.apache.org/bugzilla/attachment.cgi?id=25132 Patch provided by Todd Hicks - +1: markt, kkolinko + +1: markt, kkolinko, rjung -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49030 @@ -241,8 +241,9 @@ PATCHES PROPOSED TO BACKPORT: Improve debug logging for situations when RemoteIpValve is bypassed https://issues.apache.org/bugzilla/attachment.cgi?id=25181 Patch provided by Cyrille Le Clerc - +1: markt, kkolinko + +1: markt, kkolinko, rjung -1: + rjung: maybe using originalRemoteAddr instead of request.getRemoteAddr(). * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48379 Make session cookie name, domain and path configurable per context. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r933165 - /tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
This seems like an odd thing to make a constant. (Is something else
setting this or was there an intention for this to be set? Especially
since it is used only once in this file)
-Tim
On 4/12/2010 5:35 AM, ma...@apache.org wrote:
Author: markt
Date: Mon Apr 12 09:35:52 2010
New Revision: 933165
URL: http://svn.apache.org/viewvc?rev=933165&view=rev
Log:
Make public constant final
Modified:
tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
Modified: tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java?rev=933165&r1=933164&r2=933165&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java (original)
+++ tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java Mon Apr 12
09:35:52 2010
@@ -38,7 +38,7 @@ import java.sql.Timestamp;
public class ChannelData implements ChannelMessage {
public static final ChannelData[] EMPTY_DATA_ARRAY = new ChannelData[0];
-public static boolean USE_SECURE_RANDOM_FOR_UUID = false;
+public static final boolean USE_SECURE_RANDOM_FOR_UUID = false;
/**
* The options this message was sent with
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 43642] Add prestartminSpareThreads attribute for Executor
https://issues.apache.org/bugzilla/show_bug.cgi?id=43642 --- Comment #2 from Ruediger Pluem 2010-04-12 07:56:39 EDT --- Ping? Any interest? If needed I can provide a patch against 6.0.26. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49095] New: org.apache.tomcat.util.net.AprEndpoint.unlockAccept does not wakeup accepts with deferred accept or BSD filters
https://issues.apache.org/bugzilla/show_bug.cgi?id=49095 Summary: org.apache.tomcat.util.net.AprEndpoint.unlockAccept does not wakeup accepts with deferred accept or BSD filters Product: Tomcat 6 Version: 6.0.26 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P2 Component: Connectors AssignedTo: dev@tomcat.apache.org ReportedBy: rpl...@apache.org Created an attachment (id=25266) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25266) Patch to fix issue org.apache.tomcat.util.net.AprEndpoint.unlockAccept does not wakeup accepts with deferred accept or BSD filters. This is because it only connects to its connector for causing the accept call to return. This is not enough in the case of a deferred accept / BSD filters as the accept call only returns from the kernel if data was sent / a HTTP request was sent. The attached patch fixes that by sending and OPTIONS * in this case. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Tomcat Wiki] Update of "TomcatTrackNA10_PMC_Sessions " by damodar_chetty
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "TomcatTrackNA10_PMC_Sessions" page has been changed by damodar_chetty. http://wiki.apache.org/tomcat/TomcatTrackNA10_PMC_Sessions?action=diff&rev1=12&rev2=13 -- . Tim Funk has been a Tomcat user for over 7 years and committer since 2003. Tim currently resides in Pennsylvania and works for Armstrong World Industries performing a range of roles, enjoying the role of developer the most. Tim has a Masters of Software Engineering from Penn State. + + Tomcat 7 - Implementing a Servlet Container + By Damodar Chetty: + . The servlet specification forms the requirements document that a servlet container, such as Tomcat, actually implements. To truly appreciate what a servlet container does, it is therefore critically important to first start with the servlet specification. + + . In this session we'll take a long hard look both at the specification as well as at how Tomcat stays true to it. + + . We will consider the conceptual underpinnings and implementations of aspects such as deployment descriptors, the servlet life cycle, session management, listeners, and filters. + + . Damodar Chetty is the author of the recently published, Tomcat 6 Developer's Guide, and is a veteran software engineer with over two decades in the field. He has graduate degrees from the University of Minnesota (Computer Engineering) and the University of Goa (MBA), and an undergraduate degree in electrical engineering form the University of Bombay. + + Tomcat Vital Component Deep Dive + By Damodar Chetty: + + . In this session we'll take an up close and personal look at the most vital components that comprise Tomcat– the connector subsystem, virtual host, the context, the wrapper, and the session manager. + + . We will explore the implementation of the JIO and NIO connectors, look at alternative virtual hosting techniques and its context deployment responsibilities, delve into protocol handlers and the class loading mechanics associated with web application contexts, get familiar with request dispatching and the filter decoration aspects of wrappers, and immerse ourselves in the intricacies of state management with sessions. + + . Damodar Chetty is the author of the recently published, Tomcat 6 Developer's Guide, and is a veteran software engineer with over two decades in the field. He has graduate degrees from the University of Minnesota (Computer Engineering) and the University of Goa (MBA), and an undergraduate degree in electrical engineering form the University of Bombay. + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49098] New: Filter not invoked when of contains querystring
https://issues.apache.org/bugzilla/show_bug.cgi?id=49098 Summary: Filter not invoked when of contains querystring Product: Tomcat 6 Version: 6.0.26 Platform: PC OS/Version: Windows Vista Status: NEW Severity: major Priority: P2 Component: Catalina AssignedTo: dev@tomcat.apache.org ReportedBy: filippo.mun...@kion.it The filter is not invoked with the following web.xml: log *.do FORWARD REQUEST INCLUDE ERROR my-servlet *.do java.lang.NullPointerException /error.do?type=generic_error Changing with the filter is correctly invoked: filter action FORWARD REQUEST INCLUDE ERROR The filter is also correctly invoked using but removing the querystring from : filter *.do FORWARD REQUEST INCLUDE ERROR java.lang.NullPointerException /error.do I have tested with 6.0.26 and 5.5.28. The problem seems to be in the class org.apache.catalina.core.ApplicationFilterFactory.java, method matchFiltersURL, Case 3 - Extension Match. Filippo -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49098] Filter not invoked when of contains querystring
https://issues.apache.org/bugzilla/show_bug.cgi?id=49098 Tim Funk changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Comment #1 from Tim Funk 2010-04-12 12:37:38 EDT --- Servlet mappings should not contain query strings. Its meant to be a path only. This is not valid: /error.do?type=generic_error So the resulting behavior is undefined. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r933165 - /tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
On 12/04/2010 11:53, Tim Funk wrote:
> This seems like an odd thing to make a constant. (Is something else
> setting this or was there an intention for this to be set? Especially
> since it is used only once in this file)
It isn't entirely clear. I suspect it was going to be made configurable
at start-up at some point. The naming convention implies constant. If it
is ever made configurable, the final can be removed if required.
Mark
>
> -Tim
>
> On 4/12/2010 5:35 AM, ma...@apache.org wrote:
>> Author: markt
>> Date: Mon Apr 12 09:35:52 2010
>> New Revision: 933165
>>
>> URL: http://svn.apache.org/viewvc?rev=933165&view=rev
>> Log:
>> Make public constant final
>>
>> Modified:
>> tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
>>
>> Modified:
>> tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
>> URL:
>> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java?rev=933165&r1=933164&r2=933165&view=diff
>>
>> ==
>>
>> --- tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
>> (original)
>> +++ tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
>> Mon Apr 12 09:35:52 2010
>> @@ -38,7 +38,7 @@ import java.sql.Timestamp;
>> public class ChannelData implements ChannelMessage {
>> public static final ChannelData[] EMPTY_DATA_ARRAY = new
>> ChannelData[0];
>>
>> -public static boolean USE_SECURE_RANDOM_FOR_UUID = false;
>> +public static final boolean USE_SECURE_RANDOM_FOR_UUID = false;
>>
>> /**
>>* The options this message was sent with
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
building tomcat-oacc: missing some classes?
Hi,
first please forgive me for the apparent x-post (my previous post was
hi-jacked and thus is ignored by most relevant contributors, see
http://old.nabble.com/Can-catalina-cluster-from-Tomcat-5.5-be-used-in-Tomcat-6--tp25244120p28173804.html).
I got the latest tomcat-oacc code from
svn checkout
http://svn.apache.org/repos/asf/tomcat/sandbox/tomcat-oacc/trunk/
I am using:
JDK 1.6.0_16
Ant 1.6.0
tomcat-6.0.24
Unfortunately I am running into some issues while trying to build (see end
of mail for errors) due to some missing classes. For example these 2
classes:
org.apache.catalina.cluster.session.ClusterManagerBase
org.apache.catalina.cluster.ClusterMessageBase
several classes in oacc import or extend these classes, but they are not in
SVN (see end of mail for src tree) nor are they in the 6.0 JARs references
in the classpath. Tomcat 6.0.24 has
org.apache.catalina.ha.ClusterMessageBase
org.apache.catalina.ha.session.ClusterManagerBase
should these be used instead? I cannot see that to be the case since that in
turn would pull more oac.ha classes...
I am obviously missing something...
Thanks in advance for any help.
Florian
-
ERRORS:
[javac]
C:\tomcat\tomcat-oacc\latest\trunk\src\share\org\apache\catalina\cluster
\authenticator\SingleSignOnMessage.java:23: cannot find symbol
[javac] symbol : class ClusterMessageBase
[javac] location: package org.apache.catalina.cluster
[javac] import org.apache.catalina.cluster.ClusterMessageBase;
[javac] ^
[javac]
C:\tomcat\tomcat-oacc\latest\trunk\src\share\org\apache\catalina\cluster
\authenticator\SingleSignOnMessage.java:32: cannot find symbol
[javac] symbol: class ClusterMessageBase
[javac] public class SingleSignOnMessage extends ClusterMessageBase
implements C
lusterMessage, Serializable {
[javac] ^
[javac] [loading java\io\File.class(java\io:File.class)]
[javac]
C:\tomcat\tomcat-oacc\latest\trunk\src\share\org\apache\catalina\cluster
\deploy\FileMessage.java:21: cannot find symbol
[javac] symbol : class ClusterMessageBase
[javac] location: package org.apache.catalina.cluster
[javac] import org.apache.catalina.cluster.ClusterMessageBase;
[javac] ^
[javac]
C:\tomcat\tomcat-oacc\latest\trunk\src\share\org\apache\catalina\cluster
\deploy\FileMessage.java:32: cannot find symbol
[javac] symbol: class ClusterMessageBase
[javac] public class FileMessage extends ClusterMessageBase implements
ClusterMe
--
SOURCE TREE:
C:\tomcat\tomcat-oacc\latest\trunk>tree /F /A
Folder PATH listing for volume Qwest
Volume serial number is F586B622 C03A:31B5
C:.
| build.properties
| build.properties.default
| build.xml
| BUILDING.txt
| LICENSE
| NOTICE
| PROPOSALS.txt
| RELEASE-NOTES
| RELEASE-PLAN.txt
| RUNNING.txt
| to-do.txt
|
+---docs
| | build.xml
| | changelog.xml
| | index.xml
| | oacc-howto.xml
| | project.xml
| | tomcat-oacc-docs.xsl
| |
| \---images
| add.gif
| asf-logo.gif
| code.gif
| design.gif
| docs.gif
| fix.gif
| printer.gif
| tomcat.gif
| update.gif
| void.gif
|
+---etc
| cluster-server.xml
|
+---output
| \---build
| \---classes
+---src
| \---share
| \---org
| \---apache
| \---catalina
| +---authenticator
| | SingleSignOnEntry.java
| |
| \---cluster
| | CatalinaCluster.java
| | ClusterDeployer.java
| | ClusterManager.java
| | ClusterMessage.java
| | ClusterReceiver.java
| | ClusterRuleSet.java
| | ClusterSender.java
| | ClusterSession.java
| | ClusterValve.java
| | Constants.java
| | LocalStrings.properties
| | LocalStrings_es.properties
| | mbeans-descriptors.xml
| | Member.java
| | MembershipListener.java
| | MembershipService.java
| | MessageListener.java
| | package.html
| |
| +---authenticator
| | ClusterSingleSignOn.java
| | ClusterSingleSignOnListener.java
| | mbeans-descriptors.xml
| | SingleSignOnMessage.java
| |
| +---deploy
| | FarmWarDeployer.java
| | FileChangeListener.java
|
Re: svn commit: r933165 - /tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
On 12/04/2010, Mark Thomas wrote:
> On 12/04/2010 11:53, Tim Funk wrote:
> > This seems like an odd thing to make a constant. (Is something else
> > setting this or was there an intention for this to be set? Especially
> > since it is used only once in this file)
>
>
> It isn't entirely clear. I suspect it was going to be made configurable
> at start-up at some point. The naming convention implies constant. If it
> is ever made configurable, the final can be removed if required.
This was done to fix:
https://issues.apache.org/bugzilla/show_bug.cgi?id=49089
If it is ever made mutable, please consider making it a private
instance variable instead of a thread-hostile mutable static.
> Mark
>
>
> >
> > -Tim
> >
> > On 4/12/2010 5:35 AM, ma...@apache.org wrote:
> >> Author: markt
> >> Date: Mon Apr 12 09:35:52 2010
> >> New Revision: 933165
> >>
> >> URL: http://svn.apache.org/viewvc?rev=933165&view=rev
> >> Log:
> >> Make public constant final
> >>
> >> Modified:
> >> tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
> >>
> >> Modified:
> >> tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
> >> URL:
> >>
> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java?rev=933165&r1=933164&r2=933165&view=diff
> >>
> >>
> ==
> >>
> >> --- tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
> >> (original)
> >> +++ tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
> >> Mon Apr 12 09:35:52 2010
> >> @@ -38,7 +38,7 @@ import java.sql.Timestamp;
> >> public class ChannelData implements ChannelMessage {
> >> public static final ChannelData[] EMPTY_DATA_ARRAY = new
> >> ChannelData[0];
> >>
> >> -public static boolean USE_SECURE_RANDOM_FOR_UUID = false;
> >> +public static final boolean USE_SECURE_RANDOM_FOR_UUID = false;
> >>
> >> /**
> >>* The options this message was sent with
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> > For additional commands, e-mail: dev-h...@tomcat.apache.org
> >
>
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49099] New: Using % after context prefix results in 400 but nothing is logged in access log
https://issues.apache.org/bugzilla/show_bug.cgi?id=49099 Summary: Using % after context prefix results in 400 but nothing is logged in access log Product: Tomcat 6 Version: 6.0.26 Platform: PC OS/Version: Linux Status: NEW Severity: major Priority: P2 Component: Catalina AssignedTo: dev@tomcat.apache.org ReportedBy: i...@fedulov.com Simple test: 1. Download latest tomcat 6.0.26 2. Utar it and start it up 3. Head over to http://localhost:8080/ to verify that it's working 4. Now change the URL to something like http://localhost:8080/%foo and you get error 400 as expected but nothing is logged in access log: http://localhost:8080/%foo GET /%foo HTTP/1.1 Host: localhost:8080 User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.9) Gecko/20100401 Ubuntu/9.10 (karmic) Firefox/3.5.9 Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8 Accept-Language: en-us,en;q=0.5 Accept-Encoding: gzip,deflate Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.7 Keep-Alive: 300 Connection: keep-alive HTTP/1.1 400 Bad Request Server: Apache-Coyote/1.1 Content-Length: 0 Date: Mon, 12 Apr 2010 19:44:57 GMT Connection: close 5. Now change the URL to legitimate, i.e.: http://localhost:8080/%29 and you get 404 as expected and it's also logged in access log as expected. http://localhost:8080/%29 GET /%29 HTTP/1.1 Host: localhost:8080 User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.9) Gecko/20100401 Ubuntu/9.10 (karmic) Firefox/3.5.9 Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8 Accept-Language: en-us,en;q=0.5 Accept-Encoding: gzip,deflate Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.7 Keep-Alive: 300 Connection: keep-alive HTTP/1.1 404 Not Found Server: Apache-Coyote/1.1 Content-Type: text/html;charset=utf-8 Content-Length: 964 Date: Mon, 12 Apr 2010 19:43:45 GMT So for admin of the server there is no way to see if there is a DDoS attack going on on the box because there is nothing written to the log files, nothing at all. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Patch suggestion
On 12 April 2010 11:25, Pid * wrote:
> On 11 April 2010 14:56, Pid * wrote:
>
>>
>> On 11 April 2010 00:17, Konstantin Kolinko wrote:
>>
>>> 2010/4/10 Pid :
>>> > In lieu of of a Bugzilla enhancement (and hoping that I have the right
>>> end
>>> > of the stick).
>>> >
>>>
>>> If I guess your intention correctly,
>>> you want to prevent deployment of a war file that is still open for
>>> writing?
>>>
>>
>> Yes. I should have been more explicit. The patch was prompted by a message
>> to the User list a little while ago.
>> The user uploaded a .war directly to the webapps directory and was
>> surprised to discover Tomcat throwing exceptions when it tried to deploy the
>> incomplete file.
>>
>
> I suspect that the thread on the Users list "" is in the same category as
> the problem I describe.
>
I almost made sense there, thread "Context.xml being deleted".
> If that is the case, then asking for modification time probably will
>>> not work. The file properties in the file system are usually not
>>> updated that frequently. Though that might differ between OSes. Also,
>>> if the file is being transmitted over network, the update frequency
>>> depends on how fast is the connection that is used to upload the file.
>>>
>>> As far as I remember my experience, I think that a file that is still
>>> being written can be detected by asking its length. Such files can be
>>> listed by shell to be of length 0.
>>>
>>> Needs more research and some summary across OSes though.
>>>
>>
>> I will test Linux, OSX.
>>
>
> When uploading a war of 5Mb to an RHL linux server, a simple class which
> monitors (every 100ms) the size of the file reports the current file size
> changing as the bytes arrive in chunks of 16k, the file size remains the
> same for 5-8 runs of the loop either before enough packets have arrived, or
> the file system updates.
>
> Which means waiting for maybe 1000ms to see a change, which isn't ideal as
> KK points out.
>
>
> p
>
>
>> At least, if the war file is of length 0 it can be safely skipped for
>>> obvious reasons.
>>>
>>> >try {
>>> >Thread.sleep(500);
>>> >}
>>>
>>> I do not like unconditionally sleeping for every file. 20 wars = 10
>>> seconds to sleep, even if none of them is going to be deployed
>>>
>>
>> Fair enough. If the file size detectably zero, then calling continue
>> would be sufficient to prevent the attempt at deploying the war. I think it
>> would be good to log a warning here too.
>>
>>
>> p
>>
>>
>>> Time could be compared against the interval between autoDeploy cycle
>>> runs, if it is enabled, but there are also explicit calls from the
>>> manager web application that must not be broken.
>>>
>>> The above is from my mind/memory. I have not researched it for this case.
>>>
>>> Best regards,
>>> Konstantin Kolinko
>>>
>>> -
>>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>>
>>>
>>
>>
>> --
>>
>> --
>> pidster.com
>>
>
>
>
> --
>
> --
> pidster.com
>
--
--
pidster.com
DO NOT REPLY [Bug 49100] New: Mutable public constants: MemberImpl.TRIBES_MBR_BEGIN/END
https://issues.apache.org/bugzilla/show_bug.cgi?id=49100 Summary: Mutable public constants: MemberImpl.TRIBES_MBR_BEGIN/END Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Windows XP Status: NEW Severity: normal Priority: P2 Component: Catalina AssignedTo: dev@tomcat.apache.org ReportedBy: s...@apache.org The fields tribes.membership.MemberImpl.TRIBES_MBR_BEGIN tribes.membership.MemberImpl.TRIBES_MBR_END are intended to be constants, but they are defined as public static final transient byte[] These are non-empty arrays, so they are not immutable. TRIBES_MBR_END does not seem to be accessed outside its class, so could be made private to protect it. TRIBES_MBR_BEGIN only seems to be used in tribes.membership.McastServiceImpl.receive() so the field could be made package protected. Alternatively, the method call XByteBuffer.firstIndexOf(data,0,MemberImpl.TRIBES_MBR_BEGIN) could be refactored and moved to MemberImpl in which case the field could be made private. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49099] Using % after context prefix results in 400 but nothing is logged in access log
https://issues.apache.org/bugzilla/show_bug.cgi?id=49099 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WONTFIX --- Comment #1 from Mark Thomas 2010-04-12 15:56:39 EDT --- This is working as designed. Bad urls are rejected before they reach the access log valve. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49101] New: All constants in tribes.transport.Constants are mutable
https://issues.apache.org/bugzilla/show_bug.cgi?id=49101 Summary: All constants in tribes.transport.Constants are mutable Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Windows XP Status: NEW Severity: normal Priority: P2 Component: Catalina AssignedTo: dev@tomcat.apache.org ReportedBy: s...@apache.org The "constant" fields in tribes.transport.Constants are defined as non-empty public static final byte arrays, so are not actually immutable. The _DATA fields only appear to be used in Arrays.equals method calls, so the array comparison could be moved to the Constants class. The _COMMAND fields are a bit more difficult to protect, but there could be a getter that returned a copy of the array. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49102] New: coyote.ajp.Constants - 3 "constant" arrays are mutable
https://issues.apache.org/bugzilla/show_bug.cgi?id=49102 Summary: coyote.ajp.Constants - 3 "constant" arrays are mutable Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Windows XP Status: NEW Severity: normal Priority: P2 Component: Catalina AssignedTo: dev@tomcat.apache.org ReportedBy: s...@apache.org The class coyote.ajp.Constants contains 3 public static non-empty String[] arrays: methodTransArray responseTransArray headerTransArray responseTransArray only appears to be locally, so could be made private. The others are used in index lookups, so get(index) methods could be used to protect them. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49099] Using % after context prefix results in 400 but nothing is logged in access log
https://issues.apache.org/bugzilla/show_bug.cgi?id=49099 Igor Fedulov changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|WONTFIX | --- Comment #2 from Igor Fedulov 2010-04-12 16:27:51 EDT --- So what are the solutions from preventing DDoS attack if server doesn't log malformed request attempts, not even the originating IP? You don't consider this as a problem? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49045] JMX Enhancement- Provision of MBeanFactory createStandardService
https://issues.apache.org/bugzilla/show_bug.cgi?id=49045 --- Comment #6 from Mark Thomas 2010-04-12 17:58:00 EDT --- Ping. When do you expect to have an updated patch? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49103] New: Missing annotations
https://issues.apache.org/bugzilla/show_bug.cgi?id=49103 Summary: Missing annotations Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Windows XP Status: NEW Severity: normal Priority: P2 Component: Catalina AssignedTo: dev@tomcat.apache.org ReportedBy: s...@apache.org Created an attachment (id=25270) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25270) Add missing annotations -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49104] New: Fix up some raw types
https://issues.apache.org/bugzilla/show_bug.cgi?id=49104 Summary: Fix up some raw types Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Windows XP Status: NEW Severity: normal Priority: P2 Component: Catalina AssignedTo: dev@tomcat.apache.org ReportedBy: s...@apache.org Created an attachment (id=25271) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25271) Fix up some raw types -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49105] New: Javadoc corrections
https://issues.apache.org/bugzilla/show_bug.cgi?id=49105 Summary: Javadoc corrections Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Windows XP Status: NEW Severity: normal Priority: P2 Component: Catalina AssignedTo: dev@tomcat.apache.org ReportedBy: s...@apache.org Created an attachment (id=25272) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25272) Javadoc corrections - includes some deletions of misplaced docn -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49106] New: Unused imports
https://issues.apache.org/bugzilla/show_bug.cgi?id=49106 Summary: Unused imports Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Windows XP Status: NEW Severity: normal Priority: P2 Component: Catalina AssignedTo: dev@tomcat.apache.org ReportedBy: s...@apache.org Created an attachment (id=25273) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25273) Unused imports - patch -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49107] New: Document fallthrough, Eclipse-fashion
https://issues.apache.org/bugzilla/show_bug.cgi?id=49107 Summary: Document fallthrough, Eclipse-fashion Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Windows XP Status: NEW Severity: normal Priority: P2 Component: Catalina AssignedTo: dev@tomcat.apache.org ReportedBy: s...@apache.org Created an attachment (id=25274) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25274) Document fallthrough, Eclipse-fashion -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49108] New: Eliminate double-check of same value and fix fallthrough warning
https://issues.apache.org/bugzilla/show_bug.cgi?id=49108 Summary: Eliminate double-check of same value and fix fallthrough warning Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Windows XP Status: NEW Severity: normal Priority: P2 Component: Catalina AssignedTo: dev@tomcat.apache.org ReportedBy: s...@apache.org Created an attachment (id=25275) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25275) Eliminate double-check of same value and fix fallthrough warning -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49109] New: RealmBase.authenticate uses toString on byte array
https://issues.apache.org/bugzilla/show_bug.cgi?id=49109 Summary: RealmBase.authenticate uses toString on byte array Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Windows XP Status: NEW Severity: normal Priority: P2 Component: Catalina AssignedTo: dev@tomcat.apache.org ReportedBy: s...@apache.org catalina.realm.RealmBase.authenticate(String username, byte[] credentials) has the following code: return (authenticate(username, credentials.toString())); This looks wrong, as credentials is a byte array. It should probably be: return (authenticate(username, new String(credentials[,charset]))); -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49110] New: runtime.JspFactoryImpl$PageContextPool needs to be static
https://issues.apache.org/bugzilla/show_bug.cgi?id=49110 Summary: runtime.JspFactoryImpl$PageContextPool needs to be static Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Windows XP Status: NEW Severity: normal Priority: P2 Component: Jasper AssignedTo: dev@tomcat.apache.org ReportedBy: s...@apache.org Findbugs says: Bug: org.apache.jasper.runtime.JspFactoryImpl$PageContextPool needs to be _static_ to avoid a deadly embrace with org.apache.jasper.runtime.JspFactoryImpl.localPool Pattern id: SIC_THREADLOCAL_DEADLY_EMBRACE, type: SIC, category: CORRECTNESS This class is an inner class, but should probably be a static inner class. As it is, there is a serious danger of a deadly embrace between the inner class and the thread local in the outer class. Because the inner class isn't static, it retains a reference to the outer class. If the thread local contains a reference to an instance of the inner class, the inner and outer instance will both be reachable and not eligible for garbage collection. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 43642] Add prestartminSpareThreads attribute for Executor
https://issues.apache.org/bugzilla/show_bug.cgi?id=43642 --- Comment #3 from jfclere 2010-04-13 02:20:10 EDT --- Nope a patch against trunk would be better. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49112] New: MyFaces (JSF) lost it's support
https://issues.apache.org/bugzilla/show_bug.cgi?id=49112
Summary: MyFaces (JSF) lost it's support
Product: Tomcat 6
Version: 6.0.26
Platform: Other
OS/Version: Linux
Status: NEW
Severity: critical
Priority: P2
Component: Catalina
AssignedTo: dev@tomcat.apache.org
ReportedBy: peter.kov...@gmail.com
I have simple and standard MyFaces app. deployed, that worked successfully on
6.0.18 tomcat on the same OS(Ubuntu kernel 2.6.31-20-generic, i686).
After deploy on 6.0.26 it stops to work correctly.
1)
message bundles not recognized,
code like that not working:
it does not see the message, treats all the #{message.abc} like a simple
string.
2)
In select boxes it does not recognize value listeners. treats them like simple
strings.
It seems TomCat became unaware of JSF presence in the app.
Deployment details:
All jsf libs are under MY_WEB_APP/WEB_INF/lib, in tomcat libs I have nothing of
mine.
"myfaces" version used is 1.2.5
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
