https://issues.apache.org/bugzilla/show_bug.cgi?id=49110
Summary: runtime.JspFactoryImpl$PageContextPool needs to be
static
Product: Tomcat 7
Version: trunk
Platform: PC
OS/Version: Windows XP
Status: NEW
Severity: normal
Priority: P2
Component: Jasper
AssignedTo: dev@tomcat.apache.org
ReportedBy: s...@apache.org
Findbugs says:
Bug: org.apache.jasper.runtime.JspFactoryImpl$PageContextPool needs to be
_static_ to avoid a deadly embrace with
org.apache.jasper.runtime.JspFactoryImpl.localPool
Pattern id: SIC_THREADLOCAL_DEADLY_EMBRACE, type: SIC, category: CORRECTNESS
This class is an inner class, but should probably be a static inner class. As
it is, there is a serious danger of a deadly embrace between the inner class
and the thread local in the outer class. Because the inner class isn't static,
it retains a reference to the outer class. If the thread local contains a
reference to an instance of the inner class, the inner and outer instance will
both be reachable and not eligible for garbage collection.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
