DO NOT REPLY [Bug 48055] New: binding error in lifecycleEvent method of org.apache.catalina.core.NamingContextListener class
https://issues.apache.org/bugzilla/show_bug.cgi?id=48055
Summary: binding error in lifecycleEvent method of
org.apache.catalina.core.NamingContextListener class
Product: Tomcat 6
Version: 6.0.20
Platform: PC
OS/Version: Linux
Status: NEW
Severity: normal
Priority: P2
Component: Catalina
AssignedTo: dev@tomcat.apache.org
ReportedBy: qingyang...@qunar.com
in the lifecycleEvent(LifecycleEvent event) method of the class of
'org.apache.catalina.core.NamingContextListener':
ContextAccessController.setSecurityToken(getName(), container);
ContextBindings.bindContext(container, namingContext, container);
if( log.isDebugEnabled() ) {
log.debug("Bound " + container );
}
should be:
ContextAccessController.setSecurityToken(getName(), container);
ContextBindings.bindContext(getName(), namingContext, container);
if( log.isDebugEnabled() ) {
log.debug("Bound " + container );
}
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Tomcat Wiki] Update of "TomcatAtApacheConUs2009" by Je anFredericClere
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "TomcatAtApacheConUs2009" page has been changed by JeanFredericClere. http://wiki.apache.org/tomcat/TomcatAtApacheConUs2009?action=diff&rev1=8&rev2=9 -- === Attendees === Please register [[http://spreadsheets.google.com/viewform?formkey=dEJLcHk3c1ZrRm8tWUNYeXZZckN0Vnc6MA|on the link]] if you plan to attend. - Already registered attendees (updated the 23th of October): + Already registered attendees (updated the 26th of October): Jean-Frederic Clere, Rainer Jung, Jason Brittain, Sateesh Narahari, Costin Manolache, + Mark Thomas, + Aleksandar Gargenta, + Luca Candela, + Juan Manuel, For more information on other BoF / !MeetUp / !GetTogetther schedules please consult the main !ApacheCon wiki... - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 47893] Use StringBuilder instead of StringBuffer
https://issues.apache.org/bugzilla/show_bug.cgi?id=47893 --- Comment #3 from Marc Guillemot 2009-10-26 02:53:10 UTC --- (In reply to comment #2) Mark, you surely already know that, but quick reactions are the best way for a project to show that it is interested in contributions. I agree that complex patches require work to be applied but here I believe that commenting the ticket was nearly more time consuming than understanding and applying the patch. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Releasing Apache Tomcat Native 1.1.17
On 10/20/2009 09:55 PM, jean-frederic clere wrote: Hi, Native 1.1.17 is available for testing. If you want to take a look, the final source distribution can be downloaded from: http://tomcat.apache.org/dev/dist/tomcat-connectors/native/source/ Some binaries will be available at: http://tomcat.apache.org/dev/dist/tomcat-connectors/native/binaries/ So here's the vote. It will be closed in about 72 hours as usual. Apache Tomcat Native 1.1.17 is: [X] Stable - no major issues, no regressions BTW: Please vote... Cheers Jean-Frederic - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Releasing Apache Tomcat Native 1.1.17
On Tue, 2009-10-20 at 21:55 +0200, jean-frederic clere wrote: > [X] Stable - no major issues, no regressions > [ ] Beta - at least one significant issue -- tell us what it is > [ ] Alpha - multiple significant issues -- tell us what they are Rémy - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r829825 - /tomcat/trunk/res/tomcat.nsi
Author: markt
Date: Mon Oct 26 15:27:12 2009
New Revision: 829825
URL: http://svn.apache.org/viewvc?rev=829825&view=rev
Log:
Update copyright year
Clean up unused elements
Modified:
tomcat/trunk/res/tomcat.nsi
Modified: tomcat/trunk/res/tomcat.nsi
URL:
http://svn.apache.org/viewvc/tomcat/trunk/res/tomcat.nsi?rev=829825&r1=829824&r2=829825&view=diff
==
--- tomcat/trunk/res/tomcat.nsi (original)
+++ tomcat/trunk/res/tomcat.nsi Mon Oct 26 15:27:12 2009
@@ -25,7 +25,7 @@
;Product information
VIAddVersionKey ProductName "Apache Tomcat"
VIAddVersionKey CompanyName "Apache Software Foundation"
- VIAddVersionKey LegalCopyright "Copyright (c) 1999-2006 The Apache Software
Foundation"
+ VIAddVersionKey LegalCopyright "Copyright (c) 1999-2009 The Apache Software
Foundation"
VIAddVersionKey FileDescription "Apache Tomcat Installer"
VIAddVersionKey FileVersion "2.0"
VIAddVersionKey ProductVersion "@VERSION@"
@@ -99,7 +99,6 @@
LangString DESC_SecMenu ${LANG_ENGLISH} "Create a Start Menu program group
for Tomcat."
LangString DESC_SecDocs ${LANG_ENGLISH} "Install the Tomcat documentation
bundle. This include documentation on the servlet container and its
configuration options, on the Jasper JSP page compiler, as well as on the
native webserver connectors."
LangString DESC_SecExamples ${LANG_ENGLISH} "Installs some examples web
applications."
-LangString DESC_SecAdmin ${LANG_ENGLISH} "Installs the administration web
application.";
;Language
!insertmacro MUI_LANGUAGE English
@@ -354,13 +353,9 @@
!insertmacro MUI_DESCRIPTION_TEXT ${SecTomcatCore} $(DESC_SecTomcatCore)
!insertmacro MUI_DESCRIPTION_TEXT ${SecTomcatService}
$(DESC_SecTomcatService)
!insertmacro MUI_DESCRIPTION_TEXT ${SecTomcatNative} $(DESC_SecTomcatNative)
-; !insertmacro MUI_DESCRIPTION_TEXT ${SecTomcatSource} $(DESC_SecTomcatSource)
-; !insertmacro MUI_DESCRIPTION_TEXT ${SecCompat} $(DESC_SecCompat)
!insertmacro MUI_DESCRIPTION_TEXT ${SecMenu} $(DESC_SecMenu)
!insertmacro MUI_DESCRIPTION_TEXT ${SecDocs} $(DESC_SecDocs)
!insertmacro MUI_DESCRIPTION_TEXT ${SecExamples} $(DESC_SecExamples)
-; !insertmacro MUI_DESCRIPTION_TEXT ${SecAdmin} $(DESC_SecAdmin)
-; !insertmacro MUI_DESCRIPTION_TEXT ${SecWebapps} $(DESC_SecWebapps)
!insertmacro MUI_FUNCTION_DESCRIPTION_END
; =
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48047] Http11Protocol.Http11ConnectionHandler's process(Socket socket) method always return false!
https://issues.apache.org/bugzilla/show_bug.cgi?id=48047 Filip Hanik changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Comment #1 from Filip Hanik 2009-10-26 09:32:08 UTC --- processor.process(socket) is a loop that continues until its time to release the socket. So the return value here has no meaning what-so-ever. In trunk, you will see that the keep alive logic has been moved from the processor to the endpoint in order to accomodate async behavior, and there, the value is taken into consideration. So for Tomcat 6, this will not likely change, since the return value is not really defined, when this method returns, the socket should close, regardless Filip -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 47744] Memory leak when using SSL + Java security manager
https://issues.apache.org/bugzilla/show_bug.cgi?id=47744 --- Comment #4 from Greg Vanore 2009-10-26 09:33:27 UTC --- (In reply to comment #3) > I'm not a big fan of trying to work around JVM bugs, but this patch looks like > it is OK (once the missing synchronizing is added). Synchronizing will add a > small hit, but this part of the code is well off the critical path. Yes, I agree with everything you said, except Sun has closed and concluded it is *not* a problem with the VM: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6877740 A bit after posting this I revised my local copy of the patch to add synchronization - should I repost the patch to include it? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r830004 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: kkolinko Date: Mon Oct 26 22:22:14 2009 New Revision: 830004 URL: http://svn.apache.org/viewvc?rev=830004&view=rev Log: votes Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=830004&r1=830003&r2=830004&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Mon Oct 26 22:22:14 2009 @@ -314,27 +314,30 @@ http://svn.apache.org/viewvc?view=revision&revision=828196 +1: markt -1: + kkolinko: +1, but only if the same lines are added to /res/confinstall/server_1.xml as well +Also, once this patch is approved, a description of JreMemoryLeakPreventionListener +has to be added to http://tomcat.apache.org/tomcat-6.0-doc/config/listeners.html * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48019 Be more careful about skipping over sections we aren't interested in http://svn.apache.org/viewvc?view=revision&revision=828201 - +1: markt + +1: markt, kkolinko -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48009 - Protect against a context file breifly disappearing due to text editor + Protect against a context file briefly disappearing due to text editor http://svn.apache.org/viewvc?view=revision&revision=828210 - +1: markt + +1: markt, kkolinko -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47987 Limit size of not found resources cache http://svn.apache.org/viewvc?rev=828759&view=rev - +1: markt + +1: markt, kkolinko -1: * Refix https://issues.apache.org/bugzilla/show_bug.cgi?id=37848 Don't output info messages when there is no terminal http://svn.apache.org/viewvc?rev=828225&view=rev - +1: markt + +1: markt, kkolinko -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r830011 - /tomcat/tc5.5.x/trunk/STATUS.txt
Author: kkolinko Date: Mon Oct 26 22:40:20 2009 New Revision: 830011 URL: http://svn.apache.org/viewvc?rev=830011&view=rev Log: votes Modified: tomcat/tc5.5.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=830011&r1=830010&r2=830011&view=diff == --- tomcat/tc5.5.x/trunk/STATUS.txt (original) +++ tomcat/tc5.5.x/trunk/STATUS.txt Mon Oct 26 22:40:20 2009 @@ -146,11 +146,11 @@ * Refix https://issues.apache.org/bugzilla/show_bug.cgi?id=37848 Don't output info messages when there is no terminal http://svn.apache.org/viewvc?rev=828225&view=rev - +1: markt + +1: markt, kkolinko -1: * Loading tcnative is broken since r795039. https://issues.apache.org/bugzilla/show_bug.cgi?id=47712 https://issues.apache.org/bugzilla/attachment.cgi?id=24411 - +1: rjung + +1: rjung, kkolinko -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48059] New: org.apache.catalina.startup.Bootstrap's main method handles 'startd' or 'stopd' wrongly
https://issues.apache.org/bugzilla/show_bug.cgi?id=48059
Summary: org.apache.catalina.startup.Bootstrap's main method
handles 'startd' or 'stopd' wrongly
Product: Tomcat 7
Version: trunk
Platform: PC
OS/Version: Linux
Status: NEW
Severity: normal
Priority: P2
Component: Catalina
AssignedTo: dev@tomcat.apache.org
ReportedBy: qingyang...@qunar.com
String command = "start";
if (args.length > 0) {
command = args[args.length - 1];
}
if (command.equals("startd")) {
args[0] = "start";
daemon.load(args);
daemon.start();
} else if (command.equals("stopd")) {
args[0] = "stop";
daemon.stop();
}
should be:
String command = "start";
if (args.length > 0) {
command = args[args.length - 1];
}
if (command.equals("startd")) {
args[args.length - 1] = "start";
daemon.load(args);
daemon.start();
} else if (command.equals("stopd")) {
args[args.length - 1] = "stop";
daemon.stop();
}
... ...
Consider what whould happen if Bootstrap is invoked as :
org.apache.catalina.startup.Bootstrap -nonaming startd
Please refer to the following usage method of
org.apache.catalina.startup.Catalina:
/**
* Print usage information for this application.
*/
protected void usage() {
System.out.println
("usage: java org.apache.catalina.startup.Catalina"
+ " [ -config {pathname} ]"
+ " [ -nonaming ] { start | stop }");
}
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48060] New: wrong implementation of peek() method of JIoEndpoint.WorkerStack class
https://issues.apache.org/bugzilla/show_bug.cgi?id=48060
Summary: wrong implementation of peek() method of
JIoEndpoint.WorkerStack class
Product: Tomcat 7
Version: trunk
Platform: PC
OS/Version: Linux
Status: NEW
Severity: normal
Priority: P2
Component: Catalina
AssignedTo: dev@tomcat.apache.org
ReportedBy: qingyang...@qunar.com
/**
* Get the first object out of the queue, Return null if the queue
* is empty.
*/
public Worker peek() {
return workers[end];
}
should be:
/**
* Get the first object out of the queue, Return null if the queue
* is empty.
*/
public Worker peek() {
if (end > 0) {
return workers[end - 1];
}
return null;
}
please refer to the pop() method (apart from pop()'s side effect, pop() and
peek() should return the same result):
/**
* Get the first object out of the queue. Return null if the queue
* is empty.
*/
public Worker pop() {
if (end > 0) {
return workers[--end];
}
return null;
}
'end' denotes the index beyond the last element, not the index of the last
element itself. That is why the variable of 'end' is assigned a zero value at
first.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 47881] org.apache.catalina.startup.Bootstrap's main method handles 'startd' or 'stopd' wrongly
https://issues.apache.org/bugzilla/show_bug.cgi?id=47881 qingyang.xu changed: What|Removed |Added Status|NEW |RESOLVED Resolution||DUPLICATE --- Comment #7 from qingyang.xu 2009-10-26 17:38:23 UTC --- *** This bug has been marked as a duplicate of bug 48059 *** -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48059] org.apache.catalina.startup.Bootstrap's main method handles 'startd' or 'stopd' wrongly
https://issues.apache.org/bugzilla/show_bug.cgi?id=48059 --- Comment #1 from qingyang.xu 2009-10-26 17:38:23 UTC --- *** Bug 47881 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48060] wrong implementation of peek() method of JIoEndpoint.WorkerStack class
https://issues.apache.org/bugzilla/show_bug.cgi?id=48060 --- Comment #1 from qingyang.xu 2009-10-26 17:39:14 UTC --- *** Bug 48046 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48046] wrong implementation of peek() method of JIoEndpoint.WorkerStack class
https://issues.apache.org/bugzilla/show_bug.cgi?id=48046 qingyang.xu changed: What|Removed |Added Status|NEW |RESOLVED Resolution||DUPLICATE --- Comment #1 from qingyang.xu 2009-10-26 17:39:14 UTC --- *** This bug has been marked as a duplicate of bug 48060 *** -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
