DO NOT REPLY [Bug 41564] service.bat does not install tomcat as a service properly on Windows Vista
https://issues.apache.org/bugzilla/show_bug.cgi?id=41564 Mark Thomas changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #17 from Mark Thomas 2009-07-18 04:31:33 PST --- I've got to the bottom of this. UAC was getting in the way. Without UAC, the new /user switch works. With UAC, you have to right-click on cmd.exe and select "Run as administrator" I'll update the docs. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r795348 - /tomcat/trunk/webapps/docs/windows-service-howto.xml
Author: markt Date: Sat Jul 18 11:53:41 2009 New Revision: 795348 URL: http://svn.apache.org/viewvc?rev=795348&view=rev Log: Fixed https://issues.apache.org/bugzilla/show_bug.cgi?id=41564 Updated Tomcat6 to Tomcat 7 I couldn't see anything obviously obsolete so I removed the warning. Modified: tomcat/trunk/webapps/docs/windows-service-howto.xml Modified: tomcat/trunk/webapps/docs/windows-service-howto.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/windows-service-howto.xml?rev=795348&r1=795347&r2=795348&view=diff == --- tomcat/trunk/webapps/docs/windows-service-howto.xml (original) +++ tomcat/trunk/webapps/docs/windows-service-howto.xml Sat Jul 18 11:53:41 2009 @@ -29,19 +29,14 @@ - + -This section of the documentation applies to procrun 1.0, and is now obsolete. +Tomcat7 is a service application for running Tomcat7 as NT service. - + -Tomcat6 is a service application for running Tomcat6 as NT service. - - - - -Tomcat6w is a GUI application for monitoring and configuring Tomcat +Tomcat7w is a GUI application for monitoring and configuring Tomcat services. The available command line options are: @@ -70,7 +65,7 @@ Run the service as console application This is the default operation. It is called if the no option is provided. The ServiceName is the name of the executable without -exe suffix, meaning Tomcat6 +exe suffix, meaning Tomcat7 //RS// Run the service @@ -305,22 +300,32 @@ -The safest way to manually install the service is to use the provided service.bat script. +The safest way to manually install the service is to use the provided +service.bat script. Administrator privileges are required to run this +script. If necessary, you can use the /user switch to specify +a user to use for the installation of the service. + + +NOTE: On Windows Vista or any other operating system with User +Account Control (UAC) you must either disable UAC or right-click on cmd.exe and +select "Run as administrator" in order to run this script. If UAC is enabled +neither being logged on with an Administrator account, nor using the +/user switch is sufficient. -Install the service named 'Tomcat6' +Install the service named 'Tomcat7' C:\> service.bat install -If using tomcat6.exe, you need to use the //IS// parameter. +If using tomcat7.exe, you need to use the //IS// parameter. -Install the service named 'Tomcat6' -C:\> tomcat6 //IS//Tomcat6 --DisplayName="Apache Tomcat 6" \ -C:\> --Install="C:\Program Files\Tomcat\bin\tomcat6.exe" --Jvm=auto \ +Install the service named 'Tomcat7' +C:\> tomcat7 //IS//Tomcat7 --DisplayName="Apache Tomcat 7" \ +C:\> --Install="C:\Program Files\Tomcat\bin\tomcat7.exe" --Jvm=auto \ C:\> --StartMode=jvm --StopMode=jvm \ C:\> --StartClass=org.apache.catalina.startup.Bootstrap --StartParams=start \ C:\> --StopClass=org.apache.catalina.startup.Bootstrap --StopParams=stop @@ -333,8 +338,8 @@ -Update the service named 'Tomcat6 -C:\> tomcat6 //US//Tomcat6 --Description="Apache Tomcat Server - http://tomcat.apache.org/ " \ +Update the service named 'Tomcat7' +C:\> tomcat7 //US//Tomcat7 --Description="Apache Tomcat Server - http://tomcat.apache.org/ " \ C:\> --Startup=auto --Classpath=%JAVA_HOME%\lib\tools.jar;%CATALINA_HOME%\bin\bootstrap.jar @@ -346,8 +351,8 @@ -Remove the service named 'Tomcat6' -C:\> tomcat6 //DS//Tomcat6 +Remove the service named 'Tomcat7' +C:\> tomcat7 //DS//Tomcat7 @@ -356,15 +361,15 @@ To run the service in console mode, you need to use the //TS// parameter. The service shutdown can be initiated by pressing CTRL+C or CTRL+BREAK. -If you rename the tomcat6.exe to testservice.exe then you can just execute the +If you rename the tomcat7.exe to testservice.exe then you can just execute the testservice.exe and this command mode will be executed by default. -Run the service named 'Tomcat6' in console mode -C:\> tomcat6 //TS//Tomcat6 [additional arguments] +Run the service named 'Tomcat7' in console mode +C:\> tomcat7 //TS//Tomcat7 [additional arguments] Or simply execute: -C:\> tomcat6 +C:\> tomcat7 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r795349 - in /tomcat/tc6.0.x/trunk/webapps/docs: changelog.xml windows-service-howto.xml
Author: markt Date: Sat Jul 18 11:59:08 2009 New Revision: 795349 URL: http://svn.apache.org/viewvc?rev=795349&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=41564 Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml tomcat/tc6.0.x/trunk/webapps/docs/windows-service-howto.xml Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml?rev=795349&r1=795348&r2=795349&view=diff == --- tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml (original) +++ tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Sat Jul 18 11:59:08 2009 @@ -195,6 +195,10 @@ +41564: Add some information on installing Tomcat as a service +on operating systems with User Account Control, e.g. Vista. (markt) + + 47235: Remove use of autoReconnect from MySQL examples. (markt) Modified: tomcat/tc6.0.x/trunk/webapps/docs/windows-service-howto.xml URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/windows-service-howto.xml?rev=795349&r1=795348&r2=795349&view=diff == --- tomcat/tc6.0.x/trunk/webapps/docs/windows-service-howto.xml (original) +++ tomcat/tc6.0.x/trunk/webapps/docs/windows-service-howto.xml Sat Jul 18 11:59:08 2009 @@ -29,11 +29,6 @@ - - -This section of the documentation applies to procrun 1.0, and is now obsolete. - - Tomcat6 is a service application for running Tomcat6 as NT service. @@ -305,7 +300,15 @@ -The safest way to manually install the service is to use the provided service.bat script. +The safest way to manually install the service is to use the provided +service.bat script. Administrator privileges are required to run this +script. + + +NOTE: On Windows Vista or any other operating system with User +Account Control (UAC) you must either disable UAC or right-click on cmd.exe and +select "Run as administrator" in order to run this script. If UAC is enabled +being logged on with an Administrator account is not sufficient. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r795350 - in /tomcat/container/tc5.5.x/webapps/docs: changelog.xml windows-service-howto.xml
Author: markt Date: Sat Jul 18 12:04:23 2009 New Revision: 795350 URL: http://svn.apache.org/viewvc?rev=795350&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=41564 Add some info on running service.bat with UAC Modified: tomcat/container/tc5.5.x/webapps/docs/changelog.xml tomcat/container/tc5.5.x/webapps/docs/windows-service-howto.xml Modified: tomcat/container/tc5.5.x/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/webapps/docs/changelog.xml?rev=795350&r1=795349&r2=795350&view=diff == --- tomcat/container/tc5.5.x/webapps/docs/changelog.xml (original) +++ tomcat/container/tc5.5.x/webapps/docs/changelog.xml Sat Jul 18 12:04:23 2009 @@ -32,6 +32,26 @@ + + + + + + + + + + + + + + +41564: Add some information on installing Tomcat as a service +on operating systems with User Account Control, e.g. Vista. (markt) + + + + Modified: tomcat/container/tc5.5.x/webapps/docs/windows-service-howto.xml URL: http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/webapps/docs/windows-service-howto.xml?rev=795350&r1=795349&r2=795350&view=diff == --- tomcat/container/tc5.5.x/webapps/docs/windows-service-howto.xml (original) +++ tomcat/container/tc5.5.x/webapps/docs/windows-service-howto.xml Sat Jul 18 12:04:23 2009 @@ -29,11 +29,6 @@ - - -This section of the documentation applies to procrun 1.0, and is now obsolete. - - Tomcat5 is a service application for running Tomcat5 as NT service. @@ -301,7 +296,15 @@ -The safest way to manually install the service is to use the provided service.bat script. +The safest way to manually install the service is to use the provided +service.bat script. Administrator privileges are required to run this +script. + + +NOTE: On Windows Vista or any other operating system with User +Account Control (UAC) you must either disable UAC or right-click on cmd.exe and +select "Run as administrator" in order to run this script. If UAC is enabled +being logged on with an Administrator account is not sufficient. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 41564] service.bat does not install tomcat as a service properly on Windows Vista
https://issues.apache.org/bugzilla/show_bug.cgi?id=41564 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #18 from Mark Thomas 2009-07-18 05:04:49 PST --- I've updated the docs for trunk 6.0.x (will be in 6.0.21) and 5.5.x (will be in 5.5.29). -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 41530] stopping a connector produces intermittent SocketException
https://issues.apache.org/bugzilla/show_bug.cgi?id=41530 Konstantin Kolinko changed: What|Removed |Added Status|VERIFIED|CLOSED --- Comment #2 from Konstantin Kolinko 2009-07-18 06:40:56 PST --- Fixed in 6.0.11. I am changing status from VERIFIED to CLOSED. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 41797] CNFE/NPE thrown from function mapper when externalizing
https://issues.apache.org/bugzilla/show_bug.cgi?id=41797 Konstantin Kolinko changed: What|Removed |Added Status|VERIFIED|CLOSED --- Comment #10 from Konstantin Kolinko 2009-07-18 06:44:14 PST --- Fixed in 6.0.15 (6.0.16). I am changing status from VERIFIED to CLOSED. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r795449 - /tomcat/connectors/trunk/jk/HOWTO-RELEASE.txt
Author: kkolinko Date: Sat Jul 18 23:45:07 2009 New Revision: 795449 URL: http://svn.apache.org/viewvc?rev=795449&view=rev Log: Add mention of the Tomcat announements list that was established a month ago. Modified: tomcat/connectors/trunk/jk/HOWTO-RELEASE.txt Modified: tomcat/connectors/trunk/jk/HOWTO-RELEASE.txt URL: http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/HOWTO-RELEASE.txt?rev=795449&r1=795448&r2=795449&view=diff == --- tomcat/connectors/trunk/jk/HOWTO-RELEASE.txt (original) +++ tomcat/connectors/trunk/jk/HOWTO-RELEASE.txt Sat Jul 18 23:45:07 2009 @@ -175,6 +175,7 @@ 24 hours before sending out the announcement so that the mirrors get a chance to get the new release distributions. -Send an email announcement to us...@tomcat.apache.org, -...@tomcat.apache.org, and annou...@apache.org. +Send an email announcement to annou...@tomcat.apache.org, +us...@tomcat.apache.org, dev@tomcat.apache.org and +annou...@apache.org. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r795457 - /tomcat/trunk/java/org/apache/catalina/ha/session/JvmRouteBinderValve.java
Author: kkolinko
Date: Sun Jul 19 01:12:50 2009
New Revision: 795457
URL: http://svn.apache.org/viewvc?rev=795457&view=rev
Log:
Rewrote (reworded) the Javadoc comment for JvmRouteBinderValve class.
Modified:
tomcat/trunk/java/org/apache/catalina/ha/session/JvmRouteBinderValve.java
Modified:
tomcat/trunk/java/org/apache/catalina/ha/session/JvmRouteBinderValve.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ha/session/JvmRouteBinderValve.java?rev=795457&r1=795456&r2=795457&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/ha/session/JvmRouteBinderValve.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/ha/session/JvmRouteBinderValve.java
Sun Jul 19 01:12:50 2009
@@ -47,40 +47,52 @@
/**
* Valve to handle Tomcat jvmRoute takeover using mod_jk module after node
- * failure. After a node crashed the next request going to other cluster node.
- * Now the answering from apache is slower ( make some error handshaking. Very
- * bad with apache at my windows.). We rewrite now the cookie jsessionid
- * information to the backup cluster node. After the next response all client
- * request goes direct to the backup node. The change sessionid send also to
all
- * other cluster nodes. Well, now the session stickyness work directly to the
- * backup node and traffic don't go back too restarted cluster nodes!
+ * failure. After a node crashes, subsequent requests go to other cluster
nodes.
+ * That incurs a drop in performance. When this Valve is enabled on a backup
+ * node and sees a request, which was intended for another (thus failed) node,
+ * it will rewrite the cookie jsessionid information to use the route to this
+ * backup cluster node, that answered the request. After the response is
+ * delivered to the client, all subsequent client requests will go directly to
+ * the backup node. The change of sessionid is also sent to all other cluster
+ * nodes. After all that, the session stickyness will work directly to the
+ * backup node and the traffic will not go back to the failed node after it is
+ * restarted!
*
- * At all cluster node you must configure the as ClusterListener since 5.5.10
- * {...@link org.apache.catalina.ha.session.JvmRouteSessionIDBinderListener
JvmRouteSessionIDBinderListener}
- * or before with
- * org.apache.catalina.ha.session.JvmRouteSessionIDBinderListenerLifecycle.
+ *
+ * For this valve to function correctly, so that all nodes of the cluster
+ * receive the sessionid change notifications that it generates, the following
+ * ClusterListener MUST be configured at all nodes of the cluster:
+ * {...@link org.apache.catalina.ha.session.JvmRouteSessionIDBinderListener
+ * JvmRouteSessionIDBinderListener} since Tomcat 5.5.10, and both
+ * JvmRouteSessionIDBinderListener and JvmRouteSessionIDBinderLifecycleListener
+ * for earlier versions of Tomcat.
*
+ *
* Add this Valve to your host definition at conf/server.xml .
*
* Since 5.5.10 as direct cluster valve:
+ *
*
*
*
*
+ *
*
* Before 5.5.10 as Host element:
+ *
*
- *
+ *
*
+ *
*
*
- * Trick:
- * You can enable this mod_jk turnover mode via JMX before you drop a node to
all backup nodes!
- * Set enable true on all JvmRouteBinderValve backups, disable worker at
mod_jk
- * and then drop node and restart it! Then enable mod_jk Worker and disable
JvmRouteBinderValves again.
- * This use case means that only requested session are migrated.
+ * A Trick:
+ * You can enable this mod_jk turnover mode via JMX before you drop a node to
+ * all backup nodes! Set enable true on all JvmRouteBinderValve backups,
disable
+ * worker at mod_jk and then drop node and restart it! Then enable mod_jk
worker
+ * and disable JvmRouteBinderValves again. This use case means that only
+ * requested sessions are migrated.
*
* @author Peter Rossbach
* @version $Revision$ $Date$
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r795458 - in /tomcat/tc6.0.x/trunk: ./ java/org/apache/catalina/ha/session/JvmRouteBinderValve.java
Author: kkolinko Date: Sun Jul 19 01:17:02 2009 New Revision: 795458 URL: http://svn.apache.org/viewvc?rev=795458&view=rev Log: Rewrote (reworded) the Javadoc comment for JvmRouteBinderValve class. Modified: tomcat/tc6.0.x/trunk/ (props changed) tomcat/tc6.0.x/trunk/java/org/apache/catalina/ha/session/JvmRouteBinderValve.java Propchange: tomcat/tc6.0.x/trunk/ -- --- svn:mergeinfo (original) +++ svn:mergeinfo Sun Jul 19 01:17:02 2009 @@ -1 +1 @@ -/tomcat/trunk:601180,606992,612607,630314,640888,652744,653247,673796,673820,683982,684001,684081,684234,684269-684270,685177,687503,687645,689402,690781,691392,691805,692748,693378,694992,695053,695311,696780,696782,698012,698227,698236,698613,699427,699634,701355,709294,709811,709816,710063,710066,710125,710205,711126,711600,712461,712467,718360,719119,719124,719602,719626,719628,720046,720069,721040,721286,721708,721886,723404,723738,726052,727303,728032,728768,728947,729057,729567,729569,729571,729681,729809,729815,729934,730250,730590,731651,732859,732863,734734,740675,740684,742677,742697,742714,744160,744238,746321,746384,746425,747834,747863,748344,750258,750291,750921,751286-751287,751289,751295,753039,757335,757774,758365,758596,758616,758664,759074,761601,762868,762929,762936-762937,763166,763183,763193,763228,763262,763298,763302,763325,763599,763611,763654,763681,763706,764985,764997,765662,768335,769979,770716,770809,770876,776921,776924,776935,776945,777464,77 7466,777576,777625,778379,778523-778524,781528,781779,782145,782791,783316,783696,783724,783756,783762,783766,783863,783934,784453,784602,784614,785381,785688,785768,785859,786468,786487,786490,786496,786667,787627,787770,787985,790405,791041,791184,791194,791243,791326,791328,791789,792740,793372,793757,793882,793981,794822,795043 +/tomcat/trunk:601180,606992,612607,630314,640888,652744,653247,673796,673820,683982,684001,684081,684234,684269-684270,685177,687503,687645,689402,690781,691392,691805,692748,693378,694992,695053,695311,696780,696782,698012,698227,698236,698613,699427,699634,701355,709294,709811,709816,710063,710066,710125,710205,711126,711600,712461,712467,718360,719119,719124,719602,719626,719628,720046,720069,721040,721286,721708,721886,723404,723738,726052,727303,728032,728768,728947,729057,729567,729569,729571,729681,729809,729815,729934,730250,730590,731651,732859,732863,734734,740675,740684,742677,742697,742714,744160,744238,746321,746384,746425,747834,747863,748344,750258,750291,750921,751286-751287,751289,751295,753039,757335,757774,758365,758596,758616,758664,759074,761601,762868,762929,762936-762937,763166,763183,763193,763228,763262,763298,763302,763325,763599,763611,763654,763681,763706,764985,764997,765662,768335,769979,770716,770809,770876,776921,776924,776935,776945,777464,77 7466,777576,777625,778379,778523-778524,781528,781779,782145,782791,783316,783696,783724,783756,783762,783766,783863,783934,784453,784602,784614,785381,785688,785768,785859,786468,786487,786490,786496,786667,787627,787770,787985,790405,791041,791184,791194,791243,791326,791328,791789,792740,793372,793757,793882,793981,794822,795043,795457 Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/ha/session/JvmRouteBinderValve.java URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/ha/session/JvmRouteBinderValve.java?rev=795458&r1=795457&r2=795458&view=diff == --- tomcat/tc6.0.x/trunk/java/org/apache/catalina/ha/session/JvmRouteBinderValve.java (original) +++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/ha/session/JvmRouteBinderValve.java Sun Jul 19 01:17:02 2009 @@ -46,40 +46,52 @@ /** * Valve to handle Tomcat jvmRoute takeover using mod_jk module after node - * failure. After a node crashed the next request going to other cluster node. - * Now the answering from apache is slower ( make some error handshaking. Very - * bad with apache at my windows.). We rewrite now the cookie jsessionid - * information to the backup cluster node. After the next response all client - * request goes direct to the backup node. The change sessionid send also to all - * other cluster nodes. Well, now the session stickyness work directly to the - * backup node and traffic don't go back too restarted cluster nodes! + * failure. After a node crashes, subsequent requests go to other cluster nodes. + * That incurs a drop in performance. When this Valve is enabled on a backup + * node and sees a request, which was intended for another (thus failed) node, + * it will rewrite the cookie jsessionid information to use the route to this + * backup cluster node, that answered the request. After the response is + * delivered to the client, all subsequent client requests will go directly to + * the backup node. The change of sessionid is also sent to all other cluster + * nodes. After all that, the session stickyness will
DO NOT REPLY [Bug 47378] welcome-file ignores servlet mapping
https://issues.apache.org/bugzilla/show_bug.cgi?id=47378
--- Comment #8 from Tim Funk 2009-07-18 18:26:49 PST ---
This might work as a patch to org.apache.tomcat.util.http.mapper.Mapper - add
it before // Rule 7 -- Default servlet and after // Rule 4 -- Welcome
resources processing for servlets
// DAMMIT - welcome file processing - take 2
// take first matching welcome match
// its a copy of rule 4 since it needs to do less
if (mappingData.wrapper == null) {
boolean checkWelcomeFiles = checkJspWelcomeFiles;
if (!checkWelcomeFiles) {
char[] buf = path.getBuffer();
checkWelcomeFiles = (buf[pathEnd - 1] == '/');
}
if (checkWelcomeFiles) {
for (int i = 0; (i < context.welcomeResources.length)
&& (mappingData.wrapper == null); i++) {
path.setOffset(pathOffset);
path.setEnd(pathEnd);
path.append(context.welcomeResources[i], 0,
context.welcomeResources[i].length());
path.setOffset(servletPath);
internalMapExtensionWrapper(extensionWrappers,
path, mappingData);
if (mappingData.wrapper == null
&& context.defaultWrapper != null) {
mappingData.wrapper =
context.defaultWrapper.object;
mappingData.requestPath.setChars
(path.getBuffer(), path.getStart(),
path.getLength());
mappingData.wrapperPath.setChars
(path.getBuffer(), path.getStart(),
path.getLength());
mappingData.requestPath.setString(pathStr);
mappingData.wrapperPath.setString(pathStr);
}
}
path.setOffset(servletPath);
path.setEnd(pathEnd);
}
}
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r795466 - /tomcat/trunk/java/org/apache/jasper/compiler/Generator.java
Author: kkolinko
Date: Sun Jul 19 02:52:32 2009
New Revision: 795466
URL: http://svn.apache.org/viewvc?rev=795466&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47413
First part of a composite expression "${a}${b}" was not coerced to String
Modified:
tomcat/trunk/java/org/apache/jasper/compiler/Generator.java
Modified: tomcat/trunk/java/org/apache/jasper/compiler/Generator.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/compiler/Generator.java?rev=795466&r1=795465&r2=795466&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/compiler/Generator.java (original)
+++ tomcat/trunk/java/org/apache/jasper/compiler/Generator.java Sun Jul 19
02:52:32 2009
@@ -862,6 +862,10 @@
// Composite expression - must coerce to String
type = String.class;
}
+if (i+1 < size) {
+// Composite expression - must coerce to String
+type = String.class;
+}
output.append(
JspUtil.interpreterCall(isTag,
tx.substring(mark, i+1), type,
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r795467 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: kkolinko
Date: Sun Jul 19 02:57:48 2009
New Revision: 795467
URL: http://svn.apache.org/viewvc?rev=795467&view=rev
Log:
proposal
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=795467&r1=795466&r2=795467&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Sun Jul 19 02:57:48 2009
@@ -180,3 +180,11 @@
http://svn.apache.org/viewvc?rev=795210&view=rev
+1: markt, kkolinko
-1:
+
+* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47413
+ First part of a composite EL expression "${a}${b}" was not coerced to String
+ Without coercion, the concatenation of ((Object)null) + string results in
+ "null" being printed.
+ http://svn.apache.org/viewvc?rev=795466&view=rev
+ +1: kkolinko
+ -1:
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 47413] There is difference tag output between 6.0.18 and 6.0.20
https://issues.apache.org/bugzilla/show_bug.cgi?id=47413
--- Comment #6 from Konstantin Kolinko 2009-07-18
20:06:35 PST ---
I've debugged the issue
(the one, demonstrated by example jsp attached in comment #4)
If you look to what java code is generated for
you will see, that the first part of the value expression is constrained to
Object. That is wrong, because both ${foo} and ${undefined} should be
constrained to String.
I fixed it in trunk and proposed for 6.0.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 47487] "null " as result of expression evaluation
https://issues.apache.org/bugzilla/show_bug.cgi?id=47487 Konstantin Kolinko changed: What|Removed |Added Status|NEW |RESOLVED Resolution||DUPLICATE --- Comment #1 from Konstantin Kolinko 2009-07-18 20:08:38 PST --- *** This bug has been marked as a duplicate of bug 47413 *** -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 47413] There is difference tag output between 6.0.18 and 6.0.20
https://issues.apache.org/bugzilla/show_bug.cgi?id=47413 Konstantin Kolinko changed: What|Removed |Added CC||alfred.staflin...@infoniqa. ||com --- Comment #7 from Konstantin Kolinko 2009-07-18 20:08:38 PST --- *** Bug 47487 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
