Author: kkolinko Date: Sun Jul 19 01:17:02 2009 New Revision: 795458 URL: http://svn.apache.org/viewvc?rev=795458&view=rev Log: Rewrote (reworded) the Javadoc comment for JvmRouteBinderValve class.
Modified: tomcat/tc6.0.x/trunk/ (props changed) tomcat/tc6.0.x/trunk/java/org/apache/catalina/ha/session/JvmRouteBinderValve.java Propchange: tomcat/tc6.0.x/trunk/ ------------------------------------------------------------------------------ --- svn:mergeinfo (original) +++ svn:mergeinfo Sun Jul 19 01:17:02 2009 @@ -1 +1 @@ -/tomcat/trunk:601180,606992,612607,630314,640888,652744,653247,673796,673820,683982,684001,684081,684234,684269-684270,685177,687503,687645,689402,690781,691392,691805,692748,693378,694992,695053,695311,696780,696782,698012,698227,698236,698613,699427,699634,701355,709294,709811,709816,710063,710066,710125,710205,711126,711600,712461,712467,718360,719119,719124,719602,719626,719628,720046,720069,721040,721286,721708,721886,723404,723738,726052,727303,728032,728768,728947,729057,729567,729569,729571,729681,729809,729815,729934,730250,730590,731651,732859,732863,734734,740675,740684,742677,742697,742714,744160,744238,746321,746384,746425,747834,747863,748344,750258,750291,750921,751286-751287,751289,751295,753039,757335,757774,758365,758596,758616,758664,759074,761601,762868,762929,762936-762937,763166,763183,763193,763228,763262,763298,763302,763325,763599,763611,763654,763681,763706,764985,764997,765662,768335,769979,770716,770809,770876,776921,776924,776935,776945,777464,77 7466,777576,777625,778379,778523-778524,781528,781779,782145,782791,783316,783696,783724,783756,783762,783766,783863,783934,784453,784602,784614,785381,785688,785768,785859,786468,786487,786490,786496,786667,787627,787770,787985,790405,791041,791184,791194,791243,791326,791328,791789,792740,793372,793757,793882,793981,794822,795043 +/tomcat/trunk:601180,606992,612607,630314,640888,652744,653247,673796,673820,683982,684001,684081,684234,684269-684270,685177,687503,687645,689402,690781,691392,691805,692748,693378,694992,695053,695311,696780,696782,698012,698227,698236,698613,699427,699634,701355,709294,709811,709816,710063,710066,710125,710205,711126,711600,712461,712467,718360,719119,719124,719602,719626,719628,720046,720069,721040,721286,721708,721886,723404,723738,726052,727303,728032,728768,728947,729057,729567,729569,729571,729681,729809,729815,729934,730250,730590,731651,732859,732863,734734,740675,740684,742677,742697,742714,744160,744238,746321,746384,746425,747834,747863,748344,750258,750291,750921,751286-751287,751289,751295,753039,757335,757774,758365,758596,758616,758664,759074,761601,762868,762929,762936-762937,763166,763183,763193,763228,763262,763298,763302,763325,763599,763611,763654,763681,763706,764985,764997,765662,768335,769979,770716,770809,770876,776921,776924,776935,776945,777464,77 7466,777576,777625,778379,778523-778524,781528,781779,782145,782791,783316,783696,783724,783756,783762,783766,783863,783934,784453,784602,784614,785381,785688,785768,785859,786468,786487,786490,786496,786667,787627,787770,787985,790405,791041,791184,791194,791243,791326,791328,791789,792740,793372,793757,793882,793981,794822,795043,795457 Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/ha/session/JvmRouteBinderValve.java URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/ha/session/JvmRouteBinderValve.java?rev=795458&r1=795457&r2=795458&view=diff ============================================================================== --- tomcat/tc6.0.x/trunk/java/org/apache/catalina/ha/session/JvmRouteBinderValve.java (original) +++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/ha/session/JvmRouteBinderValve.java Sun Jul 19 01:17:02 2009 @@ -46,40 +46,52 @@ /** * Valve to handle Tomcat jvmRoute takeover using mod_jk module after node - * failure. After a node crashed the next request going to other cluster node. - * Now the answering from apache is slower ( make some error handshaking. Very - * bad with apache at my windows.). We rewrite now the cookie jsessionid - * information to the backup cluster node. After the next response all client - * request goes direct to the backup node. The change sessionid send also to all - * other cluster nodes. Well, now the session stickyness work directly to the - * backup node and traffic don't go back too restarted cluster nodes! + * failure. After a node crashes, subsequent requests go to other cluster nodes. + * That incurs a drop in performance. When this Valve is enabled on a backup + * node and sees a request, which was intended for another (thus failed) node, + * it will rewrite the cookie jsessionid information to use the route to this + * backup cluster node, that answered the request. After the response is + * delivered to the client, all subsequent client requests will go directly to + * the backup node. The change of sessionid is also sent to all other cluster + * nodes. After all that, the session stickyness will work directly to the + * backup node and the traffic will not go back to the failed node after it is + * restarted! * - * At all cluster node you must configure the as ClusterListener since 5.5.10 - * {...@link org.apache.catalina.ha.session.JvmRouteSessionIDBinderListener JvmRouteSessionIDBinderListener} - * or before with - * org.apache.catalina.ha.session.JvmRouteSessionIDBinderListenerLifecycle. + * <p> + * For this valve to function correctly, so that all nodes of the cluster + * receive the sessionid change notifications that it generates, the following + * ClusterListener MUST be configured at all nodes of the cluster: + * {...@link org.apache.catalina.ha.session.JvmRouteSessionIDBinderListener + * JvmRouteSessionIDBinderListener} since Tomcat 5.5.10, and both + * JvmRouteSessionIDBinderListener and JvmRouteSessionIDBinderLifecycleListener + * for earlier versions of Tomcat. * + * <p> * Add this Valve to your host definition at conf/server.xml . * * Since 5.5.10 as direct cluster valve:<br/> + * * <pre> * <Cluster> * <Valve className="org.apache.catalina.ha.session.JvmRouteBinderValve" /> * </Cluster> * </pre> + * * <br /> * Before 5.5.10 as Host element:<br/> + * * <pre> - * <Hostr> + * <Host> * <Valve className="org.apache.catalina.ha.session.JvmRouteBinderValve" /> - * </Hostr> + * </Host> * </pre> * - * Trick:<br/> - * You can enable this mod_jk turnover mode via JMX before you drop a node to all backup nodes! - * Set enable true on all JvmRouteBinderValve backups, disable worker at mod_jk - * and then drop node and restart it! Then enable mod_jk Worker and disable JvmRouteBinderValves again. - * This use case means that only requested session are migrated. + * <em>A Trick:</em><br/> + * You can enable this mod_jk turnover mode via JMX before you drop a node to + * all backup nodes! Set enable true on all JvmRouteBinderValve backups, disable + * worker at mod_jk and then drop node and restart it! Then enable mod_jk worker + * and disable JvmRouteBinderValves again. This use case means that only + * requested sessions are migrated. * * @author Peter Rossbach * @version $Revision$ $Date$ --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org