DO NOT REPLY [Bug 47216] Possible NPE in Http11Processor.action()

2009-05-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47216





--- Comment #2 from Sebb   2009-05-19 05:01:51 PST ---
(In reply to comment #1)
> This "bug" is purely theoretical.  The only way to hit it is to hold a
> reference to the Request after request processing has finished.

In that case, why does the action() method bother checking for socket!=null
everywhere else?

It does not make sense to have to check for null when processing
ACTION_REQ_LOCAL_NAME_ATTRIBUTE (e.g.) but not when processing
ACTION_REQ_LOCAL_ADDR_ATTRIBUTE.

> If you do
> that, IMHO you deserve all the NPEs you get.
> +0 to making parseHost protected (since anyone subclassing this will likely
> need it).

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r776390 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-05-19 Thread kkolinko
Author: kkolinko
Date: Tue May 19 17:35:21 2009
New Revision: 776390

URL: http://svn.apache.org/viewvc?rev=776390&view=rev
Log:
vote

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=776390&r1=776389&r2=776390&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Tue May 19 17:35:21 2009
@@ -168,6 +168,18 @@
   Deregister all MBeans when the server is stopped
   http://svn.apache.org/viewvc?rev=769979&view=rev
   +1: markt, pero
+  +1: kkolinko (ok, but one question:
+in MBeanUtils.java:
+
+@@ -1401,12 +1417,7 @@
+ static void destroyMBean(Context context)
+ ..
++String domain = context.getParent().getParent().getName();
+ if (domain == null)
+ domain = mserver.getDefaultDomain();
+
+ Can domain be null here, or one of those getParent().foo() calls 
result in an NPE ?
+  )
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47080



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Eclipse+Tomcat6]How to publish modification in a text file ?

2009-05-19 Thread b...@umd

I am developing a webapp with Eclipse 3.4.2 which runs on a Tomcat v6 server.

When I click on a button of my webapp during runtime, it modifies or
createsa shell script present in my webapp folder. Then, I retrieve this
script (which contains installation instructions) at the startup of a
Virtual Machine. My problem is that this script is not updated/created on my
server whereas it is in my filesystem.  (But if I manually refresh webapp on
Eclipse, this script is correctly updated/created.)

I first thought it was a problem of caching in Tomcat, so I edited the
context.xml file to disable caching like this :

Then I try to set the development init-param to true in my web.xml like this

development
true


However, it changes nothing. Does anyone have an idea of how i can
automatically "refresh" my webapp folder and synchronize it with my
filesystem ?

-- 
View this message in context: 
http://www.nabble.com/-Eclipse%2BTomcat6-How-to-publish-modification-in-a-text-file---tp23624586p23624586.html
Sent from the Tomcat - Dev mailing list archive at Nabble.com.


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 47222] New: Changes made to ping_timeout via Status Worker not synced across Apache Children

2009-05-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47222

   Summary: Changes made to ping_timeout via Status Worker not
synced across Apache Children
   Product: Tomcat Connectors
   Version: 1.2.28
  Platform: PC
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: P2
 Component: mod_jk
AssignedTo: dev@tomcat.apache.org
ReportedBy: j...@k12s.phast.umass.edu


Changes made to ping_timeout via Status Worker not synced across Apache
Children

Configure Apache to use the mpm_worker, and start 2 children by default

Access the Status Worker, and change the "Ping Timeout:" on a worker.  EG:
Change it from 1 to 15000

Query the status worker using a non-keepalived webbrowser (such as curl) and
see what the setting is set to.  It will alternate between the OLD setting and
the NEW setting.  EG:

curl "http://SERVERNAMEHERE/ajpstatus?cmd=show&w=WORKERNAMEHERE&mime=txt";
-> First request returned 1 (the 'old' value)

curl "http://SERVERNAMEHERE/ajpstatus?cmd=show&w=WORKERNAMEHERE&mime=txt";
-> Second request returned 15000 (the 'new' value)

If you change another value, such as 'Retries', your change will by synced
across the children

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 47222] Changes made to ping_timeout via Status Worker not synced across Apache Children

2009-05-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47222





--- Comment #1 from Joe Kislo   2009-05-19 15:07:26 
PST ---
This bug seems simple now, but it caused alot of head banging for me.  I didn't
realize that it was just this one parameter; I was assuming it was ALL
parameters that weren't being synced, and I kept looking for problems with my
Shm file.  It wasn't until I was writing this bug report I discovered it
appears (although I didn't throughly test) that it's just this one parameter

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Configuring while moving app from iPlanet 4.1 to Tomcat 6

2009-05-19 Thread raghu ram srinivas
I am not sure how can i configure my web.xml in tomcat. can any one help me
regarding this issue?

Actually i got 3 main config files in iplanet ie.,1. ob.conf,
2.mime.conf,and 3. magns.conf. After moving my web application from iplanet
to tomcat I am not sure how can I configure it in the Tomcat .


Thanks in Advance.


DO NOT REPLY [Bug 47224] New: Hostname and Port Changes from Status Worker do not affect new connections either

2009-05-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47224

   Summary: Hostname and Port Changes from Status Worker do not
affect new connections either
   Product: Tomcat Connectors
   Version: 1.2.28
  Platform: PC
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: P2
 Component: mod_jk
AssignedTo: dev@tomcat.apache.org
ReportedBy: j...@k12s.phast.umass.edu


Hostname and Port Changes from Status Worker do not affect new connections
either

I do not know if this is a documentation issue or a software bug.  I am hoping
it is a software bug (because I want it to work!), but I'll settle for some
clarification in the documentation.

If you change the hostname or port of an AJP worker from the Status Worker, the
change does not appear to always work.  The documentation states:
---
http://tomcat.apache.org/connectors-doc/reference/status.html:

Note that changing the host name or port will only take effect for new
connections. Already established connections to the old address will still be
used. 
---

This is, actually, exactly the behavior I want.  Old connections continue to
use the old settings, but new connections use the new settings.  What I am
seeing is my change is not affecting new connections either (I am using a
non-keep alive new TCP connection... I am using curl).  I believe there must be
some sort of worker internal to mod_jk, and that worker is not being updated
with the setting.

If I make TWO new requests in parallel, the first request will get old
settings, and the second request will get the new settings.

So either the internal workers need to be signaled for a graceful shutdown
after a port or hostname change (after handling their existing requests) or the
existing internal workers need to be notified of the change.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 47224] Hostname and Port Changes from Status Worker do not affect new connections either

2009-05-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47224





--- Comment #1 from Joe Kislo   2009-05-19 15:40:59 
PST ---
FWIW, what I am actually trying to accomplish is an administrative shutdown of
an AJP worker at runtime.  I am trying to accomplish this by changing the port
to 0.  So I would settle for another way of admin downing a worker... I am
going to try building a LB worker with just the single AJP subworker in it and
see if I can accomplish it that way, even though I am doing no load balancing.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r776523 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-05-19 Thread kkolinko
Author: kkolinko
Date: Wed May 20 02:33:55 2009
New Revision: 776523

URL: http://svn.apache.org/viewvc?rev=776523&view=rev
Log:
vote

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=776523&r1=776522&r2=776523&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Wed May 20 02:33:55 2009
@@ -153,7 +153,10 @@
   Patch provided by Konstantin Kolinko
   http://svn.apache.org/viewvc?rev=763717&view=rev
   +1: markt, remm (risky ...)
-  -1: 
+  -1: kkolinko: sorry, but it looks like I have to revoke my own patch
+ At very least: it is, indeed, risky: it changes behavior both for
+ SimpleTags and Tags, but only SimpleTags were reported to be broken.
+ It will need more testing.
 
 * Fix use of non-ASCII characters in property files
   http://people.apache.org/~markt/patches/2009-04-20-native2ascii-de.patch 
(German)



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 47225] New: Wrong argument in redirectPath.setChars in Mapper.internalMapWrapper()

2009-05-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47225

   Summary: Wrong argument in redirectPath.setChars in
Mapper.internalMapWrapper()
   Product: Tomcat 6
   Version: 6.0.18
  Platform: PC
OS/Version: Windows XP
Status: NEW
  Severity: minor
  Priority: P2
 Component: Catalina
AssignedTo: dev@tomcat.apache.org
ReportedBy: knst.koli...@gmail.com


Found in current trunk and tc6.0.x, and tc5.5.x:

http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/http/mapper/Mapper.java?annotate=734728&pathrev=770809

730 :  if(mappingData.wrapper == null && noServletPath) {
731 : // The path is empty, redirect to "/"
732 : mappingData.redirectPath.setChars
733 : (path.getBuffer(), pathOffset, pathEnd);
734 : path.setEnd(pathEnd - 1);
735 : return;
736 : }

On line 733 the pathEnd argument is wrong:
it should be length, not an index.

It should be
 mappingData.redirectPath.setChars(path.getBuffer(), pathOffset,
pathEnd-pathOffset);

Do not know, why there are no complaints. May be pathOffset is always zero?

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 34110] The message "SEVERE: Error listenerStart" should be more explicit

2009-05-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=34110


Wesley  changed:

   What|Removed |Added

 CC||topo...@gmail.com




-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org