https://issues.apache.org/bugzilla/show_bug.cgi?id=47216





--- Comment #2 from Sebb <s...@apache.org>  2009-05-19 05:01:51 PST ---
(In reply to comment #1)
> This "bug" is purely theoretical.  The only way to hit it is to hold a
> reference to the Request after request processing has finished.

In that case, why does the action() method bother checking for socket!=null
everywhere else?

It does not make sense to have to check for null when processing
ACTION_REQ_LOCAL_NAME_ATTRIBUTE (e.g.) but not when processing
ACTION_REQ_LOCAL_ADDR_ATTRIBUTE.

> If you do
> that, IMHO you deserve all the NPEs you get.
> +0 to making parseHost protected (since anyone subclassing this will likely
> need it).

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to