DO NOT REPLY [Bug 46655] New: keystore's password handler
https://issues.apache.org/bugzilla/show_bug.cgi?id=46655 Summary: keystore's password handler Product: Tomcat 6 Version: 6.0.18 Platform: PC OS/Version: Windows XP Status: NEW Severity: enhancement Priority: P2 Component: Catalina AssignedTo: dev@tomcat.apache.org ReportedBy: alessandro.giann...@urmet.it Created an attachment (id=23216) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=23216) Connector.java This patch is useful when you want handle keystore password from external class. To do this, I added two additional parameters (in Connector tag of server.xml) to call external method and get Password String. - Parameter keystorePassHandler (in form some.package.Class.methodToInvoke) - Parameter truststorePassHandler (in form some.package.Class.methodToInvoke) obviously, if not present, keystorePass and truststorePass parameters are used. Example: Using external attached passConsole.jar to enter password from console add attribute to Connector tag of server.xml If new attributes are presents,keystorePass and truststorePass are ignored (can be omitted). -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46655] keystore's password handler
https://issues.apache.org/bugzilla/show_bug.cgi?id=46655 --- Comment #1 from Alessandro 2009-02-03 00:27:56 PST --- Created an attachment (id=23217) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=23217) example of external jar to handle pasword An example of external keystore's password utilization -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46658] New: tomcat5.exe (x64) V2.0.4 aka procrun loads different registry hive than V2.0.3
https://issues.apache.org/bugzilla/show_bug.cgi?id=46658 Summary: tomcat5.exe (x64) V2.0.4 aka procrun loads different registry hive than V2.0.3 Product: Tomcat 5 Version: 5.5.25 Platform: PC OS/Version: Windows XP Status: NEW Severity: normal Priority: P2 Component: Native:Integration AssignedTo: dev@tomcat.apache.org ReportedBy: t.stra...@srs-management.de Version 2.0.3 of the service starter (version according to file-properties in windows) (version for x64) will read the settings for tomcat startup from the registry key HKEY_LOCAL_MACHINE\SOFTWARE\Apache Software Foundation\Procrun 2.0\ The Version 2.0.4 (also version for x64) will read the settings from the win32 compatibility branch of the registry HKEY_LOCAL_MACHINE\SOFTWARE\Wow6432Node\Apache Software Foundation\Procrun 2.0\ This and should not be that way. When migrating from an x32 environment, the settings are in the same path as the x64 are expected to be. The second path (WOW6432Node) is only to be used by x32 applications running on x64 and accessing the registry (actually windows will realize the 32bitness of the accessor and redirect the access into the Wow6432node hive). I suppose that someone configured using tomcat5w.exe x32 and then the tomcat5.exe x64 did not find the settings? A possible fix might be that both hives are sought, first the x64 standard path and if it is not found there, then the x32 WOW hive is checked. Remark: I tried to give the fix a try for myself, but I was not able to identify the Version 2.0.3 or 2.0.4 in the commons-daemon project. There I only found 1.0.1 or 1.0 versions, this leaves the question: which version is integrated in Tomcat? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46658] tomcat5.exe (x64) V2.0.4 aka procrun loads different registry hive than V2.0.3
https://issues.apache.org/bugzilla/show_bug.cgi?id=46658 Thomas Strau changed: What|Removed |Added OS/Version|Windows XP |Windows Server 2003 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn repo layout for modules
On Tue, Feb 3, 2009 at 5:14 AM, Remy Maucherat wrote: > On Fri, 2009-01-30 at 17:44 -0700, Filip Hanik - Dev Lists wrote: > > I would suggest > > > > https://svn.apache.org/repos/asf/tomcat/ > > - site > > - tc6.0.x > > - trunk > > - modules <-- ADD THIS > > - jdbc-pool > > - trunk > > - tags > > - branches > > - bayeux > > - trunk > > - tags > > - branches > > > > and move it away and out of (and get rid of) the tomcat/modules folder, > > and let tomcat be tomcat. > > My suggestion is to dump modules as much as possible, this is messy. > JDBC should really be developed elsewhere beyond the experimental stage > (Tomcat is not a DB project, thanks) and Bayeux should go to the main > tree (if it works). Good points. Costin
DO NOT REPLY [Bug 46658] tomcat5.exe (x64) V2.0.4 aka procrun loads different registry hive than V2.0.3
https://issues.apache.org/bugzilla/show_bug.cgi?id=46658 Mladen Turk changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WONTFIX --- Comment #1 from Mladen Turk 2009-02-03 09:28:27 PST --- > This and should not be that way. But it should, since both 32 and 64 bits are supported and can live together. The main reason is the installer which is 32bit and creates the key under Wow6432Node Any 64bit would simply fail because of missing registry. The solution is to move your existing key to Wow6432Node like you observed. I doubt it's worth to complicate things and add extra checking for registry. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn repo layout for modules
On Fri, 2009-01-30 at 17:44 -0700, Filip Hanik - Dev Lists wrote: > I would suggest > > https://svn.apache.org/repos/asf/tomcat/ > - site > - tc6.0.x > - trunk > - modules <-- ADD THIS > - jdbc-pool > - trunk > - tags > - branches > - bayeux > - trunk > - tags > - branches > > and move it away and out of (and get rid of) the tomcat/modules folder, > and let tomcat be tomcat. My suggestion is to dump modules as much as possible, this is messy. JDBC should really be developed elsewhere beyond the experimental stage (Tomcat is not a DB project, thanks) and Bayeux should go to the main tree (if it works). Rémy - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46658] tomcat5.exe (x64) V2.0.4 aka procrun loads different registry hive than V2.0.3
https://issues.apache.org/bugzilla/show_bug.cgi?id=46658 --- Comment #2 from Thomas Strau 2009-02-03 13:13:43 PST --- Fine, I dislike this a lot, since I have setup multiple services using the tomcat5w.exe (x64) V2.0.3 and it wrote it's settings to the "real place". Now I need to do a registry export - edit - import - hope it runs fine cycle :-( So, since there are many ways to setup tomcat as a service besides the installer, and version 2.0.3 behaved completely different in this apect, you have complicated things a lot for me. BTW: The 2.0.3 to 2.0.4 has changed it's behaviour in a way, that could at least have been noted in the docs or in the committers-log somewhere. BTW2: I still cannot compile my own version, as I cannot find the information on what version the procrun-tomcat is actually running on: Where's the source Luke? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46586] impossible download a jar with this webapp
https://issues.apache.org/bugzilla/show_bug.cgi?id=46586 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WONTFIX --- Comment #5 from Mark Thomas 2009-02-03 22:47:57 PST --- This is a bit of a grey area but given that: - attributes may be set by the container (SRV.3.2) - there is generally no need to remove attributes (ServletRequest.removeAttribute javadoc) - some attributes are explicitly reserved for use by Sun it is clear that request attributes may be set outside of the application's control. Therefore, removing all request attributes is likely to have unexpected side effects as seen here. Given the above, it is good practise for components to only attempt to manipulate the request attributes that they own. On this basis I am marking the bug as WONTFIX. As Konstatin notes, disabling sendfile support should fix this as would changing the listener not to remove all request attributes. If neither of these is possible, then using a custom default servlet with an added call to flushBuffer() should work. If you need assistance writing or configuring your own version of Tomcat's default servlet please ask on the users list. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46600] maxKeepAliveRequests description in wrong section of documentation
https://issues.apache.org/bugzilla/show_bug.cgi?id=46600 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #1 from Mark Thomas 2009-02-03 22:53:02 PST --- Common attributes are only those required by the org.apache.catalina.connector.Connector class Whilst some additional attributes are supported by multiple connectors, these should be listed individually against each connector. I have added maxKeepAliveRequests to the NIO connector for trunk and 6.0.x. This will be included in 6.0.19 onwards. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r740632 - in /tomcat: tc6.0.x/trunk/webapps/docs/changelog.xml tc6.0.x/trunk/webapps/docs/config/http.xml trunk/webapps/docs/config/http.xml
Author: markt Date: Wed Feb 4 06:53:13 2009 New Revision: 740632 URL: http://svn.apache.org/viewvc?rev=740632&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46600 Correctly document maxKeepAliveRequests Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml tomcat/tc6.0.x/trunk/webapps/docs/config/http.xml tomcat/trunk/webapps/docs/config/http.xml Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml?rev=740632&r1=740631&r2=740632&view=diff == --- tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml (original) +++ tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Wed Feb 4 06:53:13 2009 @@ -482,6 +482,10 @@ 46563: Update doc for correct default for pollerThreadCount. (markt) + +46600: Document maxKeepAliveRequests for the NIO connector. +(markt) + Modified: tomcat/tc6.0.x/trunk/webapps/docs/config/http.xml URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/config/http.xml?rev=740632&r1=740631&r2=740632&view=diff == --- tomcat/tc6.0.x/trunk/webapps/docs/config/http.xml (original) +++ tomcat/tc6.0.x/trunk/webapps/docs/config/http.xml Wed Feb 4 06:53:13 2009 @@ -448,6 +448,14 @@ -1 means unlimited, default is 200. Set this value somewhere close to your maxThreads value. + +The maximum number of HTTP requests which can be pipelined until +the connection is closed by the server. Setting this attribute to 1 will +disable HTTP/1.0 keep-alive, as well as HTTP/1.1 keep-alive and +pipelining. Setting this to -1 will allow an unlimited amount of +pipelined or keep-alive HTTP requests. +If not specified, this attribute is set to 100. + (bool)Boolean value, whether to use direct ByteBuffers or java mapped ByteBuffers. Default is false When you are using direct buffers, make sure you allocate the appropriate amount of memory for the Modified: tomcat/trunk/webapps/docs/config/http.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/config/http.xml?rev=740632&r1=740631&r2=740632&view=diff == --- tomcat/trunk/webapps/docs/config/http.xml (original) +++ tomcat/trunk/webapps/docs/config/http.xml Wed Feb 4 06:53:13 2009 @@ -513,6 +513,15 @@ -1 means unlimited, default is 200. Set this value somewhere close to your maxThreads value. + +The maximum number of HTTP requests which can be pipelined until +the connection is closed by the server. Setting this attribute to 1 will +disable HTTP/1.0 keep-alive, as well as HTTP/1.1 keep-alive and +pipelining. Setting this to -1 will allow an unlimited amount of +pipelined or keep-alive HTTP requests. +If not specified, this attribute is set to 100. + + (bool)Boolean value, whether to use direct ByteBuffers or java mapped ByteBuffers. Default is false When you are using direct buffers, make sure you allocate the appropriate amount of memory for the - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r740635 - /tomcat/trunk/java/org/apache/catalina/servlets/WebdavServlet.java
Author: markt Date: Wed Feb 4 07:00:03 2009 New Revision: 740635 URL: http://svn.apache.org/viewvc?rev=740635&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46606 Max max depth limit configurable Modified: tomcat/trunk/java/org/apache/catalina/servlets/WebdavServlet.java Modified: tomcat/trunk/java/org/apache/catalina/servlets/WebdavServlet.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/servlets/WebdavServlet.java?rev=740635&r1=740634&r2=740635&view=diff == --- tomcat/trunk/java/org/apache/catalina/servlets/WebdavServlet.java (original) +++ tomcat/trunk/java/org/apache/catalina/servlets/WebdavServlet.java Wed Feb 4 07:00:03 2009 @@ -132,12 +132,6 @@ /** - * Default depth is infite. - */ -private static final int INFINITY = 3; // To limit tree browsing a bit - - -/** * PROPFIND - Specify a property mask. */ private static final int FIND_BY_PROPERTY = 0; @@ -250,6 +244,13 @@ private String secret = "catalina"; +/** + * Default depth in spec is infinite. Limit depth to 3 by default as + * infinite depth makes operations very expensive. + */ +private int maxDepth = 3; + + // - Public Methods @@ -264,6 +265,10 @@ if (getServletConfig().getInitParameter("secret") != null) secret = getServletConfig().getInitParameter("secret"); +if (getServletConfig().getInitParameter("maxDepth") != null) +maxDepth = Integer.parseInt( +getServletConfig().getInitParameter("maxDepth")); + // Load the MD5 helper used to calculate signatures. try { md5Helper = MessageDigest.getInstance("MD5"); @@ -438,21 +443,21 @@ // Properties which are to be displayed. Vector properties = null; // Propfind depth -int depth = INFINITY; +int depth = maxDepth; // Propfind type int type = FIND_ALL_PROP; String depthStr = req.getHeader("Depth"); if (depthStr == null) { -depth = INFINITY; +depth = maxDepth; } else { if (depthStr.equals("0")) { depth = 0; } else if (depthStr.equals("1")) { depth = 1; } else if (depthStr.equals("infinity")) { -depth = INFINITY; +depth = maxDepth; } } @@ -878,12 +883,12 @@ String depthStr = req.getHeader("Depth"); if (depthStr == null) { -lock.depth = INFINITY; +lock.depth = maxDepth; } else { if (depthStr.equals("0")) { lock.depth = 0; } else { -lock.depth = INFINITY; +lock.depth = maxDepth; } } @@ -1090,7 +1095,7 @@ md5Encoder.encode(md5Helper.digest(lockTokenStr.getBytes())); if ( (exists) && (object instanceof DirContext) && - (lock.depth == INFINITY) ) { + (lock.depth == maxDepth) ) { // Locking a collection (and all its member resources) @@ -2731,7 +2736,7 @@ generatedXML.writeElement(null, "lockscope", XMLWriter.CLOSING); generatedXML.writeElement(null, "depth", XMLWriter.OPENING); -if (depth == INFINITY) { +if (depth == maxDepth) { generatedXML.writeText("Infinity"); } else { generatedXML.writeText("0"); - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46606] WebdavServlet
https://issues.apache.org/bugzilla/show_bug.cgi?id=46606 --- Comment #1 from Mark Thomas 2009-02-03 23:06:46 PST --- The limit is in place to prevent what could be an expensive operation. I have made this configurable with the default still set to 3. This change has been made to trunk and proposed for 6.0.x and 5.5.x -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r740638 - in /tomcat: current/tc5.5.x/STATUS.txt tc6.0.x/trunk/STATUS.txt
Author: markt Date: Wed Feb 4 07:06:45 2009 New Revision: 740638 URL: http://svn.apache.org/viewvc?rev=740638&view=rev Log: Propose 46606 Modified: tomcat/current/tc5.5.x/STATUS.txt tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/current/tc5.5.x/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=740638&r1=740637&r2=740638&view=diff == --- tomcat/current/tc5.5.x/STATUS.txt (original) +++ tomcat/current/tc5.5.x/STATUS.txt Wed Feb 4 07:06:45 2009 @@ -182,3 +182,8 @@ +1: fhanik -1: +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46606 + Make max depth configurable for WebDAV servlet + http://svn.apache.org/viewvc?rev=740635&view=rev + +1: markt + -1: Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=740638&r1=740637&r2=740638&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Wed Feb 4 07:06:45 2009 @@ -81,14 +81,6 @@ +1: rjung, mturk, markt, pero, jim 0: remm (also affects to the two other AJP connectors) -* Fix serialisation issue reported by Find Bugs - http://svn.apache.org/viewvc?rev=699633&view=rev - +1: markt - +1: funkman (prefer to also remove Serializable from trunk) - 0: remm (StdContext was marked as Serializable for an experiment; obviously it won't work) - 0: not sure what to serialize here, don't see it as necessary - -1: - * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45403 See commit message for details of negligable performance impact http://svn.apache.org/viewvc?rev=701358&view=rev @@ -141,3 +133,9 @@ Make page encoding test case insensitive +1: markt -1: + +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46606 + Make max depth configurable for WebDAV servlet + http://svn.apache.org/viewvc?rev=740635&view=rev + +1: markt + -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 37918] EL cannot find valid getter from object when using some inheritance
https://issues.apache.org/bugzilla/show_bug.cgi?id=37918 Mark Thomas changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution||WORKSFORME --- Comment #2 from Mark Thomas 2009-02-03 23:07:50 PST --- A simple test case based on the above works for me with the latest 5.5.x and 6.0.x code. If you still see this problem, feel free to re-open this issue. It would help a lot if you could provide the simplest possible test case that demonstrates the issue. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 38046] apache-tomcat-5.5.14-deployer doesn't work (IllegalStateException: No Java compiler available)
https://issues.apache.org/bugzilla/show_bug.cgi?id=38046 Mark Thomas changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution||WORKSFORME --- Comment #4 from Mark Thomas 2009-02-03 23:08:08 PST --- This works for me with a simple hello world JSP and the latest 5.5.x source. If you still see this problem please feel free to re-open this issue. If re-opening, it would help a lot if you provided the simplest possible webapp that exhibited this error. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 38427] ServletContextListener Notified Multiple Times When Using Virtual Hosting
https://issues.apache.org/bugzilla/show_bug.cgi?id=38427 Mark Thomas changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution||INVALID --- Comment #2 from Mark Thomas 2009-02-03 23:08:31 PST --- Your context definition is causing multiple deployment of your application - hence the multiple listener notifications. You need to use a dir called ROOT or move your docBase outside your appBase. Please ask on the users list if your require further assistance with your configuration. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org