DO NOT REPLY [Bug 46352] Apache 1.3 crashes inside mod_jk.so with selfsigned SSL cert

2008-12-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46352


Patrick Middleton <[EMAIL PROTECTED]> changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WORKSFORME




--- Comment #5 from Patrick Middleton <[EMAIL PROTECTED]>  2008-12-08 03:02:35 
PST ---
I tried the additional debugging tips (run a single server using -X, as a user,
listening on nonprivileged ports) but still couldn't create a coredump.

I tried the hint about 'JkMountCopy All', and cleaned up my httpd.conf.  There
are no longer mod_jk directives in virtual host containers.  httpd no longer
crashes.

I'd been using mod_jk directives in virtual host containers because there has
been a problem with static URIs /services.html and servlet-mapped URIs
/services/ and /services/* where neither would work correctly.  Using mod_jk
1.2.27 with JkMountCopy All in the global server configuration, that problem is
gone too.

For https://localhost/services/index.jsp:
mod_jk.c:666 r->subprocess_env: SCRIPT_URL=/services/index.jsp=SCRIPT_URI

For https://localhost/services/:
mod_jk.c:666 r->subprocess_env:
REDIRECT_SCRIPT_URL=/services/=REDIRECT_SCRIPT_URI=https://localhost/services/=REDIRECT_HTTPS=on=REDIRECT_STATUS

At this point, I think there is a bug in how mod_jk works with virtual hosts,
but which does not affect well-configured servers.  Since I'm making no
progress debugging this and it's not crashing, do we want to close this bug
report?


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 46352] Apache 1.3 crashes inside mod_jk.so with selfsigned SSL cert

2008-12-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46352





--- Comment #6 from Rainer Jung <[EMAIL PROTECTED]>  2008-12-08 03:20:17 PST ---
Thanks for your feedback.

Do you have a test system, on which you can reproduce? In other words: are you
able and willing to dig into the problem some more?

If yes, It would be very helpful to kopy the ap_table_get code from comment #4
into your mod_jk.c (under a different name, like my_table_get) and replace the
call to ap_table_get in line 659 with my_table_get. Then finally add some
output statements in my_table_get to check, whether it loops indefinitely, or
whether it is actually the strcasecmp that crashes.

Unfortunately I can't reproduce, and I'm still not convinced, that it i a JK
bug. I've seen similar crashes when other modules corupt memory. So I'm still
interested in getting a clearer picture about what's wrong.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 46284] Add flag to DeltaManager that blocks processing cluster messages until local applicaiton initialization is completed

2008-12-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46284


andyb <[EMAIL PROTECTED]> changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r724384 - /tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

2008-12-08 Thread fhanik
Author: fhanik
Date: Mon Dec  8 07:52:23 2008
New Revision: 724384

URL: http://svn.apache.org/viewvc?rev=724384&view=rev
Log:
implement a bit cleanup and a rough estimate on the size of a poller

Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

Modified: tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java?rev=724384&r1=724383&r2=724384&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java Mon Dec  8 
07:52:23 2008
@@ -1280,12 +1280,14 @@
 
 protected CountDownLatch stopLatch = new CountDownLatch(1);
 
-
+protected volatile int keyCount = 0;
 
 public Poller() throws IOException {
 this.selector = Selector.open();
 }
 
+public int getKeyCount() { return keyCount; }
+
 public Selector getSelector() { return selector;}
 
 /**
@@ -1380,8 +1382,9 @@
 //processSocket(ka.getChannel(), status, dispatch);
 ka.setComet(false);//to avoid a loop
 if (status == SocketStatus.TIMEOUT ) {
-processSocket(ka.getChannel(), status, true);
-return; // don't close on comet timeout
+if (processSocket(ka.getChannel(), status, true)) {
+return; // don't close on comet timeout
+}
 } else {
 processSocket(ka.getChannel(), status, false); //don't 
dispatch if the lines below are cancelling the key
 }
@@ -1430,7 +1433,8 @@
 //do a non blocking select
 keyCount = selector.selectNow();
 }else {
-wakeupCounter.set( -1);
+keyCount = selector.keys().size();
+wakeupCounter.set(-1);
 keyCount = selector.select(selectorTimeout);
 }
 wakeupCounter.set(0);



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Executor - package dependencies

2008-12-08 Thread Filip Hanik - Dev Lists

The executor, the way we have optimized it works really well now.

I'd like to get rid of all thread pooling inside the NIO connector, but 
that would create a funky package dependency from tomcat-coyote.jar -> 
catalina.jar



any thoughts on how we could structure this so that the thread pool 
( interface) could be reused in other parts of tomcat code?


best
Filip

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 46284] Add flag to DeltaManager that blocks processing cluster messages until local applicaiton initialization is completed

2008-12-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46284





--- Comment #1 from Filip Hanik <[EMAIL PROTECTED]>  2008-12-08 08:13:30 PST ---
Here is some feedback:

1. The formatting gets somewhat messed up, there are tabs in the patch.

2.  public void messageDataReceived(ClusterMessage cmsg) {
+   // Block processing until local application initialization has
+   // completed, if a gate has been erected
+   if(gate != null) {
+   try {
+   gate.await();
+   gate = null;
+   }
+   catch(InterruptedException e) {
+   log.error(e, e);
+   }
+   }
+

This will pose a problem since it blocks the messaging threads. Other
applications running would suffer since you are now holding on to threads that
are supposed to deliver replication messages in other parts of the system.

3. openContainerGates
Does this happen all at once after all the apps are finished. (Am I reading it
correct?).
a container gate should be opened immediately after a context has finished
initialization. regardless of what other applications/containers are doing.

4. the 'gate' variable would have to be volatile, since the thread that is
creating the gate is different from the thread that is reading it, and the non
null gate might not have yet become visible.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r724393 - /tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

2008-12-08 Thread fhanik
Author: fhanik
Date: Mon Dec  8 08:24:05 2008
New Revision: 724393

URL: http://svn.apache.org/viewvc?rev=724393&view=rev
Log:
Implement keepAliveCount in a thread safe way, and as an estimate

Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

Modified: tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java?rev=724393&r1=724392&r2=724393&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java Mon Dec  8 
08:24:05 2008
@@ -707,7 +707,7 @@
 } else {
 int sum = 0;
 for (int i=0; i

Re: Executor - package dependencies

2008-12-08 Thread Remy Maucherat
On Mon, 2008-12-08 at 09:04 -0700, Filip Hanik - Dev Lists wrote:
> The executor, the way we have optimized it works really well now.
> 
> I'd like to get rid of all thread pooling inside the NIO connector, but 
> that would create a funky package dependency from tomcat-coyote.jar -> 
> catalina.jar
> 
> 
> any thoughts on how we could structure this so that the thread pool 
> ( interface) could be reused in other parts of tomcat code?

Components should use the java.util.concurrent.Excutor interface, the
other one adds Lifecycle and that's it.

I see you broke that design by Filipizing it and broke that design. It
is up to you to solve your own problems, I think ;)

Rémy



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Executor - package dependencies

2008-12-08 Thread Filip Hanik - Dev Lists

Remy Maucherat wrote:

On Mon, 2008-12-08 at 09:04 -0700, Filip Hanik - Dev Lists wrote:
  

The executor, the way we have optimized it works really well now.

I'd like to get rid of all thread pooling inside the NIO connector, but 
that would create a funky package dependency from tomcat-coyote.jar -> 
catalina.jar



any thoughts on how we could structure this so that the thread pool 
( interface) could be reused in other parts of tomcat code?



Components should use the java.util.concurrent.Excutor interface, the
other one adds Lifecycle and that's it.
  
the interface is somewhat too limited. an implementation of it would 
have to either block forever or never block, and there is no in between.



I see you broke that design by Filipizing it and broke that design. It
is up to you to solve your own problems, I think ;)
  

I'll noodle on it a bit, see if i can think of something to defilipize it

Filip

Rémy



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


  



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 46354] LIMIT_BUFFER setting causes arraycopy errors

2008-12-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46354





--- Comment #3 from Ed Hill <[EMAIL PROTECTED]>  2008-12-08 09:06:04 PST ---
I've upgraded to Tomcat-5.5.27 and Java 1.6.0_11 and I still am getting the
exception (with a slightly different stack trace - just not showing the
arraycopy)

Dec 8, 2008 10:57:20 AM org.apache.catalina.core.StandardWrapperValve invoke
SEVERE: Servlet.service() for servlet StripesDispatcher threw exception
java.lang.ArrayIndexOutOfBoundsException
at java.lang.String.getChars(String.java:855)
at
org.apache.jasper.runtime.BodyContentImpl.write(BodyContentImpl.java:146)
at
org.apache.jasper.runtime.BodyContentImpl.write(BodyContentImpl.java:159)
at
org.apache.jsp.tag.web.labelAndValue_tag._jspx_meth_c_005fif_005f1(labelAndValue_tag.java:1069)
at
org.apache.jsp.tag.web.labelAndValue_tag._jspx_meth_c_005fif_005f0(labelAndValue_tag.java:1039)
at
org.apache.jsp.tag.web.labelAndValue_tag.doTag(labelAndValue_tag.java:304)
at
org.apache.jsp.WEB_002dINF.pages.admissions.prospects.Prospect.inspect.person_002dtab_jsp._jspx_meth_tags_005flabelAndValue_005f0(person_002dtab_jsp.java:608)
at
org.apache.jsp.WEB_002dINF.pages.admissions.prospects.Prospect.inspect.person_002dtab_jsp._jspService(person_002dtab_jsp.java:199)
at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:98)


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Executor - package dependencies

2008-12-08 Thread Remy Maucherat
On Mon, 2008-12-08 at 09:59 -0700, Filip Hanik - Dev Lists wrote:
> I'll noodle on it a bit, see if i can think of something to defilipize it

Or keep it Filipized, but you'll need to move it in util.

Rémy



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Executor - package dependencies

2008-12-08 Thread Filip Hanik - Dev Lists

Remy Maucherat wrote:

On Mon, 2008-12-08 at 09:59 -0700, Filip Hanik - Dev Lists wrote:
  

I'll noodle on it a bit, see if i can think of something to defilipize it



Or keep it Filipized, but you'll need to move it in util.
  

does anyone have any objections to that in trunk?
this will not be suggested for a backport, since its a refactoring.

Filip

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r724458 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-12-08 Thread fhanik
Author: fhanik
Date: Mon Dec  8 11:42:22 2008
New Revision: 724458

URL: http://svn.apache.org/viewvc?rev=724458&view=rev
Log:
votes

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=724458&r1=724457&r2=724458&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Mon Dec  8 11:42:22 2008
@@ -216,18 +216,18 @@
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=42693
   Fix compilation of recursive tags
   http://svn.apache.org/viewvc?rev=720046&view=rev
-  +1: markt
+  +1: markt, fhanik
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=42077
   Don't include nulls in iterator. Based on a patch by Mathias Broekelmann
   http://svn.apache.org/viewvc?rev=720069&view=rev
-  +1: markt
+  +1: markt, fhanik
   -1: 
 
 * Use consistent (and more useful) JPDA defaults in catalina.bat
   http://svn.apache.org/viewvc?rev=721040&view=rev
-  +1: markt
+  +1: markt, fhanik
   -1: 
 
 * Changes required to run with a security manager
@@ -235,17 +235,17 @@
   http://svn.apache.org/viewvc?rev=721704&view=rev
   http://svn.apache.org/viewvc?rev=721708&view=rev
   http://svn.apache.org/viewvc?rev=721886&view=rev
-  +1: markt
+  +1: markt, fhanik
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=44285
   Make SSL session cache size and timeout configurable
   http://svn.apache.org/viewvc?rev=723404&view=rev
-  +1: markt
+  +1: markt, fhanik
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46232
   Don't override the endorsed dir if the user has set it
   http://svn.apache.org/viewvc?rev=723738&view=rev
-  +1: mart
+  +1: markt, fhanik
   -1: 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Unnecessary entries in Eclipse project

2008-12-08 Thread Kirk True

Hi all,

When I use the included Eclipse project file (from trunk), I get these 
error messages:


   Project 'trunk' is missing required library: 
'output/extras/webservices/jaxrpc.jar'
   Project 'trunk' is missing required library: 
'output/extras/webservices/wsdl4j.jar'


That said, I can remove the CLASSPATH entries from the Eclipse project 
and rebuild and everything works fine. Are these part of an optional 
build, only accessed at runtime, or are they really removable from the 
Eclipse project?


Thanks,
Kirk


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 38726] GlobalRequestProcessor attributes are always 0

2008-12-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=38726


Kirk True <[EMAIL PROTECTED]> changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Comment #8 from Kirk True <[EMAIL PROTECTED]>  2008-12-08 16:56:08 PST ---
I cannot reproduce the bug using versions...

trunk  (pulled and built fresh)
6.0.18 (current 6.x)
5.5.27 (current 5.5.x)

...on Linux (Fedora 8).

If there's anything I'm missing, please let me know.

Thanks.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 38570] if docBase path contains "webapps", a backslash is inserted

2008-12-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=38570


Kirk True <[EMAIL PROTECTED]> changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Unnecessary entries in Eclipse project

2008-12-08 Thread Filip Hanik - Dev Lists

ant -f extras.xml

Filip

Kirk True wrote:

Hi all,

When I use the included Eclipse project file (from trunk), I get these 
error messages:


   Project 'trunk' is missing required library: 
'output/extras/webservices/jaxrpc.jar'
   Project 'trunk' is missing required library: 
'output/extras/webservices/wsdl4j.jar'


That said, I can remove the CLASSPATH entries from the Eclipse project 
and rebuild and everything works fine. Are these part of an optional 
build, only accessed at runtime, or are they really removable from the 
Eclipse project?


Thanks,
Kirk


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Unnecessary entries in Eclipse project

2008-12-08 Thread Kirk True

Hi Filip,

Filip Hanik - Dev Lists wrote:

ant -f extras.xml



Thanks. I do know how to get the libraries, that's not really the 
question ;)


It seems that the core code in the Eclipse project doesn't reference 
those libraries and so it seems they're superfluously included in the 
.project file.


I don't care, and it doesn't bother me, I'm just trying to put the 
pieces together and want to make sure I understand where they all go :)


Thanks,
Kirk


Filip

Kirk True wrote:

Hi all,

When I use the included Eclipse project file (from trunk), I get 
these error messages:


   Project 'trunk' is missing required library: 
'output/extras/webservices/jaxrpc.jar'
   Project 'trunk' is missing required library: 
'output/extras/webservices/wsdl4j.jar'


That said, I can remove the CLASSPATH entries from the Eclipse 
project and rebuild and everything works fine. Are these part of an 
optional build, only accessed at runtime, or are they really 
removable from the Eclipse project?


Thanks,
Kirk


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 39013] Incorrect use of docBase from XML Context file deployment

2008-12-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=39013


Kirk True <[EMAIL PROTECTED]> changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]
 AssignedTo|dev@tomcat.apache.org   |[EMAIL PROTECTED]
 Status|ASSIGNED|NEW




--- Comment #1 from Kirk True <[EMAIL PROTECTED]>  2008-12-08 17:45:35 PST ---
This still appears to exist in the trunk as of today's pull.

I've got a one-liner that appears to fix it that I'll post soon.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]