https://issues.apache.org/bugzilla/show_bug.cgi?id=46284
--- Comment #1 from Filip Hanik <[EMAIL PROTECTED]> 2008-12-08 08:13:30 PST ---
Here is some feedback:
1. The formatting gets somewhat messed up, there are tabs in the patch.
2. public void messageDataReceived(ClusterMessage cmsg) {
+ // Block processing until local application initialization has
+ // completed, if a gate has been erected
+ if(gate != null) {
+ try {
+ gate.await();
+ gate = null;
+ }
+ catch(InterruptedException e) {
+ log.error(e, e);
+ }
+ }
+
This will pose a problem since it blocks the messaging threads. Other
applications running would suffer since you are now holding on to threads that
are supposed to deliver replication messages in other parts of the system.
3. openContainerGates
Does this happen all at once after all the apps are finished. (Am I reading it
correct?).
a container gate should be opened immediately after a context has finished
initialization. regardless of what other applications/containers are doing.
4. the 'gate' variable would have to be volatile, since the thread that is
creating the gate is different from the thread that is reading it, and the non
null gate might not have yet become visible.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
