DO NOT REPLY [Bug 45765] Heap size is growing

2008-09-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45765


Barak <[EMAIL PROTECTED]> changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]
 Status|RESOLVED|REOPENED
 Resolution|INVALID |




--- Comment #2 from Barak <[EMAIL PROTECTED]>  2008-09-12 01:41:15 PST ---
This kind of memory foot print does not exist in standalone java application
running with security manager, and performing the same logic described in the
bug.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 45765] Heap size is growing

2008-09-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45765


Mark Thomas <[EMAIL PROTECTED]> changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||INVALID




--- Comment #3 from Mark Thomas <[EMAIL PROTECTED]>  2008-09-12 01:59:39 PST ---
This remains no information in this report that demonstrates that Tomcat is the
root cause of the leak. Neither is there sufficient information for someone to
try and reproduce it.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



why not use id field in the table of JDBCRealm

2008-09-12 Thread Shanbo Li
Hi there,

i am thinking of it is a good design of JDBCRealm implementation.

the table in HOW-TO looks like this:


--

 create table users (
  user_name varchar(15) not null primary key,
  user_pass varchar(15) not null
);

create table user_roles (
  user_name varchar(15) not null,
  role_name varchar(15) not null,
  primary key (user_name, role_name)
);

--




obviously *it missed the id field*. it would be much better that each table
have an id field. and make the table looks like this:


- 
-- Table structure for users
-- 
DROP TABLE IF EXISTS `users`;
CREATE TABLE `users` (
  `id` int(11) NOT NULL auto_increment,
  `username` varchar(225) NOT NULL,
  `password` varchar(225) NOT NULL,
  PRIMARY KEY  (`id`),
  UNIQUE KEY `unique_username` (`username`)
) ENGINE=InnoDB AUTO_INCREMENT=10 DEFAULT CHARSET=utf8;

-- 
-- Table structure for roles
-- 
DROP TABLE IF EXISTS `roles`;
CREATE TABLE `roles` (
  `id` int(11) NOT NULL auto_increment,
  `role` varchar(255) NOT NULL,
  `description` text,
  PRIMARY KEY  (`id`),
  UNIQUE KEY `unique_role` (`role`)
) ENGINE=InnoDB AUTO_INCREMENT=3 DEFAULT CHARSET=utf8;

-- 
-- Table structure for users_roles
-- 
DROP TABLE IF EXISTS `users_roles`;
CREATE TABLE `users_roles` (
  `id` int(11) NOT NULL auto_increment,
  `user_id` int(11) NOT NULL,
  `role_id` int(11) NOT NULL,
  PRIMARY KEY  (`id`),
  UNIQUE KEY `unique_user_id_and_role_id` (`user_id`,`role_id`),
  KEY `fk_roles_by_role_id` (`role_id`),
  CONSTRAINT `fk_roles_by_role_id` FOREIGN KEY (`role_id`) REFERENCES
`roles` (`id`) ON DELETE CASCADE ON UPDATE CASCADE,
  CONSTRAINT `fk_users_by_user_id` FOREIGN KEY (`user_id`) REFERENCES
`users` (`id`) ON DELETE CASCADE ON UPDATE CASCADE
) ENGINE=InnoDB DEFAULT CHARSET=utf8;





i mean the bridge-table use id to associate users and roles


-- 
Shanbo Li

Master student
Software Engineering of Distributed Systems, KTH


Re: why not use id field in the table of JDBCRealm

2008-09-12 Thread Mark Thomas
Shanbo Li wrote:
>
> obviously *it missed the id field*. it would be much better that each table
> have an id field. and make the table looks like this:

Obviously *this was done for a good reason*. The how to is intended for any
database. The changes you propose are non-standard and hence will not work
in many databases.

Users are free to organise their data in any way they wish. The only
constraint is how that data is presented to the JDBC realm. Many databases
support the concept of views which can be used for this purpose.

Mark



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [VOTE] Release tc-native 1.1.15

2008-09-12 Thread Jim Jagielski

Hopefully not too late:

On Sep 8, 2008, at 8:11 AM, jean-frederic clere wrote:


The candidates binaries are available here:
http://people.apache.org/~jfclere/tcnative/v1.1.15/

According to the release process, the 1.1.15 tag is:
[ ] Broken
[ ] Alpha
[ ] Beta
[X] Stable


Cheers

Jean-Frederic

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [VOTE] Release tc-native 1.1.15

2008-09-12 Thread Henri Gomez
The good news is the binaries will be available from ASF site.



2008/9/12 Jim Jagielski <[EMAIL PROTECTED]>

> Hopefully not too late:
>
> On Sep 8, 2008, at 8:11 AM, jean-frederic clere wrote:
>
>  The candidates binaries are available here:
>> http://people.apache.org/~jfclere/tcnative/v1.1.15/
>>
>> According to the release process, the 1.1.15 tag is:
>> [ ] Broken
>> [ ] Alpha
>> [ ] Beta
>> [X] Stable
>>
>>
>> Cheers
>>
>> Jean-Frederic
>>
>> -
>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>> For additional commands, e-mail: [EMAIL PROTECTED]
>>
>>
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>


RE: JNDIRealm

2008-09-12 Thread william.beene
Hi Tomcat Developers,
  I have updated the patch from http://markmail.org/message/qrmrubh3gfrz5yo5 to
  match up with the current source release for tomcat 6.0.18. I am interested 
  in getting this patch applied to the code base. So, I am curious if anything
  else needs to be done?

Thanks,

William Beene
Accenture
Associate Consultant, TACF
407 S Pennsylvania, Suite 201
Joplin, MO 64804
417-626-6528
[EMAIL PROTECTED]





This message is for the designated recipient only and may contain privileged, 
proprietary, or otherwise private information.  If you have received it in 
error, please notify the sender immediately and delete the original.  Any other 
use of the email by you is prohibited.
--- JNDIRealm.java.old	2008-09-12 11:42:10.0 -0500
+++ JNDIRealm.java	2008-09-12 10:43:04.0 -0500
@@ -913,7 +913,7 @@
  curUserPattern < userPatternFormatArray.length;
  curUserPattern++) {
 // Retrieve user information
-User user = getUser(context, username);
+User user = getUser(context, username, credentials);
 if (user != null) {
 try {
 // Check the user's credentials
@@ -938,7 +938,7 @@
 return null;
 } else {
 // Retrieve user information
-User user = getUser(context, username);
+User user = getUser(context, username, credentials);
 if (user == null)
 return (null);
 
@@ -971,7 +971,7 @@
  *
  * @exception NamingException if a directory server error occurs
  */
-protected User getUser(DirContext context, String username)
+protected User getUser(DirContext context, String username, String credentials)
 throws NamingException {
 
 User user = null;
@@ -987,7 +987,7 @@
 
 // Use pattern or search for user entry
 if (userPatternFormatArray != null) {
-user = getUserByPattern(context, username, attrIds);
+user = getUserByPattern(context, username, credentials, attrIds);
 } else {
 user = getUserBySearch(context, username, attrIds);
 }
@@ -1011,6 +1011,7 @@
  */
 protected User getUserByPattern(DirContext context,
   String username,
+  String credentials,
   String[] attrIds)
 throws NamingException {
 
@@ -1026,6 +1027,32 @@
 attrs = context.getAttributes(dn, attrIds);
 } catch (NameNotFoundException e) {
 return (null);
+} catch (NamingException e) {
+// If the getAttributes() call fails, try it again with the
+// credentials of the user that we're searching for
+try {
+// Set up security environment to bind as the user
+context.addToEnvironment(Context.SECURITY_PRINCIPAL, dn);
+context.addToEnvironment(Context.SECURITY_CREDENTIALS, credentials);
+
+attrs = context.getAttributes(dn, attrIds);
+} finally {
+// Restore the original security environment
+if (connectionName != null) {
+context.addToEnvironment(Context.SECURITY_PRINCIPAL,
+ connectionName);
+} else {
+context.removeFromEnvironment(Context.SECURITY_PRINCIPAL);
+}
+
+if (connectionPassword != null) {
+context.addToEnvironment(Context.SECURITY_CREDENTIALS,
+ connectionPassword);
+}
+else {
+context.removeFromEnvironment(Context.SECURITY_CREDENTIALS);
+}
+}
 }
 if (attrs == null)
 return (null);
@@ -1598,7 +1625,7 @@
   String username)
 throws NamingException {
 
-User user = getUser(context, username);
+User user = getUser(context, username, null);
 
 return new GenericPrincipal(this, user.username, user.password ,
 getRoles(context, user));
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: JNDIRealm

2008-09-12 Thread Mark Thomas
[EMAIL PROTECTED] wrote:
> Hi Tomcat Developers,
>   I have updated the patch from http://markmail.org/message/qrmrubh3gfrz5yo5 
> to
>   match up with the current source release for tomcat 6.0.18. I am interested 
>   in getting this patch applied to the code base. So, I am curious if anything
>   else needs to be done?

As with any patch, open a bugzilla item and attach it there. Patches
attached to mailing list messages tend to get lost.

Mark



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 45794] New: Patch causes JNDIRealm to bind with user entered credentials

2008-09-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45794

   Summary: Patch causes JNDIRealm to bind with user entered
credentials
   Product: Tomcat 6
   Version: 6.0.18
  Platform: PC
OS/Version: Linux
Status: NEW
  Severity: enhancement
  Priority: P2
 Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


This patch causes the JNDIRealm to bind with the credentials passed in by the
user if user lookup fails when bound anonymously.

I have updated the patch from http://markmail.org/message/qrmrubh3gfrz5yo5 to
match up with the current source release for tomcat 6.0.18.

My environment:
Java: 1.5.0_16
OS: Debian Testing (2.6.26)
Tomcat: 6.0.18

Thanks,
William Beene


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r694791 - /tomcat/trunk/webapps/examples/jsp/jsp2/el/basic-comparisons.jsp

2008-09-12 Thread markt
Author: markt
Date: Fri Sep 12 13:02:45 2008
New Revision: 694791

URL: http://svn.apache.org/viewvc?rev=694791&view=rev
Log:
Fix copy and paste error

Modified:
tomcat/trunk/webapps/examples/jsp/jsp2/el/basic-comparisons.jsp

Modified: tomcat/trunk/webapps/examples/jsp/jsp2/el/basic-comparisons.jsp
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/examples/jsp/jsp2/el/basic-comparisons.jsp?rev=694791&r1=694790&r2=694791&view=diff
==
--- tomcat/trunk/webapps/examples/jsp/jsp2/el/basic-comparisons.jsp (original)
+++ tomcat/trunk/webapps/examples/jsp/jsp2/el/basic-comparisons.jsp Fri Sep 12 
13:02:45 2008
@@ -52,8 +52,8 @@
${1 > (4/2)}
  
  
-   \${1 > (4/2)}
-   ${1 > (4/2)}
+   \${1 gt (4/2)}
+   ${1 gt (4/2)}
  
  
\${4.0 >= 3}



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 45796] New: 505 Errors are not logged in the access log

2008-09-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45796

   Summary: 505 Errors are not logged in the access log
   Product: Tomcat 5
   Version: 5.5.23
  Platform: PC
OS/Version: Windows Server 2003
Status: NEW
  Severity: normal
  Priority: P2
 Component: Connector:Coyote
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Easy to verify via

% telnet host 8080
GET / foo bar HTTP/1.1
Host: host

Then
curl http://host:8080/

then look in access log.

I realize its debatable whether or not 505s should be logged, but I am trying
to debug a 505 right now and it should would be helpful.  At the very least, a
config option that enabled logging of 505s would be nice.  Fwiw, Apache HTTPd
2.0 logs 505s.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 45797] New: Oi

2008-09-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45797

   Summary: Oi
   Product: Tomcat 6
   Version: 6.0.18
  Platform: PC
OS/Version: Windows Vista
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Oi


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]