DO NOT REPLY [Bug 44166] New: - Axis2-1.2 could not be undeployed

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=44166

   Summary: Axis2-1.2 could not be undeployed
   Product: Tomcat 6
   Version: 6.0.13
  Platform: PC
OS/Version: Windows XP
Status: NEW
  Severity: normal
  Priority: P2
 Component: Manager application
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Hi,

On Windows, Axis2 could not be undeployed successfully when Tomcat is started.
All files and directories are deleted expect jars in the WEB-INF/lib directory
which seems to be in use by Tomcat even if not request are supplied to the Axis
engine.

Consequently, Axis is always listed in the application list even if the
application is unavailable.

Thanks

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43538] - [patch] Show the hostname and IP address in the manager webapp

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43538


[EMAIL PROTECTED] changed:

   What|Removed |Added

Version|5.5.24  |5.5.25




--- Additional Comments From [EMAIL PROTECTED]  2008-01-04 03:49 ---
Set the correct "Version".

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r608842 - /tomcat/connectors/trunk/jni/native/build/tcnative.m4

[rjung]

Author: rjung
Date: Fri Jan  4 05:57:44 2008
New Revision: 608842

URL: http://svn.apache.org/viewvc?rev=608842&view=rev
Log:
Correct syntax of linker flag for gcc.

Modified:
tomcat/connectors/trunk/jni/native/build/tcnative.m4

Modified: tomcat/connectors/trunk/jni/native/build/tcnative.m4
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jni/native/build/tcnative.m4?rev=608842&r1=608841&r2=608842&view=diff
==
--- tomcat/connectors/trunk/jni/native/build/tcnative.m4 (original)
+++ tomcat/connectors/trunk/jni/native/build/tcnative.m4 Fri Jan  4 05:57:44 
2008
@@ -336,7 +336,7 @@
 TCN_OPENSSL_LIBS="-L$use_openssl/lib -Wl,+b: -lssl -lcrypto"
 ;;
 *linux*)
-TCN_OPENSSL_LIBS="-L$use_openssl/lib 
--Wl,-rpath,$use_openssl/lib -lssl -lcrypto"
+TCN_OPENSSL_LIBS="-L$use_openssl/lib 
-Wl,-rpath,$use_openssl/lib -lssl -lcrypto"
 ;;
 *)
 TCN_OPENSSL_LIBS="-L$use_openssl/lib -lssl -lcrypto"



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r608831 - /tomcat/connectors/trunk/jni/native/build/tcnative.m4

[rjung]

Author: rjung
Date: Fri Jan  4 05:29:15 2008
New Revision: 608831

URL: http://svn.apache.org/viewvc?rev=608831&view=rev
Log:
Space as separation character in IFS is not sufficient.
Simply save and restore the previous IFS.

Modified:
tomcat/connectors/trunk/jni/native/build/tcnative.m4

Modified: tomcat/connectors/trunk/jni/native/build/tcnative.m4
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jni/native/build/tcnative.m4?rev=608831&r1=608830&r2=608831&view=diff
==
--- tomcat/connectors/trunk/jni/native/build/tcnative.m4 (original)
+++ tomcat/connectors/trunk/jni/native/build/tcnative.m4 Fri Jan  4 05:29:15 
2008
@@ -31,7 +31,7 @@
 AC_MSG_ERROR(APR config could not be located. Please use the --with-apr 
option.)
   fi
   sapr_version="`echo $sapr_pversion|sed -e 's/\([a-z]*\)$/.\1/'`"
-  IFS=.; set $sapr_version; IFS=' '
+  tc_save_IFS=$IFS; IFS=.; set $sapr_version; IFS=$tc_save_IFS
   if test "${1}" -lt "1"; then
 AC_MSG_ERROR(You need APR version 1.2.1 or newer installed.)
   else



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 44170] New: - maxSpareThreads inoperative in http connector (under JBOSS 4.0.5?)

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=44170

   Summary: maxSpareThreads inoperative in http connector (under
JBOSS 4.0.5?)
   Product: Tomcat 5
   Version: 5.5.20
  Platform: Other
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: P2
 Component: Connector:HTTP
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Running Tomcat in a JBOSS container.
I am having a problem where threads aren't being destroyed when there are too 
many idle threads:

  
  

$ for host in `seq -w 1 30`; do echo $host; wget -qO - 
http://exobxw$host/administration/queryjmx.jsp | grep currentThread; done
(trimmed output where the values were within expected limits)
09
jboss.web:name=http-0.0.0.0-8080,type=ThreadPool: currentThreadCount: 153
jboss.web:name=http-0.0.0.0-8080,type=ThreadPool: currentThreadsBusy: 18
11
jboss.web:name=http-0.0.0.0-8080,type=ThreadPool: currentThreadCount: 315
jboss.web:name=http-0.0.0.0-8080,type=ThreadPool: currentThreadsBusy: 27
22
jboss.web:name=http-0.0.0.0-8080,type=ThreadPool: currentThreadCount: 220
jboss.web:name=http-0.0.0.0-8080,type=ThreadPool: currentThreadsBusy: 18
23
jboss.web:name=http-0.0.0.0-8080,type=ThreadPool: currentThreadCount: 185
jboss.web:name=http-0.0.0.0-8080,type=ThreadPool: currentThreadsBusy: 18
24
jboss.web:name=http-0.0.0.0-8080,type=ThreadPool: currentThreadCount: 141
jboss.web:name=http-0.0.0.0-8080,type=ThreadPool: currentThreadsBusy: 14
25
jboss.web:name=http-0.0.0.0-8080,type=ThreadPool: currentThreadCount: 188
jboss.web:name=http-0.0.0.0-8080,type=ThreadPool: currentThreadsBusy: 18
27
jboss.web:name=http-0.0.0.0-8080,type=ThreadPool: currentThreadCount: 127
jboss.web:name=http-0.0.0.0-8080,type=ThreadPool: currentThreadsBusy: 21
28
jboss.web:name=http-0.0.0.0-8080,type=ThreadPool: currentThreadCount: 247
jboss.web:name=http-0.0.0.0-8080,type=ThreadPool: currentThreadsBusy: 15
29
jboss.web:name=http-0.0.0.0-8080,type=ThreadPool: currentThreadCount: 202
jboss.web:name=http-0.0.0.0-8080,type=ThreadPool: currentThreadsBusy: 18
30
jboss.web:name=http-0.0.0.0-8080,type=ThreadPool: currentThreadCount: 242
jboss.web:name=http-0.0.0.0-8080,type=ThreadPool: currentThreadsBusy: 16

There's a bug raised in the JBOSS JIRA which has been marked as a "will not 
fix" because Tomcat is 
using the wrong thread pool:

http://jira.jboss.org/jira/browse/JBAS-4412

Remy Maucherat [27/Nov/07 11:31 AM]
The thread pool used in that Tomcat version does not have the capability to 
scale back the amount of 
threads used.

This used to work in an older version, I believe.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r608919 - /tomcat/tc6.0.x/trunk/STATUS.txt

[fhanik]

Author: fhanik
Date: Fri Jan  4 08:55:20 2008
New Revision: 608919

URL: http://svn.apache.org/viewvc?rev=608919&view=rev
Log:
votes

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=608919&r1=608918&r2=608919&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Fri Jan  4 08:55:20 2008
@@ -51,7 +51,7 @@
 * Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=43840
   Include user principal if possible when serializing / de-serializing
   http://people.apache.org/~markt/dev/bug43840.txt
-  +1: markt
+  +1: markt, fhanik
   -1:
 
 * Improve Jasper docs. Note rather than remove unused option, it will be



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r608666 - /tomcat/tc6.0.x/trunk/STATUS.txt

[Filip Hanik - Dev Lists]

:)
what I meant was, it still contains non functional changes, such as 
reordering of imports, breaking up code lines etc.
If I read the patch correctly, the only functional changes are really 
only during readPrincipal and writePrincipal, yet so many other lines 
are changed.


does that make sense, ie, the patch is fine, and works, and will get my 
+1, but it will make it hard for anyone else trying to review whether to 
functionality is compatible, still has to review 70% of lines that do 
nothing


Filip


[EMAIL PROTECTED] wrote:

Author: markt
Date: Thu Jan  3 14:54:47 2008
New Revision: 608666

URL: http://svn.apache.org/viewvc?rev=608666&view=rev
Log:
Address Filip's concerns with a new patch.

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=608666&r1=608665&r2=608666&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Jan  3 14:54:47 2008
@@ -50,10 +50,9 @@
 
 * Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=43840

   Include user principal if possible when serializing / de-serializing
-  http://svn.apache.org/viewvc?rev=607596&view=rev
-  http://svn.apache.org/viewvc?rev=607597&view=rev
-  +1: markt, funkman
-  -1: fhanik - lets not do e.printStackTrace, handle the error and log it 
correctly, also, have the diff only change lines that are actually changed. 
makes it easier to review
+  http://people.apache.org/~markt/dev/bug43840.txt
+  +1: markt
+  -1:
 
 * Improve Jasper docs. Note rather than remove unused option, it will be

   deprecated in 6.0.x.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



  



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

new year, new version? 6.0.16

[Filip Hanik - Dev Lists]

we have a lot of updates added in, I think it may be good to set a date 
for our next release and work towards that


Filip

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r608944 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/connector/Request.java

[fhanik]

Author: fhanik
Date: Fri Jan  4 09:59:38 2008
New Revision: 608944

URL: http://svn.apache.org/viewvc?rev=608944&view=rev
Log:
fix parameter processing logic

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/Request.java

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=608944&r1=608943&r2=608944&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Fri Jan  4 09:59:38 2008
@@ -31,11 +31,6 @@
   +1: jfclere
   -1: fhanik - Can we add the 'package' directive to make the package match 
the dir structure
 
-* Smallest fix to the above patches.
-  http://people.apache.org/~jfclere/patches/Request.patch  
-  +1: jfclere, fhanik, markt, yoavs, jim
-  -1:
-
 * Fix CVE-2007-5342
   JULI permissions need to be restricted
   http://svn.apache.org/viewvc?rev=606594&view=rev

Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/Request.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/Request.java?rev=608944&r1=608943&r2=608944&view=diff
==
--- tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/Request.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/Request.java Fri 
Jan  4 09:59:38 2008
@@ -2486,6 +2486,7 @@
 context.getLogger().debug(
 sm.getString("coyoteRequest.parseParameters"), e);
 }
+return;
 }
 parameters.processParameters(formData, 0, len);
 }



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: new year, new version? 6.0.16

[Yoav Shapira]

On Jan 4, 2008 1:34 PM, Mark Thomas <[EMAIL PROTECTED]> wrote:
> Filip Hanik - Dev Lists wrote:
> > we have a lot of updates added in, I think it may be good to set a date
> > for our next release and work towards that
>
> +1.
>
> There are a stack of changes (both committed and proposed) for 5.5.x as
> well. It would be good to plan a 5.5.x release as well.
>
> I'll also do a 4.1.x release and wrap up the few remaining patches for that.

+1

Yoav

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 44166] - Axis2-1.2 could not be undeployed

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=44166


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID




--- Additional Comments From [EMAIL PROTECTED]  2008-01-04 10:36 ---
This sounds like a known 'feature' of windows. You have two options:
- use linux
- use the anti-jar/resource locking options.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r608329 - /tomcat/tc6.0.x/trunk/STATUS.txt

[Mark Thomas]

Filip Hanik - Dev Lists wrote:
> Mark Thomas wrote:
>> [EMAIL PROTECTED] wrote:
>>  
>>> +  -1: fhanik - lets not do e.printStackTrace, handle the error and
>>> log it correctly,
>>> 
>>
>> Fair point. I'll fix that.
>>
>> also, have the diff only change lines that are actually changed. makes it
>> easier to review
>>
>> Which lines do you mean? The diff looks normal to me.
>>   
> pretty much all the lines before
> "public class SerializablePrincipal" are non functional changes, but
> cosmetic.

Got it. I didn't realise you meant "not cosmetic changes" when you wrote
"actually changed"

Mark


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: new year, new version? 6.0.16

[Mark Thomas]

Filip Hanik - Dev Lists wrote:
> we have a lot of updates added in, I think it may be good to set a date
> for our next release and work towards that

+1.

There are a stack of changes (both committed and proposed) for 5.5.x as
well. It would be good to plan a 5.5.x release as well.

I'll also do a 4.1.x release and wrap up the few remaining patches for that.

Mark

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Tagging 5.5.26

[Filip Hanik - Dev Lists]

Hey all,
I'm planning on tagging 5.5.26 on Monday Jan 21st, roughly around noon MST.
This should give us plenty of time to clear out status and test 
everything before doing the release.


I'll assume lazy consensus unless anyone objects to the release or we 
find show stoppers


Filip

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r608974 - /tomcat/current/tc5.5.x/STATUS.txt

[rjung]

Author: rjung
Date: Fri Jan  4 11:56:54 2008
New Revision: 608974

URL: http://svn.apache.org/viewvc?rev=608974&view=rev
Log:
Backport voting.

Modified:
tomcat/current/tc5.5.x/STATUS.txt

Modified: tomcat/current/tc5.5.x/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=608974&r1=608973&r2=608974&view=diff
==
--- tomcat/current/tc5.5.x/STATUS.txt (original)
+++ tomcat/current/tc5.5.x/STATUS.txt Fri Jan  4 11:56:54 2008
@@ -39,17 +39,17 @@
 * JDT location return 404
   http://people.apache.org/~fhanik/patches/jdt-loc.patch
   Backport from Tomcat 6
-  +1: pero, markt
+  +1: pero, markt, rjung
   -1: 
  
 * Fix NPE situation
   
http://people.apache.org/~pero/patches/tc55/2007-11-16-AccessLogValve-tc55.patch
-  +1: pero, markt
+  +1: pero, markt, rjung
   -1:
 
 * Fix wrong && (Also needed at tomcat 6)
   
http://people.apache.org/~pero/patches/tc55/2007-11-16-1-ReplicationValve-tc55.patch
-  +1: pero, markt
+  +1: pero, markt, rjung
   -1:
 
 * Fix  FarmWarDeployer can be only config at Host Element (Also needed at 
tomcat 6)
@@ -95,7 +95,7 @@
 * Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=43957
   Service.bat doesn't configure logging correctly
   http://svn.apache.org/viewvc?rev=598800&view=rev
-  +1: markt, pero
+  +1: markt, pero, rjung
   -1: 
 
 * Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=43757
@@ -127,18 +127,19 @@
 * Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=43594
   Use CATALINA_BASE (if set) for setenv
   http://svn.apache.org/viewvc?rev=600185&view=rev
-  +1: markt, pero
+  +1: markt, pero, rjung
   -1:
 
 * Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=44041
   http://svn.apache.org/viewvc?rev=603340&view=rev
-  +1: markt, pero
+  +1: markt, pero, rjung
   -1:
+  rjung: 603340 needs 603074 to.
 
 * Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=44094
   Add note about side-effects of setting privileged on a context
   http://svn.apache.org/viewvc?rev=605339&view=rev
-  +1: markt, pero
+  +1: markt, pero, rjung
   -1: 
 
 * Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=43241



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: new year, new version? 6.0.16

[Rainer Jung]

Mark Thomas schrieb:
> Filip Hanik - Dev Lists wrote:
>> we have a lot of updates added in, I think it may be good to set a date
>> for our next release and work towards that
> 
> +1.
> 
> There are a stack of changes (both committed and proposed) for 5.5.x as
> well. It would be good to plan a 5.5.x release as well.
> 
> I'll also do a 4.1.x release and wrap up the few remaining patches for that.
> 
> Mark

+1

We need a some more votes for the long patch list in 5.5 STATUS.txt.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: new year, new version? 6.0.16

[Henri Gomez]

+1

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r609009 - /tomcat/trunk/webapps/docs/jasper-howto.xml

[markt]

Author: markt
Date: Fri Jan  4 13:13:58 2008
New Revision: 609009

URL: http://svn.apache.org/viewvc?rev=609009&view=rev
Log:
Fix path

Modified:
tomcat/trunk/webapps/docs/jasper-howto.xml

Modified: tomcat/trunk/webapps/docs/jasper-howto.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/jasper-howto.xml?rev=609009&r1=609008&r2=609009&view=diff
==
--- tomcat/trunk/webapps/docs/jasper-howto.xml (original)
+++ tomcat/trunk/webapps/docs/jasper-howto.xml Fri Jan  4 13:13:58 2008
@@ -261,7 +261,7 @@
   
 
 
-
+
   
 
  



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r609019 - /tomcat/trunk/java/org/apache/jasper/compiler/Parser.java

[markt]

Author: markt
Date: Fri Jan  4 13:47:28 2008
New Revision: 609019

URL: http://svn.apache.org/viewvc?rev=609019&view=rev
Log:
No functional change. Remove unused code. Lines <= 80 chars

Modified:
tomcat/trunk/java/org/apache/jasper/compiler/Parser.java

Modified: tomcat/trunk/java/org/apache/jasper/compiler/Parser.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/compiler/Parser.java?rev=609019&r1=609018&r2=609019&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/compiler/Parser.java (original)
+++ tomcat/trunk/java/org/apache/jasper/compiler/Parser.java Fri Jan  4 
13:47:28 2008
@@ -51,8 +51,6 @@
 
 private JspReader reader;
 
-private String currentFile;
-
 private Mark start;
 
 private ErrorDispatcher err;
@@ -69,11 +67,14 @@
 
 // Virtual body content types, to make parsing a little easier.
 // These are not accessible from outside the parser.
-private static final String JAVAX_BODY_CONTENT_PARAM = 
"JAVAX_BODY_CONTENT_PARAM";
+private static final String JAVAX_BODY_CONTENT_PARAM =
+"JAVAX_BODY_CONTENT_PARAM";
 
-private static final String JAVAX_BODY_CONTENT_PLUGIN = 
"JAVAX_BODY_CONTENT_PLUGIN";
+private static final String JAVAX_BODY_CONTENT_PLUGIN =
+"JAVAX_BODY_CONTENT_PLUGIN";
 
-private static final String JAVAX_BODY_CONTENT_TEMPLATE_TEXT = 
"JAVAX_BODY_CONTENT_TEMPLATE_TEXT";
+private static final String JAVAX_BODY_CONTENT_TEMPLATE_TEXT =
+"JAVAX_BODY_CONTENT_TEMPLATE_TEXT";
 
 /**
  * The constructor
@@ -85,7 +86,6 @@
 this.pageInfo = pc.getCompiler().getPageInfo();
 this.err = pc.getCompiler().getErrorDispatcher();
 this.reader = reader;
-this.currentFile = reader.mark().getFile();
 this.scriptlessCount = 0;
 this.isTagFile = isTagFile;
 this.directivesOnly = directivesOnly;
@@ -108,7 +108,8 @@
 public static Node.Nodes parse(ParserController pc, JspReader reader,
 Node parent, boolean isTagFile, boolean directivesOnly,
 URL jarFileUrl, String pageEnc, String jspConfigPageEnc,
-boolean isDefaultPageEncoding, boolean isBomPresent) throws 
JasperException {
+boolean isDefaultPageEncoding, boolean isBomPresent)
+throws JasperException {
 
 Parser parser = new Parser(pc, reader, isTagFile, directivesOnly,
 jarFileUrl);
@@ -169,7 +170,8 @@
  * around Eq. It is added to be backward compatible with Tomcat, and with
  * other xml parsers.
  */
-private boolean parseAttribute(AttributesImpl attrs) throws 
JasperException {
+private boolean parseAttribute(AttributesImpl attrs)
+throws JasperException {
 
 // Get the qualified name
 String qName = parseName();
@@ -417,8 +419,8 @@
 }
 if (impl == null) {
 String[] location = ctxt.getTldLocation(uri);
-impl = new TagLibraryInfoImpl(ctxt, parserController, 
pageInfo,
-prefix, uri, location, err);
+impl = new TagLibraryInfoImpl(ctxt, parserController,
+pageInfo, prefix, uri, location, err);
 if (ctxt.getOptions().isCaching()) {
 ctxt.getOptions().getCache().put(uri, impl);
 }
@@ -433,7 +435,8 @@
 if (pageInfo.getTaglib(urnTagdir) == null) {
 pageInfo.addTaglib(urnTagdir,
 new ImplicitTagLibraryInfo(ctxt,
-parserController, pageInfo, prefix, 
tagdir, err));
+parserController, pageInfo, prefix,
+tagdir, err));
 }
 pageInfo.addPrefixMapping(prefix, urnTagdir);
 }
@@ -599,8 +602,8 @@
 }
 
 /*
- * Parses a variable directive with the following syntax: PageDirective 
::= (
- * S Attribute)*
+ * Parses a variable directive with the following syntax:
+ * PageDirective ::= ( S Attribute)*
  */
 private void parseVariableDirective(Node parent) throws JasperException {
 Attributes attrs = parseAttributes();
@@ -738,7 +741,8 @@
  * ELExpressionBody (following "${" to first unquoted "}") // XXX add 
formal
  * production and confirm implementation against it, // once it's decided
  */
-private void parseELExpression(Node parent, char type) throws 
JasperException {
+private void parseELExpression(Node parent, char type)
+throws JasperException {
 start = reader.mark();
 Mark last = null;
 boolean singleQuoted = false, doubleQuoted = false;

DO NOT REPLY [Bug 44170] - maxSpareThreads inoperative in http connector (under JBOSS 4.0.5?)

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=44170


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WORKSFORME




--- Additional Comments From [EMAIL PROTECTED]  2008-01-04 13:32 ---
This works as expected in Tomcat 5.5.25. I am not aware of this not working in a
previous Tomcat version. This looks like a JBoss issue to me.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r609012 - /tomcat/current/tc5.5.x/STATUS.txt

[markt]

Author: markt
Date: Fri Jan  4 13:17:06 2008
New Revision: 609012

URL: http://svn.apache.org/viewvc?rev=609012&view=rev
Log:
Add NPE correction to fix for 43839 and re-propose patch

Modified:
tomcat/current/tc5.5.x/STATUS.txt

Modified: tomcat/current/tc5.5.x/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=609012&r1=609011&r2=609012&view=diff
==
--- tomcat/current/tc5.5.x/STATUS.txt (original)
+++ tomcat/current/tc5.5.x/STATUS.txt Fri Jan  4 13:17:06 2008
@@ -166,15 +166,16 @@
   +1: markt, pero
   -1: 
 
-* Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=43839
-  URL based session tracking fails when session cookie from parent context is
-  present. Based on a patch by Yuan Qingyun.
-  http://svn.apache.org/viewvc?rev=606944&view=rev
-  +1: markt, pero
-  -1: 
-
 * Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=43914
   Location headers must be encoded. Patch provided by Ivan Todoroski.
   http://svn.apache.org/viewvc?rev=606952&view=rev
   +1: markt, pero
+  -1: 
+
+* Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=43839
+  URL based session tracking fails when session cookie from parent context is
+  present. Based on a patch by Yuan Qingyun.
+  http://svn.apache.org/viewvc?rev=606944&view=rev
+  http://svn.apache.org/viewvc?rev=609003&view=rev
+  +1: markt
   -1: 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r609003 - /tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java

[markt]

Author: markt
Date: Fri Jan  4 12:59:59 2008
New Revision: 609003

URL: http://svn.apache.org/viewvc?rev=609003&view=rev
Log:
Fix possible NPE when no ROOT application is deployed in fix for bug 43839.

Modified:
tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java

Modified: tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java?rev=609003&r1=609002&r2=609003&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java Fri Jan  
4 12:59:59 2008
@@ -551,7 +551,8 @@
 // context, don't go looking for a session ID in a cookie as a cookie
 // from a parent context with a session ID may be present which would
 // overwrite the valid session ID encoded in the URL
-if (!((Context)request.getMappingData().context).getCookies())
+Context context = (Context) request.getMappingData().context;
+if (context != null && !context.getCookies())
 return;
 
 // Parse session id from cookies



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r609010 - /tomcat/tc6.0.x/trunk/STATUS.txt

[markt]

Author: markt
Date: Fri Jan  4 13:14:57 2008
New Revision: 609010

URL: http://svn.apache.org/viewvc?rev=609010&view=rev
Log:
Propose improvement to fix for 43839

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=609010&r1=609009&r2=609010&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Fri Jan  4 13:14:57 2008
@@ -72,3 +72,9 @@
   http://svn.apache.org/viewvc?rev=607903&view=rev
   +1: markt
   -1: 
+
+  Fix possible NPE in previous fix for
+  http://issues.apache.org/bugzilla/show_bug.cgi?id=43839
+  http://svn.apache.org/viewvc?rev=609003&view=rev
+  +1: markt
+  -1: 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43839] - I think the implement is difference with the document in function CoyoteAdapter.postParseRequest

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43839





--- Additional Comments From [EMAIL PROTECTED]  2008-01-04 13:17 ---
The NPE only occurs if the ROOT web app is not present. I have fixed the coed in
svn and proposed the improved fix for 6.0.x and 5.5.x

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r609026 - /tomcat/connectors/trunk/jni/CHANGELOG.txt

[rjung]

Author: rjung
Date: Fri Jan  4 14:01:53 2008
New Revision: 609026

URL: http://svn.apache.org/viewvc?rev=609026&view=rev
Log:
Add my small fixes to tcnative changelog.
I don't really understand the format though...

Modified:
tomcat/connectors/trunk/jni/CHANGELOG.txt

Modified: tomcat/connectors/trunk/jni/CHANGELOG.txt
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jni/CHANGELOG.txt?rev=609026&r1=609025&r2=609026&view=diff
==
--- tomcat/connectors/trunk/jni/CHANGELOG.txt (original)
+++ tomcat/connectors/trunk/jni/CHANGELOG.txt Fri Jan  4 14:01:53 2008
@@ -1,3 +1,6 @@
+Fix: IFS problem in native/build/tcnative.m4 (rjung)
+Fix: Wrong gcc link flag in native/build/tcnative.m4 (rjung)
+Tag: 1_1.12
 Improvement: Add support of J9VM based JVM. (jfclere)
 Improvement: Arrange licence in source files. (markt).
 Improvement: Add two new 'immediate' methods for sending the data.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r609028 - /tomcat/current/tc5.5.x/STATUS.txt

[fhanik]

Author: fhanik
Date: Fri Jan  4 14:06:57 2008
New Revision: 609028

URL: http://svn.apache.org/viewvc?rev=609028&view=rev
Log:
review and cast votes

Modified:
tomcat/current/tc5.5.x/STATUS.txt

Modified: tomcat/current/tc5.5.x/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=609028&r1=609027&r2=609028&view=diff
==
--- tomcat/current/tc5.5.x/STATUS.txt (original)
+++ tomcat/current/tc5.5.x/STATUS.txt Fri Jan  4 14:06:57 2008
@@ -28,12 +28,12 @@
 * Improve fix for webdav vulnerability to workaround what looks like a parser
   bug
   http://people.apache.org/~markt/patches/2007-10-20-webdav.patch
-  +1: markt, pero
+  +1: markt, pero, fhanik
   -1:
 
 * Fix bug in CGI servlet that causes it to fail when included
   http://svn.apache.org/viewvc?view=rev&revision=595802
-  +1: markt
+  +1: markt, fhanik
   -1:
 
 * JDT location return 404
@@ -56,11 +56,12 @@
   
http://people.apache.org/~pero/patches/tc55/2007-11-16-1-FarmWarDeployer-tc55.patch
   +1: pero
   -1:
+   0: fhanik, this needs to be reworked completely, so I'm neutral
 
 * Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=43675 Possible logging
   releated class loader leak
   http://svn.apache.org/viewvc?rev=594700&view=rev
-  +1: markt, pero
+  +1: markt, pero, fhanik
   -1:
 
 * Update TC5 with the new Cookie handling code from TC6
@@ -71,13 +72,13 @@
   http://svn.apache.org/viewvc?view=rev&revision=580754
   http://svn.apache.org/viewvc?view=rev&revision=586818
   http://svn.apache.org/viewvc?view=rev&revision=594968
-  +1: markt, pero
+  +1: markt, pero, fhanik
   -1:
 
 * Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=43887
   Include exception in log message
   http://svn.apache.org/viewvc?rev=597738&view=rev
-  +1: markt, pero
+  +1: markt, pero, fhanik
   -1:
 
 * Fix license issues
@@ -89,7 +90,7 @@
   
http://svn.apache.org/repos/asf/tomcat/tc6.0.x/trunk/java/javax/servlet/jsp/resources/web-jsptaglibrary_2_0.xsd
   and port the following:
   http://svn.apache.org/viewvc?rev=598412&view=rev
-  +1: markt, pero
+  +1: markt, pero, fhanik
   -1:
 
 * Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=43957
@@ -101,27 +102,27 @@
 * Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=43757
   Use SMAP info rather than string matching to ID line number in JSP
   http://svn.apache.org/viewvc?rev=599605&view=rev
-  +1: markt, pero
+  +1: markt, pero, fhanik
   -1:
 
 * Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=43995
   Backport fix from TC6. Also fix memory leak
   
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java?view=diff&r1=583649&r2=583650&pathrev=583650
-  +1: markt, pero
+  +1: markt, pero, fhanik
   -1:
 
 
 * Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=43622
   Don't always overwrite min compression size with default
   http://svn.apache.org/viewvc?rev=599914&view=rev
-  +1: markt, pero
+  +1: markt, pero, fhanik
   -1:
 
 * Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=43611
   Provide an error message when trying to upload a war if the context is 
defined
   in server.xml
   http://svn.apache.org/viewvc?rev=600177&view=rev
-  +1: markt, pero
+  +1: markt, pero, fhanik
   -1:
 
 * Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=43594
@@ -145,13 +146,13 @@
 * Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=43241
   ServletContext.getResourceAsStream() not spec compliant
   http://svn.apache.org/viewvc?rev=605356&view=rev
-  +1: markt, pero
+  +1: markt, pero, fhanik
   -1: 
 
 * Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=43236
   Reset usingWriter and associated flags when response is reset
   http://svn.apache.org/viewvc?rev=605364&view=rev
-  +1: markt, pero
+  +1: markt, pero, fhanik
   -1: 
 
 * Fix CVE-2007-5342
@@ -163,13 +164,13 @@
 * Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=44084
   JASSRealm is broken for application provided Principals
   http://svn.apache.org/viewvc?rev=606621&view=rev
-  +1: markt, pero
+  +1: markt, pero,fhanik
   -1: 
 
 * Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=43914
   Location headers must be encoded. Patch provided by Ivan Todoroski.
   http://svn.apache.org/viewvc?rev=606952&view=rev
-  +1: markt, pero
+  +1: markt, pero, fhanik
   -1: 
 
 * Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=43839



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: new year, new version? 6.0.16

[Peter Rossbach]

+1

Am 04.01.2008 um 19:34 schrieb Mark Thomas:


Filip Hanik - Dev Lists wrote:
we have a lot of updates added in, I think it may be good to set a  
date

for our next release and work towards that


+1.

There are a stack of changes (both committed and proposed) for  
5.5.x as

well. It would be good to plan a 5.5.x release as well.

I'll also do a 4.1.x release and wrap up the few remaining patches  
for that.


Mark

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]