svn commit: r543419 - /tomcat/connectors/trunk/jk/native/common/jk_util.c

[rjung]

Author: rjung
Date: Fri Jun  1 00:53:52 2007
New Revision: 543419

URL: http://svn.apache.org/viewvc?view=rev&rev=543419
Log:
Correct pthread_t casting in jk_gettid().
Needed at least on Mac OS X,
shouldn't hurt on other platforms.

Modified:
tomcat/connectors/trunk/jk/native/common/jk_util.c

Modified: tomcat/connectors/trunk/jk/native/common/jk_util.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_util.c?view=diff&rev=543419&r1=543418&r2=543419
==
--- tomcat/connectors/trunk/jk/native/common/jk_util.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_util.c Fri Jun  1 00:53:52 2007
@@ -1686,7 +1686,7 @@
 pthread_getunique_np(&t, &tid);
 return ((int)(tid.intId.lo & 0x));
 #else
-int tid = (int)(t & 0x);
+int tid = ((int)t) & 0x;
 return tid;
 #endif /* AS400 */
 }



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r543419 - /tomcat/connectors/trunk/jk/native/common/jk_util.c

[Mladen Turk]

[EMAIL PROTECTED] wrote:

Correct pthread_t casting in jk_gettid().
Needed at least on Mac OS X,
shouldn't hurt on other platforms.

-int tid = (int)(t & 0x);
+int tid = ((int)t) & 0x;


Since thread id is a pointer, think it can even be
rounded to the sizeof t
Something like ((int)t / align(sizeof t)) & 0x

Anyhow, it's used only for logging to have an idea
from which threads in worker mpm's the logs are coming,
so the accuracy is not important.

Regards,
Mladen.






-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r543414 - in /tomcat/trunk/java/javax: el/BeanELResolver.java el/ResourceBundleELResolver.java servlet/jsp/el/ScopedAttributeELResolver.java servlet/jsp/tagext/TagInfo.java

[fhanik]

Author: fhanik
Date: Fri Jun  1 00:40:37 2007
New Revision: 543414

URL: http://svn.apache.org/viewvc?view=rev&rev=543414
Log:
Forward port of BZ 42509 and BZ 42515

Modified:
tomcat/trunk/java/javax/el/BeanELResolver.java
tomcat/trunk/java/javax/el/ResourceBundleELResolver.java
tomcat/trunk/java/javax/servlet/jsp/el/ScopedAttributeELResolver.java
tomcat/trunk/java/javax/servlet/jsp/tagext/TagInfo.java

Modified: tomcat/trunk/java/javax/el/BeanELResolver.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/javax/el/BeanELResolver.java?view=diff&rev=543414&r1=543413&r2=543414
==
--- tomcat/trunk/java/javax/el/BeanELResolver.java (original)
+++ tomcat/trunk/java/javax/el/BeanELResolver.java Fri Jun  1 00:40:37 2007
@@ -81,7 +81,7 @@
}
 
context.setPropertyResolved(true);
-   return this.property(context, base, property).getType();
+   return this.property(context, base, property).getPropertyType();
}
 
public void setValue(ELContext context, Object base, Object property,
@@ -105,7 +105,7 @@
 
Method m = this.property(context, base, 
property).write(context);
try {
-   m.invoke(base, new Object[] { value });
+   m.invoke(base, value);
} catch (IllegalAccessException e) {
throw new ELException(e);
} catch (InvocationTargetException e) {
@@ -187,7 +187,7 @@
}
}
 
-   public BeanProperty get(ELContext ctx, String name) {
+   private BeanProperty get(ELContext ctx, String name) {
BeanProperty property = this.properties.get(name);
if (property == null) {
throw new PropertyNotFoundException(message(ctx,
@@ -196,8 +196,12 @@
}
return property;
}
+
+public BeanProperty getBeanProperty(String name) {
+return get(null, name);
+}
 
-public Class getType() {
+private Class getType() {
 return type;
 }
}
@@ -213,13 +217,13 @@
 
private Method write;
 
-   public BeanProperty(Class owner, PropertyDescriptor descriptor) 
{
+   public BeanProperty(Class owner, PropertyDescriptor 
descriptor) {
this.owner = owner;
this.descriptor = descriptor;
this.type = descriptor.getPropertyType();
}
 
-   public Class getType() {
+   public Class getPropertyType() {
return this.type;
}
 
@@ -228,7 +232,15 @@
&& (null == (this.write = getMethod(this.owner, 
descriptor.getWriteMethod(;
}
 
-   public Method write(ELContext ctx) {
+   public Method getWriteMethod() {
+   return write(null);
+   }
+
+   public Method getReadMethod() {
+   return this.read(null);
+   }
+
+   private Method write(ELContext ctx) {
if (this.write == null) {
this.write = getMethod(this.owner, 
descriptor.getWriteMethod());
if (this.write == null) {
@@ -240,7 +252,7 @@
return this.write;
}
 
-   public Method read(ELContext ctx) {
+   private Method read(ELContext ctx) {
if (this.read == null) {
this.read = getMethod(this.owner, 
descriptor.getReadMethod());
if (this.read == null) {

Modified: tomcat/trunk/java/javax/el/ResourceBundleELResolver.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/javax/el/ResourceBundleELResolver.java?view=diff&rev=543414&r1=543413&r2=543414
==
--- tomcat/trunk/java/javax/el/ResourceBundleELResolver.java (original)
+++ tomcat/trunk/java/javax/el/ResourceBundleELResolver.java Fri Jun  1 
00:40:37 2007
@@ -95,7 +95,7 @@
return true;
}
 
-   public Iterator getFeatureDescriptors(ELContext 
context, Object base) {
+   public Iterator getFeatureDescriptors(ELContext context, Object base) {
if (base instanceof ResourceBundle) {
List feats = new 
ArrayList();
Enumeration e = ((ResourceBundle) base).getKeys();

Modified: tomcat/trunk/java/javax/servlet/jsp/el/ScopedAttributeELResolver.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/javax/servlet/jsp/el/ScopedAttributeELResolver.java?view=diff&rev=543414&r1

DO NOT REPLY [Bug 42509] - API signature errors in javax.servlet.jsp

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42509


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 42515] - API signature discrepancies in el-api

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42515


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r543413 - in /tomcat/tc6.0.x/trunk/java/javax: el/BeanELResolver.java el/ResourceBundleELResolver.java servlet/jsp/el/ScopedAttributeELResolver.java servlet/jsp/tagext/TagInfo.java

[fhanik]

Author: fhanik
Date: Fri Jun  1 00:38:39 2007
New Revision: 543413

URL: http://svn.apache.org/viewvc?view=rev&rev=543413
Log:
Fix signatures
BZ 42509  
BZ 42515  
Submitted by Paul McMahan

Modified:
tomcat/tc6.0.x/trunk/java/javax/el/BeanELResolver.java
tomcat/tc6.0.x/trunk/java/javax/el/ResourceBundleELResolver.java

tomcat/tc6.0.x/trunk/java/javax/servlet/jsp/el/ScopedAttributeELResolver.java
tomcat/tc6.0.x/trunk/java/javax/servlet/jsp/tagext/TagInfo.java

Modified: tomcat/tc6.0.x/trunk/java/javax/el/BeanELResolver.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/javax/el/BeanELResolver.java?view=diff&rev=543413&r1=543412&r2=543413
==
--- tomcat/tc6.0.x/trunk/java/javax/el/BeanELResolver.java (original)
+++ tomcat/tc6.0.x/trunk/java/javax/el/BeanELResolver.java Fri Jun  1 00:38:39 
2007
@@ -81,7 +81,7 @@
}
 
context.setPropertyResolved(true);
-   return this.property(context, base, property).getType();
+   return this.property(context, base, property).getPropertyType();
}
 
public void setValue(ELContext context, Object base, Object property,
@@ -105,7 +105,7 @@
 
Method m = this.property(context, base, 
property).write(context);
try {
-   m.invoke(base, new Object[] { value });
+   m.invoke(base, value);
} catch (IllegalAccessException e) {
throw new ELException(e);
} catch (InvocationTargetException e) {
@@ -187,7 +187,7 @@
}
}
 
-   public BeanProperty get(ELContext ctx, String name) {
+   private BeanProperty get(ELContext ctx, String name) {
BeanProperty property = this.properties.get(name);
if (property == null) {
throw new PropertyNotFoundException(message(ctx,
@@ -196,8 +196,12 @@
}
return property;
}
+
+public BeanProperty getBeanProperty(String name) {
+return get(null, name);
+}
 
-public Class getType() {
+private Class getType() {
 return type;
 }
}
@@ -213,13 +217,13 @@
 
private Method write;
 
-   public BeanProperty(Class owner, PropertyDescriptor descriptor) 
{
+   public BeanProperty(Class owner, PropertyDescriptor 
descriptor) {
this.owner = owner;
this.descriptor = descriptor;
this.type = descriptor.getPropertyType();
}
 
-   public Class getType() {
+   public Class getPropertyType() {
return this.type;
}
 
@@ -228,7 +232,15 @@
&& (null == (this.write = getMethod(this.owner, 
descriptor.getWriteMethod(;
}
 
-   public Method write(ELContext ctx) {
+   public Method getWriteMethod() {
+   return write(null);
+   }
+
+   public Method getReadMethod() {
+   return this.read(null);
+   }
+
+   private Method write(ELContext ctx) {
if (this.write == null) {
this.write = getMethod(this.owner, 
descriptor.getWriteMethod());
if (this.write == null) {
@@ -240,7 +252,7 @@
return this.write;
}
 
-   public Method read(ELContext ctx) {
+   private Method read(ELContext ctx) {
if (this.read == null) {
this.read = getMethod(this.owner, 
descriptor.getReadMethod());
if (this.read == null) {

Modified: tomcat/tc6.0.x/trunk/java/javax/el/ResourceBundleELResolver.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/javax/el/ResourceBundleELResolver.java?view=diff&rev=543413&r1=543412&r2=543413
==
--- tomcat/tc6.0.x/trunk/java/javax/el/ResourceBundleELResolver.java (original)
+++ tomcat/tc6.0.x/trunk/java/javax/el/ResourceBundleELResolver.java Fri Jun  1 
00:38:39 2007
@@ -95,7 +95,7 @@
return true;
}
 
-   public Iterator getFeatureDescriptors(ELContext 
context, Object base) {
+   public Iterator getFeatureDescriptors(ELContext context, Object base) {
if (base instanceof ResourceBundle) {
List feats = new 
ArrayList();
Enumeration e = ((ResourceBundle) base).getKeys();

Modified: 
tomcat/tc6.0.x/trunk/java/javax/servlet/jsp/el/ScopedAttributeELResolver.j

DO NOT REPLY [Bug 42554] - mod_ssl + mod_jk with status_worker does not work on a single node cluster.

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42554





--- Additional Comments From [EMAIL PROTECTED]  2007-06-01 03:57 ---
Sorry me, but i dont understand what are you asking to me:

Are you asking me for tomcat config files please ask me for.


My full httpd.conf:
#
# Based upon the NCSA server configuration files originally by Rob McCool.
#
# This is the main Apache server configuration file.  It contains the
# configuration directives that give the server its instructions.
# See http://httpd.apache.org/docs-2.0/> for detailed information about
# the directives.
#
# Do NOT simply read the instructions in here without understanding
# what they do.  They're here only as hints or reminders.  If you are unsure
# consult the online docs. You have been warned.  
#
# The configuration directives are grouped into three basic sections:
#  1. Directives that control the operation of the Apache server process as a
# whole (the 'global environment').
#  2. Directives that define the parameters of the 'main' or 'default' server,
# which responds to requests that aren't handled by a virtual host.
# These directives also provide default values for the settings
# of all virtual hosts.
#  3. Settings for virtual hosts, which allow Web requests to be sent to
# different IP addresses or hostnames and have them handled by the
# same Apache server process.
#
# Configuration and logfile names: If the filenames you specify for many
# of the server's control files begin with "/" (or "drive:/" for Win32), the
# server will use that explicit path.  If the filenames do *not* begin
# with "/", the value of ServerRoot is prepended -- so "logs/foo.log"
# with ServerRoot set to "C:/Apache2" will be interpreted by the
# server as "C:/Apache2/logs/foo.log".
#
# NOTE: Where filenames are specified, you must use forward slashes
# instead of backslashes (e.g., "c:/apache" instead of "c:\apache").
# If a drive letter is omitted, the drive on which Apache.exe is located
# will be used by default.  It is recommended that you always supply
# an explicit drive letter in absolute paths, however, to avoid
# confusion.
#

### Section 1: Global Environment
#
# The directives in this section affect the overall operation of Apache,
# such as the number of concurrent requests it can handle or where it
# can find its configuration files.
#

#
# ServerRoot: The top of the directory tree under which the server's
# configuration, error, and log files are kept.
#
# NOTE!  If you intend to place this on an NFS (or otherwise network)
# mounted filesystem then please read the LockFile documentation (available
# at http://httpd.apache.org/docs-2.0/mod/mpm_common.html#lockfile>);
# you will save yourself a lot of trouble.
#
# Do NOT add a slash at the end of the directory path.
#
ServerRoot "C:/Apache2"

#
# ScoreBoardFile: File used to store internal server process information.
# If unspecified (the default), the scoreboard will be stored in an
# anonymous shared memory segment, and will be unavailable to third-party
# applications.
# If specified, ensure that no two invocations of Apache share the same
# scoreboard file. The scoreboard file MUST BE STORED ON A LOCAL DISK.
#
#ScoreBoardFile logs/apache_runtime_status

#
# PidFile: The file in which the server should record its process
# identification number when it starts.
#
PidFile logs/httpd.pid

#
# Timeout: The number of seconds before receives and sends time out.
#
Timeout 300

#
# KeepAlive: Whether or not to allow persistent connections (more than
# one request per connection). Set to "Off" to deactivate.
#
KeepAlive On

#
# MaxKeepAliveRequests: The maximum number of requests to allow
# during a persistent connection. Set to 0 to allow an unlimited amount.
# We recommend you leave this number high, for maximum performance.
#
MaxKeepAliveRequests 100

#
# KeepAliveTimeout: Number of seconds to wait for the next request from the
# same client on the same connection.
#
KeepAliveTimeout 15

##
## Server-Pool Size Regulation (MPM specific)
## 

# WinNT MPM
# ThreadsPerChild: constant number of worker threads in the server process
# MaxRequestsPerChild: maximum  number of requests a server process serves

ThreadsPerChild 250
MaxRequestsPerChild  0


#
# Listen: Allows you to bind Apache to specific IP addresses and/or
# ports, instead of the default. See also the 
# directive.
#
# Change this to Listen on specific IP addresses as shown below to 
# prevent Apache from glomming onto all bound IP addresses (0.0.0.0)
#
#Listen 12.34.56.78:80
Listen 80
Listen 443

#
# Dynamic Shared Object (DSO) Support
#
# To be able to use the functionality of a module which was built as a DSO you
# have to place corresponding `LoadMod

Re: please publish a snapshot

[Remy Maucherat]

Paul McMahan wrote:
Could someone please publish a snapshot of  
http://svn.apache.org/repos/asf/tomcat/trunk/  to the Apache snapshot repo?


No, it would be really inappropriate.

Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 42554] - mod_ssl + mod_jk with status_worker does not work on a single node cluster.

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42554





--- Additional Comments From [EMAIL PROTECTED]  2007-06-01 04:46 ---
Mark made a comment, that your httpd.conf indicates, that your setup is fragile
with respect to security.

Concerning your original question ("my web server doesn't start up"), we both
were asking you to look into your log files to check, if there are any messages
that might be helpful.

The log files are the ErrorLog of Apache httpd (logs/error.log) and the
JkLogFile (logs/mod_jk.log).

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r543460 - in /tomcat/site/trunk: docs/faq/connectors.html docs/faq/printer/connectors.html xdocs-faq/connectors.xml

[funkman]

Author: funkman
Date: Fri Jun  1 04:28:14 2007
New Revision: 543460

URL: http://svn.apache.org/viewvc?view=rev&rev=543460
Log:
jk2 update and other legacy cleanup

Modified:
tomcat/site/trunk/docs/faq/connectors.html
tomcat/site/trunk/docs/faq/printer/connectors.html
tomcat/site/trunk/xdocs-faq/connectors.xml

Modified: tomcat/site/trunk/docs/faq/connectors.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/faq/connectors.html?view=diff&rev=543460&r1=543459&r2=543460
==
--- tomcat/site/trunk/docs/faq/connectors.html (original)
+++ tomcat/site/trunk/docs/faq/connectors.html Fri Jun  1 04:28:14 2007
@@ -13,7 +13,11 @@
 
   
   
-http://tomcat.apache.org/connectors-doc/";>JK docs.
+Here is a link to the http://tomcat.apache.org/connectors-doc/";>JK Connectors. It contains
+more configuration and installation information.
+  
+  
+Please note, jk2 is no longer supported. Please use mod_jk 
instead.
   
 Questions
 
@@ -38,14 +42,6 @@
 At boot, is order of start up (Apache vs Tomcat) important?
   
 
-
-  
- JK2 doesn't seem to be using my settings in my
- workers2.properties file
- such as creating the shm file or mapping the URIs listed to Tomcat,
- what's wrong?
-  
-
 
 
   
@@ -111,12 +107,14 @@
 The alternative is mod_jk or mod_proxy_ajp.
   
   
-mod_jk is great and should be used for production. It is getting
-fixes as needed (which is now rare). 
+mod_jk is great and should be used for production. 
+It is still under active
+development and also works for the apache 2.X series for cases where
+you do not want to use mod_proxy_ajp.
   
   mod_proxy. A cheap way to proxy without the hassles of configuring 
JK.
 This solution lacks sticky session load balancing. If you don't
-need some of the features of jk, jk2 - this is a very simple
+need some of the features of jk - this is a very simple
 alternative.
   
   mod_proxy_ajp. With apache 2.2, mod_proxy was rewritten to support
@@ -137,7 +135,7 @@
 reasons why it
 should not be done too. Needless to say, everyone will disagree with
 the opinions here.
-With the upcoming performance of Tomcat 5, performance reasons
+With the performance of Tomcat 5 and 6, performance reasons
 become harder to justify. So here are the issues to discuss in
 integrating vs not.

@@ -202,11 +200,6 @@
packets, invalid requests from invalid IP's, Apache does a better job
at dropping these error conditions than JVM based program. (YMMV)
 
-
-http://marc.theaimsgroup.com/?l=tomcat-user&m=104874913017036&w=2";>Here 

-is a great response from Craig R. McClanahan. If you have free time,
-read emails by him in any of the list archives. You'll learn a lot.
-
 
   
 
@@ -221,30 +214,6 @@
   
 
   
-
- JK2 doesn't seem to be using my settings in my
- workers2.properties file
- such as creating the shm file or mapping the URIs listed to Tomcat,
- what's wrong?
-
-  
-  
-JK2 is not finding your workers2.properties file.
-Specify it's location in your httpd.conf file by adding:
-
-
-
-JkSet config.file /full/system/path/to/workers2.properties
-
-
-http://marc.theaimsgroup.com/?t=10578489323&r=1&w=2";>
-Thread which spawned this question.
- 
-Please note the JK2 is unsupported.
-  
-
-
-  
 
 Is there any way to control the content of automatically generated
 mod_jk.conf-auto? I need my own specific commands added
@@ -303,7 +272,7 @@
 
   
   
-In tomcat 5 - does your connector have Connector declaration have
+Since tomcat 5 - does your connector have Connector declaration have
 URIEncoding="UTF-8". For example:
 
 JK docs.
+Here is a link to the http://tomcat.apache.org/connectors-doc/";>JK Connectors. It contains
+more configuration and installation information.
+  
+  
+Please note, jk2 is no longer supported. Please use mod_jk 
instead.
   
 Questions
 
@@ -37,14 +41,6 @@
 At boot, is order of start up (Apache vs Tomcat) important?
   
 
-
-  
- JK2 doesn't seem to be using my settings in my
- workers2.properties file
- such as creating the shm file or mapping the URIs lis

DO NOT REPLY [Bug 12428] - request.getUserPrincipal(): Misinterpretation of specification?

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=12428


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|INVALID |




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 42554] - mod_ssl + mod_jk with status_worker does not work on a single node cluster.

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42554





--- Additional Comments From [EMAIL PROTECTED]  2007-06-01 05:44 ---
Thanks, it was a typing error, now it is fixed:

# Per prohibir que els usuaris accedeixin al WEB-INF de Tomcat

AllowOverride None
deny from all


mod_jk log in debug mode:

[Fri Jun 01 14:43:23 2007] [0732:0736] [debug] jk_uri_worker_map.c (423): rule 
map size is 6
[Fri Jun 01 14:43:23 2007] [0732:0736] [debug] jk_uri_worker_map.c (364): 
wildchar rule '/*/AppJava/*=lb_worker' source 'JkMount' was added
[Fri Jun 01 14:43:23 2007] [0732:0736] [debug] jk_uri_worker_map.c (364): 
wildchar rule '/*.jsp=lb_worker' source 'JkMount' was added
[Fri Jun 01 14:43:23 2007] [0732:0736] [debug] jk_uri_worker_map.c (364): 
wildchar rule '/*/GenData/*=lb_worker' source 'JkMount' was added
[Fri Jun 01 14:43:23 2007] [0732:0736] [debug] jk_uri_worker_map.c (364): 
wildchar rule '/*/UsrData/*=lb_worker' source 'JkMount' was added
[Fri Jun 01 14:43:23 2007] [0732:0736] [debug] jk_uri_worker_map.c (364): 
wildchar rule '/*/TmpData/*=lb_worker' source 'JkMount' was added
[Fri Jun 01 14:43:23 2007] [0732:0736] [debug] jk_uri_worker_map.c (372): exact 
rule '/jkmanager/=status_worker' source 'JkMount' was added
[Fri Jun 01 14:43:23 2007] [0732:0736] [debug] jk_uri_worker_map.c (423): rule 
map size is 6
[Fri Jun 01 14:43:23 2007] [0732:0736] [debug] jk_uri_worker_map.c (364): 
wildchar rule '/*/AppJava/*=lb_worker' source 'JkMount' was added
[Fri Jun 01 14:43:23 2007] [0732:0736] [debug] jk_uri_worker_map.c (364): 
wildchar rule '/*.jsp=lb_worker' source 'JkMount' was added
[Fri Jun 01 14:43:23 2007] [0732:0736] [debug] jk_uri_worker_map.c (364): 
wildchar rule '/*/GenData/*=lb_worker' source 'JkMount' was added
[Fri Jun 01 14:43:23 2007] [0732:0736] [debug] jk_uri_worker_map.c (364): 
wildchar rule '/*/UsrData/*=lb_worker' source 'JkMount' was added
[Fri Jun 01 14:43:23 2007] [0732:0736] [debug] jk_uri_worker_map.c (364): 
wildchar rule '/*/TmpData/*=lb_worker' source 'JkMount' was added
[Fri Jun 01 14:43:23 2007] [0732:0736] [debug] jk_uri_worker_map.c (372): exact 
rule '/jkmanager/=status_worker' source 'JkMount' was added
[Fri Jun 01 14:43:23 2007] [0732:0736] [debug] jk_shm.c (163): Initialized 
shared memory size=28800 free=28672 addr=0x63bd00
[Fri Jun 01 14:43:23 2007] [0732:0736] [debug] mod_jk.c (2632): Initialized 
shm:memory
[Fri Jun 01 14:43:23 2007] [0732:0736] [debug] jk_map.c (644): Checking for 
references with prefix worker. with wildcard (recursion 1)
[Fri Jun 01 14:43:23 2007] [0732:0736] [debug] jk_worker.c (239): creating 
worker lb_worker
[Fri Jun 01 14:43:23 2007] [0732:0736] [debug] jk_worker.c (144): about to 
create instance lb_worker of lb
[Fri Jun 01 14:43:23 2007] [0732:0736] [debug] jk_worker.c (157): about to 
validate and init lb_worker
[Fri Jun 01 14:43:23 2007] [0732:0736] [debug] jk_worker.c (144): about to 
create instance workerW02 of ajp13
[Fri Jun 01 14:43:23 2007] [0732:0736] [debug] jk_worker.c (157): about to 
validate and init workerW02
[Fri Jun 01 14:43:23 2007] [0732:0736] [debug] jk_ajp_common.c (1985): worker 
workerW02 contact is 'VPBRPRESIDW02:8009'
[Fri Jun 01 14:43:23 2007] [0732:0736] [debug] jk_ajp_common.c (2112): setting 
endpoint options:
[Fri Jun 01 14:43:23 2007] [0732:0736] [debug] jk_ajp_common.c (2115): 
keepalive:0
[Fri Jun 01 14:43:23 2007] [0732:0736] [debug] jk_ajp_common.c (2119): 
timeout:  0
[Fri Jun 01 14:43:23 2007] [0732:0736] [debug] jk_ajp_common.c (2123): buffer 
size:  0
[Fri Jun 01 14:43:23 2007] [0732:0736] [debug] jk_ajp_common.c (2127): pool 
timeout: 0
[Fri Jun 01 14:43:23 2007] [0732:0736] [debug] jk_ajp_common.c (2131): connect 
timeout:  0
[Fri Jun 01 14:43:23 2007] [0732:0736] [debug] jk_ajp_common.c (2135): reply 
timeout:0
[Fri Jun 01 14:43:23 2007] [0732:0736] [debug] jk_ajp_common.c (2139): prepost 
timeout:  0
[Fri Jun 01 14:43:23 2007] [0732:0736] [debug] jk_ajp_common.c (2143): recovery 
options: 0
[Fri Jun 01 14:43:23 2007] [0732:0736] [debug] jk_ajp_common.c (2147): 
retries:  2
[Fri Jun 01 14:43:23 2007] [0732:0736] [debug] jk_ajp_common.c (2151): max 
packet size:  8192
[Fri Jun 01 14:43:23 2007] [0732:0736] [debug] jk_ajp_common.c (2022): setting 
connection pool size to 250 with min 125
[Fri Jun 01 14:43:23 2007] [0732:0736] [debug] jk_lb_worker.c (1288): Balanced 
worker 0 has name workerW02 and route workerW02 in domain 
[Fri Jun 01 14:43:23 2007] [0732:0736] [debug] jk_lb_worker.c (217): worker 
workerW02 gets multiplicity 1
[Fri Jun 01 14:43:23 2007] [0732:0736] [debug] jk_lb_worker.c (261): syncing 
shm for lb 'lb_worker' from mem
[Fri Jun 01 14:43:23 2007] [0732:0736] [debug] jk_worker.c (239

Re: intentional change to ErrorReportValve?

[Yoav Shapira]

Hi,.

On 5/30/07, Paul McMahan <[EMAIL PROTECTED]> wrote:

A recent change to ErrorReportValve is causing a problem with TCK.
 From the commit log it seems that the change was not supposed to
introduce any new behavior:
http://svn.apache.org/viewvc?view=rev&revision=535915

But the valve's behavior was changed because the check for
response.isCommitted() was replaced with response.isAppCommitted().
Was that change intentional or should it be reverted?


Paul, did you ever hear back on this?  I'd be concerned with a TCK
failure in this area.

Yoav

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 42563] New: - OS X; NIO protocol; improve documentation; -Djava.net.preferIPv4Stack=true

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42563

   Summary: OS X; NIO protocol; improve documentation; -
Djava.net.preferIPv4Stack=true
   Product: Tomcat 6
   Version: unspecified
  Platform: PC
OS/Version: Mac OS X 10.4
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


On OS X if one wants to use the "org.apache.coyote.http11.Http11NioProtocol"
protocol with the HTTP connector one has to set the following system property:

-Djava.net.preferIPv4Stack=true

Otherwise one gets:

Jun 1, 2007 4:09:33 PM org.apache.tomcat.util.net.NioEndpoint setSocketOptions
SEVERE: 
java.net.SocketException: Invalid argument
at sun.nio.ch.Net.setIntOption0(Native Method)
at sun.nio.ch.Net.setIntOption(Net.java:152)
at sun.nio.ch.SocketChannelImpl$1.setInt(SocketChannelImpl.java:372)
at sun.nio.ch.SocketOptsImpl.setInt(SocketOptsImpl.java:46)
at sun.nio.ch.SocketOptsImpl$IP.typeOfService(SocketOptsImpl.java:249)
at sun.nio.ch.OptionAdaptor.setTrafficClass(OptionAdaptor.java:158)
at sun.nio.ch.SocketAdaptor.setTrafficClass(SocketAdaptor.java:330)
at
org.apache.tomcat.util.net.SocketProperties.setProperties(SocketProperties.java:171)
at 
org.apache.tomcat.util.net.NioEndpoint.setSocketOptions(NioEndpoint.java:967)
at 
org.apache.tomcat.util.net.NioEndpoint$Acceptor.run(NioEndpoint.java:1183)
at java.lang.Thread.run(Thread.java:613)

Also see:
http://lists.apple.com/archives/java-dev/2006/Jun/msg00414.html



This should be documented on:

http://tomcat.apache.org/tomcat-6.0-doc/config/http.html

And in other appropriate places.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: intentional change to ErrorReportValve?

[Paul McMahan]

Yoav,   Thanks for following up.  Yesterday rev 543307 fixed the  
problem in tc6.0.x/trunk.   But the problem still remains in trunk.   
Not sure if there are plans to apply BZ 42559 there as well.


Best wishes,
Paul

On Jun 1, 2007, at 9:49 AM, Yoav Shapira wrote:


Hi,.

On 5/30/07, Paul McMahan <[EMAIL PROTECTED]> wrote:

A recent change to ErrorReportValve is causing a problem with TCK.
 From the commit log it seems that the change was not supposed to
introduce any new behavior:
http://svn.apache.org/viewvc?view=rev&revision=535915

But the valve's behavior was changed because the check for
response.isCommitted() was replaced with response.isAppCommitted().
Was that change intentional or should it be reverted?


Paul, did you ever hear back on this?  I'd be concerned with a TCK
failure in this area.

Yoav

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: please publish a snapshot

[Paul McMahan]

My goal is to get the new InstanceManager code that was recently  
committed to trunk into the geronimo 2.0 testbed.  Picking up a  
snapshot of trunk seems like the most straightforward way to do  
this.  At the same time I realize that trunk has been very active  
lately, and that there is some parallel work going on in sandbox.  So  
instead of picking up a snapshot I could apply the InstanceManager  
patch to a private copy of 6.0.13.  I would also need to apply my  
patch that Fabien committed for jaxrpc (rev 540457), and maybe the EL  
and JSP api signature patch you just applied.  But as you might guess  
I'm not a big fan of maintaining a private copy of tomcat and want to  
stay in synch with you as much as possible, even if it means using a  
less stable code base for the short term.   The only other  
alternative I can think of would be to ask you to apply the  
InstanceManager patch to the 6.0.x branch, but that seems unwise...   
in good conscience I don't even think I could make that request.


I sincerely appreciate the support and attention that you, Remy, and  
the rest of the team have provided.  How do you suggest I should  
proceed?


Best wishes,
Paul


On Jun 1, 2007, at 2:57 AM, Filip Hanik - Dev Lists wrote:


Paul McMahan wrote:
Could someone please publish a snapshot of  http://svn.apache.org/ 
repos/asf/tomcat/trunk/  to the Apache snapshot repo?
you sure you want trunk, this branch is in modification mode and  
doesn't even have a scheduled release date nor has all changes yet  
been agreed upon,

I can publish the tc6.0.x snapshot if you wish

Filip



Best wishes,
Paul


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



--No virus found in this incoming message.
Checked by AVG Free Edition.Version: 7.5.472 / Virus Database:  
269.8.4/825 - Release Date: 5/30/2007 3:03 PM






-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 42497] - 304 response should consistently include ETag header

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42497





--- Additional Comments From [EMAIL PROTECTED]  2007-06-01 07:43 ---
I see how to fix this, but I'm not set up to compile Tomcat so someone else will
have to make the change and test it.

In org.apache.catalina.servlets.DefaultServlet, the serveResource method sets an
ETag header when it serves a file with a 200 or 206 response. To get it to add
the ETag to 304 responses, this needs to be added:
 response.setHeader("ETag", getETag(resourceAttributes));
in two places where a a status of 304 (SC_NOT_MODIFIED) is set, in the methods
checkIfModifiedSince and checkIfNoneMatch.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 42497] - 304 response should consistently include ETag header

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42497


[EMAIL PROTECTED] changed:

   What|Removed |Added

  Component|Unknown |Catalina




--- Additional Comments From [EMAIL PROTECTED]  2007-06-01 07:45 ---
(I've changed the Component to "Catalina" because none of the more specific
Components seem appropriate. If that's wrong, please correct it.)

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: intentional change to ErrorReportValve?

[Remy Maucherat]

Paul McMahan wrote:
Yoav,   Thanks for following up.  Yesterday rev 543307 fixed the problem 
in tc6.0.x/trunk.   But the problem still remains in trunk.  Not sure if 
there are plans to apply BZ 42559 there as well.


Trunk does not have any official existence as a release branch, so it's 
not really important at this point. The change will be applied there 
eventually, of course.


Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 42565] New: - jsp /expression language

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42565

   Summary: jsp /expression language
   Product: Tomcat 6
   Version: unspecified
  Platform: Other
OS/Version: Windows 2000
Status: NEW
  Severity: normal
  Priority: P2
 Component: Jasper
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


the following jspx works fine in tomcat 5.5.23 but fails in 6.0.13


http://www.w3.org/1999/xhtml";
xmlns:jsp="http://java.sun.com/JSP/Page";>

http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"; />   


error!!!


${true? (false?true:false):false}



org.apache.jasper.JasperException: An exception occurred processing JSP page
/test.jspx at line 15

12: error!!!
13: 
14: 
15: ${true? (false?true:false):false}
16: 
17: 


Stacktrace:

org.apache.jasper.servlet.JspServletWrapper.handleJspException(JspServletWrapper.java:524)

org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:435)
org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:320)
org.apache.jasper.servlet.JspServlet.service(JspServlet.java:266)
javax.servlet.http.HttpServlet.service(HttpServlet.java:803)

root cause

javax.el.ELException: Error Parsing: ${true? (false?true:false):false}

org.apache.el.lang.ExpressionBuilder.createNodeInternal(ExpressionBuilder.java:125)
org.apache.el.lang.ExpressionBuilder.build(ExpressionBuilder.java:146)

org.apache.el.lang.ExpressionBuilder.createValueExpression(ExpressionBuilder.java:190)

org.apache.el.ExpressionFactoryImpl.createValueExpression(ExpressionFactoryImpl.java:68)

org.apache.jasper.runtime.PageContextImpl.proprietaryEvaluate(PageContextImpl.java:922)
org.apache.jsp.test_jspx._jspService(test_jspx.java:62)
org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70)
javax.servlet.http.HttpServlet.service(HttpServlet.java:803)

org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:393)
org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:320)
org.apache.jasper.servlet.JspServlet.service(JspServlet.java:266)
javax.servlet.http.HttpServlet.service(HttpServlet.java:803)

root cause

org.apache.el.parser.ParseException: Encountered "true: false" at line 1, 
column 16.
Was expecting one of:
"(" ...
 ...
  ...

org.apache.el.parser.ELParser.generateParseException(ELParser.java:1874)
org.apache.el.parser.ELParser.jj_consume_token(ELParser.java:1754)
org.apache.el.parser.ELParser.NonLiteral(ELParser.java:1136)
org.apache.el.parser.ELParser.ValuePrefix(ELParser.java:1030)
org.apache.el.parser.ELParser.Value(ELParser.java:978)
org.apache.el.parser.ELParser.Unary(ELParser.java:960)
org.apache.el.parser.ELParser.Multiplication(ELParser.java:723)
org.apache.el.parser.ELParser.Math(ELParser.java:643)
org.apache.el.parser.ELParser.Compare(ELParser.java:455)
org.apache.el.parser.ELParser.Equality(ELParser.java:349)
org.apache.el.parser.ELParser.And(ELParser.java:293)
org.apache.el.parser.ELParser.Or(ELParser.java:237)
org.apache.el.parser.ELParser.Choice(ELParser.java:203)
org.apache.el.parser.ELParser.Expression(ELParser.java:183)
org.apache.el.parser.ELParser.NonLiteral(ELParser.java:1122)
org.apache.el.parser.ELParser.ValuePrefix(ELParser.java:1030)
org.apache.el.parser.ELParser.Value(ELParser.java:978)
org.apache.el.parser.ELParser.Unary(ELParser.java:960)
org.apache.el.parser.ELParser.Multiplication(ELParser.java:723)
org.apache.el.parser.ELParser.Math(ELParser.java:643)
org.apache.el.parser.ELParser.Compare(ELParser.java:455)
org.apache.el.parser.ELParser.Equality(ELParser.java:349)
org.apache.el.parser.ELParser.And(ELParser.java:293)
org.apache.el.parser.ELParser.Or(ELParser.java:237)
org.apache.el.parser.ELParser.Choice(ELParser.java:203)
org.apache.el.parser.ELParser.Expression(ELParser.java:183)
org.apache.el.parser.ELParser.DynamicExpression(ELParser.java:155)
org.apache.el.parser.ELParser.CompositeExpression(ELParser.java:52)

org.apache.el.lang.ExpressionBuilder.createNodeInternal(ExpressionBuilder.java:93)
org.apache.el.lang.ExpressionBuilder.build(ExpressionBuilder.java:146)

org.apache.el.lang.ExpressionBuilder.createValueExpression(ExpressionBuilder.jav

Gotta submit a Board report this month...

[Yoav Shapira]

... by June 18th at the latest, because the Board meeting is on June
20th.  But since I'll be leaving the country on vacation the preceding
weekend, our deadline is a bit earlier, let's say June 15th.

This is just an early heads-up.  Anyone have comments on what should
go in, besides the standard list of releases we've done since the last
report?

Yoav

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

How to load a static class on Tomcat startup

[[EMAIL PROTECTED]]

Hello everybody,
I want to know how I can configure Tomcat to load a Singleton class on his 
startup routine? This class implement a cache that I want to stay in memory 
until Tomcat is shutted down.

I've read about context but it seem to load the class only on a particular URL 
request..

I want the class to be loaded with Tomcat, without any request is made.

Thanks to all

Andrea


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Gotta submit a Board report this month...

[Tim Funk]

What about the new security site?

-Tim

Yoav Shapira wrote:

... by June 18th at the latest, because the Board meeting is on June
20th.  But since I'll be leaving the country on vacation the preceding
weekend, our deadline is a bit earlier, let's say June 15th.

This is just an early heads-up.  Anyone have comments on what should
go in, besides the standard list of releases we've done since the last
report?



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: How to load a static class on Tomcat startup

[Yoav Shapira]

Hey,
Use ServletContextListener's contextInitialized method.  In it you can
do your Class.forName call or whatever other way you want to load the
class.  This is portable and doesn't depend on Tomcat's internal
implementation.

Also, this is not a question for the dev mailing list, but for the
users mailing list.  Please see  http://tomcat.apache.org/lists.html
and if you have follow-up questions, post them on the users mailing
list.  Thanks,

Yoav


On 6/1/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:

Hello everybody,
I want to know how I can configure Tomcat to load a Singleton class on his
startup routine? This class implement a cache that I want to stay in memory
until Tomcat is shutted down.

I've read about context but it seem to load the class only on a particular URL
request..

I want the class to be loaded with Tomcat, without any request is made.

Thanks to all

Andrea


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Gotta submit a Board report this month...

[Remy Maucherat]

Yoav Shapira wrote:

... by June 18th at the latest, because the Board meeting is on June
20th.  But since I'll be leaving the country on vacation the preceding
weekend, our deadline is a bit earlier, let's say June 15th.

This is just an early heads-up.  Anyone have comments on what should
go in, besides the standard list of releases we've done since the last
report?


We have a separate 6.0.x branch.

Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Gotta submit a Board report this month...

[Niall Pemberton]

On 6/1/07, Yoav Shapira <[EMAIL PROTECTED]> wrote:

... by June 18th at the latest, because the Board meeting is on June
20th.  But since I'll be leaving the country on vacation the preceding
weekend, our deadline is a bit earlier, let's say June 15th.

This is just an early heads-up.  Anyone have comments on what should
go in, besides the standard list of releases we've done since the last
report?


The fact that Tomcat is now publishing its artifacts on standard maven repo :-)

Niall


Yoav


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 42563] - OS X; NIO protocol; improve documentation; -Djava.net.preferIPv4Stack=true

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42563


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WONTFIX




--- Additional Comments From [EMAIL PROTECTED]  2007-06-01 10:04 ---
it's already documented, in the first paragraph about NIO

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 42563] - OS X; NIO protocol; improve documentation; -Djava.net.preferIPv4Stack=true

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42563





--- Additional Comments From [EMAIL PROTECTED]  2007-06-01 10:13 ---
The paragraph you mention should be formatted:

- period missing
- : after Note missing

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Gotta submit a Board report this month...

[Rainer Jung]

- Lots of Tomcat talks at ApacheCon EU Amsterdam (Filip, Mladen)
- 2 mod_jk releases (1.2.22, 1.2.23), 1.2.23 was a security release

Yoav Shapira wrote:

... by June 18th at the latest, because the Board meeting is on June
20th.  But since I'll be leaving the country on vacation the preceding
weekend, our deadline is a bit earlier, let's say June 15th.

This is just an early heads-up.  Anyone have comments on what should
go in, besides the standard list of releases we've done since the last
report?

Yoav


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r543538 - in /tomcat/trunk/java/org/apache/tomcat/util/net: NioBlockingSelector.java NioEndpoint.java NioSelectorPool.java

[fhanik]

Author: fhanik
Date: Fri Jun  1 10:20:06 2007
New Revision: 543538

URL: http://svn.apache.org/viewvc?view=rev&rev=543538
Log:
Thread safe handling of dealing with async writes and non blocking writes, 
needed to separate it into a poller for incoming events and one poller for 
outgoing data
Not thread safe for multiple async servlet threads writing at the same time, up 
to the comet developer to set it straight

Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java
tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java
tomcat/trunk/java/org/apache/tomcat/util/net/NioSelectorPool.java

Modified: tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java?view=diff&rev=543538&r1=543537&r2=543538
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java 
(original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java Fri 
Jun  1 10:20:06 2007
@@ -25,9 +25,43 @@
 
 import org.apache.tomcat.util.net.NioEndpoint.KeyAttachment;
 import org.apache.tomcat.util.MutableInteger;
+import java.nio.channels.Selector;
+import java.util.concurrent.ConcurrentLinkedQueue;
+import org.apache.juli.logging.Log;
+import org.apache.juli.logging.LogFactory;
+import java.util.Iterator;
+import java.nio.channels.SocketChannel;
+import java.nio.channels.ClosedChannelException;
+import java.nio.channels.CancelledKeyException;
+import java.util.concurrent.CountDownLatch;
 
 public class NioBlockingSelector {
+
+protected static Log log = LogFactory.getLog(NioBlockingSelector.class);
+
+private static int threadCounter = 0;
+
+protected Selector sharedSelector;
+
+protected BlockPoller poller;
 public NioBlockingSelector() {
+
+}
+
+public void open(Selector selector) {
+sharedSelector = selector;
+poller = new BlockPoller();
+poller.selector = sharedSelector;
+poller.setDaemon(true);
+poller.setName("NioBlockingSelector.BlockPoller-"+(++threadCounter));
+poller.start();
+}
+
+public void close() {
+if (poller!=null) {
+poller.disable();
+poller.interrupt();
+}
 }
 
 /**
@@ -42,11 +76,10 @@
  * @throws SocketTimeoutException if the write times out
  * @throws IOException if an IO Exception occurs in the underlying socket 
logic
  */
-public static int write(ByteBuffer buf, NioChannel socket, long 
writeTimeout,MutableInteger lastWrite) throws IOException {
+public int write(ByteBuffer buf, NioChannel socket, long 
writeTimeout,MutableInteger lastWrite) throws IOException {
 SelectionKey key = 
socket.getIOChannel().keyFor(socket.getPoller().getSelector());
 if ( key == null ) throw new IOException("Key no longer registered");
 KeyAttachment att = (KeyAttachment) key.attachment();
-int prevOps = att.interestOps() | 
(att.getCometOps()&NioEndpoint.OP_CALLBACK);
 int written = 0;
 boolean timedout = false;
 int keycount = 1; //assume we can write
@@ -66,8 +99,7 @@
 }
 try {
 if ( att.getWriteLatch()==null || 
att.getWriteLatch().getCount()==0) att.startWriteLatch(1);
-//only register for write if a write has not yet been 
issued
-if ( (att.interestOps() & SelectionKey.OP_WRITE) == 0) 
socket.getPoller().add(socket,prevOps|SelectionKey.OP_WRITE);
+poller.add(att,SelectionKey.OP_WRITE);
 att.awaitWriteLatch(writeTimeout,TimeUnit.MILLISECONDS);
 }catch (InterruptedException ignore) {
 Thread.interrupted();
@@ -87,11 +119,11 @@
 if (timedout) 
 throw new SocketTimeoutException();
 } finally {
+poller.remove(att,SelectionKey.OP_WRITE);
 if (timedout && key != null) {
 cancelKey(socket, key);
 }
 }
-socket.getPoller().add(socket,prevOps);
 return written;
 }
 
@@ -108,11 +140,10 @@
  * @throws SocketTimeoutException if the read times out
  * @throws IOException if an IO Exception occurs in the underlying socket 
logic
  */
-public static int read(ByteBuffer buf, NioChannel socket, long 
readTimeout) throws IOException {
+public int read(ByteBuffer buf, NioChannel socket, long readTimeout) 
throws IOException {
 SelectionKey key = 
socket.getIOChannel().keyFor(socket.getPoller().getSelector());
 if ( key == null ) throw new IOException("Key no longer registered");
 KeyAttachment att = (KeyAttachment) key.attachment();
-int prevOps = att.interestOps() | 
(att.getCometOps()&NioEndpoint.OP_CALLBACK);
 int

DO NOT REPLY [Bug 42566] New: - hangs including jsp with < symbol

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42566

   Summary:  hangs including jsp with < symbol
   Product: Tomcat 5
   Version: 5.5.23
  Platform: Other
OS/Version: other
Status: NEW
  Severity: normal
  Priority: P2
 Component: Jasper
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Example:
includer.jsp : 

inner_ko.jsp : Hi, with this < the include hangs

inner_ok.jsp : Hi, now it works

This works with tomcat 2.2.20

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Gotta submit a Board report this month...

[Filip Hanik - Dev Lists]

Rainer Jung wrote:

- Lots of Tomcat talks at ApacheCon EU Amsterdam (Filip, Mladen)
yes, there was a "tomcat track", a full day of presos around tomcat, 
some from non committers as well if I remember correctly


Filip

- 2 mod_jk releases (1.2.22, 1.2.23), 1.2.23 was a security release

Yoav Shapira wrote:

... by June 18th at the latest, because the Board meeting is on June
20th.  But since I'll be leaving the country on vacation the preceding
weekend, our deadline is a bit earlier, let's say June 15th.

This is just an early heads-up.  Anyone have comments on what should
go in, besides the standard list of releases we've done since the last
report?

Yoav


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]






-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r543563 - /tomcat/connectors/trunk/jk/tools/jkrelease.sh

[rjung]

Author: rjung
Date: Fri Jun  1 11:12:33 2007
New Revision: 543563

URL: http://svn.apache.org/viewvc?view=rev&rev=543563
Log:
Allow to roll testing tarballs from a local
svn workspace. This makes release testing easier.

Modified:
tomcat/connectors/trunk/jk/tools/jkrelease.sh

Modified: tomcat/connectors/trunk/jk/tools/jkrelease.sh
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/tools/jkrelease.sh?view=diff&rev=543563&r1=543562&r2=543563
==
--- tomcat/connectors/trunk/jk/tools/jkrelease.sh (original)
+++ tomcat/connectors/trunk/jk/tools/jkrelease.sh Fri Jun  1 11:12:33 2007
@@ -11,18 +11,24 @@
 # And any one of: w3m, elinks, links (links2)
 
 usage() {
-echo "Usage:: $0 -t VERSION [-b BRANCH | -T]"
+echo "Usage:: $0 -t VERSION [-b BRANCH | -T | -d DIR]"
 echo "-t: version to package"
 echo "-b: package from branch BRANCH"
 echo "-T: package from trunk"
+echo "-d: package from local directory"
 }
 
-while getopts :t:b:T c
+conflict=0
+while getopts :t:b:d:T c
 do
 case $c in
 t) tag=$OPTARG;;
-b) branch=$OPTARG;;
-T) trunk=trunk;;
+b) branch=$OPTARG
+   conflict=$(($conflict+1));;
+T) trunk=trunk
+   conflict=$(($conflict+1));;
+d) local_dir=$OPTARG
+   conflict=$(($conflict+1));;
 \:)usage
exit 2;;
 \?)usage
@@ -31,6 +37,30 @@
 done
 shift `expr $OPTIND - 1`
 
+if [ $conflict -gt 1 ]
+then
+usage
+echo "Only one of the options '-b', '-T'  and '-d' is allowed."
+exit 2
+fi
+
+if [ -n "$local_dir" ]
+then
+echo "Caution: Packaging from directory!"
+echo "Make sure the directory is committed."
+answer="x"
+while [ "$answer" != "y" -a "$answer" != "n" ]
+do
+echo "Do you want to procede? [y/n]"
+read answer
+done
+if [ "$answer" != "y" ]
+then
+echo "Aborting."
+exit 4
+fi
+fi
+
 SVNROOT="http://svn.apache.org/repos/asf";
 SVNPROJ="tomcat/connectors"
 JK_CVST="tomcat-connectors"
@@ -49,12 +79,6 @@
 usage
 exit 2
 fi
-if [ -n "$trunk" -a -n "$branch" ]
-then
-usage
-echo "Only one of the options '-b' and '-T' allowed."
-exit 2
-fi
 if [ -n "$trunk" ]
 then
 JK_SVN_URL="${SVNROOT}/${SVNPROJ}/trunk"
@@ -76,6 +100,16 @@
exit 3
 fi
 JK_DIST=${JK_CVST}-${tag}-dev-${JK_BRANCH}-${JK_REV}-src
+elif [ -n "$local_dir" ]
+then
+JK_SVN_URL="$local_dir"
+JK_REV=`svn info ${JK_SVN_URL} | awk '$1 == "Revision:" {print $2}'`
+if [ -z "$JK_REV" ]
+then
+   echo "No Revision found at '$JK_SVN_URL'"
+   exit 3
+fi
+JK_DIST=${JK_CVST}-${tag}-dev-local-${JK_REV}-src
 else
 JK_VER=$tag
 JK_TAG=`echo $tag | sed -e 's#^#JK_#' -e 's#\.#_#g'`



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r543576 - /tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java

[fhanik]

Author: fhanik
Date: Fri Jun  1 11:55:10 2007
New Revision: 543576

URL: http://svn.apache.org/viewvc?view=rev&rev=543576
Log:
added cleanup code

Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java

Modified: tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java?view=diff&rev=543576&r1=543575&r2=543576
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java 
(original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java Fri 
Jun  1 11:55:10 2007
@@ -20,20 +20,20 @@
 import java.io.IOException;
 import java.net.SocketTimeoutException;
 import java.nio.ByteBuffer;
+import java.nio.channels.CancelledKeyException;
+import java.nio.channels.ClosedChannelException;
 import java.nio.channels.SelectionKey;
-import java.util.concurrent.TimeUnit;
-
-import org.apache.tomcat.util.net.NioEndpoint.KeyAttachment;
-import org.apache.tomcat.util.MutableInteger;
 import java.nio.channels.Selector;
+import java.nio.channels.SocketChannel;
+import java.util.Iterator;
 import java.util.concurrent.ConcurrentLinkedQueue;
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.TimeUnit;
+
 import org.apache.juli.logging.Log;
 import org.apache.juli.logging.LogFactory;
-import java.util.Iterator;
-import java.nio.channels.SocketChannel;
-import java.nio.channels.ClosedChannelException;
-import java.nio.channels.CancelledKeyException;
-import java.util.concurrent.CountDownLatch;
+import org.apache.tomcat.util.MutableInteger;
+import org.apache.tomcat.util.net.NioEndpoint.KeyAttachment;
 
 public class NioBlockingSelector {
 
@@ -61,6 +61,7 @@
 if (poller!=null) {
 poller.disable();
 poller.interrupt();
+poller = null;
 }
 }
 
@@ -214,7 +215,12 @@
 sk.interestOps(sk.interestOps() | ops);
 }
 }catch (ClosedChannelException cx) {
-if (sk!=null) sk.cancel();
+if (sk!=null) {
+sk.cancel();
+sk.attach(null);
+if 
(SelectionKey.OP_WRITE==(ops&SelectionKey.OP_WRITE)) 
countDown(key.getWriteLatch());
+if 
(SelectionKey.OP_READ==(ops&SelectionKey.OP_READ))countDown(key.getReadLatch());
+}
 }
 }
 };



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 12428] - request.getUserPrincipal(): Misinterpretation of specification?

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=12428


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|major   |enhancement
Version|4.0.4 Final |Nightly Build




--- Additional Comments From [EMAIL PROTECTED]  2007-06-01 16:42 ---
Having looked at this again, I agree that authenticating the user, if
credentials are present, for a non-protected resource would not be in violation
of the spec. However, the question remains - what to do if that authentication
fails?

Anyway, I am changing this to an enhancement request since the current behaviour
is spec compliant. As ever, patches for review will be welcomed.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 42566] - hangs including jsp with < symbol

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42566


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID




--- Additional Comments From [EMAIL PROTECTED]  2007-06-01 16:47 ---
You need to encode the included '<'

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Gotta submit a Board report this month...

[Yoav Shapira]

Cool, lots of good stuff, thanks.  I'll draft up something and put it
up for review here next week.

Yoav

On 6/1/07, Filip Hanik - Dev Lists <[EMAIL PROTECTED]> wrote:

Rainer Jung wrote:
> - Lots of Tomcat talks at ApacheCon EU Amsterdam (Filip, Mladen)
yes, there was a "tomcat track", a full day of presos around tomcat,
some from non committers as well if I remember correctly

Filip
> - 2 mod_jk releases (1.2.22, 1.2.23), 1.2.23 was a security release
>
> Yoav Shapira wrote:
>> ... by June 18th at the latest, because the Board meeting is on June
>> 20th.  But since I'll be leaving the country on vacation the preceding
>> weekend, our deadline is a bit earlier, let's say June 15th.
>>
>> This is just an early heads-up.  Anyone have comments on what should
>> go in, besides the standard list of releases we've done since the last
>> report?
>>
>> Yoav
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>
>


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r543679 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/servlets/DefaultServlet.java webapps/docs/changelog.xml

[markt]

Author: markt
Date: Fri Jun  1 17:42:19 2007
New Revision: 543679

URL: http://svn.apache.org/viewvc?view=rev&rev=543679
Log:
Fix bug 42497. Include ETag header on 304 response as per RFC2616. Patch 
provided by Len Popp.

Modified:

tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/servlets/DefaultServlet.java
tomcat/container/tc5.5.x/webapps/docs/changelog.xml

Modified: 
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/servlets/DefaultServlet.java
URL: 
http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/servlets/DefaultServlet.java?view=diff&rev=543679&r1=543678&r2=543679
==
--- 
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/servlets/DefaultServlet.java
 (original)
+++ 
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/servlets/DefaultServlet.java
 Fri Jun  1 17:42:19 2007
@@ -1653,6 +1653,8 @@
 // The entity has not been modified since the date
 // specified by the client. This is not an error case.
 response.setStatus(HttpServletResponse.SC_NOT_MODIFIED);
+response.setHeader("ETag", getETag(resourceAttributes));
+
 return false;
 }
 }
@@ -1709,6 +1711,8 @@
 if ( ("GET".equals(request.getMethod()))
  || ("HEAD".equals(request.getMethod())) ) {
 response.setStatus(HttpServletResponse.SC_NOT_MODIFIED);
+response.setHeader("ETag", getETag(resourceAttributes));
+
 return false;
 } else {
 response.sendError

Modified: tomcat/container/tc5.5.x/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/webapps/docs/changelog.xml?view=diff&rev=543679&r1=543678&r2=543679
==
--- tomcat/container/tc5.5.x/webapps/docs/changelog.xml (original)
+++ tomcat/container/tc5.5.x/webapps/docs/changelog.xml Fri Jun  1 17:42:19 2007
@@ -84,6 +84,10 @@
  (markt)
   
   
+ 42497: Ensure ETag header is present in a 304 response.
+ Patch provided by Len Popp. (markt)
+  
+  
  Allow for a forward/include to call getAttributeNames on the Request 
in a sandbox. (billbarker)
   
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r543680 - in /tomcat/tc6.0.x/trunk: java/org/apache/catalina/servlets/DefaultServlet.java webapps/docs/changelog.xml

[markt]

Author: markt
Date: Fri Jun  1 17:42:36 2007
New Revision: 543680

URL: http://svn.apache.org/viewvc?view=rev&rev=543680
Log:
Port fix for bug 42497. Include ETag header on 304 response as per RFC2616. 
Patch provided by Len Popp.

Modified:
tomcat/tc6.0.x/trunk/java/org/apache/catalina/servlets/DefaultServlet.java
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

Modified: 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/servlets/DefaultServlet.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/servlets/DefaultServlet.java?view=diff&rev=543680&r1=543679&r2=543680
==
--- tomcat/tc6.0.x/trunk/java/org/apache/catalina/servlets/DefaultServlet.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/servlets/DefaultServlet.java 
Fri Jun  1 17:42:36 2007
@@ -1014,7 +1014,7 @@
 
 // Vector which will contain all the ranges which are successfully
 // parsed.
-ArrayList result = new ArrayList();
+ArrayList result = new ArrayList();
 StringTokenizer commaTokenizer = new StringTokenizer(rangeHeader, ",");
 
 // Parsing the range list
@@ -1571,6 +1571,8 @@
 // The entity has not been modified since the date
 // specified by the client. This is not an error case.
 response.setStatus(HttpServletResponse.SC_NOT_MODIFIED);
+response.setHeader("ETag", getETag(resourceAttributes));
+
 return false;
 }
 }
@@ -1627,6 +1629,8 @@
 if ( ("GET".equals(request.getMethod()))
  || ("HEAD".equals(request.getMethod())) ) {
 response.setStatus(HttpServletResponse.SC_NOT_MODIFIED);
+response.setHeader("ETag", getETag(resourceAttributes));
+
 return false;
 } else {
 response.sendError

Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml?view=diff&rev=543680&r1=543679&r2=543680
==
--- tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Fri Jun  1 17:42:36 2007
@@ -18,13 +18,8 @@
   
 
   
- 42449:
- JNDIRealm does not catch NullPointerException for Sun's
- LDAP provider (See bug for details) (funkman)
-  
-  
- 42444: prevent NPE for AccessLogValve
- Patch provided by Nils Hammar (funkman)
+ 39875: Fix BPE in RealmBase.init(). Port of yoavs's fix 
from
+ Tomcat 5. (markt)
   
   
  42361: Handle multi-part forms when saving requests during
@@ -35,8 +30,17 @@
  (markt)
   
   
- 39875: Fix BPE in RealmBase.init(). Port of yoavs's fix 
from
- Tomcat 5. (markt)
+ 42444: prevent NPE for AccessLogValve
+ Patch provided by Nils Hammar (funkman)
+  
+  
+ 42449:
+ JNDIRealm does not catch NullPointerException for Sun's
+ LDAP provider (See bug for details) (funkman)
+  
+  
+ 42497: Ensure ETag header is present in a 304 response.
+ Patch provided by Len Popp. (markt)
   
 
   



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r543681 - in /tomcat/tc6.0.x/trunk/java/org/apache/catalina/servlets: CGIServlet.java WebdavServlet.java

[markt]

Author: markt
Date: Fri Jun  1 17:42:59 2007
New Revision: 543681

URL: http://svn.apache.org/viewvc?view=rev&rev=543681
Log:
Fix compiler warnings

Modified:
tomcat/tc6.0.x/trunk/java/org/apache/catalina/servlets/CGIServlet.java
tomcat/tc6.0.x/trunk/java/org/apache/catalina/servlets/WebdavServlet.java

Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/servlets/CGIServlet.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/servlets/CGIServlet.java?view=diff&rev=543681&r1=543680&r2=543681
==
--- tomcat/tc6.0.x/trunk/java/org/apache/catalina/servlets/CGIServlet.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/servlets/CGIServlet.java Fri 
Jun  1 17:42:59 2007
@@ -267,7 +267,7 @@
 static Object expandFileLock = new Object();
 
 /** the shell environment variables to be passed to the CGI script */
-static Hashtable shellEnv = new Hashtable();
+static Hashtable shellEnv = new Hashtable();
 
 /**
  * Sets instance variables.
@@ -644,8 +644,8 @@
  * See http://www.rgagnon.com/javadetails/java-0150.html";>Read 
environment
  * variables from an application for original source and article.
  */
-private Hashtable getShellEnvironment() throws IOException {
-Hashtable envVars = new Hashtable();
+private Hashtable getShellEnvironment() throws IOException {
+Hashtable envVars = new Hashtable();
 Process p = null;
 Runtime r = Runtime.getRuntime();
 String OS = System.getProperty("os.name").toLowerCase();
@@ -729,7 +729,7 @@
 private File workingDirectory = null;
 
 /** cgi command's command line parameters */
-private ArrayList cmdLineParameters = new ArrayList();
+private ArrayList cmdLineParameters = new ArrayList();
 
 /** whether or not this object is valid or not */
 private boolean valid = false;
@@ -961,7 +961,7 @@
  * (apologies to Marv Albert regarding MJ)
  */
 
-Hashtable envp = new Hashtable();
+Hashtable envp = new Hashtable();
 
 // Add the shell environment variables (if any)
 envp.putAll(shellEnv);
@@ -1539,7 +1539,7 @@
  */
 protected String[] hashToStringArray(Hashtable h)
 throws NullPointerException {
-Vector v = new Vector();
+Vector v = new Vector();
 Enumeration e = h.keys();
 while (e.hasMoreElements()) {
 String k = e.nextElement().toString();

Modified: 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/servlets/WebdavServlet.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/servlets/WebdavServlet.java?view=diff&rev=543681&r1=543680&r2=543681
==
--- tomcat/tc6.0.x/trunk/java/org/apache/catalina/servlets/WebdavServlet.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/servlets/WebdavServlet.java 
Fri Jun  1 17:42:59 2007
@@ -174,7 +174,8 @@
  * Key : path 
  * Value : LockInfo
  */
-private Hashtable resourceLocks = new Hashtable();
+private Hashtable resourceLocks =
+new Hashtable();
 
 
 /**
@@ -185,7 +186,8 @@
  * collection. Each element of the Vector is the path associated with
  * the lock-null resource.
  */
-private Hashtable lockNullResources = new Hashtable();
+private Hashtable> lockNullResources =
+new Hashtable>();
 
 
 /**
@@ -194,7 +196,7 @@
  * Key : path 
  * Value : LockInfo
  */
-private Vector collectionLocks = new Vector();
+private Vector collectionLocks = new Vector();
 
 
 /**
@@ -358,7 +360,7 @@
 }
 
 // Properties which are to be displayed.
-Vector properties = null;
+Vector properties = null;
 // Propfind depth
 int depth = INFINITY;
 // Propfind type
@@ -416,7 +418,7 @@
 }
 
 if (type == FIND_BY_PROPERTY) {
-properties = new Vector();
+properties = new Vector();
 NodeList childList = propNode.getChildNodes();
 
 for (int i=0; i < childList.getLength(); i++) {
@@ -504,11 +506,11 @@
 properties);
 } else {
 // The stack always contains the object of the current level
-Stack stack = new Stack();
+Stack stack = new Stack();
 stack.push(path);
 
 // Stack of the objects one level below
-Stack stackBelow = new Stack();
+Stack stackBelow = new Stack();
 
 while ((!stack.isEmpty()) && (depth >= 0)) {
 
@@ -567,7 +569,7 @@
 if (stack.isEmpty()) {
 depth--;
 stack = stackBelow;
-stackBelow = new Stack();
+

DO NOT REPLY [Bug 42497] - 304 response should consistently include ETag header

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42497


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2007-06-01 18:01 ---
Thanks for the patch. It has been applied to svn and will be in 5.5.24 and
6.0.14 onwards.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 27122] - IE plugins cannot access components through Tomcat 5 over SSL

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27122


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |enhancement




--- Additional Comments From [EMAIL PROTECTED]  2007-06-01 18:09 ---
The current behaviour is unlikely to change. I am marking this as an enhancement
rather than WONTFIX in case someone cares enough to come up with a proposed 
patch.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 30028] - session attributes Map may become inconsistent start causing "strange" problems

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=30028


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2007-06-01 18:11 ---
This was fixed quite some time ago.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r543691 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/realm/

[markt]

Author: markt
Date: Fri Jun  1 18:37:08 2007
New Revision: 543691

URL: http://svn.apache.org/viewvc?view=rev&rev=543691
Log:
Fix compiler warnings in o.a.c.realm

Modified:
tomcat/tc6.0.x/trunk/java/org/apache/catalina/realm/DataSourceRealm.java
tomcat/tc6.0.x/trunk/java/org/apache/catalina/realm/GenericPrincipal.java
tomcat/tc6.0.x/trunk/java/org/apache/catalina/realm/JAASCallbackHandler.java

tomcat/tc6.0.x/trunk/java/org/apache/catalina/realm/JAASMemoryLoginModule.java
tomcat/tc6.0.x/trunk/java/org/apache/catalina/realm/JAASRealm.java
tomcat/tc6.0.x/trunk/java/org/apache/catalina/realm/JDBCRealm.java
tomcat/tc6.0.x/trunk/java/org/apache/catalina/realm/JNDIRealm.java
tomcat/tc6.0.x/trunk/java/org/apache/catalina/realm/MemoryRealm.java
tomcat/tc6.0.x/trunk/java/org/apache/catalina/realm/UserDatabaseRealm.java

Modified: 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/realm/DataSourceRealm.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/realm/DataSourceRealm.java?view=diff&rev=543691&r1=543690&r2=543691
==
--- tomcat/tc6.0.x/trunk/java/org/apache/catalina/realm/DataSourceRealm.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/realm/DataSourceRealm.java 
Fri Jun  1 18:37:08 2007
@@ -345,7 +345,7 @@
 return (null);
 }
 
-ArrayList list = getRoles(dbConnection, username);
+ArrayList list = getRoles(dbConnection, username);
 
 // Create and return a suitable Principal for this user
 return (new GenericPrincipal(this, username, credentials, list));
@@ -527,17 +527,17 @@
  * @param dbConnection The database connection to be used
  * @param username Username for which roles should be retrieved
  */
-protected ArrayList getRoles(Connection dbConnection,
+protected ArrayList getRoles(Connection dbConnection,
  String username) {

 ResultSet rs = null;
 PreparedStatement stmt = null;
-ArrayList list = null;
+ArrayList list = null;

 try {
stmt = roles(dbConnection, username);
rs = stmt.executeQuery();
-   list = new ArrayList();
+   list = new ArrayList();

while (rs.next()) {
String role = rs.getString(1);

Modified: 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/realm/GenericPrincipal.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/realm/GenericPrincipal.java?view=diff&rev=543691&r1=543690&r2=543691
==
--- tomcat/tc6.0.x/trunk/java/org/apache/catalina/realm/GenericPrincipal.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/realm/GenericPrincipal.java 
Fri Jun  1 18:37:08 2007
@@ -65,7 +65,7 @@
  * @param roles List of roles (must be Strings) possessed by this user
  */
 public GenericPrincipal(Realm realm, String name, String password,
-List roles) {
+List roles) {
 this(realm, name, password, roles, null);
 }
 
@@ -82,7 +82,7 @@
  *getUserPrincipal call if not null; if null, this will be returned
  */
 public GenericPrincipal(Realm realm, String name, String password,
-List roles, Principal userPrincipal) {
+List roles, Principal userPrincipal) {
 
 super();
 this.realm = realm;

Modified: 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/realm/JAASCallbackHandler.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/realm/JAASCallbackHandler.java?view=diff&rev=543691&r1=543690&r2=543691
==
--- 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/realm/JAASCallbackHandler.java 
(original)
+++ 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/realm/JAASCallbackHandler.java 
Fri Jun  1 18:37:08 2007
@@ -27,8 +27,6 @@
 import javax.security.auth.callback.UnsupportedCallbackException;
 
 import org.apache.catalina.util.StringManager;
-import org.apache.juli.logging.Log;
-import org.apache.juli.logging.LogFactory;
 
 /**
  * Implementation of the JAAS CallbackHandler interface,
@@ -49,7 +47,6 @@
  */
 
 public class JAASCallbackHandler implements CallbackHandler {
-private static Log log = LogFactory.getLog(JAASCallbackHandler.class);
 
 //  Constructor
 

Modified: 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/realm/JAASMemoryLoginModule.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/realm/JAASMemoryLoginModule.java?view=diff&rev=543691&r1=543690&r2=543691
=

svn commit: r543692 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/realm/JNDIRealm.java webapps/docs/changelog.xml

[markt]

Author: markt
Date: Fri Jun  1 18:41:58 2007
New Revision: 543692

URL: http://svn.apache.org/viewvc?view=rev&rev=543692
Log:
Fix 33774. Retry on ServiceUnavailableException

Modified:

tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/realm/JNDIRealm.java
tomcat/container/tc5.5.x/webapps/docs/changelog.xml

Modified: 
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/realm/JNDIRealm.java
URL: 
http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/realm/JNDIRealm.java?view=diff&rev=543692&r1=543691&r2=543692
==
--- 
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/realm/JNDIRealm.java
 (original)
+++ 
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/realm/JNDIRealm.java
 Fri Jun  1 18:41:58 2007
@@ -35,6 +35,7 @@
 import javax.naming.NameParser;
 import javax.naming.Name;
 import javax.naming.AuthenticationException;
+import javax.naming.ServiceUnavailableException;
 import javax.naming.directory.Attribute;
 import javax.naming.directory.Attributes;
 import javax.naming.directory.DirContext;
@@ -809,6 +810,21 @@
 principal = authenticate(context, username, credentials);
 
 } catch (CommunicationException e) {
+
+// log the exception so we know it's there.
+containerLog.warn(sm.getString("jndiRealm.exception"), e);
+
+// close the connection so we know it will be reopened.
+if (context != null)
+close(context);
+
+// open a new directory context.
+context = open();
+
+// Try the authentication again.
+principal = authenticate(context, username, credentials);
+
+} catch (ServiceUnavailableException e) {
 
 // log the exception so we know it's there.
 containerLog.warn(sm.getString("jndiRealm.exception"), e);

Modified: tomcat/container/tc5.5.x/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/webapps/docs/changelog.xml?view=diff&rev=543692&r1=543691&r2=543692
==
--- tomcat/container/tc5.5.x/webapps/docs/changelog.xml (original)
+++ tomcat/container/tc5.5.x/webapps/docs/changelog.xml Fri Jun  1 18:41:58 2007
@@ -28,6 +28,11 @@
   
 
   
+33774 Retry JNDI authentiction on 
ServiceUnavailableException
+as at least one provider throws this after an idle connection has been
+closed. (markt)
+  
+  
 40593 Cleanup that Listener stop after Manager stop 
 at StandardContext.stop(). Patch by Suzuki Yuichiro (pero)
   



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r543693 - in /tomcat/tc6.0.x/trunk: java/org/apache/catalina/realm/JNDIRealm.java webapps/docs/changelog.xml

[markt]

Author: markt
Date: Fri Jun  1 18:42:17 2007
New Revision: 543693

URL: http://svn.apache.org/viewvc?view=rev&rev=543693
Log:
Port fix for 33774. Retry on ServiceUnavailableException

Modified:
tomcat/tc6.0.x/trunk/java/org/apache/catalina/realm/JNDIRealm.java
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/realm/JNDIRealm.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/realm/JNDIRealm.java?view=diff&rev=543693&r1=543692&r2=543693
==
--- tomcat/tc6.0.x/trunk/java/org/apache/catalina/realm/JNDIRealm.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/realm/JNDIRealm.java Fri Jun  
1 18:42:17 2007
@@ -35,6 +35,7 @@
 import javax.naming.NameParser;
 import javax.naming.Name;
 import javax.naming.AuthenticationException;
+import javax.naming.ServiceUnavailableException;
 import javax.naming.directory.Attribute;
 import javax.naming.directory.Attributes;
 import javax.naming.directory.DirContext;
@@ -826,6 +827,21 @@
 principal = authenticate(context, username, credentials);
 
 } catch (CommunicationException e) {
+
+// log the exception so we know it's there.
+containerLog.warn(sm.getString("jndiRealm.exception"), e);
+
+// close the connection so we know it will be reopened.
+if (context != null)
+close(context);
+
+// open a new directory context.
+context = open();
+
+// Try the authentication again.
+principal = authenticate(context, username, credentials);
+
+} catch (ServiceUnavailableException e) {
 
 // log the exception so we know it's there.
 containerLog.warn(sm.getString("jndiRealm.exception"), e);

Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml?view=diff&rev=543693&r1=543692&r2=543693
==
--- tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Fri Jun  1 18:42:17 2007
@@ -18,6 +18,11 @@
   
 
   
+33774 Retry JNDI authentiction on 
ServiceUnavailableException
+as at least one provider throws this after an idle connection has been
+closed. (markt)
+  
+  
  39875: Fix BPE in RealmBase.init(). Port of yoavs's fix 
from
  Tomcat 5. (markt)
   



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 33774] - JNDIRealm fails when server disconnects after time

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33774


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2007-06-01 18:42 ---
This has been fixed in svn and will be included in 5.5.24 and 6.0.14 onwards.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 34509] - tag names that are xml:Name but not java identifier are not accepted

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34509


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2007-06-01 18:43 ---
See #2

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 38261] - XML validation fails when war-files with libraries are not unpacked

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38261


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID




--- Additional Comments From [EMAIL PROTECTED]  2007-06-01 19:07 ---
Your schema declaration in web.xml is incorrect.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 38836] - java.io.IOException when reading data

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38836


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution||DUPLICATE




--- Additional Comments From [EMAIL PROTECTED]  2007-06-01 19:09 ---
No further comments from OP. Assuming it was a duplicate and is now fixed.

*** This bug has been marked as a duplicate of 38346 ***

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 38346] - InputBuffer breaks request.readLine()

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38346


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2007-06-01 19:09 ---
*** Bug 38836 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r543696 - /tomcat/jasper/tc5.5.x/src/share/org/apache/jasper/compiler/ELFunctionMapper.java

[markt]

Author: markt
Date: Fri Jun  1 19:17:28 2007
New Revision: 543696

URL: http://svn.apache.org/viewvc?view=rev&rev=543696
Log:
Minor code clean up

Modified:

tomcat/jasper/tc5.5.x/src/share/org/apache/jasper/compiler/ELFunctionMapper.java

Modified: 
tomcat/jasper/tc5.5.x/src/share/org/apache/jasper/compiler/ELFunctionMapper.java
URL: 
http://svn.apache.org/viewvc/tomcat/jasper/tc5.5.x/src/share/org/apache/jasper/compiler/ELFunctionMapper.java?view=diff&rev=543696&r1=543695&r2=543696
==
--- 
tomcat/jasper/tc5.5.x/src/share/org/apache/jasper/compiler/ELFunctionMapper.java
 (original)
+++ 
tomcat/jasper/tc5.5.x/src/share/org/apache/jasper/compiler/ELFunctionMapper.java
 Fri Jun  1 19:17:28 2007
@@ -32,7 +32,6 @@
 
 public class ELFunctionMapper {
 static private int currFunc = 0;
-private ErrorDispatcher err;
 StringBuffer ds;  // Contains codes to initialize the functions mappers.
 StringBuffer ss;  // Contains declarations of the functions mappers.
 
@@ -47,7 +46,6 @@
 
currFunc = 0;
ELFunctionMapper map = new ELFunctionMapper();
-   map.err = compiler.getErrorDispatcher();
map.ds = new StringBuffer();
map.ss = new StringBuffer();
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]