Re: Releasing mod_jk 1.2.21

[Rainer Jung]

What is still open:

A Henri's core dumps on iSeries
B The other user with protocol corruption on AIX for worker MPM
C Porting 41439 from IIS to Apache

and maybe

D New design of interaction of mod_jk ForwardDirectories and httpd 
DirectoryIndex (BZ 41430, BZ 36121)

E BZ 41330/40310
F Investigation, if it would be easy to allow Apache to send ErrorPages 
instead of Tomcat (centralized error page management).


I would like to give A-C a chance until end of the week and would then 
inform the list on monday, give a couple of days for reviewing on p.a.o 
and tag around Feb, 28, so that we can have a voted release around the 
first March weekend. Does that sound good?


Regards,

Rainer

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Releasing mod_jk 1.2.21

[Mladen Turk]

Rainer Jung wrote:

What is still open:


I would like to give A-C a chance until end of the week and would then 


This week or a next?
We have a Security issue that requires release ASAP.

Regards,
Mladen.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r510902 - /tomcat/connectors/trunk/jk/native/iis/jk_isapi_plugin.c

[mturk]

Author: mturk
Date: Fri Feb 23 02:54:28 2007
New Revision: 510902

URL: http://svn.apache.org/viewvc?view=rev&rev=510902
Log:
TAB police

Modified:
tomcat/connectors/trunk/jk/native/iis/jk_isapi_plugin.c

Modified: tomcat/connectors/trunk/jk/native/iis/jk_isapi_plugin.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/iis/jk_isapi_plugin.c?view=diff&rev=510902&r1=510901&r2=510902
==
--- tomcat/connectors/trunk/jk/native/iis/jk_isapi_plugin.c (original)
+++ tomcat/connectors/trunk/jk/native/iis/jk_isapi_plugin.c Fri Feb 23 02:54:28 
2007
@@ -1003,7 +1003,7 @@
 jk_log(logger, JK_LOG_DEBUG,
"[%s] is not a servlet url", uri);
 if (strip_session) {
-   char *jsessionid = strstr(uri, 
JK_PATH_SESSION_IDENTIFIER);
+char *jsessionid = strstr(uri, JK_PATH_SESSION_IDENTIFIER);
 if (jsessionid) {
 if (JK_IS_DEBUG_LEVEL(logger))
 jk_log(logger, JK_LOG_DEBUG,



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Releasing mod_jk 1.2.21

[Jean-Frederic]

On Fri, 2007-02-23 at 09:20 +0100, Rainer Jung wrote:
> What is still open:
> 
> A Henri's core dumps on iSeries

Wasn't it only a wrong printf?

> B The other user with protocol corruption on AIX for worker MPM

Is there are bugzilla number for this one?

> C Porting 41439 from IIS to Apache

You want to remove sessionid=D5E2FE08F02400159DFD6231
11F98FEE.p-ng-ptom2 from 
/shoppingcc/img/btn_nav_main_login.gif;jsessionid=D5E2FE08F02400159DFD6231
11F98FEE.p-ng-ptom2
do it with mod_rewrite:
RewriteRule ^/(.*).gif;jsessionid=.*$ /$1.gif [PT]

Cheers

Jean-Frederic

> and maybe
> 
> D New design of interaction of mod_jk ForwardDirectories and httpd 
> DirectoryIndex (BZ 41430, BZ 36121)
> E BZ 41330/40310
> F Investigation, if it would be easy to allow Apache to send
> ErrorPages 
> instead of Tomcat (centralized error page management).
> 
> I would like to give A-C a chance until end of the week and would
> then 
> inform the list on monday, give a couple of days for reviewing on
> p.a.o 
> and tag around Feb, 28, so that we can have a voted release around
> the 
> first March weekend. Does that sound good?
> 
> Regards,
> 
> Rainer 


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Releasing mod_jk 1.2.21

[Mladen Turk]

Jean-Frederic wrote:

C Porting 41439 from IIS to Apache


You want to remove sessionid=D5E2FE08F02400159DFD6231
11F98FEE.p-ng-ptom2 from 
/shoppingcc/img/btn_nav_main_login.gif;jsessionid=D5E2FE08F02400159DFD6231
11F98FEE.p-ng-ptom2
do it with mod_rewrite:
RewriteRule ^/(.*).gif;jsessionid=.*$ /$1.gif [PT]



Right. Since Apache has mod_rewrite, use that instead.
IIS comes with no mod_rewrite surrogate so strip_session
makes sense as a workaround.

Regards,
Mladen.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Releasing mod_jk 1.2.21

[Mladen Turk]

Rainer Jung wrote:


D New design of interaction of mod_jk ForwardDirectories and httpd 
DirectoryIndex (BZ 41430, BZ 36121)


As I said so many times, any attempt to from DirectoryIndex
that will force serving something that is not part of
the Tomcat's welcome file list will be vetoed.

I would support only the complete removal of the
entire stat logic and leave that entirely to Tomcat.
IMO, the entire DirectoryIndex is complete breakage of
the Servlet API, as I said so many times on the so
many BZ reports having the same subject.

Regards,
Mladen.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 40909] - High CPU Usage When Using mod_jk or mod_proxy_ajp connectors

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40909





--- Additional Comments From [EMAIL PROTECTED]  2007-02-23 04:29 ---
I just bumped into this very same problem.
I also fixed it by switching to tcnative dll 1.1.8 (from whatever version was 
included with Tomcat 5.5.20)

My working config is:
Tomcat 5.5.20 + tcnative 1.1.8
IIS 6.0
isapi_redirect.dll 1.2.20
Windows 2003 server
jdk1.4.2_12

Best regards,

Dick Zetterberg
http://www.comers.se

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r510933 - /tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java

[fhanik]

Author: fhanik
Date: Fri Feb 23 04:58:49 2007
New Revision: 510933

URL: http://svn.apache.org/viewvc?view=rev&rev=510933
Log:
When a read or write times out, make sure the key is deregistered with the 
poller

Modified:

tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java

Modified: 
tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java?view=diff&rev=510933&r1=510932&r2=510933
==
--- 
tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java 
(original)
+++ 
tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java 
Fri Feb 23 04:58:49 2007
@@ -41,7 +41,7 @@
  * @throws IOException if an IO Exception occurs in the underlying socket 
logic
  */
 public static int write(ByteBuffer buf, NioChannel socket, long 
writeTimeout) throws IOException {
-final SelectionKey key = 
socket.getIOChannel().keyFor(socket.getPoller().getSelector());
+SelectionKey key = 
socket.getIOChannel().keyFor(socket.getPoller().getSelector());
 int written = 0;
 boolean timedout = false;
 int keycount = 1; //assume we can write
@@ -86,18 +86,22 @@
 if (timedout) 
 throw new SocketTimeoutException();
 } finally {
-//if (key != null) {
-//socket.getPoller().addEvent(
-//new Runnable() {
-//public void run() {
-//key.cancel();
-//}
-//});
-//}
+if (timedout && key != null) {
+cancelKey(socket, key);
+}
 }
 return written;
 }
 
+private static void cancelKey(final NioChannel socket, final SelectionKey 
key) {
+socket.getPoller().addEvent(
+new Runnable() {
+public void run() {
+key.cancel();
+}
+});
+}
+
 /**
  * Performs a blocking read using the bytebuffer for data to be read
  * If the selector parameter is null, then it will perform a 
busy read that could
@@ -149,14 +153,9 @@
 if (timedout)
 throw new SocketTimeoutException();
 } finally {
-//if (key != null) {
-//socket.getPoller().addEvent(
-//new Runnable() {
-//public void run() {
-//key.cancel();
-//}
-//});
-//}
+if (timedout && key != null) {
+cancelKey(socket,key);
+}
 }
 return read;
 }



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [VOTE] Release build 5.5.22

[Jim Jagielski]

On Feb 18, 2007, at 12:06 PM, Filip Hanik - Dev Lists wrote:

Candidate binaries are available here: http://people.apache.org/ 
~fhanik/tomcat/tomcat-5.5/v5.5.22/


According to the (slightly) updated release process, the 5.5.22 tag  
is:

[ ] Broken
[ ] Alpha
[ ] Beta
[X] Stable


Stable

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Releasing mod_jk 1.2.21

[Rainer Jung]

Mladen Turk wrote:

Rainer Jung wrote:

What is still open:


I would like to give A-C a chance until end of the week and would then 


This week or a next?
We have a Security issue that requires release ASAP.


This week.

I would be interested in the Security issue. If appropriate use direct 
communication.




Regards,
Mladen.


Regards,

Rainer

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Releasing mod_jk 1.2.21

[Rainer Jung]

Jean-Frederic wrote:

On Fri, 2007-02-23 at 09:20 +0100, Rainer Jung wrote:

What is still open:

A Henri's core dumps on iSeries


Wasn't it only a wrong printf?


I doubt that very much, at the stack in his core didn't point to these 
statements. I'm still waiting for feedback from Henri.



B The other user with protocol corruption on AIX for worker MPM


Is there are bugzilla number for this one?


No, he participated in the mail thread started by Henri on the iSeries 
core dump.



C Porting 41439 from IIS to Apache


You want to remove sessionid=D5E2FE08F02400159DFD6231
11F98FEE.p-ng-ptom2 from 
/shoppingcc/img/btn_nav_main_login.gif;jsessionid=D5E2FE08F02400159DFD6231
11F98FEE.p-ng-ptom2
do it with mod_rewrite:
RewriteRule ^/(.*).gif;jsessionid=.*$ /$1.gif [PT]


Of course I know, but you need to coordinate with your Jkmounts, so you 
need to duplicate your rules to detect static URLs between mod_jk and 
mod_rewrite. Anyhow the feature is not high on my list and I actually 
dropped it for 1.2.21.


Regards,

Rainer

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Releasing mod_jk 1.2.21

[Rainer Jung]

Mladen Turk wrote:

Rainer Jung wrote:


D New design of interaction of mod_jk ForwardDirectories and httpd 
DirectoryIndex (BZ 41430, BZ 36121)


As I said so many times, any attempt to from DirectoryIndex
that will force serving something that is not part of
the Tomcat's welcome file list will be vetoed.

I would support only the complete removal of the
entire stat logic and leave that entirely to Tomcat.
IMO, the entire DirectoryIndex is complete breakage of
the Servlet API, as I said so many times on the so
many BZ reports having the same subject.

Regards,
Mladen.


Yes, but then you ignore the fact, that we already have such a 
functionality, and that we changed it's behaviour between 1.2.19 and 
1.2.20. So at least we need to decide, if it's behaviour should be


- like 1.2.19
- like 1.2.20
- disabled completely (breaking existing configs for all versions)
- define it newly and then implement what's defined

Regards,

Rainer

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Releasing mod_jk 1.2.21

[Mladen Turk]

Rainer Jung wrote:

Jean-Frederic wrote:

On Fri, 2007-02-23 at 09:20 +0100, Rainer Jung wrote:

What is still open:

A Henri's core dumps on iSeries


Wasn't it only a wrong printf?


I doubt that very much, at the stack in his core didn't point to these 
statements. I'm still waiting for feedback from Henri.



B The other user with protocol corruption on AIX for worker MPM


Is there are bugzilla number for this one?


No, he participated in the mail thread started by Henri on the iSeries 
core dump.



C Porting 41439 from IIS to Apache


You want to remove sessionid=D5E2FE08F02400159DFD6231
11F98FEE.p-ng-ptom2 from 
/shoppingcc/img/btn_nav_main_login.gif;jsessionid=D5E2FE08F02400159DFD6231 


11F98FEE.p-ng-ptom2
do it with mod_rewrite:
RewriteRule ^/(.*).gif;jsessionid=.*$ /$1.gif [PT]


Of course I know, but you need to coordinate with your Jkmounts, so you 
need to duplicate your rules to detect static URLs between mod_jk and 
mod_rewrite. Anyhow the feature is not high on my list and I actually 
dropped it for 1.2.21.


I have the patch for that with new directive
JkStripSession On|Off definable per vhost

Regards,
Mladen.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Releasing mod_jk 1.2.21

[Mladen Turk]

Rainer Jung wrote:


Yes, but then you ignore the fact, that we already have such a 
functionality, and that we changed it's behaviour between 1.2.19 and 
1.2.20. So at least we need to decide, if it's behaviour should be


- disabled completely (breaking existing configs for all versions)


My favorite :)

The point is that using DirectoryIndex one can
force for example that index.jsp is served as default
welcome file.

However, the web application might have different
thoughts on that subject in web.xml, and then your
web application doesn't behave like it should.
In fact with that you are breaking the Servlet spec,
because something gets served outside the config.
So, you must edit httpd.conf in parallel with web.xml
(very bogus and cumbersome).

Also the usage of the DirectoryIndex is possible
*only* and *only when* you have a physical access to
the web application's directory tree, meaning that
this is limited to the negligible number of deployments
where you have both Apache and Tomcat on the same box.

And as last, DirectoryIndex doesn't allow you to do
anything you cannot do with web.xml and 
except breaking it.

Regards,
Mladen.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Releasing mod_jk 1.2.21

[Jean-Frederic]

I also  have the pending patch... To prevent typos in the properties no
beeing detected what starting httpd.

Should I include it?

Cheers

Jean-Frederic
Index: apache-1.3/mod_jk.c
===
--- apache-1.3/mod_jk.c	(revision 510645)
+++ apache-1.3/mod_jk.c	(working copy)
@@ -2512,8 +2512,8 @@
 ap_log_error(APLOG_MARK, APLOG_EMERG, s,
  "No worker file and no worker options in httpd.conf "
  "use JkWorkerFile to set workers");
-return;
 }
+jk_error_exit(APLOG_MARK, APLOG_EMERG, s, p, "Error in reading worker properties");
 
 }
 #if MODULE_MAGIC_NUMBER >= 19980527
Index: common/jk_map.c
===
--- common/jk_map.c	(revision 510645)
+++ common/jk_map.c	(working copy)
@@ -365,6 +365,13 @@
 trim(v);
 if (strlen(v) && strlen(prp)) {
 const char *oldv = jk_map_get_string(m, prp, NULL);
+if (!jk_is_valid_property(prp)) {
+jk_log(l, JK_LOG_ERROR,
+   "The attribute '%s' is not supported - please check"
+   " the documentation for the supported attributes.",
+   prp);
+return JK_FALSE;
+}
 if (jk_is_deprecated_property(prp)) {
 jk_log(l, JK_LOG_WARNING,
"The attribute '%s' is deprecated - please check"
Index: common/jk_util.c
===
--- common/jk_util.c	(revision 510645)
+++ common/jk_util.c	(working copy)
@@ -96,7 +96,9 @@
 
 #define DEFAULT_WORKER  JK_AJP13_WORKER_NAME
 #define WORKER_LIST_PROPERTY_NAME ("worker.list")
+#define LIST_PROPERTY_NAME("list")
 #define WORKER_MAINTAIN_PROPERTY_NAME ("worker.maintain")
+#define MAINTAIN_PROPERTY_NAME("maintain")
 #define DEFAULT_MAINTAIN_TIME   (60)
 #define DEFAULT_LB_FACTOR   (1)
 #define DEFAULT_DISTANCE(0)
@@ -209,6 +211,70 @@
 NULL
 };
 
+static const char *supported_properties[] = {
+SYSPROPS_OF_WORKER,
+STDERR_OF_WORKER,
+STDOUT_OF_WORKER,
+SECRET_OF_WORKER,
+MX_OF_WORKER,
+MS_OF_WORKER,
+CP_OF_WORKER,
+BRIDGE_OF_WORKER,
+JVM_OF_WORKER,
+LIBPATH_OF_WORKER,
+CMD_LINE_OF_WORKER,
+NATIVE_LIB_OF_WORKER,
+HOST_OF_WORKER,
+PORT_OF_WORKER,
+TYPE_OF_WORKER,
+CACHE_OF_WORKER_DEPRECATED,
+CACHE_OF_WORKER,
+CACHE_OF_WORKER_MIN,
+CACHE_TIMEOUT_DEPRECATED,
+CACHE_TIMEOUT_OF_WORKER,
+RECOVERY_OPTS_OF_WORKER,
+CONNECT_TIMEOUT_OF_WORKER,
+PREPOST_TIMEOUT_OF_WORKER,
+REPLY_TIMEOUT_OF_WORKER,
+SOCKET_TIMEOUT_OF_WORKER,
+SOCKET_BUFFER_OF_WORKER,
+SOCKET_KEEPALIVE_OF_WORKER,
+RECYCLE_TIMEOUT_DEPRECATED,
+LOAD_FACTOR_OF_WORKER,
+DISTANCE_OF_WORKER,
+BALANCED_WORKERS_DEPRECATED,
+BALANCE_WORKERS,
+STICKY_SESSION,
+STICKY_SESSION_FORCE,
+JVM_ROUTE_OF_WORKER_DEPRECATED,
+ROUTE_OF_WORKER,
+DOMAIN_OF_WORKER,
+REDIRECT_OF_WORKER,
+MOUNT_OF_WORKER,
+METHOD_OF_WORKER,
+LOCK_OF_WORKER,
+IS_WORKER_DISABLED_DEPRECATED,
+IS_WORKER_STOPPED_DEPRECATED,
+ACTIVATION_OF_WORKER,
+WORKER_RECOVER_TIME,
+WORKER_MAX_PACKET_SIZE,
+STYLE_SHEET_OF_WORKER,
+NAMESPACE_OF_WORKER,
+XML_NAMESPACE_OF_WORKER,
+XML_DOCTYPE_OF_WORKER,
+PROP_PREFIX_OF_WORKER,
+READ_ONLY_OF_WORKER,
+USER_OF_WORKER,
+USER_CASE_OF_WORKER,
+GOOD_RATING_OF_WORKER,
+BAD_RATING_OF_WORKER,
+SECRET_KEY_OF_WORKER,
+RETRIES_OF_WORKER,
+STATUS_FAIL_OF_WORKER,
+LIST_PROPERTY_NAME,
+MAINTAIN_PROPERTY_NAME
+};
+
 /* All entries need to have fixed length 8 chars! */
 static const char *jk_level_verbs[] = {
 "[" JK_LOG_TRACE_VERB "] ",
@@ -1454,6 +1520,37 @@
 }
 return JK_FALSE;
 }
+/*
+ * Check that property is a valid one (to prevent user typos).
+ */
+int jk_is_valid_property(const char *prp_name)
+{
+const char **props = &list_properties[0];
+while (*props) {
+if (jk_is_some_property(prp_name, *props, "."))
+return JK_TRUE;
+props++;
+}
+props = &unique_properties[0];
+while (*props) {
+if (jk_is_some_property(prp_name, *props, "."))
+return JK_TRUE;
+props++;
+}
+props = &deprecated_properties[0];
+while (*props) {
+if (jk_is_some_property(prp_name, *props, "."))
+return JK_TRUE;
+props++;
+}
+props = &supported_properties[0];
+while (*props) {
+if (jk_is_some_property(prp_name, *props, "."))
+return JK_TRUE;
+props++;
+}
+return JK_FALSE;
+}
 
 int jk_get_worker_stdout(jk_map_t *m, const char *wname, const char **stdout_name)
 {
Index: apache-2.0/mod_jk.c
===

Re: Releasing mod_jk 1.2.21

[Mladen Turk]

Jean-Frederic wrote:

I also  have the pending patch... To prevent typos in the properties no
beeing detected what starting httpd.

Should I include it?



Looks like a good feature for unexperienced admins :)
+1

Regards,
Mladen.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Releasing mod_jk 1.2.21

[Rainer Jung]

I like it too. It was always a weakness, that workers.properties typos
get through unnoticed. It will be interesting to find out that way, how
many users have configs that actually don't work...

I didn't read the patch in detail: will it be compatible with the
existing macro feature

myvar=someValue
worker.something.attribute=$(myvar)

There are zillions of old default config files including the deprecated

ps=/
...

(it's even still in our docs)

and we will get a lot of bug reports, if we break those.
So I think all in all we should only check attributes beginning with
"worker.".

Regards,

Rainer

Mladen Turk schrieb:
> Jean-Frederic wrote:
>> I also  have the pending patch... To prevent typos in the properties no
>> beeing detected what starting httpd.
>>
>> Should I include it?
>>
> 
> Looks like a good feature for unexperienced admins :)
> +1
> 
> Regards,
> Mladen.
> 
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Releasing mod_jk 1.2.21

[Mladen Turk]

Rainer Jung wrote:


and we will get a lot of bug reports, if we break those.
So I think all in all we should only check attributes beginning with
"worker.".



Right, good point. After all this is what matters.

Regards,
Mladen.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [VOTE] Release build 6.0.10

[Remy Maucherat]

Mark Thomas wrote:

Remy Maucherat wrote:

According to the (slightly) updated release process, the 6.0.10 tag is:
[ ] Broken
[ ] Alpha
[ ] Beta
[X] Stable

So far, there are 3 binding votes for stable (with one from an inactive
committer), and 1 for beta. While a beta or stable release could legaly
be made, I don't feel comfortable with it without more votes.


In my usage to date I haven't found any issues that prevent it being
stable.


Ok, so with the additional votes, I think 6.0.10 may reasonably be 
called stable :)


Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 41563] - Processing result of mod_jk for Apache2.0.x is unexpected, differs from the one for Apache1.3.x.

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41563





--- Additional Comments From [EMAIL PROTECTED]  2007-02-23 16:23 ---
Hi, 
We also have Apache2.0.59, and we just upgraded mod_jk from 1.2.15 to 1.2.20.
After upgrade, the web servers crashed few times causing major production
issues, so we had to roll back mod_jk. We still don't know exactly why, but we
were also seeing "-" value as well assuming Taka is referring to the same.

[22/Feb/2007:20:37:58 -0800] "HEAD /index.html HTTP/1.0" 200 - "-" "Mozilla/4.06
[en] (WinNT; I)"
[22/Feb/2007:20:38:03 -0800] "HEAD /index.html HTTP/1.0" 200 - "-" "Mozilla/4.06
[en] (WinNT; I)"
[22/Feb/2007:20:38:08 -0800] "HEAD /index.html HTTP/1.0" 200 - "-" "Mozilla/4.06
[en] (WinNT; I)"
[22/Feb/2007:20:38:13 -0800] "HEAD /index.html HTTP/1.0" 200 - "-" "Mozilla/4.06
[en] (WinNT; I)"

Is this known issue? We would like to have features on 1.2.20. What's
recommendation here?

Thanks.
-rc


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r511227 - in /tomcat/connectors/trunk/jk: native/apache-1.3/mod_jk.c native/apache-2.0/mod_jk.c native/iis/jk_isapi_plugin.c xdocs/miscellaneous/changelog.xml xdocs/reference/apache.xml

[mturk]

Author: mturk
Date: Fri Feb 23 22:50:05 2007
New Revision: 511227

URL: http://svn.apache.org/viewvc?view=rev&rev=511227
Log:
Fix 41439 for Apache servers by adding JkStripSession directive.

Modified:
tomcat/connectors/trunk/jk/native/apache-1.3/mod_jk.c
tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c
tomcat/connectors/trunk/jk/native/iis/jk_isapi_plugin.c
tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml
tomcat/connectors/trunk/jk/xdocs/reference/apache.xml

Modified: tomcat/connectors/trunk/jk/native/apache-1.3/mod_jk.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/apache-1.3/mod_jk.c?view=diff&rev=511227&r1=511226&r2=511227
==
--- tomcat/connectors/trunk/jk/native/apache-1.3/mod_jk.c (original)
+++ tomcat/connectors/trunk/jk/native/apache-1.3/mod_jk.c Fri Feb 23 22:50:05 
2007
@@ -174,6 +174,7 @@
 int options;
 int exclude_options;
 
+int strip_session;
 /*
  * Environment variables support
  */
@@ -1118,6 +1119,25 @@
 return NULL;
 }
 
+/*
+ * JkStripSession directive handling
+ *
+ * JkStripSession On/Off
+ */
+
+static const char *jk_set_strip_session(cmd_parms * cmd, void *dummy, int flag)
+{
+server_rec *s = cmd->server;
+jk_server_conf_t *conf =
+(jk_server_conf_t *) ap_get_module_config(s->module_config,
+  &jk_module);
+
+/* Set up our value */
+conf->strip_session = flag ? JK_TRUE : JK_FALSE;
+
+return NULL;
+}
+
 /*
  *
  * Actually logging.
@@ -1791,6 +1811,13 @@
  "Should the base server mounts be copied to the virtual server"},
 
 /*
+ * JkStripSession specifies if mod_jk should strip the ;jsessionid
+ * from the unmapperd urls
+ */
+{"JkStripSession", jk_set_strip_session, NULL, RSRC_CONF, FLAG,
+ "Should the base server strip the jsessionid from the url"},
+
+/*
  * JkLogFile & JkLogLevel specifies to where should the plugin log
  * its information and how much.
  * JkLogStampFormat specify the time-stamp to be used on log
@@ -2128,6 +2155,7 @@
 c->cipher_indicator = NULL;
 c->session_indicator = NULL;
 c->key_size_indicator = NULL;
+c->strip_session = JK_UNSET;
 } else {
 c->mount_file_reload = JK_URIMAP_DEF_RELOAD;
 c->log_level = JK_LOG_DEF_LEVEL;
@@ -2147,6 +2175,7 @@
 c->cipher_indicator = JK_ENV_CIPHER;
 c->session_indicator = JK_ENV_SESSION;
 c->key_size_indicator = JK_ENV_KEY_SIZE;
+c->strip_session = JK_FALSE;
 }
 
 if (!jk_map_alloc(&(c->uri_to_context))) {
@@ -2261,6 +2290,8 @@
 if (!overrides->alias_dir)
 overrides->alias_dir = base->alias_dir;
 }
+if (overrides->strip_session == JK_UNSET)
+overrides->strip_session = base->strip_session;
 
 return overrides;
 }
@@ -2671,6 +2702,16 @@
 }
 }
 }
+}
+}
+else if (conf->strip_session == JK_TRUE) {
+char *jsessionid = strstr(r->uri, JK_PATH_SESSION_IDENTIFIER);
+if (jsessionid) {
+if (JK_IS_DEBUG_LEVEL(conf->log))
+jk_log(conf->log, JK_LOG_DEBUG,
+   "removing session identifier [%s] for non 
servlet url [%s]",
+   jsessionid, r->uri);
+*jsessionid = '\0';
 }
 }
 }

Modified: tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c?view=diff&rev=511227&r1=511226&r2=511227
==
--- tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c (original)
+++ tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c Fri Feb 23 22:50:05 
2007
@@ -211,6 +211,7 @@
 int options;
 int exclude_options;
 
+int strip_session;
 /*
  * Environment variables support
  */
@@ -1142,6 +1143,25 @@
 return NULL;
 }
 
+/*
+ * JkStripSession directive handling
+ *
+ * JkStripSession On/Off
+ */
+
+static const char *jk_set_strip_session(cmd_parms * cmd, void *dummy, int flag)
+{
+server_rec *s = cmd->server;
+jk_server_conf_t *conf =
+(jk_server_conf_t *) ap_get_module_config(s->module_config,
+  &jk_module);
+
+/* Set up our value */
+conf->strip_session = flag ? JK_TRUE : JK_FALSE;
+
+return NULL;
+}
+
 /*
  *
  * Actually logging.
@@ -1832,6 +1852,13 @@
  "Should the base server mounts be copied to the virtual 
server"),
 
 /*
+ * JkStripSession specif

svn commit: r511235 - /tomcat/connectors/trunk/jk/native/common/jk_uri_worker_map.c

[mturk]

Author: mturk
Date: Fri Feb 23 23:24:06 2007
New Revision: 511235

URL: http://svn.apache.org/viewvc?view=rev&rev=511235
Log:
Be more verbose while logging url mappings.

Modified:
tomcat/connectors/trunk/jk/native/common/jk_uri_worker_map.c

Modified: tomcat/connectors/trunk/jk/native/common/jk_uri_worker_map.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_uri_worker_map.c?view=diff&rev=511235&r1=511234&r2=511235
==
--- tomcat/connectors/trunk/jk/native/common/jk_uri_worker_map.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_uri_worker_map.c Fri Feb 23 
23:24:06 2007
@@ -535,7 +535,6 @@
   const char *uri, jk_logger_t *l)
 {
 unsigned int i;
-char *url_rewrite;
 const char *rv = NULL;
 char  url[JK_MAX_URI_LEN+1];
 
@@ -552,28 +551,43 @@
 JK_TRACE_EXIT(l);
 return NULL;
 }
-for (i = 0; i < strlen(uri); i++) 
+if (uw_map->fname) {
+uri_worker_map_update(uw_map, l);
+if (!uw_map->size) {
+jk_log(l, JK_LOG_INFO,
+   "No worker maps defined for %s.",
+   uw_map->fname);
+JK_TRACE_EXIT(l);
+return NULL;
+}
+}
+/* Make the copy of the provided uri and strip
+ * everything after the first ';' char.
+ */
+for (i = 0; i < strlen(uri); i++) {
+if (i == JK_MAX_URI_LEN) {
+jk_log(l, JK_LOG_WARNING,
+   "Uri %s is invalid. Uri must be smaller then %d chars",
+   uri, JK_MAX_URI_LEN);
+JK_TRACE_EXIT(l);
+return NULL;
+}
 if (uri[i] == ';')
 break;
 else
 url[i] = uri[i];
+}
 url[i] = '\0';
-
-url_rewrite = strstr(uri, JK_PATH_SESSION_IDENTIFIER);
-if (url_rewrite) {
-size_t len = url_rewrite - url;
-if (len > JK_MAX_URI_LEN)
-len = JK_MAX_URI_LEN;
-url[len] = '\0';
-if (JK_IS_DEBUG_LEVEL(l))
-jk_log(l, JK_LOG_DEBUG, "Removing Session path '%s' URI '%s'",
-   url_rewrite, url);
+
+if (JK_IS_DEBUG_LEVEL(l)) {
+char *url_rewrite = strstr(uri, JK_PATH_SESSION_IDENTIFIER);
+if (url_rewrite)
+jk_log(l, JK_LOG_DEBUG, "Removed session id '%s' from '%s'",
+   url_rewrite, uri);
 }
-if (uw_map->fname)
-uri_worker_map_update(uw_map, l);
 if (JK_IS_DEBUG_LEVEL(l))
 jk_log(l, JK_LOG_DEBUG, "Attempting to map URI '%s' from %d maps",
-   uri, uw_map->size);
+   url, uw_map->size);
 
 for (i = 0; i < uw_map->size; i++) {
 uri_worker_record_t *uwr = uw_map->maps[i];



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]