Re: [VOTE] Release Apache Log4net 3.1.0

2025-05-08 Thread Gary Gregory
Hi all,

The review kit is not quite right IMO: One must at least review the
source zip or tar ball. Reviewing a checkout of the sources is useful
for devs but that's not what we deliver from my understanding of
Apache rules; we deliver source files (not an svn repo).
Would it be possible to add to the review kit to make this distinction?

TY,
Gary

On Wed, May 7, 2025 at 2:08 PM Jan Friedrich  wrote:
>
> This is a vote to release the Apache Log4net 3.1.0.
>
> Website: https://logging.staged.apache.org/log4net/release-notes.html
> GitHub: https://github.com/apache/logging-log4net
> Commit: 76eb4b34f501415fef5adcee2c677f60f48651dc
> Distribution: https://dist.apache.org/repos/dist/dev/logging/log4net/3.1.0
> Signing key: 0x7D24496A230E29D6349A99EF583E491578F02D5D
> Review kit: https://logging.staged.apache.org/log4net/release-review.html
>
> Please download, test, and cast your votes on this mailing list.
>
> [ ] +1, release the artifacts
> [ ] -1, don't release, because ...
>
> This vote is open for 72 hours and will pass unless getting a net
> negative vote count.
> All votes are welcome and we encourage everyone to test the release, but
> only the Logging Services PMC votes are officially counted.


Re: [VOTE] Release Apache Log4net 3.1.0

2025-05-08 Thread Gary D. Gregory
Here's my current issue:

 ggregory@RS-PF3NRMLR  ~  rc  log4net-3.1.0 
❯ dotnet test ./src/log4net.sln

Welcome to .NET 9.0!
-
SDK Version: 9.0.101

Telemetry
-
The .NET tools collect usage data in order to help us improve your experience. 
It is collected by Microsoft and shared with the community. You can opt-out of 
telemetry by setting the DOTNET_CLI_TELEMETRY_OPTOUT environment variable to 
'1' or 'true' using your favorite shell.

Read more about .NET CLI Tools telemetry: https://aka.ms/dotnet-cli-telemetry


Installed an ASP.NET Core HTTPS development certificate.
To trust the certificate, run 'dotnet dev-certs https --trust'
Learn about HTTPS: https://aka.ms/dotnet-https


Write your first app: https://aka.ms/dotnet-hello-world
Find out what's new: https://aka.ms/dotnet-whats-new
Explore documentation: https://aka.ms/dotnet-docs
Report issues and find source on GitHub: https://github.com/dotnet/core
Use 'dotnet --help' to see available commands or visit: 
https://aka.ms/dotnet-cli
--
MSBUILD : error MSB1009: Project file does not exist.
Switch: ./src/log4net.sln
 ggregory@RS-PF3NRMLR  ~  rc  log4net-3.1.0   

It looks like I have dotnet 9 installed on this laptop, is that an issue?

I checkout the RC to my ~/rc/log4net-3.1.0:

❯ svn info
Path: .
Working Copy Root Path: C:\Users\ggregory\rc\log4net-3.1.0
URL: https://dist.apache.org/repos/dist/dev/logging/log4net/3.1.0
Relative URL: ^/dev/logging/log4net/3.1.0
Repository Root: https://dist.apache.org/repos/dist
Repository UUID: 0d268c88-bc11-4956-87df-91683dc98e59
Revision: 76735
Node Kind: directory
Schedule: normal
Last Changed Author: freeandnil
Last Changed Rev: 76721
Last Changed Date: 2025-05-07 14:00:41 -0400 (Wed, 07 May 2025)

I'm not used to running dotnet builds ;-)

Gary


On 2025/05/08 13:18:07 Gary Gregory wrote:
> One day I'll learn how to read ALL the instructions 😉
> 
> Gary
> 
> On Thu, May 8, 2025, 09:14 Jan Friedrich  wrote:
> 
> > See 2) Prerequisites (choco - *only in case of problems with winget*)
> >
> > Jan
> >
> >
> > On May 8, 2025 3:07:19 PM GMT+02:00, "Gary D. Gregory" <
> > ggreg...@apache.org> wrote:
> >
> >> Before I google myself down a rabbit hole... have you seen:
> >>
> >> winget install -e --id GnuPG.Gpg4win
> >> Failed when searching source: winget
> >> An unexpected error occurred while executing the command:
> >> 0x8a15000f : Data required by the source is missing
> >>
> >> No packages were found among the working sources.
> >>
> >> Gary
> >>
> >> On 2025/05/07 18:07:49 Jan Friedrich wrote:
> >>
> >>> This is a vote to release the Apache Log4net 3.1.0.
> >>>
> >>> Website: https://logging.staged.apache.org/log4net/release-notes.html
> >>> GitHub: https://github.com/apache/logging-log4net
> >>> Commit: 76eb4b34f501415fef5adcee2c677f60f48651dc
> >>> Distribution: https://dist.apache.org/repos/dist/dev/logging/log4net/3.1.0
> >>> Signing key: 0x7D24496A230E29D6349A99EF583E491578F02D5D
> >>> Review kit: https://logging.staged.apache.org/log4net/release-review.html
> >>>
> >>> Please download, test, and cast your votes on this mailing list.
> >>>
> >>> [ ] +1, release the artifacts
> >>> [ ] -1, don't release, because ...
> >>>
> >>> This vote is open for 72 hours and will pass unless getting a net
> >>> negative vote count.
> >>> All votes are welcome and we encourage everyone to test the release, but
> >>> only the Logging Services PMC votes are officially counted.
> >>>
> >>> Jan
> >
> 


Re: [VOTE] Release Apache Log4net 3.1.0

2025-05-08 Thread Gary Gregory
Ahhh! I see it now! Thank you.

Gary

On Thu, May 8, 2025, 08:39 Volkan Yazıcı  wrote:

> You *are* reviewing the source ZIP Jan will deliver at the end of the
> release. See the `unzip` command in the review kit – for Windows, see
> `Expand-Archive` command in the shared `verify-release.ps1` script.
>
> If I misunderstood your remark, would you mind elaborating it, please?
>
> On Thu, May 8, 2025 at 2:06 PM Gary Gregory 
> wrote:
>
> > Hi all,
> >
> > The review kit is not quite right IMO: One must at least review the
> > source zip or tar ball. Reviewing a checkout of the sources is useful
> > for devs but that's not what we deliver from my understanding of
> > Apache rules; we deliver source files (not an svn repo).
> > Would it be possible to add to the review kit to make this distinction?
> >
> > TY,
> > Gary
> >
> > On Wed, May 7, 2025 at 2:08 PM Jan Friedrich 
> > wrote:
> > >
> > > This is a vote to release the Apache Log4net 3.1.0.
> > >
> > > Website: https://logging.staged.apache.org/log4net/release-notes.html
> > > GitHub: https://github.com/apache/logging-log4net
> > > Commit: 76eb4b34f501415fef5adcee2c677f60f48651dc
> > > Distribution:
> > https://dist.apache.org/repos/dist/dev/logging/log4net/3.1.0
> > > Signing key: 0x7D24496A230E29D6349A99EF583E491578F02D5D
> > > Review kit:
> > https://logging.staged.apache.org/log4net/release-review.html
> > >
> > > Please download, test, and cast your votes on this mailing list.
> > >
> > > [ ] +1, release the artifacts
> > > [ ] -1, don't release, because ...
> > >
> > > This vote is open for 72 hours and will pass unless getting a net
> > > negative vote count.
> > > All votes are welcome and we encourage everyone to test the release,
> but
> > > only the Logging Services PMC votes are officially counted.
> >
>


Re: [VOTE] Release Apache Log4net 3.1.0

2025-05-08 Thread Volkan Yazıcı
You *are* reviewing the source ZIP Jan will deliver at the end of the
release. See the `unzip` command in the review kit – for Windows, see
`Expand-Archive` command in the shared `verify-release.ps1` script.

If I misunderstood your remark, would you mind elaborating it, please?

On Thu, May 8, 2025 at 2:06 PM Gary Gregory  wrote:

> Hi all,
>
> The review kit is not quite right IMO: One must at least review the
> source zip or tar ball. Reviewing a checkout of the sources is useful
> for devs but that's not what we deliver from my understanding of
> Apache rules; we deliver source files (not an svn repo).
> Would it be possible to add to the review kit to make this distinction?
>
> TY,
> Gary
>
> On Wed, May 7, 2025 at 2:08 PM Jan Friedrich 
> wrote:
> >
> > This is a vote to release the Apache Log4net 3.1.0.
> >
> > Website: https://logging.staged.apache.org/log4net/release-notes.html
> > GitHub: https://github.com/apache/logging-log4net
> > Commit: 76eb4b34f501415fef5adcee2c677f60f48651dc
> > Distribution:
> https://dist.apache.org/repos/dist/dev/logging/log4net/3.1.0
> > Signing key: 0x7D24496A230E29D6349A99EF583E491578F02D5D
> > Review kit:
> https://logging.staged.apache.org/log4net/release-review.html
> >
> > Please download, test, and cast your votes on this mailing list.
> >
> > [ ] +1, release the artifacts
> > [ ] -1, don't release, because ...
> >
> > This vote is open for 72 hours and will pass unless getting a net
> > negative vote count.
> > All votes are welcome and we encourage everyone to test the release, but
> > only the Logging Services PMC votes are officially counted.
>


Re: [VOTE] Release Apache Log4net 3.1.0

2025-05-08 Thread Jan Friedrich
See 2) Prerequisites (choco - *only in case of problems with winget*)

Jan

On May 8, 2025 3:07:19 PM GMT+02:00, "Gary D. Gregory"  
wrote:
>Before I google myself down a rabbit hole... have you seen:
>
>winget install -e --id GnuPG.Gpg4win
>Failed when searching source: winget
>An unexpected error occurred while executing the command:
>0x8a15000f : Data required by the source is missing
>
>No packages were found among the working sources.
>
>Gary
>
>On 2025/05/07 18:07:49 Jan Friedrich wrote:
>> This is a vote to release the Apache Log4net 3.1.0.
>> 
>> Website: https://logging.staged.apache.org/log4net/release-notes.html
>> GitHub: https://github.com/apache/logging-log4net
>> Commit: 76eb4b34f501415fef5adcee2c677f60f48651dc
>> Distribution: https://dist.apache.org/repos/dist/dev/logging/log4net/3.1.0
>> Signing key: 0x7D24496A230E29D6349A99EF583E491578F02D5D
>> Review kit: https://logging.staged.apache.org/log4net/release-review.html
>> 
>> Please download, test, and cast your votes on this mailing list.
>> 
>> [ ] +1, release the artifacts
>> [ ] -1, don't release, because ...
>> 
>> This vote is open for 72 hours and will pass unless getting a net 
>> negative vote count.
>> All votes are welcome and we encourage everyone to test the release, but 
>> only the Logging Services PMC votes are officially counted.
>> 

Jan

Re: [VOTE] Release Apache Log4net 3.1.0

2025-05-08 Thread Gary D. Gregory
Before I google myself down a rabbit hole... have you seen:

winget install -e --id GnuPG.Gpg4win
Failed when searching source: winget
An unexpected error occurred while executing the command:
0x8a15000f : Data required by the source is missing

No packages were found among the working sources.

Gary

On 2025/05/07 18:07:49 Jan Friedrich wrote:
> This is a vote to release the Apache Log4net 3.1.0.
> 
> Website: https://logging.staged.apache.org/log4net/release-notes.html
> GitHub: https://github.com/apache/logging-log4net
> Commit: 76eb4b34f501415fef5adcee2c677f60f48651dc
> Distribution: https://dist.apache.org/repos/dist/dev/logging/log4net/3.1.0
> Signing key: 0x7D24496A230E29D6349A99EF583E491578F02D5D
> Review kit: https://logging.staged.apache.org/log4net/release-review.html
> 
> Please download, test, and cast your votes on this mailing list.
> 
> [ ] +1, release the artifacts
> [ ] -1, don't release, because ...
> 
> This vote is open for 72 hours and will pass unless getting a net 
> negative vote count.
> All votes are welcome and we encourage everyone to test the release, but 
> only the Logging Services PMC votes are officially counted.
> 


Re: [VOTE] Release Apache Log4net 3.1.0

2025-05-08 Thread Gary Gregory
One day I'll learn how to read ALL the instructions 😉

Gary

On Thu, May 8, 2025, 09:14 Jan Friedrich  wrote:

> See 2) Prerequisites (choco - *only in case of problems with winget*)
>
> Jan
>
>
> On May 8, 2025 3:07:19 PM GMT+02:00, "Gary D. Gregory" <
> ggreg...@apache.org> wrote:
>
>> Before I google myself down a rabbit hole... have you seen:
>>
>> winget install -e --id GnuPG.Gpg4win
>> Failed when searching source: winget
>> An unexpected error occurred while executing the command:
>> 0x8a15000f : Data required by the source is missing
>>
>> No packages were found among the working sources.
>>
>> Gary
>>
>> On 2025/05/07 18:07:49 Jan Friedrich wrote:
>>
>>> This is a vote to release the Apache Log4net 3.1.0.
>>>
>>> Website: https://logging.staged.apache.org/log4net/release-notes.html
>>> GitHub: https://github.com/apache/logging-log4net
>>> Commit: 76eb4b34f501415fef5adcee2c677f60f48651dc
>>> Distribution: https://dist.apache.org/repos/dist/dev/logging/log4net/3.1.0
>>> Signing key: 0x7D24496A230E29D6349A99EF583E491578F02D5D
>>> Review kit: https://logging.staged.apache.org/log4net/release-review.html
>>>
>>> Please download, test, and cast your votes on this mailing list.
>>>
>>> [ ] +1, release the artifacts
>>> [ ] -1, don't release, because ...
>>>
>>> This vote is open for 72 hours and will pass unless getting a net
>>> negative vote count.
>>> All votes are welcome and we encourage everyone to test the release, but
>>> only the Logging Services PMC votes are officially counted.
>>>
>>> Jan
>


Re: [VOTE] Release Apache Log4net 3.1.0

2025-05-08 Thread Jan Friedrich

Hi Gary,

thanks for reporting.
There was a bug in verify-release.ps1 due to changes of the directory 
structure inside the zip file.

I've fixed the script and uploaded the new version to svn.

Can you do the following in 3.1.0?

- svn cleanup --remove-unversioned
- svn up
- ./verify-release.ps1

Having a newer dotnet sdk (9 or 10-preview) is no problem.

Thanks.

Jan


On 5/8/25 15:42, Gary D. Gregory wrote:

dotnet test ./src/log4net.sln

MSBUILD : error MSB1009: Project file does not exist.
Switch: ./src/log4net.sln