[GitHub] geode pull request #490: Feature/geode 2852
GitHub user ladyVader opened a pull request: https://github.com/apache/geode/pull/490 Feature/geode 2852 GEODE-2852: Enforce lucene waitUntilFlushed timeout for all buckets * Since we are now batching waitUntilFlushed threads, do not submit more WaitUntilFlushed Callables if timeout exceeded * create the WaitUntilFlushed Callables just prior to submitting for execution so the remaining nanoSeconds can be passed in and applied for each bucket. * updated tests to accommodate changes @upthewaterspout @nabarunnag, @boglesby, @jhuynh1, @gesterzhou You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/geode feature/GEODE-2852 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/490.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #490 commit f47082376335e4f7d271d3e0159439295751d8cd Author: Lynn Hughes-Godfrey Date: 2017-04-28T23:33:14Z GEODE-2852: Lucene waitUntilFlushed timeout enforced across all (local) buckets * Add check for timeout in WaitUntilParallelGatewaySenderFlushedCoordinator.waitUntilFlushed() * return false if all Callables not invoked before timeout reached commit ddec64a3403840bc50eca69ad6ce54762397f1fe Author: Dave Barnes Date: 2017-04-25T20:05:00Z GEODE-2821 - Geode User Guide: Add running heads with logo commit 8dd87ed9b7449c77b751689ebf19f8ff5f025157 Author: adongre Date: 2017-04-04T18:28:53Z GEODE-2723: Removed localCacheEnabled field, and associated dead code. This closes #440 Signed-off-by: adongre commit 7207aa45b7e4298d5f92a5ea7a57afd5510e1e6a Author: Darrel Schneider Date: 2017-04-20T00:09:05Z GEODE-2801: change krfIds to be thread safe commit 7948362fbd0422b01de429906a9cc51348c5f7aa Author: Darrel Schneider Date: 2017-04-22T00:09:23Z GEODE-2811: close OffHeapEvictor when cache is closed Rejected executions are now ignored if shutting down. execute now used instead of submit. Close logic on HeapEvictor improved to prevent race conditions and NPEs. commit 84e36d558e92b3d722a7e4c6df2439a72ea8f218 Author: nabarun Date: 2017-04-24T17:50:06Z GEODE-2816: Redundancy recovery inititated even if redundancy set to 0 commit 63ffe7649d8257f7e7c3e5f2533caed0548556e8 Author: Jinmei Liao Date: 2017-04-25T20:51:42Z GEODE-1597: use Spring shell's parser and delete our own parsing code * Use Spring's SimpleParser as a basis for command parsing * reworked help/hint * removing singleton CommandManager commit e5549c8cd9c3e561a876e1ec49fe53988fcd49be Author: Kirk Lund Date: 2017-04-26T17:06:01Z GEODE-2632: minor fixes from code review * add TODO comments for some larger fixes from review commit bcb8a746dbd8f6344da362821fb28958bb33bb61 Author: Kirk Lund Date: 2017-04-26T18:16:57Z GEODE-2632: make GemFireCacheImpl.getRegion(String) non-final * mock getRegion(String) in ParallelQueueRemovalMessageJUnitTest commit 6eb100d8a5b271c67366793380333ced7112aed4 Author: Jared Stewart Date: 2017-04-27T20:09:08Z GEODE-2840: add a DUnit test to test concurrent deploy commit 7771e97a1e3c31fa77821b9777884a2147c93bb0 Author: Jared Stewart Date: 2017-04-28T17:30:35Z GEODE-2795: Clean up DUnit VMs after dynamically changing 'user.dir' commit d0c44de5f0bc2d1de276fc25c5cecaf61908fa7c Author: Lynn Hughes-Godfrey Date: 2017-05-02T20:33:49Z Enforce waitUntilFlushed timeout per bucket (as well as overall). Rework JUnit tests for new implementation. commit e94e506eb250ec51c8285897dbbcbe255a7910b1 Author: Lynn Hughes-Godfrey Date: 2017-05-02T20:34:58Z Merge remote-tracking branch 'origin/develop' into feature/GEODE-2852 commit 29fbd25cb3cb16a5c759a835402c60270e4f21cd Author: Lynn Hughes-Godfrey Date: 2017-05-02T20:51:48Z Merge remote-tracking branch 'origin/develop' into feature/GEODE-2852 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #490: Feature/geode 2852
Github user ladyVader closed the pull request at: https://github.com/apache/geode/pull/490 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #503: GEODE-2907: Removed @Experimental tag from the Luce...
Github user ladyVader commented on a diff in the pull request: https://github.com/apache/geode/pull/503#discussion_r115626998 --- Diff: geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneResultStruct.java --- @@ -39,6 +41,8 @@ * Return score the score of the entry matching the query. Scores are computed by Lucene based on * how closely documents match the query. * + * @return float value representing the score of the document / entry obtained as a result of --- End diff -- So, we should probably use entry (instead of document) in line 42 as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #503: GEODE-2907: Removed @Experimental tag from the Luce...
Github user ladyVader commented on a diff in the pull request:
https://github.com/apache/geode/pull/503#discussion_r115627251
--- Diff:
geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneIndex.java ---
@@ -19,39 +19,62 @@
import org.apache.lucene.analysis.Analyzer;
-import org.apache.geode.annotations.Experimental;
-
/**
*
- * An Lucene index is built over the data stored in a GemFire Region.
+ * LuceneIndex represents the Lucene index created over the data stored in
Apache Geode regions. The
+ * Lucene indexes are maintained automatically by Apache Geode whenever
the entries are updated in
+ * the associated regions. Lucene Indexes are created using {@link
LuceneService#createIndexFactory}
+ * by specifying the Lucene index name, the region associated with the
Lucene index, the fields on
--- End diff --
maybe just add the word "and" before the last phrase here ... "and the
fields on ..."
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #552: GEODE-3013: Reduce log level for FunctionInvocation...
GitHub user ladyVader opened a pull request: https://github.com/apache/geode/pull/552 GEODE-3013: Reduce log level for FunctionInvocationTargetException GEODE-3013: Reduce log level for FunctionInvocationTargetExceptions - Modified to display at debug vs. warning level (includes full stack trace) @upthewaterspout @nabarunnag, @boglesby, @jhuynh1, @gesterzhou Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to dev@geode.apache.org. You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/geode feature/GEODE-3013 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/552.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #552 commit d9f219ad048668a99ccdf4ac630326c1e13c6f19 Author: Lynn Hughes-Godfrey Date: 2017-05-31T01:16:34Z GEODE-3013: Reduce logging level for FunctionInvocationTargetException: Multiple target nodes found for single hop operation - Modified to display at debug vs. warning level --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #552: GEODE-3013: Reduce log level for FunctionInvocation...
Github user ladyVader closed the pull request at: https://github.com/apache/geode/pull/552 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #552: GEODE-3013: Reduce log level for FunctionInvocationTargetE...
Github user ladyVader commented on the issue: https://github.com/apache/geode/pull/552 Actually, with this change, I'm still seeing these log messages in testing, so retracting this pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #622: GEODE-1731: Modifying region size check to be more accurat...
Github user ladyVader commented on the issue: https://github.com/apache/geode/pull/622 Looks good! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #645: GEODE-3113: Modify HARegionQueue test to use Awaiti...
GitHub user ladyVader opened a pull request: https://github.com/apache/geode/pull/645 GEODE-3113: Modify HARegionQueue test to use Awaitility vs. timeouts * Modify test to use Awaitility (at most 60 seconds) vs. sleeps prior to checking expiration @upthewaterspout @nabarunnag Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to dev@geode.apache.org. You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/geode feature/GEODE-3113 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/645.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #645 commit f286244a864e3eb61bbb586b678d39e0227bd574 Author: Lynn Hughes-Godfrey Date: 2017-07-18T20:48:24Z GEODE-3113: Modify HARegionQueue test to use Awaitility vs. timeouts * Modify test to use Awaitility (at most 60 seconds) vs. sleeps prior to checking expiration --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #659: GEODE-3308: Lucene rolling upgrade and backwards co...
Github user ladyVader commented on a diff in the pull request:
https://github.com/apache/geode/pull/659#discussion_r129672503
--- Diff:
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneSearchWithRollingUpgradeDUnit.java
---
@@ -0,0 +1,1044 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF
ANY KIND, either express
+ * or implied. See the License for the specific language governing
permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.cache.lucene;
+
+import static org.apache.geode.test.dunit.Assert.fail;
+import static org.junit.Assert.assertEquals;
+
+import java.io.File;
+import java.io.IOException;
+import java.lang.reflect.Constructor;
+import java.lang.reflect.Method;
+import java.net.InetAddress;
+import java.net.UnknownHostException;
+import java.util.Collection;
+import java.util.List;
+import java.util.Properties;
+import java.util.concurrent.TimeUnit;
+
+import org.apache.commons.io.FileUtils;
+import org.apache.logging.log4j.Logger;
+import org.awaitility.Awaitility;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
+
+import org.apache.geode.cache.GemFireCache;
+import org.apache.geode.cache.RegionShortcut;
+import org.apache.geode.cache.client.ClientCache;
+import org.apache.geode.cache.client.ClientCacheFactory;
+import org.apache.geode.cache.client.ClientRegionFactory;
+import org.apache.geode.cache.client.ClientRegionShortcut;
+import org.apache.geode.cache.server.CacheServer;
+import org.apache.geode.cache30.CacheSerializableRunnable;
+import org.apache.geode.distributed.Locator;
+import org.apache.geode.distributed.internal.DistributionConfig;
+import org.apache.geode.internal.AvailablePortHelper;
+import org.apache.geode.internal.Version;
+import org.apache.geode.internal.cache.GemFireCacheImpl;
+import org.apache.geode.internal.logging.LogService;
+import org.apache.geode.test.dunit.DistributedTestUtils;
+import org.apache.geode.test.dunit.Host;
+import org.apache.geode.test.dunit.IgnoredException;
+import org.apache.geode.test.dunit.Invoke;
+import org.apache.geode.test.dunit.NetworkUtils;
+import org.apache.geode.test.dunit.VM;
+import org.apache.geode.test.dunit.internal.JUnit4DistributedTestCase;
+import org.apache.geode.test.dunit.standalone.DUnitLauncher;
+import org.apache.geode.test.dunit.standalone.VersionManager;
+import org.apache.geode.test.junit.categories.BackwardCompatibilityTest;
+import org.apache.geode.test.junit.categories.DistributedTest;
+import
org.apache.geode.test.junit.runners.CategoryWithParameterizedRunnerFactory;
+
+@Category({DistributedTest.class, BackwardCompatibilityTest.class})
+@RunWith(Parameterized.class)
+@Parameterized.UseParametersRunnerFactory(CategoryWithParameterizedRunnerFactory.class)
+public class LuceneSearchWithRollingUpgradeDUnit extends
JUnit4DistributedTestCase {
+
+
+ @Parameterized.Parameters
+ public static Collection data() {
+List result =
VersionManager.getInstance().getVersionsWithoutCurrent();
+// Lucene Compatibility checks start with Apache Geode v1.2.0
+// Removing the versions older than v1.2.0
+result.removeIf(s -> Integer.parseInt(s) < 120);
+if (result.size() < 1) {
+ throw new RuntimeException("No older versions of Geode were found to
test against");
+} else {
+ System.out.println("running against these versions: " + result);
+}
+return result;
+ }
+
+ private File[] testingDirs = new File[3];
+
+ private static String INDEX_NAME = "index";
+
+ private static String diskDir = "LuceneSearchWithRollingUpgradeDUnit";
+
+ // Each vm will have a cache object
+ private static Object cache;
+
+ // the old version of Geode we're testing against
+ private String oldVersion;
+
+ private void deleteVMFiles() throws Exception {
+System.out.println(&q
[GitHub] geode pull request #669: GEODE-2226: SessionReplicationIntegrationTests do n...
GitHub user ladyVader opened a pull request: https://github.com/apache/geode/pull/669 GEODE-2226: SessionReplicationIntegrationTests do not run on Windows * Disable SessionReplicationIntegrationTests on Windows @nabarunnag, @jhuynh1 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to dev@geode.apache.org. You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/geode feature/GEODE-2226 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/669.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #669 commit 8f3c6b07acc1cadf23b843a75b165f6a95d88b99 Author: Lynn Hughes-Godfrey Date: 2017-07-28T23:15:01Z GEODE-2226: SesssionReplicationIntegrationTests do not run on Windows * Disable SessionReplicationIntegrationTests on Windows --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #744: GEODE-3522: create via load needs to add event to A...
GitHub user ladyVader opened a pull request: https://github.com/apache/geode/pull/744 GEODE-3522: create via load needs to add event to AEQ under same lock⦠⦠as update to local region * create via load was invoking handleWANEvent prior to obtaining a lock, which allowed rebalance to shift the primary between AEQ update and data region update. * moved call to handleWANEvent from DistributedRegion to BucketRegion to synchronize these two actions. @upthewaterspout, @boglesby Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to dev@geode.apache.org. You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/geode feature/GEODE-3522 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/744.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #744 commit afbfd708185cc7ed82490699c033c40263e4aa76 Author: Lynn Hughes-Godfrey Date: 2017-08-25T21:46:17Z GEODE-3522: create via load needs to add event to AEQ under same lock as update to local region * create via load was invoking handleWANEvent prior to obtaining a lock, which allowed rebalance to shift the primary between AEQ update and data region update. * moved call to handleWANEvent from DistributedRegion to BucketRegion to synchronize these two actions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #411: GEODE-2589, GEODE-2590 lucene index region attribut...
GitHub user ladyVader opened a pull request: https://github.com/apache/geode/pull/411 GEODE-2589, GEODE-2590 lucene index region attributes should be based⦠lucene index region attributes should reflect those on data region - lucene index region now inherits recoveryDelay and startupRecoveryDelay from data region - lucene index region now only sets diskStoreName (in RegionAttributes) when data region has persistence. @upthewaterspout @nabarunnag - Could you please review these changes? You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/geode feature/GEODE-2589 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/411.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #411 commit 24d02a5862851ceffa715233f245c46651776cf4 Author: Lynn Hughes-Godfrey Date: 2017-03-03T21:11:53Z GEODE-2589, GEODE-2590 lucene index region attributes should be based on data region - lucene index region now inherits recoveryDelay and startupRecoveryDelay from data region - lucene index region now only sets diskStoreName (in RegionAttributes) when data region has persistence. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #448: GEODE-2745: WaitUntilBucketRegionQueueFlushedCallab...
GitHub user ladyVader opened a pull request: https://github.com/apache/geode/pull/448 GEODE-2745: WaitUntilBucketRegionQueueFlushedCallable gets BucketRegi⦠GEODE-2745: waitUntilFlushed method waits longer than it should - Added getter in BucketRegionQueue for latestQueuedKey - WaitUntilBucketRegionQueueFlushedCallable constructor now gets/maintains the BucketRegionQueue.latestQueuedKey You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/geode feature/GEODE-2745 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/448.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #448 commit ba3b28adc48884bb5d697d307a28f4831f5d9301 Author: Lynn Hughes-Godfrey Date: 2017-04-07T18:57:16Z GEODE-2745: WaitUntilBucketRegionQueueFlushedCallable gets BucketRegionQueue.latestQueuedKey in constructor vs. setting when callable invoked. - Added getter in BucketRegionQueue for latestQueuedKey - WaitUntilBucketRegionQueueFlushedCallable constructor now gets/maintains the BucketRegionQueue.latestQueuedKey --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #448: GEODE-2745: WaitUntilBucketRegionQueueFlushedCallab...
Github user ladyVader commented on a diff in the pull request:
https://github.com/apache/geode/pull/448#discussion_r111012023
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/BucketRegionQueue.java
---
@@ -464,16 +464,21 @@ private void setLatestAcknowledgedKey(Long key) {
this.latestAcknowledgedKey.set(key);
}
- public boolean waitUntilFlushed(long timeout, TimeUnit unit) throws
InterruptedException {
+ public long getLatestQueuedKey() {
+return this.latestQueuedKey.get();
+ }
+
+ public boolean waitUntilFlushed(long latestQueuedKey, long timeout,
TimeUnit unit)
+ throws InterruptedException {
long then = System.currentTimeMillis();
if (logger.isDebugEnabled()) {
- logger.debug("BucketRegionQueue: waitUntilFlushed bucket=" + getId()
+ "; timeout=" + timeout
- + "; unit=" + unit);
+ logger.debug("BucketRegionQueue: waitUntilFlushed bucket=" + getId()
+ "; latestQueuedKey="
+ + latestQueuedKey + "; timeout=" + timeout + "; unit=" + unit);
}
boolean result = false;
// Wait until latestAcknowledgedKey > latestQueuedKey or the queue is
empty
if (this.initialized) {
- long latestQueuedKeyToCheck = this.latestQueuedKey.get();
+ long latestQueuedKeyToCheck = latestQueuedKey;
--- End diff --
Ah, yes ... that does seem more straightforward. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #448: GEODE-2745: WaitUntilBucketRegionQueueFlushedCallab...
Github user ladyVader closed the pull request at: https://github.com/apache/geode/pull/448 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
