[GitHub] geode issue #440: GEODE-2723: Removed localCacheEnabled field, and associate...
Github user davinash commented on the issue: https://github.com/apache/geode/pull/440 Is this ok to merge ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #488: GEODE-254: Removed deprecated Region.keys and Regio...
GitHub user davinash opened a pull request: https://github.com/apache/geode/pull/488 GEODE-254: Removed deprecated Region.keys and Region.entries You can merge this pull request into a Git repository by running: $ git pull https://github.com/davinash/geode feature/GEODE-254 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/488.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #488 commit 2e2684dcf471f294a0d9da94bdba1c767436abe4 Author: adongre Date: 2017-05-02T09:11:55Z GEODE-254: Removed deprecated Region.keys and Region.entries --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #443: [GEODE-1887] #comment Fix for Client PROXY region should d...
Github user davinash commented on the issue: https://github.com/apache/geode/pull/443 closing this PR as per the comment above. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #495: GEODE-234: Removed deprecated MirrorType class and ...
GitHub user davinash opened a pull request: https://github.com/apache/geode/pull/495 GEODE-234: Removed deprecated MirrorType class and its usage is replaced by appropriate DataPolicy.REPLICATE or DataPolicy.NORMAL - Did not find cache-9.0.xsd in source. So I am assuming this file will get added later. - geode-docs still has reference to mirror-type. - ConsoleDistributionManagerDUnitTest#testApplications is failing ( FlakyTest ) - ClusterConfigurationServiceEndToEndDUnitTest#testStartServerAndExecuteCommands is failing ( FlakyTest) You can merge this pull request into a Git repository by running: $ git pull https://github.com/davinash/geode feature/GEODE-234 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/495.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #495 commit aa048b25659b65050ca19a963228d7ce8b014c07 Author: adongre Date: 2017-05-04T03:02:34Z GEODE-234: Removed deprecated MirrorType class and its usage is replaced by appropriate DataPolicy.REPLICATE or DataPolicy.NORMAL GEODE-234: Spotless and import error fix. GEODE-234: Fixing the Test Failures. GEODE-234 : Fixing some more test failures --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #443: [GEODE-1887] #comment Fix for Client PROXY region s...
Github user davinash closed the pull request at: https://github.com/apache/geode/pull/443 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #464: GEODE-237: Removed deprecated API from EntryEvent
Github user davinash commented on the issue: https://github.com/apache/geode/pull/464 Some is wrong. I am closing this PR and will raise another one from latest develop. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #464: GEODE-237: Removed deprecated API from EntryEvent
Github user davinash closed the pull request at: https://github.com/apache/geode/pull/464 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #496: GEODE-237: Removed deprecated API from EntryEvent
GitHub user davinash opened a pull request: https://github.com/apache/geode/pull/496 GEODE-237: Removed deprecated API from EntryEvent @upthewaterspout , @dschneider-pivotal Resubmitting PR , as I have closed #464 Please review. You can merge this pull request into a Git repository by running: $ git pull https://github.com/davinash/geode feature/GEODE-237.II Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/496.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #496 commit 187c922da2cd592797c68c3324424814ea448bc7 Author: adongre Date: 2017-05-06T08:43:13Z GEODE-237: Removed deprecated API from EntryEvent --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #467: GEODE-258: Remove deprecated Cache.getLoggerI18n and getSe...
Github user davinash commented on the issue: https://github.com/apache/geode/pull/467 Thanks @kirklund and @upthewaterspout If I understand correctly getLoggerI18n should go away and replace with Log4j2. What is to be done for getSecurityLoggerI18n ?? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #495: GEODE-234: Removed deprecated MirrorType class and its usa...
Github user davinash commented on the issue: https://github.com/apache/geode/pull/495 Thanks @dschneider-pivotal for the review. Do you want CacheXML and dtd changes part of this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #488: GEODE-254: Removed deprecated Region.keys and Region.entri...
Github user davinash commented on the issue: https://github.com/apache/geode/pull/488 Thanks @dschneider-pivotal for review. I will fix those issue and raise another PR, as this one is already merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #497: GEODE-2866: Removing the unused files and the correspondin...
Github user davinash commented on the issue: https://github.com/apache/geode/pull/497 +1 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #504: GEODE-254: Removed deprecated Region.keys and Regio...
GitHub user davinash opened a pull request: https://github.com/apache/geode/pull/504 GEODE-254: Removed deprecated Region.keys and Region.entries Addressing review comment from https://github.com/apache/geode/pull/488 - removed method entries - IndexMaintenanceJUnitTest#testIndexMaintenanceWithIndexOnMethodEntries is no longer applicable so removed the same. - Other than GMSMembershipManagerJUnitTest all tests are passing - This also fixed ConsoleDistributionManagerDUnitTest#testApplications, which was failing due to my previous fix. @dschneider-pivotal , @kirklund Please review. You can merge this pull request into a Git repository by running: $ git pull https://github.com/davinash/geode feature/GEODE-254.2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/504.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #504 commit bba87157d39cefcc977ce9207842f0316cbb6729 Author: adongre Date: 2017-05-09T19:04:14Z GEODE-254: Addressing review comments from PR #488 Replacing all inststance of entries with entrySet GEODE-254: Fixing the Test Failures - Removed test testIndexMaintenanceWithIndexOnMethodEntries since this is no more applicable. GEODE-254: Spotless fixing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #504: GEODE-254: Removed deprecated Region.keys and Region.entri...
Github user davinash commented on the issue: https://github.com/apache/geode/pull/504 Thanks @dschneider-pivotal Can I merge this PR now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #508: GEODE-2908: Adding the new tag as per swagger notification...
Github user davinash commented on the issue: https://github.com/apache/geode/pull/508 @prasi-in Can you please fix the imports. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #515: GEODE-240: Remove deprecated methods on TransactionEvent
Github user davinash commented on the issue: https://github.com/apache/geode/pull/515 +1 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #529: GEODE-2980: All the methods in an interface are imp...
GitHub user davinash opened a pull request: https://github.com/apache/geode/pull/529 GEODE-2980: All the methods in an interface are implicitly public and abstract. All fields in the interface are implicitly public, static and final. Removing this from all the interface. Pre-checkin pass. Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [X] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [X] Is your initial contribution a single, squashed commit? - [X] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? Not required for this change - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? NA ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to dev@geode.apache.org. You can merge this pull request into a Git repository by running: $ git pull https://github.com/davinash/geode feature/GEODE-2980 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/529.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #529 commit 8e6fdeec35ab62b3913dab9292fefe604fa340ad Author: Avinash Date: 2017-05-23T03:55:02Z All the methods in an interface are implicitly public and abstract. All fields in the interface are implicitly public, static and final. Removing this from all the interface. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #529: GEODE-2980: All the methods in an interface are implicitly...
Github user davinash commented on the issue: https://github.com/apache/geode/pull/529 Thanks @kirklund , Yes Please you can merge this change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #529: GEODE-2980: All the methods in an interface are implicitly...
Github user davinash commented on the issue: https://github.com/apache/geode/pull/529 Hi @kirklund Updated the PR and running the tests now again. Please review and you can merge the same. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #467: GEODE-258: Remove deprecated Cache.getLoggerI18n and getSe...
Github user davinash commented on the issue: https://github.com/apache/geode/pull/467 Thanks @kirklund and @upthewaterspout for your comments. I am moving this discussion on JIRA GEODE-258 and more questions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #388: GEODE-2428: Adding support of Serialization/deseria...
GitHub user davinash opened a pull request: https://github.com/apache/geode/pull/388 GEODE-2428: Adding support of Serialization/deserialization of LinkedHashMap Added support for writeLinkedHashMap and readLinkedHashMap and the test for the same. You can merge this pull request into a Git repository by running: $ git pull https://github.com/davinash/geode feature/GEODE-2428 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/388.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #388 commit 3869e0d0d3ed2104c79323a252c6c47ef1e5bd20 Author: adongre Date: 2017-02-04T14:17:51Z GEODE-2428: Adding support of Serialization/deserialization of LinkedHashMap in DataSerializer Also added a test for the same. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #329: [GEODE-1887] #comment Fix for Issue #1887
Github user davinash closed the pull request at: https://github.com/apache/geode/pull/329 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #329: [GEODE-1887] #comment Fix for Issue #1887
Github user davinash commented on the issue: https://github.com/apache/geode/pull/329 closing this one and will open another PR for the same. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #390: [GEODE-1887] #comment Fix Issue Client PROXY region...
GitHub user davinash opened a pull request: https://github.com/apache/geode/pull/390 [GEODE-1887] #comment Fix Issue Client PROXY region should delegate all operations to server Issue : Client PROXY region should delegate all operations to server If client and data policy is empty then size API goes through ServerRegionProxy Wrote a test for Replicated and PR to verify size and isEmpty You can merge this pull request into a Git repository by running: $ git pull https://github.com/davinash/geode feature/GEODE-1887 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/390.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #390 commit 0ecfb99979bdaa1fab7784e72418e1c6737f8225 Author: adongre Date: 2017-02-04T16:04:37Z GEODE-1887: Now Size api goes through ServerProxy when cache is of type client and DataPolicy is Empty. Added a test for both PR and Replicated regions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #390: [GEODE-1887] #comment Fix Issue Client PROXY region should...
Github user davinash commented on the issue: https://github.com/apache/geode/pull/390 Thanks @sbawaska for review. I have made the changes. Please review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native issue #21: GEODE-2441: Remove pdx auto serializer from core sou...
Github user davinash commented on the issue: https://github.com/apache/geode-native/pull/21 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #388: GEODE-2428: Adding support of Serialization/deserializatio...
Github user davinash commented on the issue: https://github.com/apache/geode/pull/388 Thanks @metatype and @bschuchardt I will fix import issue and check-in the changes to develop, once all the checks have passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #390: [GEODE-1887] #comment Fix Issue Client PROXY region...
Github user davinash commented on a diff in the pull request:
https://github.com/apache/geode/pull/390#discussion_r103070526
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscDUnitTest.java
---
@@ -773,6 +755,73 @@ public void
clientIsPreventedFromConnectingToLocatorAsServer() throws Exception
}
+ private void proxyRegionClientServerOp(RegionShortcut shortcut) throws
Exception {
+// start server first
+final String REGION_NAME = "proxyRegionClientServerOp";
+PORT1 = initServerCache(false);
+// Create regions on servers.
+server1.invoke(new SerializableCallable() {
+ @Override
+ public Object call() throws Exception {
+Cache c = CacheFactory.getAnyInstance();
+assertNotNull(c);
+Region r =
c.createRegionFactory(shortcut).create(REGION_NAME);
+assertNotNull(r);
+return null;
+ }
+});
+
+String host = NetworkUtils.getServerHostName(server1.getHost());
+
+Properties props = new Properties();
+props.setProperty(MCAST_PORT, "0");
+props.setProperty(LOCATORS, "");
+ClientCacheFactory ccf = new ClientCacheFactory(props);
+ccf.addPoolServer(host, PORT1);
+
+ClientCache clientCache = ccf.create();
+Region clientRegion =
+
clientCache.createClientRegionFactory(ClientRegionShortcut.PROXY).create(REGION_NAME);
+assertNotNull(clientRegion);
+
+// let us populate this region from client.
+for (int i = 0; i < 10; i++) {
+ clientRegion.put(i, i * 10);
+}
+// Verify using gets
+for (int i = 0; i < 10; i++) {
+ assertEquals(i * 10, clientRegion.get(i));
+}
+assertEquals(10, clientRegion.size());
+assertFalse(clientRegion.isEmpty());
+// delete all the entries from the server
+server1.invoke(new SerializableCallable() {
+ @Override
+ public Object call() throws Exception {
+Cache c = CacheFactory.getAnyInstance();
+assertNotNull(c);
+Region r = c.getRegion(REGION_NAME);
+assertNotNull(r);
+for (int i = 0; i < 10; i++) {
+ r.remove(i);
+}
+return null;
+ }
+});
+assertEquals(0, clientRegion.size());
+assertTrue(clientRegion.isEmpty());
+
+clientRegion.destroyRegion();
+clientCache.close();
+ }
+
+ @Test
--- End diff --
Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #390: [GEODE-1887] #comment Fix Issue Client PROXY region...
Github user davinash commented on a diff in the pull request:
https://github.com/apache/geode/pull/390#discussion_r103070521
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscDUnitTest.java
---
@@ -773,6 +755,73 @@ public void
clientIsPreventedFromConnectingToLocatorAsServer() throws Exception
}
+ private void proxyRegionClientServerOp(RegionShortcut shortcut) throws
Exception {
+// start server first
+final String REGION_NAME = "proxyRegionClientServerOp";
+PORT1 = initServerCache(false);
+// Create regions on servers.
+server1.invoke(new SerializableCallable() {
--- End diff --
Fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #390: [GEODE-1887] #comment Fix Issue Client PROXY region...
Github user davinash commented on a diff in the pull request:
https://github.com/apache/geode/pull/390#discussion_r103070525
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientServerMiscDUnitTest.java
---
@@ -773,6 +755,73 @@ public void
clientIsPreventedFromConnectingToLocatorAsServer() throws Exception
}
+ private void proxyRegionClientServerOp(RegionShortcut shortcut) throws
Exception {
+// start server first
+final String REGION_NAME = "proxyRegionClientServerOp";
+PORT1 = initServerCache(false);
+// Create regions on servers.
+server1.invoke(new SerializableCallable() {
+ @Override
+ public Object call() throws Exception {
+Cache c = CacheFactory.getAnyInstance();
+assertNotNull(c);
+Region r =
c.createRegionFactory(shortcut).create(REGION_NAME);
+assertNotNull(r);
+return null;
+ }
+});
+
+String host = NetworkUtils.getServerHostName(server1.getHost());
+
+Properties props = new Properties();
+props.setProperty(MCAST_PORT, "0");
+props.setProperty(LOCATORS, "");
+ClientCacheFactory ccf = new ClientCacheFactory(props);
+ccf.addPoolServer(host, PORT1);
+
+ClientCache clientCache = ccf.create();
+Region clientRegion =
+
clientCache.createClientRegionFactory(ClientRegionShortcut.PROXY).create(REGION_NAME);
+assertNotNull(clientRegion);
+
+// let us populate this region from client.
+for (int i = 0; i < 10; i++) {
+ clientRegion.put(i, i * 10);
+}
+// Verify using gets
+for (int i = 0; i < 10; i++) {
+ assertEquals(i * 10, clientRegion.get(i));
+}
+assertEquals(10, clientRegion.size());
+assertFalse(clientRegion.isEmpty());
+// delete all the entries from the server
+server1.invoke(new SerializableCallable() {
+ @Override
+ public Object call() throws Exception {
+Cache c = CacheFactory.getAnyInstance();
--- End diff --
Fixed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #390: [GEODE-1887] #comment Fix Issue Client PROXY region should...
Github user davinash commented on the issue: https://github.com/apache/geode/pull/390 Thanks @kirklund Addressed review comment. Please let me know if this is PR is now good for merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #315: GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQ...
Github user davinash commented on the issue: https://github.com/apache/geode/pull/315 @metatype , @dschneider-pivotal Please let me know if this is good to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #388: GEODE-2428: Adding support of Serialization/deseria...
Github user davinash closed the pull request at: https://github.com/apache/geode/pull/388 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #388: GEODE-2428: Adding support of Serialization/deserializatio...
Github user davinash commented on the issue: https://github.com/apache/geode/pull/388 Closing, merged to develop --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #390: [GEODE-1887] #comment Fix Issue Client PROXY region...
Github user davinash closed the pull request at: https://github.com/apache/geode/pull/390 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #315: GEODE-1995: Removed ReliableMessageQueue, ReliableM...
Github user davinash closed the pull request at: https://github.com/apache/geode/pull/315 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #440: GEODE-2723: Removed localCacheEnabled field, and as...
GitHub user davinash opened a pull request: https://github.com/apache/geode/pull/440 GEODE-2723: Removed localCacheEnabled field, and associated dead code. - Removed localCacheEnabled field, and associated dead code. - Ran pre-checkin, no failures. You can merge this pull request into a Git repository by running: $ git pull https://github.com/davinash/geode feature/GEODE-2723 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/440.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #440 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #443: [GEODE-1887] #comment Fix for Client PROXY region s...
GitHub user davinash opened a pull request: https://github.com/apache/geode/pull/443 [GEODE-1887] #comment Fix for Client PROXY region should delegate all operations to server Fix for Client PROXY region should delegate all operations to server - Resubmitting the PR. - Separated the Test - Ran Precheckin and no failures. You can merge this pull request into a Git repository by running: $ git pull https://github.com/davinash/geode feature/GEODE-1887.II Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/443.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #443 commit 179878e6fca09a30a87dacf61d771bf5b05a51e5 Author: adongre Date: 2017-04-06T17:35:03Z GEODE-1887: Now Size api goes through ServerProxy when cache is of type client and DataPolicy is Empty. commit 8b2184e044182acda3b5dba1417f7c02d5e75e2c Author: adongre Date: 2017-04-07T12:31:31Z GEODE-1887: Fixing Spotless errors. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #450: GEODE-2632: create ClientCachePutBench
Github user davinash commented on the issue: https://github.com/apache/geode/pull/450 +1. @kirklund what is correct way of running those benchmark. Is following command correct ./gradlew :geode-core:jmh --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #456: GEODE-72 : Remove deprecated APIs from Geode
GitHub user davinash opened a pull request: https://github.com/apache/geode/pull/456 GEODE-72 : Remove deprecated APIs from Geode This PR fixes following - GEODE-236 Remove deprecated CacheEvent methods - GEODE-237 Remove EntryEvent deprecated methods - GEODE-253 Remove deprecated EntryNotFoundInRegion - GEODE-255 Remove deprecated DataSerializer.register(Class,byte) - GEODE-258 Remove deprecated Cache.getLoggerI18n and getSecurityLoggerI18n methods - GEODE-260 Remove deprecated RemoteTransactionException - GEODE-266 Remove deprecated ObjectSizerImpl - GEODE-267 Remove deprecated ThreadInterruptedException - GEODE-289 Remove deprecated LicenseException Testing : Precheckin Passed with one failure ExportLogsDUnitTest.testExportWithStartAndEndDateTimeFiltering But When I ran this test individually from command line and IDE no failures seen. You can merge this pull request into a Git repository by running: $ git pull https://github.com/davinash/geode feature/GEODE-72 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/456.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #456 commit e49b05a4b684b3b6f1cb40b692a6c0161058a8f9 Author: adongre Date: 2017-04-13T02:15:29Z GEODE-236: Removed deprecated CacheEvent methods isExpiration and isDistributed removed from CacheEvent. All the usage in the code and test are replaced with CacheEvent.getOperation Refactored TXJUnitTest test for event property validations. commit 2196bd5e3200baa08669fd25beba331b7982480d Author: adongre Date: 2017-04-13T02:20:39Z GEODE-253: Removed depreated and not used EntryNotFoundInRegion class commit f1e4b4366694729dd73006e26f2ca166b54f2e15 Author: adongre Date: 2017-04-13T02:21:34Z GEODE-260: Removed deprecated and not used RemoteTransactionException class commit 844e83cc0b46b8fc35fae0802db2ed7f2713c6d7 Author: adongre Date: 2017-04-13T02:23:42Z GEODE-266: Removed ObjectSizerImpl and its usage is replace with ObjectSizer.DEFAULT commit caf4e2b033b2780323a18626fbb844a84fa97a60 Author: adongre Date: 2017-04-13T02:24:38Z GEODE-267: Removed deprecated ThreadInterruptedException class commit 4d50c2a719f5d8eecab2ba1198784df0c1886fe2 Author: adongre Date: 2017-04-13T02:25:26Z GEODE-289: Removed depcreated LicenseException class commit 81c019724ac4c735fbe89f44ebfbf2e63eb73da4 Author: adongre Date: 2017-04-13T05:04:14Z GEODE-237: Removed deprecated API from EntryEvent 1. isLocalLoad 2. isNetLoad 3. isLoad 4. isNetSearch 5. isBridgeEvent commit 4f5177e2a7ebad6da8b573c0e14b48044f2c8de0 Author: adongre Date: 2017-04-13T05:29:26Z GEODE-255: Removed deprecated DataSerializer.register(Class,byte) commit b9e851d355dff477037f1063b9b393108483431b Author: adongre Date: 2017-04-13T05:48:31Z GEODE-258: Removed deprecated Cache.getLoggerI18n and getSecurityLoggerI18n methods commit 9cc3445fe88ce74a1ba665d71c2011cd676bf3e0 Author: adongre Date: 2017-04-13T09:04:21Z GEODE-258: ServerConnectionTest fails. Cache is created using mock which does not initializes the DistributedSystem. In this particular case c.getLogger() will fail with NPE. Guarding NPE in ServerConnection CTOR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #456: GEODE-72 : Remove deprecated APIs from Geode
Github user davinash commented on the issue: https://github.com/apache/geode/pull/456 @kirklund , I will create separate PR for each JIRA and then will close this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #463: GEODE-236: Removed deprecated CacheEvent methods
GitHub user davinash opened a pull request: https://github.com/apache/geode/pull/463 GEODE-236: Removed deprecated CacheEvent methods Removed deprecated CacheEvent methods You can merge this pull request into a Git repository by running: $ git pull https://github.com/davinash/geode feature/GEODE-236 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/463.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #463 commit f9cd9793efcfa8fb40c0fef03b88ee8689114a2a Author: adongre Date: 2017-04-19T10:19:43Z GEODE-236: Removed deprecated CacheEvent methods --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #464: GEODE-237: Removed deprecated API from EntryEvent
GitHub user davinash opened a pull request: https://github.com/apache/geode/pull/464 GEODE-237: Removed deprecated API from EntryEvent Removed deprecated CacheEvent methods You can merge this pull request into a Git repository by running: $ git pull https://github.com/davinash/geode feature/GEODE-237 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/464.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #464 commit 69c7d997c340efe9cfd3ba755f529ee113d1e2ad Author: adongre Date: 2017-04-19T08:41:49Z GEODE-237: Removed deprecated API from EntryEvent 1. isLocalLoad 2. isNetLoad 3. isLoad 4. isNetSearch 5. isBridgeEvent --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #465: GEODE-253: Removed depreated and not used EntryNotF...
GitHub user davinash opened a pull request: https://github.com/apache/geode/pull/465 GEODE-253: Removed depreated and not used EntryNotFoundInRegion class Removed depreated and not used EntryNotFoundInRegion class You can merge this pull request into a Git repository by running: $ git pull https://github.com/davinash/geode feature/GEODE-253 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/465.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #465 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #466: GEODE-255: Removed deprecated DataSerializer.regist...
GitHub user davinash opened a pull request: https://github.com/apache/geode/pull/466 GEODE-255: Removed deprecated DataSerializer.register(Class,byte) Removed deprecated DataSerializer.register(Class,byte) You can merge this pull request into a Git repository by running: $ git pull https://github.com/davinash/geode feature/GEODE-255 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/466.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #466 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #467: GEODE-258: Remove deprecated Cache.getLoggerI18n an...
GitHub user davinash opened a pull request: https://github.com/apache/geode/pull/467 GEODE-258: Remove deprecated Cache.getLoggerI18n and getSecurityLoggerI18n methods You can merge this pull request into a Git repository by running: $ git pull https://github.com/davinash/geode feature/GEODE-258 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/467.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #467 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #468: GEODE-260: Remove deprecated RemoteTransactionExcep...
GitHub user davinash opened a pull request: https://github.com/apache/geode/pull/468 GEODE-260: Remove deprecated RemoteTransactionException You can merge this pull request into a Git repository by running: $ git pull https://github.com/davinash/geode feature/GEODE-260 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/468.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #468 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #469: GEODE-266: Remove the deprecated ObjectSizerImpl cl...
GitHub user davinash opened a pull request: https://github.com/apache/geode/pull/469 GEODE-266: Remove the deprecated ObjectSizerImpl class You can merge this pull request into a Git repository by running: $ git pull https://github.com/davinash/geode feature/GEODE-266 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/469.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #469 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #470: GEODE-267: Remove deprecated ThreadInterruptedExcep...
GitHub user davinash opened a pull request: https://github.com/apache/geode/pull/470 GEODE-267: Remove deprecated ThreadInterruptedException You can merge this pull request into a Git repository by running: $ git pull https://github.com/davinash/geode feature/GEODE-267 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/470.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #470 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #471: GEODE-289: Remove depcreated LicenseException class
GitHub user davinash opened a pull request: https://github.com/apache/geode/pull/471 GEODE-289: Remove depcreated LicenseException class You can merge this pull request into a Git repository by running: $ git pull https://github.com/davinash/geode feature/GEODE-289 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/471.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #471 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #456: GEODE-72 : Remove deprecated APIs from Geode
Github user davinash commented on the issue: https://github.com/apache/geode/pull/456 closing this PR, as I have opened separate PR for each subtask. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #456: GEODE-72 : Remove deprecated APIs from Geode
Github user davinash closed the pull request at: https://github.com/apache/geode/pull/456 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #469: GEODE-266: Remove the deprecated ObjectSizerImpl class
Github user davinash commented on the issue: https://github.com/apache/geode/pull/469 Is this PR OK to merge ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #468: GEODE-260: Remove deprecated RemoteTransactionException
Github user davinash commented on the issue: https://github.com/apache/geode/pull/468 Thanks @upthewaterspout for review Is this PR OK to merge ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #466: GEODE-255: Removed deprecated DataSerializer.register(Clas...
Github user davinash commented on the issue: https://github.com/apache/geode/pull/466 Thanks @upthewaterspout for review Is this PR OK to merge ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #465: GEODE-253: Removed depreated and not used EntryNotFoundInR...
Github user davinash commented on the issue: https://github.com/apache/geode/pull/465 Thanks @upthewaterspout for review Is this PR OK to merge ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode pull request #291: [GEODE-1122] Fixed Dependency on environm...
GitHub user davinash opened a pull request: https://github.com/apache/incubator-geode/pull/291 [GEODE-1122] Fixed Dependency on environment variable GEMFIRE needs to be removed All Test Passing. You can merge this pull request into a Git repository by running: $ git pull https://github.com/davinash/incubator-geode feature/GEODE-1122 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-geode/pull/291.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #291 commit d8a2d94aae096444cca43ba3d1f3356421b8d439 Author: adongre Date: 2016-11-16T06:59:12Z GEODE-1122: Removing dependency on the environment variable GEMFIRE to GEODE_HOME commit a91d1f278ea60b410876a22da44d7f44e65e1395 Author: adongre Date: 2016-11-16T07:25:34Z GEODE-1122: Updating gfsh scripts to use GEODE_HOME commit ec204b51d45413a5cb17d91f9955db4083b95141 Author: adongre Date: 2016-11-17T08:56:25Z GEODE-1122: Fixing REST Related Dunit Tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode pull request #291: [GEODE-1122] Fixed Dependency on environm...
Github user davinash commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/291#discussion_r88781673
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/AgentUtil.java ---
@@ -52,7 +52,7 @@ public AgentUtil(String gemfireVersion) {
*geode-web-api
*/
public String findWarLocation(String warFilePrefix) {
-String gemfireHome = getGemFireHome();
+String gemfireHome = getGeodeHome();
--- End diff --
Fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request #291: [GEODE-1122] Fixed Dependency on environm...
Github user davinash commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/291#discussion_r88781680
--- Diff:
geode-assembly/src/test/java/org/apache/geode/management/internal/configuration/SharedConfigurationEndToEndDUnitTest.java
---
@@ -146,6 +146,8 @@ public void testStartServerAndExecuteCommands() throws
Exception {
CommandResult cmdResult = executeCommand(gfsh,
csb.getCommandString());
+ System.out.println("cmdResult = " + cmdResult);
--- End diff --
Fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode issue #291: [GEODE-1122] Fixed Dependency on environment var...
Github user davinash commented on the issue: https://github.com/apache/incubator-geode/pull/291 Thanks for Review @metatype --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode pull request #291: [GEODE-1122] Fixed Dependency on environm...
Github user davinash commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/291#discussion_r88781685
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java
---
@@ -1493,6 +1495,7 @@ public Result startServer(
help = CliStrings.START_SERVER__PASSWORD__HELP) String
passwordToUse)
// NOTICE: keep the parameters in alphabetical order based on their
CliStrings.START_SERVER_* text
{
+System.out.println("GEODE_HOME = " + GEODE_HOME);
--- End diff --
Fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode issue #291: [GEODE-1122] Fixed Dependency on environment var...
Github user davinash commented on the issue: https://github.com/apache/incubator-geode/pull/291 Is this PR now good for merge to develop now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode pull request #295: [GEODE-1984] #comment Fix Issue Make Gate...
GitHub user davinash opened a pull request: https://github.com/apache/incubator-geode/pull/295 [GEODE-1984] #comment Fix Issue Make GatewaySender destroy a public API 1. Making destory API public 2. Added a new gfsh WAN command destroyGatewaySender 3. Impleted GatewaySenderDestroyFunction, which first stop gatewaysender and then call destroy on the same. 4. Added a WAN Rest Controller for destroy gatewaysender 5. Removed the need of explicit casting of sender to AbstractGatewaySender for calling destroy API 6. Renamed Test WanCommandCreateGatewaySenderDUnitTest to WanCommandCreateDestroyGatewaySenderDUnitTest 7. Each applicable test now also calls destroy gfsh command and verfies the result 8. Minor changes in the logging for each tests Precheckin is passing. You can merge this pull request into a Git repository by running: $ git pull https://github.com/davinash/incubator-geode feature/GEODE-1984 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-geode/pull/295.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #295 commit 008309dd6bd01d101071c6caa1786657e84953b3 Author: Anthony Baker Date: 2016-02-08T16:58:07Z Merge branch 'release/1.0.0-incubating.M1' commit 347d78ce0c9f2fe53d619aef60381fb2f3d8f919 Author: Lynn Hughes-Godfrey Date: 2016-04-07T20:49:02Z Added keys for Lynn Hughes-Godfrey commit a745ce9e9a9f706c6b4977ae059852be3994e8ab Author: Dan Smith Date: 2016-04-22T00:36:50Z Merge branch 'release/1.0.0-incubating.M2' Overrode the KEYS file that was accidentally checked in to master. commit 2e1075246a5c95dcd087fe497bae0df323acfdbd Author: Anthony Baker Date: 2016-08-22T16:38:09Z Merge branch 'release/1.0.0-incubating.M3' commit c3162e0b9d7315c4665ebd05e26515228f9e89de Author: zhouxh Date: 2016-10-10T18:20:25Z GEODE-1956: fix the race condition that cause the vm only hosts 1 primary bucket commit 639c856021ec9321cdc0895a5e1503a6296dc765 Author: Anthony Baker Date: 2016-10-10T18:38:51Z Revert "GEODE-1956: fix the race condition that cause the vm only hosts 1 primary bucket" This reverts commit c3162e0b9d7315c4665ebd05e26515228f9e89de. commit 09d7b5ce2817bcd1ae7e7b09f32dce995b9cfcf5 Author: Swapnil Bawaskar Date: 2016-10-25T06:18:28Z Merge branch 'release/1.0.0-incubating' commit bf1fba82163b0c65857dbaf70eca3bcda2e40f1e Author: adongre Date: 2016-11-19T09:45:43Z Merge remote-tracking branch 'upstream/master' into develop commit f4521776eeccb36ad9e9d80c1d322e38492334ab Author: adongre Date: 2016-11-19T09:47:35Z Merge remote-tracking branch 'upstream/develop' into develop commit 6af49b5e4e0fef85fa31cf9f9af539773baf7178 Author: adongre Date: 2016-11-19T10:34:53Z GEODE-1984: Making public GateWaySender API 'destroy' commit 93d4c08e2923474b40b153f7cabfbda0dce20ef8 Author: adongre Date: 2016-11-19T15:26:25Z GEODE-1984: Started writing gfsh command for destroy gateway-sender commit c8228f16a6c984bf8cf1e94533d9e88231311dd4 Author: adongre Date: 2016-11-19T17:40:45Z GEODE-1984: Added a new WanCommand to destroy a gateway-sender Implemented GatewaySenderDestroyFunctionArgs and GatewaySenderDestroyFunction Started writing a test for destroy functionality. [ WIP ] commit eb994e1320af01c3e37697b9d942fd25c181c01c Author: adongre Date: 2016-11-20T12:08:11Z GEODE-1984: Fixing the logic of destroying a gateway sender, one need to stop the gatewaySender before calling destroy. commit 43e45a96891fbc5338e5e9649b297f8372b15c88 Author: adongre Date: 2016-11-20T15:25:37Z GEODE-1984: 1. Added verifySenderDestroyed from WANTestBase to WANCommandTestBase 2. Moved Test WanCommandCreateGatewaySenderDUnitTest to WanCommandCreateDestroyGatewaySenderDUnitTest to include gateway-sender destroy command 3. Updating the logging in all the tests commit 24a4dc44e8d00ba9c56d828fb311dbae42974dfc Author: adongre Date: 2016-11-21T08:33:48Z GEODE-1984: Adding more Tests and fixing the error message commit d15f7d6d5f494b1ba905790a329eb2cc724f5680 Author: adongre Date: 2016-11-22T06:35:37Z GEODE-1984: 1. Fixing Test failures for ShellCommandsControllerJUnitTest,AnalyzeSerializablesJUnitTest,HelpCommandsIntegrationTest,HelpCommandsIntegrationTest 2. Added Rest Request for gateway-sender destroy in WanCommandsController --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode issue #291: [GEODE-1122] Fixed Dependency on environment var...
Github user davinash commented on the issue: https://github.com/apache/incubator-geode/pull/291 @metatype Thanks for the review, I think I messed up in my local git repo. I am always getting ``` ~/source/open/incubator-geode (feature/GEODE-1122) $ git flow feature finish -rF GEODE-1122 Branches 'develop' and 'origin/develop' have diverged. Fatal: Branches need merging first. ``` I tried rebase and other solutions, but nothing is working. Could you please help this time to merge this change to develop. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode pull request #291: [GEODE-1122] Fixed Dependency on environm...
Github user davinash closed the pull request at: https://github.com/apache/incubator-geode/pull/291 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode pull request #295: [GEODE-1984] #comment Fix Issue Make Gate...
Github user davinash closed the pull request at: https://github.com/apache/incubator-geode/pull/295 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode issue #298: [GEODE-1122] Fix Dependency on environment varia...
Github user davinash commented on the issue: https://github.com/apache/incubator-geode/pull/298 @metatype I have re-created a Pull Request and closed the earlier one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode pull request #298: [GEODE-1122] Fix Dependency on environmen...
GitHub user davinash opened a pull request: https://github.com/apache/incubator-geode/pull/298 [GEODE-1122] Fix Dependency on environment variable GEMFIRE needs to be removed You can merge this pull request into a Git repository by running: $ git pull https://github.com/davinash/incubator-geode feature/GEODE-1122 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-geode/pull/298.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #298 commit b151fa7e6bf95b970d3d3d95552749ffa8cd31db Author: adongre Date: 2016-11-26T08:07:48Z GEODE-1122: Replace environment variable "GEMFIRE" with "GEODE_HOME" commit a83c789875d38d33c8fb87b8e53cfdb70d5dbd2b Author: adongre Date: 2016-11-27T12:35:00Z GEODE-1122: Reverting gradle-wrapper.properties --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode issue #298: [GEODE-1122] Fix Dependency on environment varia...
Github user davinash commented on the issue: https://github.com/apache/incubator-geode/pull/298 This closes #298 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode pull request #298: [GEODE-1122] Fix Dependency on environmen...
Github user davinash closed the pull request at: https://github.com/apache/incubator-geode/pull/298 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode pull request #299: [ GEODE-2141 ] #comment Fix Issue #2141
GitHub user davinash opened a pull request: https://github.com/apache/incubator-geode/pull/299 [ GEODE-2141 ] #comment Fix Issue #2141 Replaced List with ConcurrentHashSet You can merge this pull request into a Git repository by running: $ git pull https://github.com/davinash/incubator-geode feature/GEODE-2141 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-geode/pull/299.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #299 commit e4da4c43dc691e59d34640e95c5d63a5a1b0ea1c Author: adongre Date: 2016-11-27T14:11:48Z GEODE-2141: Replace use of List with ConcurrentHashSet for storing various stats and listener. Moved methods stopNotifier_IfEnabledAndRunning and startNotifier_IfEnabledAndNotRunning in synchronized block. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode pull request #283: GEODE-2098: Moved gfsh history file locat...
Github user davinash closed the pull request at: https://github.com/apache/incubator-geode/pull/283 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode issue #283: GEODE-2098: Moved gfsh history file location fro...
Github user davinash commented on the issue: https://github.com/apache/incubator-geode/pull/283 closing the pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode issue #299: [ GEODE-2141 ] #comment Fix Issue #2141
Github user davinash commented on the issue: https://github.com/apache/incubator-geode/pull/299 Thanks @upthewaterspout , @metatype for review I Have address review comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode issue #299: [ GEODE-2141 ] #comment Fix Issue #2141
Github user davinash commented on the issue: https://github.com/apache/incubator-geode/pull/299 Is this PR good to merge to develop ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode pull request #299: [ GEODE-2141 ] #comment Fix Issue #2141
Github user davinash closed the pull request at: https://github.com/apache/incubator-geode/pull/299 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode issue #295: [GEODE-1984] #comment Fix Issue Make GatewaySend...
Github user davinash commented on the issue: https://github.com/apache/incubator-geode/pull/295 Hi @metatype Could you please deleting branch GEODE-1984 from master. I am getting error. git flow feature start GEODE-1984 Fatal: Branch 'feature/GEODE-1984' already exists. Pick another name. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode issue #295: [GEODE-1984] #comment Fix Issue Make GatewaySend...
Github user davinash commented on the issue: https://github.com/apache/incubator-geode/pull/295 I have no problem with write access and have deleted local branch. But I get following error. ``` git push origin --delete feature/GEODE-1984 error: unable to delete 'feature/GEODE-1984': remote ref does not exist error: failed to push some refs to 'https://git-wip-us.apache.org/repos/asf/incubator-geode.git' ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode pull request #303: GEODE-1984: Fix Issue Make GatewaySender ...
GitHub user davinash opened a pull request: https://github.com/apache/incubator-geode/pull/303 GEODE-1984: Fix Issue Make GatewaySender destroy a public API 1. Making destory API public 2. Added a new gfsh WAN command destroyGatewaySender 3. Impleted GatewaySenderDestroyFunction, which first stop gatewaysender and then call destroy on the same. 4. Added a WAN Rest Controller for destroy gatewaysender 5. Removed the need of explicit casting of sender to AbstractGatewaySender for calling destroy API 6. Renamed Test WanCommandCreateGatewaySenderDUnitTest to WanCommandCreateDestroyGatewaySenderDUnitTest 7. Each applicable test now also calls destroy gfsh command and verfies the result 8. Minor changes in the logging for each tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/davinash/incubator-geode bugfix/GEODE-1984 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-geode/pull/303.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #303 commit 610b620e12b3b8f4198238cd562d5c3f0d8cd669 Author: adongre Date: 2016-12-03T14:08:39Z GEODE-1984: Fix Issue Make GatewaySender destroy a public API 1. Making destory API public 2. Added a new gfsh WAN command destroyGatewaySender 3. Impleted GatewaySenderDestroyFunction, which first stop gatewaysender and then call destroy on the same. 4. Added a WAN Rest Controller for destroy gatewaysender 5. Removed the need of explicit casting of sender to AbstractGatewaySender for calling destroy API 6. Renamed Test WanCommandCreateGatewaySenderDUnitTest to WanCommandCreateDestroyGatewaySenderDUnitTest 7. Each applicable test now also calls destroy gfsh command and verfies the result 8. Minor changes in the logging for each tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #303: GEODE-1984: Fix Issue Make GatewaySender destroy a public ...
Github user davinash commented on the issue: https://github.com/apache/geode/pull/303 Please help to review this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #303: GEODE-1984: Fix Issue Make GatewaySender destroy a ...
Github user davinash commented on a diff in the pull request: https://github.com/apache/geode/pull/303#discussion_r91421904 --- Diff: geode-core/src/main/java/org/apache/geode/cache/wan/GatewaySender.java --- @@ -400,4 +400,19 @@ public int getMaxParallelismForReplicatedRegion(); + + /** + * Destroys the GatewaySender. Before destroying the sender, caller needs to to ensure that the --- End diff -- Fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #303: GEODE-1984: Fix Issue Make GatewaySender destroy a ...
Github user davinash commented on a diff in the pull request:
https://github.com/apache/geode/pull/303#discussion_r91422055
--- Diff:
geode-wan/src/test/java/org/apache/geode/internal/cache/wan/wancommand/WanCommandCreateDestroyGatewaySenderDUnitTest.java
---
@@ -55,7 +55,7 @@ private CommandResult
executeCommandWithIgnoredExceptions(String command) {
* GatewaySender with all default attributes
--- End diff --
I thought it would be good to have the same Test. Any new create scenario
will also have associated destroy command.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #303: GEODE-1984: Fix Issue Make GatewaySender destroy a ...
Github user davinash commented on a diff in the pull request: https://github.com/apache/geode/pull/303#discussion_r91422209 --- Diff: geode-core/src/main/java/org/apache/geode/cache/wan/GatewaySender.java --- @@ -400,4 +400,19 @@ public int getMaxParallelismForReplicatedRegion(); + + /** + * Destroys the GatewaySender. Before destroying the sender, caller needs to to ensure that the + * sender is stopped so that all the resources (threads, connection pool etc.) will be released + * properly. Stopping the sender is not handled in the destroy. Destroy is carried out in + * following steps: 1. Take the lifeCycleLock. 2. If the sender is attached to any application + * region, throw an exception. 3. Close the GatewaySenderAdvisor. 4. Remove the sender from the + * cache. 5. Destroy the region underlying the GatewaySender. + * + * In case of ParallelGatewaySender, the destroy operation does distributed destroy of the QPR. In + * case of SerialGatewaySender, the queue region is destroyed locally. --- End diff -- Fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #303: GEODE-1984: Fix Issue Make GatewaySender destroy a ...
Github user davinash commented on a diff in the pull request:
https://github.com/apache/geode/pull/303#discussion_r91422194
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/GatewaySenderDestroyFunction.java
---
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF
ANY KIND, either express
+ * or implied. See the License for the specific language governing
permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.management.internal.cli.functions;
+
+import org.apache.geode.cache.Cache;
+import org.apache.geode.cache.CacheFactory;
+import org.apache.geode.cache.execute.FunctionAdapter;
+import org.apache.geode.cache.execute.FunctionContext;
+import org.apache.geode.cache.execute.ResultSender;
+import org.apache.geode.cache.wan.GatewaySender;
+import org.apache.geode.internal.InternalEntity;
+import org.apache.geode.internal.cache.wan.GatewaySenderException;
+import org.apache.geode.internal.logging.LogService;
+import org.apache.geode.management.internal.cli.CliUtil;
+import org.apache.geode.management.internal.cli.i18n.CliStrings;
+import org.apache.logging.log4j.Logger;
+
+public class GatewaySenderDestroyFunction extends FunctionAdapter
implements InternalEntity {
+ private static final long serialVersionUID = 1459761440357690134L;
+
+ private static final Logger logger = LogService.getLogger();
+ private static final String ID =
GatewaySenderDestroyFunction.class.getName();
+ public static GatewaySenderDestroyFunction INSTANCE = new
GatewaySenderDestroyFunction();
+
+ @Override
+ public void execute(FunctionContext context) {
+ResultSender resultSender = context.getResultSender();
+
+Cache cache = CacheFactory.getAnyInstance();
+String memberNameOrId =
+
CliUtil.getMemberNameOrId(cache.getDistributedSystem().getDistributedMember());
+
+GatewaySenderDestroyFunctionArgs gatewaySenderDestroyFunctionArgs =
+(GatewaySenderDestroyFunctionArgs) context.getArguments();
+
+try {
+ GatewaySender gatewaySender =
+ cache.getGatewaySender(gatewaySenderDestroyFunctionArgs.getId());
+ if (gatewaySender != null) {
+gatewaySender.stop();
--- End diff --
Looking at the code AbstractGatewaySenderEventProcessor#closeProcessor, It
looks like stop logs the warning and goes ahead with closing. I think we should
open separate JIRA for stop behaviour.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #303: GEODE-1984: Fix Issue Make GatewaySender destroy a ...
Github user davinash commented on a diff in the pull request:
https://github.com/apache/geode/pull/303#discussion_r91458212
--- Diff:
geode-wan/src/test/java/org/apache/geode/internal/cache/wan/wancommand/WanCommandCreateDestroyGatewaySenderDUnitTest.java
---
@@ -282,13 +335,40 @@ public void
testCreateGatewaySenderWithGatewayEventFilters() {
1000, 5000, true, false, 1000, 100, 2, OrderPolicy.THREAD,
eventFilters, null));
vm5.invoke(() -> verifySenderAttributes("ln", 2, false, true, 1000,
socketReadTimeout, true,
1000, 5000, true, false, 1000, 100, 2, OrderPolicy.THREAD,
eventFilters, null));
+
+// Test Destroy Command.
+command =
+CliStrings.DESTROY_GATEWAYSENDER + " --" +
CliStrings.DESTROY_GATEWAYSENDER__ID + "=ln";
--- End diff --
fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #303: GEODE-1984: Fix Issue Make GatewaySender destroy a public ...
Github user davinash commented on the issue: https://github.com/apache/geode/pull/303 Thanks @upthewaterspout , @jhuynh1 for review. I have address comments. Please let me know now if this PR OK to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #303: GEODE-1984: Fix Issue Make GatewaySender destroy a ...
Github user davinash closed the pull request at: https://github.com/apache/geode/pull/303 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #312: [GEODE-2061] Fix for Remove PdxInstanceInputStream
GitHub user davinash opened a pull request: https://github.com/apache/geode/pull/312 [GEODE-2061] Fix for Remove PdxInstanceInputStream - Removed PdxInstanceInputStream - Removed usage of PdxInstanceInputStream and replace with PdxInputStream You can merge this pull request into a Git repository by running: $ git pull https://github.com/davinash/geode feature/GEODE-2061 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/312.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #312 commit 0722fcd83b13c6bc7a362f7c43cd5f682854d56c Author: adongre Date: 2016-12-11T17:11:22Z GEODE-2061: Removed PdxInstanceInputStream and its references replace by PdxInputStream commit e74787ce619a90f044840bd5fcc44d2eb39e9fb0 Author: adongre Date: 2016-12-12T16:41:07Z GEODE-2061: Construct PdxInputStream properly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #312: [GEODE-2061] Fix for Remove PdxInstanceInputStream
Github user davinash commented on the issue: https://github.com/apache/geode/pull/312 CC @bschuchardt --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #312: [GEODE-2061] Fix for Remove PdxInstanceInputStream
Github user davinash closed the pull request at: https://github.com/apache/geode/pull/312 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #315: GEODE-1995: Removed ReliableMessageQueue, ReliableM...
GitHub user davinash opened a pull request: https://github.com/apache/geode/pull/315 GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQueueFactory⦠â¦, ReliableMessageQueueFactoryImpl and it's usage in the code from GemfireCacheImpl and DistributedRegion. CC @dschneider-pivotal You can merge this pull request into a Git repository by running: $ git pull https://github.com/davinash/geode feature/GEODE-1995 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/315.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #315 commit 7fdf95086d1f31e5520c449c254a9a07d813fbe8 Author: adongre Date: 2016-12-13T07:20:31Z GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQueueFactory, ReliableMessageQueueFactoryImpl and it's usage in the code from GemfireCacheImpl and DistributedRegion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #315: GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQ...
Github user davinash commented on the issue: https://github.com/apache/geode/pull/315 Please review this PR, Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #319: GEODE-1541 : Made statsListUniqueId to be an AtomicLong.
Github user davinash commented on the issue: https://github.com/apache/geode/pull/319 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #322: [GEODE-165] Fix for Add build support for generatin...
GitHub user davinash opened a pull request: https://github.com/apache/geode/pull/322 [GEODE-165] Fix for Add build support for generating antlr classes from grammar 1. Updated spotless configuration to exclude 'generated-src' directory. 2. Removed OQLLexerTokenTypes.java OQLLexerTokenTypes.txt OQLParser.java OQLLexer.java 3. Removed above files entry from rat Thanks @metatype for helping in gradle configuration. You can merge this pull request into a Git repository by running: $ git pull https://github.com/davinash/geode feature/GEODE-165 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/322.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #322 commit d68d32c63fa90254b34116320bc2889a366c12c3 Author: adongre Date: 2016-12-16T08:47:10Z GEODE-165: Removed OQL generated files and added the target into geode-core/build.gradle. commit e83732fdd3890783c991a81b824a5c4207a2ddaf Author: adongre Date: 2016-12-17T10:38:55Z GEODE-165 : Updating spotless configuration to exclude 'generated-src' directory. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #315: GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQ...
Github user davinash commented on the issue: https://github.com/apache/geode/pull/315 Thanks @dschneider-pivotal for review, I will make these changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #315: GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQ...
Github user davinash commented on the issue: https://github.com/apache/geode/pull/315 All test passed. Please review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #322: [GEODE-165] Fix for Add build support for generating antlr...
Github user davinash commented on the issue: https://github.com/apache/geode/pull/322 Thanks @upthewaterspout , Is this PR good for merge to develop now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #322: [GEODE-165] Fix for Add build support for generatin...
Github user davinash closed the pull request at: https://github.com/apache/geode/pull/322 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #315: GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQ...
Github user davinash commented on the issue: https://github.com/apache/geode/pull/315 Is this PR looking good now ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #329: [GEODE-1887] #comment Fix for Issue #1887
GitHub user davinash opened a pull request: https://github.com/apache/geode/pull/329 [GEODE-1887] #comment Fix for Issue #1887 Issue : Client PROXY region should delegate all operations to server 1. If client and data policy is empty then size API goes through ServerRegionProxy 2. Wrote a test for Replicated and PR to verify size and isEmpty 3. Precheckin complete You can merge this pull request into a Git repository by running: $ git pull https://github.com/davinash/geode bugfix/GEODE-1887 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/329.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #329 commit ce639204a2d9e0fb7d1df464b5836c83ff041b7a Author: adongre Date: 2017-01-03T10:47:37Z GEODE-1887: Now Size api goes through ServerProxy when cache is of type client and DataPolicy is Empty. Added a test for both PR and Replicated regions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
