GitHub user davinash opened a pull request:

    https://github.com/apache/geode/pull/504

    GEODE-254: Removed deprecated Region.keys and Region.entries

    Addressing review comment from 
    https://github.com/apache/geode/pull/488
    - removed method entries
    - IndexMaintenanceJUnitTest#testIndexMaintenanceWithIndexOnMethodEntries is 
no longer applicable so removed the same.
    - Other than GMSMembershipManagerJUnitTest all tests are passing
    - This also fixed ConsoleDistributionManagerDUnitTest#testApplications, 
which was failing due to my previous fix.
    
    @dschneider-pivotal , @kirklund  Please review.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/davinash/geode feature/GEODE-254.2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/504.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #504
    
----
commit bba87157d39cefcc977ce9207842f0316cbb6729
Author: adongre <adon...@apache.org>
Date:   2017-05-09T19:04:14Z

    GEODE-254: Addressing review comments from PR #488
    Replacing all inststance of entries with entrySet
    
    GEODE-254: Fixing the Test Failures
     - Removed test testIndexMaintenanceWithIndexOnMethodEntries since this is 
no more applicable.
    
    GEODE-254: Spotless fixing.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to