[GitHub] geode issue #585: GEODE-3091: remove empty method
Github user agingade commented on the issue: https://github.com/apache/geode/pull/585 The changes looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #753: GEODE-3283: Expose parallel import and export in gf...
Github user agingade commented on a diff in the pull request: https://github.com/apache/geode/pull/753#discussion_r136640863 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/snapshot/RegionSnapshotServiceImpl.java --- @@ -342,6 +342,7 @@ private void exportOnMember(File snapshot, SnapshotFormat format, SnapshotOption long count = 0; long start = CachePerfStats.getStatTime(); +snapshot.getParentFile().mkdirs(); --- End diff -- Can getParentFile() return null...How about handling failure during mkdirs()... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #753: GEODE-3283: Expose parallel import and export in gf...
Github user agingade commented on a diff in the pull request:
https://github.com/apache/geode/pull/753#discussion_r136644394
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/ImportDataFunction.java
---
@@ -40,9 +40,13 @@ public void execute(FunctionContext context) {
final Object[] args = (Object[]) context.getArguments();
final String regionName = (String) args[0];
final String importFileName = (String) args[1];
-boolean invokeCallbacks = false;
+boolean parallel = false;
if (args.length > 2) {
--- End diff --
Don't we need to check for the total args size? which is always 4. What if
an old gfsh client connected to newer server executes this function (which is
not supported...yet one could do it)...in that case, won't invoke callbacks
value get set to parallel?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #753: GEODE-3283: Expose parallel import and export in gf...
Github user agingade commented on a diff in the pull request:
https://github.com/apache/geode/pull/753#discussion_r136644610
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/ImportDataFunction.java
---
@@ -40,9 +40,13 @@ public void execute(FunctionContext context) {
final Object[] args = (Object[]) context.getArguments();
final String regionName = (String) args[0];
final String importFileName = (String) args[1];
-boolean invokeCallbacks = false;
+boolean parallel = false;
if (args.length > 2) {
--- End diff --
agingade just now Contributor
Don't we need to check for the total args size? which is always 4. What if
an old gfsh client connected to newer server executes this function (which is
not supported...yet one could do it)...in that case, won't invoke callbacks
value get set to parallel?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #477: GEODE-2398: fix oplog corruption in overflow oplogs
Github user agingade commented on a diff in the pull request:
https://github.com/apache/geode/pull/477#discussion_r113087379
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/OverflowOplog.java ---
@@ -724,8 +727,31 @@ public final void flush() throws IOException {
if (bb != null && bb.position() != 0) {
bb.flip();
int flushed = 0;
+ int numChannelRetries = 0;
do {
-flushed += olf.channel.write(bb);
+int channelBytesWritten = 0;
+final int bbStartPos = bb.position();
+final long channelStartPos = olf.channel.position();
+// differentiate between bytes written on this channel.write()
iteration and the
+// total number of bytes written to the channel on this call
+channelBytesWritten += olf.channel.write(bb);
--- End diff --
Instead of "+="; we could just assign the value...Its not really makes any
difference; its just when you read this line, you don't have to know its
previous value...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #322: [GEODE-165] Fix for Add build support for generating antlr...
Github user agingade commented on the issue: https://github.com/apache/geode/pull/322 Earlier the files used to be generated when the grammar files are changed (which was a rare case); with this change are we generating the files, every time when the build/compilation is done? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
