Github user agingade commented on a diff in the pull request:
https://github.com/apache/geode/pull/753#discussion_r136644394
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/ImportDataFunction.java
---
@@ -40,9 +40,13 @@ public void execute(FunctionContext context) {
final Object[] args = (Object[]) context.getArguments();
final String regionName = (String) args[0];
final String importFileName = (String) args[1];
- boolean invokeCallbacks = false;
+ boolean parallel = false;
if (args.length > 2) {
--- End diff --
Don't we need to check for the total args size? which is always 4. What if
an old gfsh client connected to newer server executes this function (which is
not supported...yet one could do it)...in that case, won't invoke callbacks
value get set to parallel?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
