Re: Review Request 59542: GEODE-2974: rename ResultBuilder methods: GemFire -> Geode
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59542/#review176329 --- Ship it! Ship It! - Emily Yeh On May 30, 2017, 5:54 p.m., Ken Howe wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59542/ > --- > > (Updated May 30, 2017, 5:54 p.m.) > > > Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Kirk Lund, > and Patrick Rhomberg. > > > Repository: geode > > > Description > --- > > Change GemFire to Geode in method names and message string > > This is change to simply correct the Gfsh command error strings where > "GemFire" appears. With additional work on Gfsh command error handling > pending (see GEODE-2984), no attempt has been made within the scope of this > issue to reorganize or otherwise improve Gfsh command error messages. > > > Diffs > - > > > geode-core/src/main/java/org/apache/geode/management/internal/cli/result/ResultBuilder.java > 6332540aa4ff6d210ed7f3ba167057de9a0a5023 > > > Diff: https://reviews.apache.org/r/59542/diff/2/ > > > Testing > --- > > 5/30 - precheckin restarted > > precheckin is running > > > Thanks, > > Ken Howe > >
Re: Review Request 59642: GEODE-3000: do not have jetty log at debug level
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59642/#review176493 --- geode-core/src/test/java/org/apache/geode/management/internal/security/LogNoPasswordTest.java Lines 55-59 (patched) <https://reviews.apache.org/r/59642/#comment249848> Perhaps the Scanner should be closed? Just adding `scanner.close()` after the while loop should do it. (Alternatively, scanner could be instantiated before the `for` loop, so that it doesn't have to be re-instantiated during every iteration.) - Emily Yeh On May 31, 2017, 5:45 p.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59642/ > --- > > (Updated May 31, 2017, 5:45 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and > Patrick Rhomberg. > > > Repository: geode > > > Description > --- > > GEODE-3000: do not have jetty log at debug level > > > Diffs > - > > geode-core/src/main/resources/log4j2.xml > cdb932b5b3b3337aae4a6cde9800ebd5617a0c4d > > geode-core/src/test/java/org/apache/geode/management/internal/security/LogNoPasswordTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/59642/diff/1/ > > > Testing > --- > > precheckin successful > > > Thanks, > > Jinmei Liao > >
Re: Review Request 59643: GEODE-3006: reduce the frequency of ping request and reduce the loglevel of login/logout messages
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59643/#review176556 --- Ship it! Ship It! - Emily Yeh On May 31, 2017, 10:46 p.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59643/ > --- > > (Updated May 31, 2017, 10:46 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and > Patrick Rhomberg. > > > Repository: geode > > > Description > --- > > disregard the diff for log4j2.xml changes, these are from the changeset of > another review request. > > > Diffs > - > > > geode-core/src/main/java/org/apache/geode/internal/security/IntegratedSecurityService.java > 600d5462b1d18cfc702d400f6d91c1ac1fab3755 > > geode-core/src/main/java/org/apache/geode/management/internal/web/shell/AbstractHttpOperationInvoker.java > b342c6688e527b0ed67e0210c6f8befa15978818 > > > Diff: https://reviews.apache.org/r/59643/diff/1/ > > > Testing > --- > > precheckin running > > > Thanks, > > Jinmei Liao > >
Re: Review Request 59686: GEODE-2983: correctly handling --J option value that has ", " inside.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59686/#review176783 --- Ship it! Ship It! - Emily Yeh On May 31, 2017, 10:44 p.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59686/ > --- > > (Updated May 31, 2017, 10:44 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and > Patrick Rhomberg. > > > Repository: geode > > > Description > --- > > GEODE-2983: correctly handling --J option value that has "," inside. > > > Diffs > - > > > geode-core/src/main/java/org/apache/geode/management/internal/cli/GfshParser.java > 288ea054ae1230c480d141c0159d6ccf9c299a7d > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java > 74acfd6e03613ac4d0c62fcdd4ea859d1c74d2f2 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/GfshParserParsingTest.java > 4467792f60a2a3bf7cc53cf35e997e7462882539 > > > Diff: https://reviews.apache.org/r/59686/diff/2/ > > > Testing > --- > > precheckin running > > > Thanks, > > Jinmei Liao > >
Re: Review Request 59893: GEODE-3032: Fix CI failure of CommandOverHttpDUnitTest
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59893/#review177237 --- Ship it! Ship It! - Emily Yeh On June 7, 2017, 9:08 p.m., Jared Stewart wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59893/ > --- > > (Updated June 7, 2017, 9:08 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and > Patrick Rhomberg. > > > Repository: geode > > > Description > --- > > GEODE-3032: Fix CI failure of CommandOverHttpDUnitTest > > > Diffs > - > > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/MemberCommandsDUnitTest.java > 5bbfc5b3d4ba1a37f8c1e700a36bd96b4ea40667 > > > Diff: https://reviews.apache.org/r/59893/diff/1/ > > > Testing > --- > > Precheckin is green except for unrelated flaky DUnits. > > > Thanks, > > Jared Stewart > >
Re: Review Request 59754: GEODE-2928: get rid of the isGfshVM static variable
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59754/#review177355
---
geode-core/src/main/java/org/apache/geode/management/cli/CliMetaData.java
Lines 41-42 (original), 41-42 (patched)
<https://reviews.apache.org/r/59754/#comment250911>
A possible nitpick: is this comment missing a period? ("Indicates that the
command will only run in the gfsh shell. Gfsh ExecutionStrategy will use this
flag to determine whether to invoke remote call or not.)
- Emily Yeh
On June 5, 2017, 8:03 p.m., Jinmei Liao wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59754/
> ---
>
> (Updated June 5, 2017, 8:03 p.m.)
>
>
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and
> Patrick Rhomberg.
>
>
> Repository: geode
>
>
> Description
> ---
>
> * consolidate the availability indicators
> * remove the isGfshVM and isGfshVM() method
> * enhance the MultiStepCommand to include info on shellOnly commands to
> enhance command validation
> * remove the SUPPORT_MULTIPLE_GFSH static flag and properly remove the gfsh
> instance at the end of each test
>
>
> Diffs
> -
>
>
> geode-core/src/main/java/org/apache/geode/internal/GfeConsoleReaderFactory.java
> 120d6257b
> geode-core/src/main/java/org/apache/geode/management/cli/CliMetaData.java
> 2e6dc3973
>
> geode-core/src/main/java/org/apache/geode/management/internal/cli/CliUtil.java
> 038e0691e
>
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ClientCommands.java
> e61934261
>
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CommandAvailabilityIndicator.java
> PRE-CREATION
>
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ConfigCommands.java
> bc9c05b81
>
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java
> ad40518f8
>
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DataCommands.java
> cb9c4fe50
>
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DeployCommands.java
> 30d840a0f
>
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java
> 64fafda84
>
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DurableClientCommands.java
> 6441f20cc
>
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportImportClusterConfigurationCommands.java
> 9d263d110
>
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/FunctionCommands.java
> 2774584ff
>
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/GfshCommand.java
> d46024d38
>
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/IndexCommands.java
> b3d96757b
>
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java
> 4c668b681
>
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/MemberCommands.java
> 695718a82
>
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/MiscellaneousCommands.java
> 9754d7d52
>
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/PDXCommands.java
> 9f1290d16
>
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/QueueCommands.java
> d3c263509
>
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/RegionCommands.java
> 2009dcc05
>
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ShellCommands.java
> efd10d27b
>
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/StatusCommands.java
> fffb9646f
>
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/WanCommands.java
> 28686ce4d
>
> geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/DataCommandFunction.java
> e2164a375
>
> geode-core/src/main/java/org/apache/geode/management/internal/cli/multistep/CLIMultiStepHelper.java
> d53261d04
>
> geode-core/src/main/java/org/apache/geode/management/internal/cli/multistep/MultiStepCommand.java
> 6708726cd
>
> geode-core/src/main/java/org/apa
Re: Review Request 59905: GEODE-2933: Add jmx-manager-hostname-for-clients for startLocator and startServer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59905/#review177357 --- Ship it! Ship It! - Emily Yeh On June 8, 2017, 5:33 p.m., Jared Stewart wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59905/ > --- > > (Updated June 8, 2017, 5:33 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and > Patrick Rhomberg. > > > Repository: geode > > > Description > --- > > GEODE-2933: Add jmx-manager-hostname-for-clients for startLocator and > startServer > > > Diffs > - > > > geode-core/src/main/java/org/apache/geode/management/internal/cli/GfshParser.java > df16e9b > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java > 4c668b6 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java > 9f68d3a > > geode-core/src/main/java/org/apache/geode/management/internal/cli/remote/CommandProcessor.java > c2c6e14 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/Gfsh.java > c5ff6b6 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/GfshParserAutoCompletionTest.java > a122de0 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/GfshParserConverterTest.java > 1ff60d6 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/GfshParserParsingTest.java > ab6dc3d > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshParserRule.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/59905/diff/2/ > > > Testing > --- > > Precheckin passed (other than 1 known flaky) > > > Thanks, > > Jared Stewart > >
Re: Review Request 59946: GEODE-3054: escaping the escape character in the command string before passing it to the SimpleParser
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59946/#review177503 --- Ship it! Ship It! - Emily Yeh On June 9, 2017, 2:57 p.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59946/ > --- > > (Updated June 9, 2017, 2:57 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and > Patrick Rhomberg. > > > Repository: geode > > > Description > --- > > GEODE-3054: escaping the escape character in the command string before > passing it to the SimpleParser > > > Diffs > - > > > geode-core/src/main/java/org/apache/geode/management/internal/cli/GfshParser.java > df16e9b9e9f71f21ef7c8ac84267a9858ee4298c > > geode-core/src/main/java/org/apache/geode/management/internal/cli/MultipleValueAdapter.java > 5c466a0c70c433d5f595cf3eab903fda8d362f9c > > geode-core/src/main/java/org/apache/geode/management/internal/cli/MultipleValueConverter.java > e3e1fec243fcb2e4048c60510af52c799e9c5110 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/GfshParserParsingTest.java > ab6dc3d10a6235af0ca6fc5164cac5d3c2419cdd > > > Diff: https://reviews.apache.org/r/59946/diff/1/ > > > Testing > --- > > precheckin successfull > hydra test failures related to path name are fixed. > > > Thanks, > > Jinmei Liao > >
Re: Review Request 59961: GEODE-3048: Introduce a rule to identify tests that require GEODE_HOME
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59961/#review177671 --- Ship it! Ship It! - Emily Yeh On June 9, 2017, 11:35 p.m., Jared Stewart wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59961/ > --- > > (Updated June 9, 2017, 11:35 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and > Patrick Rhomberg. > > > Repository: geode > > > Description > --- > > GEODE-3048: Introduce a rule to identify tests that require GEODE_HOME > > - A subsequent commit will add this rule to all of the relevant tests. > > > Diffs > - > > > geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/RequiresGeodeHome.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/59961/diff/2/ > > > Testing > --- > > > Thanks, > > Jared Stewart > >
Re: Review Request 60025: GEODE-3060: Introduce JUnit rule for testing the fully-assembled GFSH
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60025/#review177759 --- Fix it, then Ship it! I had a teeny tiny nitpick, but otherwise, it looks great! Ship it! geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshRule.java Lines 83-84 (patched) <https://reviews.apache.org/r/60025/#comment251471> It may (or may not?) be helpful to include a comment here to explain why nothing happens when the exception is caught, like in line 99 of `GfshScript.java` (`// ignore since we are waiting *quietly*`). - Emily Yeh On June 12, 2017, 9:50 p.m., Jared Stewart wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60025/ > --- > > (Updated June 12, 2017, 9:50 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and > Patrick Rhomberg. > > > Repository: geode > > > Description > --- > > GEODE-3060: Introduce JUnit rule for testing the fully-assembled GFSH > > > Diffs > - > > > geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StatusLocatorRealGfshTest.java > PRE-CREATION > > geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshRule.java > PRE-CREATION > > geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshScript.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/60025/diff/2/ > > > Testing > --- > > Precheckin started (still running) > > > Thanks, > > Jared Stewart > >
Re: Review Request 60030: GEODE-2925: finer security for disk management
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60030/#review177760 --- Ship it! Ship It! - Emily Yeh On June 12, 2017, 9:14 p.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60030/ > --- > > (Updated June 12, 2017, 9:14 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and > Patrick Rhomberg. > > > Repository: geode > > > Description > --- > > GEODE-2925: finer security for disk management > > changes that are needed to apply the finer grained security for disk > management after the latest security changes. > > > Diffs > - > > geode-core/src/main/java/org/apache/geode/management/DiskStoreMXBean.java > cca6272610517d75c877945872e1b9e77efae230 > > geode-core/src/main/java/org/apache/geode/management/DistributedSystemMXBean.java > f6f701e1faad30839574d8b20fbba31032755e80 > geode-core/src/main/java/org/apache/geode/management/MemberMXBean.java > e2de400601075af880a04b4521898280249d3e99 > > geode-core/src/main/java/org/apache/geode/management/internal/beans/DistributedSystemMBean.java > c45da73b4aabfc389b31f9a1092f2abd883813f7 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java > b2f1d561f9ef30dd2c02680b0a1075296719cd61 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java > ef2c3dd5db5f193de1ef307813b02f2ef60a4715 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/QueueCommands.java > 0f407e7d3273f4ec6206e24bbc064e207335ee11 > > geode-core/src/main/java/org/apache/geode/management/internal/security/MBeanServerWrapper.java > 47260bc855025864d0def5855eff33d0cdfd6617 > > geode-core/src/test/java/org/apache/geode/management/internal/security/DiskStoreMXBeanSecurityJUnitTest.java > e6502c0e4e94b2cea09ff78ea39ebcf02a7197f7 > > geode-core/src/test/java/org/apache/geode/management/internal/security/DistributedSystemMXBeanSecurityTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/60030/diff/1/ > > > Testing > --- > > precheckin running > > > Thanks, > > Jinmei Liao > >
Re: Review Request 59811: GEODE-2420: add file-size-limit param to the ExportLogsController
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59811/#review177765 --- Ship it! Ship It! - Emily Yeh On June 8, 2017, 9:08 p.m., Ken Howe wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59811/ > --- > > (Updated June 8, 2017, 9:08 p.m.) > > > Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Kirk Lund, > and Patrick Rhomberg. > > > Repository: geode > > > Description > --- > > GEODE-2420: add file-size-limit param to the ExportLogsController > > > Diffs > - > > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogsCommand.java > 0ff780cbf66937d8ececfb3a2d0789ee485b9b62 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/SizeExportLogsFunction.java > 57355c0efae4c6da9470267f95e27e59aa4d8b2c > > geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java > 9f68d3a5eaadbe8f1bd95ec8df85ed1f65aa67ce > > geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/ExportLogController.java > a369c6e1ffb330715fbde2cd69d023ed36f133ad > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsCommandTest.java > 16549e70bbebf4390bb73a481274e92ca6cad035 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsDUnitTest.java > 8609b3aaf0a0eb1ba903bd39c64103f9510a6a78 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsFileSizeLimitTest.java > 09ee08dd6af29b9a418ef7499defc4980da787ed > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsStatsDUnitTest.java > 44a036298e0991c880fc552596d296e104b97ca1 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsTestSuite.java > 4e1dac013d239437829bc52dc70689c4ba15dc58 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/SizeExportLogsFunctionTest.java > cc5e7d5256741ad0a48ff87c7f989a18b90f7f03 > > > Diff: https://reviews.apache.org/r/59811/diff/4/ > > > Testing > --- > > 6/7/17: re-started precheckin > precheckin is green with the exception of unrelated DUnit tests > > * re-starting precheckin once more > > 6/8/17: previous precheckin green except for 1 known flaky test > > Precheckin started > > > Thanks, > > Ken Howe > >
Re: Review Request 60052: GEODE-2294: revert to avoid rest protocol change
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60052/#review177767 --- Ship it! Ship It! - Emily Yeh On June 13, 2017, 5:29 p.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60052/ > --- > > (Updated June 13, 2017, 5:29 p.m.) > > > Review request for geode, Anthony Baker, Emily Yeh, Jared Stewart, Ken Howe, > Kirk Lund, and Patrick Rhomberg. > > > Repository: geode > > > Description > --- > > GEODE-2294: revert to avoid rest protocol change > > > Diffs > - > > > geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/AbstractBaseController.java > d8eb5721315b65f2924a54e565a1dad2815a5afa > > geode-web-api/src/test/java/org/apache/geode/rest/internal/web/controllers/AbstractBaseControllerJUnitTest.java > 7ebfbcfe9d97a2e984b2b9975b95945971d4b1ef > > > Diff: https://reviews.apache.org/r/60052/diff/1/ > > > Testing > --- > > precheckin running > > > Thanks, > > Jinmei Liao > >
Re: Review Request 60010: GEODE-3062: replace SecurityService after loading cluster config
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60010/#review19 --- Ship it! Ship It! - Emily Yeh On June 13, 2017, 4:29 p.m., Kirk Lund wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60010/ > --- > > (Updated June 13, 2017, 4:29 p.m.) > > > Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe, > and Patrick Rhomberg. > > > Bugs: GEODE-3062 > https://issues.apache.org/jira/browse/GEODE-3062 > > > Repository: geode > > > Description > --- > > Add new test to ClusterConfigWithSecurityDUnitTest that fails due to bug > GEODE-3062. > > Remove unused Cache param from applyClusterPropertiesConfiguration so it can > be called during Cache construction. > > Move cluster config request to Cache construction and handle jars and > properties there. Create new SecurityService in constructor and overwrite the > SecurityService in InternalDistributedSystem. > > NOTE: We will later have to fix GEODE-3061 by moving cluster config request > from Cache to InternalDistributedSystem construction so that IDS can be > created with gemfire.properties from cluster config. At that time we would > rip out both cluster config request and creation of security service from > Cache construction and pass both into Cache construction. > > > Diffs > - > > > geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java > 22edb6f06c7791929cc9a033ca1a1bfed5751a47 > > geode-core/src/main/java/org/apache/geode/internal/cache/ClusterConfigurationLoader.java > 4f4881fe39116faa505bc2fbec74efd669efe0ef > > geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java > 40df0c7dcac8827a381c268c1f90e6acfb97a7f1 > > geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigWithSecurityDUnitTest.java > c551ca9104a85dcf54c0bebbc4178fce4114a416 > > > Diff: https://reviews.apache.org/r/60010/diff/2/ > > > Testing > --- > > Precheckin passes > > > Thanks, > > Kirk Lund > >
Re: Review Request 60199: GEODE-3092: fix specifiedDefaultValue for cacheLoader and cacheWriter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60199/#review178266 --- Ship it! Ship It! - Emily Yeh On June 19, 2017, 4:09 p.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60199/ > --- > > (Updated June 19, 2017, 4:09 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and > Patrick Rhomberg. > > > Repository: geode > > > Description > --- > > GEODE-3092: fix specifiedDefaultValue for cacheLoader and cacheWriter > > > Diffs > - > > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java > 842802ba7b7ed34aa52974dcf327015051f22e1b > > geode-core/src/test/java/org/apache/geode/management/internal/cli/GfshParserParsingTest.java > 47d150d180dada8066f1e644b293c56096b2a969 > > > Diff: https://reviews.apache.org/r/60199/diff/1/ > > > Testing > --- > > precheckin running > > > Thanks, > > Jinmei Liao > >
Re: Review Request 60200: GEODE-3095: fix parameter type mismatch between the diskstore command and controller
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60200/#review178306 --- Ship it! Ship It! - Emily Yeh On June 19, 2017, 9:12 p.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60200/ > --- > > (Updated June 19, 2017, 9:12 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and > Patrick Rhomberg. > > > Repository: geode > > > Description > --- > > GEODE-3095: fix parameter type mismatch between the diskstore command and > controller > > > Diffs > - > > > geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/DiskStoreCommandsController.java > c613a8a1d5cca93ce7be785b58f6502d96752d8c > > geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/CreateDiskStoreOverHttpTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/60200/diff/2/ > > > Testing > --- > > GfshCommandOverHttpTest, GfshSecurityCommandOverHttpTest > > > Thanks, > > Jinmei Liao > >
Re: Review Request 60348: GEODE-3103: GfshRule no longer clutters output
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60348/#review178810 --- Ship it! Ship It! - Emily Yeh On June 23, 2017, 6:01 p.m., Jared Stewart wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60348/ > --- > > (Updated June 23, 2017, 6:01 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and > Patrick Rhomberg. > > > Repository: geode > > > Description > --- > > - GfshRule writes via a logger rather than StdOut. This will make it no > longer clutter precheckin runs or the nightly build. > - Introduce ProcessLogger to capture output from the Gfsh JVM so that tests > can assert against the output. > > > Diffs > - > > geode-assembly/build.gradle 39bb542 > > geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StatusLocatorRealGfshTest.java > 82ee240 > > geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshExecution.java > PRE-CREATION > > geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshRule.java > 8109377 > > geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshScript.java > 3ee1402 > > geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/ProcessLogger.java > PRE-CREATION > > geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/StreamGobbler.java > PRE-CREATION > > geode-core/src/main/java/org/apache/geode/management/internal/cli/util/CommandStringBuilder.java > cfb8a24 > > > Diff: https://reviews.apache.org/r/60348/diff/3/ > > > Testing > --- > > Precheckin running > > > Thanks, > > Jared Stewart > >
Re: Review Request 60202: GEODE-3056: fix the message for invalid partition-resolver
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60202/#review180043 --- Ship it! Ship It! - Emily Yeh On June 19, 2017, 7:08 p.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60202/ > --- > > (Updated June 19, 2017, 7:08 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and > Patrick Rhomberg. > > > Repository: geode > > > Description > --- > > GEODE-3056: fix the message for invalid partition-resolver > > > Diffs > - > > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java > 842802ba7b7ed34aa52974dcf327015051f22e1b > > geode-core/src/test/java/org/apache/geode/management/internal/cli/GfshParserParsingTest.java > 47d150d180dada8066f1e644b293c56096b2a969 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommandsTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/60202/diff/1/ > > > Testing > --- > > newly added test and precheckin running > > > Thanks, > > Jinmei Liao > >
Re: Review Request 60666: geode-3166: remove the uncalled getCredential method
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60666/#review181245 --- Ship it! +1! - Emily Yeh On July 17, 2017, 3:49 p.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60666/ > --- > > (Updated July 17, 2017, 3:49 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and > Patrick Rhomberg. > > > Repository: geode > > > Description > --- > > geode-3166: remove the uncalled getCredential method > > I simply removed the call. Since the new method is never called, if we have > any users that's implementing this method, it's never used anyway. We will > not be breaking backward compatibility, I believe. > > > Diffs > - > > geode-core/src/main/java/org/apache/geode/security/AuthInitialize.java > 6b0675a5629a3e057fd3d54841db740189007966 > > > Diff: https://reviews.apache.org/r/60666/diff/3/ > > > Testing > --- > > precheckin running > > > Thanks, > > Jinmei Liao > >
Re: Review Request 61042: GEODE-3214: Remove support for multistep gfsh commands.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61042/#review181247 --- Ship it! +1! - Emily Yeh On July 24, 2017, 5:50 p.m., Jared Stewart wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61042/ > --- > > (Updated July 24, 2017, 5:50 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and > Patrick Rhomberg. > > > Repository: geode > > > Description > --- > > GEODE-3214: Remove support for multistep gfsh commands. > > > Diffs > - > > > geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java > 5621b2497050d6a1003078dc993861a90fad4000 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/multistep/CLIMultiStepHelper.java > 4eeb2279cc041adbd12127a5ad68e862a6e72871 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/multistep/CLIRemoteStep.java > 4c38a313f7b6b7244c092dd4363c778bb810e18c > > geode-core/src/main/java/org/apache/geode/management/internal/cli/multistep/CLIStep.java > a037f518a89258bc5e6da00f42f6c7b102bc0e2c > > geode-core/src/main/java/org/apache/geode/management/internal/cli/multistep/CLIStepExecption.java > 389e72f4f91dd8a30e4086391d3c882e003943f3 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/multistep/MultiStepCommand.java > 75925f782b54c5d55c8fb921b803cf7ae4443252 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/remote/RemoteExecutionStrategy.java > 89cb9adee00b72c3775896a5f553256205a0b7cb > > geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/GfshExecutionStrategy.java > 1cbdb157d2e65a5976edd906f9db82272caad4c4 > > geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptor.java > 5e502f55e781a5bf3a656d17d0156175088891b2 > > geode-core/src/main/java/org/apache/geode/management/internal/web/http/ClientHttpRequest.java > 43657b9888d7e588d2d6e55584671478940c1d28 > > > Diff: https://reviews.apache.org/r/61042/diff/1/ > > > Testing > --- > > Precheckin passed > > > Thanks, > > Jared Stewart > >
Re: Review Request 61084: GEODE-3231: withLogFile does not imply withWorkingDir anymore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61084/#review181249 --- Ship it! Ship It! - Emily Yeh On July 24, 2017, 4:28 p.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61084/ > --- > > (Updated July 24, 2017, 4:28 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and > Patrick Rhomberg. > > > Repository: geode > > > Description > --- > > More refactor of the rules > GEODE-3231: withLogFile does not imply withWorkingDir anymore > > > Diffs > - > > > geode-core/src/test/java/org/apache/geode/internal/ClassPathLoaderIntegrationTest.java > 721e5020ead8c93313008d11599195a0a0022f9e > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsDUnitTest.java > 492e304e43113877102be22304bab09025a36dbc > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsIntegrationTest.java > 6726ede5e7a2e9237406d701e8d01c8cbb4adf8b > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsOnServerManagerDUnit.java > 557fae7f58d5b7eb29818177c329de255eea75c1 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsStatsDUnitTest.java > a1dff25990fcf1fd1c41e2e291d4ef277032ba36 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/ExportLogsFunctionIntegrationTest.java > 9669669c4fe103ddb21885eca5f23743f75ae005 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/ExportLogsFunctionTest.java > 4e72444d634ab37d39b3b01018d5f21c6ce67753 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/SizeExportLogsFunctionTest.java > 12410c79a3df1624e165ebecf1f97425e1ce08e6 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/util/LogExporterIntegrationTest.java > 0cd6d5af65aab3d286267b663418b798da362904 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/util/MergeLogsDUnitTest.java > 35d65a005198b981581bf7d02476ad79cd0eea9c > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java > 872553efed290890708caaf98dc206b4735005d0 > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java > d8753cf285388acabef91761a5043ee18f8475f3 > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorStarterRule.java > e1c14ce828d45d3777e9b31f4b7019e23d6a19ce > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/MemberStarterRule.java > 156236bae5cc1b5dc477b01e8b1955bf4aae64fb > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/ServerStarterRule.java > 0fd0e7759695d05071a4ade327b129107a9d9d0e > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/test/MemberStarterRuleTest.java > 4970cb5a6becfe259c70132adad949d34f7e2952 > > geode-web/src/test/java/org/apache/geode/management/internal/security/LogNoPasswordTest.java > 368d64dd9c2be3fb15d6d4563bb1c95d83733244 > > > Diff: https://reviews.apache.org/r/61084/diff/1/ > > > Testing > --- > > precheckin running > > > Thanks, > > Jinmei Liao > >
Re: Review Request 60688: GEODE-1279: rename tests with old bug system numbers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60688/#review181251 --- Ship it! Ship It! - Emily Yeh On July 6, 2017, 6:28 p.m., Kirk Lund wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60688/ > --- > > (Updated July 6, 2017, 6:28 p.m.) > > > Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe, > and Patrick Rhomberg. > > > Bugs: GEODE-1279 > https://issues.apache.org/jira/browse/GEODE-1279 > > > Repository: geode > > > Description > --- > > GEODE-1279: rename tests with old bug system numbers > > * Bug34387DUnitTest -> CreateAndLocalDestroyInTXRegressionTest > * Bug35214DUnitTest -> EntriesDoNotExpireDuringGIIRegressionTest > * Bug38013DUnitTest -> RemotePRValuesAreNotDeserializedRegressionTest > * Bug34948DUnitTest -> ValuesAreLazilyDeserializedRegressionTest > > There are many more tests left to rename but here's 4 that are ready to merge. > > > Diffs > - > > geode-core/src/test/java/org/apache/geode/cache30/Bug34387DUnitTest.java > d43be83c1844a931d65ccdc992746a3fb44fd396 > geode-core/src/test/java/org/apache/geode/cache30/Bug34948DUnitTest.java > 8b98cd3dd66fce8220ea7fe14aa14f8e7738a774 > geode-core/src/test/java/org/apache/geode/cache30/Bug35214DUnitTest.java > ed25b267f33ea311142950dbca212f19046985b0 > geode-core/src/test/java/org/apache/geode/cache30/Bug38013DUnitTest.java > a0e8021e210c058c20c061305f4b1a64a27bca11 > > geode-core/src/test/java/org/apache/geode/cache30/CreateAndLocalDestroyInTXRegressionTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/cache30/EntriesDoNotExpireDuringGIIRegressionTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/internal/cache/ConnectDisconnectDUnitTest.java > de6343304cefa39ac353e8b692f1f10b03ce0de3 > > geode-core/src/test/java/org/apache/geode/test/dunit/internal/DistributedTestFixture.java > 4175e8119d0652c6cc217ff21679d3c74e757cc9 > > geode-core/src/test/java/org/apache/geode/test/dunit/internal/JUnit3DistributedTestCase.java > abdac89c35ae39480501d6c954cd169b86f4e29a > > geode-core/src/test/java/org/apache/geode/test/dunit/internal/JUnit4DistributedTestCase.java > 110d649d8b8c77765de186ffbbe07af8cc16029b > > > Diff: https://reviews.apache.org/r/60688/diff/1/ > > > Testing > --- > > * CreateAndLocalDestroyInTXRegressionTest > * EntriesDoNotExpireDuringGIIRegressionTest > * RemotePRValuesAreNotDeserializedRegressionTest > * ValuesAreLazilyDeserializedRegressionTest > * precheckin > > > Thanks, > > Kirk Lund > >
Re: Review Request 60974: GEODE-3231: do not log to file by default when using the member starter rules
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60974/#review181263 --- Ship it! Ship It! - Emily Yeh On July 21, 2017, 8:05 p.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60974/ > --- > > (Updated July 21, 2017, 8:05 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and > Patrick Rhomberg. > > > Repository: geode > > > Description > --- > > * do not log to file by default, only when withLogInFile is called > * do not create a workingDir and sets the user.dir by default, only when > withWorkingDir is called > * For LocatorServerStarterRule, also do not set the workingDir if not asked > to, and only bounce the VM if the VM is started with a workingDir > > > Diffs > - > > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DeployCommandRedeployDUnitTest.java > e494bcdd8aab49864516d61ca1eee78b50a3e7ee > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DeployCommandsDUnitTest.java > 846a8d9ab93de73e612a85a4efa781b6cc1ac4a1 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsDUnitTest.java > 045e13edc798f2bd3460dc17bbfeec28ac5022e4 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsIntegrationTest.java > 4ca625a436ad9d181f1fecd11afc7a0cf1157aa6 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsOnServerManagerDUnit.java > a78b26fb560c17c96b794ecedc09e10c87766ef0 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsStatsDUnitTest.java > 33439e6063150b87938f21f13e647d3b0ecc4896 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsWithMemberGroupDUnitTest.java > e5cca279d8a8082726fc67eab8a5cfd91ce90529 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ShowMissingDiskStoresDUnitTest.java > 766f25ada3b446df71d840d70bb6fae797a85a00 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/ExportLogsFunctionIntegrationTest.java > d98641849eed458b4c830e1fa198f4d986b0c4ce > > geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/SizeExportLogsFunctionTest.java > 510a4e7fef1aff5a1aa8f00f569cd6422b7816ab > > geode-core/src/test/java/org/apache/geode/management/internal/cli/util/LogExporterIntegrationTest.java > a8b498ddbecb9d8733ed4f98c1c80cb18da5c37e > > geode-core/src/test/java/org/apache/geode/management/internal/cli/util/MergeLogsDUnitTest.java > 9166642044055071b2cced88edfe3ae660976ef7 > > geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigDeployJarDUnitTest.java > 3b105a4e412542160e763d7016970e10e8c2adcf > > geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigDistributionDUnitTest.java > 4b003a8b2b4b0ac1df19f851be23b3442fca975f > > geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigImportDUnitTest.java > 066f8828f64b7caa9c9748683f9214868105fed8 > > geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigStartMemberDUnitTest.java > c84a7c12f62a5ee28fec24aa82ba7da6f62a7d3d > > geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigTestBase.java > fd8fb46f44edcea2a068ec47d2a8577c933fd319 > > geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigWithSecurityDUnitTest.java > bb45b0d9acbed901fa17ef39d1bb0ca1153e0458 > > geode-core/src/test/java/org/apache/geode/management/internal/configuration/ImportClusterConfigDistributedTest.java > 4274d677d6d06a6f9b14dd362fef9d8fcd10f410 > > geode-core/src/test/java/org/apache/geode/management/internal/security/MemberMBeanSecurityJUnitTest.java > e6b50d210dad844aca5e37fcb3cf58d7aace4b3e > > geode-core/src/test/java/org/apache/geode/security/ClusterConfigWithoutSecurityDUnitTest.java > e90bc0a69222998322e02fcfad1b6bad3c97f4d1 > > geode-core/src/test/java/org/apache/geode/security/PDXPostProcessorDUnitTest.java > c4a25470bab75a2fdfcdb55126564d21ecd9403d > > geode-core/src/test/java/org/apache/geode/security/PeerAuthenticat
Re: Review Request 60977: GEODE-3251: make JMX test rules more robust
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60977/#review181264 --- Ship it! Ship It! - Emily Yeh On July 19, 2017, 5:14 p.m., Kirk Lund wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60977/ > --- > > (Updated July 19, 2017, 5:14 p.m.) > > > Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe, > and Patrick Rhomberg. > > > Bugs: GEODE-3251 > https://issues.apache.org/jira/browse/GEODE-3251 > > > Repository: geode > > > Description > --- > > GEODE-3251: make JMX test rules more robust > > Add "Failed to retrieve RMIServer stub" to rule await > to help ensure that JMX RMI is ready before running > the test. > > Also removed Soft assertions from DiskStoreMXBeanSecurityJUnitTest. > > > Diffs > - > > > geode-core/src/test/java/org/apache/geode/management/internal/security/DiskStoreMXBeanSecurityJUnitTest.java > 4d101e7862dd45bbf4faaec84cb4f808cfd26cf3 > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java > 872553efed290890708caaf98dc206b4735005d0 > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/MBeanServerConnectionRule.java > 3addc4e2ff07d36a340ed548e4c9a2d7f6094390 > > > Diff: https://reviews.apache.org/r/60977/diff/1/ > > > Testing > --- > > DiskStoreMXBeanSecurityJUnitTest > precheckin in progress > > > Thanks, > > Kirk Lund > >
Re: Review Request 61003: GEODE-393: GetRegionFunction uses the cache in the FunctionContext
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61003/#review181266 --- Ship it! Ship It! - Emily Yeh On July 20, 2017, 5:40 p.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61003/ > --- > > (Updated July 20, 2017, 5:40 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and > Patrick Rhomberg. > > > Repository: geode > > > Description > --- > > GEODE-393: GetRegionFunction uses the cache in the FunctionContext > > > Diffs > - > > > geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/GetRegionsFunction.java > d52492466d521fb25f410e7c03b3d9808aabe67c > > geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/GetRegionsFunctionTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/61003/diff/1/ > > > Testing > --- > > added test and precheckin funning > > > Thanks, > > Jinmei Liao > >
Re: Review Request 60918: GEODE-3134: fix lucene command security
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60918/#review181267 --- Ship it! Ship It! - Emily Yeh On July 17, 2017, 6:34 p.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60918/ > --- > > (Updated July 17, 2017, 6:34 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, > Patrick Rhomberg, and Dan Smith. > > > Repository: geode > > > Description > --- > > GEODE-3108: update lucene security permission to use "LUCENE" target > > * have lucene module define it's own target for plugability > * added string based target support for SecurityService > > > Diffs > - > > > geode-core/src/main/java/org/apache/geode/internal/security/IntegratedSecurityService.java > 323ab67d7f948b739783b2fb3b6bcfac32f68f0a > > geode-core/src/main/java/org/apache/geode/internal/security/SecurityService.java > b00e0f481f4b0cc92d163915c05822fb339fd158 > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/MemberStarterRule.java > 5b4f2c14545847d9a3fcfc501fdd9ff1e19771ba > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/cli/LuceneIndexCommands.java > 6ddacf134710da2f79a2d2e5e4ee866ef605674d > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/cli/functions/LuceneCreateIndexFunction.java > 2d3f8d2062b29b3ba11936ac07f67ac4af210640 > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/security/LucenePermission.java > PRE-CREATION > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneCommandsSecurityDUnitTest.java > 71166017b7a16162e3f4201a9e76691329ab346a > > > Diff: https://reviews.apache.org/r/60918/diff/1/ > > > Testing > --- > > LuceneCommandsSecurityDUnitTest precheckin running > > > Thanks, > > Jinmei Liao > >
Re: Review Request 60924: GEODE-2920: added security tests for create diskstore and create persistent region.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60924/#review181274 --- Ship it! Ship It! - Emily Yeh On July 17, 2017, 9:39 p.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60924/ > --- > > (Updated July 17, 2017, 9:39 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and > Patrick Rhomberg. > > > Repository: geode > > > Description > --- > > GEODE-2920: handle non-existent role in ExampleSecurityManager > > > Diffs > - > > > geode-core/src/main/java/org/apache/geode/examples/security/ExampleSecurityManager.java > c1d7ebfa017ccc627e7d4da6db951d3f61e2461b > > geode-core/src/test/java/org/apache/geode/management/internal/security/GfshCommandsSecurityTest.java > c2be173f8844bcf25361edc9e5d428f62aa8761f > > geode-core/src/test/java/org/apache/geode/security/ExampleSecurityManagerTest.java > 9093a7bc70835ae50c72a80739a3f8ab4789cacd > > geode-core/src/test/resources/org/apache/geode/security/templates/security.json > c1ee9fc22bad58642d814c5930eb2d02810dad0e > > > Diff: https://reviews.apache.org/r/60924/diff/1/ > > > Testing > --- > > precheckin running > > > Thanks, > > Jinmei Liao > >
Re: Review Request 61166: GEODE-3313: Test utility supports building jar files with multiple classes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61166/#review182126 --- Ship it! Looks good! +1 geode-junit/src/main/java/org/apache/geode/test/compiler/ClassNameExtractor.java Lines 22 (patched) <https://reviews.apache.org/r/61166/#comment257978> Always really impressed by your regexes! geode-junit/src/main/java/org/apache/geode/test/compiler/JavaCompiler.java Lines 108 (patched) <https://reviews.apache.org/r/61166/#comment257977> Super nitpick: there's just one extra line here that could be deleted. - Emily Yeh On Aug. 2, 2017, 5:54 p.m., Jared Stewart wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61166/ > --- > > (Updated Aug. 2, 2017, 5:54 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and > Patrick Rhomberg. > > > Repository: geode > > > Description > --- > > GEODE-3313: Test utility supports building jar files with multiple classes > > > Diffs > - > > geode-junit/build.gradle e47095f > > geode-junit/src/main/java/org/apache/geode/test/compiler/ClassNameExtractor.java > PRE-CREATION > > geode-junit/src/main/java/org/apache/geode/test/compiler/CompiledSourceCode.java > PRE-CREATION > geode-junit/src/main/java/org/apache/geode/test/compiler/JarBuilder.java > PRE-CREATION > geode-junit/src/main/java/org/apache/geode/test/compiler/JavaCompiler.java > PRE-CREATION > > geode-junit/src/main/java/org/apache/geode/test/compiler/UncompiledSourceCode.java > PRE-CREATION > > geode-junit/src/test/java/org/apache/geode/test/compiler/ClassNameExtractorTest.java > PRE-CREATION > > geode-junit/src/test/java/org/apache/geode/test/compiler/JarBuilderTest.java > PRE-CREATION > > geode-junit/src/test/java/org/apache/geode/test/compiler/JavaCompilerTest.java > PRE-CREATION > > geode-junit/src/test/java/org/apache/geode/test/compiler/UncompiledSourceCodeTest.java > PRE-CREATION > > geode-junit/src/test/resources/org/apache/geode/test/compiler/AbstractExtendsFunctionAdapter.java > PRE-CREATION > > geode-junit/src/test/resources/org/apache/geode/test/compiler/AbstractFunction.java > PRE-CREATION > > geode-junit/src/test/resources/org/apache/geode/test/compiler/ConcreteExtendsAbstractExtendsFunctionAdapter.java > PRE-CREATION > > geode-junit/src/test/resources/org/apache/geode/test/compiler/ExtendsAbstractFunction.java > PRE-CREATION > > geode-junit/src/test/resources/org/apache/geode/test/compiler/ExtendsFunctionAdapter.java > PRE-CREATION > > geode-junit/src/test/resources/org/apache/geode/test/compiler/ImplementsFunction.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/61166/diff/7/ > > > Testing > --- > > Precheckin running > > > Thanks, > > Jared Stewart > >
Re: Review Request 61185: GEODE-3231: use tempWorkingFolder to avoid test log file contamination between tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61185/#review182128 --- Ship it! Ship It! - Emily Yeh On July 27, 2017, 4:57 p.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61185/ > --- > > (Updated July 27, 2017, 4:57 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and > Patrick Rhomberg. > > > Repository: geode > > > Description > --- > > GEODE-3231: use tempWorkingFolder to avoid test log file contamination > between tests. > > > Diffs > - > > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsWithMemberGroupDUnitTest.java > ef62269133a9842b81bfaa661b77ed80ddf8552d > > > Diff: https://reviews.apache.org/r/61185/diff/1/ > > > Testing > --- > > > Thanks, > > Jinmei Liao > >
Re: Review Request 61506: GEODE-3328: refactor ConnectCommand
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61506/#review182527 --- Ship it! Ship It! - Emily Yeh On Aug. 9, 2017, 7:02 p.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61506/ > --- > > (Updated Aug. 9, 2017, 7:02 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and > Patrick Rhomberg. > > > Repository: geode > > > Description > --- > > * connect command will prompt for missing ssl configs if ssl is implied. > * command ssl options will override the properties loaded in the file and > prompt for missing ones if ssl is defined using the ssl-* prefix > * reworked the SSLConfigFactory to not use cached sslConfig when passing in a > Properties object > > > Diffs > - > > > geode-core/src/main/java/org/apache/geode/distributed/ConfigurationProperties.java > 91a6443b8fd98874feb9f17cf15b36826d7982c3 > > geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpClient.java > d4068910779c93b800d795d7f31f49a722ce6576 > > geode-core/src/main/java/org/apache/geode/internal/net/SSLConfigurationFactory.java > 4b98617465d282fd9ff50cf551a66d4359b4111d > > geode-core/src/main/java/org/apache/geode/management/internal/JmxManagerLocatorRequest.java > eb71d38e4f893b0435d99b2192256fb559751b00 > > geode-core/src/main/java/org/apache/geode/management/internal/beans/BeanUtilFuncs.java > 16d45bc719817782d84ae7e3da876fb9ed4a77bb > > geode-core/src/main/java/org/apache/geode/management/internal/cli/AbstractCliAroundInterceptor.java > 3e1357dad711c134cc45e5415b132dfdde92d93f > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java > be556a447d862144e453f69809a2de67ee00b654 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ShellCommands.java > 1aea253ff72dfd2bd89754e862cf222754286a94 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/StartLocatorCommand.java > 5b289a545e2d324bfa516cf1b05f8df641bc8a36 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/UserInputProperty.java > PRE-CREATION > > geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java > 58c8ef79c70f789d10d0a6e95cb24b510aa014a0 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/Gfsh.java > a69ce36afa6762890edcfb58f48bd8eddd27be65 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/JmxOperationInvoker.java > 7ae7c3b0f7d85aae1a8d16ba0fa7d9b80683bdfd > > geode-core/src/main/java/org/apache/geode/management/internal/cli/util/GfshConsoleReader.java > 9251d7e127a085e3bdb9bfcffc6c706b50b042dd > > geode-core/src/test/java/org/apache/geode/internal/net/SSLConfigurationFactoryJUnitTest.java > 31c2469a6ef7d9a1db9f2803b0b5bd9adfb5971c > > geode-core/src/test/java/org/apache/geode/management/ConnectToLocatorSSLDUnitTest.java > 866f4ef43dd1c583df210caa491cdd0ef8a3b84a > > geode-core/src/test/java/org/apache/geode/management/ConnectToLocatorWithLegacySSLDUnitTest.java > d7db4897d58d318496c1ba990c792ba94f77c81e > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ConnectCommandTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/UserInputPropertyTest.java > PRE-CREATION > > geode-cq/src/test/java/org/apache/geode/management/CacheServerManagementDUnitTest.java > 2cd69ddc619a68fb151e6574bace7418a7d58d10 > > geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/ConnectCommandIntegrationTest.java > PRE-CREATION > > geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/ConnectCommandWithSSLTest.java > PRE-CREATION > > geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/ConnectCommandWithSecurityTest.java > PRE-CREATION > > geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/ConnectToLocatorSSLOverHttpTest.java > e5b8d25ae4349e19c252c4d364d0a3c50edeeb54 > > > Diff: https://reviews.apache.org/r/61506/diff/2/ > > > Testing > --- > > precheckin all Green > > > Thanks, > > Jinmei Liao > >
Re: Review Request 61480: GEODE-3330: user needs CLUSTER:MANAGE:QUERY permission to create a CQ.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61480/#review182528 --- Ship it! Ship It! - Emily Yeh On Aug. 8, 2017, 9:10 p.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61480/ > --- > > (Updated Aug. 8, 2017, 9:10 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and > Patrick Rhomberg. > > > Repository: geode > > > Description > --- > > * cq.execute() and cq.executeWithInitialResult() all would still require > DATA:READ because it will send the result back to the client either initially > or later. > > > Diffs > - > > geode-core/src/test/java/org/apache/geode/security/SecurityTestUtil.java > 5d5c2148e2eba8054df305942e04f43ea69c0a79 > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java > a455aff315cd26abd398630ff63d8b54b0d1d12b > > geode-cq/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/CloseCQ.java > 6748f7d3193babfa668a7ff2846f974f0cdc1cbd > > geode-cq/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteCQ61.java > 77a608c7e65a2030c0037e9f327cf8c17e9313db > > geode-cq/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/StopCQ.java > a3d51edcc141391e9d818fc0ed7e514d3cb5d6d0 > > geode-cq/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/CloseCQTest.java > PRE-CREATION > > geode-cq/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteCQ61Test.java > PRE-CREATION > > geode-cq/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/StopCQTest.java > PRE-CREATION > geode-cq/src/test/java/org/apache/geode/security/CQClientAuthDUnitTest.java > 89167258ddbc06315068c849255a8530faefe060 > > geode-cq/src/test/java/org/apache/geode/security/CQPostProcessorDunitTest.java > 45f45abd17cf4f90f96163ebe4f01e67b3b53633 > geode-cq/src/test/java/org/apache/geode/security/ClientCQAuthDUnitTest.java > PRE-CREATION > > geode-cq/src/test/java/org/apache/geode/security/ClientQueryAuthDUnitTest.java > cc5dde409c561522ae3739eeaee892079c509ae8 > > geode-cq/src/test/java/org/apache/geode/test/dunit/rules/CQUnitTestRule.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/61480/diff/2/ > > > Testing > --- > > precheckin running > > > Thanks, > > Jinmei Liao > >
Re: Review Request 61409: GEODE-3328: simplify GfshParserRule
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61409/#review182529 --- Ship it! Ship It! - Emily Yeh On Aug. 3, 2017, 5:12 p.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61409/ > --- > > (Updated Aug. 3, 2017, 5:12 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and > Patrick Rhomberg. > > > Repository: geode > > > Description > --- > > GEODE-3328: simplify GfshParserRule > > another step towards refactor connect command, some simple rule change. > > > Diffs > - > > > geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StartLocatorCommandIntegrationTest.java > 0700742fac70730c160d28c62c93b824e8ee0a3c > > geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StartServerCommandIntegrationTest.java > 059611dc1c5101643cbae18d067a2943a573d405 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommandsTest.java > c2810801257479ad9a31452f294daaaf2975dfad > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshParserRule.java > b1bc7aa73b7d9273ad9a89af4c119d91a67aae03 > > > Diff: https://reviews.apache.org/r/61409/diff/1/ > > > Testing > --- > > precheckin running, tests > > > Thanks, > > Jinmei Liao > >
Re: Review Request 61472: GEODE-3097: fix an accidental bug introduced when working on ssl over http
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61472/#review182530 --- Ship it! Ship It! - Emily Yeh On Aug. 7, 2017, 5:18 p.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61472/ > --- > > (Updated Aug. 7, 2017, 5:18 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and > Patrick Rhomberg. > > > Repository: geode > > > Description > --- > > GEODE-3097: fix an accidental bug introduced when working on ssl over http > > > Diffs > - > > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java > be556a447d862144e453f69809a2de67ee00b654 > > > Diff: https://reviews.apache.org/r/61472/diff/1/ > > > Testing > --- > > precheckin running > > > Thanks, > > Jinmei Liao > >
[jira] [Assigned] (GEODE-2203) gfsh status locator/server - Give more descriptive output on empty parameter
[
https://issues.apache.org/jira/browse/GEODE-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Emily Yeh reassigned GEODE-2203:
Assignee: Emily Yeh (was: Alyssa Kim)
> gfsh status locator/server - Give more descriptive output on empty parameter
>
>
> Key: GEODE-2203
> URL: https://issues.apache.org/jira/browse/GEODE-2203
> Project: Geode
> Issue Type: Improvement
> Components: gfsh
>Reporter: Alyssa Kim
> Assignee: Emily Yeh
>Priority: Minor
> Labels: StatusLocatorCommand, StatusServerCommand, gfsh, status
>
> Currently, executing some status commands in gfsh without valid parameters
> gives a vague explanation/output that might be misleading. Although we have
> help for usage description, displaying 'null' as an output
> might not be the best idea.
> Current Result
> {code}
> gfsh>status locator
> null
> {code}
> {code}
> gfsh>status server
> Server in
> C:\Users\XXX\git\incubator-geode\geode-assembly\build\install\apache-geode\bin
> on null is currently not responding.
> {code}
> Improvement
> {code}
> gfsh>status locator
> SYNTAX
> status locator [--name=value] [--host=value] [--port=value] [--pid=value]
> Use help status locator to display detailed usage information
> {code}
> {code}
> gfsh>status server
> SYNTAX
> status server [--name=value] [--pid=value] [--dir=value]
> Use help status server to display detailed usage information
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (GEODE-2203) gfsh status locator/server - Give more descriptive output on empty parameter
[
https://issues.apache.org/jira/browse/GEODE-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16023852#comment-16023852
]
Emily Yeh commented on GEODE-2203:
--
gfsh> start locator --port=40001
(locator starts and gfsh auto-connects to locator)
gfsh> status locator
null
Expectation: because gfsh is connected to locator, it should automatically give
status for "locator --port=40001"
gfsh> status locator --port=40001
> gfsh status locator/server - Give more descriptive output on empty parameter
>
>
> Key: GEODE-2203
> URL: https://issues.apache.org/jira/browse/GEODE-2203
> Project: Geode
> Issue Type: Improvement
> Components: gfsh
> Reporter: Alyssa Kim
>Assignee: Emily Yeh
>Priority: Minor
> Labels: StatusLocatorCommand, StatusServerCommand, gfsh, status
>
> Currently, executing some status commands in gfsh without valid parameters
> gives a vague explanation/output that might be misleading. Although we have
> help for usage description, displaying 'null' as an output
> might not be the best idea.
> Current Result
> {code}
> gfsh>status locator
> null
> {code}
> {code}
> gfsh>status server
> Server in
> C:\Users\XXX\git\incubator-geode\geode-assembly\build\install\apache-geode\bin
> on null is currently not responding.
> {code}
> Improvement
> {code}
> gfsh>status locator
> SYNTAX
> status locator [--name=value] [--host=value] [--port=value] [--pid=value]
> Use help status locator to display detailed usage information
> {code}
> {code}
> gfsh>status server
> SYNTAX
> status server [--name=value] [--pid=value] [--dir=value]
> Use help status server to display detailed usage information
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Comment Edited] (GEODE-2203) gfsh status locator/server - Give more descriptive output on empty parameter
[
https://issues.apache.org/jira/browse/GEODE-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16023852#comment-16023852
]
Emily Yeh edited comment on GEODE-2203 at 5/24/17 11:01 PM:
{code}
gfsh>status locator
null ==> We want something more like status server's message, like...
Locator in on is currently not responding.
{code}
was (Author: eyeh):
gfsh> start locator --port=40001
(locator starts and gfsh auto-connects to locator)
gfsh> status locator
null
Expectation: because gfsh is connected to locator, it should automatically give
status for "locator --port=40001"
gfsh> status locator --port=40001
> gfsh status locator/server - Give more descriptive output on empty parameter
>
>
> Key: GEODE-2203
> URL: https://issues.apache.org/jira/browse/GEODE-2203
> Project: Geode
> Issue Type: Improvement
> Components: gfsh
> Reporter: Alyssa Kim
>Assignee: Emily Yeh
>Priority: Minor
> Labels: StatusLocatorCommand, StatusServerCommand, gfsh, status
>
> Currently, executing some status commands in gfsh without valid parameters
> gives a vague explanation/output that might be misleading. Although we have
> help for usage description, displaying 'null' as an output
> might not be the best idea.
> Current Result
> {code}
> gfsh>status locator
> null
> {code}
> {code}
> gfsh>status server
> Server in
> C:\Users\XXX\git\incubator-geode\geode-assembly\build\install\apache-geode\bin
> on null is currently not responding.
> {code}
> Improvement
> {code}
> gfsh>status locator
> SYNTAX
> status locator [--name=value] [--host=value] [--port=value] [--pid=value]
> Use help status locator to display detailed usage information
> {code}
> {code}
> gfsh>status server
> SYNTAX
> status server [--name=value] [--pid=value] [--dir=value]
> Use help status server to display detailed usage information
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Created] (GEODE-2991) "destroy gateway-sender" command not in documentation
Emily Yeh created GEODE-2991: Summary: "destroy gateway-sender" command not in documentation Key: GEODE-2991 URL: https://issues.apache.org/jira/browse/GEODE-2991 Project: Geode Issue Type: Bug Components: docs Reporter: Emily Yeh Documentation for the "destroy gateway-sender" command (handled by the destroyGatewaySender method under WanCommands.java) isn't available in the docs yet. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Issue Comment Deleted] (GEODE-2203) gfsh status locator/server - Give more descriptive output on empty parameter
[
https://issues.apache.org/jira/browse/GEODE-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Emily Yeh updated GEODE-2203:
-
Comment: was deleted
(was: {code}
gfsh>status locator
null ==> We want something more like status server's message, like...
Locator in on is currently not responding.
{code})
> gfsh status locator/server - Give more descriptive output on empty parameter
>
>
> Key: GEODE-2203
> URL: https://issues.apache.org/jira/browse/GEODE-2203
> Project: Geode
> Issue Type: Improvement
> Components: gfsh
>Reporter: Alyssa Kim
>Assignee: Emily Yeh
>Priority: Minor
> Labels: StatusLocatorCommand, StatusServerCommand, gfsh, status
>
> Currently, executing some status commands in gfsh without valid parameters
> gives a vague explanation/output that might be misleading. Although we have
> help for usage description, displaying 'null' as an output
> might not be the best idea.
> Current Result
> {code}
> gfsh>status locator
> null
> {code}
> {code}
> gfsh>status server
> Server in
> C:\Users\XXX\git\incubator-geode\geode-assembly\build\install\apache-geode\bin
> on null is currently not responding.
> {code}
> Improvement
> {code}
> gfsh>status locator
> SYNTAX
> status locator [--name=value] [--host=value] [--port=value] [--pid=value]
> Use help status locator to display detailed usage information
> {code}
> {code}
> gfsh>status server
> SYNTAX
> status server [--name=value] [--pid=value] [--dir=value]
> Use help status server to display detailed usage information
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Assigned] (GEODE-2977) commands should take string[] as the value for --group and --memberId(--name) whenever possible
[ https://issues.apache.org/jira/browse/GEODE-2977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emily Yeh reassigned GEODE-2977: Assignee: Emily Yeh > commands should take string[] as the value for --group and --memberId(--name) > whenever possible > --- > > Key: GEODE-2977 > URL: https://issues.apache.org/jira/browse/GEODE-2977 > Project: Geode > Issue Type: Bug > Components: gfsh >Reporter: Jinmei Liao >Assignee: Emily Yeh > > some commands takes string[], and some takes only String and split them > manually. We should make this consistent and the help message would be a lot > clearer if taking string[]. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (GEODE-2991) "destroy gateway-sender" command not in documentation
[ https://issues.apache.org/jira/browse/GEODE-2991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emily Yeh updated GEODE-2991: - Priority: Minor (was: Major) > "destroy gateway-sender" command not in documentation > - > > Key: GEODE-2991 > URL: https://issues.apache.org/jira/browse/GEODE-2991 > Project: Geode > Issue Type: Bug > Components: docs >Reporter: Emily Yeh >Priority: Minor > > Documentation for the "destroy gateway-sender" command (handled by the > destroyGatewaySender method under WanCommands.java) isn't available in the > docs yet. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (GEODE-2818) add alias to any command's options that involves "group", "member", "jar"
[ https://issues.apache.org/jira/browse/GEODE-2818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emily Yeh reassigned GEODE-2818: Assignee: Emily Yeh > add alias to any command's options that involves "group", "member", "jar" > - > > Key: GEODE-2818 > URL: https://issues.apache.org/jira/browse/GEODE-2818 > Project: Geode > Issue Type: New Feature > Components: docs, gfsh > Reporter: Jinmei Liao >Assignee: Emily Yeh > > Or anything that would have confusion about if we are going to use singular > or plural at all. > 1) add alias for those options > 2) make sure it parameter type is an array type, some method only accepts a > string and split it inside the command. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Resolved] (GEODE-2818) add alias to any command's options that involves "group", "member", "jar"
[ https://issues.apache.org/jira/browse/GEODE-2818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emily Yeh resolved GEODE-2818. -- Resolution: Fixed > add alias to any command's options that involves "group", "member", "jar" > - > > Key: GEODE-2818 > URL: https://issues.apache.org/jira/browse/GEODE-2818 > Project: Geode > Issue Type: New Feature > Components: docs, gfsh > Reporter: Jinmei Liao >Assignee: Emily Yeh > > Or anything that would have confusion about if we are going to use singular > or plural at all. > 1) add alias for those options > 2) make sure it parameter type is an array type, some method only accepts a > string and split it inside the command. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Resolved] (GEODE-2977) commands should take string[] as the value for --group and --memberId(--name) whenever possible
[ https://issues.apache.org/jira/browse/GEODE-2977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emily Yeh resolved GEODE-2977. -- Resolution: Fixed > commands should take string[] as the value for --group and --memberId(--name) > whenever possible > --- > > Key: GEODE-2977 > URL: https://issues.apache.org/jira/browse/GEODE-2977 > Project: Geode > Issue Type: Bug > Components: gfsh >Reporter: Jinmei Liao >Assignee: Emily Yeh > > some commands takes string[], and some takes only String and split them > manually. We should make this consistent and the help message would be a lot > clearer if taking string[]. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (GEODE-2601) Banner is logged twice during locator startup
[
https://issues.apache.org/jira/browse/GEODE-2601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Emily Yeh reassigned GEODE-2601:
Assignee: Emily Yeh
> Banner is logged twice during locator startup
> -
>
> Key: GEODE-2601
> URL: https://issues.apache.org/jira/browse/GEODE-2601
> Project: Geode
> Issue Type: Bug
> Components: logging
>Reporter: Patrick Rhomberg
> Assignee: Emily Yeh
>Priority: Minor
> Labels: LogBanner
>
> In locator log file, starting a locator in gfsh yields a log file containing
> "Licensed to the Apache [...]"
> First banner ends with:
> {noformat}[info 2017/03/06 14:29:29.995 PST loc1 tid=0x1] Starting
> peer location for Distribution Locator on 10.118.33.239{noformat}
> Second banner ends with:
> {noformat}[info 2017/03/06 14:29:30.160 PST loc1 tid=0x1] Starting
> membership services{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
