[GitHub] geode pull request #524: GEODE-2956: Trimmed analzer strings in create index
GitHub user DivineEnder opened a pull request: https://github.com/apache/geode/pull/524 GEODE-2956: Trimmed analzer strings in create index Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to dev@geode.apache.org. You can merge this pull request into a Git repository by running: $ git pull https://github.com/DivineEnder/geode feature/GEODE-2956 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/524.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #524 commit de702fd50f194990b0c6ad3ed4a7fddba9dd4e0a Author: David Anuta Date: 2017-05-23T00:10:25Z GEODE-2956: Trimmed analzer strings in create index --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #524: GEODE-2956: Trimmed analzer strings in create index
Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/524 Potential Reviewers @jhuynh1 @upthewaterspout @boglesby @nabarunnag @ladyVader @gesterzhou --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #527: GEODE-2961: Fixed distinct multiple OR query return...
GitHub user DivineEnder opened a pull request: https://github.com/apache/geode/pull/527 GEODE-2961: Fixed distinct multiple OR query returning partial results Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to dev@geode.apache.org. You can merge this pull request into a Git repository by running: $ git pull https://github.com/DivineEnder/geode feature/GEODE-2961 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/527.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #527 commit 8f77fc2ad87fbc7b7b565005f120ab0ae822aca7 Author: David Anuta Date: 2017-05-23T20:53:19Z GEODE-2961: Fixed distinct multiple OR query returning partial results --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #527: GEODE-2961: Fixed distinct multiple OR query returning par...
Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/527 @nabarunnag @upthewaterspout @jhuynh1 @ladyVader @boglesby --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #531: GEODE-2955: Validating region names when creating l...
GitHub user DivineEnder opened a pull request: https://github.com/apache/geode/pull/531 GEODE-2955: Validating region names when creating lucene index Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to dev@geode.apache.org. You can merge this pull request into a Git repository by running: $ git pull https://github.com/DivineEnder/geode feature/GEODE-2955 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/531.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #531 commit 37449b92a7b67010e6ccac03ea8e8e1f8fa8c92f Author: David Anuta Date: 2017-05-24T18:34:39Z GEODE-2955: Validating region names when creating lucene index --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #531: GEODE-2955: Validating region names when creating lucene i...
Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/531 @upthewaterspout @nabarunnag @ladyVader @jhuynh1 @boglesby --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #527: GEODE-2961: Fixed distinct multiple OR query return...
Github user DivineEnder closed the pull request at: https://github.com/apache/geode/pull/527 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #532: GEODE-2950: Adding validation checks on create Luce...
GitHub user DivineEnder opened a pull request: https://github.com/apache/geode/pull/532 GEODE-2950: Adding validation checks on create Lucene index parameter⦠⦠names Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to dev@geode.apache.org. You can merge this pull request into a Git repository by running: $ git pull https://github.com/DivineEnder/geode feature/GEODE-2950 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/532.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #532 commit db35110899adad1372f1f832344608dcf457a639 Author: David Anuta Date: 2017-05-24T23:21:33Z GEODE-2950: Adding validation checks on create lucene index parameter names --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #532: GEODE-2950: Adding validation checks on create Lucene inde...
Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/532 @ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #533: GEODE-2944: Added __REGION_VALUE_FIELD explanation ...
GitHub user DivineEnder opened a pull request: https://github.com/apache/geode/pull/533 GEODE-2944: Added __REGION_VALUE_FIELD explanation to Lucene create i⦠â¦ndex help Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to dev@geode.apache.org. You can merge this pull request into a Git repository by running: $ git pull https://github.com/DivineEnder/geode feature/GEODE-2944 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/533.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #533 commit 1f944192b8657da5e7f07f4af1d03a5539ee3025 Author: David Anuta Date: 2017-05-25T00:05:33Z GEODE-2944: Added __REGION_VALUE_FIELD explanation to lucene create index help --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #533: GEODE-2944: Added __REGION_VALUE_FIELD explanation to Luce...
Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/533 @ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #537: GEODE-2957: Added DEFAULT as a standardAnalyzer key...
GitHub user DivineEnder opened a pull request: https://github.com/apache/geode/pull/537 GEODE-2957: Added DEFAULT as a standardAnalyzer keyword specifier whe⦠â¦n creating Lucene index Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to dev@geode.apache.org. You can merge this pull request into a Git repository by running: $ git pull https://github.com/DivineEnder/geode feature/GEODE-2957 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/537.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #537 commit 7b0543a7325ee08fb9b91710c9b406cc41f75451 Author: David Anuta Date: 2017-05-25T19:03:43Z GEODE-2957: Added DEFAULT as a standardAnalyzer keyword specifier when creating Lucene index --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #537: GEODE-2957: Added DEFAULT as a standardAnalyzer keyword sp...
Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/537 @ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #540: GEODE-2950: Updated error messages
GitHub user DivineEnder opened a pull request: https://github.com/apache/geode/pull/540 GEODE-2950: Updated error messages * Different error messages are displayed when validating region names versus indexes. * Added flexible enum allowing for expanded error messages and name validation. Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to dev@geode.apache.org. You can merge this pull request into a Git repository by running: $ git pull https://github.com/DivineEnder/geode feature/GEODE-2950 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/540.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #540 commit 382f3e672964c76c3854f33c3b628c5a0234eb66 Author: David Anuta Date: 2017-05-25T22:18:40Z GEODE-2950: Updated error messages * Different error messages are displayed when validating region names versus indexes. * Added flexible enum allowing for expanded error messages and name validation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #540: GEODE-2950: Updated error messages
Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/540 @ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #547: GEODE-2957: Create Lucene index analyzer help updat...
GitHub user DivineEnder opened a pull request: https://github.com/apache/geode/pull/547 GEODE-2957: Create Lucene index analyzer help updated to include keyw⦠â¦ord DEFAULT Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to dev@geode.apache.org. You can merge this pull request into a Git repository by running: $ git pull https://github.com/DivineEnder/geode feature/GEODE-2957 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/547.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #547 commit 0e37c14c01dd5ceb853f337c6c45c6287e6ccd7f Author: David Anuta Date: 2017-05-30T16:27:11Z GEODE-2957: Create Lucene index analyzer help updated to include keyword DEFAULT --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #547: GEODE-2957: Create Lucene index analyzer help updated to i...
Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/547 @ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #543: GEODE-2957 gfsh create lucene index "null" becomes "DEFAUL...
Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/543 Looks good ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #584: GEODE-2901: Adding integration tests of session rep...
GitHub user DivineEnder opened a pull request: https://github.com/apache/geode/pull/584 GEODE-2901: Adding integration tests of session replication Adding integration tests that test both session replications frameworks shipped with geode. These tests use cargo to download and launch different J2EE containers, so the tests can run against many different containers. Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to dev@geode.apache.org. You can merge this pull request into a Git repository by running: $ git pull https://github.com/DivineEnder/geode feature/GEODE-2901 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/584.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #584 commit 75943c5e6a1d1c9d4f23ca423f1766a0a854a5dc Author: David Anuta Date: 2017-05-27T00:07:36Z GEODE-2901: Adding integration tests of session replication Adding integration tests that test both session replications frameworks shipped with geode. These tests use cargo to download and launch different J2EE containers, so the tests can run against many different containers. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #584: GEODE-2901: Adding integration tests of session replicatio...
Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/584 @ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #587: GEODE-2018: Added instantiators to SessionCachingFi...
GitHub user DivineEnder opened a pull request: https://github.com/apache/geode/pull/587 GEODE-2018: Added instantiators to SessionCachingFilter init method Also removed unused registerInstantiator methods from GatewayDeltaCreateEvent, GatewayDeltaDestroyEvent, and DeltaSessionDestroyAttrbiuteEvent classes. Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to dev@geode.apache.org. You can merge this pull request into a Git repository by running: $ git pull https://github.com/DivineEnder/geode feature/GEODE-2018 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/587.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #587 commit 917487bd593ed96d4135d6a057a1f172bd7e188e Author: David Anuta Date: 2017-06-16T17:44:05Z GEODE-2018: Added instantiators to SessionCachingFilter init method Also removed unused registerInstantiator methods from GatewayDeltaCreateEvent, GatewayDeltaDestroyEvent, and DeltaSessionDestroyAttrbiuteEvent classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #587: GEODE-2018: Added instantiators to SessionCachingFilter in...
Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/587 @ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #589: GEODE-393: Providing cache for FunctionContext
Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/589 @ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #589: GEODE-393: Providing cache for FunctionContext
GitHub user DivineEnder opened a pull request: https://github.com/apache/geode/pull/589 GEODE-393: Providing cache for FunctionContext Added the ability to pass a Cache to a function context as well as tests to check for this. Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to dev@geode.apache.org. You can merge this pull request into a Git repository by running: $ git pull https://github.com/DivineEnder/geode feature/GEODE-393 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/589.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #589 commit ec1047c56ebc9f92e7b521bd765286fbed09af59 Author: David Anuta Date: 2017-06-16T23:05:24Z GEODE-393: Providing cache for FunctionContext Added the ability to pass a Cache to a function context as well as tests to check for this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #603: GEODE-3128: Changed the batch size to 1000 when cre...
GitHub user DivineEnder opened a pull request: https://github.com/apache/geode/pull/603 GEODE-3128: Changed the batch size to 1000 when creating AEQFactory * Prevously the batch size was the default 100 * Also added Lucene index overhead tests as performance tests. Currently these tests are ignored because they do not contain an assertions Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to dev@geode.apache.org. You can merge this pull request into a Git repository by running: $ git pull https://github.com/DivineEnder/geode feature/GEODE-3128 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/603.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #603 commit d51d650b494b60ffd6a4578c6fc7be3d76ffd705 Author: David Anuta Date: 2017-06-19T15:55:34Z GEODE-3128: Changed the batch size to 1000 when creating AEQFactory * Prevously the batch size was the default 100 * Also added Lucene index overhead tests as performance tests. Currently these tests are ignored because they do not contain an assertions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #603: GEODE-3128: Changed the batch size to 1000 when creating A...
Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/603 @ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #608: GEODE-3140: Removed DiskDirRule and replaced use with Temp...
Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/608 @ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #608: GEODE-3140: Removed DiskDirRule and replaced use wi...
GitHub user DivineEnder opened a pull request: https://github.com/apache/geode/pull/608 GEODE-3140: Removed DiskDirRule and replaced use with TemporaryFolder⦠⦠rule Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to dev@geode.apache.org. You can merge this pull request into a Git repository by running: $ git pull https://github.com/DivineEnder/geode feature/GEODE-3140 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/608.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #608 commit 8e43d6139c13ad5de6355f34637d92af8e9d699e Author: David Anuta Date: 2017-06-28T00:00:00Z GEODE-3140: Removed DiskDirRule and replaced use with TemporaryFolder rule --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #608: GEODE-3140: Removed DiskDirRule and replaced use wi...
Github user DivineEnder commented on a diff in the pull request:
https://github.com/apache/geode/pull/608#discussion_r124621529
--- Diff:
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPersistenceIntegrationTest.java
---
@@ -48,13 +49,13 @@
public class LuceneQueriesPersistenceIntegrationTest extends
LuceneIntegrationTest {
@Rule
- public DiskDirRule diskDirRule = new DiskDirRule();
+ public TemporaryFolder tempFolderRule = new TemporaryFolder(new
File("."));
--- End diff --
Yeah. That's a good idea. Turns out there is an empty TemporaryFolder
constructor, so I'll make that change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #584: GEODE-2901: Adding integration tests of session replicatio...
Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/584 Single successful run on course when only running the Distributed tests in geode-assembly. Testing again with fully concourse run. ð¤ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #618: GEODE-3167: Added commons-validator dependency to m...
GitHub user DivineEnder opened a pull request: https://github.com/apache/geode/pull/618 GEODE-3167: Added commons-validator dependency to modify_war script a⦠â¦nd Tomcat required jars Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to dev@geode.apache.org. You can merge this pull request into a Git repository by running: $ git pull https://github.com/DivineEnder/geode feature/GEODE-3167 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/618.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #618 commit 5d5ede50a1367f6851b3c9eb5db7a843b84cb4ac Author: David Anuta Date: 2017-07-05T17:12:01Z GEODE-3167: Added commons-validator dependency to modify_war script and Tomcat required jars --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #618: GEODE-3167: Added commons-validator dependency to modify_w...
Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/618 @ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #619: Feature/geode 2901
GitHub user DivineEnder opened a pull request: https://github.com/apache/geode/pull/619 Feature/geode 2901 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to dev@geode.apache.org. You can merge this pull request into a Git repository by running: $ git pull https://github.com/DivineEnder/geode feature/GEODE-2901 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/619.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #619 commit 5d5ede50a1367f6851b3c9eb5db7a843b84cb4ac Author: David Anuta Date: 2017-07-05T17:12:01Z GEODE-3167: Added commons-validator dependency to modify_war script and Tomcat required jars commit e1b5570bac6d56bce6132daa93c84e39938f5f88 Author: David Anuta Date: 2017-07-03T23:55:03Z Updating installation and container management to allow more container independence (just in time for the 4th) commit 2350d37f294bf8a03a45cc8626522dcd1b610440 Author: David Anuta Date: 2017-07-04T00:12:29Z Fixed incorrect local cache enabled property setting for jetty and tomcat Setting has previously been set as a cache property as enableLocalCache. Jetty needs the cache property enable_local_cache so moved the setting of this property within each container (Tomcat and Jetty) with their respective variable names commit 1ad5395befdf330b35b931624a0bf79155dafa0f Author: David Anuta Date: 2017-07-05T23:21:27Z Fixed server.xml so that it was no longer installation specific Previously, each container edited the same file, which led to some concurrency issues. Now the configuration holds the server xml configuration and only writes it to the configuration folder when a container is started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #619: Feature/geode 2901
Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/619 @ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #619: Feature/geode 2901
Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/619 Still working on adding javadoc, but the actual code is all in place --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #622: GEODE-1731: Modifying region size check to be more ...
GitHub user DivineEnder opened a pull request: https://github.com/apache/geode/pull/622 GEODE-1731: Modifying region size check to be more accurate Changed the hardcoded 5010 region size check to the size of the region already plus 20 new elements. The 20 new elements is due to the fact that a synchronous call to get the region size of vm2 had to be used, so there should be more time for elements to be put. Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to dev@geode.apache.org. You can merge this pull request into a Git repository by running: $ git pull https://github.com/DivineEnder/geode feature/GEODE-1731 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/622.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #622 commit 10e04c6a035b6ad83ba9bdedc6651eebe177f133 Author: David Anuta Date: 2017-07-10T20:05:44Z GEODE-1731: Modifying region size check to be more accurate Changed the hardcoded 5010 region size check to the size of the region already plus 20 new elements. The 20 new elements is due to the fact that a synchronous call to get the region size of vm2 had to be used, so there should be more time for elements to be put. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #622: GEODE-1731: Modifying region size check to be more accurat...
Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/622 @ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #626: GEODE-3179: Fixing bundled jars test finding slf4j-...
GitHub user DivineEnder opened a pull request: https://github.com/apache/geode/pull/626 GEODE-3179: Fixing bundled jars test finding slf4j-jdk jar This fixes the failing verify bundled jars test, caused by an unexpected slf4j-jdk jar coming from the tomcat module folder when extracted. Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to dev@geode.apache.org. You can merge this pull request into a Git repository by running: $ git pull https://github.com/DivineEnder/geode feature/GEODE-3179 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/626.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #626 commit b662c9b08537ebffadf3427f616f6aad5f2a8daf Author: David Anuta Date: 2017-07-10T23:40:07Z GEODE-3179: Changed extract directory of the Tomcat module This fixes the failing verify bundled jars test, caused by an unexpected slf4j-jdk jar coming from the tomcat module folder when extracted. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #626: GEODE-3179: Fixing bundled jars test finding slf4j-jdk jar
Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/626 @ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #639: GEODE-3112: Fixing improper ordering of client time...
GitHub user DivineEnder opened a pull request: https://github.com/apache/geode/pull/639 GEODE-3112: Fixing improper ordering of client timeout setting Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to dev@geode.apache.org. You can merge this pull request into a Git repository by running: $ git pull https://github.com/DivineEnder/geode feature/GEODE-3112 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/639.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #639 commit 4cf98a4605c17f8c08bc878df2db99fb1d194b6e Author: David Anuta Date: 2017-07-17T22:25:35Z GEODE-3112: Fixing improper ordering of client timeout setting --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #639: GEODE-3112: Fixing improper ordering of client timeout set...
Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/639 @ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #662: GEODE-3301: Installations now cleanup previously le...
GitHub user DivineEnder opened a pull request: https://github.com/apache/geode/pull/662 GEODE-3301: Installations now cleanup previously left over directories⦠This should hopefully fix Jenkins build issues Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to dev@geode.apache.org. You can merge this pull request into a Git repository by running: $ git pull https://github.com/DivineEnder/geode feature/GEODE-3301 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/662.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #662 commit 4895d7aebe2bc4923018e4d1cf10ef1261674f04 Author: David Anuta Date: 2017-07-27T19:23:15Z GEODE-3301: Cargo installs now delete left over directories This should hopefully fix Jenkins build issues --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #662: GEODE-3301: Installations now cleanup previously left over...
Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/662 @ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #666: GEODE-3329: Changed logging output of modify_war sc...
GitHub user DivineEnder opened a pull request: https://github.com/apache/geode/pull/666 GEODE-3329: Changed logging output of modify_war script Changed the modify_war script so that its output and error streams write to a log file instead of to standard out. Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to dev@geode.apache.org. You can merge this pull request into a Git repository by running: $ git pull https://github.com/DivineEnder/geode feature/GEODE-3329 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/666.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #666 commit 0fb270a5916d32e00847b48a7fd9de2bc2b566af Author: David Anuta Date: 2017-07-28T17:49:36Z GEODE-3329: Changed logging output of modify_war script Changed the modify_war script so that its output and error streams write to a log file instead of to standard out. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #666: GEODE-3329: Changed logging output of modify_war script
Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/666 @ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou @PurelyApplied --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #688: GEODE-3397: Fixed issue with Tomcat locators in cac...
GitHub user DivineEnder opened a pull request: https://github.com/apache/geode/pull/688 GEODE-3397: Fixed issue with Tomcat locators in cache-client.xml file Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to dev@geode.apache.org. You can merge this pull request into a Git repository by running: $ git pull https://github.com/DivineEnder/geode feature/GEODE-3397 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/688.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #688 commit b1c2bc53fc6f488b8a0fa3832479b77c9c8df0f3 Author: David Anuta Date: 2017-08-04T20:26:24Z GEODE-3397: Fixed issue with Tomcat locators in cache-client.xml file --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #688: GEODE-3397: Fixed issue with Tomcat locators in cache-clie...
Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/688 @ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #712: GEODE-3434: Allow the modules to be interoperable w...
Github user DivineEnder commented on a diff in the pull request: https://github.com/apache/geode/pull/712#discussion_r133010884 --- Diff: geode-assembly/src/test/java/org/apache/geode/session/tests/ServerContainer.java --- @@ -134,6 +134,7 @@ public ServerContainer(ContainerInstall install, File containerConfigHome, // Set cacheXML file File installXMLFile = install.getCacheXMLFile(); +String path = logDir.getAbsolutePath() + "/" + installXMLFile.getName(); --- End diff -- Probably not needed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #712: GEODE-3434: Allow the modules to be interoperable w...
Github user DivineEnder commented on a diff in the pull request:
https://github.com/apache/geode/pull/712#discussion_r133011336
--- Diff:
geode-assembly/src/test/java/org/apache/geode/session/tests/TomcatInstall.java
---
@@ -131,15 +142,20 @@ public TomcatInstall(TomcatVersion version,
ConnectionType connType) throws Exce
* within the installation's 'conf' folder, and {@link
#updateProperties()} to set the jar
* skipping properties needed to speedup container startup.
*/
- public TomcatInstall(TomcatVersion version, ConnectionType connType,
String installDir)
- throws Exception {
+ public TomcatInstall(TomcatVersion version, ConnectionType connType,
String installDir,
+ String modulesJarLocation, String extraJarsPath) throws Exception {
// Does download and install from URL
-super(installDir, version.getDownloadURL(), connType, "tomcat");
+super(installDir, version.getDownloadURL(), connType, "tomcat",
--- End diff --
Refactor both "tomcat" and DEFAULT_MODULE_LOCATION pass down/up into other
constructors
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #712: GEODE-3434: Allow the modules to be interoperable w...
Github user DivineEnder commented on a diff in the pull request:
https://github.com/apache/geode/pull/712#discussion_r133012057
--- Diff:
geode-assembly/src/test/java/org/apache/geode/session/tests/TomcatInstall.java
---
@@ -150,6 +166,66 @@ public TomcatInstall(TomcatVersion version,
ConnectionType connType, String inst
}
/**
+ * Copies jars specified by {@link #tomcatRequiredJars} from the {@link
#getModulePath()} and the
+ * specified other directory passed to the function
+ *
+ * @throws IOException if the {@link #getModulePath()}, installation lib
directory, or extra
+ * directory passed in contain no files.
+ */
+ private void copyTomcatGeodeReqFiles(String moduleJarDir, String
extraJarsPath)
--- End diff --
Copy stuff in function into other function
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #712: GEODE-3434: Allow the modules to be interoperable w...
Github user DivineEnder commented on a diff in the pull request:
https://github.com/apache/geode/pull/712#discussion_r133012849
--- Diff:
geode-assembly/src/test/java/org/apache/geode/session/tests/TomcatSessionBackwardsCompatibilityTest.java
---
@@ -0,0 +1,254 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF
ANY KIND, either express
+ * or implied. See the License for the specific language governing
permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.session.tests;
+
+import static org.junit.Assert.assertEquals;
+
+import java.io.BufferedReader;
+import java.io.File;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.InputStreamReader;
+import java.net.URISyntaxException;
+import java.util.Collection;
+import java.util.List;
+
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.rules.TestName;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
+
+import org.apache.geode.internal.AvailablePortHelper;
+import org.apache.geode.management.internal.cli.i18n.CliStrings;
+import org.apache.geode.management.internal.cli.util.CommandStringBuilder;
+import org.apache.geode.test.dunit.rules.GfshShellConnectionRule;
+import org.apache.geode.test.dunit.rules.LocatorServerStartupRule;
+import org.apache.geode.test.dunit.standalone.VersionManager;
+import org.apache.geode.test.junit.categories.BackwardCompatibilityTest;
+import org.apache.geode.test.junit.categories.DistributedTest;
+import
org.apache.geode.test.junit.runners.CategoryWithParameterizedRunnerFactory;
+
+/**
+ * This test iterates through the versions of Geode and executes session
client compatibility with
+ * the current version of Geode.
+ */
+@Category({DistributedTest.class, BackwardCompatibilityTest.class})
+@RunWith(Parameterized.class)
+@Parameterized.UseParametersRunnerFactory(CategoryWithParameterizedRunnerFactory.class)
+public class TomcatSessionBackwardsCompatibilityTest {
+
+ @Parameterized.Parameters
+ public static Collection data() {
+List result =
VersionManager.getInstance().getVersionsWithoutCurrent();
+result.removeIf(s -> Integer.parseInt(s) < 120);
+if (result.size() < 1) {
+ throw new RuntimeException("No older versions of Geode were found to
test against");
+}
+return result;
+ }
+
+ @Rule
+ public transient GfshShellConnectionRule gfsh = new
GfshShellConnectionRule();
+
+ @Rule
+ public transient LocatorServerStartupRule locatorStartup = new
LocatorServerStartupRule();
+
+ @Rule
+ public transient TestName testName = new TestName();
+
+ public transient Client client;
+ public transient ContainerManager manager;
+
+ File oldBuild;
+ File oldModules;
+
+ TomcatInstall tomcat7079AndOldModules;
+ TomcatInstall tomcat7079AndCurrentModules;
+ TomcatInstall tomcat8AndOldModules;
+ TomcatInstall tomcat8AndCurrentModules;
+
+ int locatorPort;
+ String classPathTomcat7079;
+ String classPathTomcat8;
+
+ public TomcatSessionBackwardsCompatibilityTest(String version) {
+VersionManager versionManager = VersionManager.getInstance();
+String installLocation = versionManager.getInstall(version);
+oldBuild = new File(installLocation);
+oldModules = new File(installLocation + "/tools/Modules/");
+ }
+
+ protected void startServer(String name, String classPath, int
locatorPort) throws Exception {
+CommandStringBuilder command = new
CommandStringBuilder(CliStrings.START_SERVER);
+command.addOption(CliStrings.START_SERVER__NAME, name);
+command.addOption(CliStrings.START_SERVER__SERVER_PORT, "0");
+command.addOption(CliStrings.START_SERVER__CLASSPATH, classPath);
+command.addOption(CliStrings.START_SERVER__LOCATORS, "localhost[" +
locatorPort + "]");
+gfsh.ex
[GitHub] geode pull request #712: GEODE-3434: Allow the modules to be interoperable w...
Github user DivineEnder commented on a diff in the pull request: https://github.com/apache/geode/pull/712#discussion_r133013329 --- Diff: geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneEventListener.java --- @@ -34,6 +34,7 @@ import org.apache.geode.cache.query.internal.DefaultQuery; import org.apache.geode.internal.cache.BucketNotFoundException; import org.apache.geode.internal.cache.PrimaryBucketException; +import org.apache.geode.internal.cache.tier.sockets.command.Default; --- End diff -- Organize imports --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #712: GEODE-3434: Allow the modules to be interoperable w...
Github user DivineEnder commented on a diff in the pull request:
https://github.com/apache/geode/pull/712#discussion_r133013984
--- Diff: geode-old-versions/build.gradle ---
@@ -65,6 +100,71 @@ task createGeodeClasspathsFile {
new FileOutputStream(classpathsFile).withStream { fos ->
versions.store(fos, '')
}
+
+installsFile.getParentFile().mkdirs();
+
+new FileOutputStream(installsFile).withStream { fos ->
+ project.ext.installs.store(fos, '')
+}
}
+
+ // Add sourceSets for backwards compatibility, rolling upgrade, and
+// pdx testing.
+ addOldVersion('test100', '1.0.0-incubating')
+ addOldVersion('test110', '1.1.0')
+ addOldVersion('test111', '1.1.1')
+ addOldVersion('test120', '1.2.0')
+
+
+
+//
+// def downloadUrl = (geodeReleaseUrl != "") ? geodeReleaseUrl :
--- End diff --
Clean up commented code
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #712: GEODE-3434: Allow the modules to be interoperable w...
Github user DivineEnder commented on a diff in the pull request: https://github.com/apache/geode/pull/712#discussion_r133256792 --- Diff: geode-assembly/src/test/java/org/apache/geode/session/tests/ContainerInstall.java --- @@ -18,6 +18,7 @@ import java.io.FileInputStream; import java.io.FileOutputStream; import java.io.IOException; +import java.net.URI; --- End diff -- I think this is extraneous. It doesn't seem to be used anywhere in this file. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #712: GEODE-3434: Allow the modules to be interoperable w...
Github user DivineEnder commented on a diff in the pull request: https://github.com/apache/geode/pull/712#discussion_r133268501 --- Diff: geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneEventListener.java --- @@ -34,7 +34,6 @@ import org.apache.geode.cache.query.internal.DefaultQuery; import org.apache.geode.internal.cache.BucketNotFoundException; import org.apache.geode.internal.cache.PrimaryBucketException; -import org.apache.geode.internal.cache.tier.sockets.command.Default; --- End diff -- Can you organize imports on this file since this import seems to have changed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #722: GEODE-3184: Cleaned up Cargo tests
GitHub user DivineEnder opened a pull request: https://github.com/apache/geode/pull/722 GEODE-3184: Cleaned up Cargo tests Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to dev@geode.apache.org. You can merge this pull request into a Git repository by running: $ git pull https://github.com/DivineEnder/geode feature/GEODE-3184 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/722.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #722 commit b47c7fd5491bf4725005d4ea57aa6192df6176cc Author: David Anuta Date: 2017-08-18T16:41:24Z GEODE-3184: Cleaned up Cargo tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
