Github user DivineEnder commented on a diff in the pull request:
https://github.com/apache/geode/pull/712#discussion_r133011336
--- Diff:
geode-assembly/src/test/java/org/apache/geode/session/tests/TomcatInstall.java
---
@@ -131,15 +142,20 @@ public TomcatInstall(TomcatVersion version,
ConnectionType connType) throws Exce
* within the installation's 'conf' folder, and {@link
#updateProperties()} to set the jar
* skipping properties needed to speedup container startup.
*/
- public TomcatInstall(TomcatVersion version, ConnectionType connType,
String installDir)
- throws Exception {
+ public TomcatInstall(TomcatVersion version, ConnectionType connType,
String installDir,
+ String modulesJarLocation, String extraJarsPath) throws Exception {
// Does download and install from URL
- super(installDir, version.getDownloadURL(), connType, "tomcat");
+ super(installDir, version.getDownloadURL(), connType, "tomcat",
--- End diff --
Refactor both "tomcat" and DEFAULT_MODULE_LOCATION pass down/up into other
constructors
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
