RE: Update geode-native-build image as part of release process
Done! I have updated the wiki adding the steps to update the Docker image. https://cwiki.apache.org/confluence/display/GEODE/Releasing+Apache+Geode#ReleasingApacheGeode-Updategeode-native-buildDockerimage De: Dick Cavender Enviado: jueves, 7 de noviembre de 2019 17:51 Para: dev@geode.apache.org Asunto: Re: Update geode-native-build image as part of release process +1 On Thu, Nov 7, 2019 at 8:38 AM Owen Nichols wrote: > +1 > > On Thu, Nov 7, 2019 at 6:46 AM Alberto Bustamante Reyes > wrote: > > > Hi all, > > > > Some time ago I opened GEODE-7056 to update the Dockerfile of the > > "geode-native-build", because I saw that it was using 1.6.0 although > 1.9.0 > > was available. After this change, other ticket was needed to build and > > update the image in Dockerhub. > > > > I think this task (update file, build image and update image) should be > > part of the release process. Otherwise, the image will be outdated once > > there is a new release. And now that 1.11.0 is closer, I think its a good > > moment to do it. > > > > What do you think? > > > > BR/ > > > > Alberto B. > > >
ParallelGatewaySenderQueue implementation
Hi geode dev, I am investigating SerialGatewaySenderQueue and ParallelGatewaySenderQueue implementation, and I found that in ParallelGatewaySenderQueue.close() function, code is deleted and comment is left: // Because of bug 49060 do not close the regions of a parallel queue My question is, where can I find some more info regarding this bug. BR, Mario
Propose adding GEODE-7400 fix to 1.11 release
I propose merging the fix for GEODE-7400 (merged to develop today) to the 1.11 release branch. My fix for GEODE-7330 (merged to develop in late October) introduced GEODE-7400 which is the potential for RejectedExecutionException to be thrown within FederatingManager. Thanks, Kirk commit 3c5a6ccf40b03c345f53f28214513a9d76a1e024 Author: Aaron Lindsey Date: Mon Nov 11 09:36:24 2019 -0800 GEODE-7400: Prevent RejectedExecutionException in FederatingManager (#4270) Commit f0c96db73263bb1b3cb04558f2a720d70f43421f changed the FederatingManager class so that it reuses the same ExecutorService between restarts. After that change, if we start the manager after previously starting and stopping it, we get RejectedExecutionException because it tries to invoke a task on the same ExecutorService which has been shut down. This commit changes the FederatingManager so that it invokes a supplier to get a new ExecutorService each time it is started to prevent the RejectedExecutionException. Co-authored-by: Aaron Lindsey Co-authored-by: Kirk Lund
Re: Propose adding GEODE-7400 fix to 1.11 release
+1 On Mon, Nov 11, 2019 at 9:41 AM Kirk Lund wrote: > I propose merging the fix for GEODE-7400 (merged to develop today) to the > 1.11 release branch. > > My fix for GEODE-7330 (merged to develop in late October) introduced > GEODE-7400 which is the potential for RejectedExecutionException to be > thrown within FederatingManager. > > Thanks, > Kirk > > commit 3c5a6ccf40b03c345f53f28214513a9d76a1e024 > Author: Aaron Lindsey > Date: Mon Nov 11 09:36:24 2019 -0800 > > GEODE-7400: Prevent RejectedExecutionException in FederatingManager > (#4270) > > Commit f0c96db73263bb1b3cb04558f2a720d70f43421f changed the > FederatingManager class so that it reuses the same ExecutorService > between restarts. After that change, if we start the manager after > previously starting and stopping it, we get RejectedExecutionException > because it tries to invoke a task on the same ExecutorService which has > been shut down. > > This commit changes the FederatingManager so that it invokes a supplier > to get a new ExecutorService each time it is started to prevent the > RejectedExecutionException. > > Co-authored-by: Aaron Lindsey > Co-authored-by: Kirk Lund >
Re: Update geode-native-build image as part of release process
Thanks Alberto! Maybe as a future enhancement we should consider extending the geode-native-build image from the geode image to make this simpler. Anthony > On Nov 11, 2019, at 2:42 AM, Alberto Bustamante Reyes > wrote: > > Done! I have updated the wiki adding the steps to update the Docker image. > > https://cwiki.apache.org/confluence/display/GEODE/Releasing+Apache+Geode#ReleasingApacheGeode-Updategeode-native-buildDockerimage > > > > De: Dick Cavender > Enviado: jueves, 7 de noviembre de 2019 17:51 > Para: dev@geode.apache.org > Asunto: Re: Update geode-native-build image as part of release process > > +1 > > On Thu, Nov 7, 2019 at 8:38 AM Owen Nichols wrote: > >> +1 >> >> On Thu, Nov 7, 2019 at 6:46 AM Alberto Bustamante Reyes >> wrote: >> >>> Hi all, >>> >>> Some time ago I opened GEODE-7056 to update the Dockerfile of the >>> "geode-native-build", because I saw that it was using 1.6.0 although >> 1.9.0 >>> was available. After this change, other ticket was needed to build and >>> update the image in Dockerhub. >>> >>> I think this task (update file, build image and update image) should be >>> part of the release process. Otherwise, the image will be outdated once >>> there is a new release. And now that 1.11.0 is closer, I think its a good >>> moment to do it. >>> >>> What do you think? >>> >>> BR/ >>> >>> Alberto B. >>> >>
Re: Propose adding GEODE-7400 fix to 1.11 release
+1 > On Nov 11, 2019, at 9:42 AM, Jason Huynh wrote: > > +1 > > On Mon, Nov 11, 2019 at 9:41 AM Kirk Lund wrote: > >> I propose merging the fix for GEODE-7400 (merged to develop today) to the >> 1.11 release branch. >> >> My fix for GEODE-7330 (merged to develop in late October) introduced >> GEODE-7400 which is the potential for RejectedExecutionException to be >> thrown within FederatingManager. >> >> Thanks, >> Kirk >> >> commit 3c5a6ccf40b03c345f53f28214513a9d76a1e024 >> Author: Aaron Lindsey >> Date: Mon Nov 11 09:36:24 2019 -0800 >> >>GEODE-7400: Prevent RejectedExecutionException in FederatingManager >> (#4270) >> >>Commit f0c96db73263bb1b3cb04558f2a720d70f43421f changed the >>FederatingManager class so that it reuses the same ExecutorService >>between restarts. After that change, if we start the manager after >>previously starting and stopping it, we get RejectedExecutionException >>because it tries to invoke a task on the same ExecutorService which has >>been shut down. >> >>This commit changes the FederatingManager so that it invokes a supplier >>to get a new ExecutorService each time it is started to prevent the >>RejectedExecutionException. >> >>Co-authored-by: Aaron Lindsey >>Co-authored-by: Kirk Lund >>
Re: Propose adding GEODE-7400 fix to 1.11 release
+1 On 11/11/19 9:41 AM, Kirk Lund wrote: I propose merging the fix for GEODE-7400 (merged to develop today) to the 1.11 release branch. My fix for GEODE-7330 (merged to develop in late October) introduced GEODE-7400 which is the potential for RejectedExecutionException to be thrown within FederatingManager. Thanks, Kirk commit 3c5a6ccf40b03c345f53f28214513a9d76a1e024 Author: Aaron Lindsey Date: Mon Nov 11 09:36:24 2019 -0800 GEODE-7400: Prevent RejectedExecutionException in FederatingManager (#4270) Commit f0c96db73263bb1b3cb04558f2a720d70f43421f changed the FederatingManager class so that it reuses the same ExecutorService between restarts. After that change, if we start the manager after previously starting and stopping it, we get RejectedExecutionException because it tries to invoke a task on the same ExecutorService which has been shut down. This commit changes the FederatingManager so that it invokes a supplier to get a new ExecutorService each time it is started to prevent the RejectedExecutionException. Co-authored-by: Aaron Lindsey Co-authored-by: Kirk Lund
