+1 On Mon, Nov 11, 2019 at 9:41 AM Kirk Lund <kl...@apache.org> wrote:
> I propose merging the fix for GEODE-7400 (merged to develop today) to the > 1.11 release branch. > > My fix for GEODE-7330 (merged to develop in late October) introduced > GEODE-7400 which is the potential for RejectedExecutionException to be > thrown within FederatingManager. > > Thanks, > Kirk > > commit 3c5a6ccf40b03c345f53f28214513a9d76a1e024 > Author: Aaron Lindsey <alind...@pivotal.io> > Date: Mon Nov 11 09:36:24 2019 -0800 > > GEODE-7400: Prevent RejectedExecutionException in FederatingManager > (#4270) > > Commit f0c96db73263bb1b3cb04558f2a720d70f43421f changed the > FederatingManager class so that it reuses the same ExecutorService > between restarts. After that change, if we start the manager after > previously starting and stopping it, we get RejectedExecutionException > because it tries to invoke a task on the same ExecutorService which has > been shut down. > > This commit changes the FederatingManager so that it invokes a supplier > to get a new ExecutorService each time it is started to prevent the > RejectedExecutionException. > > Co-authored-by: Aaron Lindsey <alind...@pivotal.io> > Co-authored-by: Kirk Lund <kl...@apache.org> >
