geode-core dependencies for maven pom

2018-12-06 Thread Kirk Lund 
Can someone please point me at the right place to review and alter
the dependencies for geode-core that are being published for its maven pom?

Also, are there any tests involving the dependencies of the geode-core
maven pom?

Re: geode-core dependencies for maven pom

2018-12-06 Thread Kirk Lund 
Is this the only file controlling and testing the dependencies for the
geode-core maven pom that we publish?

geode-core/src/test/resources/expected-pom.xml

On Thu, Dec 6, 2018 at 9:52 AM Kirk Lund  wrote:

> Can someone please point me at the right place to review and alter
> the dependencies for geode-core that are being published for its maven pom?
>
> Also, are there any tests involving the dependencies of the geode-core
> maven pom?
>

Re: geode-core dependencies for maven pom

2018-12-06 Thread Jacob Barrett 
That file is only for testing that the contents are as expected. The POM is 
generated from dependencies and transitive dependencies specified in the 
various Gradle files.

> On Dec 6, 2018, at 9:55 AM, Kirk Lund  wrote:
> 
> Is this the only file controlling and testing the dependencies for the
> geode-core maven pom that we publish?
> 
> geode-core/src/test/resources/expected-pom.xml
> 
>> On Thu, Dec 6, 2018 at 9:52 AM Kirk Lund  wrote:
>> 
>> Can someone please point me at the right place to review and alter
>> the dependencies for geode-core that are being published for its maven pom?
>> 
>> Also, are there any tests involving the dependencies of the geode-core
>> maven pom?
>>

Re: geode-core dependencies for maven pom

2018-12-06 Thread Kirk Lund 
The geode-core maven pom is missing "spring-shell" -- where can I go to add
in "spring-shell" as a required dependency? That's the code or gradle or
xml that I want to look at.

On Thu, Dec 6, 2018 at 9:57 AM Jacob Barrett  wrote:

> That file is only for testing that the contents are as expected. The POM
> is generated from dependencies and transitive dependencies specified in the
> various Gradle files.
>
> > On Dec 6, 2018, at 9:55 AM, Kirk Lund  wrote:
> >
> > Is this the only file controlling and testing the dependencies for the
> > geode-core maven pom that we publish?
> >
> > geode-core/src/test/resources/expected-pom.xml
> >
> >> On Thu, Dec 6, 2018 at 9:52 AM Kirk Lund  wrote:
> >>
> >> Can someone please point me at the right place to review and alter
> >> the dependencies for geode-core that are being published for its maven
> pom?
> >>
> >> Also, are there any tests involving the dependencies of the geode-core
> >> maven pom?
> >>
>

Re: geode-core dependencies for maven pom

2018-12-06 Thread Kirk Lund 
Is the presence of "ext.optional = true" for spring-shell in
geode-core/build.gradle the reason it's missing from the geode-core maven
pom?

  compile('org.springframework.shell:spring-shell:' +
project.'spring-shell.version') {
exclude module: 'aopalliance'
exclude module: 'asm'
exclude module: 'cglib'
exclude module: 'guava'
exclude module: 'spring-aop'
exclude module: 'spring-context-support'
exclude module: 'spring-core'
*ext.optional = true*
  }


On Thu, Dec 6, 2018 at 10:12 AM Kirk Lund  wrote:

> The geode-core maven pom is missing "spring-shell" -- where can I go to
> add in "spring-shell" as a required dependency? That's the code or gradle
> or xml that I want to look at.
>
> On Thu, Dec 6, 2018 at 9:57 AM Jacob Barrett  wrote:
>
>> That file is only for testing that the contents are as expected. The POM
>> is generated from dependencies and transitive dependencies specified in the
>> various Gradle files.
>>
>> > On Dec 6, 2018, at 9:55 AM, Kirk Lund  wrote:
>> >
>> > Is this the only file controlling and testing the dependencies for the
>> > geode-core maven pom that we publish?
>> >
>> > geode-core/src/test/resources/expected-pom.xml
>> >
>> >> On Thu, Dec 6, 2018 at 9:52 AM Kirk Lund  wrote:
>> >>
>> >> Can someone please point me at the right place to review and alter
>> >> the dependencies for geode-core that are being published for its maven
>> pom?
>> >>
>> >> Also, are there any tests involving the dependencies of the geode-core
>> >> maven pom?
>> >>
>>
>

Re: geode-core dependencies for maven pom

2018-12-06 Thread Jacob Barrett 
It should be in the POM as optional. 

> On Dec 6, 2018, at 10:17 AM, Kirk Lund  wrote:
> 
> Is the presence of "ext.optional = true" for spring-shell in
> geode-core/build.gradle the reason it's missing from the geode-core maven
> pom?
> 
>  compile('org.springframework.shell:spring-shell:' +
> project.'spring-shell.version') {
>exclude module: 'aopalliance'
>exclude module: 'asm'
>exclude module: 'cglib'
>exclude module: 'guava'
>exclude module: 'spring-aop'
>exclude module: 'spring-context-support'
>exclude module: 'spring-core'
>*ext.optional = true*
>  }
> 
> 
>> On Thu, Dec 6, 2018 at 10:12 AM Kirk Lund  wrote:
>> 
>> The geode-core maven pom is missing "spring-shell" -- where can I go to
>> add in "spring-shell" as a required dependency? That's the code or gradle
>> or xml that I want to look at.
>> 
>>> On Thu, Dec 6, 2018 at 9:57 AM Jacob Barrett  wrote:
>>> 
>>> That file is only for testing that the contents are as expected. The POM
>>> is generated from dependencies and transitive dependencies specified in the
>>> various Gradle files.
>>> 
 On Dec 6, 2018, at 9:55 AM, Kirk Lund  wrote:
 
 Is this the only file controlling and testing the dependencies for the
 geode-core maven pom that we publish?
 
 geode-core/src/test/resources/expected-pom.xml
 
> On Thu, Dec 6, 2018 at 9:52 AM Kirk Lund  wrote:
> 
> Can someone please point me at the right place to review and alter
> the dependencies for geode-core that are being published for its maven
>>> pom?
> 
> Also, are there any tests involving the dependencies of the geode-core
> maven pom?
> 
>>> 
>>

Re: [VOTE] Apache Geode 1.8.0 RC2

2018-12-06 Thread Dan Smith 
The native source distribution tarball seems to have a lot of files that
aren't in source control. See attached:

-Dan

On Wed, Dec 5, 2018 at 6:19 PM Alexander Murmann 
wrote:

> Hi Apache Geode community,
>
> Below you find all the information for the the second release candidate of
> Geode 1.8.0. All packaging issues related to Geode native should be
> resolved in this candidate. Everything else is unchanged.
>
> Please review and provide feedback, so that the vote can end by the end of
> day Monday, Dec. 10th.
>
> Release notes can still be found at
>
> https://cwiki.apache.org/confluence/display/GEODE/Release+Notes#ReleaseNotes-1.8.0
>
> Apache Geode:
> https://github.com/apache/geode/tree/rel/v1.8.0.RC2
> Apache Geode examples:
> https://github.com/apache/geode-examples/tree/rel/v1.8.0.RC2
> Apache Geode Native:
> https://github.com/apache/geode-native/tree/rel/v1.8.0.RC2
>
> Commit IDs:
> Apache Geode: 671671b5e81acde2684df3331aedf176cc927e6e
> Apache Geode Examples: aee3794f1302ffab51b4ca5d02657598420b7a00
> Apache Geode Native: ae8c6b2500ee8ffb600e5a295c053e9b2ac880ee
>
> Source and binary files:
> https://dist.apache.org/repos/dist/dev/geode/1.8.0.RC2/
>
> Maven staging repo:
> https://repository.apache.org/content/repositories/orgapachegeode-1048
>
> Geode's KEYS file containing PGP keys we use to sign the release:
> https://github.com/apache/geode/blob/develop/KEYS
>
> Signed the release with fingerprint:
> rsa4096 2018-09-01 [SC]
> D5C5C950D61898EDE8928820D6048392BDFB7797
>
build> diff -r -q nativeSrcClone/ nativeSrcDist/apache-geode-native/
Only in nativeSrcClone/: .git
Only in nativeSrcClone/: .gitignore
Only in nativeSrcDist/apache-geode-native/: CMakeCache.txt
Only in nativeSrcDist/apache-geode-native/: CMakeDoxyfile.in
Only in nativeSrcDist/apache-geode-native/: CMakeDoxygenDefaults.cmake
Only in nativeSrcDist/apache-geode-native/: CMakeFiles
Only in nativeSrcDist/apache-geode-native/: CPackConfig.cmake
Only in nativeSrcDist/apache-geode-native/: CPackSourceConfig.cmake
Only in nativeSrcDist/apache-geode-native/: Makefile
Only in nativeSrcDist/apache-geode-native/: _CPack_Packages
Only in nativeSrcDist/apache-geode-native/: cmake_install.cmake
Only in nativeSrcDist/apache-geode-native/cppcache: CMakeFiles
Only in nativeSrcDist/apache-geode-native/cppcache: Makefile
Only in nativeSrcDist/apache-geode-native/cppcache: apache-geode_export.h
Only in nativeSrcDist/apache-geode-native/cppcache: cmake_install.cmake
Only in nativeSrcDist/apache-geode-native/cppcache: config.h
Only in nativeSrcDist/apache-geode-native/cppcache/integration-test: 
.testAttributesMutator.sh.in
Only in nativeSrcDist/apache-geode-native/cppcache/integration-test: 
.testCache.sh.in
Only in nativeSrcDist/apache-geode-native/cppcache/integration-test: 
.testCacheless.sh.in
Only in nativeSrcDist/apache-geode-native/cppcache/integration-test: 
.testCreateAndDestroyPool.sh.in
Only in nativeSrcDist/apache-geode-native/cppcache/integration-test: 
.testDataOutput.sh.in
Only in nativeSrcDist/apache-geode-native/cppcache/integration-test: 
.testDunit.sh.in
Only in nativeSrcDist/apache-geode-native/cppcache/integration-test: 
.testExpiration.sh.in
Only in nativeSrcDist/apache-geode-native/cppcache/integration-test: 
.testFWHelper.sh.in
Only in nativeSrcDist/apache-geode-native/cppcache/integration-test: 
.testFwPerf.sh.in
Only in nativeSrcDist/apache-geode-native/cppcache/integration-test: 
.testLRUList.sh.in
Only in nativeSrcDist/apache-geode-native/cppcache/integration-test: 
.testLinkage.sh.in
Only in nativeSrcDist/apache-geode-native/cppcache/integration-test: 
.testLogger.sh.in
Only in nativeSrcDist/apache-geode-native/cppcache/integration-test: 
.testOverflowPutGetSqLite.sh.in
Only in nativeSrcDist/apache-geode-native/cppcache/integration-test: 
.testPdxMetadataCheckTest.sh.in
Only in nativeSrcDist/apache-geode-native/cppcache/integration-test: 
.testPoolFactory.sh.in
Only in nativeSrcDist/apache-geode-native/cppcache/integration-test: 
.testRegionAccessThreadSafe.sh.in
Only in nativeSrcDist/apache-geode-native/cppcache/integration-test: 
.testRegionAttributesFactory.sh.in
Only in nativeSrcDist/apache-geode-native/cppcache/integration-test: 
.testRegionMap.sh.in
Only in nativeSrcDist/apache-geode-native/cppcache/integration-test: 
.testRegionTemplateArgs.sh.in
Only in nativeSrcDist/apache-geode-native/cppcache/integration-test: 
.testSerialization.sh.in
Only in nativeSrcDist/apache-geode-native/cppcache/integration-test: 
.testSpinLock.sh.in
Only in nativeSrcDist/apache-geode-native/cppcache/integration-test: 
.testSystemProperties.sh.in
Only in nativeSrcDist/apache-geode-native/cppcache/integration-test: 
.testThinClientAfterRegionLive.sh.in
Only in nativeSrcDist/apache-geode-native/cppcache/integration-test: 
.testThinClientBigValue.sh.in
Only in nativeSrcDist/apache-geode-native/cppcache/integration-test: 
.testThinClientCacheableStringArray.sh.in
Only in nativeSrcDist/apache-geode-native/cppcache/integration-test: 
.test

Re: [VOTE] Apache Geode 1.8.0 RC2

2018-12-06 Thread Jacob Barrett 
Looks like someone executed CMake in the source directory. 

> On Dec 6, 2018, at 10:34 AM, Dan Smith  wrote:
> 
> The native source distribution tarball seems to have a lot of files that 
> aren't in source control. See attached:
> 
> -Dan
> 
>> On Wed, Dec 5, 2018 at 6:19 PM Alexander Murmann  wrote:
>> Hi Apache Geode community,
>> 
>> Below you find all the information for the the second release candidate of
>> Geode 1.8.0. All packaging issues related to Geode native should be
>> resolved in this candidate. Everything else is unchanged.
>> 
>> Please review and provide feedback, so that the vote can end by the end of
>> day Monday, Dec. 10th.
>> 
>> Release notes can still be found at
>> https://cwiki.apache.org/confluence/display/GEODE/Release+Notes#ReleaseNotes-1.8.0
>> 
>> Apache Geode:
>> https://github.com/apache/geode/tree/rel/v1.8.0.RC2
>> Apache Geode examples:
>> https://github.com/apache/geode-examples/tree/rel/v1.8.0.RC2
>> Apache Geode Native:
>> https://github.com/apache/geode-native/tree/rel/v1.8.0.RC2
>> 
>> Commit IDs:
>> Apache Geode: 671671b5e81acde2684df3331aedf176cc927e6e
>> Apache Geode Examples: aee3794f1302ffab51b4ca5d02657598420b7a00
>> Apache Geode Native: ae8c6b2500ee8ffb600e5a295c053e9b2ac880ee
>> 
>> Source and binary files:
>> https://dist.apache.org/repos/dist/dev/geode/1.8.0.RC2/
>> 
>> Maven staging repo:
>> https://repository.apache.org/content/repositories/orgapachegeode-1048
>> 
>> Geode's KEYS file containing PGP keys we use to sign the release:
>> https://github.com/apache/geode/blob/develop/KEYS
>> 
>> Signed the release with fingerprint:
>> rsa4096 2018-09-01 [SC]
>> D5C5C950D61898EDE8928820D6048392BDFB7797
>

Re: geode-core dependencies for maven pom

2018-12-06 Thread Kirk Lund 
I disagree 100%. It is required for the main use of geode-core which is to
create a Cache. Client Cache is something that came later. If you want it a
dependency to be optional for Client Caches then please create a
geode-client module that generates a pom without this dependency or move
the dependency from geode-core to geode-gfsh and make the latter optional
for creation of Client Caches. This kind of thing is why Users consider
Geode difficult to use. Marking the dependency as optional in geode-core
without any of the changes necessary to make it truly optional is simply a
bug.

The geode-core pom should be considered the pom for Geode Cache, not Geode
Client Cache. If we want to have a separate module for clients which leaves
out certain dependencies then that would be one approach. Moving GFSH and
the spring-shell dependent code to another Geode module would also be
another approach that works. But simply crippling a pom so that one of the
main uses of Geode does not work out of box is a big no-no.

Creating a Cache in an application using maven dependencies (geode-core
specifically) is supported but broken because we flag spring-shell as
optional.

A User who creates a Cache in an application should not be forced to either
have JMX broken or explicitly add in spring-shell to their application's
dependencies.

10:31:55.168 [main] WARN  o.a.g.d.i.InternalDistributedSystem -
org/springframework/shell/core/Parser
java.lang.NoClassDefFoundError: org/springframework/shell/core/Parser
at
org.apache.geode.management.internal.beans.MemberMBeanBridge.(MemberMBeanBridge.java:333)
at
org.apache.geode.management.internal.beans.ManagementAdapter.handleCacheCreation(ManagementAdapter.java:144)
at
org.apache.geode.management.internal.beans.ManagementListener.handleEvent(ManagementListener.java:115)
at
org.apache.geode.distributed.internal.InternalDistributedSystem.notifyResourceEventListeners(InternalDistributedSystem.java:2201)
at
org.apache.geode.distributed.internal.InternalDistributedSystem.handleResourceEvent(InternalDistributedSystem.java:606)
at
org.apache.geode.internal.cache.GemFireCacheImpl.initialize(GemFireCacheImpl.java:1214)
at
org.apache.geode.internal.cache.GemFireCacheImpl.basicCreate(GemFireCacheImpl.java:799)
at
org.apache.geode.internal.cache.GemFireCacheImpl.create(GemFireCacheImpl.java:785)
at org.apache.geode.cache.CacheFactory.create(CacheFactory.java:176)
at org.apache.geode.cache.CacheFactory.create(CacheFactory.java:223)
at
io.github.kirklund.geode.GeodeApplicationIntegrationTest.setUp(GeodeApplicationIntegrationTest.java:35)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)
at
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
at
com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
at
com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:47)
at
com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:242)
at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70)
Caused by: java.lang.ClassNotFoundException:
org.springframework.shell.core.Parser
at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:349)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
... 34 common frames omitted

You can reproduce this bug by specifying geode-core as a dependency in
maven:


org.apache.geode
geode-core
1.9.0-SNAPSHOT


And then create a Cache:

cache = new CacheFactory().set(LOCATORS, "").create();

You will see the above warning get lo

Re: geode-core dependencies for maven pom

2018-12-06 Thread Jacob Barrett 
You misunderstood my reply. You were saying it was missing from the Pom and I 
was saying that it should be in the Pom but marked optional. Whether it should 
be optional or not in the Pom isn’t really a concern I have. I plan on 
correcting this nasty stuff with a BOM. See modules PR.

> On Dec 6, 2018, at 10:58 AM, Kirk Lund  wrote:
> 
> I disagree 100%. It is required for the main use of geode-core which is to
> create a Cache. Client Cache is something that came later. If you want it a
> dependency to be optional for Client Caches then please create a
> geode-client module that generates a pom without this dependency or move
> the dependency from geode-core to geode-gfsh and make the latter optional
> for creation of Client Caches. This kind of thing is why Users consider
> Geode difficult to use. Marking the dependency as optional in geode-core
> without any of the changes necessary to make it truly optional is simply a
> bug.
> 
> The geode-core pom should be considered the pom for Geode Cache, not Geode
> Client Cache. If we want to have a separate module for clients which leaves
> out certain dependencies then that would be one approach. Moving GFSH and
> the spring-shell dependent code to another Geode module would also be
> another approach that works. But simply crippling a pom so that one of the
> main uses of Geode does not work out of box is a big no-no.
> 
> Creating a Cache in an application using maven dependencies (geode-core
> specifically) is supported but broken because we flag spring-shell as
> optional.
> 
> A User who creates a Cache in an application should not be forced to either
> have JMX broken or explicitly add in spring-shell to their application's
> dependencies.
> 
> 10:31:55.168 [main] WARN  o.a.g.d.i.InternalDistributedSystem -
> org/springframework/shell/core/Parser
> java.lang.NoClassDefFoundError: org/springframework/shell/core/Parser
> at
> org.apache.geode.management.internal.beans.MemberMBeanBridge.(MemberMBeanBridge.java:333)
> at
> org.apache.geode.management.internal.beans.ManagementAdapter.handleCacheCreation(ManagementAdapter.java:144)
> at
> org.apache.geode.management.internal.beans.ManagementListener.handleEvent(ManagementListener.java:115)
> at
> org.apache.geode.distributed.internal.InternalDistributedSystem.notifyResourceEventListeners(InternalDistributedSystem.java:2201)
> at
> org.apache.geode.distributed.internal.InternalDistributedSystem.handleResourceEvent(InternalDistributedSystem.java:606)
> at
> org.apache.geode.internal.cache.GemFireCacheImpl.initialize(GemFireCacheImpl.java:1214)
> at
> org.apache.geode.internal.cache.GemFireCacheImpl.basicCreate(GemFireCacheImpl.java:799)
> at
> org.apache.geode.internal.cache.GemFireCacheImpl.create(GemFireCacheImpl.java:785)
> at org.apache.geode.cache.CacheFactory.create(CacheFactory.java:176)
> at org.apache.geode.cache.CacheFactory.create(CacheFactory.java:223)
> at
> io.github.kirklund.geode.GeodeApplicationIntegrationTest.setUp(GeodeApplicationIntegrationTest.java:35)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
> at
> com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
> at
> com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:47)
> at
> com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:242)
> at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70)
> Caused by: java.lang.ClassNotFoundException:
> org.springframework.shell.core.Parser
> at java.net.URLClassLoader.findClass(URLClassLoader.java:38

Re: [VOTE] Apache Geode 1.8.0 RC2

2018-12-06 Thread Alexander Murmann 
Thanks again for catching this! This should now be fixed.

On Thu, Dec 6, 2018 at 10:42 AM Jacob Barrett  wrote:

> Looks like someone executed CMake in the source directory.
>
> > On Dec 6, 2018, at 10:34 AM, Dan Smith  wrote:
> >
> > The native source distribution tarball seems to have a lot of files that
> aren't in source control. See attached:
> >
> > -Dan
> >
> >> On Wed, Dec 5, 2018 at 6:19 PM Alexander Murmann 
> wrote:
> >> Hi Apache Geode community,
> >>
> >> Below you find all the information for the the second release candidate
> of
> >> Geode 1.8.0. All packaging issues related to Geode native should be
> >> resolved in this candidate. Everything else is unchanged.
> >>
> >> Please review and provide feedback, so that the vote can end by the end
> of
> >> day Monday, Dec. 10th.
> >>
> >> Release notes can still be found at
> >>
> https://cwiki.apache.org/confluence/display/GEODE/Release+Notes#ReleaseNotes-1.8.0
> >>
> >> Apache Geode:
> >> https://github.com/apache/geode/tree/rel/v1.8.0.RC2
> >> Apache Geode examples:
> >> https://github.com/apache/geode-examples/tree/rel/v1.8.0.RC2
> >> Apache Geode Native:
> >> https://github.com/apache/geode-native/tree/rel/v1.8.0.RC2
> >>
> >> Commit IDs:
> >> Apache Geode: 671671b5e81acde2684df3331aedf176cc927e6e
> >> Apache Geode Examples: aee3794f1302ffab51b4ca5d02657598420b7a00
> >> Apache Geode Native: ae8c6b2500ee8ffb600e5a295c053e9b2ac880ee
> >>
> >> Source and binary files:
> >> https://dist.apache.org/repos/dist/dev/geode/1.8.0.RC2/
> >>
> >> Maven staging repo:
> >> https://repository.apache.org/content/repositories/orgapachegeode-1048
> >>
> >> Geode's KEYS file containing PGP keys we use to sign the release:
> >> https://github.com/apache/geode/blob/develop/KEYS
> >>
> >> Signed the release with fingerprint:
> >> rsa4096 2018-09-01 [SC]
> >> D5C5C950D61898EDE8928820D6048392BDFB7797
> > 
>

Failing to get resources from Maven in CI

2018-12-06 Thread Helena Bales 
Hello,

It looks like we are still having some problems with Maven in CI. I got the
following error in the pre-checkin for this PR
 (the first commit). Since I
didn't change any dependencies, I would expect the image to already have
all the dependencies, and since we increased the timeout for the Maven
connection, I would expect us to be able to connect to Maven. This issue is
coming up frequently enough that I think we should do something about it.

What can we do to fix this?

Part of the error message:

   > Could not resolve com.netflix.nebula:nebula-gradle-interop:0.6.0.
 Required by:
 project : > com.netflix.nebula:nebula-project-plugin:5.1.0
 project : > com.netflix.nebula:nebula-project-plugin:5.1.0 >
com.netflix.nebula:gradle-dependency-lock-plugin:6.0.0
  > Could not resolve com.netflix.nebula:nebula-gradle-interop:0.6.0.
 > Could not get resource
'https://plugins.gradle.org/m2/com/netflix/nebula/nebula-gradle-interop/0.6.0/nebula-gradle-interop-0.6.0.pom'.
> Could not GET
'https://plugins.gradle.org/m2/com/netflix/nebula/nebula-gradle-interop/0.6.0/nebula-gradle-interop-0.6.0.pom'.
   > Connect to jcenter.bintray.com:443
[jcenter.bintray.com/75.126.118.188] failed: connect timed out

Re: Failing to get resources from Maven in CI

2018-12-06 Thread Jacob Barrett 
Given that this seems to be an ongoing problem with bintray I think it is time 
we put a local caching repository in our CI network. The native project ran 
into this same issue for months at one point. Depending on where in the 
internet you live the bintray host you get can be flakey. For native we would 
get a glacially slow server from a connections on a certain ISP. If we put 
Artifactory or something on a GCP instance and proxy all Maven dependencies 
through it we could cut down these issues significantly. If the artifact is 
already cached, nothing to do, but it needs to fetch upstream it is really good 
about trying multiple sources and retrying on transient failures.

Objections? Thoughts?

-Jake 


> On Dec 6, 2018, at 4:01 PM, Helena Bales  wrote:
> 
> Hello,
> 
> It looks like we are still having some problems with Maven in CI. I got the
> following error in the pre-checkin for this PR
> 
>  (the first commit). Since I
> didn't change any dependencies, I would expect the image to already have
> all the dependencies, and since we increased the timeout for the Maven
> connection, I would expect us to be able to connect to Maven. This issue is
> coming up frequently enough that I think we should do something about it.
> 
> What can we do to fix this?
> 
> Part of the error message:
> 
>> Could not resolve com.netflix.nebula:nebula-gradle-interop:0.6.0.
> Required by:
> project : > com.netflix.nebula:nebula-project-plugin:5.1.0
> project : > com.netflix.nebula:nebula-project-plugin:5.1.0 >
> com.netflix.nebula:gradle-dependency-lock-plugin:6.0.0
>> Could not resolve com.netflix.nebula:nebula-gradle-interop:0.6.0.
>> Could not get resource
> 'https://urldefense.proofpoint.com/v2/url?u=https-3A__plugins.gradle.org_m2_com_netflix_nebula_nebula-2Dgradle-2Dinterop_0.6.0_nebula-2Dgradle-2Dinterop-2D0.6.0.pom&d=DwIBaQ&c=lnl9vOaLMzsy2niBC8-h_K-7QJuNJEsFrzdndhuJ3Sw&r=dUZ47GLLeizzE2hSUiriIoTlIpvoqfbYDvZD45P2srM&m=W_6FJHVE85xyXpDMaO9yVyW-eRFIPNzpQTJjDm8KTlI&s=zF0AKeB_4ff6Z6vyIaQRZcISf6bZy9bVJUoYauZci-0&e='.
>> Could not GET
> 'https://urldefense.proofpoint.com/v2/url?u=https-3A__plugins.gradle.org_m2_com_netflix_nebula_nebula-2Dgradle-2Dinterop_0.6.0_nebula-2Dgradle-2Dinterop-2D0.6.0.pom&d=DwIBaQ&c=lnl9vOaLMzsy2niBC8-h_K-7QJuNJEsFrzdndhuJ3Sw&r=dUZ47GLLeizzE2hSUiriIoTlIpvoqfbYDvZD45P2srM&m=W_6FJHVE85xyXpDMaO9yVyW-eRFIPNzpQTJjDm8KTlI&s=zF0AKeB_4ff6Z6vyIaQRZcISf6bZy9bVJUoYauZci-0&e='.
>> Connect to 
>> https://urldefense.proofpoint.com/v2/url?u=http-3A__jcenter.bintray.com&d=DwIBaQ&c=lnl9vOaLMzsy2niBC8-h_K-7QJuNJEsFrzdndhuJ3Sw&r=dUZ47GLLeizzE2hSUiriIoTlIpvoqfbYDvZD45P2srM&m=W_6FJHVE85xyXpDMaO9yVyW-eRFIPNzpQTJjDm8KTlI&s=F2LvC1coGwut-9sy2cbmLeWeDafmNRiUYL458xaR_Q0&e=:443
> [https://urldefense.proofpoint.com/v2/url?u=http-3A__jcenter.bintray.com_75.126.118.188&d=DwIBaQ&c=lnl9vOaLMzsy2niBC8-h_K-7QJuNJEsFrzdndhuJ3Sw&r=dUZ47GLLeizzE2hSUiriIoTlIpvoqfbYDvZD45P2srM&m=W_6FJHVE85xyXpDMaO9yVyW-eRFIPNzpQTJjDm8KTlI&s=SNOKq9weHDmT2RyQzsjfOo_Jc2MCr9vP4NuGoHOp8I8&e=]
>  failed: connect timed out

Re: [VOTE] Apache Geode 1.8.0 RC2

2018-12-06 Thread Nabarun Nag 
+1 on the basis of the below tests.

-- Verified SHAs
-- Verified signatures.
-- Build apache-geode, apache-geode-examples, apache-geode-native
-- Ran the examples
-- start gfsh, start server, create region, do a put, verify using query.
--Verified commit IDs with the release tags.

We should create tickets to remove the zip release for
apache-geode-examples. And all releases with SHASUM 512
Regards
Naba

On Thu, Dec 6, 2018 at 12:54 PM Alexander Murmann 
wrote:

> Thanks again for catching this! This should now be fixed.
>
> On Thu, Dec 6, 2018 at 10:42 AM Jacob Barrett  wrote:
>
> > Looks like someone executed CMake in the source directory.
> >
> > > On Dec 6, 2018, at 10:34 AM, Dan Smith  wrote:
> > >
> > > The native source distribution tarball seems to have a lot of files
> that
> > aren't in source control. See attached:
> > >
> > > -Dan
> > >
> > >> On Wed, Dec 5, 2018 at 6:19 PM Alexander Murmann  >
> > wrote:
> > >> Hi Apache Geode community,
> > >>
> > >> Below you find all the information for the the second release
> candidate
> > of
> > >> Geode 1.8.0. All packaging issues related to Geode native should be
> > >> resolved in this candidate. Everything else is unchanged.
> > >>
> > >> Please review and provide feedback, so that the vote can end by the
> end
> > of
> > >> day Monday, Dec. 10th.
> > >>
> > >> Release notes can still be found at
> > >>
> >
> https://cwiki.apache.org/confluence/display/GEODE/Release+Notes#ReleaseNotes-1.8.0
> > >>
> > >> Apache Geode:
> > >> https://github.com/apache/geode/tree/rel/v1.8.0.RC2
> > >> Apache Geode examples:
> > >> https://github.com/apache/geode-examples/tree/rel/v1.8.0.RC2
> > >> Apache Geode Native:
> > >> https://github.com/apache/geode-native/tree/rel/v1.8.0.RC2
> > >>
> > >> Commit IDs:
> > >> Apache Geode: 671671b5e81acde2684df3331aedf176cc927e6e
> > >> Apache Geode Examples: aee3794f1302ffab51b4ca5d02657598420b7a00
> > >> Apache Geode Native: ae8c6b2500ee8ffb600e5a295c053e9b2ac880ee
> > >>
> > >> Source and binary files:
> > >> https://dist.apache.org/repos/dist/dev/geode/1.8.0.RC2/
> > >>
> > >> Maven staging repo:
> > >>
> https://repository.apache.org/content/repositories/orgapachegeode-1048
> > >>
> > >> Geode's KEYS file containing PGP keys we use to sign the release:
> > >> https://github.com/apache/geode/blob/develop/KEYS
> > >>
> > >> Signed the release with fingerprint:
> > >> rsa4096 2018-09-01 [SC]
> > >> D5C5C950D61898EDE8928820D6048392BDFB7797
> > > 
> >
>