How to export region keys in json file

2017-08-16 Thread Dinesh Akhand 
Hi,

How I can export Region keys in json file.

It will help full for us to use get command or remove command for particular 
key when we have the composite keys defined.

get --region=/CUSTOMER_1 
--key=({'customerID':'1593','customerGroup':'30013','cycleCode':'1','partitionID':'300133'})
 --key-class=amdocs.imdg.model.keys.CustomerKey
Message : Error in converting JSON Couldn't convert JSON to Object of type 
class amdocs.imdg.model.keys.CustomerKey


Thanks,
Dinesh Akhand
This message and the information contained herein is proprietary and 
confidential and subject to the Amdocs policy statement,

you may review at https://www.amdocs.com/about/email-disclaimer

ACTION REQUIRED: geode-native has moved

2017-08-16 Thread Jacob Barrett 
Devs,

The geode-native repo has moved to GitHub utilizing the Apache GitBox
service.

For contributors nothing really changes, the repo is still at
github.com/apache/geode-native.

For committers the origin is now github.com/apache/geode-native. Before you
can get write access to the new repo you need to "link" your accounts via
https://gitbox.apache.org/setup/. You should also change the URL of your
origin from Apache to GitHub. You will also notice we have full control
over pull requests, including assignments and labeling. Good times ahead.

Thanks Mark for getting this ball rolling.

-Jake

Re: ACTION REQUIRED: geode-native has moved

2017-08-16 Thread Michael William Dodge 
Does this affect a pre-existing fork?

Sarge

> On 16 Aug, 2017, at 07:24, Jacob Barrett  wrote:
> 
> Devs,
> 
> The geode-native repo has moved to GitHub utilizing the Apache GitBox
> service.
> 
> For contributors nothing really changes, the repo is still at
> github.com/apache/geode-native.
> 
> For committers the origin is now github.com/apache/geode-native. Before you
> can get write access to the new repo you need to "link" your accounts via
> https://gitbox.apache.org/setup/. You should also change the URL of your
> origin from Apache to GitHub. You will also notice we have full control
> over pull requests, including assignments and labeling. Good times ahead.
> 
> Thanks Mark for getting this ball rolling.
> 
> -Jake

Re: ACTION REQUIRED: geode-native has moved

2017-08-16 Thread Jacob Barrett 
Nope!

Sent from my iPhone

> On Aug 16, 2017, at 7:33 AM, Michael William Dodge  wrote:
> 
> Does this affect a pre-existing fork?
> 
> Sarge
> 
>> On 16 Aug, 2017, at 07:24, Jacob Barrett  wrote:
>> 
>> Devs,
>> 
>> The geode-native repo has moved to GitHub utilizing the Apache GitBox
>> service.
>> 
>> For contributors nothing really changes, the repo is still at
>> github.com/apache/geode-native.
>> 
>> For committers the origin is now github.com/apache/geode-native. Before you
>> can get write access to the new repo you need to "link" your accounts via
>> https://gitbox.apache.org/setup/. You should also change the URL of your
>> origin from Apache to GitHub. You will also notice we have full control
>> over pull requests, including assignments and labeling. Good times ahead.
>> 
>> Thanks Mark for getting this ball rolling.
>> 
>> -Jake
>

Re: Build failed in Jenkins: Geode-nightly #923

2017-08-16 Thread Jens Deppe 
I'm working on enabling parallel dunits in docker to work on Jenkins. If
this can happen it should help with some of these problems. However, it
requires fairly beefy systems to run well, otherwise you end up with other
issues around resource starvation. At worst we could just run with a
parallelism of 1 which should help with network isolation but won't help
with speeding up the build unfortunately.

--Jens

On Tue, Aug 15, 2017 at 2:01 PM, Mark Bretl  wrote:

> Hi Jared,
>
> Short answer: No, Longer answer: Ask Infra ;)
>
> We are generally running on VMs with multiple Jenkins executors, which
> means we could be sharing the box with other jobs. We have been
> piggybacking on other project's systems so far, trying to find 'available'
> systems. I have a feeling this is going to be an ongoing issue of getting a
> stable environment until we have another solution, such as requesting
> dedicated VMs or containers or etc.
>
> Open to ideas here...
>
> --Mark
>
>
> On Tue, Aug 15, 2017 at 10:59 AM, Jared Stewart 
> wrote:
>
> > It looks like all of our tests using default ports are failing in the
> > nightly build.  Here is my suspicion of what happened: We have some
> > Acceptance Tests that spin up separate JVMs for Locators and Servers.
> > Those tests make sure to kill their child processes as part of their
> > cleanup, but I suspect that when the build times out our test process
> gets
> > hard-killed, which would prevent the proper cleanup from taking place.
> > Does anyone have ssh access into this box to look for orphaned Java
> > processes?
> >
> > Thanks,
> > Jared
> >
> > > Begin forwarded message:
> > >
> > > From: Apache Jenkins Server 
> > > Subject: Build failed in Jenkins: Geode-nightly #923
> > > Date: August 14, 2017 at 8:53:03 PM PDT
> > > To: dev@geode.apache.org, kmil...@pivotal.io, kh...@apache.org,
> > bschucha...@pivotal.io, jstew...@pivotal.io, kl...@pivotal.io,
> > dschnei...@pivotal.io, dbar...@pivotal.io, n...@pivotal.io
> > > Reply-To: dev@geode.apache.org
> > >
> > > See  > irect?page=changes>
> > >
> > > Changes:
> > >
> > > [jiliao] GEODE-3328: fix a test failure on windows.
> > >
> > > [klund] Revert "GEODE-3328: fix a test failure on windows."
> > >
> > > [klund] GEODE-3436: revert recent refactoring of GFSH commands
> > >
> > > --
> > > [...truncated 129.88 KB...]
> > >org.apache.geode.test.dunit.RMIException: While invoking
> > org.apache.geode.modules.session.Tomcat8SessionsClientServer
> > DUnitTest$$Lambda$56/1529418967.call in VM 1 running on Host
> > asf905.gq1.ygridcore.net with 4 VMs
> > >at org.apache.geode.test.dunit.VM.invoke(VM.java:387)
> > >at org.apache.geode.test.dunit.VM.invoke(VM.java:357)
> > >at org.apache.geode.test.dunit.VM.invoke(VM.java:325)
> > >at org.apache.geode.modules.session.Tomcat8SessionsClientServer
> > DUnitTest.setupServer(Tomcat8SessionsClientServerDUnitTest.java:60)
> > >at org.apache.geode.modules.session.Tomcat8SessionsClientServer
> > DUnitTest.postSetUp(Tomcat8SessionsClientServerDUnitTest.java:44)
> > >
> > >Caused by:
> > >java.net.BindException: Failed to create server socket on
> > null[40,404]
> > >at org.apache.geode.internal.net.
> > SocketCreator.createServerSocket(SocketCreator.java:783)
> > >at org.apache.geode.internal.net.
> > SocketCreator.createServerSocket(SocketCreator.java:745)
> > >at org.apache.geode.internal.net.
> > SocketCreator.createServerSocket(SocketCreator.java:712)
> > >at org.apache.geode.internal.cach
> > e.tier.sockets.AcceptorImpl.(AcceptorImpl.java:469)
> > >at org.apache.geode.internal.cach
> > e.CacheServerImpl.start(CacheServerImpl.java:344)
> > >at org.apache.geode.modules.sessi
> > on.Tomcat8SessionsClientServerDUnitTest.lambda$setupServer$f
> > 0fd67c5$1(Tomcat8SessionsClientServerDUnitTest.java:65)
> > >
> > >Caused by:
> > >java.net.BindException: Address already in use (Bind failed)
> > >at java.net.PlainSocketImpl.socketBind(Native Method)
> > >at java.net.AbstractPlainSocketIm
> > pl.bind(AbstractPlainSocketImpl.java:387)
> > >at java.net.ServerSocket.bind(ServerSocket.java:375)
> > >at org.apache.geode.internal.net.
> > SocketCreator.createServerSocket(SocketCreator.java:779)
> > >... 5 more
> > >
> > > org.apache.geode.modules.session.Tomcat8SessionsClientServerDUnitTest
> >
> > testSanity FAILED
> > >org.apache.geode.test.dunit.RMIException: While invoking
> > org.apache.geode.modules.session.Tomcat8SessionsClientServer
> > DUnitTest$$Lambda$56/1529418967.call in VM 1 running on Host
> > asf905.gq1.ygridcore.net with 4 VMs
> > >at org.apache.geode.test.dunit.VM.invoke(VM.java:387)
> > >at org.apache.geode.test.dunit.VM.invoke(VM.java:35

Re: Review Request 61627: GEODE-3437: Fix list and describe region tests

2017-08-16 Thread Ken Howe 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61627/#review183037
---


Ship it!




Ship It!

- Ken Howe


On Aug. 14, 2017, 10:40 p.m., Jared Stewart wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61627/
> ---
> 
> (Updated Aug. 14, 2017, 10:40 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-3437: Fix list and describe region tests
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ListAndDescribeRegionDUnitTest.java
>  ab8c69b7cc99c88dd4e928efeb441d7d1a1d9b1b 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java
>  fc7966f5eb2a9ca4c30369a20ce664d3929ecc22 
> 
> 
> Diff: https://reviews.apache.org/r/61627/diff/1/
> 
> 
> Testing
> ---
> 
> Precheckin running
> 
> 
> Thanks,
> 
> Jared Stewart
> 
>

RE: continuous query internal mechanism questions

2017-08-16 Thread Roi Apelker 
Thanks,
The subscription-redundancy is set to "1" and the region is used in 2 nodes 
(there are more nodes which re not related to it).

Yes there is an exception, which I am yet to understand: (and this exception 
causes the closure of the CQ in this node as well as sending operation message 
to the other node to close!)

caught exception while running: 
java.io.IOException: Broken pipe
at sun.nio.ch.FileDispatcherImpl.write0(Native Method)
at sun.nio.ch.SocketDispatcher.write(SocketDispatcher.java:47)
at sun.nio.ch.IOUtil.writeFromNativeBuffer(IOUtil.java:93)
at sun.nio.ch.IOUtil.write(IOUtil.java:51)
at sun.nio.ch.SocketChannelImpl.write(SocketChannelImpl.java:471)
at 
org.apache.geode.internal.cache.tier.sockets.Message.flushBuffer(Message.java:651)
at 
org.apache.geode.internal.cache.tier.sockets.Message.sendBytes(Message.java:632)
at 
org.apache.geode.internal.cache.tier.sockets.ChunkedMessage.sendChunk(ChunkedMessage.java:314)
at 
org.apache.geode.internal.cache.tier.sockets.ChunkedMessage.sendChunk(ChunkedMessage.java:322)
at 
org.apache.geode.internal.cache.tier.sockets.BaseCommand.writeQueryResponseChunk(BaseCommand.java:756)
at 
org.apache.geode.internal.cache.tier.sockets.BaseCommandQuery.processQueryUsingParams(BaseCommandQuery.java:225)
at 
org.apache.geode.internal.cache.tier.sockets.BaseCommandQuery.processQuery(BaseCommandQuery.java:70)
at 
org.apache.geode.internal.cache.tier.sockets.command.ExecuteCQ61.cmdExecute(ExecuteCQ61.java:179)
at 
org.apache.geode.internal.cache.tier.sockets.BaseCommand.execute(BaseCommand.java:147)
at 
org.apache.geode.internal.cache.tier.sockets.ServerConnection.doNormalMsg(ServerConnection.java:783)
at 
org.apache.geode.internal.cache.tier.sockets.ServerConnection.doOneMessage(ServerConnection.java:913)
at 
org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1143)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at 
org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:546)
at java.lang.Thread.run(Thread.java:745)

could it be the client disconnected from the node right after sending this 
message? (The client itself continues to run normally...)
The scenario is that after all nodes are initialized, I am stopping one server 
out of 2. Sometimes, 1 out of 5 - the CQ stops notifying the client after this 
stop. Most if the time the CQ continues to run fine.
I am certain this is related to some timing issue, some registration which 
fails, something also related to the filter profiles which is held in the 
region...

Thanks

Roi

-Original Message-
From: Anilkumar Gingade [mailto:aging...@pivotal.io] 
Sent: Wednesday, August 16, 2017 1:41 AM
To: dev@geode.apache.org
Subject: Re: continuous query internal mechanism questions

In Geode, high availability for subscription events are achieved by having 
redundant event-queues (HAQueues) on multiple severs; this is configured using 
redundancy-level with client connection. Based on the redundancy level, the 
client register CQs on multiple servers. During the subscription
(CQ) registration, it elects/assigns one of the server to host primary HAQueue.

The client keeps monitoring the redundancy level during node join or failure; 
to satisfy the redundancy level.

You can find more about HAQueues at
https://cwiki.apache.org/confluence/display/GEODE/HA+Client+Event+Queues

I assume, you have 2 node cluster. What is your subscription redundancy level?

>> For some reason, sometimes there is a failure to complete the first
registration
Is there any log message, stack trace, reporting reason for failure? If its dev 
environment, you can run client/server with debug/fine level log to see 
additional info.

Are you trying to stop your server, while registering the CQs? Can you give 
more detail about your test scenario...

-Anil.


On Tue, Aug 15, 2017 at 11:25 AM, Jason Huynh  wrote:

> I am not quite sure how native client registers cqs. From my understanding:
> with the java api, I believe there is only one message (ExecuteCQ 
> message) that is executed on the server side and then replicated to 
> the other nodes through the profile (OperationMessage).
>
> It seems the extra ExecuteCQ message failing and then closing the cq 
> might be putting the system in a weird state...
>
> On Tue, Aug 15, 2017 at 7:56 AM Roi Apelker 
> wrote:
>
> > Hi,
> >
> > I have been examining the continuous query registration mechanism 
> > for quite some time This is related to an issue that I have, where 
> > sometimes a node crashes
> (1
> > node out of 2), and the other one does not send CQ events. The CQ is 
> > registered on a partitioned region which resides on these 2 nodes.
> >
> >

[GitHub] geode pull request #702: GEODE-3416: Reduce synchronization blockages in Soc...

2017-08-16 Thread hiteshk25 
Github user hiteshk25 commented on a diff in the pull request:

https://github.com/apache/geode/pull/702#discussion_r133506959
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/internal/net/SocketCloser.java ---
@@ -96,46 +99,55 @@ public int getMaxThreads() {
 return this.asyncClosePoolMaxThreads;
   }
 
-  private ThreadPoolExecutor getAsyncThreadExecutor(String address) {
-synchronized (asyncCloseExecutors) {
-  ThreadPoolExecutor pool = asyncCloseExecutors.get(address);
-  if (pool == null) {
-final ThreadGroup tg = 
LoggingThreadGroup.createThreadGroup("Socket asyncClose", logger);
-ThreadFactory tf = new ThreadFactory() {
-  public Thread newThread(final Runnable command) {
-Thread thread = new Thread(tg, command);
-thread.setDaemon(true);
-return thread;
-  }
-};
-BlockingQueue workQueue = new 
LinkedBlockingQueue();
-pool = new ThreadPoolExecutor(this.asyncClosePoolMaxThreads, 
this.asyncClosePoolMaxThreads,
-this.asyncClosePoolKeepAliveSeconds, TimeUnit.SECONDS, 
workQueue, tf);
-pool.allowCoreThreadTimeOut(true);
-asyncCloseExecutors.put(address, pool);
+  private ExecutorService getAsyncThreadExecutor(String address) {
+ExecutorService executorService = asyncCloseExecutors.get(address);
+if (executorService == null) {
+  // To be used for pre-1.8 jdk releases.
+  // createThreadPool();
+
+  executorService = 
Executors.newWorkStealingPool(asyncClosePoolMaxThreads);
+
+  ExecutorService previousThreadPoolExecutor =
+  asyncCloseExecutors.putIfAbsent(address, executorService);
+
+  if (previousThreadPoolExecutor != null) {
+executorService.shutdownNow();
+return previousThreadPoolExecutor;
   }
-  return pool;
 }
+return executorService;
+  }
+
+  /**
+   * @deprecated this method is to be used for pre 1.8 jdk.
+   */
+  @Deprecated
+  private void createThreadPool() {
+ExecutorService executorService;
+final ThreadGroup threadGroup =
+LoggingThreadGroup.createThreadGroup("Socket asyncClose", logger);
+ThreadFactory threadFactory = new ThreadFactory() {
+  public Thread newThread(final Runnable command) {
+Thread thread = new Thread(threadGroup, command);
+thread.setDaemon(true);
+return thread;
+  }
+};
+
+executorService = new ThreadPoolExecutor(asyncClosePoolMaxThreads, 
asyncClosePoolMaxThreads,
+asyncCloseWaitTime, asyncCloseWaitUnits, new 
LinkedBlockingQueue<>(), threadFactory);
   }
 
   /**
* Call this method if you know all the resources in the closer for the 
given address are no
* longer needed. Currently a thread pool is kept for each address and 
if you know that an address
* no longer needs its pool then you should call this method.
*/
-  public void releaseResourcesForAddress(String address) {
-synchronized (asyncCloseExecutors) {
-  ThreadPoolExecutor pool = asyncCloseExecutors.get(address);
-  if (pool != null) {
-pool.shutdown();
-asyncCloseExecutors.remove(address);
-  }
-}
-  }
 
-  private boolean isClosed() {
-synchronized (asyncCloseExecutors) {
-  return this.closed;
+  public void releaseResourcesForAddress(String address) {
+ExecutorService executorService = asyncCloseExecutors.remove(address);
+if (executorService != null) {
+  executorService.shutdown();
--- End diff --

Thanks Bruce. So we close socket closer after closing all the connections? 
So we just have a executor in sync(but socket close always happens in another 
thread).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 61627: GEODE-3437: Fix list and describe region tests

2017-08-16 Thread Jared Stewart 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61627/
---

(Updated Aug. 16, 2017, 5:24 p.m.)


Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
Patrick Rhomberg.


Changes
---

Safe copy of Properties before we add to it


Repository: geode


Description
---

GEODE-3437: Fix list and describe region tests


Diffs (updated)
-

  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ListAndDescribeRegionDUnitTest.java
 ab8c69b 
  
geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java
 fc7966f 


Diff: https://reviews.apache.org/r/61627/diff/2/

Changes: https://reviews.apache.org/r/61627/diff/1-2/


Testing
---

Precheckin running


Thanks,

Jared Stewart

Re: Review Request 61627: GEODE-3437: Fix list and describe region tests

2017-08-16 Thread Ken Howe 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61627/#review183042
---


Ship it!




Ship It!

- Ken Howe


On Aug. 16, 2017, 5:24 p.m., Jared Stewart wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61627/
> ---
> 
> (Updated Aug. 16, 2017, 5:24 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-3437: Fix list and describe region tests
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ListAndDescribeRegionDUnitTest.java
>  ab8c69b 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java
>  fc7966f 
> 
> 
> Diff: https://reviews.apache.org/r/61627/diff/2/
> 
> 
> Testing
> ---
> 
> Precheckin running
> 
> 
> Thanks,
> 
> Jared Stewart
> 
>

RE: continuous query internal mechanism questions

2017-08-16 Thread Roi Apelker 
It seems like the code in the native client (in the version I have, which may 
be old) send the message to all servers:

CqResultsPtr CqQueryImpl::executeWithInitialResults(uint32_t timeout)
{
  ...

  TcrMessage msg(TcrMessage::EXECUTECQ_WITH_IR_MSG_TYPE, m_cqName, 
m_queryString, CqState::RUNNING, isDurable(), m_tccdm);
  TcrMessage reply(true, m_tccdm);
  ChunkedQueryResponse* resultCollector = (new ChunkedQueryResponse(reply));
  reply.setChunkedResultHandler(static_cast(resultCollector));
  reply.setTimeout(timeout);

  GfErrType err = GF_NOERR;
  err = m_tccdm->sendSyncRequest(msg, reply);
..

And sendSyncRequest:
...

for (std::vector::iterator ep = m_endpoints.begin(); ep != 
m_endpoints.end(); ++ep) {
if ((*ep)->connected()) {
  (*ep)->setDM(this);
  opErr = sendRequestToEP(request, reply, *ep);//this will go to 
ThinClientDistributionManager

...


Can this be causing the issue?



-Roi





-Original Message-
From: Jason Huynh [mailto:jasonhu...@apache.org] 
Sent: Tuesday, August 15, 2017 9:25 PM
To: dev@geode.apache.org
Subject: Re: continuous query internal mechanism questions

I am not quite sure how native client registers cqs. From my understanding:
with the java api, I believe there is only one message (ExecuteCQ message) that 
is executed on the server side and then replicated to the other nodes through 
the profile (OperationMessage).

It seems the extra ExecuteCQ message failing and then closing the cq might be 
putting the system in a weird state...

On Tue, Aug 15, 2017 at 7:56 AM Roi Apelker  wrote:

> Hi,
>
> I have been examining the continuous query registration mechanism for 
> quite some time This is related to an issue that I have, where 
> sometimes a node crashes (1 node out of 2), and the other one does not 
> send CQ events. The CQ is registered on a partitioned region which 
> resides on these 2 nodes.
>
> I noticed the following behavior, and I wonder if anyone can comment 
> regarding it, if it is justified or not and what is the reason:
>
> 1. When the software using the client (native client) registers for 
> the CQ, a CQ command (ExecuteCQ61) is received on both servers.
>  -- is this normal behaviour? Does the client actually send this 
> command to both servers?
>
> 2. When this command is received by a server, and the CQ is 
> registered, another registration message is sent to the other node via 
> an OperationMessage (REGISTER_CQ)
>  -- it seems that regularly, the server can handle this situation as 
> the second registration identifies the previous one and does not 
> affect it. but the question, why do we need this 2nd registration, if 
> there is a command sent to each server?
>
> 3. For some reason, sometimes there is a failure to complete the first 
> registration (executed by ExecuteCQ61) and then this failure causes a 
> closure to the CQ, which is accompanied with a close request to the 
> other node.
>  -- I assume by now, since 2 registrations and one closure have 
> occurred on node 2, the CQ is still active and the client receives 
> notifications.
>
> 4. Sometimes, 1 out of 5, once node 1 crashes, I get a cleanup 
> operation, caused by the crash (via MemberCrashedEvent), and this also 
> closes the existing CQ, and in this case the CQ in node 2 does not 
> operate anymore and the client receives no notifications.
>  -- fact is, that 4 out of 4 times, I do not get this cleanup by 
> MemberCrashedEvent (maybe due to some other error), and that the CQ 
> notifications are received normally.
>
> Can anyone clear things up for me? Any comment on any of the 
> statements above will be greatly appreciated.
>
> Thanks,
>
> Roi
>
>
> -Original Message-
> From: Roi Apelker
> Sent: Wednesday, August 09, 2017 3:21 PM
> To: dev@geode.apache.org
> Subject: RE: continuous query internal mechanism
>
> Dhanyavad
>
> -Original Message-
> From: Anilkumar Gingade [mailto:aging...@pivotal.io]
> Sent: Tuesday, August 08, 2017 9:55 PM
> To: dev@geode.apache.org
> Subject: Re: continuous query internal mechanism
>
> Registered events, i meant, are events generated for interest 
> registration "region.registerInterest(*)". And CqEvents are for CQs 
> registered.
>
> -Anil.
>
>
> On Tue, Aug 8, 2017 at 12:27 AM, Roi Apelker 
> wrote:
>
> > Shukriya
> >
> > What is the difference between registered events and CQ events?
> >
> > -Original Message-
> > From: Anilkumar Gingade [mailto:aging...@pivotal.io]
> > Sent: Monday, August 07, 2017 10:12 PM
> > To: dev@geode.apache.org
> > Subject: Re: continuous query internal mechanism
> >
> > CQ Processing on server side is same for all clients (Java, C++)...
> >
> > The subscription events are sent to client as ClientUpdateMessage, 
> > which holds information about registered events and CQ events. The 
> > client process this and updates/invokes the client side 
> > cache/listeners with respective event. Look into 
> > ClientUpdateMessageImpl and CacheClientUpdater (for client

Review Request 61694: GEODE-3235: Deploy jar registers functions which extend FunctionAdapter

2017-08-16 Thread Jared Stewart 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61694/
---

Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
Patrick Rhomberg.


Repository: geode


Description
---

GEODE-3235: Deploy jar registers functions which extend FunctionAdapter
- Extract FunctionScanner class
- Add scanning for FunctionAdapter in addition to Function
- Add test to expose GEODE-3429


Diffs
-

  geode-core/src/main/java/org/apache/geode/internal/DeployedJar.java 
037ef9ee96f6a01927c6b2c429f186e4eab285be 
  
geode-core/src/main/java/org/apache/geode/management/internal/deployment/FunctionScanner.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DeployCommandFunctionRegistrationDUnitTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/management/internal/deployment/FunctionScannerTest.java
 PRE-CREATION 
  
geode-core/src/test/resources/org/apache/geode/management/internal/deployment/AbstractExtendsFunctionAdapter.java
 PRE-CREATION 
  
geode-core/src/test/resources/org/apache/geode/management/internal/deployment/AbstractImplementsFunction.java
 PRE-CREATION 
  
geode-core/src/test/resources/org/apache/geode/management/internal/deployment/AnnotatedFunction.java
 PRE-CREATION 
  
geode-core/src/test/resources/org/apache/geode/management/internal/deployment/ConcreteExtendsAbstractExtendsFunctionAdapter.java
 PRE-CREATION 
  
geode-core/src/test/resources/org/apache/geode/management/internal/deployment/ConcreteExtendsAbstractImplementsFunction.java
 PRE-CREATION 
  
geode-core/src/test/resources/org/apache/geode/management/internal/deployment/ExtendsAbstractFunction.java
 PRE-CREATION 
  
geode-core/src/test/resources/org/apache/geode/management/internal/deployment/ExtendsFunctionAdapter.java
 PRE-CREATION 
  
geode-core/src/test/resources/org/apache/geode/management/internal/deployment/ImplementsFunction.java
 PRE-CREATION 
  geode-junit/src/main/java/org/apache/geode/test/compiler/JarBuilder.java 
beea476d6a587bc0dcc434a03ea8b6beb53b449e 
  geode-junit/src/main/java/org/apache/geode/test/compiler/JavaCompiler.java 
844960522726981fd3895caf336aef27de462485 


Diff: https://reviews.apache.org/r/61694/diff/1/


Testing
---

precheckin running


Thanks,

Jared Stewart

Re: Review Request 61627: GEODE-3437: Fix list and describe region tests

2017-08-16 Thread Patrick Rhomberg 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61627/#review183046
---


Ship it!




Ship It!

- Patrick Rhomberg


On Aug. 16, 2017, 5:24 p.m., Jared Stewart wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61627/
> ---
> 
> (Updated Aug. 16, 2017, 5:24 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-3437: Fix list and describe region tests
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ListAndDescribeRegionDUnitTest.java
>  ab8c69b 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java
>  fc7966f 
> 
> 
> Diff: https://reviews.apache.org/r/61627/diff/2/
> 
> 
> Testing
> ---
> 
> Precheckin running
> 
> 
> Thanks,
> 
> Jared Stewart
> 
>

Re: Review Request 61694: GEODE-3235: Deploy jar registers functions which extend FunctionAdapter

2017-08-16 Thread Patrick Rhomberg 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61694/#review183048
---



It looks like FunctionAdapter has bee deprecated for around a year and a half 
(since 2016-04-27: `15a2a29d996c60831ec67bb8f565660950e67a29`).  Would it be 
better to just put it on the chopping block rather than to go to all this 
effort to distinguish `implements Function` vs `extends FunctionAdapter`?

- Patrick Rhomberg


On Aug. 16, 2017, 6:12 p.m., Jared Stewart wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61694/
> ---
> 
> (Updated Aug. 16, 2017, 6:12 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-3235: Deploy jar registers functions which extend FunctionAdapter
> - Extract FunctionScanner class
> - Add scanning for FunctionAdapter in addition to Function
> - Add test to expose GEODE-3429
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/internal/DeployedJar.java 
> 037ef9ee96f6a01927c6b2c429f186e4eab285be 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/deployment/FunctionScanner.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DeployCommandFunctionRegistrationDUnitTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/deployment/FunctionScannerTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/resources/org/apache/geode/management/internal/deployment/AbstractExtendsFunctionAdapter.java
>  PRE-CREATION 
>   
> geode-core/src/test/resources/org/apache/geode/management/internal/deployment/AbstractImplementsFunction.java
>  PRE-CREATION 
>   
> geode-core/src/test/resources/org/apache/geode/management/internal/deployment/AnnotatedFunction.java
>  PRE-CREATION 
>   
> geode-core/src/test/resources/org/apache/geode/management/internal/deployment/ConcreteExtendsAbstractExtendsFunctionAdapter.java
>  PRE-CREATION 
>   
> geode-core/src/test/resources/org/apache/geode/management/internal/deployment/ConcreteExtendsAbstractImplementsFunction.java
>  PRE-CREATION 
>   
> geode-core/src/test/resources/org/apache/geode/management/internal/deployment/ExtendsAbstractFunction.java
>  PRE-CREATION 
>   
> geode-core/src/test/resources/org/apache/geode/management/internal/deployment/ExtendsFunctionAdapter.java
>  PRE-CREATION 
>   
> geode-core/src/test/resources/org/apache/geode/management/internal/deployment/ImplementsFunction.java
>  PRE-CREATION 
>   geode-junit/src/main/java/org/apache/geode/test/compiler/JarBuilder.java 
> beea476d6a587bc0dcc434a03ea8b6beb53b449e 
>   geode-junit/src/main/java/org/apache/geode/test/compiler/JavaCompiler.java 
> 844960522726981fd3895caf336aef27de462485 
> 
> 
> Diff: https://reviews.apache.org/r/61694/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin running
> 
> 
> Thanks,
> 
> Jared Stewart
> 
>

Re: Review Request 61694: GEODE-3235: Deploy jar registers functions which extend FunctionAdapter

2017-08-16 Thread Patrick Rhomberg 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61694/#review183049
---




geode-core/src/main/java/org/apache/geode/internal/DeployedJar.java
Lines 19-54 (original), 17-52 (patched)


A few imports need reordering.

```
geode-core/src/main/java/org/apache/geode/internal/DeployedJar.java

geode-core/src/main/java/org/apache/geode/management/internal/deployment/FunctionScanner.java

geode-core/src/test/resources/org/apache/geode/management/internal/deployment/AbstractImplementsFunction.java

geode-core/src/test/resources/org/apache/geode/management/internal/deployment/AnnotatedFunction.java
```


- Patrick Rhomberg


On Aug. 16, 2017, 6:12 p.m., Jared Stewart wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61694/
> ---
> 
> (Updated Aug. 16, 2017, 6:12 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-3235: Deploy jar registers functions which extend FunctionAdapter
> - Extract FunctionScanner class
> - Add scanning for FunctionAdapter in addition to Function
> - Add test to expose GEODE-3429
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/internal/DeployedJar.java 
> 037ef9ee96f6a01927c6b2c429f186e4eab285be 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/deployment/FunctionScanner.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DeployCommandFunctionRegistrationDUnitTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/deployment/FunctionScannerTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/resources/org/apache/geode/management/internal/deployment/AbstractExtendsFunctionAdapter.java
>  PRE-CREATION 
>   
> geode-core/src/test/resources/org/apache/geode/management/internal/deployment/AbstractImplementsFunction.java
>  PRE-CREATION 
>   
> geode-core/src/test/resources/org/apache/geode/management/internal/deployment/AnnotatedFunction.java
>  PRE-CREATION 
>   
> geode-core/src/test/resources/org/apache/geode/management/internal/deployment/ConcreteExtendsAbstractExtendsFunctionAdapter.java
>  PRE-CREATION 
>   
> geode-core/src/test/resources/org/apache/geode/management/internal/deployment/ConcreteExtendsAbstractImplementsFunction.java
>  PRE-CREATION 
>   
> geode-core/src/test/resources/org/apache/geode/management/internal/deployment/ExtendsAbstractFunction.java
>  PRE-CREATION 
>   
> geode-core/src/test/resources/org/apache/geode/management/internal/deployment/ExtendsFunctionAdapter.java
>  PRE-CREATION 
>   
> geode-core/src/test/resources/org/apache/geode/management/internal/deployment/ImplementsFunction.java
>  PRE-CREATION 
>   geode-junit/src/main/java/org/apache/geode/test/compiler/JarBuilder.java 
> beea476d6a587bc0dcc434a03ea8b6beb53b449e 
>   geode-junit/src/main/java/org/apache/geode/test/compiler/JavaCompiler.java 
> 844960522726981fd3895caf336aef27de462485 
> 
> 
> Diff: https://reviews.apache.org/r/61694/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin running
> 
> 
> Thanks,
> 
> Jared Stewart
> 
>

Re: Review Request 61627: GEODE-3437: Fix list and describe region tests

2017-08-16 Thread Jared Stewart 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61627/
---

(Updated Aug. 16, 2017, 8:44 p.m.)


Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
Patrick Rhomberg.


Changes
---

Safe copy for locator props as well as server props


Repository: geode


Description
---

GEODE-3437: Fix list and describe region tests


Diffs (updated)
-

  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ListAndDescribeRegionDUnitTest.java
 ab8c69b 
  
geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java
 fc7966f 


Diff: https://reviews.apache.org/r/61627/diff/3/

Changes: https://reviews.apache.org/r/61627/diff/2-3/


Testing
---

Precheckin running


Thanks,

Jared Stewart

Review Request 61701: GEODE-3277: Fix error path constructors of Launcher inner State classess

2017-08-16 Thread Ken Howe 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61701/
---

Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Kirk Lund, and 
Patrick Rhomberg.


Repository: geode


Description
---

Updated tests for changes in the error constructors for ServerState and
LocatorState.

Minor spelling corrections.

I've updated the fix for GEODE-3277 and rebased on top of the @klund's recent 
process controller updates


Diffs
-

  
geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StatusLocatorRealGfshTest.java
 3a98373938e3de21da6badcf460dae3648218ac6 
  geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java 
83c1ab533e3dea323a8a99f7002b9464a54dfc25 
  geode-core/src/main/java/org/apache/geode/distributed/ServerLauncher.java 
ae64691605130c9b212a3a33bb65ae37b28af02b 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/lifecycle/GfshStatusCommandsIntegrationTest.java
 dd5841f4cffca38da07a11f381cf4174d7264349 
  
geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java
 e7f17ef208a1708f385c7c4041affb70fd309a4c 


Diff: https://reviews.apache.org/r/61701/diff/1/


Testing
---

Precheckin is in progress.


Thanks,

Ken Howe

[GitHub] geode pull request #715: GEODE-3169: Decoupling of DiskStore and backups

2017-08-16 Thread nreich 
GitHub user nreich opened a pull request:

https://github.com/apache/geode/pull/715

GEODE-3169: Decoupling of DiskStore and backups

  * move backup logic away from DiskStore and into BackupManager
  * refactor code into smaller methods
  * improve test code clarity

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nreich/geode feature/GEODE-3169

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/715.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #715


commit 9a1a6e03576e69916f6ec8efc3393fd941eb1603
Author: Nick Reich 
Date:   2017-08-08T18:30:17Z

GEODE-3169: Decoupling of DiskStore and backups

  * move backup logic away from DiskStore and into BackupManager
  * refactor code into smaller methods
  * improve test code clarity




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #649 was SUCCESSFUL (with 2027 tests)

2017-08-16 Thread Spring CI 

---
Spring Data GemFire > Nightly-ApacheGeode > #649 was successful.
---
Scheduled
2029 tests in total.

https://build.spring.io/browse/SGF-NAG-649/





--
This message is automatically generated by Atlassian Bamboo

Re: Review Request 61676: Release the lock held when beforeCompletion failed with CommitConflictException

2017-08-16 Thread anilkumar gingade 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61676/#review183078
---




geode-core/src/main/java/org/apache/geode/internal/cache/TXState.java
Line 1013 (original), 1013 (patched)


We can remove this cleanup, right?



geode-core/src/main/java/org/apache/geode/internal/cache/TXState.java
Line 1024 (original), 1024 (patched)


And remove this one too...


- anilkumar gingade


On Aug. 15, 2017, 10:47 p.m., Eric Shu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61676/
> ---
> 
> (Updated Aug. 15, 2017, 10:47 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Darrel Schneider, Lynn Gallinat, 
> and Nick Reich.
> 
> 
> Bugs: GEODE-3444
> https://issues.apache.org/jira/browse/GEODE-3444
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> When JTA transaction failed with exception, it is better to release the locks 
> it held right away.
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/internal/cache/TXState.java 
> 55415e3 
> 
> 
> Diff: https://reviews.apache.org/r/61676/diff/1/
> 
> 
> Testing
> ---
> 
> Precheckin.
> 
> 
> Thanks,
> 
> Eric Shu
> 
>

Re: How to export region keys in json file

2017-08-16 Thread Barry Oglesby 
There isn't anything built in to export keys as JSON. There was some talk
about exporting values as JSON at one time, but that hasn't been done.

I attached a function to dump the keys as JSON. It just logs them to the
terminal, but it can easily be changed to write them to a file.

It dumps output like:

Region data contains the following 34 keys:
{"customerID":"28","customerGroup":"group-28","cycleCode":"cycleCode-28","partitionID":28}
{"customerID":"21","customerGroup":"group-21","cycleCode":"cycleCode-21","partitionID":21}
{"customerID":"68","customerGroup":"group-68","cycleCode":"cycleCode-68","partitionID":68}
{"customerID":"81","customerGroup":"group-81","cycleCode":"cycleCode-81","partitionID":81}
{"customerID":"35","customerGroup":"group-35","cycleCode":"cycleCode-35","partitionID":35}
{"customerID":"90","customerGroup":"group-90","cycleCode":"cycleCode-90","partitionID":90}
{"customerID":"15","customerGroup":"group-15","cycleCode":"cycleCode-15","partitionID":15}
{"customerID":"44","customerGroup":"group-44","cycleCode":"cycleCode-44","partitionID":44}


Thanks,
Barry Oglesby


On Wed, Aug 16, 2017 at 4:35 AM, Dinesh Akhand  wrote:

> Hi,
>
> How I can export Region keys in json file.
>
> It will help full for us to use get command or remove command for
> particular key when we have the composite keys defined.
>
> get --region=/CUSTOMER_1 --key=({'customerID':'1593','
> customerGroup':'30013','cycleCode':'1','partitionID':'300133'})
> --key-class=amdocs.imdg.model.keys.CustomerKey
> Message : Error in converting JSON Couldn't convert JSON to Object of type
> class amdocs.imdg.model.keys.CustomerKey
>
>
> Thanks,
> Dinesh Akhand
> This message and the information contained herein is proprietary and
> confidential and subject to the Amdocs policy statement,
>
> you may review at https://www.amdocs.com/about/email-disclaimer <
> https://www.amdocs.com/about/email-disclaimer>
>

Re: Review Request 61676: Release the lock held when beforeCompletion failed with CommitConflictException

2017-08-16 Thread Nick Reich 


> On Aug. 16, 2017, 10:47 p.m., anilkumar gingade wrote:
> > geode-core/src/main/java/org/apache/geode/internal/cache/TXState.java
> > Line 1024 (original), 1024 (patched)
> > 
> >
> > And remove this one too...

Yes, in both cases the wrapped exception thrown is getting caught by that outer 
catch block.


- Nick


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61676/#review183078
---


On Aug. 15, 2017, 10:47 p.m., Eric Shu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61676/
> ---
> 
> (Updated Aug. 15, 2017, 10:47 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Darrel Schneider, Lynn Gallinat, 
> and Nick Reich.
> 
> 
> Bugs: GEODE-3444
> https://issues.apache.org/jira/browse/GEODE-3444
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> When JTA transaction failed with exception, it is better to release the locks 
> it held right away.
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/internal/cache/TXState.java 
> 55415e3 
> 
> 
> Diff: https://reviews.apache.org/r/61676/diff/1/
> 
> 
> Testing
> ---
> 
> Precheckin.
> 
> 
> Thanks,
> 
> Eric Shu
> 
>

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-16 Thread pivotal-amurmann 
GitHub user pivotal-amurmann opened a pull request:

https://github.com/apache/geode/pull/716

GEODE-3406: Locator accepts Protobuf requests

Also addresses GEODE-3400, GEODE-3399
This allows the locator to respond to Protobuf requests. Currently it
will only be able to respond to getAvailableServers.

To enable this we are introducing a new value of "0" that will be sent
in place of the Gossip version. After it we expect the same magic byte
("110") as in AcceptorImpl.

This also is gated by the `geode.feature-protobuf-protocol` system
property.

The getAvailableServers request handler now uses the locator directly,
since we are on the locator.

Signed-off-by: Brian Rowe 

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [✔️ ] Is there a JIRA ticket associated with this PR? Is it 
referenced in the commit message?
GEODE-3400, GEODE-3399, GEODE-3406

- [✔️ ] Has your PR been rebased against the latest commit within the 
target branch (typically `develop`)?

- [✔️] Is your initial contribution a single, squashed commit?

- [✔️] Does `gradlew build` run cleanly?

- [✔️] Have you written or updated unit tests to verify your changes?

- [x] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
N/A

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.

@kohlmu-pivotal @bschuchardt @galen-pivotal @WireBaron @hiteshk25 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pivotal-amurmann/geode 
feature/GEODE-3400/locator_support_protobuf

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/716.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #716


commit a1d10ffdc6eda365eafa11d055cbce5096abcec2
Author: Alexander Murmann 
Date:   2017-08-14T22:08:14Z

GEODE-3406: Locator accepts Protobuf requests

Also addresses GEODE-3400, GEODE-3399
This allows the locator to respond to Protobuf requests. Currently it
will only be able to respond to getAvailableServers.

To enable this we are introducing a new value of "0" that will be sent
in place of the Gossip version. After it we expect the same magic byte
("110") as in AcceptorImpl.

This also is gated by the `geode.feature-protobuf-protocol` system
property.

The getAvailableServers request handler now uses the locator directly,
since we are on the locator.

Signed-off-by: Brian Rowe 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 61672: GEODE-3249: internal messages should require credentials

2017-08-16 Thread Brian Rowe 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61672/#review183089
---


Fix it, then Ship it!





geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java
Lines 1059 (patched)


Is this intended to be new logging or was it just for debugging?



geode-core/src/test/java/org/apache/geode/security/ClientAuthenticationPart2DUnitTest.java
Lines 62 (patched)


Does this call do anything? serverConnection is a mock and you haven't told 
it how to handle this call.


- Brian Rowe


On Aug. 15, 2017, 8:46 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61672/
> ---
> 
> (Updated Aug. 15, 2017, 8:46 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Galen O'Sullivan, Hitesh 
> Khamesra, Udo Kohlmeyer, and Brian Rowe.
> 
> 
> Bugs: GEODE-3249
> https://issues.apache.org/jira/browse/GEODE-3249
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Internal messages that could alter server state now require security 
> credentials.
> 
> This was merely a matter of changing the server to require the credentials 
> and changing the client to send credentials.  I removed the general 
> overriding of AbstractOp.processSecureBytes() because it made no sense.  If 
> the server sends a secure byte "part" in a message the client is obligated to 
> process it or the next message it sends will cause a security violation.
> 
> I've added a server-side property that folks can set to allow old clients to 
> continue to work.  This must be used to roll the servers forward to the new 
> version that contains this change.  Clients must then be rolled forward & the 
> servers can then be rolled once again without the property set.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/cache/client/internal/AbstractOp.java
>  c4035f9cf5db1c031e35eef4be0908afbddefffb 
>   
> geode-core/src/main/java/org/apache/geode/cache/client/internal/AddPDXEnumOp.java
>  ca7790aca5cab703c2180f85f01e37c91fa3c956 
>   
> geode-core/src/main/java/org/apache/geode/cache/client/internal/AddPDXTypeOp.java
>  88c85514c891d19399257bb2d85cb463b92ed6bb 
>   
> geode-core/src/main/java/org/apache/geode/cache/client/internal/CloseConnectionOp.java
>  ffcdc39c3ba05e90bf7b9c49509b72de70451f85 
>   
> geode-core/src/main/java/org/apache/geode/cache/client/internal/CommitOp.java 
> edffb2b18bde31435c9555b13c3e630aee1e4027 
>   
> geode-core/src/main/java/org/apache/geode/cache/client/internal/GetClientPRMetaDataOp.java
>  2ba3e3a9a8044fcd7d991fd444fcaf75b2a5c2f4 
>   
> geode-core/src/main/java/org/apache/geode/cache/client/internal/GetClientPartitionAttributesOp.java
>  49567dd31d9f617162768b5066bbb5307785a85f 
>   
> geode-core/src/main/java/org/apache/geode/cache/client/internal/GetEventValueOp.java
>  3fb5fcfa497264d5e0a14d95ed0935f392216680 
>   
> geode-core/src/main/java/org/apache/geode/cache/client/internal/GetFunctionAttributeOp.java
>  c7edbfea719e75291287824c3654c0e7fac3e7bb 
>   
> geode-core/src/main/java/org/apache/geode/cache/client/internal/GetPDXEnumByIdOp.java
>  7bbf74056f6ecfb7efe27c575029281b98d01b47 
>   
> geode-core/src/main/java/org/apache/geode/cache/client/internal/GetPDXEnumsOp.java
>  be4c092298df497f6c145b26d8b87234d59c6be8 
>   
> geode-core/src/main/java/org/apache/geode/cache/client/internal/GetPDXIdForEnumOp.java
>  d87371c6778e9a9ea44c956dbef9e169338c7930 
>   
> geode-core/src/main/java/org/apache/geode/cache/client/internal/GetPDXIdForTypeOp.java
>  27f600e3e5e2803cfd2f1c312036b57f61a12751 
>   
> geode-core/src/main/java/org/apache/geode/cache/client/internal/GetPDXTypeByIdOp.java
>  bee50b5f02c2d891f8c450ce1dc799757a39453f 
>   
> geode-core/src/main/java/org/apache/geode/cache/client/internal/GetPDXTypesOp.java
>  5256924e94fd533dc27c8eb28073a4e68bd68174 
>   
> geode-core/src/main/java/org/apache/geode/cache/client/internal/MakePrimaryOp.java
>  e1d3d5030bb2b31f6471cfc14f147d7780357dc1 
>   geode-core/src/main/java/org/apache/geode/cache/client/internal/PingOp.java 
> 2e5254226c3ef461e93033bb623dfca31cdce1c5 
>   
> geode-core/src/main/java/org/apache/geode/cache/client/internal/PrimaryAckOp.java
>  e380e99e00815d3d56763d429dfc8ad51c3f4113 
>   geode-core/src/main/java/org/apache/geode/cache/client/internal/PutOp.java 
> 447ed382cda810c99f3400ba862db9537794a01b 
>   
> geode-core/src/main/java/org/apache/geode/cache/client/internal/ReadyForEventsOp.java
>  f6d0ccb5a9892e38d83b7fafc831fef6f1f14bb7 
>   
> geode-core/src/main/java/org/apache/geode/cache/client/internal/RegisterDataSerializersOp.ja

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-16 Thread WireBaron 
Github user WireBaron commented on a diff in the pull request:

https://github.com/apache/geode/pull/716#discussion_r133599146
  
--- Diff: 
geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetAvailableServersOperationHandlerJUnitTest.java
 ---
@@ -32,75 +30,48 @@
 import org.junit.Test;
 import org.junit.experimental.categories.Category;
 
-import java.io.IOException;
 import java.util.ArrayList;
-import java.util.Properties;
 
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertTrue;
 import static org.mockito.ArgumentMatchers.any;
-import static org.mockito.ArgumentMatchers.anyBoolean;
-import static org.mockito.ArgumentMatchers.anyInt;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.when;
 
 @Category(UnitTest.class)
 public class GetAvailableServersOperationHandlerJUnitTest extends 
OperationHandlerJUnitTest {
--- End diff --

Are we getting anything of value from the OperationHandlerJUnitTest now 
that we're using a locator instead of a cache?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-16 Thread WireBaron 
Github user WireBaron commented on a diff in the pull request:

https://github.com/apache/geode/pull/716#discussion_r133596604
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java ---
@@ -76,7 +76,9 @@
  */
 public interface InternalCache extends Cache, Extensible, CacheTime 
{
 
-  InternalDistributedMember getMyId();
+  default InternalDistributedMember getMyId() {
--- End diff --

I don't remember why this got done, is it still necessary?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-16 Thread WireBaron 
Github user WireBaron commented on a diff in the pull request:

https://github.com/apache/geode/pull/716#discussion_r133597935
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ExecutionContext.java
 ---
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+
+package org.apache.geode.internal.cache.tier.sockets;
+
+import org.apache.geode.cache.Cache;
+import org.apache.geode.distributed.internal.InternalLocator;
+
+public class ExecutionContext {
+  private Cache cache;
+  private InternalLocator locator;
+
+  public ExecutionContext(Cache cache) {
+this.cache = cache;
+  }
+
+  public ExecutionContext(InternalLocator locator) {
+this.locator = locator;
+  }
+
+  // This throws if the cache isn't present because we know that non of 
the callers can take any
+  // reasonable action if the cache is not present
+  public Cache getCache() throws InvalidExecutionContextException {
+if (cache != null) {
+  return cache;
+} else {
+  throw new InvalidExecutionContextException(
+  "Execution context's cache was accessed but isn't present. Did 
this happen on a locator? Operations on the locator should not try to operate 
on a cache");
+}
+  }
+
+  // This throws if the locator isn't present because we know that non of 
the callers can take any
+  // reasonable action if the locator is not present
+  public InternalLocator getLocator() throws 
InvalidExecutionContextException {
+if (locator != null) {
+  return locator;
+} else {
+  throw new InvalidExecutionContextException(
+  "Execution context's locator was accessed but isn't present. Did 
this happen on a server? Operations on the locator should not try to operate on 
a cache");
--- End diff --

Update comment "Operations on the server should not to try to operate on a 
locator.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-16 Thread WireBaron 
Github user WireBaron commented on a diff in the pull request:

https://github.com/apache/geode/pull/716#discussion_r133595959
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java
 ---
@@ -120,6 +126,7 @@
   private InetAddress bind_address;
   private volatile boolean shuttingDown = false; // GemStoneAddition
   private final PoolStatHelper poolHelper;
+  private InternalLocator internalLocator;
--- End diff --

Can this be final?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-16 Thread WireBaron 
Github user WireBaron commented on a diff in the pull request:

https://github.com/apache/geode/pull/716#discussion_r133598026
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ExecutionContext.java
 ---
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+
+package org.apache.geode.internal.cache.tier.sockets;
+
+import org.apache.geode.cache.Cache;
+import org.apache.geode.distributed.internal.InternalLocator;
+
+public class ExecutionContext {
--- End diff --

Should this be marked @Experimental


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-16 Thread WireBaron 
Github user WireBaron commented on a diff in the pull request:

https://github.com/apache/geode/pull/716#discussion_r133596280
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java
 ---
@@ -334,42 +342,46 @@ protected void run() {
* fix for bug 33711 - client requests are spun off to another thread 
for processing. Requests are
* synchronized in processGossip.
*/
-  private void processRequest(final Socket sock) {
+  private void processRequest(final Socket socket) {
 executor.execute(() -> {
   long startTime = DistributionStats.getStatTime();
   DataInputStream input = null;
   Object request, response;
   try {
 
-sock.setSoTimeout(READ_TIMEOUT);
-getSocketCreator().configureServerSSLSocket(sock);
+socket.setSoTimeout(READ_TIMEOUT);
+getSocketCreator().configureServerSSLSocket(socket);
 
 try {
-  input = new DataInputStream(sock.getInputStream());
+  input = new DataInputStream(socket.getInputStream());
 } catch (StreamCorruptedException e) {
   // Some garbage can be left on the socket stream
   // if a peer disappears at exactly the wrong moment.
   log.debug("Discarding illegal request from "
-  + (sock.getInetAddress().getHostAddress() + ":" + 
sock.getPort()), e);
+  + (socket.getInetAddress().getHostAddress() + ":" + 
socket.getPort()), e);
   return;
 }
-int gossipVersion = readGossipVersion(sock, input);
+int gossipVersion = readGossipVersion(socket, input);
 
 short versionOrdinal;
+if (gossipVersion == NON_GOSSIP_REQUEST_VERSION) {
+  if (input.readUnsignedByte() == 
AcceptorImpl.PROTOBUF_CLIENT_SERVER_PROTOCOL
+  && Boolean.getBoolean("geode.feature-protobuf-protocol")) {
+ClientProtocolMessageHandler messageHandler = 
ClientProtocolMessageHandlerLoader.load();
--- End diff --

Rather than introduce a new static object here, can we just have the 
TcpServer own a messageHandler?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-16 Thread WireBaron 
Github user WireBaron commented on a diff in the pull request:

https://github.com/apache/geode/pull/716#discussion_r133597359
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientProtoclMessageHandlerLoader.java
 ---
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+
+package org.apache.geode.internal.cache.tier.sockets;
+
+import java.io.IOException;
+import java.net.Socket;
+import java.util.Iterator;
+import java.util.ServiceLoader;
+
+import org.apache.geode.internal.cache.InternalCache;
+import org.apache.geode.internal.cache.tier.Acceptor;
+import org.apache.geode.internal.cache.tier.CachedRegionHelper;
+import org.apache.geode.internal.security.SecurityService;
+
+/**
+ * Creates instances of ServerConnection based on the connection mode 
provided.
+ */
+public class ClientProtoclMessageHandlerLoader {
--- End diff --

Typo: s/Protocl/Protocol

Actually, this looks like a second copy of this code, so should just be 
deleted in favor of the correctly spelled version.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-16 Thread WireBaron 
Github user WireBaron commented on a diff in the pull request:

https://github.com/apache/geode/pull/716#discussion_r133599245
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ExecutionContext.java
 ---
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+
+package org.apache.geode.internal.cache.tier.sockets;
+
+import org.apache.geode.cache.Cache;
+import org.apache.geode.distributed.internal.InternalLocator;
+
+public class ExecutionContext {
--- End diff --

Should this be marked experimental like the exception?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-16 Thread WireBaron 
Github user WireBaron commented on a diff in the pull request:

https://github.com/apache/geode/pull/716#discussion_r133598920
  
--- Diff: 
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAvailableServersOperationHandler.java
 ---
@@ -50,51 +37,19 @@
   @Override
   public Result process(
   SerializationService serializationService, 
ServerAPI.GetAvailableServersRequest request,
-  Cache cache) {
-
-InternalDistributedSystem distributedSystem =
-(InternalDistributedSystem) cache.getDistributedSystem();
-Properties properties = distributedSystem.getProperties();
-String locatorsString = 
properties.getProperty(ConfigurationProperties.LOCATORS);
-
-HashSet locators = new HashSet();
-StringTokenizer stringTokenizer = new StringTokenizer(locatorsString, 
",");
-while (stringTokenizer.hasMoreTokens()) {
-  String locator = stringTokenizer.nextToken();
-  if (StringUtils.isNotEmpty(locator)) {
-locators.add(new DistributionLocatorId(locator));
-  }
-}
+  ExecutionContext executionContext) throws 
InvalidExecutionContextException {
 
-TcpClient tcpClient = getTcpClient();
-for (DistributionLocatorId locator : locators) {
-  try {
-return getGetAvailableServersFromLocator(tcpClient, 
locator.getHost());
-  } catch (IOException | ClassNotFoundException e) {
-// try the next locator
-  }
-}
-return Failure.of(ProtobufResponseUtilities.makeErrorResponse(
-ProtocolErrorCode.DATA_UNREACHABLE.codeValue, "Unable to find a 
locator"));
-  }
+InternalLocator locator = executionContext.getLocator();
+ArrayList servers2 = 
locator.getServerLocatorAdvisee().getLoadSnapshot().getServers(null);
--- End diff --

I see we didn't fix up this inane variable name I added, can you take care 
of that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: Geode-nightly #925

2017-08-16 Thread Apache Jenkins Server 
See 


Changes:

[jdeppe] GEODE-3423: Have Gradle set LOCAL_USER_ID

[ukohlmeyer] GEODE-3386 - Make KeyedErrorResponse & ErrorResponse siblings

[ukohlmeyer] GEODE-3314 - Refactoring of DLockService to improve developer QoL. 
This

[ukohlmeyer] GEODE-3412: Add simple authentication flow to protobuf protocol. 
This

[ukohlmeyer] GEODE-3412: adding files missing from last commit. This now closes 
#714

[klund] GEODE-3328: fix testAddGemFirePropertyFileToCommandLine on Windows

[jstewart] GEODE-3383: Refactor deploy tests

[dbarnes] GEODE-3395 Variable-ize product version and name in user guide - 
Tools &

--
[...truncated 243.26 KB...]
at org.apache.geode.test.dunit.VM.invoke(VM.java:357)
at org.apache.geode.test.dunit.VM.invoke(VM.java:302)
at 
org.apache.geode.distributed.DistributedSystemDUnitTest.testConflictingUDPPort(DistributedSystemDUnitTest.java:297)

Caused by:
java.lang.AssertionError: 
Expecting:
 
to be an instance of:
 
but was instance of:
 
at 
org.apache.geode.distributed.DistributedSystemDUnitTest.lambda$testConflictingUDPPort$2f137518$1(DistributedSystemDUnitTest.java:303)

java.lang.AssertionError: Suspicious strings were written to the log during 
this run.
Fix the strings or use IgnoredException.addIgnoredException to ignore.
---
Found suspect string in log4j at line 426

[fatal 2017/08/16 20:56:08.021 UTC  
tid=0x1b] Unexpected exception while booting membership services
org.apache.geode.SystemConnectException: unable to create jgroups channel
at 
org.apache.geode.distributed.internal.membership.gms.messenger.JGroupsMessenger.start(JGroupsMessenger.java:348)
at 
org.apache.geode.distributed.internal.membership.gms.Services.start(Services.java:156)
at 
org.apache.geode.distributed.internal.membership.gms.GMSMemberFactory.newMembershipManager(GMSMemberFactory.java:107)
at 
org.apache.geode.distributed.internal.membership.MemberFactory.newMembershipManager(MemberFactory.java:91)
at 
org.apache.geode.distributed.internal.DistributionManager.(DistributionManager.java:1155)
at 
org.apache.geode.distributed.internal.DistributionManager.(DistributionManager.java:1204)
at 
org.apache.geode.distributed.internal.DistributionManager.create(DistributionManager.java:573)
at 
org.apache.geode.distributed.internal.InternalDistributedSystem.initialize(InternalDistributedSystem.java:740)
at 
org.apache.geode.distributed.internal.InternalDistributedSystem.newInstance(InternalDistributedSystem.java:350)
at 
org.apache.geode.distributed.internal.InternalDistributedSystem.newInstance(InternalDistributedSystem.java:336)
at 
org.apache.geode.distributed.internal.InternalDistributedSystem.newInstance(InternalDistributedSystem.java:330)
at 
org.apache.geode.distributed.DistributedSystem.connect(DistributedSystem.java:205)
at 
org.apache.geode.distributed.DistributedSystemDUnitTest.lambda$null$2(DistributedSystemDUnitTest.java:302)
at 
org.assertj.core.api.ThrowableAssert.catchThrowable(ThrowableAssert.java:61)
at 
org.assertj.core.api.AssertionsForClassTypes.catchThrowable(AssertionsForClassTypes.java:653)
at org.assertj.core.api.Assertions.catchThrowable(Assertions.java:879)
at 
org.assertj.core.api.Assertions.assertThatThrownBy(Assertions.java:851)
at 
org.apache.geode.distributed.DistributedSystemDUnitTest.lambda$testConflictingUDPPort$2f137518$1(DistributedSystemDUnitTest.java:302)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at hydra.MethExecutor.executeObject(MethExecutor.java:245)
at 
org.apache.geode.test.dunit.standalone.RemoteDUnitVM.executeMethodOnObject(RemoteDUnitVM.java:70)
at sun.reflect.GeneratedMethodAccessor9.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:357)
at sun.rmi.transport.Transport$1.run(Transport.java:200)
at sun.rmi.transport.Transport$1.run(Transport.java:197)
at java.security.AccessController.doPrivileged(Native Method)
at sun.rmi.transport.Transport.serviceCall(Transport.java:196)
at 
sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:568)
at 
sun.rmi.transport.tcp.TCPTrans

[geode-native] branch develop updated: GEODE-3453: Fix native client function tests to use updated API

2017-08-16 Thread jbarrett 
This is an automated email from the ASF dual-hosted git repository.

jbarrett pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/geode-native.git


The following commit(s) were added to refs/heads/develop by this push:
 new a2e1f10  GEODE-3453: Fix native client function tests to use updated 
API
a2e1f10 is described below

commit a2e1f102b0ac743b929f826147b34a7bcde3f97e
Author: David Kimura 
AuthorDate: Wed Aug 16 17:35:33 2017 -0700

GEODE-3453: Fix native client function tests to use updated API
---
 tests/javaobject/GetFunctionExeHA.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/javaobject/GetFunctionExeHA.java 
b/tests/javaobject/GetFunctionExeHA.java
index 62216c0..ece5f33 100644
--- a/tests/javaobject/GetFunctionExeHA.java
+++ b/tests/javaobject/GetFunctionExeHA.java
@@ -35,7 +35,7 @@ public class GetFunctionExeHA extends FunctionAdapter 
implements Declarable{
 RegionFunctionContext context = (RegionFunctionContext)fc;
 System.out.println("Data set :: " + context.getDataSet());
 Region region = PartitionRegionHelper.getLocalDataForContext(context);
-Set keys = region.keys();
+Set keys = region.keySet();
 Iterator itr = keys.iterator();
 ResultSender sender = context.getResultSender();
 Object k = null;

-- 
To stop receiving notification emails like this one, please contact
['"dev@geode.apache.org" '].