[GitHub] geode issue #652: Geode-2971: Introduce ExitCode to resolve inconsistency of...

[PurelyApplied]

Github user PurelyApplied commented on the issue:

https://github.com/apache/geode/pull/652
  
Precheckin came back fully green.  PR squashed and rebased.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #657: GEODE-3286: Failing to cleanup connections from Con...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/657


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: Geode-nightly #912

[Apache Jenkins Server]

See 

--
[...truncated 112.49 KB...]
Note: Recompile with -Xlint:unchecked for details.

:geode-cq:processTestResources
:geode-cq:testClasses
:geode-cq:checkMissedTests
:geode-cq:spotlessJavaCheck
:geode-cq:spotlessCheck
:geode-cq:test
:geode-cq:check
:geode-cq:build
:geode-cq:distributedTest
:geode-cq:integrationTest
:geode-json:assemble
:geode-json:compileTestJava UP-TO-DATE
:geode-json:processTestResources
:geode-json:testClasses
:geode-json:checkMissedTests UP-TO-DATE
:geode-json:spotlessJavaCheck
:geode-json:spotlessCheck
:geode-json:test UP-TO-DATE
:geode-json:check
:geode-json:build
:geode-json:distributedTest UP-TO-DATE
:geode-json:integrationTest UP-TO-DATE
:geode-junit:javadoc
:geode-junit:javadocJar
:geode-junit:sourcesJar
:geode-junit:signArchives SKIPPED
:geode-junit:assemble
:geode-junit:compileTestJava
:geode-junit:processTestResources UP-TO-DATE
:geode-junit:testClasses
:geode-junit:checkMissedTests
:geode-junit:spotlessJavaCheck
:geode-junit:spotlessCheck
:geode-junit:test
:geode-junit:check
:geode-junit:build
:geode-junit:distributedTest
:geode-junit:integrationTest
:geode-lucene:assemble
:geode-lucene:compileTestJavaNote: Some input files use or override a 
deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-lucene:processTestResources
:geode-lucene:testClasses
:geode-lucene:checkMissedTests
:geode-lucene:spotlessJavaCheck
:geode-lucene:spotlessCheck
:geode-lucene:test
:geode-lucene:check
:geode-lucene:build
:geode-lucene:distributedTest
:geode-lucene:integrationTest
:geode-old-client-support:assemble
:geode-old-client-support:compileTestJavaNote: 

 uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

:geode-old-client-support:processTestResources UP-TO-DATE
:geode-old-client-support:testClasses
:geode-old-client-support:checkMissedTests
:geode-old-client-support:spotlessJavaCheck
:geode-old-client-support:spotlessCheck
:geode-old-client-support:test
:geode-old-client-support:check
:geode-old-client-support:build
:geode-old-client-support:distributedTest
:geode-old-client-support:integrationTest
:geode-old-versions:javadoc UP-TO-DATE
:geode-old-versions:javadocJar
:geode-old-versions:sourcesJar
:geode-old-versions:signArchives SKIPPED
:geode-old-versions:assemble
:geode-old-versions:compileTestJava UP-TO-DATE
:geode-old-versions:processTestResources UP-TO-DATE
:geode-old-versions:testClasses UP-TO-DATE
:geode-old-versions:checkMissedTests UP-TO-DATE
:geode-old-versions:spotlessJavaCheck
:geode-old-versions:spotlessCheck
:geode-old-versions:test UP-TO-DATE
:geode-old-versions:check
:geode-old-versions:build
:geode-old-versions:distributedTest UP-TO-DATE
:geode-old-versions:integrationTest UP-TO-DATE
:geode-protobuf:assemble
:geode-protobuf:extractIncludeTestProto
:geode-protobuf:extractTestProto UP-TO-DATE
:geode-protobuf:generateTestProto UP-TO-DATE
:geode-protobuf:compileTestJavaNote: Some input files use unchecked or unsafe 
operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-protobuf:processTestResources
:geode-protobuf:testClasses
:geode-protobuf:checkMissedTests
:geode-protobuf:spotlessJavaCheck
:geode-protobuf:spotlessCheck
:geode-protobuf:test
:geode-protobuf:check
:geode-protobuf:build
:geode-protobuf:distributedTest
:geode-protobuf:integrationTest
:geode-pulse:assemble
:geode-pulse:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: 

 uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-pulse:processTestResources
:geode-pulse:testClasses
:geode-pulse:checkMissedTests
:geode-pulse:spotlessJavaCheck
:geode-pulse:spotlessCheck
:geode-pulse:test
:geode-pulse:check
:geode-pulse:build
:geode-pulse:distributedTest
:geode-pulse:integrationTest
:geode-rebalancer:assemble
:geode-rebalancer:compileTestJava
:geode-rebalancer:processTestResources UP-TO-DATE
:geode-rebalancer:testClasses
:geode-rebalancer:checkMissedTests
:geode-rebalancer:spotlessJavaCheck
:geode-rebalancer:spotlessCheck
:geode-rebalancer:test
:geode-rebalancer:check
:geode-rebalancer:build
:geode-rebalancer:distributedTest
:geode-rebalancer:integrationTest
:geode-wan:assemble
:geode-wan:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:g

[GitHub] geode pull request #669: GEODE-2226: SessionReplicationIntegrationTests do n...

[ladyVader]

GitHub user ladyVader opened a pull request:

https://github.com/apache/geode/pull/669

GEODE-2226: SessionReplicationIntegrationTests do not run on Windows

* Disable SessionReplicationIntegrationTests on Windows

@nabarunnag, @jhuynh1

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/geode feature/GEODE-2226

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/669.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #669


commit 8f3c6b07acc1cadf23b843a75b165f6a95d88b99
Author: Lynn Hughes-Godfrey 
Date:   2017-07-28T23:15:01Z

GEODE-2226: SesssionReplicationIntegrationTests do not run on Windows

* Disable SessionReplicationIntegrationTests on Windows




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 61166: GEODE-3313: Test utility supports building jar files with multiple classes

[Jared Stewart]

> On July 30, 2017, 5:05 a.m., Jinmei Liao wrote:
> > geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/JarBuilder.java
> > Lines 66 (patched)
> > 
> >
> > looks like only the JavaCompiler needs a temp dir to store some 
> > temporary files and delete them afterwards. JarBuilder doesn't need it. Can 
> > we have JavaCompiler uses a system temp folder instead of needing a dir to 
> > construct it?

My concern was that the built-in `File.createTempFile` method doesn't clean up 
after itself as reliably as the JUnit `TemporaryFolder` rule.  I'll add a 
no-arg constructor that uses a system temp folder and also sets `deleteOnExit`.


> On July 30, 2017, 5:05 a.m., Jinmei Liao wrote:
> > geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/JarBuilderTest.java
> > Lines 105 (patched)
> > 
> >
> > this method seems useful, can we allow user to simply pass a className 
> > (with package prefixes) instead of a File object to the JarBuilder?
> > 
> > Basically I am wondering if the usage of the JarBuilder can be simplied 
> > to the following:
> > 
> > JarBuilder jarbuilder = new JarBuilder();
> > File outputFile = new File(tempDir, output.jar);
> > jarBuilder.buildJar(outputFile, "com.foo.Bar1", "com.foo.Bar2")

Great suggestion!  I will add this functionality.


> On July 30, 2017, 5:05 a.m., Jinmei Liao wrote:
> > geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/ExtendsFunctionAdapter.java
> > Lines 19 (patched)
> > 
> >
> > this has no package declaration. Is it intended?

I omitted a package declaration for simplicity since it didn't seem necessary 
to specify one.  I can add one in if you think the lack of a package is 
confusing.


- Jared


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61166/#review181770
---


On July 28, 2017, 10:46 p.m., Jared Stewart wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61166/
> ---
> 
> (Updated July 28, 2017, 10:46 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-3313: Test utility supports building jar files with multiple classes
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/ClassNameExtractor.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/ClassNameExtractorTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/CompiledSourceCode.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/JarBuilder.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/JarBuilderTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/JavaCompiler.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/JavaCompilerTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/UncompiledSourceCode.java
>  PRE-CREATION 
>   
> geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/AbstractExtendsFunctionAdapter.java
>  PRE-CREATION 
>   
> geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/AbstractFunction.java
>  PRE-CREATION 
>   
> geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/ConcreteExtendsAbstractExtendsFunctionAdapter.java
>  PRE-CREATION 
>   
> geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/ExtendsAbstractFunction.java
>  PRE-CREATION 
>   
> geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/ExtendsFunctionAdapter.java
>  PRE-CREATION 
>   
> geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/ImplementsFunction.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61166/diff/4/
> 
> 
> Testing
> ---
> 
> Precheckin running
> 
> 
> Thanks,
> 
> Jared Stewart
> 
>

[GitHub] geode pull request #670: GEODE-3336: Refactor IndexCommandsDUnitTest to use ...

[YehEmily]

GitHub user YehEmily opened a pull request:

https://github.com/apache/geode/pull/670

GEODE-3336: Refactor IndexCommandsDUnitTest to use test rules

[View the JIRA ticket 
here.](https://issues.apache.org/jira/browse/GEODE-3336)

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [x] Is your initial contribution a single, squashed commit?

- [x] Does `gradlew build` run cleanly?

- [x] Have you written or updated unit tests to verify your changes?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/YehEmily/geode GEODE-1359

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/670.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #670


commit 514018b97c5e5ffab8efbc1e7c119d8bcca64dc1
Author: YehEmily 
Date:   2017-07-26T23:53:27Z

GEODE-1359: Refactor IndexCommandsDUnitTest to use test rules and allow for 
removal of CliCommandTestBase




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #671: GEODE-3255: Refactor CreateAlterDestroyRegionComman...

[YehEmily]

GitHub user YehEmily opened a pull request:

https://github.com/apache/geode/pull/671

GEODE-3255: Refactor CreateAlterDestroyRegionCommands and tests

[View the JIRA ticket 
here.](https://issues.apache.org/jira/browse/GEODE-3255)

`CreateAlterDestroyRegionCommands` was a large class that contained 
multiple commands. Each command was refactored into a separate class, and the 
methods shared by the commands were refactored into a new and appropriately 
named class of their own. Tests related to `CreateAlterDestroyRegionCommands` 
were also refactored.

**Testing status: Precheckin completed successfully**

- [x] JIRA ticket referenced

- [x] PR rebased

- [x] Single, squashed commit

- [x] `gradlew build` runs cleanly

- [x] Tests updated

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/YehEmily/geode GEODE-3255

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/671.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #671


commit 8a0e27fd3bf44cb63871b8b3b226800a845e0e4c
Author: YehEmily 
Date:   2017-07-28T21:23:25Z

GEODE-3255: Refactor CreateAlterDestroyRegionCommands and tests




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #652: Geode-2971: Introduce ExitCode to resolve inconsist...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/652


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Passed: apache/geode#3342 (develop - 9db5c8e)

[Travis CI]

Build Update for apache/geode
-

Build: #3342
Status: Passed

Duration: 14 minutes and 3 seconds
Commit: 9db5c8e (develop)
Author: Patrick Rhomberg
Message: GEODE-2971: Introduce ExitCode to resolve inconsistency of shell exit 
values.

* this closes #652

* Corrected inconsistency of error handling and subsequent exit status in 
member status commands
* 'gfsh help' now returns 0 exit code as base behavior (previously returned 1).

View the changeset: 
https://github.com/apache/geode/compare/3acb47e60f74...9db5c8e58ac6

View the full build log and details: 
https://travis-ci.org/apache/geode/builds/259473587?utm_source=email&utm_medium=notification

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

Re: Review Request 61166: GEODE-3313: Test utility supports building jar files with multiple classes

[Jared Stewart]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61166/
---

(Updated July 31, 2017, 10:37 p.m.)


Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
Patrick Rhomberg.


Changes
---

- Add method for building a jar from class names alone
- Include a package with test/resources java files
- Use a system temp directory rather than a user-specified temp dir


Repository: geode


Description
---

GEODE-3313: Test utility supports building jar files with multiple classes


Diffs (updated)
-

  
geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/ClassNameExtractor.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/ClassNameExtractorTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/CompiledSourceCode.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/JarBuilder.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/JarBuilderTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/JavaCompiler.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/JavaCompilerTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/UncompiledSourceCode.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/UncompiledSourceCodeTest.java
 PRE-CREATION 
  
geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/AbstractExtendsFunctionAdapter.java
 PRE-CREATION 
  
geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/AbstractFunction.java
 PRE-CREATION 
  
geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/ConcreteExtendsAbstractExtendsFunctionAdapter.java
 PRE-CREATION 
  
geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/ExtendsAbstractFunction.java
 PRE-CREATION 
  
geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/ExtendsFunctionAdapter.java
 PRE-CREATION 
  
geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/ImplementsFunction.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/61166/diff/5/

Changes: https://reviews.apache.org/r/61166/diff/4-5/


Testing
---

Precheckin running


Thanks,

Jared Stewart

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #633 was SUCCESSFUL (with 1987 tests)

[Spring CI]

---
Spring Data GemFire > Nightly-ApacheGeode > #633 was successful.
---
Scheduled
1989 tests in total.

https://build.spring.io/browse/SGF-NAG-633/





--
This message is automatically generated by Atlassian Bamboo

[GitHub] geode pull request #667: GEODE-3324 Document finer-grained security permissi...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/667


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #669: GEODE-2226: SessionReplicationIntegrationTests do n...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/669


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 61231: GEODE-3328: simply extract connect command from ShellCommand

[Jared Stewart]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61231/#review181866
---


Ship it!




Ship It!

- Jared Stewart


On July 28, 2017, 8:41 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61231/
> ---
> 
> (Updated July 28, 2017, 8:41 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> I am working on GEM-1575 which involves prompting for ssl configuration 
> properties when connecting to the cluster. So I refactoring the 
> ConnectCommand before doing that.
> This is the first step: simply extracting the command to its separate class 
> without any refactor at all
> 
> GEODE-3328: simply extract connect command from ShellCommand
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/internal/util/PasswordUtil.java 
> ac0b8459e1cd8f399eed5e98bd9d5fbd4953f9c3 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ShellCommands.java
>  d5e1b27715420818e9a63c9bd467d771e5ee20e3 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/StartLocatorCommand.java
>  10dc0db871898b4fe95027baeacfc72f0e16d4a3 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/util/GfshConsoleReader.java
>  80a20e6d075f2b7c9202df96f36aa4c99c445e04 
>   
> geode-core/src/test/java/org/apache/geode/internal/util/PasswordUtilJUnitTest.java
>  8051c5671650ad4f4756f9f614778d1ae1387fa7 
> 
> 
> Diff: https://reviews.apache.org/r/61231/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin running
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

[GitHub] geode pull request #672: GEODE-3256: Refactoring DataCommands

[YehEmily]

GitHub user YehEmily opened a pull request:

https://github.com/apache/geode/pull/672

GEODE-3256: Refactoring DataCommands

[View the JIRA ticket 
here.](https://issues.apache.org/jira/browse/GEODE-3256)

`DataCommands.java` was a large class that contained multiple commands. 
Each command was refactored into a separate class, and the methods shared by 
the commands were refactored into a new and appropriately named class of their 
own (`DataCommandsUtils`).

**Testing Done: Precheckin to be run on morning of 8/1**

- [x] JIRA ticket

- [x] PR rebased

- [x] Single, squashed commit

- [x] Does `gradlew build` runs cleanly

- [ ] No unit tests updated with this change (yet) - some related tests 
could stand to be refactored (especially `GemfireDataCommandsDUnitTest`), but I 
think I will leave these for 
[GEODE-1359](https://issues.apache.org/jira/browse/GEODE-1359).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/YehEmily/geode GEODE-3256

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/672.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #672


commit 017e39eb9cfe27c010c4c31f248c3fcdeab391f9
Author: YehEmily 
Date:   2017-07-31T23:45:19Z

GEODE-3256: Refactoring DataCommands




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #673: GEODE-3284: New flow: getAvailableServers

[WireBaron]

GitHub user WireBaron opened a pull request:

https://github.com/apache/geode/pull/673

GEODE-3284: New flow: getAvailableServers

@galen-pivotal @kohlmu-pivotal @bschuchardt @hiteshk25 @pivotal-amurmann 

Signed-off-by: Bruce Schuchardt 

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [x] Is your initial contribution a single, squashed commit?

- [x] Does `gradlew build` run cleanly?

- [x] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/WireBaron/geode feature/GEODE-3284

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/673.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #673


commit 6da72b504ed83d80fde60e8e661badab4d3d33bb
Author: Udo Kohlmeyer 
Date:   2017-07-31T16:23:53Z

GEODE-3284: New flow: getAvailableServers

Signed-off-by: Bruce Schuchardt 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #674: GEODE-3380: There're 2 problems here

[gesterzhou]

GitHub user gesterzhou opened a pull request:

https://github.com/apache/geode/pull/674

GEODE-3380: There're 2 problems here

@dschneider-pivotal @upthewaterspout @boglesby 

There're 2 problems:
1) when removeAll is retried, it will get EntryNotFound exception. It 
should still put the remove event
into the AEQ.
2) An old bug fix in 8.2 was not merged into develop: when removeAll 
encounter EntryNotFound exception, should
return version tag of the tombstone. (i.e. #51871)

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/geode feature/GEODE-3380

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/674.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #674


commit 2637aaf2677171569c89e98482fb489415795d72
Author: zhouxh 
Date:   2017-08-01T00:55:09Z

GEODE-3380: There're 2 problems here
1) when removeAll is retried, it will get EntryNotFound exception. It 
should still put the remove event
into the AEQ.
2) An old bug fix in 8.2 was not merged into develop: when removeAll 
encounter EntryNotFound exception, should
return version tag of the tombstone.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #664: Fix for GEODE-3292

[jaredjstewart]

Github user jaredjstewart commented on the issue:

https://github.com/apache/geode/pull/664
  
Hi Juan,

Thanks for your contribution!  Your changes look good to me, but our 
[Criteria for Code 
Submissions](https://cwiki.apache.org/confluence/display/GEODE/Criteria+for+Code+Submissions)
 require having tests for the behavior that is being changed.  In this case, it 
would be good to add a test to make sure that GEODE-3292 has been fixed and 
will not reoccur.  Typically I would point you towards an existing test to use 
as a guide, but since your changes appear to be in an area of the code that is 
not particularly well-tested, let me know if you don't feel confident in 
writing such a test and I can help.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---