GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/672
GEODE-3256: Refactoring DataCommands
[View the JIRA ticket
here.](https://issues.apache.org/jira/browse/GEODE-3256)
`DataCommands.java` was a large class that contained multiple commands.
Each command was refactored into a separate class, and the methods shared by
the commands were refactored into a new and appropriately named class of their
own (`DataCommandsUtils`).
**Testing Done: Precheckin to be run on morning of 8/1**
- [x] JIRA ticket
- [x] PR rebased
- [x] Single, squashed commit
- [x] Does `gradlew build` runs cleanly
- [ ] No unit tests updated with this change (yet) - some related tests
could stand to be refactored (especially `GemfireDataCommandsDUnitTest`), but I
think I will leave these for
[GEODE-1359](https://issues.apache.org/jira/browse/GEODE-1359).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/YehEmily/geode GEODE-3256
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/672.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #672
----
commit 017e39eb9cfe27c010c4c31f248c3fcdeab391f9
Author: YehEmily <emilyyeh1...@gmail.com>
Date: 2017-07-31T23:45:19Z
GEODE-3256: Refactoring DataCommands
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
