Re: New Committer: Deepak Dixit
Welcome -- Mike Stolz Principal Engineer - Gemfire Product Manager Mobile: 631-835-4771 On Jul 14, 2017 7:46 PM, "Mark Bretl" wrote: > The Apache Geode Project Management Committee has invited Deepak Dixit to > be committer on the project. We are pleased to announce he has accepted. > > Please join me in welcoming Deepak! > > Thanks, > > Mark > On behalf of the Apache Geode PMC >
Re: Review Request 60666: geode-3166: remove the uncalled getCredential method
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60666/ --- (Updated July 17, 2017, 3:49 p.m.) Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg. Changes --- fixed comment to include deprecated version Repository: geode Description --- geode-3166: remove the uncalled getCredential method I simply removed the call. Since the new method is never called, if we have any users that's implementing this method, it's never used anyway. We will not be breaking backward compatibility, I believe. Diffs (updated) - geode-core/src/main/java/org/apache/geode/security/AuthInitialize.java 6b0675a5629a3e057fd3d54841db740189007966 Diff: https://reviews.apache.org/r/60666/diff/3/ Changes: https://reviews.apache.org/r/60666/diff/2-3/ Testing --- precheckin running Thanks, Jinmei Liao
Re: Review Request 60666: geode-3166: remove the uncalled getCredential method
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60666/#review180683 --- Ship it! Ship It! - Ken Howe On July 17, 2017, 3:49 p.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60666/ > --- > > (Updated July 17, 2017, 3:49 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and > Patrick Rhomberg. > > > Repository: geode > > > Description > --- > > geode-3166: remove the uncalled getCredential method > > I simply removed the call. Since the new method is never called, if we have > any users that's implementing this method, it's never used anyway. We will > not be breaking backward compatibility, I believe. > > > Diffs > - > > geode-core/src/main/java/org/apache/geode/security/AuthInitialize.java > 6b0675a5629a3e057fd3d54841db740189007966 > > > Diff: https://reviews.apache.org/r/60666/diff/3/ > > > Testing > --- > > precheckin running > > > Thanks, > > Jinmei Liao > >
[ANNOUNCE] Apache Geode 1.2.0
The Apache Geode community is pleased to announce the availability of Apache Geode 1.2.0. Apache Geode is a data management platform that provides a database-like consistency model, reliable transaction processing and a shared-nothing architecture to maintain very low latency performance with high concurrency processing. Geode 1.2.0 contains a number of improvements and bug fixes. This release includes redundant, in-memory Apache Lucene indexes of data stored in Geode to enable full-text searching. Users are encouraged to upgrade to the latest release. For the full list of changes please review the release notes: https://cwiki.apache.org/confluence/display/GEODE/Release+Notes#ReleaseNotes-1.2.0 The release artifacts can be downloaded from the project website: http://geode.apache.org/releases/ The release documentation is available at: http://geode.apache.org/docs/guide/about_geode.html We would like to thank all the contributors that made the release possible. Regards, Anthony Baker on behalf of the Apache Geode team
[GitHub] geode pull request #630: GEODE-3141: GetRegion Operation implemented
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/630#discussion_r127756778
--- Diff: geode-protobuf/src/main/proto/region_API.proto ---
@@ -102,4 +102,14 @@ message GetRegionNamesRequest {
message GetRegionNamesResponse {
repeated string regions = 1;
-}
\ No newline at end of file
+}
+
+/* does a region exist? */
+message GetRegionRequest {
+string regionName = 1;
+}
+
+/* success will be true if the region exists */
--- End diff --
Did there used to be a success variable here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #630: GEODE-3141: GetRegion Operation implemented
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/630#discussion_r127761196
--- Diff: geode-protobuf/src/main/proto/region_API.proto ---
@@ -102,4 +102,14 @@ message GetRegionNamesRequest {
message GetRegionNamesResponse {
repeated string regions = 1;
-}
\ No newline at end of file
+}
+
+/* does a region exist? */
+message GetRegionRequest {
+string regionName = 1;
+}
+
+/* success will be true if the region exists */
--- End diff --
Updating the documentation of this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #634: Feature/geode 3175
Github user pivotal-amurmann commented on the issue: https://github.com/apache/geode/pull/634 Should this be squashed? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Can someone grant me wiki edit privileges
Can someone with the relevant karma please grant me edit permissions on cwiki.apache.org/confluence. My username there is browe. Thanks, -Brian
Re: Can someone grant me wiki edit privileges
Done! -Dan On Mon, Jul 17, 2017 at 10:50 AM, Brian Rowe wrote: > Can someone with the relevant karma please grant me edit permissions on > cwiki.apache.org/confluence. My username there is browe. > > Thanks, > -Brian >
Review Request 60918: GEODE-3134: fix lucene command security
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60918/ --- Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, Patrick Rhomberg, and Dan Smith. Repository: geode Description --- GEODE-3108: update lucene security permission to use "LUCENE" target * have lucene module define it's own target for plugability * added string based target support for SecurityService Diffs - geode-core/src/main/java/org/apache/geode/internal/security/IntegratedSecurityService.java 323ab67d7f948b739783b2fb3b6bcfac32f68f0a geode-core/src/main/java/org/apache/geode/internal/security/SecurityService.java b00e0f481f4b0cc92d163915c05822fb339fd158 geode-core/src/test/java/org/apache/geode/test/dunit/rules/MemberStarterRule.java 5b4f2c14545847d9a3fcfc501fdd9ff1e19771ba geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/cli/LuceneIndexCommands.java 6ddacf134710da2f79a2d2e5e4ee866ef605674d geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/cli/functions/LuceneCreateIndexFunction.java 2d3f8d2062b29b3ba11936ac07f67ac4af210640 geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/security/LucenePermission.java PRE-CREATION geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneCommandsSecurityDUnitTest.java 71166017b7a16162e3f4201a9e76691329ab346a Diff: https://reviews.apache.org/r/60918/diff/1/ Testing --- LuceneCommandsSecurityDUnitTest precheckin running Thanks, Jinmei Liao
[GitHub] geode pull request #549: GEODE-2203: gfsh status locator/server - Command no...
Github user YehEmily closed the pull request at: https://github.com/apache/geode/pull/549 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #575: GEODE-3048: Editing tests requiring Gradle test run...
Github user YehEmily closed the pull request at: https://github.com/apache/geode/pull/575 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #630: GEODE-3141: GetRegion Operation implemented
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/630#discussion_r127820947
--- Diff: geode-protobuf/src/main/proto/basicTypes.proto ---
@@ -52,7 +52,12 @@ message CallbackArguments {
message Region {
--- End diff --
Why not inline the contents of this in `GetRegionResponse`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
Re: Review Request 60918: GEODE-3134: fix lucene command security
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60918/#review180739 --- Ship it! +1 - Kirk Lund On July 17, 2017, 6:34 p.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60918/ > --- > > (Updated July 17, 2017, 6:34 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, > Patrick Rhomberg, and Dan Smith. > > > Repository: geode > > > Description > --- > > GEODE-3108: update lucene security permission to use "LUCENE" target > > * have lucene module define it's own target for plugability > * added string based target support for SecurityService > > > Diffs > - > > > geode-core/src/main/java/org/apache/geode/internal/security/IntegratedSecurityService.java > 323ab67d7f948b739783b2fb3b6bcfac32f68f0a > > geode-core/src/main/java/org/apache/geode/internal/security/SecurityService.java > b00e0f481f4b0cc92d163915c05822fb339fd158 > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/MemberStarterRule.java > 5b4f2c14545847d9a3fcfc501fdd9ff1e19771ba > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/cli/LuceneIndexCommands.java > 6ddacf134710da2f79a2d2e5e4ee866ef605674d > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/cli/functions/LuceneCreateIndexFunction.java > 2d3f8d2062b29b3ba11936ac07f67ac4af210640 > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/security/LucenePermission.java > PRE-CREATION > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneCommandsSecurityDUnitTest.java > 71166017b7a16162e3f4201a9e76691329ab346a > > > Diff: https://reviews.apache.org/r/60918/diff/1/ > > > Testing > --- > > LuceneCommandsSecurityDUnitTest precheckin running > > > Thanks, > > Jinmei Liao > >
Re: Review Request 60666: geode-3166: remove the uncalled getCredential method
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60666/#review180740 --- Ship it! +1 - Kirk Lund On July 17, 2017, 3:49 p.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60666/ > --- > > (Updated July 17, 2017, 3:49 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and > Patrick Rhomberg. > > > Repository: geode > > > Description > --- > > geode-3166: remove the uncalled getCredential method > > I simply removed the call. Since the new method is never called, if we have > any users that's implementing this method, it's never used anyway. We will > not be breaking backward compatibility, I believe. > > > Diffs > - > > geode-core/src/main/java/org/apache/geode/security/AuthInitialize.java > 6b0675a5629a3e057fd3d54841db740189007966 > > > Diff: https://reviews.apache.org/r/60666/diff/3/ > > > Testing > --- > > precheckin running > > > Thanks, > > Jinmei Liao > >
Review Request 60924: GEODE-2920: added security tests for create diskstore and create persistent region.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60924/ --- Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg. Repository: geode Description --- GEODE-2920: handle non-existent role in ExampleSecurityManager Diffs - geode-core/src/main/java/org/apache/geode/examples/security/ExampleSecurityManager.java c1d7ebfa017ccc627e7d4da6db951d3f61e2461b geode-core/src/test/java/org/apache/geode/management/internal/security/GfshCommandsSecurityTest.java c2be173f8844bcf25361edc9e5d428f62aa8761f geode-core/src/test/java/org/apache/geode/security/ExampleSecurityManagerTest.java 9093a7bc70835ae50c72a80739a3f8ab4789cacd geode-core/src/test/resources/org/apache/geode/security/templates/security.json c1ee9fc22bad58642d814c5930eb2d02810dad0e Diff: https://reviews.apache.org/r/60924/diff/1/ Testing --- precheckin running Thanks, Jinmei Liao
[GitHub] geode-examples pull request #9: GEODE-3199: Make signing with a gpg key opti...
Github user asfgit closed the pull request at: https://github.com/apache/geode-examples/pull/9 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-examples pull request #10: Feature/geode 3202 - Add an example to demo...
Github user asfgit closed the pull request at: https://github.com/apache/geode-examples/pull/10 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: need information about SerialGatewaySenderQueue/ParallelGatewaySenderQueue Clear
Hi Dinesh,
I think we probably just never got around to adding a clear. I think you
could probably clear your queues just stop stopping and starting the
gateway sender, which might be the easiest thing to do here.
Regarding your code, for your parallel queue are you doing that inside of a
function? The code you have will try to clear things on a single node. The
queue also maintains some other metadata in memory. I'm not quite sure what
the effect on the queue will be if you delete the region entries without
changing that other metadata. I guess you could test it and find out.
You'll probably want to see what the effect is while the queue is actually
dispatching entries as well, because it's possible you could catch the
system in a state where it is trying to read entries from the region as you
are deleting them. Or maybe pause the queue first in your clear method?
-Dan
On Fri, Jul 14, 2017 at 2:23 AM, Dinesh Akhand wrote:
> Hi Team,
>
>
>
> Please reply . why we don't have implementation of clear method in
> ParallelGatewaySenderQueue/ SerialGatewaySenderQueue in geode. Requirement:
> we want to clear the queue data.
>
>
>
> I have implement below method in our code.
>
> --
>
> Class ParallelGatewaySenderQueue.java
>
>
>
> //clear the partition region
>
> private void clearPartitionedRegion(PartitionedRegion partitionedRegion)
>
> {
>
> LocalDataSet lds = (LocalDataSet)
> PartitionRegionHelper.getLocalPrimaryData(partitionedRegion);
>
> Setset = lds.getBucketSet(); // this returns
> bucket ids in the function context
>
>
>
> for (Integer bucketId : set) {
>
> Bucket bucket = partitionedRegion.
> getRegionAdvisor().getBucket(bucketId);
>
> if (bucket instanceof
> ProxyBucketRegion == false) {
>
> if (bucket
> instanceof BucketRegion) {
>
>
> BucketRegion bucketRegion = (BucketRegion) bucket;
>
>
> Set keySet = bucketRegion.keySet();
>
>
> for (Iterator iterator = keySet.iterator(); iterator.hasNext();) {
>
>
> Object key = iterator.next();
>
>
> bucketRegion.remove(key);
>
>
> }
>
> }
>
> }
>
> }
>
> }
>
> -
>
> Class : SerialGatewaySenderQueue.java
>
> @Override
>
> public void clearQueue() {
>
>
>
> this.sender.getLifeCycleLock().readLock().lock();
>
> Set keys = this.region.keys();
>
> for (Long key : keys) {
>
> this.region.remove(key);
>
> }
>
> this.sender.getLifeCycleLock().readLock().unlock();
>
>
>
> }
>
> -
>
>
>
> Any comment in above code will welcome.
>
>
>
>
>
> Thanks,
>
> Dinesh Akhand
>
>
>
> -Original Message-
> From: Dinesh Akhand
> Sent: Monday, May 15, 2017 2:39 PM
> To: dev@geode.apache.org
> Subject: need information about RegionQueue
>
>
>
>
>
> Hi Team,
>
>
>
> Why we do't have support to clear complete queue. Is there any limitation
> for it?.
>
>
>
> public void clear(PartitionedRegion pr, int bucketId) {
>
>throw new RuntimeException("This method(clear)is not supported by
> ParallelGatewaySenderQueue");
>
> }
>
>
>
> Class : ParallelGatewaySenderQueue
>
> Class : SerialGatewaySenderQueue
>
>
>
> Thanks,
>
> Dinesh Akhand
>
>
>
> This message and the information contained herein is proprietary and
> confidential and subject to the Amdocs policy statement,
>
>
>
> you may review at https://www.amdocs.com/about/email-disclaimer <
> https://www.amdocs.com/about/email-disclaimer>
> This message and the information contained herein is proprietary and
> confidential and subject to the Amdocs policy statement,
>
> you may review at https://www.amdocs.com/about/email-disclaimer <
> https://www.amdocs.com/about/email-disclaimer>
>
[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #619 was SUCCESSFUL (with 1953 tests)
--- Spring Data GemFire > Nightly-ApacheGeode > #619 was successful. --- Scheduled 1955 tests in total. https://build.spring.io/browse/SGF-NAG-619/ -- This message is automatically generated by Atlassian Bamboo
[GitHub] geode pull request #639: GEODE-3112: Fixing improper ordering of client time...
GitHub user DivineEnder opened a pull request: https://github.com/apache/geode/pull/639 GEODE-3112: Fixing improper ordering of client timeout setting Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to dev@geode.apache.org. You can merge this pull request into a Git repository by running: $ git pull https://github.com/DivineEnder/geode feature/GEODE-3112 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/639.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #639 commit 4cf98a4605c17f8c08bc878df2db99fb1d194b6e Author: David Anuta Date: 2017-07-17T22:25:35Z GEODE-3112: Fixing improper ordering of client timeout setting --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #639: GEODE-3112: Fixing improper ordering of client timeout set...
Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/639 @ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #640: GEODE-3232: Get a snapshot of maps when serializing...
GitHub user upthewaterspout opened a pull request: https://github.com/apache/geode/pull/640 GEODE-3232: Get a snapshot of maps when serializing FilterProfile Avoiding a race when serializing a CopyOnWrite data structures be grabbing a copy first. Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to dev@geode.apache.org. You can merge this pull request into a Git repository by running: $ git pull https://github.com/upthewaterspout/incubator-geode feature/GEODE-3232 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/640.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #640 commit aaba2aae27c5b4f57d3bfba6220f6dfff60222f0 Author: Dan Smith Date: 2017-07-17T23:46:19Z GEODE-3232: Get a snapshot of maps when serializing FilterProfile Avoiding a race when serializing a CopyOnWrite data structures be grabbing a copy first. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #640: GEODE-3232: Get a snapshot of maps when serializing Filter...
Github user upthewaterspout commented on the issue: https://github.com/apache/geode/pull/640 @ladyVader @nabarunnag --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #638: Feature/geode 2860
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/638 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-examples pull request #11: GEODE-3233 Prefix distribution files with a...
GitHub user metatype opened a pull request: https://github.com/apache/geode-examples/pull/11 GEODE-3233 Prefix distribution files with apache- You can merge this pull request into a Git repository by running: $ git pull https://github.com/metatype/geode-examples develop Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode-examples/pull/11.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #11 commit bcf98bc1cc94f0d72a7c3e4192691e3ea01a25e8 Author: Anthony Baker Date: 2017-07-18T00:38:59Z GEODE-3233 Prefix distribution files with apache- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #641: GetServersResponse number of servers was redundant.
GitHub user galen-pivotal opened a pull request: https://github.com/apache/geode/pull/641 GetServersResponse number of servers was redundant. @kohlmu-pivotal @bschuchardt @hiteshk25 @WireBaron @pivotal-amurmann I think that the number was redundant. What do y'all think? Did we miss some use for it? Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [no. Sorry.] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [x] Is your initial contribution a single, squashed commit? - [x] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to dev@geode.apache.org. You can merge this pull request into a Git repository by running: $ git pull https://github.com/galen-pivotal/geode GetServersResponse-no-number Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/641.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #641 commit 62b82451c4804468b3fe26b8ab9ca2682ef6b030 Author: Brian Rowe Date: 2017-07-17T21:13:42Z GetServersResponse number of servers was redundant. Signed-off-by: Galen O'Sullivan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Review Request 60935: GEODE-3115 Added changes to check for persistent region during pdx type registry.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60935/ --- Review request for geode, Darrel Schneider, Eric Shu, Lynn Gallinat, and Nick Reich. Repository: geode Description --- The pdx registry needs to be persisted to use pdx with persistent region. Currently while creating pdx the system checks, to see if there is a disk store with data instead of looking for persistent region in the system. In cases where persistent region is created and dropped, the system doesn't allow creating pdx witout setting pdx persistence. Diffs - geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 2dda38c geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java 4c229db geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/CacheCreation.java 61f91a0 geode-core/src/main/java/org/apache/geode/pdx/internal/PeerTypeRegistration.java 065255b geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/PersistentPartitionedRegionTestBase.java 45c6120 geode-core/src/test/java/org/apache/geode/pdx/PdxAttributesJUnitTest.java ef15cd5 Diff: https://reviews.apache.org/r/60935/diff/1/ Testing --- Added new test. Precheckin started. Thanks, anilkumar gingade
