----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60918/#review180739 -----------------------------------------------------------
Ship it! +1 - Kirk Lund On July 17, 2017, 6:34 p.m., Jinmei Liao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60918/ > ----------------------------------------------------------- > > (Updated July 17, 2017, 6:34 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, > Patrick Rhomberg, and Dan Smith. > > > Repository: geode > > > Description > ------- > > GEODE-3108: update lucene security permission to use "LUCENE" target > > * have lucene module define it's own target for plugability > * added string based target support for SecurityService > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/internal/security/IntegratedSecurityService.java > 323ab67d7f948b739783b2fb3b6bcfac32f68f0a > > geode-core/src/main/java/org/apache/geode/internal/security/SecurityService.java > b00e0f481f4b0cc92d163915c05822fb339fd158 > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/MemberStarterRule.java > 5b4f2c14545847d9a3fcfc501fdd9ff1e19771ba > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/cli/LuceneIndexCommands.java > 6ddacf134710da2f79a2d2e5e4ee866ef605674d > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/cli/functions/LuceneCreateIndexFunction.java > 2d3f8d2062b29b3ba11936ac07f67ac4af210640 > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/security/LucenePermission.java > PRE-CREATION > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneCommandsSecurityDUnitTest.java > 71166017b7a16162e3f4201a9e76691329ab346a > > > Diff: https://reviews.apache.org/r/60918/diff/1/ > > > Testing > ------- > > LuceneCommandsSecurityDUnitTest precheckin running > > > Thanks, > > Jinmei Liao > >
