[jira] [Moved] (GEODE-3004) file logging do not check if parent directories exists

[*$^¨%`£]

 [ 
https://issues.apache.org/jira/browse/GEODE-3004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olivier Lamy (*$^¨%`£) moved MCOMPILER-299 to GEODE-3004:
-

Affects Version/s: (was: 3.6.1)
   1.1.1
 Workflow: patch-available, re-open possible  (was: Default 
workflow, editable Closed status)
  Key: GEODE-3004  (was: MCOMPILER-299)
  Project: Geode  (was: Maven Compiler Plugin)

> file logging do not check if parent directories exists
> --
>
> Key: GEODE-3004
> URL: https://issues.apache.org/jira/browse/GEODE-3004
> Project: Geode
>  Issue Type: Bug
>Affects Versions: 1.1.1
>Reporter: Olivier Lamy (*$^¨%`£)
>
> {code}
> Caused by: java.io.FileNotFoundException: logs/gemfire-client.log (No such 
> file or directory)
>   at java.io.FileOutputStream.open0(Native Method) ~[?:1.8.0_121]
>   at java.io.FileOutputStream.open(FileOutputStream.java:270) 
> ~[?:1.8.0_121]
>   at java.io.FileOutputStream.(FileOutputStream.java:213) 
> ~[?:1.8.0_121]
>   at 
> org.apache.geode.internal.logging.log4j.LogWriterAppenders.createLogWriterAppender(LogWriterAppenders.java:162)
>  ~[geode-core-9.0.3.jar:?]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-3004) file logging do not check if parent directories exists

[*$^¨%`£]

[ 
https://issues.apache.org/jira/browse/GEODE-3004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029177#comment-16029177
 ] 

Olivier Lamy (*$^¨%`£) commented on GEODE-3004:
---

working on a patch.

> file logging do not check if parent directories exists
> --
>
> Key: GEODE-3004
> URL: https://issues.apache.org/jira/browse/GEODE-3004
> Project: Geode
>  Issue Type: Bug
>Affects Versions: 1.1.1
>Reporter: Olivier Lamy (*$^¨%`£)
>
> {code}
> Caused by: java.io.FileNotFoundException: logs/gemfire-client.log (No such 
> file or directory)
>   at java.io.FileOutputStream.open0(Native Method) ~[?:1.8.0_121]
>   at java.io.FileOutputStream.open(FileOutputStream.java:270) 
> ~[?:1.8.0_121]
>   at java.io.FileOutputStream.(FileOutputStream.java:213) 
> ~[?:1.8.0_121]
>   at 
> org.apache.geode.internal.logging.log4j.LogWriterAppenders.createLogWriterAppender(LogWriterAppenders.java:162)
>  ~[geode-core-9.0.3.jar:?]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2580) New Client/Server Protocol to make the development of clients easier

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029531#comment-16029531
 ] 

ASF subversion and git services commented on GEODE-2580:


Commit ceabf07aafdfe80a424ba90cfc42fc4c3ce74594 in geode's branch 
refs/heads/feature/GEODE-2580 from [~ukohlmeyer]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=ceabf07 ]

GEODE-2580: Amended gradle build to include protobuf files as src files


> New Client/Server Protocol to make the development of clients easier
> 
>
> Key: GEODE-2580
> URL: https://issues.apache.org/jira/browse/GEODE-2580
> Project: Geode
>  Issue Type: Wish
>  Components: client/server
>Reporter: Addison
>
> Today, writing a client in a new language (e.g. Go, Ruby, etc) is difficult 
> be the client/server protocol is now well documented and optimized for 
> super-low latency over maintainability.  The goal of this this epic is to 
> write a new client/server protocol that is well documented that will be the 
> foundation for future Geode client.
> This epic is broken down in the sub-tasks below.
> Please vote on this wish if you think it is a worthwhile endeavor.
> Note: no design choices are being made just yet. The first sub-task in this 
> epic is to make a former proposal to the developer list to discuss 
> foundational design choices.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2951) A gfsh lucene query specifying --pageSize fails with a NullPointerException

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029674#comment-16029674
 ] 

ASF subversion and git services commented on GEODE-2951:


Commit d3543d229de46a3a582881484bccf3b77d8ac505 in geode's branch 
refs/heads/develop from [~karensmolermiller]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=d3543d2 ]

GEODE-2951 Remove --pageSize from docs of gfsh search lucene


> A gfsh lucene query specifying --pageSize fails with a NullPointerException
> ---
>
> Key: GEODE-2951
> URL: https://issues.apache.org/jira/browse/GEODE-2951
> Project: Geode
>  Issue Type: Bug
>  Components: docs, lucene
>Reporter: Barry Oglesby
>Assignee: Karen Smoler Miller
> Fix For: 1.2.0
>
>
> A gfsh lucene query specifying {{--pageSize}} fails with a 
> NullPointerException:
> {noformat}
> gfsh>search lucene --name=index --region=data --queryStrings=NYPD 
> --defaultField=Agency --pageSize=10
> Could not process command due to GemFire error. An error occurred while 
> searching lucene index across the Geode cluster: null
> {noformat}
> This exception is logged in the locator.log:
> {noformat}
> [info 2017/05/18 12:42:22.317 PDT locator  
> tid=0x7f] null
> java.lang.NullPointerException
>   at 
> org.apache.geode.cache.lucene.internal.cli.LuceneIndexCommands.displayResults(LuceneIndexCommands.java:476)
>   at 
> org.apache.geode.cache.lucene.internal.cli.LuceneIndexCommands.searchIndex(LuceneIndexCommands.java:299)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> {noformat}
> The same query without the {{--pageSize=10}} setting works fine.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #542: GEODE-2951 Remove --pageSize from docs of gfsh sear...

[karensmolermiller]

Github user karensmolermiller closed the pull request at:

https://github.com/apache/geode/pull/542


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #542: GEODE-2951 Remove --pageSize from docs of gfsh search luce...

[karensmolermiller]

Github user karensmolermiller commented on the issue:

https://github.com/apache/geode/pull/542
  
Merged in with d3543d229de46a3a582881484bccf3b77d8ac505.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2951) A gfsh lucene query specifying --pageSize fails with a NullPointerException

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029684#comment-16029684
 ] 

ASF GitHub Bot commented on GEODE-2951:
---

Github user karensmolermiller commented on the issue:

https://github.com/apache/geode/pull/542
  
Merged in with d3543d229de46a3a582881484bccf3b77d8ac505.


> A gfsh lucene query specifying --pageSize fails with a NullPointerException
> ---
>
> Key: GEODE-2951
> URL: https://issues.apache.org/jira/browse/GEODE-2951
> Project: Geode
>  Issue Type: Bug
>  Components: docs, lucene
>Reporter: Barry Oglesby
>Assignee: Karen Smoler Miller
> Fix For: 1.2.0
>
>
> A gfsh lucene query specifying {{--pageSize}} fails with a 
> NullPointerException:
> {noformat}
> gfsh>search lucene --name=index --region=data --queryStrings=NYPD 
> --defaultField=Agency --pageSize=10
> Could not process command due to GemFire error. An error occurred while 
> searching lucene index across the Geode cluster: null
> {noformat}
> This exception is logged in the locator.log:
> {noformat}
> [info 2017/05/18 12:42:22.317 PDT locator  
> tid=0x7f] null
> java.lang.NullPointerException
>   at 
> org.apache.geode.cache.lucene.internal.cli.LuceneIndexCommands.displayResults(LuceneIndexCommands.java:476)
>   at 
> org.apache.geode.cache.lucene.internal.cli.LuceneIndexCommands.searchIndex(LuceneIndexCommands.java:299)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> {noformat}
> The same query without the {{--pageSize=10}} setting works fine.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2951) A gfsh lucene query specifying --pageSize fails with a NullPointerException

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029685#comment-16029685
 ] 

ASF GitHub Bot commented on GEODE-2951:
---

Github user karensmolermiller closed the pull request at:

https://github.com/apache/geode/pull/542


> A gfsh lucene query specifying --pageSize fails with a NullPointerException
> ---
>
> Key: GEODE-2951
> URL: https://issues.apache.org/jira/browse/GEODE-2951
> Project: Geode
>  Issue Type: Bug
>  Components: docs, lucene
>Reporter: Barry Oglesby
>Assignee: Karen Smoler Miller
> Fix For: 1.2.0
>
>
> A gfsh lucene query specifying {{--pageSize}} fails with a 
> NullPointerException:
> {noformat}
> gfsh>search lucene --name=index --region=data --queryStrings=NYPD 
> --defaultField=Agency --pageSize=10
> Could not process command due to GemFire error. An error occurred while 
> searching lucene index across the Geode cluster: null
> {noformat}
> This exception is logged in the locator.log:
> {noformat}
> [info 2017/05/18 12:42:22.317 PDT locator  
> tid=0x7f] null
> java.lang.NullPointerException
>   at 
> org.apache.geode.cache.lucene.internal.cli.LuceneIndexCommands.displayResults(LuceneIndexCommands.java:476)
>   at 
> org.apache.geode.cache.lucene.internal.cli.LuceneIndexCommands.searchIndex(LuceneIndexCommands.java:299)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> {noformat}
> The same query without the {{--pageSize=10}} setting works fine.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-3003) Geode doesn't start after cluster restart when using cluster-configuration

[Swapnil Bawaskar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Swapnil Bawaskar updated GEODE-3003:

Component/s: membership

> Geode doesn't start after cluster restart when using cluster-configuration
> --
>
> Key: GEODE-3003
> URL: https://issues.apache.org/jira/browse/GEODE-3003
> Project: Geode
>  Issue Type: Bug
>  Components: configuration, membership
>Reporter: Anton Mironenko
>Priority: Blocker
> Attachments: 20170522-geode-klyazma.zip, 20170522-geode-vyazma.zip, 
> geode-host1.zip, geode-host2.zip, readme.txt
>
>
> There is a two-host Geode cluster with locator and server on each host.
> First start of all nodes goes well.
> Then all nodes are gracefully stopped (kill [locator-PID] [server-PID]).
> The second start goes wrong: the locator on the first host always doesn't 
> join the rest of the cluster with the error in the locator log:
> "Region /_ConfigurationRegion has potentially stale data. It is waiting for 
> another member to recover the latest data."
> And sometimes (once per 5 starts) some server shuts down just after start 
> with the error 
> "org.apache.geode.GemFireConfigException: cluster configuration service not 
> available".
> This bug started appearing only when we moved to Geode 1.1.1. And it totally 
> blocks us.
> On GemFire 8.2.1 there was no such a bug.
> This is very easy to reproduce.
> Test preparation:
> -
> Here are two attached zip files - "geode-host1.zip" and "geode-host2.zip"
> 1) unzip "geode-host1.zip" into some folder on your first host
> 2) in start-locator.sh change the IPs of locators to the values of your host1 
> and host2
> "--locators=10.50.3.38[20236],10.50.3.14[20236]"
> 3) in start-server.sh 
> "locators=10.50.3.38[20236],10.50.3.14[20236]" change the IPs of locators to 
> the values of your host1 and host2
> 4) do the bullets 1)-4) for host2, the folder where you unzip the file should 
> be the same as on the first host
> Test running:
> ---
> 1) rm -rf {locator0,server1}
> 2) run ./start-locator.sh; ./start-server.sh on both hosts. See that this 
> cluster start is successful.
> 3) kill locator and server processes on both hosts
> kill [locator-PID] [server-PID]
> 4) run ./start-locator.sh; ./start-server.sh on both hosts
> 5) see that actually there are two clusters: "host1-locator" and 
> "host1-server, host2-locator, host2-server" instead of one cluster. And 
> sometimes there is no "host1-server", because it shutdown with error "Region 
> /_ConfigurationRegion has potentially stale data. It is waiting for another 
> member to recover the latest data.".



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-2951) A gfsh lucene query specifying --pageSize fails with a NullPointerException

[Karen Smoler Miller (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karen Smoler Miller resolved GEODE-2951.

Resolution: Fixed

> A gfsh lucene query specifying --pageSize fails with a NullPointerException
> ---
>
> Key: GEODE-2951
> URL: https://issues.apache.org/jira/browse/GEODE-2951
> Project: Geode
>  Issue Type: Bug
>  Components: docs, lucene
>Reporter: Barry Oglesby
>Assignee: Karen Smoler Miller
> Fix For: 1.2.0
>
>
> A gfsh lucene query specifying {{--pageSize}} fails with a 
> NullPointerException:
> {noformat}
> gfsh>search lucene --name=index --region=data --queryStrings=NYPD 
> --defaultField=Agency --pageSize=10
> Could not process command due to GemFire error. An error occurred while 
> searching lucene index across the Geode cluster: null
> {noformat}
> This exception is logged in the locator.log:
> {noformat}
> [info 2017/05/18 12:42:22.317 PDT locator  
> tid=0x7f] null
> java.lang.NullPointerException
>   at 
> org.apache.geode.cache.lucene.internal.cli.LuceneIndexCommands.displayResults(LuceneIndexCommands.java:476)
>   at 
> org.apache.geode.cache.lucene.internal.cli.LuceneIndexCommands.searchIndex(LuceneIndexCommands.java:299)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> {noformat}
> The same query without the {{--pageSize=10}} setting works fine.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2983) gfsh doesn't return user friendly error message when java property has comma separated values

[Kirk Lund (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029729#comment-16029729
 ] 

Kirk Lund commented on GEODE-2983:
--

Workaround is to specify quotes around the value of --J:
{noformat}
--J="-Dgemfire.security-enabled-components=server,http,jmx,gateway"
{noformat}
Error message needs improvement.

> gfsh doesn't return user friendly error message when java property has comma 
> separated values
> -
>
> Key: GEODE-2983
> URL: https://issues.apache.org/jira/browse/GEODE-2983
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Reporter: Hitesh Khamesra
>
> Here is the gfsh command and output. It is telling "Error: Could not find or 
> load main class http", which slightly misleading
> -bash-4.2$ gfsh start locator --dir=gemfire-locator --name=locator 
> --port=56661 --enable-cluster-configuration=true --force=true 
> --J=-Dgemfire.OSProcess.ENABLE_OUTPUT_REDIRECTION=true 
> --J=-Dgemfire.http-service-port=8080  
> --J=-Dgemfire.security-manager=SecurityManager 
> --J=-Dgemfire.security-enabled-components=server,http,jmx,gateway
> .The Locator process terminated unexpectedly with exit status 1. Please refer 
> to the log file in tmp/gemfire-locator for full details.
> Error: Could not find or load main class http



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Comment Edited] (GEODE-2983) gfsh doesn't return user friendly error message when java property has comma separated values

[Kirk Lund (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029729#comment-16029729
 ] 

Kirk Lund edited comment on GEODE-2983 at 5/30/17 4:55 PM:
---

Workaround is to specify quotes around the value of --J:
{noformat}
--J="-Dgemfire.security-enabled-components=server,http,jmx,gateway"
{noformat}



was (Author: klund):
Workaround is to specify quotes around the value of --J:
{noformat}
--J="-Dgemfire.security-enabled-components=server,http,jmx,gateway"
{noformat}
Error message needs improvement.

> gfsh doesn't return user friendly error message when java property has comma 
> separated values
> -
>
> Key: GEODE-2983
> URL: https://issues.apache.org/jira/browse/GEODE-2983
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Reporter: Hitesh Khamesra
>
> Here is the gfsh command and output. It is telling "Error: Could not find or 
> load main class http", which slightly misleading
> -bash-4.2$ gfsh start locator --dir=gemfire-locator --name=locator 
> --port=56661 --enable-cluster-configuration=true --force=true 
> --J=-Dgemfire.OSProcess.ENABLE_OUTPUT_REDIRECTION=true 
> --J=-Dgemfire.http-service-port=8080  
> --J=-Dgemfire.security-manager=SecurityManager 
> --J=-Dgemfire.security-enabled-components=server,http,jmx,gateway
> .The Locator process terminated unexpectedly with exit status 1. Please refer 
> to the log file in tmp/gemfire-locator for full details.
> Error: Could not find or load main class http



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #528: GEODE-1994, revisited: Removed guaranteed failures.

[PurelyApplied]

Github user PurelyApplied closed the pull request at:

https://github.com/apache/geode/pull/528


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-1994) Change geode StringUtils to extend commons StringUtils

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029730#comment-16029730
 ] 

ASF GitHub Bot commented on GEODE-1994:
---

Github user PurelyApplied closed the pull request at:

https://github.com/apache/geode/pull/528


> Change geode StringUtils to extend commons StringUtils
> --
>
> Key: GEODE-1994
> URL: https://issues.apache.org/jira/browse/GEODE-1994
> Project: Geode
>  Issue Type: Wish
>  Components: general, management
>Reporter: Kirk Lund
>Assignee: Patrick Rhomberg
>
> org.apache.geode.internal.lang.StringUtils duplicates some of the methods in 
> org.apache.commons.lang.StringUtils with some inconsistencies.
> isBlank is implemented identically
> isEmpty is inconsistent -- commons version returns true if string is null, 
> while geode version returns false if string is null



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #546: GEODE-2818: add alias to any command's options that...

[YehEmily]

GitHub user YehEmily opened a pull request:

https://github.com/apache/geode/pull/546

GEODE-2818: add alias to any command's options that involves "group", 
"member", "jar"

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/YehEmily/geode synonyms.rerun.rererun

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/546.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #546


commit 80871fe2fc68247c8f53ac3ac78aaff16adc483a
Author: YehEmily 
Date:   2017-05-25T19:18:45Z

GEODE-2818: Edited command files and testing files to allow either 'group' 
or 'groups' and 'member' or 'members' and 'jar' or 'jars'

commit 3fd97485d708cdd489968e12c08153f0a39fa243
Author: YehEmily 
Date:   2017-05-26T18:50:35Z

GEODE-2818: Edited command files and testing files to allow either 'group' 
or 'groups' and 'member' or 'members' and 'jar' or 'jars'

commit bcf2e7d6940cddb241418463da41a44df5e883bb
Author: YehEmily 
Date:   2017-05-29T22:21:40Z

GEODE-2818: add alias to any command's options that involves "group", 
"member", "jar"




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2818) add alias to any command's options that involves "group", "member", "jar"

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029739#comment-16029739
 ] 

ASF GitHub Bot commented on GEODE-2818:
---

GitHub user YehEmily opened a pull request:

https://github.com/apache/geode/pull/546

GEODE-2818: add alias to any command's options that involves "group", 
"member", "jar"

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/YehEmily/geode synonyms.rerun.rererun

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/546.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #546


commit 80871fe2fc68247c8f53ac3ac78aaff16adc483a
Author: YehEmily 
Date:   2017-05-25T19:18:45Z

GEODE-2818: Edited command files and testing files to allow either 'group' 
or 'groups' and 'member' or 'members' and 'jar' or 'jars'

commit 3fd97485d708cdd489968e12c08153f0a39fa243
Author: YehEmily 
Date:   2017-05-26T18:50:35Z

GEODE-2818: Edited command files and testing files to allow either 'group' 
or 'groups' and 'member' or 'members' and 'jar' or 'jars'

commit bcf2e7d6940cddb241418463da41a44df5e883bb
Author: YehEmily 
Date:   2017-05-29T22:21:40Z

GEODE-2818: add alias to any command's options that involves "group", 
"member", "jar"




> add alias to any command's options that involves "group", "member", "jar"
> -
>
> Key: GEODE-2818
> URL: https://issues.apache.org/jira/browse/GEODE-2818
> Project: Geode
>  Issue Type: New Feature
>  Components: docs, gfsh
>Reporter: Jinmei Liao
>Assignee: Emily Yeh
>
> Or anything that would have confusion about if we are going to use singular 
> or plural at all.
> 1) add alias for those options
> 2) make sure it parameter type is an array type, some method only accepts a 
> string and split it inside the command.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (GEODE-3005) A developer can create a Region with Partition Resolution using Java API

[Fred Krone (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fred Krone reassigned GEODE-3005:
-

Assignee: Fred Krone

> A developer can create a Region with Partition Resolution using Java API
> 
>
> Key: GEODE-3005
> URL: https://issues.apache.org/jira/browse/GEODE-3005
> Project: Geode
>  Issue Type: Wish
>  Components: regions
>Reporter: Fred Krone
>Assignee: Fred Krone
>
> A user should be able to set partition by prefix programmatically when 
> creating a partitioned region.
> This can only be done when creating a Region type PARTITION



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-3005) A developer can create a Region with Partition Resolution using Java API

[Fred Krone (JIRA)]

Fred Krone created GEODE-3005:
-

 Summary: A developer can create a Region with Partition Resolution 
using Java API
 Key: GEODE-3005
 URL: https://issues.apache.org/jira/browse/GEODE-3005
 Project: Geode
  Issue Type: Wish
Reporter: Fred Krone


A user should be able to set partition by prefix programmatically when creating 
a partitioned region.

This can only be done when creating a Region type PARTITION



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-3005) A developer can create a Region with Partition Resolution using Java API

[Fred Krone (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fred Krone updated GEODE-3005:
--
Component/s: regions

> A developer can create a Region with Partition Resolution using Java API
> 
>
> Key: GEODE-3005
> URL: https://issues.apache.org/jira/browse/GEODE-3005
> Project: Geode
>  Issue Type: Wish
>  Components: regions
>Reporter: Fred Krone
>
> A user should be able to set partition by prefix programmatically when 
> creating a partitioned region.
> This can only be done when creating a Region type PARTITION



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #546: GEODE-2818: add alias to any command's options that...

[jinmeiliao]

Github user jinmeiliao commented on a diff in the pull request:

https://github.com/apache/geode/pull/546#discussion_r119159305
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java
 ---
@@ -726,13 +733,13 @@
   public static final String CREATE_INDEX__REGION = "region";
   public static final String CREATE_INDEX__REGION__HELP =
   "Name/Path of the region which corresponds to the \"from\" clause in 
a query.";
-  public static final String CREATE_INDEX__MEMBER = "member";
+  public static final String CREATE_INDEX__MEMBER = MEMBER;
--- End diff --

I am wondering if you can delete all these other xxx_GROUP or xxx_MEMBER 
string declarations and change all reference of them to use the generic ones.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2818) add alias to any command's options that involves "group", "member", "jar"

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029755#comment-16029755
 ] 

ASF GitHub Bot commented on GEODE-2818:
---

Github user jinmeiliao commented on a diff in the pull request:

https://github.com/apache/geode/pull/546#discussion_r119159305
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java
 ---
@@ -726,13 +733,13 @@
   public static final String CREATE_INDEX__REGION = "region";
   public static final String CREATE_INDEX__REGION__HELP =
   "Name/Path of the region which corresponds to the \"from\" clause in 
a query.";
-  public static final String CREATE_INDEX__MEMBER = "member";
+  public static final String CREATE_INDEX__MEMBER = MEMBER;
--- End diff --

I am wondering if you can delete all these other xxx_GROUP or xxx_MEMBER 
string declarations and change all reference of them to use the generic ones.


> add alias to any command's options that involves "group", "member", "jar"
> -
>
> Key: GEODE-2818
> URL: https://issues.apache.org/jira/browse/GEODE-2818
> Project: Geode
>  Issue Type: New Feature
>  Components: docs, gfsh
>Reporter: Jinmei Liao
>Assignee: Emily Yeh
>
> Or anything that would have confusion about if we are going to use singular 
> or plural at all.
> 1) add alias for those options
> 2) make sure it parameter type is an array type, some method only accepts a 
> string and split it inside the command.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #547: GEODE-2957: Create Lucene index analyzer help updat...

[DivineEnder]

GitHub user DivineEnder opened a pull request:

https://github.com/apache/geode/pull/547

GEODE-2957: Create Lucene index analyzer help updated to include keyw…

…ord DEFAULT

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/DivineEnder/geode feature/GEODE-2957

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/547.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #547


commit 0e37c14c01dd5ceb853f337c6c45c6287e6ccd7f
Author: David Anuta 
Date:   2017-05-30T16:27:11Z

GEODE-2957: Create Lucene index analyzer help updated to include keyword 
DEFAULT




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #547: GEODE-2957: Create Lucene index analyzer help updated to i...

[DivineEnder]

Github user DivineEnder commented on the issue:

https://github.com/apache/geode/pull/547
  
@ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2957) null used as a default parameter when specifying analyzers

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029757#comment-16029757
 ] 

ASF GitHub Bot commented on GEODE-2957:
---

GitHub user DivineEnder opened a pull request:

https://github.com/apache/geode/pull/547

GEODE-2957: Create Lucene index analyzer help updated to include keyw…

…ord DEFAULT

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/DivineEnder/geode feature/GEODE-2957

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/547.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #547


commit 0e37c14c01dd5ceb853f337c6c45c6287e6ccd7f
Author: David Anuta 
Date:   2017-05-30T16:27:11Z

GEODE-2957: Create Lucene index analyzer help updated to include keyword 
DEFAULT




> null used as a default parameter when specifying analyzers
> --
>
> Key: GEODE-2957
> URL: https://issues.apache.org/jira/browse/GEODE-2957
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Jason Huynh
>Assignee: David Anuta
> Fix For: 1.2.0
>
>
> null seems to be the way to specify using the default 
> StandardKeywordAnalyzer. This can be used when specifying a long list of 
> field/analyzers.  
> So the line may look like 
> --analyzers="null,SomeAnalyzer,null,null,SomeAnalyzer}
>  We should probably change that to default or some other keyword.  null seems 
> a bit confusing.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2957) null used as a default parameter when specifying analyzers

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029758#comment-16029758
 ] 

ASF GitHub Bot commented on GEODE-2957:
---

Github user DivineEnder commented on the issue:

https://github.com/apache/geode/pull/547
  
@ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou 


> null used as a default parameter when specifying analyzers
> --
>
> Key: GEODE-2957
> URL: https://issues.apache.org/jira/browse/GEODE-2957
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Jason Huynh
>Assignee: David Anuta
> Fix For: 1.2.0
>
>
> null seems to be the way to specify using the default 
> StandardKeywordAnalyzer. This can be used when specifying a long list of 
> field/analyzers.  
> So the line may look like 
> --analyzers="null,SomeAnalyzer,null,null,SomeAnalyzer}
>  We should probably change that to default or some other keyword.  null seems 
> a bit confusing.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Geode Exception: cluster configuration service not available

[Kirk Lund]

1st problem is two locators starting up but not seeing each other. I
recommend solving this issue first. I'm not aware of any bugs but maybe
someone else recognizes this?

2nd problem is probably GEODE-2238. The cause of GEODE-2238 is the Locator
starts an asynchronous thread to initialize cluster config. That thread may
not have completed initializing cluster config before requests from new
Servers start coming in to get the config. Workaround is to delay starting
the Servers until the Locator has completed initializing cluster config.

On Thu, May 25, 2017 at 6:06 AM, Anton Mironenko 
wrote:

> Hi Aravind,
> Why did you miss the locator property
>
>   --enable-cluster-configuration=true \
> ?
>
> Anton Mironenko
> Software Architect
> Amdocs ASP team
>
> -Original Message-
> From: Aravind Musigumpula
> Sent: Thursday, May 25, 2017 10:54
> To: dev@geode.apache.org
> Subject: RE: Geode Exception: cluster configuration service not available
>
> Hi,
> Currently I am using the following configuration :
>
> locator-specific-props:(used by both locators)
> --J=-Dgemfire.jmx-manager=true
> --J=-Dgemfire.jmx-manager-start=true
> --J=-Dgemfire.jmx-manager-port=(portno.)
> --J=-Dgemfire.jmx-manager-http-port=(portno.)
> locator-common-props:( used by both locators)
> --initial-heap=256M --max-heap=256M
> --mcast-port=0
> --locators=address(port), address(port)
> --dir=.
> --J=-XX:+UseParNewGC --J=-XX:+UseConcMarkSweepGC --J=-XX:
> CMSInitiatingOccupancyFraction=60 --J=-XX:+UseCMSInitiatingOccupancyOnly
> --J=-XX:+CMSParallelRemarkEnabled --  J=XX:+DisableExplicitGC 
> --J=-XX:+CMSClassUnloadingEnabled
> --J=-verbose:gc --J=-Xloggc:locator-gc.log --J=-XX:+PrintGCDateStamps
> --J=-XX:+PrintGCDetails --J=-XX:+PrintTenuringDistribution -J=-XX:+
> PrintGCApplicationConcurrentTime --J=-XX:+PrintGCApplicationStoppedTime
> server-common-props(used by both servers)
> locators= address(port), address(port)
> cache-xml-file=./Server.xml
> -J-Dgemfire.ALLOW_PERSISTENT_TRANSACTIONS=true
> enable-network-partition-detection=true
> disable-auto-reconnect=true
> statistic-archive-file=statistics.log
> server-specific-props-1(used by both servers)
> jmx-manager=false
> jmx-manager-start=false
> server-jvm-props(used by both servers)
> -J-Xmx256M -J-Xms256M
> -J-XX:+UseParNewGC -J-XX:+UseConcMarkSweepGC -J-XX:
> CMSInitiatingOccupancyFraction=60 -J-XX:+UseCMSInitiatingOccupancyOnly
> -J-XX:+CMSParallelRemarkEnabled -J-
>  XX:+DisableExplicitGC -J-XX:+CMSClassUnloadingEnabled -J-verbose:gc
> -J-Xloggc:server-gc.log -J-XX:+PrintGCDateStamps -J-XX:+PrintGCDetails
> -J-XX:+PrintTenuringDistribution -J- XX:+
> PrintGCApplicationConcurrentTime -J-XX:+PrintGCApplicationStoppedTime
>
> Initially it was set to true as it was not working I set it to false and
> tried, but it also didn’t work.
>
>
>
> Thanks,
> Aravind Musigumpula
>
> -Original Message-
> From: Jinmei Liao [mailto:jil...@pivotal.io]
> Sent: Wednesday, May 24, 2017 8:58 PM
> To: dev@geode.apache.org
> Subject: Re: Geode Exception: cluster configuration service not available
>
> Aravind, can you provide us with your startup script and the relevant
> locator/server properties file? Is there any reason you want to set the
> server's "disable-auto-reconnect" to false?
>
> On Wed, May 24, 2017 at 4:41 AM, Aravind Musigumpula <
> aravind.musigump...@amdocs.com> wrote:
>
> >
> > Hi,
> >
> > I am using a cluster configuration in geode 1.1.1 . I am starting two
> > locators on different hosts and one server for each locator. When I
> > stop them and restart the cluster, I can see that in one of the
> > locator view , it is receiving only one locator. In gfsh list members,
> > I can see only one locator of that host but no server and no other
> locator and its server.
> >
> > I tried enabling the following parameters:
> > In locator-specific-props: I have set "enable-cluster-configuration=
> true"
> > In sever-common-props: I have set "disable-auto-reconnect=false" ,
> > "use-cluster-configuration=true"
> >
> > In Server cache log, I am getting an exception :
> > Cache server error
> > org.apache.geode.GemFireConfigException: cluster configuration service
> > not available
> > at org.apache.geode.internal.cache.GemFireCacheImpl.
> > requestSharedConfiguration(GemFireCacheImpl.java:1067)
> > at org.apache.geode.internal.cache.GemFireCacheImpl.
> > initialize(GemFireCacheImpl.java:1200)
> > at org.apache.geode.internal.cache.GemFireCacheImpl.
> > basicCreate(GemFireCacheImpl.java:798)
> > at org.apache.geode.internal.cache.GemFireCacheImpl.create(
> > GemFireCacheImpl.java:783)
> > at org.apache.geode.cache.CacheFactory.create(
> > CacheFactory.java:178)
> > at org.apache.geode.cache.CacheFactory.create(
> > CacheFactory.java:171)
> > at org.apache.g

[GitHub] geode-site pull request #5: GEODE-2975: Change the location of the lucene xs...

[upthewaterspout]

GitHub user upthewaterspout opened a pull request:

https://github.com/apache/geode-site/pull/5

GEODE-2975: Change the location of the lucene xsd

The lucene xsd was not in the correct location on the website.

Also, fixing the website generation so that it copies the xsds to the
output directory.

@joeymcallister @karensmolermiller

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/upthewaterspout/geode-site feature/GEODE-2975

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-site/pull/5.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #5


commit 0f96bc1b520f7442f513e2849be418b62a0b9d47
Author: Dan Smith 
Date:   2017-05-30T17:24:35Z

GEODE-2975: Change the location of the lucene xsd

The lucene xsd was not in the correct location on the website.

Also, fixing the website generation so that it copies the xsds to the
output directory.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

GEODE-2632: Integrated Security performance improvements

[Kirk Lund]

Heads up that I have a fix for "GEODE-2632: Integrated Security performance
improvements" but I'd like to split it into two merges to develop this week.

I'd like to merge the 1st commit to develop today. It touches many of the
client/server tier classes and has passed review, precheckin, full
regression, perf testing and a few conflict resolutions.

2nd commit has the actual changes to Security Service and changes to the
construction of the client Commands and would go in on Thursday or Friday
after I complete review, full regression and perf testing on it. This would
isolate the actual perf improvements to a smaller, more focused commit.

If anyone really wants me to delay the 1st commit, please let me know. I'm
anxious to get it in to avoid handling more merge conflicts on it.

[jira] [Commented] (GEODE-2975) Attributes are not validated in lucene xml configuration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029828#comment-16029828
 ] 

ASF GitHub Bot commented on GEODE-2975:
---

GitHub user upthewaterspout opened a pull request:

https://github.com/apache/geode-site/pull/5

GEODE-2975: Change the location of the lucene xsd

The lucene xsd was not in the correct location on the website.

Also, fixing the website generation so that it copies the xsds to the
output directory.

@joeymcallister @karensmolermiller

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/upthewaterspout/geode-site feature/GEODE-2975

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-site/pull/5.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #5


commit 0f96bc1b520f7442f513e2849be418b62a0b9d47
Author: Dan Smith 
Date:   2017-05-30T17:24:35Z

GEODE-2975: Change the location of the lucene xsd

The lucene xsd was not in the correct location on the website.

Also, fixing the website generation so that it copies the xsds to the
output directory.




> Attributes are not validated in lucene xml configuration
> 
>
> Key: GEODE-2975
> URL: https://issues.apache.org/jira/browse/GEODE-2975
> Project: Geode
>  Issue Type: Bug
>  Components: docs, lucene
>Reporter: Barry Oglesby
> Fix For: 1.2.0
>
>
> No exception is thrown for a lucene xml configuration missing a required 
> attribute.
> No exception is thrown for a lucene xml configuration including an unknown 
> attribute.
> If a {{lucene:field}} element is defined like below, no exception is thrown 
> for the invalid attribute called {{namexx}} and no exceptio is thrown because 
> the required attribute called {{name}} is not included.
> {noformat}
> 
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode issue #541: GEODE-2960 : Trim field parameter values from create lucen...

[nabarunnag]

Github user nabarunnag commented on the issue:

https://github.com/apache/geode/pull/541
  
Working on merging this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2960) gfsh create index should trim from field names

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029832#comment-16029832
 ] 

ASF GitHub Bot commented on GEODE-2960:
---

Github user nabarunnag commented on the issue:

https://github.com/apache/geode/pull/541
  
Working on merging this.


> gfsh create index should trim from field names
> --
>
> Key: GEODE-2960
> URL: https://issues.apache.org/jira/browse/GEODE-2960
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Jason Huynh
>Assignee: Deepak Dixit
>
> When creating an index with specific fields, the parameter expects a comma 
> separated string.  However we are not trimming after splitting the string.  
> So if fields are defined as --field="name, age, height, weight" the indexed 
> fields are actually "name", " age", " height", " weight"
> The command should probably trim the spaces before creating the index.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 59542: GEODE-2974: rename ResultBuilder methods: GemFire -> Geode

[Ken Howe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59542/
---

(Updated May 30, 2017, 5:54 p.m.)


Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Kirk Lund, and 
Patrick Rhomberg.


Changes
---

Reduces scope of the change to ResultBuilder class; the original method names 
have been restored.

Error message text removes mention of "GemFire" or "Geode" to now report: 
"Could not process command due to error." plus the message passed to the 
ResultBuilder


Repository: geode


Description
---

Change GemFire to Geode in method names and message string

This is change to simply correct the Gfsh command error strings where "GemFire" 
appears. With additional work on Gfsh command error handling pending (see 
GEODE-2984), no attempt has been made within the scope of this issue to 
reorganize or otherwise improve Gfsh command error messages.


Diffs (updated)
-

  
geode-core/src/main/java/org/apache/geode/management/internal/cli/result/ResultBuilder.java
 6332540aa4ff6d210ed7f3ba167057de9a0a5023 


Diff: https://reviews.apache.org/r/59542/diff/2/

Changes: https://reviews.apache.org/r/59542/diff/1-2/


Testing (updated)
---

5/30 - precheckin restarted

precheckin is running


Thanks,

Ken Howe

Review Request 59642: GEODE-3000: do not have jetty log at debug level

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59642/
---

Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
Patrick Rhomberg.


Repository: geode


Description
---

GEODE-3000: do not have jetty log at debug level


Diffs
-

  geode-core/src/main/resources/log4j2.xml 
cdb932b5b3b3337aae4a6cde9800ebd5617a0c4d 
  
geode-core/src/test/java/org/apache/geode/management/internal/security/LogNoPasswordTest.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/59642/diff/1/


Testing
---

manual tests and precheckin running


Thanks,

Jinmei Liao

Re: GEODE-2632: Integrated Security performance improvements

[Jared Stewart]

I would also like to merge in "GEODE-2989: Improve mechanism for scanning the 
classpath to find gfsh commands" and "GEODE-2966: Refactor 
LauncherLifecycleCommands” today to avoid further merge conflicts.  If that’s 
too much for 1.2, perhaps we can cut a release branch rather than freezing 
checkins on develop.


> On May 30, 2017, at 10:50 AM, Kirk Lund  wrote:
> 
> Heads up that I have a fix for "GEODE-2632: Integrated Security performance
> improvements" but I'd like to split it into two merges to develop this week.
> 
> I'd like to merge the 1st commit to develop today. It touches many of the
> client/server tier classes and has passed review, precheckin, full
> regression, perf testing and a few conflict resolutions.
> 
> 2nd commit has the actual changes to Security Service and changes to the
> construction of the client Commands and would go in on Thursday or Friday
> after I complete review, full regression and perf testing on it. This would
> isolate the actual perf improvements to a smaller, more focused commit.
> 
> If anyone really wants me to delay the 1st commit, please let me know. I'm
> anxious to get it in to avoid handling more merge conflicts on it.

Re: Review Request 59642: GEODE-3000: do not have jetty log at debug level

[Jared Stewart]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59642/#review176322
---


Ship it!




Ship It!

- Jared Stewart


On May 30, 2017, 6:07 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59642/
> ---
> 
> (Updated May 30, 2017, 6:07 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-3000: do not have jetty log at debug level
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/resources/log4j2.xml 
> cdb932b5b3b3337aae4a6cde9800ebd5617a0c4d 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/security/LogNoPasswordTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59642/diff/1/
> 
> 
> Testing
> ---
> 
> manual tests and precheckin running
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

[jira] [Created] (GEODE-3006) busy login/logout message in the logs when gfsh connects via http

[Jinmei Liao (JIRA)]

Jinmei Liao created GEODE-3006:
--

 Summary: busy login/logout message in the logs when gfsh connects 
via http
 Key: GEODE-3006
 URL: https://issues.apache.org/jira/browse/GEODE-3006
 Project: Geode
  Issue Type: Bug
Reporter: Jinmei Liao


the ping request is constantly login and logout resulting in busy log messages 
in the logs.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 59542: GEODE-2974: rename ResultBuilder methods: GemFire -> Geode

[Jared Stewart]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59542/#review176323
---


Ship it!




Ship It!

- Jared Stewart


On May 30, 2017, 5:54 p.m., Ken Howe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59542/
> ---
> 
> (Updated May 30, 2017, 5:54 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Kirk Lund, 
> and Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Change GemFire to Geode in method names and message string
> 
> This is change to simply correct the Gfsh command error strings where 
> "GemFire" appears. With additional work on Gfsh command error handling 
> pending (see GEODE-2984), no attempt has been made within the scope of this 
> issue to reorganize or otherwise improve Gfsh command error messages.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/result/ResultBuilder.java
>  6332540aa4ff6d210ed7f3ba167057de9a0a5023 
> 
> 
> Diff: https://reviews.apache.org/r/59542/diff/2/
> 
> 
> Testing
> ---
> 
> 5/30 - precheckin restarted
> 
> precheckin is running
> 
> 
> Thanks,
> 
> Ken Howe
> 
>

Review Request 59643: GEODE-3006: reduce the frequency of ping request and reduce the loglevel of login/logout messages

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59643/
---

Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
Patrick Rhomberg.


Summary (updated)
-

GEODE-3006: reduce the frequency of ping request and reduce the loglevel of 
login/logout messages


Repository: geode


Description (updated)
---

disregard the diff for log4j2.xml changes, these are from the changeset of 
another review request.


Testing (updated)
---

precheckin running


Thanks,

Jinmei Liao

Re: Review Request 59542: GEODE-2974: rename ResultBuilder methods: GemFire -> Geode

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59542/#review176324
---


Ship it!




Ship It!

- Jinmei Liao


On May 30, 2017, 5:54 p.m., Ken Howe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59542/
> ---
> 
> (Updated May 30, 2017, 5:54 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Kirk Lund, 
> and Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Change GemFire to Geode in method names and message string
> 
> This is change to simply correct the Gfsh command error strings where 
> "GemFire" appears. With additional work on Gfsh command error handling 
> pending (see GEODE-2984), no attempt has been made within the scope of this 
> issue to reorganize or otherwise improve Gfsh command error messages.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/result/ResultBuilder.java
>  6332540aa4ff6d210ed7f3ba167057de9a0a5023 
> 
> 
> Diff: https://reviews.apache.org/r/59542/diff/2/
> 
> 
> Testing
> ---
> 
> 5/30 - precheckin restarted
> 
> precheckin is running
> 
> 
> Thanks,
> 
> Ken Howe
> 
>

[jira] [Created] (GEODE-3007) Simplify support for custom GFSH commands

[Jared Stewart (JIRA)]

Jared Stewart created GEODE-3007:


 Summary: Simplify support for custom GFSH commands
 Key: GEODE-3007
 URL: https://issues.apache.org/jira/browse/GEODE-3007
 Project: Geode
  Issue Type: Improvement
  Components: gfsh
Reporter: Jared Stewart


Geode currently supports three ways to load GFSH commands: 

1. Scan the classpath for commands in 
"org.apache.geode.management.internal.cli.commands”
2. Scan the classpath for commands in a package specified by a user via the 
“user-command-packages” system property. 
3. Scan the classpath for commands registered in files inside META-INF.services 
(e.g. 
"geode-core/src/test/resources/META-INF/services/org.springframework.shell.core.CommandMarker”)
 

After the improvements made by GEODE-2989, there is no reason to require a user 
to specify the location of their custom commands via one of these mechanisms.  
Instead, we should simply scan the entire classpath for any classes 
implementing CommandMarker (regardless of whatever packages they live in).  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-2818) add alias to any command's options that involves "group", "member", "jar"

[Emily Yeh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Emily Yeh resolved GEODE-2818.
--
Resolution: Fixed

> add alias to any command's options that involves "group", "member", "jar"
> -
>
> Key: GEODE-2818
> URL: https://issues.apache.org/jira/browse/GEODE-2818
> Project: Geode
>  Issue Type: New Feature
>  Components: docs, gfsh
>Reporter: Jinmei Liao
>Assignee: Emily Yeh
>
> Or anything that would have confusion about if we are going to use singular 
> or plural at all.
> 1) add alias for those options
> 2) make sure it parameter type is an array type, some method only accepts a 
> string and split it inside the command.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-site pull request #6: Adding an assemble task for travis to invoke

[upthewaterspout]

GitHub user upthewaterspout opened a pull request:

https://github.com/apache/geode-site/pull/6

Adding an assemble task for travis to invoke

Travis always invokes assemble for a gradle project, apparently.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/upthewaterspout/geode-site feature/fix_travis

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-site/pull/6.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #6


commit cd837fabec838f5cdd794bc02696288069a0969f
Author: Dan Smith 
Date:   2017-05-30T18:22:59Z

Adding an assemble task for travis to invoke

Travis always invokes assemble for a gradle project, apparently.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-site issue #6: Adding an assemble task for travis to invoke

[joeymcallister]

Github user joeymcallister commented on the issue:

https://github.com/apache/geode-site/pull/6
  
+1 Thanks, @upthewaterspout!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 59542: GEODE-2974: rename ResultBuilder methods: GemFire -> Geode

[Emily Yeh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59542/#review176329
---


Ship it!




Ship It!

- Emily Yeh


On May 30, 2017, 5:54 p.m., Ken Howe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59542/
> ---
> 
> (Updated May 30, 2017, 5:54 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Kirk Lund, 
> and Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Change GemFire to Geode in method names and message string
> 
> This is change to simply correct the Gfsh command error strings where 
> "GemFire" appears. With additional work on Gfsh command error handling 
> pending (see GEODE-2984), no attempt has been made within the scope of this 
> issue to reorganize or otherwise improve Gfsh command error messages.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/result/ResultBuilder.java
>  6332540aa4ff6d210ed7f3ba167057de9a0a5023 
> 
> 
> Diff: https://reviews.apache.org/r/59542/diff/2/
> 
> 
> Testing
> ---
> 
> 5/30 - precheckin restarted
> 
> precheckin is running
> 
> 
> Thanks,
> 
> Ken Howe
> 
>

[GitHub] geode issue #543: GEODE-2957 gfsh create lucene index "null" becomes "DEFAUL...

[nabarunnag]

Github user nabarunnag commented on the issue:

https://github.com/apache/geode/pull/543
  
I will be merging this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2957) null used as a default parameter when specifying analyzers

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029914#comment-16029914
 ] 

ASF GitHub Bot commented on GEODE-2957:
---

Github user nabarunnag commented on the issue:

https://github.com/apache/geode/pull/543
  
I will be merging this.


> null used as a default parameter when specifying analyzers
> --
>
> Key: GEODE-2957
> URL: https://issues.apache.org/jira/browse/GEODE-2957
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Jason Huynh
>Assignee: David Anuta
> Fix For: 1.2.0
>
>
> null seems to be the way to specify using the default 
> StandardKeywordAnalyzer. This can be used when specifying a long list of 
> field/analyzers.  
> So the line may look like 
> --analyzers="null,SomeAnalyzer,null,null,SomeAnalyzer}
>  We should probably change that to default or some other keyword.  null seems 
> a bit confusing.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode issue #547: GEODE-2957: Create Lucene index analyzer help updated to i...

[nabarunnag]

Github user nabarunnag commented on the issue:

https://github.com/apache/geode/pull/547
  
I will be merging this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2957) null used as a default parameter when specifying analyzers

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029915#comment-16029915
 ] 

ASF GitHub Bot commented on GEODE-2957:
---

Github user nabarunnag commented on the issue:

https://github.com/apache/geode/pull/547
  
I will be merging this.


> null used as a default parameter when specifying analyzers
> --
>
> Key: GEODE-2957
> URL: https://issues.apache.org/jira/browse/GEODE-2957
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Jason Huynh
>Assignee: David Anuta
> Fix For: 1.2.0
>
>
> null seems to be the way to specify using the default 
> StandardKeywordAnalyzer. This can be used when specifying a long list of 
> field/analyzers.  
> So the line may look like 
> --analyzers="null,SomeAnalyzer,null,null,SomeAnalyzer}
>  We should probably change that to default or some other keyword.  null seems 
> a bit confusing.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #541: GEODE-2960 : Trim field parameter values from creat...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/541


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2960) gfsh create index should trim from field names

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029937#comment-16029937
 ] 

ASF GitHub Bot commented on GEODE-2960:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/541


> gfsh create index should trim from field names
> --
>
> Key: GEODE-2960
> URL: https://issues.apache.org/jira/browse/GEODE-2960
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Jason Huynh
>Assignee: Deepak Dixit
>
> When creating an index with specific fields, the parameter expects a comma 
> separated string.  However we are not trimming after splitting the string.  
> So if fields are defined as --field="name, age, height, weight" the indexed 
> fields are actually "name", " age", " height", " weight"
> The command should probably trim the spaces before creating the index.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2960) gfsh create index should trim from field names

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029935#comment-16029935
 ] 

ASF subversion and git services commented on GEODE-2960:


Commit d50489c6c526ab996c4ff8883283a6e8f7a228a1 in geode's branch 
refs/heads/develop from [~deepakddixit]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=d50489c ]

GEODE-2960 : Trim field parameter values from create lucene index.

* Added logic to trim leading and trailing spaces from values provided 
against 'field'.
* Modified existing test case to verify changes.

This closes #541


> gfsh create index should trim from field names
> --
>
> Key: GEODE-2960
> URL: https://issues.apache.org/jira/browse/GEODE-2960
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Jason Huynh
>Assignee: Deepak Dixit
>
> When creating an index with specific fields, the parameter expects a comma 
> separated string.  However we are not trimming after splitting the string.  
> So if fields are defined as --field="name, age, height, weight" the indexed 
> fields are actually "name", " age", " height", " weight"
> The command should probably trim the spaces before creating the index.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-2977) commands should take string[] as the value for --group and --memberId(--name) whenever possible

[Emily Yeh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Emily Yeh resolved GEODE-2977.
--
Resolution: Fixed

> commands should take string[] as the value for --group and --memberId(--name) 
> whenever possible
> ---
>
> Key: GEODE-2977
> URL: https://issues.apache.org/jira/browse/GEODE-2977
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Reporter: Jinmei Liao
>Assignee: Emily Yeh
>
> some commands takes string[], and some takes only String and split them 
> manually. We should make this consistent and the help message would be a lot 
> clearer if taking string[].



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2957) null used as a default parameter when specifying analyzers

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029964#comment-16029964
 ] 

ASF subversion and git services commented on GEODE-2957:


Commit 96665fafbcc06948b7152ca9ad7344ab938f27ff in geode's branch 
refs/heads/develop from [~DivineEnder]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=96665fa ]

GEODE-2957: Create Lucene index analyzer help updated to include keyword DEFAULT


> null used as a default parameter when specifying analyzers
> --
>
> Key: GEODE-2957
> URL: https://issues.apache.org/jira/browse/GEODE-2957
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Jason Huynh
>Assignee: David Anuta
> Fix For: 1.2.0
>
>
> null seems to be the way to specify using the default 
> StandardKeywordAnalyzer. This can be used when specifying a long list of 
> field/analyzers.  
> So the line may look like 
> --analyzers="null,SomeAnalyzer,null,null,SomeAnalyzer}
>  We should probably change that to default or some other keyword.  null seems 
> a bit confusing.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2957) null used as a default parameter when specifying analyzers

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029969#comment-16029969
 ] 

ASF subversion and git services commented on GEODE-2957:


Commit 5b2cdf8c1499c8fdc1f76ad9351c30876f6623b2 in geode's branch 
refs/heads/develop from [~nnag]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=5b2cdf8 ]

Revert "GEODE-2957: Create Lucene index analyzer help updated to include 
keyword DEFAULT"

This reverts commit 96665fafbcc06948b7152ca9ad7344ab938f27ff.


> null used as a default parameter when specifying analyzers
> --
>
> Key: GEODE-2957
> URL: https://issues.apache.org/jira/browse/GEODE-2957
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Jason Huynh
>Assignee: David Anuta
> Fix For: 1.2.0
>
>
> null seems to be the way to specify using the default 
> StandardKeywordAnalyzer. This can be used when specifying a long list of 
> field/analyzers.  
> So the line may look like 
> --analyzers="null,SomeAnalyzer,null,null,SomeAnalyzer}
>  We should probably change that to default or some other keyword.  null seems 
> a bit confusing.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #547: GEODE-2957: Create Lucene index analyzer help updat...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/547


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2957) null used as a default parameter when specifying analyzers

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029985#comment-16029985
 ] 

ASF GitHub Bot commented on GEODE-2957:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/547


> null used as a default parameter when specifying analyzers
> --
>
> Key: GEODE-2957
> URL: https://issues.apache.org/jira/browse/GEODE-2957
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Jason Huynh
>Assignee: David Anuta
> Fix For: 1.2.0
>
>
> null seems to be the way to specify using the default 
> StandardKeywordAnalyzer. This can be used when specifying a long list of 
> field/analyzers.  
> So the line may look like 
> --analyzers="null,SomeAnalyzer,null,null,SomeAnalyzer}
>  We should probably change that to default or some other keyword.  null seems 
> a bit confusing.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-3005) A developer can create a Region with Partition Resolution using Java API

[Fred Krone (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fred Krone updated GEODE-3005:
--
Description: 
A user should be able to set partition by prefix programmatically when creating 
a partitioned region.

This can only be done when creating a Region type PARTITION

Acceptance: 
Partitioned region can be created using new 'partition by prefix' attributes 
(on/off, delimiter) 
Only String keys work -- all other keys throw an error
Providing a key with the correct delimiter routes the entry to the correct node
Providing a key with no delimiter throws an error


  was:
A user should be able to set partition by prefix programmatically when creating 
a partitioned region.

This can only be done when creating a Region type PARTITION


> A developer can create a Region with Partition Resolution using Java API
> 
>
> Key: GEODE-3005
> URL: https://issues.apache.org/jira/browse/GEODE-3005
> Project: Geode
>  Issue Type: Wish
>  Components: regions
>Reporter: Fred Krone
>Assignee: Fred Krone
>
> A user should be able to set partition by prefix programmatically when 
> creating a partitioned region.
> This can only be done when creating a Region type PARTITION
> Acceptance: 
> Partitioned region can be created using new 'partition by prefix' attributes 
> (on/off, delimiter) 
> Only String keys work -- all other keys throw an error
> Providing a key with the correct delimiter routes the entry to the correct 
> node
> Providing a key with no delimiter throws an error



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-3008) Implement PartitionByPrefix Partition Resolver

[Fred Krone (JIRA)]

Fred Krone created GEODE-3008:
-

 Summary: Implement PartitionByPrefix Partition Resolver
 Key: GEODE-3008
 URL: https://issues.apache.org/jira/browse/GEODE-3008
 Project: Geode
  Issue Type: Sub-task
  Components: regions
Reporter: Fred Krone


This is the implementation of PartitionResolver



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-3009) Implement key String parser

[Fred Krone (JIRA)]

Fred Krone created GEODE-3009:
-

 Summary: Implement key String parser
 Key: GEODE-3009
 URL: https://issues.apache.org/jira/browse/GEODE-3009
 Project: Geode
  Issue Type: Sub-task
Reporter: Fred Krone


Parse the key according to the configured delimiter.
Route the Entry correctly.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-3010) Update PartitionAttributes for new PartitionByPrefix settings

[Fred Krone (JIRA)]

Fred Krone created GEODE-3010:
-

 Summary: Update PartitionAttributes for new PartitionByPrefix 
settings
 Key: GEODE-3010
 URL: https://issues.apache.org/jira/browse/GEODE-3010
 Project: Geode
  Issue Type: Sub-task
Reporter: Fred Krone


Need to add the fields and gettors and settors

Do the same on PartitionAttributesFactory



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2957) null used as a default parameter when specifying analyzers

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029983#comment-16029983
 ] 

ASF subversion and git services commented on GEODE-2957:


Commit 1ee19c759c4bdd4133f7dcf7df648f3437234a7d in geode's branch 
refs/heads/develop from [~DivineEnder]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=1ee19c7 ]

GEODE-2957: Create Lucene index analyzer help updated to include keyword DEFAULT

This closes #547


> null used as a default parameter when specifying analyzers
> --
>
> Key: GEODE-2957
> URL: https://issues.apache.org/jira/browse/GEODE-2957
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Jason Huynh
>Assignee: David Anuta
> Fix For: 1.2.0
>
>
> null seems to be the way to specify using the default 
> StandardKeywordAnalyzer. This can be used when specifying a long list of 
> field/analyzers.  
> So the line may look like 
> --analyzers="null,SomeAnalyzer,null,null,SomeAnalyzer}
>  We should probably change that to default or some other keyword.  null seems 
> a bit confusing.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #546: GEODE-2818: add alias to any command's options that...

[YehEmily]

Github user YehEmily closed the pull request at:

https://github.com/apache/geode/pull/546


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2818) add alias to any command's options that involves "group", "member", "jar"

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030039#comment-16030039
 ] 

ASF GitHub Bot commented on GEODE-2818:
---

Github user YehEmily closed the pull request at:

https://github.com/apache/geode/pull/546


> add alias to any command's options that involves "group", "member", "jar"
> -
>
> Key: GEODE-2818
> URL: https://issues.apache.org/jira/browse/GEODE-2818
> Project: Geode
>  Issue Type: New Feature
>  Components: docs, gfsh
>Reporter: Jinmei Liao
>Assignee: Emily Yeh
>
> Or anything that would have confusion about if we are going to use singular 
> or plural at all.
> 1) add alias for those options
> 2) make sure it parameter type is an array type, some method only accepts a 
> string and split it inside the command.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode issue #548: GEODE-2818: add alias to any command's options that involv...

[YehEmily]

Github user YehEmily commented on the issue:

https://github.com/apache/geode/pull/548
  
Precheckin in progress!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #548: GEODE-2818: add alias to any command's options that...

[YehEmily]

GitHub user YehEmily opened a pull request:

https://github.com/apache/geode/pull/548

GEODE-2818: add alias to any command's options that involves "group",…

… "member", "jar" and replace CliString variables with GROUP, MEMBER, 
JAR, etc.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/YehEmily/geode GEODE-2818

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/548.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #548


commit 96df68ea155e63fa80be8f0a4be2f7b7e0cc6363
Author: YehEmily 
Date:   2017-05-30T17:56:48Z

GEODE-2818: add alias to any command's options that involves "group", 
"member", "jar" and replace CliString variables with GROUP, MEMBER, JAR, etc.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2818) add alias to any command's options that involves "group", "member", "jar"

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030044#comment-16030044
 ] 

ASF GitHub Bot commented on GEODE-2818:
---

Github user YehEmily commented on the issue:

https://github.com/apache/geode/pull/548
  
Precheckin in progress!


> add alias to any command's options that involves "group", "member", "jar"
> -
>
> Key: GEODE-2818
> URL: https://issues.apache.org/jira/browse/GEODE-2818
> Project: Geode
>  Issue Type: New Feature
>  Components: docs, gfsh
>Reporter: Jinmei Liao
>Assignee: Emily Yeh
>
> Or anything that would have confusion about if we are going to use singular 
> or plural at all.
> 1) add alias for those options
> 2) make sure it parameter type is an array type, some method only accepts a 
> string and split it inside the command.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2818) add alias to any command's options that involves "group", "member", "jar"

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030043#comment-16030043
 ] 

ASF GitHub Bot commented on GEODE-2818:
---

GitHub user YehEmily opened a pull request:

https://github.com/apache/geode/pull/548

GEODE-2818: add alias to any command's options that involves "group",…

… "member", "jar" and replace CliString variables with GROUP, MEMBER, JAR, 
etc.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/YehEmily/geode GEODE-2818

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/548.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #548


commit 96df68ea155e63fa80be8f0a4be2f7b7e0cc6363
Author: YehEmily 
Date:   2017-05-30T17:56:48Z

GEODE-2818: add alias to any command's options that involves "group", 
"member", "jar" and replace CliString variables with GROUP, MEMBER, JAR, etc.




> add alias to any command's options that involves "group", "member", "jar"
> -
>
> Key: GEODE-2818
> URL: https://issues.apache.org/jira/browse/GEODE-2818
> Project: Geode
>  Issue Type: New Feature
>  Components: docs, gfsh
>Reporter: Jinmei Liao
>Assignee: Emily Yeh
>
> Or anything that would have confusion about if we are going to use singular 
> or plural at all.
> 1) add alias for those options
> 2) make sure it parameter type is an array type, some method only accepts a 
> string and split it inside the command.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #549: GEODE-2203: gfsh status locator/server - Command no...

[YehEmily]

GitHub user YehEmily opened a pull request:

https://github.com/apache/geode/pull/549

GEODE-2203: gfsh status locator/server - Command now gives more descr…

…iptive output on empty parameter

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/YehEmily/geode GEODE-2203

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/549.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #549


commit 784ded407a0d16dc7fbf3c6693d0e1a8443fdd44
Author: YehEmily 
Date:   2017-05-26T22:54:46Z

GEODE-2203: gfsh status locator/server - Command now gives more descriptive 
output on empty parameter




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #549: GEODE-2203: gfsh status locator/server - Command now gives...

[YehEmily]

Github user YehEmily commented on the issue:

https://github.com/apache/geode/pull/549
  
Precheckin pending!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2203) gfsh status locator/server - Give more descriptive output on empty parameter

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030065#comment-16030065
 ] 

ASF GitHub Bot commented on GEODE-2203:
---

Github user YehEmily commented on the issue:

https://github.com/apache/geode/pull/549
  
Precheckin pending!


> gfsh status locator/server - Give more descriptive output on empty parameter
> 
>
> Key: GEODE-2203
> URL: https://issues.apache.org/jira/browse/GEODE-2203
> Project: Geode
>  Issue Type: Improvement
>  Components: gfsh
>Reporter: Alyssa Kim
>Assignee: Emily Yeh
>Priority: Minor
>  Labels: StatusLocatorCommand, StatusServerCommand, gfsh, status
>
> Currently, executing some status commands in gfsh without valid parameters 
> gives a vague explanation/output that might be misleading. Although we have 
> help  for usage description, displaying 'null' as an output 
> might not be the best idea.
> Current Result
> {code}
> gfsh>status locator
> null
> {code}
> {code}
> gfsh>status server
> Server in 
> C:\Users\XXX\git\incubator-geode\geode-assembly\build\install\apache-geode\bin
>  on null is currently not responding.
> {code}
> Improvement
> {code}
> gfsh>status locator
> SYNTAX
> status locator [--name=value] [--host=value] [--port=value] [--pid=value]
> Use help status locator to display detailed usage information
> {code}
> {code}
> gfsh>status server
> SYNTAX
> status server [--name=value] [--pid=value] [--dir=value]
> Use help status server to display detailed usage information
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2203) gfsh status locator/server - Give more descriptive output on empty parameter

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030064#comment-16030064
 ] 

ASF GitHub Bot commented on GEODE-2203:
---

GitHub user YehEmily opened a pull request:

https://github.com/apache/geode/pull/549

GEODE-2203: gfsh status locator/server - Command now gives more descr…

…iptive output on empty parameter

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/YehEmily/geode GEODE-2203

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/549.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #549


commit 784ded407a0d16dc7fbf3c6693d0e1a8443fdd44
Author: YehEmily 
Date:   2017-05-26T22:54:46Z

GEODE-2203: gfsh status locator/server - Command now gives more descriptive 
output on empty parameter




> gfsh status locator/server - Give more descriptive output on empty parameter
> 
>
> Key: GEODE-2203
> URL: https://issues.apache.org/jira/browse/GEODE-2203
> Project: Geode
>  Issue Type: Improvement
>  Components: gfsh
>Reporter: Alyssa Kim
>Assignee: Emily Yeh
>Priority: Minor
>  Labels: StatusLocatorCommand, StatusServerCommand, gfsh, status
>
> Currently, executing some status commands in gfsh without valid parameters 
> gives a vague explanation/output that might be misleading. Although we have 
> help  for usage description, displaying 'null' as an output 
> might not be the best idea.
> Current Result
> {code}
> gfsh>status locator
> null
> {code}
> {code}
> gfsh>status server
> Server in 
> C:\Users\XXX\git\incubator-geode\geode-assembly\build\install\apache-geode\bin
>  on null is currently not responding.
> {code}
> Improvement
> {code}
> gfsh>status locator
> SYNTAX
> status locator [--name=value] [--host=value] [--port=value] [--pid=value]
> Use help status locator to display detailed usage information
> {code}
> {code}
> gfsh>status server
> SYNTAX
> status server [--name=value] [--pid=value] [--dir=value]
> Use help status server to display detailed usage information
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2941) Pulse documentation is outdated

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030086#comment-16030086
 ] 

ASF subversion and git services commented on GEODE-2941:


Commit fa808acd41caa9cb76b1a5c66dd304925f31c0a2 in geode's branch 
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=fa808ac ]

GEODE-2941 Update Pulse documentation: logging info


> Pulse documentation is outdated
> ---
>
> Key: GEODE-2941
> URL: https://issues.apache.org/jira/browse/GEODE-2941
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Jinmei Liao
>Assignee: Dave Barnes
> Fix For: 1.2.0
>
>
> the pulse documentation:
> http://geode.apache.org/docs/guide/11/tools_modules/pulse/quickstart.html#topic_523F6DE33FE54307BBE8F83BB7D9355D
> is no longer accurate anymore.
> 1. jmxUsername and jmxpassword no long applies
> 2. the logging configurations has changed too.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #550: GEODE-3002 Clarify __REGION_VALUE_FIELD in Lucene d...

[karensmolermiller]

GitHub user karensmolermiller opened a pull request:

https://github.com/apache/geode/pull/550

GEODE-3002 Clarify __REGION_VALUE_FIELD in Lucene docs

 Review please: @nabarunnag @upthewaterspout @jhuynh1 @DevineEnder 
@dihardman @boglesby @joeymcallister  @davebarnes97 


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karensmolermiller/geode feature/GEODE-3002

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/550.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #550


commit 4c0c86a25e788444b510f26aa1c5c8e3837ef32d
Author: Karen Miller 
Date:   2017-05-30T20:39:00Z

GEODE-3002 Clarify __REGION_VALUE_FIELD in Lucene docs




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-3002) Improve doc of (Lucene) __REGION_VALUE_FIELD

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030094#comment-16030094
 ] 

ASF GitHub Bot commented on GEODE-3002:
---

GitHub user karensmolermiller opened a pull request:

https://github.com/apache/geode/pull/550

GEODE-3002 Clarify __REGION_VALUE_FIELD in Lucene docs

 Review please: @nabarunnag @upthewaterspout @jhuynh1 @DevineEnder 
@dihardman @boglesby @joeymcallister  @davebarnes97 


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karensmolermiller/geode feature/GEODE-3002

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/550.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #550


commit 4c0c86a25e788444b510f26aa1c5c8e3837ef32d
Author: Karen Miller 
Date:   2017-05-30T20:39:00Z

GEODE-3002 Clarify __REGION_VALUE_FIELD in Lucene docs




> Improve doc of (Lucene) __REGION_VALUE_FIELD
> 
>
> Key: GEODE-3002
> URL: https://issues.apache.org/jira/browse/GEODE-3002
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>Priority: Minor
>
> The original description of {{__REGION_VALUE_FIELD}} is not quite right. In 
> addition, there is an example gfsh command using this value that is wrong.  
> It is in the {{gfsh create lucene index}} command reference page.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2952) gfsh doesn't support exact match lucene queries

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030111#comment-16030111
 ] 

ASF GitHub Bot commented on GEODE-2952:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/545


> gfsh doesn't support exact match lucene queries
> ---
>
> Key: GEODE-2952
> URL: https://issues.apache.org/jira/browse/GEODE-2952
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Barry Oglesby
>Assignee: David Anuta
> Fix For: 1.2.0
>
>
> This command:
> {noformat}
> gfsh>search lucene --name=index --region=data 
> --defaultField=Resolution_Description --queryStrings='Police Dept'
> {noformat}
> Runs this lucene query:
> {noformat}
> Resolution_Description:police Resolution_Description:dept
> {noformat}
> I also tried this command which ran the same lucene query as above:
> {noformat}
> gfsh>search lucene --name=index --region=data 
> --defaultField=Resolution_Description --queryStrings='\"Police Dept\"'
> {noformat}
> The java API supports exact match queries with "" around the queryString. 
> Doing this causes this lucene query to be run:
> {noformat}
> Resolution_Description:"police dept"
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #545: GEODE-2952 document quoting of exact match Lucene q...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/545


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2952) gfsh doesn't support exact match lucene queries

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030110#comment-16030110
 ] 

ASF subversion and git services commented on GEODE-2952:


Commit c08d70dd4695dbbad17f86fa4227a13497ab0b08 in geode's branch 
refs/heads/develop from [~karensmolermiller]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=c08d70d ]

GEODE-2952 document quoting of exact match Lucene queries

This closes #545


> gfsh doesn't support exact match lucene queries
> ---
>
> Key: GEODE-2952
> URL: https://issues.apache.org/jira/browse/GEODE-2952
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Barry Oglesby
>Assignee: David Anuta
> Fix For: 1.2.0
>
>
> This command:
> {noformat}
> gfsh>search lucene --name=index --region=data 
> --defaultField=Resolution_Description --queryStrings='Police Dept'
> {noformat}
> Runs this lucene query:
> {noformat}
> Resolution_Description:police Resolution_Description:dept
> {noformat}
> I also tried this command which ran the same lucene query as above:
> {noformat}
> gfsh>search lucene --name=index --region=data 
> --defaultField=Resolution_Description --queryStrings='\"Police Dept\"'
> {noformat}
> The java API supports exact match queries with "" around the queryString. 
> Doing this causes this lucene query to be run:
> {noformat}
> Resolution_Description:"police dept"
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (GEODE-2920) secure disk-store as a resource

[Kenneth Howe (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kenneth Howe reassigned GEODE-2920:
---

Assignee: Kenneth Howe

> secure disk-store as a resource
> ---
>
> Key: GEODE-2920
> URL: https://issues.apache.org/jira/browse/GEODE-2920
> Project: Geode
>  Issue Type: Sub-task
>  Components: security
>Reporter: Swapnil Bawaskar
>Assignee: Kenneth Howe
>
> Treat DISK as a CLUSTER resource so that administrators can control the 
> ability to manage diskstores/create regions that will write to disk stores.
> Only a user with CLUSTER:MANAGE:DISK should be able to run the following gfsh 
> commands:
> {noformat}
> create disk-store
> alter disk-store
> compact disk-store
> destroy disk-store
> revoke missing-disk-store
> {noformat}
> And the following JMX bean methods:
> {noformat}
> DiskStoreMXBean.forceCompaction
> DiskStoreMXBean.flush
> DiskStoreMXBean.forceRoll
> DiskStoreMXBean.setDiskUsageCriticalPercentage
> DiskStoreMXBean.setDiskUsageWarningPercentage
> DistributedSystemMXBean.revokeMissingDiskStores
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode issue #543: GEODE-2957 gfsh create lucene index "null" becomes "DEFAUL...

[DivineEnder]

Github user DivineEnder commented on the issue:

https://github.com/apache/geode/pull/543
  
Looks good 👍 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2957) null used as a default parameter when specifying analyzers

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030135#comment-16030135
 ] 

ASF GitHub Bot commented on GEODE-2957:
---

Github user DivineEnder commented on the issue:

https://github.com/apache/geode/pull/543
  
Looks good 👍 


> null used as a default parameter when specifying analyzers
> --
>
> Key: GEODE-2957
> URL: https://issues.apache.org/jira/browse/GEODE-2957
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Jason Huynh
>Assignee: David Anuta
> Fix For: 1.2.0
>
>
> null seems to be the way to specify using the default 
> StandardKeywordAnalyzer. This can be used when specifying a long list of 
> field/analyzers.  
> So the line may look like 
> --analyzers="null,SomeAnalyzer,null,null,SomeAnalyzer}
>  We should probably change that to default or some other keyword.  null seems 
> a bit confusing.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2975) Attributes are not validated in lucene xml configuration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030138#comment-16030138
 ] 

ASF GitHub Bot commented on GEODE-2975:
---

Github user upthewaterspout commented on the issue:

https://github.com/apache/geode/pull/538
  
@boglesby - I see the problem with lucene:indexxx. It looks like in 
cache-1.0.xsd, which specify this in order to allow other schemas (like 
lucene.xsd) to extend region with additional elements:

`
  
`

Unfortunately, using 'lax' instead of 'strict' here means that we don't 
validate the new xsd as strictly - additional elements are ignored, etc.

I'm worried about the impact of changing this validation. I think the thing 
to do maybe is just to give a little better error message in our java code and 
call it a day.


> Attributes are not validated in lucene xml configuration
> 
>
> Key: GEODE-2975
> URL: https://issues.apache.org/jira/browse/GEODE-2975
> Project: Geode
>  Issue Type: Bug
>  Components: docs, lucene
>Reporter: Barry Oglesby
> Fix For: 1.2.0
>
>
> No exception is thrown for a lucene xml configuration missing a required 
> attribute.
> No exception is thrown for a lucene xml configuration including an unknown 
> attribute.
> If a {{lucene:field}} element is defined like below, no exception is thrown 
> for the invalid attribute called {{namexx}} and no exceptio is thrown because 
> the required attribute called {{name}} is not included.
> {noformat}
> 
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode issue #538: GEODE-2975: Change the location of the lucene xsd

[upthewaterspout]

Github user upthewaterspout commented on the issue:

https://github.com/apache/geode/pull/538
  
@boglesby - I see the problem with lucene:indexxx. It looks like in 
cache-1.0.xsd, which specify this in order to allow other schemas (like 
lucene.xsd) to extend region with additional elements:

`
  
`

Unfortunately, using 'lax' instead of 'strict' here means that we don't 
validate the new xsd as strictly - additional elements are ignored, etc.

I'm worried about the impact of changing this validation. I think the thing 
to do maybe is just to give a little better error message in our java code and 
call it a day.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Resolved] (GEODE-2952) gfsh doesn't support exact match lucene queries

[Karen Smoler Miller (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karen Smoler Miller resolved GEODE-2952.

Resolution: Fixed

> gfsh doesn't support exact match lucene queries
> ---
>
> Key: GEODE-2952
> URL: https://issues.apache.org/jira/browse/GEODE-2952
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Barry Oglesby
>Assignee: David Anuta
> Fix For: 1.2.0
>
>
> This command:
> {noformat}
> gfsh>search lucene --name=index --region=data 
> --defaultField=Resolution_Description --queryStrings='Police Dept'
> {noformat}
> Runs this lucene query:
> {noformat}
> Resolution_Description:police Resolution_Description:dept
> {noformat}
> I also tried this command which ran the same lucene query as above:
> {noformat}
> gfsh>search lucene --name=index --region=data 
> --defaultField=Resolution_Description --queryStrings='\"Police Dept\"'
> {noformat}
> The java API supports exact match queries with "" around the queryString. 
> Doing this causes this lucene query to be run:
> {noformat}
> Resolution_Description:"police dept"
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode issue #550: GEODE-3002 Clarify __REGION_VALUE_FIELD in Lucene docs

[dihardman]

Github user dihardman commented on the issue:

https://github.com/apache/geode/pull/550
  
+1, thanks the new description is more accurate.

On Tue, May 30, 2017 at 2:12 PM, Dave Barnes 
wrote:

> *@davebarnes97* approved this pull request.
>
> +! LGTM
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> , or 
mute
> the thread
> 

> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #550: GEODE-3002 Clarify __REGION_VALUE_FIELD in Lucene d...

[joeymcallister]

Github user joeymcallister commented on a diff in the pull request:

https://github.com/apache/geode/pull/550#discussion_r119217398
  
--- Diff: geode-docs/tools_modules/gfsh/command-pages/search.html.md.erb ---
@@ -62,12 +62,12 @@ search lucene --name=value --region=value 
--queryStrings=value --defaultField=va
 
 
 ‑‐queryStrings
-Required. Query string to search the lucene index.
+Required. Query string to search the lucene index. Use 
__REGION_VALUE_FIELD as the field name within the query string 
when the field is a primitive value.
--- End diff --

Is there a contextual reason to use "lucene index" here, rather than 
"Lucene" index with a capital L?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-3002) Improve doc of (Lucene) __REGION_VALUE_FIELD

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030142#comment-16030142
 ] 

ASF GitHub Bot commented on GEODE-3002:
---

Github user dihardman commented on the issue:

https://github.com/apache/geode/pull/550
  
+1, thanks the new description is more accurate.

On Tue, May 30, 2017 at 2:12 PM, Dave Barnes 
wrote:

> *@davebarnes97* approved this pull request.
>
> +! LGTM
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> , or 
mute
> the thread
> 

> .
>



> Improve doc of (Lucene) __REGION_VALUE_FIELD
> 
>
> Key: GEODE-3002
> URL: https://issues.apache.org/jira/browse/GEODE-3002
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>Priority: Minor
>
> The original description of {{__REGION_VALUE_FIELD}} is not quite right. In 
> addition, there is an example gfsh command using this value that is wrong.  
> It is in the {{gfsh create lucene index}} command reference page.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-3002) Improve doc of (Lucene) __REGION_VALUE_FIELD

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030145#comment-16030145
 ] 

ASF GitHub Bot commented on GEODE-3002:
---

Github user joeymcallister commented on a diff in the pull request:

https://github.com/apache/geode/pull/550#discussion_r119217398
  
--- Diff: geode-docs/tools_modules/gfsh/command-pages/search.html.md.erb ---
@@ -62,12 +62,12 @@ search lucene --name=value --region=value 
--queryStrings=value --defaultField=va
 
 
 ‑‐queryStrings
-Required. Query string to search the lucene index.
+Required. Query string to search the lucene index. Use 
__REGION_VALUE_FIELD as the field name within the query string 
when the field is a primitive value.
--- End diff --

Is there a contextual reason to use "lucene index" here, rather than 
"Lucene" index with a capital L?


> Improve doc of (Lucene) __REGION_VALUE_FIELD
> 
>
> Key: GEODE-3002
> URL: https://issues.apache.org/jira/browse/GEODE-3002
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>Priority: Minor
>
> The original description of {{__REGION_VALUE_FIELD}} is not quite right. In 
> addition, there is an example gfsh command using this value that is wrong.  
> It is in the {{gfsh create lucene index}} command reference page.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2975) Attributes are not validated in lucene xml configuration

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030150#comment-16030150
 ] 

ASF subversion and git services commented on GEODE-2975:


Commit a67bddc19f0d126c0d87b679bb2d698dfa0faea0 in geode's branch 
refs/heads/feature/GEODE-2975 from [~upthewaterspout]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=a67bddc ]

GEODE-2975 Additional tests and validation of lucene elements

Tests and validation for cases where lucene elements show up in the
wrong place, which we were unable to catch with the xsd validation.


> Attributes are not validated in lucene xml configuration
> 
>
> Key: GEODE-2975
> URL: https://issues.apache.org/jira/browse/GEODE-2975
> Project: Geode
>  Issue Type: Bug
>  Components: docs, lucene
>Reporter: Barry Oglesby
> Fix For: 1.2.0
>
>
> No exception is thrown for a lucene xml configuration missing a required 
> attribute.
> No exception is thrown for a lucene xml configuration including an unknown 
> attribute.
> If a {{lucene:field}} element is defined like below, no exception is thrown 
> for the invalid attribute called {{namexx}} and no exceptio is thrown because 
> the required attribute called {{name}} is not included.
> {noformat}
> 
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2975) Attributes are not validated in lucene xml configuration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030155#comment-16030155
 ] 

ASF GitHub Bot commented on GEODE-2975:
---

Github user upthewaterspout commented on the issue:

https://github.com/apache/geode/pull/538
  
@boglesby - Let me know what you think of the new changes. I added some 
validation to the code.


> Attributes are not validated in lucene xml configuration
> 
>
> Key: GEODE-2975
> URL: https://issues.apache.org/jira/browse/GEODE-2975
> Project: Geode
>  Issue Type: Bug
>  Components: docs, lucene
>Reporter: Barry Oglesby
> Fix For: 1.2.0
>
>
> No exception is thrown for a lucene xml configuration missing a required 
> attribute.
> No exception is thrown for a lucene xml configuration including an unknown 
> attribute.
> If a {{lucene:field}} element is defined like below, no exception is thrown 
> for the invalid attribute called {{namexx}} and no exceptio is thrown because 
> the required attribute called {{name}} is not included.
> {noformat}
> 
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #543: GEODE-2957 gfsh create lucene index "null" becomes ...

[joeymcallister]

Github user joeymcallister commented on a diff in the pull request:

https://github.com/apache/geode/pull/543#discussion_r119218480
  
--- Diff: geode-docs/tools_modules/lucene_integration.html.md.erb ---
@@ -89,10 +89,10 @@ gfsh>create lucene index --name=indexName 
--region=/orders --field=customer,tags
 
 ``` pre
 // Create an index, specifying a custom analyzer for the second field
-// Note: "null" in the first analyzer position uses the default analyzer
+// Note: "DEFAULT" in the first analyzer position uses the default analyzer
 // for the first field
 gfsh>create lucene index --name=indexName --region=/orders
-  --field=customer,tags 
--analyzer=null,org.apache.lucene.analysis.bg.BulgarianAnalyzer
+  --field=customer,tags 
--analyzer=DEFAULT,org.apache.lucene.analysis.bg.BulgarianAnalyzer
 ```
 To use the entire value as a single field set the required `--field`
--- End diff --

Add a comma between "field" and "set"



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #538: GEODE-2975: Change the location of the lucene xsd

[upthewaterspout]

Github user upthewaterspout commented on the issue:

https://github.com/apache/geode/pull/538
  
@boglesby - Let me know what you think of the new changes. I added some 
validation to the code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Review Request 59653: GEODE-2420 Warn a user if they try to export too much data. Added gfsh ref docs for --file-size-limit option.

[Dave Barnes]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59653/
---

Review request for geode, Joey McAllister, Karen Miller, and Ken Howe.


Repository: geode


Description
---

GEODE-2420 Warn a user if they try to export too much data. Added gfsh ref docs 
for --file-size-limit option.


Diffs
-

  geode-docs/tools_modules/gfsh/command-pages/export.html.md.erb 
ccf95ccf2d8449afeb1dc8381b1c0b5a05c36796 


Diff: https://reviews.apache.org/r/59653/diff/1/


Testing
---


Thanks,

Dave Barnes

[jira] [Commented] (GEODE-2957) null used as a default parameter when specifying analyzers

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030156#comment-16030156
 ] 

ASF GitHub Bot commented on GEODE-2957:
---

Github user joeymcallister commented on a diff in the pull request:

https://github.com/apache/geode/pull/543#discussion_r119218480
  
--- Diff: geode-docs/tools_modules/lucene_integration.html.md.erb ---
@@ -89,10 +89,10 @@ gfsh>create lucene index --name=indexName 
--region=/orders --field=customer,tags
 
 ``` pre
 // Create an index, specifying a custom analyzer for the second field
-// Note: "null" in the first analyzer position uses the default analyzer
+// Note: "DEFAULT" in the first analyzer position uses the default analyzer
 // for the first field
 gfsh>create lucene index --name=indexName --region=/orders
-  --field=customer,tags 
--analyzer=null,org.apache.lucene.analysis.bg.BulgarianAnalyzer
+  --field=customer,tags 
--analyzer=DEFAULT,org.apache.lucene.analysis.bg.BulgarianAnalyzer
 ```
 To use the entire value as a single field set the required `--field`
--- End diff --

Add a comma between "field" and "set"



> null used as a default parameter when specifying analyzers
> --
>
> Key: GEODE-2957
> URL: https://issues.apache.org/jira/browse/GEODE-2957
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Jason Huynh
>Assignee: David Anuta
> Fix For: 1.2.0
>
>
> null seems to be the way to specify using the default 
> StandardKeywordAnalyzer. This can be used when specifying a long list of 
> field/analyzers.  
> So the line may look like 
> --analyzers="null,SomeAnalyzer,null,null,SomeAnalyzer}
>  We should probably change that to default or some other keyword.  null seems 
> a bit confusing.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 59653: GEODE-2420 Warn a user if they try to export too much data. Added gfsh ref docs for --file-size-limit option.

[Joey McAllister]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59653/#review176361
---


Ship it!




Ship It!

- Joey McAllister


On May 30, 2017, 9:21 p.m., Dave Barnes wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59653/
> ---
> 
> (Updated May 30, 2017, 9:21 p.m.)
> 
> 
> Review request for geode, Joey McAllister, Karen Miller, and Ken Howe.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2420 Warn a user if they try to export too much data. Added gfsh ref 
> docs for --file-size-limit option.
> 
> 
> Diffs
> -
> 
>   geode-docs/tools_modules/gfsh/command-pages/export.html.md.erb 
> ccf95ccf2d8449afeb1dc8381b1c0b5a05c36796 
> 
> 
> Diff: https://reviews.apache.org/r/59653/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dave Barnes
> 
>

Re: Review Request 59653: GEODE-2420 Warn a user if they try to export too much data. Added gfsh ref docs for --file-size-limit option.

[Ken Howe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59653/#review176362
---


Ship it!




Ship It!

- Ken Howe


On May 30, 2017, 9:21 p.m., Dave Barnes wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59653/
> ---
> 
> (Updated May 30, 2017, 9:21 p.m.)
> 
> 
> Review request for geode, Joey McAllister, Karen Miller, and Ken Howe.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2420 Warn a user if they try to export too much data. Added gfsh ref 
> docs for --file-size-limit option.
> 
> 
> Diffs
> -
> 
>   geode-docs/tools_modules/gfsh/command-pages/export.html.md.erb 
> ccf95ccf2d8449afeb1dc8381b1c0b5a05c36796 
> 
> 
> Diff: https://reviews.apache.org/r/59653/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dave Barnes
> 
>

[GitHub] geode pull request #549: GEODE-2203: gfsh status locator/server - Command no...

[jaredjstewart]

Github user jaredjstewart commented on a diff in the pull request:

https://github.com/apache/geode/pull/549#discussion_r119220596
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java
 ---
@@ -1794,18 +1801,20 @@ public Result statusServer(
   
.format(CliStrings.STATUS_SERVICE__GFSH_NOT_CONNECTED_ERROR_MESSAGE, "Cache 
Server"));
 }
   } else {
-final ServerLauncher serverLauncher = new ServerLauncher.Builder()
-
.setCommand(ServerLauncher.Command.STATUS).setDebug(isDebugging())
-// NOTE since we do not know whether the "CacheServer" was 
enabled or not on the GemFire
-// server when it was started, set the disableDefaultServer 
property in the
-// ServerLauncher.Builder to default status
-// to the MemberMBean
-// TODO fix this hack! (how, the 'start server' loop needs it)
-
.setDisableDefaultServer(true).setPid(pid).setWorkingDirectory(workingDirectory)
-.build();
-
+final ServerLauncher serverLauncher;
+if ((member == null)) {
--- End diff --

It looks like we're guaranteed that `member` is not blank in this `else` 
block, so I think we are guaranteed that `member` is not null here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #549: GEODE-2203: gfsh status locator/server - Command no...

[jaredjstewart]

Github user jaredjstewart commented on a diff in the pull request:

https://github.com/apache/geode/pull/549#discussion_r119219867
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java
 ---
@@ -771,11 +771,18 @@ public Result statusLocator(
   CliStrings.STATUS_SERVICE__GFSH_NOT_CONNECTED_ERROR_MESSAGE, 
LOCATOR_TERM_NAME));
 }
   } else {
-final LocatorLauncher locatorLauncher =
-new 
LocatorLauncher.Builder().setCommand(LocatorLauncher.Command.STATUS)
-
.setBindAddress(locatorHost).setDebug(isDebugging()).setPid(pid)
-
.setPort(locatorPort).setWorkingDirectory(workingDirectory).build();
+final LocatorLauncher locatorLauncher;
 
+if ((locatorHost == null) && (locatorPort == null) && 
(workingDirectory == null)) {
--- End diff --

What if `locatorPort` is specified, but `locatorHost` is not?  It seems 
like that might pass this check, but still result in an error.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2203) gfsh status locator/server - Give more descriptive output on empty parameter

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030170#comment-16030170
 ] 

ASF GitHub Bot commented on GEODE-2203:
---

Github user jaredjstewart commented on a diff in the pull request:

https://github.com/apache/geode/pull/549#discussion_r119219867
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java
 ---
@@ -771,11 +771,18 @@ public Result statusLocator(
   CliStrings.STATUS_SERVICE__GFSH_NOT_CONNECTED_ERROR_MESSAGE, 
LOCATOR_TERM_NAME));
 }
   } else {
-final LocatorLauncher locatorLauncher =
-new 
LocatorLauncher.Builder().setCommand(LocatorLauncher.Command.STATUS)
-
.setBindAddress(locatorHost).setDebug(isDebugging()).setPid(pid)
-
.setPort(locatorPort).setWorkingDirectory(workingDirectory).build();
+final LocatorLauncher locatorLauncher;
 
+if ((locatorHost == null) && (locatorPort == null) && 
(workingDirectory == null)) {
--- End diff --

What if `locatorPort` is specified, but `locatorHost` is not?  It seems 
like that might pass this check, but still result in an error.


> gfsh status locator/server - Give more descriptive output on empty parameter
> 
>
> Key: GEODE-2203
> URL: https://issues.apache.org/jira/browse/GEODE-2203
> Project: Geode
>  Issue Type: Improvement
>  Components: gfsh
>Reporter: Alyssa Kim
>Assignee: Emily Yeh
>Priority: Minor
>  Labels: StatusLocatorCommand, StatusServerCommand, gfsh, status
>
> Currently, executing some status commands in gfsh without valid parameters 
> gives a vague explanation/output that might be misleading. Although we have 
> help  for usage description, displaying 'null' as an output 
> might not be the best idea.
> Current Result
> {code}
> gfsh>status locator
> null
> {code}
> {code}
> gfsh>status server
> Server in 
> C:\Users\XXX\git\incubator-geode\geode-assembly\build\install\apache-geode\bin
>  on null is currently not responding.
> {code}
> Improvement
> {code}
> gfsh>status locator
> SYNTAX
> status locator [--name=value] [--host=value] [--port=value] [--pid=value]
> Use help status locator to display detailed usage information
> {code}
> {code}
> gfsh>status server
> SYNTAX
> status server [--name=value] [--pid=value] [--dir=value]
> Use help status server to display detailed usage information
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2203) gfsh status locator/server - Give more descriptive output on empty parameter

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030169#comment-16030169
 ] 

ASF GitHub Bot commented on GEODE-2203:
---

Github user jaredjstewart commented on a diff in the pull request:

https://github.com/apache/geode/pull/549#discussion_r119220596
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java
 ---
@@ -1794,18 +1801,20 @@ public Result statusServer(
   
.format(CliStrings.STATUS_SERVICE__GFSH_NOT_CONNECTED_ERROR_MESSAGE, "Cache 
Server"));
 }
   } else {
-final ServerLauncher serverLauncher = new ServerLauncher.Builder()
-
.setCommand(ServerLauncher.Command.STATUS).setDebug(isDebugging())
-// NOTE since we do not know whether the "CacheServer" was 
enabled or not on the GemFire
-// server when it was started, set the disableDefaultServer 
property in the
-// ServerLauncher.Builder to default status
-// to the MemberMBean
-// TODO fix this hack! (how, the 'start server' loop needs it)
-
.setDisableDefaultServer(true).setPid(pid).setWorkingDirectory(workingDirectory)
-.build();
-
+final ServerLauncher serverLauncher;
+if ((member == null)) {
--- End diff --

It looks like we're guaranteed that `member` is not blank in this `else` 
block, so I think we are guaranteed that `member` is not null here.


> gfsh status locator/server - Give more descriptive output on empty parameter
> 
>
> Key: GEODE-2203
> URL: https://issues.apache.org/jira/browse/GEODE-2203
> Project: Geode
>  Issue Type: Improvement
>  Components: gfsh
>Reporter: Alyssa Kim
>Assignee: Emily Yeh
>Priority: Minor
>  Labels: StatusLocatorCommand, StatusServerCommand, gfsh, status
>
> Currently, executing some status commands in gfsh without valid parameters 
> gives a vague explanation/output that might be misleading. Although we have 
> help  for usage description, displaying 'null' as an output 
> might not be the best idea.
> Current Result
> {code}
> gfsh>status locator
> null
> {code}
> {code}
> gfsh>status server
> Server in 
> C:\Users\XXX\git\incubator-geode\geode-assembly\build\install\apache-geode\bin
>  on null is currently not responding.
> {code}
> Improvement
> {code}
> gfsh>status locator
> SYNTAX
> status locator [--name=value] [--host=value] [--port=value] [--pid=value]
> Use help status locator to display detailed usage information
> {code}
> {code}
> gfsh>status server
> SYNTAX
> status server [--name=value] [--pid=value] [--dir=value]
> Use help status server to display detailed usage information
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2203) gfsh status locator/server - Give more descriptive output on empty parameter

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030177#comment-16030177
 ] 

ASF GitHub Bot commented on GEODE-2203:
---

Github user pdxrunner commented on a diff in the pull request:

https://github.com/apache/geode/pull/549#discussion_r119221757
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java
 ---
@@ -771,11 +771,18 @@ public Result statusLocator(
   CliStrings.STATUS_SERVICE__GFSH_NOT_CONNECTED_ERROR_MESSAGE, 
LOCATOR_TERM_NAME));
 }
   } else {
-final LocatorLauncher locatorLauncher =
-new 
LocatorLauncher.Builder().setCommand(LocatorLauncher.Command.STATUS)
-
.setBindAddress(locatorHost).setDebug(isDebugging()).setPid(pid)
-
.setPort(locatorPort).setWorkingDirectory(workingDirectory).build();
+final LocatorLauncher locatorLauncher;
 
+if ((locatorHost == null) && (locatorPort == null) && 
(workingDirectory == null)) {
+  return ResultBuilder.createShellClientErrorResult(
+  
String.format(CliStrings.STATUS_LOCATOR__NO_LOCATOR_SPECIFIED_ERROR_MESSAGE,
+  getLocatorId(locatorHost, locatorPort),
+  StringUtils.defaultIfBlank(workingDirectory, 
SystemUtils.CURRENT_DIRECTORY)));
--- End diff --

workingDirectory == null in this clause of the if, so this argument can 
just be SystemUtils.CURRENT_DIRECTORY


> gfsh status locator/server - Give more descriptive output on empty parameter
> 
>
> Key: GEODE-2203
> URL: https://issues.apache.org/jira/browse/GEODE-2203
> Project: Geode
>  Issue Type: Improvement
>  Components: gfsh
>Reporter: Alyssa Kim
>Assignee: Emily Yeh
>Priority: Minor
>  Labels: StatusLocatorCommand, StatusServerCommand, gfsh, status
>
> Currently, executing some status commands in gfsh without valid parameters 
> gives a vague explanation/output that might be misleading. Although we have 
> help  for usage description, displaying 'null' as an output 
> might not be the best idea.
> Current Result
> {code}
> gfsh>status locator
> null
> {code}
> {code}
> gfsh>status server
> Server in 
> C:\Users\XXX\git\incubator-geode\geode-assembly\build\install\apache-geode\bin
>  on null is currently not responding.
> {code}
> Improvement
> {code}
> gfsh>status locator
> SYNTAX
> status locator [--name=value] [--host=value] [--port=value] [--pid=value]
> Use help status locator to display detailed usage information
> {code}
> {code}
> gfsh>status server
> SYNTAX
> status server [--name=value] [--pid=value] [--dir=value]
> Use help status server to display detailed usage information
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)