[ 
https://issues.apache.org/jira/browse/GEODE-2818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029755#comment-16029755
 ] 

ASF GitHub Bot commented on GEODE-2818:
---------------------------------------

Github user jinmeiliao commented on a diff in the pull request:

    https://github.com/apache/geode/pull/546#discussion_r119159305
  
    --- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java
 ---
    @@ -726,13 +733,13 @@
       public static final String CREATE_INDEX__REGION = "region";
       public static final String CREATE_INDEX__REGION__HELP =
           "Name/Path of the region which corresponds to the \"from\" clause in 
a query.";
    -  public static final String CREATE_INDEX__MEMBER = "member";
    +  public static final String CREATE_INDEX__MEMBER = MEMBER;
    --- End diff --
    
    I am wondering if you can delete all these other xxx_GROUP or xxx_MEMBER 
string declarations and change all reference of them to use the generic ones.


> add alias to any command's options that involves "group", "member", "jar"
> -------------------------------------------------------------------------
>
>                 Key: GEODE-2818
>                 URL: https://issues.apache.org/jira/browse/GEODE-2818
>             Project: Geode
>          Issue Type: New Feature
>          Components: docs, gfsh
>            Reporter: Jinmei Liao
>            Assignee: Emily Yeh
>
> Or anything that would have confusion about if we are going to use singular 
> or plural at all.
> 1) add alias for those options
> 2) make sure it parameter type is an array type, some method only accepts a 
> string and split it inside the command.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to