Fwd: [VOTE] Apache Geode release - v1.1.1 RC2

[Dick Cavender]

+1

Built source and ran tests successfully on RH.

Ran gfsh on binary dist to start and stop locator and system.


On 3/30/2017 4:58 PM, Anthony Baker wrote:

Please review and vote (especially if you are a Geode PMC member!).

Anthony

[GitHub] geode-native pull request #82: GEODE-2736: Fixed orphaned worker threads

[PivotalSarge]

Github user PivotalSarge commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/82#discussion_r109194938
  
--- Diff: 
src/cppcache/integration-test/testThinClientPoolExecuteFunctionThrowsException.cpp
 ---
@@ -0,0 +1,362 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#define ROOT_NAME "testThinClientPoolExecuteFunctionThrowsException"
+
+#include "fw_dunit.hpp"
+#include "ThinClientHelper.hpp"
+#include "testobject/VariousPdxTypes.hpp"
+
+#include 
+#include 
+
+using namespace PdxTests;
+/* This is to test
+1- funtion execution on pool
+ */
+
+#define CLIENT1 s1p1
+#define LOCATOR1 s2p1
+#define SERVER s2p2
+
+bool isLocalServer = false;
+bool isLocator = false;
+bool isPoolWithEndpoint = false;
+
+const char* locHostPort =
+CacheHelper::getLocatorHostPort(isLocator, isLocalServer, 1);
+const char* poolRegNames[] = {"partition_region", "PoolRegion2"};
+
+const char* serverGroup = "ServerGroup1";
+
+char* getFuncIName = (char*)"MultiGetFunctionI";
+char* putFuncIName = (char*)"MultiPutFunctionI";
+char* getFuncName = (char*)"MultiGetFunction";
+char* putFuncName = (char*)"MultiPutFunction";
+char* rjFuncName = (char*)"RegionOperationsFunction";
+char* exFuncName = (char*)"ExceptionHandlingFunction";
+char* exFuncNameSendException = (char*)"executeFunction_SendException";
+char* exFuncNamePdxType = (char*)"PdxFunctionTest";
+char* FEOnRegionPrSHOP = (char*)"FEOnRegionPrSHOP";
+char* FEOnRegionPrSHOP_OptimizeForWrite =
+(char*)"FEOnRegionPrSHOP_OptimizeForWrite";
+char* FETimeOut = (char*)"FunctionExecutionTimeOut";
+
+#define verifyGetResults() 
   \
+bool found = false;
 \
+for (int j = 0; j < 34; j++) { 
 \
+  if (j % 2 == 0) continue;
 \
+  sprintf(buf, "VALUE--%d", j);
 \
+  if (strcmp(buf, 
dynCast(resultList->operator[](i))\
+ ->asChar()) == 0) {   \
+LOGINFO(   
 \
+   
 "buf = %s " \
+   
 "dynCast(resultList->operator[](i))->asChar() " \
+   
 "= %s ",\
+   
 buf,\
+   
 dynCast(resultList->operator[](i))->asChar());  \
+   
 found = true;   \
+   
 break;  \
+  }
 \
+}  
 \
+ASSERT(found, "this returned value is invalid");
+
+#define verifyGetKeyResults()  
   \
+bool found = false;
 \
+for (int j = 0; j < 34; j++) { 
 \
+  if (j % 2 == 0) continue;
 \
+  sprintf(buf, "KEY--%d", j);   

[jira] [Commented] (GEODE-2736) Native client thread pool get stuck sometimes during rolling restart

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15951203#comment-15951203
 ] 

ASF GitHub Bot commented on GEODE-2736:
---

Github user PivotalSarge commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/82#discussion_r109194938
  
--- Diff: 
src/cppcache/integration-test/testThinClientPoolExecuteFunctionThrowsException.cpp
 ---
@@ -0,0 +1,362 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#define ROOT_NAME "testThinClientPoolExecuteFunctionThrowsException"
+
+#include "fw_dunit.hpp"
+#include "ThinClientHelper.hpp"
+#include "testobject/VariousPdxTypes.hpp"
+
+#include 
+#include 
+
+using namespace PdxTests;
+/* This is to test
+1- funtion execution on pool
+ */
+
+#define CLIENT1 s1p1
+#define LOCATOR1 s2p1
+#define SERVER s2p2
+
+bool isLocalServer = false;
+bool isLocator = false;
+bool isPoolWithEndpoint = false;
+
+const char* locHostPort =
+CacheHelper::getLocatorHostPort(isLocator, isLocalServer, 1);
+const char* poolRegNames[] = {"partition_region", "PoolRegion2"};
+
+const char* serverGroup = "ServerGroup1";
+
+char* getFuncIName = (char*)"MultiGetFunctionI";
+char* putFuncIName = (char*)"MultiPutFunctionI";
+char* getFuncName = (char*)"MultiGetFunction";
+char* putFuncName = (char*)"MultiPutFunction";
+char* rjFuncName = (char*)"RegionOperationsFunction";
+char* exFuncName = (char*)"ExceptionHandlingFunction";
+char* exFuncNameSendException = (char*)"executeFunction_SendException";
+char* exFuncNamePdxType = (char*)"PdxFunctionTest";
+char* FEOnRegionPrSHOP = (char*)"FEOnRegionPrSHOP";
+char* FEOnRegionPrSHOP_OptimizeForWrite =
+(char*)"FEOnRegionPrSHOP_OptimizeForWrite";
+char* FETimeOut = (char*)"FunctionExecutionTimeOut";
+
+#define verifyGetResults() 
   \
+bool found = false;
 \
+for (int j = 0; j < 34; j++) { 
 \
+  if (j % 2 == 0) continue;
 \
+  sprintf(buf, "VALUE--%d", j);
 \
+  if (strcmp(buf, 
dynCast(resultList->operator[](i))\
+ ->asChar()) == 0) {   \
+LOGINFO(   
 \
+   
 "buf = %s " \
+   
 "dynCast(resultList->operator[](i))->asChar() " \
+   
 "= %s ",\
+   
 buf,\
+   
 dynCast(resultList->operator[](i))->asChar());  \
+   
 found = true;   \
+   
 break;  \
+  }
 \
+}  
 \
+ASSERT(found, "this returned value is invalid");
+
+#define verifyGetKeyResults()  
   \
+bool found = false;

Re: [VOTE] Apache Geode release - v1.1.1 RC2

[Udo Kohlmeyer]

+1

Build source. Had one failure GEODE-2151 



Started locator + servers + wan gateways.
Loaded data and ran simple queries.

On 3/27/17 22:18, Anthony Baker wrote:

This is the second release candidate of the release for Apache Geode,
version 1.1.1.

It fixes the following issues:
   
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318420&version=12340271

*** Please download, test and vote by Thursday, March 30, 2200 hrs US
Pacific. ***

Note that we are voting upon the source (tag):
   rel/v1.1.1.RC2
   
https://git-wip-us.apache.org/repos/asf?p=geode.git;a=tag;h=refs/tags/rel/v1.1.1.RC2

Commit ID: e2081044ea0afca1cb38d62c7f34e7363b45ad97

Source and binary files:
   https://dist.apache.org/repos/dist/dev/geode/1.1.1.RC2/

Maven staging repo:
   https://repository.apache.org/content/repositories/orgapachegeode-1018

Geode's KEYS file containing PGP keys we use to sign the release:
   https://github.com/apache/geode/blob/release/1.1.1/KEYS

pub  4096R/C72CFB64 2015-10-01
 Fingerprint=948E 8234 14BE 693A 7F74  ABBE 19DB CAEE C72C FB64


Thanks,
Anthony

[jira] [Commented] (GEODE-2404) Add API to destroy a region containing lucene indexes

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15951213#comment-15951213
 ] 

ASF subversion and git services commented on GEODE-2404:


Commit 1f07ec76da27952c12547742bca00247116105ec in geode's branch 
refs/heads/develop from [~barry.oglesby]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=1f07ec7 ]

GEODE-2404: Modified to support destroying an index while puts are occurring


> Add API to destroy a region containing lucene indexes
> -
>
> Key: GEODE-2404
> URL: https://issues.apache.org/jira/browse/GEODE-2404
> Project: Geode
>  Issue Type: New Feature
>  Components: docs, lucene
>Reporter: Barry Oglesby
>Assignee: Barry Oglesby
> Fix For: 1.2.0
>
> Attachments: DestroyRegionMultipleMembersFunction.java
>
>
> h2. Description
> An application {{Region}} containing {{LuceneIndexes}} should be able to be 
> destroyed.
> There are several options, including:
> - Invoke one API to destroy both the application {{Region}} and its 
> {{LuceneIndexes}}
> - Invoke two API:
> ## destroy the {{LuceneIndexes}}
> ## destroy application {{Region}} as it is done currently
> h3. One API
> In this case, we would need a callback on {{LuceneService}} to destroy the 
> {{LuceneIndexes}} before destroying the application {{Region}} like:
> {noformat}
> public void beforeDestroyRegion(Region region);
> {noformat}
> This API would get all the {{LuceneIndexes}} for the application {{Region}}, 
> then destroy each one. See the *Two API* section below for details on 
> destroying a {{LuceneIndex}}.
> Without changes to the way {{PartitionedRegions}} are destroyed, this causes 
> an issue though.
> The current behavior of {{PartitionedRegion destroyRegion}} is to first check 
> for colocated children. If there are any, the call fails.
> There are two options for adding the call to destroy the {{LuceneIndexes}}:
> # check for colocated children
> # invoke {{LuceneService beforeDestroyRegion}} to remove the {{LuceneIndexes}}
> # do the rest of the destroy
> 
> # invoke {{LuceneService beforeDestroyRegion}} to remove the {{LuceneIndexes}}
> # check for colocated children
> # do the rest of the destroy
> Both of these options are problematic in different ways.
> In the case of a {{PartitionedRegion}} with {{LuceneIndexes}}, there are 
> colocated children, so the first option would cause the {{destroyRegion}} 
> call to fail; the second option would succeed. I don't think the first option 
> should fail since the colocated children are internal {{Regions}} that the 
> application knows nothing about.
> In the case of a {{PartitionedRegion}} defining {{LuceneIndexes}} and having 
> an {{AsyncEventQueue}}, there are colocated children, so the first option 
> would cause the {{destroyRegion}} call to fail. This is ok since one of the 
> children is an application-known {{AsyncEventQueue}}. The second option would 
> fail in a bad way. It would first remove the {{LuceneIndexes}}, then fail the 
> colocated children check, so the {{destroyRegion}} call would fail. In this 
> case, the application {{Region}} doesn't get destroyed but its 
> {{LuceneIndexes}} do. This would be bad.
> One option would be to look into changing the check for colocated children to 
> check for application-defined (or not hidden) colocated children. Then the 
> code would be something like:
> # check for application-defined colocated children
> # invoke LuceneService beforeDestroyRegion to remove the LuceneIndexes
> # do the rest of the destroy
> I think this would be ok in both cases.
> h3. Two API
> The destroy API on {{LuceneIndex}} would be something like:
> {noformat}
> public void destroy();
> {noformat}
> Destroying each {{LuceneIndex}} would require:
> # destroying the chunk {{Region}}
> # destroying the file {{Region}}
> # destroying the {{AsyncEventQueue}} which would require:
> ## retrieving and stopping the {{AsyncEventQueue's}} underlying 
> {{GatewaySender}} (there probably should be stop API on {{AsyncEventQueue}} 
> which does this)
> ## removing the id from the application {{Region's AsyncEventQueue}} ids
> ## destroying the {{AsyncEventQueue}} (this destroys the underlying 
> {{GatewaySender}} and removes it from the {{GemFireCacheImpl's}} collection 
> of {{GatewaySenders}})
> ## removing the {{AsyncEventQueue}} from the {{GemFireCacheImpl's}} 
> collection of {{AsyncEventQueues}} (this should be included in the destroy 
> method above)
> # removing {{LuceneIndex}} from {{LuceneService's}} map of indexes
> I also think the API on {{LuceneService}} should be something like:
> {noformat}
> public void destroyIndexes(String regionPath);
> public void destroyIndex(String indexName, String regionPath);
> {noformat}
> These methods would 

Re: [VOTE] Apache Geode release - v1.1.1 RC2

[Xiaojian Zhou]

+1
built from source and run several dunits (the ones showed in regression #50)

On Fri, Mar 31, 2017 at 9:04 AM, Dick Cavender  wrote:

> +1
>
> Built source and ran tests successfully on RH.
>
> Ran gfsh on binary dist to start and stop locator and system.
>
>
>
> On 3/30/2017 4:58 PM, Anthony Baker wrote:
>
>> Please review and vote (especially if you are a Geode PMC member!).
>>
>> Anthony
>>
>>
>>
>

Build failed in Jenkins: Geode-nightly #793

[Apache Jenkins Server]

See 


Changes:

[jstewart] GEODE-2730: Refactor ServerStarterRule and LocatorStarterRule

--
[...truncated 100.88 KB...]

org.apache.geode.management.UniversalMembershipListenerAdapterDUnitTest > 
testSystemClientEventsInServer FAILED
org.junit.ComparisonFailure: expected:<[67.195.81.148](2333):32771> 
but was:<[asf904](2333):32771>
at org.junit.Assert.assertEquals(Assert.java:115)
at org.junit.Assert.assertEquals(Assert.java:144)
at 
org.apache.geode.management.UniversalMembershipListenerAdapterDUnitTest.doTestSystemClientEventsInServer(UniversalMembershipListenerAdapterDUnitTest.java:946)
at 
org.apache.geode.management.UniversalMembershipListenerAdapterDUnitTest.testSystemClientEventsInServer(UniversalMembershipListenerAdapterDUnitTest.java:731)

6840 tests completed, 2 failed, 603 skipped
:geode-core:distributedTest FAILED
:geode-core:flakyTest
:geode-core:integrationTest
:geode-cq:assemble
:geode-cq:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-cq:processTestResources
:geode-cq:testClasses
:geode-cq:checkMissedTests
:geode-cq:spotlessJavaCheck
:geode-cq:spotlessCheck
:geode-cq:test
:geode-cq:check
:geode-cq:build
:geode-cq:distributedTest
:geode-cq:flakyTest
:geode-cq:integrationTest
:geode-json:assemble
:geode-json:compileTestJava UP-TO-DATE
:geode-json:processTestResources
:geode-json:testClasses
:geode-json:checkMissedTests UP-TO-DATE
:geode-json:spotlessJavaCheck
:geode-json:spotlessCheck
:geode-json:test UP-TO-DATE
:geode-json:check
:geode-json:build
:geode-json:distributedTest UP-TO-DATE
:geode-json:flakyTest UP-TO-DATE
:geode-json:integrationTest UP-TO-DATE
:geode-junit:javadoc
:geode-junit:javadocJar
:geode-junit:sourcesJar
:geode-junit:signArchives SKIPPED
:geode-junit:assemble
:geode-junit:compileTestJava
:geode-junit:processTestResources UP-TO-DATE
:geode-junit:testClasses
:geode-junit:checkMissedTests
:geode-junit:spotlessJavaCheck
:geode-junit:spotlessCheck
:geode-junit:test
:geode-junit:check
:geode-junit:build
:geode-junit:distributedTest
:geode-junit:flakyTest
:geode-junit:integrationTest
:geode-lucene:assemble
:geode-lucene:compileTestJavaNote: Some input files use or override a 
deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-lucene:processTestResources
:geode-lucene:testClasses
:geode-lucene:checkMissedTests
:geode-lucene:spotlessJavaCheck
:geode-lucene:spotlessCheck
:geode-lucene:test
:geode-lucene:check
:geode-lucene:build
:geode-lucene:distributedTest
:geode-lucene:flakyTest
:geode-lucene:integrationTest
:geode-old-client-support:assemble
:geode-old-client-support:compileTestJava
:geode-old-client-support:processTestResources UP-TO-DATE
:geode-old-client-support:testClasses
:geode-old-client-support:checkMissedTests
:geode-old-client-support:spotlessJavaCheck
:geode-old-client-support:spotlessCheck
:geode-old-client-support:test
:geode-old-client-support:check
:geode-old-client-support:build
:geode-old-client-support:distributedTest
:geode-old-client-support:flakyTest
:geode-old-client-support:integrationTest
:geode-old-versions:javadoc UP-TO-DATE
:geode-old-versions:javadocJar
:geode-old-versions:sourcesJar
:geode-old-versions:signArchives SKIPPED
:geode-old-versions:assemble
:geode-old-versions:compileTestJava UP-TO-DATE
:geode-old-versions:processTestResources UP-TO-DATE
:geode-old-versions:testClasses UP-TO-DATE
:geode-old-versions:checkMissedTests UP-TO-DATE
:geode-old-versions:spotlessJavaCheck
:geode-old-versions:spotlessCheck
:geode-old-versions:test UP-TO-DATE
:geode-old-versions:check
:geode-old-versions:build
:geode-old-versions:distributedTest UP-TO-DATE
:geode-old-versions:flakyTest UP-TO-DATE
:geode-old-versions:integrationTest UP-TO-DATE
:geode-pulse:assemble
:geode-pulse:compileTestJavaNote: 

 uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: 

 uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-pulse:processTestResources
:geode-pulse:testClasses
:geode-pulse:checkMissedTests
:geode-pulse:spotlessJavaCheck
:geode-pulse:spotlessCheck
:geode-pulse:test
:geode-pulse:check
:geode-pulse:build
:geode-pulse:distributedTest
:geode-pulse:flakyTest
:geode-pulse:integrationTest
:geode-rebalancer:assemble
:geode-rebalancer:compileTestJa

[jira] [Updated] (GEODE-2729) Improve Native Client Stability by removing global variables

[Addison (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Addison updated GEODE-2729:
---
Description: 
**Context**
Today, the native client uses singleton global variables to manage things like 
the cache.  These prove troublesome when moving between managed and unmanaged 
code. Another benefit of moving away from the globals is improved unit testing. 
 This will increase the overall testing feedback loop.

**Goal**
Remove these singletons in favor non-global constructors, destructors, etc.

Improved stability when calling functions that move between managed and 
unmanaged code.

  was:
# Context
Today, the native client uses singleton global variables to manage things like 
the cache.  These prove troublesome when moving between managed and unmanaged 
code

# Goal
Remove these singletons in favor non-global constructors, destructors, etc.

# Definition of Done
Improved stability when calling functions that move between managed and 
unmanaged code.


> Improve Native Client Stability by removing global variables
> 
>
> Key: GEODE-2729
> URL: https://issues.apache.org/jira/browse/GEODE-2729
> Project: Geode
>  Issue Type: Wish
>  Components: native client
>Reporter: Addison
>
> **Context**
> Today, the native client uses singleton global variables to manage things 
> like the cache.  These prove troublesome when moving between managed and 
> unmanaged code. Another benefit of moving away from the globals is improved 
> unit testing.  This will increase the overall testing feedback loop.
> **Goal**
> Remove these singletons in favor non-global constructors, destructors, etc.
> Improved stability when calling functions that move between managed and 
> unmanaged code.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2729) Improve Native Client Stability by removing global variables

[Addison (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Addison updated GEODE-2729:
---
Description: 
*Context*
Today, the native client uses singleton global variables to manage things like 
the cache.  These prove troublesome when moving between managed and unmanaged 
code. Another benefit of moving away from the globals is improved unit testing. 
 This will increase the overall testing feedback loop.

*Goal*
Remove these singletons in favor non-global constructors, destructors, etc.

Improved stability when calling functions that move between managed and 
unmanaged code.

*Definition of Done*
Remove all integration tests in favor of well encapsulated unit tests.

  was:
**Context**
Today, the native client uses singleton global variables to manage things like 
the cache.  These prove troublesome when moving between managed and unmanaged 
code. Another benefit of moving away from the globals is improved unit testing. 
 This will increase the overall testing feedback loop.

**Goal**
Remove these singletons in favor non-global constructors, destructors, etc.

Improved stability when calling functions that move between managed and 
unmanaged code.


> Improve Native Client Stability by removing global variables
> 
>
> Key: GEODE-2729
> URL: https://issues.apache.org/jira/browse/GEODE-2729
> Project: Geode
>  Issue Type: Wish
>  Components: native client
>Reporter: Addison
>
> *Context*
> Today, the native client uses singleton global variables to manage things 
> like the cache.  These prove troublesome when moving between managed and 
> unmanaged code. Another benefit of moving away from the globals is improved 
> unit testing.  This will increase the overall testing feedback loop.
> *Goal*
> Remove these singletons in favor non-global constructors, destructors, etc.
> Improved stability when calling functions that move between managed and 
> unmanaged code.
> *Definition of Done*
> Remove all integration tests in favor of well encapsulated unit tests.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2739) Identify all globals we want to refactor

[Addison (JIRA)]

Addison created GEODE-2739:
--

 Summary: Identify all globals we want to refactor
 Key: GEODE-2739
 URL: https://issues.apache.org/jira/browse/GEODE-2739
 Project: Geode
  Issue Type: Sub-task
  Components: native client
Reporter: Addison


Create a list of all global singletons.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2740) Refactor cache singleton in factor of well encapsulated objects

[Addison (JIRA)]

Addison created GEODE-2740:
--

 Summary: Refactor cache singleton in factor of well encapsulated 
objects
 Key: GEODE-2740
 URL: https://issues.apache.org/jira/browse/GEODE-2740
 Project: Geode
  Issue Type: Sub-task
  Components: native client
Reporter: Addison






--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2729) Improve Native Client Stability by removing global variables

[Addison (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Addison updated GEODE-2729:
---
Issue Type: Improvement  (was: Wish)

> Improve Native Client Stability by removing global variables
> 
>
> Key: GEODE-2729
> URL: https://issues.apache.org/jira/browse/GEODE-2729
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Addison
>
> *Context*
> Today, the native client uses singleton global variables to manage things 
> like the cache.  These prove troublesome when moving between managed and 
> unmanaged code. Another benefit of moving away from the globals is improved 
> unit testing.  This will increase the overall testing feedback loop.
> *Goal*
> Remove these singletons in favor non-global constructors, destructors, etc.
> Improved stability when calling functions that move between managed and 
> unmanaged code.
> *Definition of Done*
> Remove all integration tests in favor of well encapsulated unit tests.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2741) Use C++11 shared pointer over custom shared pointer

[Addison (JIRA)]

Addison created GEODE-2741:
--

 Summary: Use C++11 shared pointer over custom shared pointer
 Key: GEODE-2741
 URL: https://issues.apache.org/jira/browse/GEODE-2741
 Project: Geode
  Issue Type: Improvement
  Components: native client
Reporter: Addison


*Context*
Now that the Native Client is compatible with C++11, we can use its shared 
pointer over the custom shared pointer we use today.

*Definition of Done*
The custom shared pointer is nowhere to be found in the codebase



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2742) Identify all uses of the custom shared pointer and fix all compile errors

[Addison (JIRA)]

Addison created GEODE-2742:
--

 Summary: Identify all uses of the custom shared pointer and fix 
all compile errors
 Key: GEODE-2742
 URL: https://issues.apache.org/jira/browse/GEODE-2742
 Project: Geode
  Issue Type: Sub-task
  Components: native client
Reporter: Addison


Replace and fix compile errors one by one



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Fwd: [VOTE] Apache Geode release - v1.1.1 RC2

[Bruce Schuchardt]

I don't want to give this a -1 but I'm trying to validate this build on 
Microsoft Windows 7 and am running into problems in geode-test.


In a cygwin shell I ran this:

> git checkout rel/v1.1.1.RC2
> ./gradlew clean build

   blah, blah, blah & then this:

   :geode-core:test

   org.apache.geode.internal.cache.tier.sockets.command.ExecuteFunction65Test
> withOldSecurityShouldSucceedIfAuthorized FAILED
java.lang.UnsatisfiedLinkError: Could not load library.
   Reasons: [*no jansi64-1.8 in java.library.path, no jansi-1.8 in
   java.library.path, no jansi in java.library.path, Native Library
   C:\cygwin\tmp\jansi-64-1.8.dll already loaded in another classloade*r]

   org.apache.geode.internal.cache.tier.sockets.command.ExecuteFunction65Test
> withOldSecurityShouldThrowIfNotAuthorized FAILED
java.lang.NoClassDefFoundError: Could not initialize class
   
org.apache.geode.internal.cache.tier.sockets.Message$$EnhancerByMockitoWithCGLIB$$f116767d

   org.apache.geode.internal.cache.tier.sockets.command.ExecuteFunction65Test
> withIntegratedSecurityShouldSucceedIfAuthorized FAILED
java.lang.NoClassDefFoundError: Could not initialize class
   
org.apache.geode.internal.cache.tier.sockets.Message$$EnhancerByMockitoWithCGLIB$$f116767d

   org.apache.geode.internal.cache.tier.sockets.command.ExecuteFunction65Test
> withIntegratedSecurityShouldThrowIfNotAuthorized FAILED
java.lang.NoClassDefFoundError: Could not initialize class
   
org.apache.geode.internal.cache.tier.sockets.Message$$EnhancerByMockitoWithCGLIB$$f116767d

   org.apache.geode.internal.cache.tier.sockets.command.ExecuteFunction65Test
> nonSecureShouldSucceed FAILED
java.lang.NoClassDefFoundError: Could not initialize class
   
org.apache.geode.internal.cache.tier.sockets.Message$$EnhancerByMockitoWithCGLIB$$f116767d

   org.apache.geode.internal.cache.tier.sockets.command.ExecuteFunction66Test
> withOldSecurityShouldSucceedIfAuthorized FAILED
java.lang.UnsatisfiedLinkError: Could not load library.
   Reasons: [no jansi64-1.8 in java.library.path, no jansi-1.8 in
   java.library.path, no jansi in java.library.path, Native Library
   C:\cygwin\tmp\jansi-64-1.8.dll already loaded in another classloader]

   etc. there's a TON of this


Le 3/31/2017 à 9:04 AM, Dick Cavender a écrit :

+1

Built source and ran tests successfully on RH.

Ran gfsh on binary dist to start and stop locator and system.


On 3/30/2017 4:58 PM, Anthony Baker wrote:

Please review and vote (especially if you are a Geode PMC member!).

Anthony

Fwd: Build failed in Jenkins: Geode-nightly #793

[Kirk Lund]

What does the community want to do with this test? I have already done
everything I can to make it more dependable. Delete the assertion? Delete
the test? Someone else want to take stab at fixing it?

-- Forwarded message --
From: Apache Jenkins Server 
Date: Fri, Mar 31, 2017 at 9:35 AM
Subject: Build failed in Jenkins: Geode-nightly #793
To: dev@geode.apache.org, jstew...@pivotal.io


See 

Changes:

[jstewart] GEODE-2730: Refactor ServerStarterRule and LocatorStarterRule

--
[...truncated 100.88 KB...]

org.apache.geode.management.UniversalMembershipListenerAdapterDUnitTest >
testSystemClientEventsInServer FAILED
org.junit.ComparisonFailure: expected:<[67.195.81.148](2333):32771>
but was:<[asf904](2333):32771>
at org.junit.Assert.assertEquals(Assert.java:115)
at org.junit.Assert.assertEquals(Assert.java:144)
at org.apache.geode.management.UniversalMembershipListenerAda
pterDUnitTest.doTestSystemClientEventsInServer(
UniversalMembershipListenerAdapterDUnitTest.java:946)
at org.apache.geode.management.UniversalMembershipListenerAda
pterDUnitTest.testSystemClientEventsInServer(UniversalMembershipListenerAda
pterDUnitTest.java:731)

6840 tests completed, 2 failed, 603 skipped
:geode-core:distributedTest FAILED
:geode-core:flakyTest
:geode-core:integrationTest
:geode-cq:assemble
:geode-cq:compileTestJavaNote: Some input files use or override a
deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-cq:processTestResources
:geode-cq:testClasses
:geode-cq:checkMissedTests
:geode-cq:spotlessJavaCheck
:geode-cq:spotlessCheck
:geode-cq:test
:geode-cq:check
:geode-cq:build
:geode-cq:distributedTest
:geode-cq:flakyTest
:geode-cq:integrationTest
:geode-json:assemble
:geode-json:compileTestJava UP-TO-DATE
:geode-json:processTestResources
:geode-json:testClasses
:geode-json:checkMissedTests UP-TO-DATE
:geode-json:spotlessJavaCheck
:geode-json:spotlessCheck
:geode-json:test UP-TO-DATE
:geode-json:check
:geode-json:build
:geode-json:distributedTest UP-TO-DATE
:geode-json:flakyTest UP-TO-DATE
:geode-json:integrationTest UP-TO-DATE
:geode-junit:javadoc
:geode-junit:javadocJar
:geode-junit:sourcesJar
:geode-junit:signArchives SKIPPED
:geode-junit:assemble
:geode-junit:compileTestJava
:geode-junit:processTestResources UP-TO-DATE
:geode-junit:testClasses
:geode-junit:checkMissedTests
:geode-junit:spotlessJavaCheck
:geode-junit:spotlessCheck
:geode-junit:test
:geode-junit:check
:geode-junit:build
:geode-junit:distributedTest
:geode-junit:flakyTest
:geode-junit:integrationTest
:geode-lucene:assemble
:geode-lucene:compileTestJavaNote: Some input files use or override a
deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-lucene:processTestResources
:geode-lucene:testClasses
:geode-lucene:checkMissedTests
:geode-lucene:spotlessJavaCheck
:geode-lucene:spotlessCheck
:geode-lucene:test
:geode-lucene:check
:geode-lucene:build
:geode-lucene:distributedTest
:geode-lucene:flakyTest
:geode-lucene:integrationTest
:geode-old-client-support:assemble
:geode-old-client-support:compileTestJava
:geode-old-client-support:processTestResources UP-TO-DATE
:geode-old-client-support:testClasses
:geode-old-client-support:checkMissedTests
:geode-old-client-support:spotlessJavaCheck
:geode-old-client-support:spotlessCheck
:geode-old-client-support:test
:geode-old-client-support:check
:geode-old-client-support:build
:geode-old-client-support:distributedTest
:geode-old-client-support:flakyTest
:geode-old-client-support:integrationTest
:geode-old-versions:javadoc UP-TO-DATE
:geode-old-versions:javadocJar
:geode-old-versions:sourcesJar
:geode-old-versions:signArchives SKIPPED
:geode-old-versions:assemble
:geode-old-versions:compileTestJava UP-TO-DATE
:geode-old-versions:processTestResources UP-TO-DATE
:geode-old-versions:testClasses UP-TO-DATE
:geode-old-versions:checkMissedTests UP-TO-DATE
:geode-old-versions:spotlessJavaCheck
:geode-old-versions:spotlessCheck
:geode-old-versions:test UP-TO-DATE
:geode-old-versions:check
:geode-old-versions:build
:geode-old-versions:distributedTest UP-TO-DATE
:geode-old-versions:flakyTest UP-TO-DATE
:geode-old-versions:integrationTest UP-TO-DATE
:geode-pulse:assemble
:geode-pulse:compileTestJavaNote:  uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note:  uses unchecked or unsafe op

Re: Review Request 58090: GEODE-2738: Occurred should be spelled with two Rs.

[Patrick Rhomberg]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58090/
---

(Updated March 31, 2017, 5:25 p.m.)


Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, Ken Howe, 
Kirk Lund, and Swapnil Bawaskar.


Repository: geode


Description
---

Minor but extensive correction of "occured" to "occurred."


Diffs
-

  geode-core/src/main/java/org/apache/geode/DataSerializer.java 
627661a8ebbf5f8ffc6a5d2edff6c08f99a4035e 
  
geode-core/src/main/java/org/apache/geode/cache/client/internal/ExecuteFunctionNoAckOp.java
 def738938cc10546a157111ef93c6720cefbbdf2 
  
geode-core/src/main/java/org/apache/geode/cache/client/internal/ExecuteRegionFunctionNoAckOp.java
 06f02d1e6dd2250ef88cc794837905cd678052c0 
  
geode-core/src/main/java/org/apache/geode/cache/client/internal/LiveServerPinger.java
 32d0f8e62096ed714f8eebae6b16f49e0a33e32c 
  
geode-core/src/main/java/org/apache/geode/cache/query/internal/AbstractCompiledValue.java
 d635e024a9fa9cf8e3a7ae812744817ef071be13 
  
geode-core/src/main/java/org/apache/geode/cache/query/internal/CompiledSelect.java
 9b775570ce01e696dc73b8523ff088e585ddf399 
  
geode-core/src/main/java/org/apache/geode/cache/query/internal/OrderByComparator.java
 b9d6026c61209c3e32183f470de05ae41bd17285 
  
geode-core/src/main/java/org/apache/geode/cache/query/internal/QueryUtils.java 
8eaa74a5dad5b8edbed28e9798a7f325fc9bffcf 
  
geode-core/src/main/java/org/apache/geode/cache/query/internal/cq/CqAttributesImpl.java
 7aeee1d95101a95284516a45395a678283eb91b2 
  
geode-core/src/main/java/org/apache/geode/cache/query/internal/index/AbstractIndex.java
 96a3c833f4028cdd2e53c6fb7d74a169e8c8e465 
  
geode-core/src/main/java/org/apache/geode/cache/query/internal/index/CompactRangeIndex.java
 80568f513c5fed3a03d6b6929cb2f3083ecad9aa 
  
geode-core/src/main/java/org/apache/geode/cache/query/internal/index/HashIndex.java
 023fbb465960f366dbe901b586602ed961047b49 
  
geode-core/src/main/java/org/apache/geode/cache/query/internal/index/MemoryIndexStore.java
 e9cd0709e224339ab46d2c3c17c87b3dcb96f1f8 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
 987e4911272ba6c37046d8e39a1187b71556736d 
  
geode-core/src/main/java/org/apache/geode/distributed/internal/InternalLocator.java
 4ac2c9c705a344503fd247d39fbc980a27e2d403 
  
geode-core/src/main/java/org/apache/geode/internal/cache/AbstractRegionMap.java 
eaababaf6be6041c72156a338c69fa81f10db4c5 
  geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java 
b97f4286b6e2352a4ec5637477641d868cb05a6c 
  
geode-core/src/main/java/org/apache/geode/internal/cache/DistributedRegion.java 
b9cdfd75c19f3425dacc8f99c1bc399248230b71 
  
geode-core/src/main/java/org/apache/geode/internal/cache/DistributedRegionFunctionStreamingMessage.java
 1de8d3b3b97a090a549dbcd866436f8d571fe81e 
  
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 
15755175fc16609e0341d8c9e97039b5b83ce5d2 
  geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java 
45540eebda466805bedc6ee08fc69203ae278c8b 
  
geode-core/src/main/java/org/apache/geode/internal/cache/MemberFunctionStreamingMessage.java
 d0dd08466c0053dfd3f0b1dc58cc68c1c9ce01ad 
  geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java 
ca9468d503f5930fb20efa191335ba72d9b081ff 
  
geode-core/src/main/java/org/apache/geode/internal/cache/PRQueryProcessor.java 
6df39713fa7986e3ecd6e4c72bd0c7819235472c 
  
geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegion.java 
173f35c73d33c2e88d5b41e7a04055c423908127 
  
geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegionDataStore.java
 5ddf0cb66e2f2e503336a2705a57a6000edd6128 
  
geode-core/src/main/java/org/apache/geode/internal/cache/PlaceHolderDiskRegion.java
 db01162aeeba8113c208565d683e71a41d0f6d00 
  geode-core/src/main/java/org/apache/geode/internal/cache/ProxyRegionMap.java 
92c7b6f8e90a3382e7ce00064581d69f9706fcd3 
  
geode-core/src/main/java/org/apache/geode/internal/cache/UpdateEntryVersionOperation.java
 f82f0ce5d92420f27ba8c260069221ee6605254c 
  
geode-core/src/main/java/org/apache/geode/internal/cache/control/HeapMemoryMonitor.java
 afc9a23aafba2c1f993b30546f24cd2b5d6a0126 
  
geode-core/src/main/java/org/apache/geode/internal/cache/control/OffHeapMemoryMonitor.java
 414036747a5062ab556b60cdb58c5ce490312c78 
  
geode-core/src/main/java/org/apache/geode/internal/cache/execute/AbstractExecution.java
 505dfce711a0931ec2c52050c121b70c5cb56334 
  
geode-core/src/main/java/org/apache/geode/internal/cache/execute/FunctionServiceStats.java
 09a9122c4058df477d14f03ba7e4c4024d259d6e 
  
geode-core/src/main/java/org/apache/geode/internal/cache/execute/FunctionStats.java
 2f04034041fafa1f79e9c3f464270d4c4ea96e70 
  
geode-core/src/main/java/org/apache/geode/internal/cache/exe

[jira] [Commented] (GEODE-2231) Create new partitioning example

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15951347#comment-15951347
 ] 

ASF subversion and git services commented on GEODE-2231:


Commit 912f7b8ddca82ded1b67456d9c70f3179639cb30 in geode-examples's branch 
refs/heads/feature/GEODE-2231 from [~karensmolermiller]
[ https://git-wip-us.apache.org/repos/asf?p=geode-examples.git;h=912f7b8 ]

GEODE-2231 tweak partitioned geode-examples per reviews

- revise README.md to address review comments
- remove unneeded comments


> Create new partitioning example
> ---
>
> Key: GEODE-2231
> URL: https://issues.apache.org/jira/browse/GEODE-2231
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>Priority: Minor
>
> Add a new example to the geode-examples that demonstrates partitioning.
> The example will use the same structure as the replicated example, starting 2 
> servers that host a partitioned region (with no redundant copies).  Run the 
> producer to populate the region.  Run the consumer to see the contents of the 
> region. Then, stop one of the servers and run the consumer again to notice 
> that only roughly half (with 2 servers and hopefully a reasonable hash) of 
> the entries are present.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2738) Occurred is spelled with two Rs.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15951361#comment-15951361
 ] 

ASF GitHub Bot commented on GEODE-2738:
---

GitHub user PurelyApplied opened a pull request:

https://github.com/apache/geode/pull/435

GEODE-2738: Corrected spelling of "occured" to occurred

Most occurrences are in comments and string constants, but there are a 
nontrivial number of variable name changes as well.

Initial testing returns green across the board.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/PurelyApplied/geode improvement/occurred

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/435.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #435


commit b6a090998ee3132700a7042d114d7ea974ee4ebe
Author: Patrick Rhomberg 
Date:   2017-03-30T22:44:17Z

GEODE-2738: Corrected spelling of occurred throughout.




> Occurred is spelled with two Rs.
> 
>
> Key: GEODE-2738
> URL: https://issues.apache.org/jira/browse/GEODE-2738
> Project: Geode
>  Issue Type: Improvement
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>Priority: Trivial
>
> Most frequently, "an exception occured: {}" in logging.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #435: GEODE-2738: Corrected spelling of "occured" to occu...

[PurelyApplied]

GitHub user PurelyApplied opened a pull request:

https://github.com/apache/geode/pull/435

GEODE-2738: Corrected spelling of "occured" to occurred

Most occurrences are in comments and string constants, but there are a 
nontrivial number of variable name changes as well.

Initial testing returns green across the board.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/PurelyApplied/geode improvement/occurred

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/435.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #435


commit b6a090998ee3132700a7042d114d7ea974ee4ebe
Author: Patrick Rhomberg 
Date:   2017-03-30T22:44:17Z

GEODE-2738: Corrected spelling of occurred throughout.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Fwd: Build failed in Jenkins: Geode-nightly #793

[Bruce Schuchardt]

I'm looking into this test again.  I think we can get around any DNS 
issues by forcing the whole test to use numeric IP addresses instead of 
host names.


Le 3/31/2017 à 9:59 AM, Kirk Lund a écrit :

What does the community want to do with this test? I have already done
everything I can to make it more dependable. Delete the assertion? Delete
the test? Someone else want to take stab at fixing it?

-- Forwarded message --
From: Apache Jenkins Server 
Date: Fri, Mar 31, 2017 at 9:35 AM
Subject: Build failed in Jenkins: Geode-nightly #793
To: dev@geode.apache.org, jstew...@pivotal.io


See 

Changes:

[jstewart] GEODE-2730: Refactor ServerStarterRule and LocatorStarterRule

--
[...truncated 100.88 KB...]

org.apache.geode.management.UniversalMembershipListenerAdapterDUnitTest >
testSystemClientEventsInServer FAILED
 org.junit.ComparisonFailure: expected:<[67.195.81.148](2333):32771>
but was:<[asf904](2333):32771>
 at org.junit.Assert.assertEquals(Assert.java:115)
 at org.junit.Assert.assertEquals(Assert.java:144)
 at org.apache.geode.management.UniversalMembershipListenerAda
pterDUnitTest.doTestSystemClientEventsInServer(
UniversalMembershipListenerAdapterDUnitTest.java:946)
 at org.apache.geode.management.UniversalMembershipListenerAda
pterDUnitTest.testSystemClientEventsInServer(UniversalMembershipListenerAda
pterDUnitTest.java:731)

6840 tests completed, 2 failed, 603 skipped
:geode-core:distributedTest FAILED
:geode-core:flakyTest
:geode-core:integrationTest
:geode-cq:assemble
:geode-cq:compileTestJavaNote: Some input files use or override a
deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-cq:processTestResources
:geode-cq:testClasses
:geode-cq:checkMissedTests
:geode-cq:spotlessJavaCheck
:geode-cq:spotlessCheck
:geode-cq:test
:geode-cq:check
:geode-cq:build
:geode-cq:distributedTest
:geode-cq:flakyTest
:geode-cq:integrationTest
:geode-json:assemble
:geode-json:compileTestJava UP-TO-DATE
:geode-json:processTestResources
:geode-json:testClasses
:geode-json:checkMissedTests UP-TO-DATE
:geode-json:spotlessJavaCheck
:geode-json:spotlessCheck
:geode-json:test UP-TO-DATE
:geode-json:check
:geode-json:build
:geode-json:distributedTest UP-TO-DATE
:geode-json:flakyTest UP-TO-DATE
:geode-json:integrationTest UP-TO-DATE
:geode-junit:javadoc
:geode-junit:javadocJar
:geode-junit:sourcesJar
:geode-junit:signArchives SKIPPED
:geode-junit:assemble
:geode-junit:compileTestJava
:geode-junit:processTestResources UP-TO-DATE
:geode-junit:testClasses
:geode-junit:checkMissedTests
:geode-junit:spotlessJavaCheck
:geode-junit:spotlessCheck
:geode-junit:test
:geode-junit:check
:geode-junit:build
:geode-junit:distributedTest
:geode-junit:flakyTest
:geode-junit:integrationTest
:geode-lucene:assemble
:geode-lucene:compileTestJavaNote: Some input files use or override a
deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-lucene:processTestResources
:geode-lucene:testClasses
:geode-lucene:checkMissedTests
:geode-lucene:spotlessJavaCheck
:geode-lucene:spotlessCheck
:geode-lucene:test
:geode-lucene:check
:geode-lucene:build
:geode-lucene:distributedTest
:geode-lucene:flakyTest
:geode-lucene:integrationTest
:geode-old-client-support:assemble
:geode-old-client-support:compileTestJava
:geode-old-client-support:processTestResources UP-TO-DATE
:geode-old-client-support:testClasses
:geode-old-client-support:checkMissedTests
:geode-old-client-support:spotlessJavaCheck
:geode-old-client-support:spotlessCheck
:geode-old-client-support:test
:geode-old-client-support:check
:geode-old-client-support:build
:geode-old-client-support:distributedTest
:geode-old-client-support:flakyTest
:geode-old-client-support:integrationTest
:geode-old-versions:javadoc UP-TO-DATE
:geode-old-versions:javadocJar
:geode-old-versions:sourcesJar
:geode-old-versions:signArchives SKIPPED
:geode-old-versions:assemble
:geode-old-versions:compileTestJava UP-TO-DATE
:geode-old-versions:processTestResources UP-TO-DATE
:geode-old-versions:testClasses UP-TO-DATE
:geode-old-versions:checkMissedTests UP-TO-DATE
:geode-old-versions:spotlessJavaCheck
:geode-old-versions:spotlessCheck
:geode-old-versions:test UP-TO-DATE
:geode-old-versions:check
:geode-old-versions:build
:geode-old-versions:distributedTest UP-TO-DATE
:geode-old-versions:flakyTest UP-TO-DATE
:geode-old-versions:integrationTest UP-TO-DATE
:geode-pulse:assemble
:geode-pulse:compileTestJavaNote:  uses or overrides a deprecated API.
Note: Recompile with -Xlint

Global PDX Types -> Move to Region Level?

[Real Wes]

Would there be a negative impact in moving PDXType’s to the region level 
instead of the cache level?  On the positive side, when there is an object with 
a variable number of fields being stored in a partitioned region, we would get 
rid of the distributed lock.  As it is now at the cache level, a DLock is made, 
slowing performance.  Another positive is that export would go much, much, much 
faster in systems with a lot of PDXType’s because all PDXType’s are exported 
with every region.

Thanks,
Wes

[jira] [Created] (GEODE-2743) Adjust gradle build of geode-examples JAR files

[Karen Smoler Miller (JIRA)]

Karen Smoler Miller created GEODE-2743:
--

 Summary: Adjust gradle build of geode-examples JAR files
 Key: GEODE-2743
 URL: https://issues.apache.org/jira/browse/GEODE-2743
 Project: Geode
  Issue Type: Improvement
Reporter: Karen Smoler Miller


With a versioned build of geode-examples, the JAR file created for any specific 
example (right now there are 2, replicated and partitioned) has a version 
number in its file name.  This makes it difficult or impossible to write a 
robust shell script that must place that JAR file on the classpath.  

One idea floated was to just grab whatever JAR file was in the build/libs 
directory and use it on the classpath.  That doesn't work if the developer 
running the examples has used 2 (or more) distinct version of Geode over time, 
such that there are 2 (or more) JAR files in the build/libs directory.

Another idea was to not use shell scripts to run the example.  Just inform the 
developer how to form the correct gfsh commands.  This works, but it makes the 
examples more effort for the developer, who can no longer copy/paste any of the 
commands from the README instructions that explain how to run the example. I 
think it also hobbles a developer of further examples.

Since the examples should be fairly independent of which version of Geode is 
actually running, my proposed solution is for the build to not inject a Geode 
version number into the name of the JAR file. That is what this ticket is meant 
to implement.

Once this is done, both the replicated and partitioned examples will need to be 
revised, since both have scripts that reference versioned files.  

This will also decrease the effort of a release manager, since right now, to 
have a working example, the release manager would need to update the 
geode-examples gradle.properties file (this will always need to be done) and  
the versioned file names that are embedded into an example's scripts.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2743) Adjust gradle build of geode-examples JAR files

[Anthony Baker (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15951412#comment-15951412
 ] 

Anthony Baker commented on GEODE-2743:
--

What geode jar are you referring to above?  If you are suggesting we should 
remove the version from {{geode-core-1.1.0.jar}}, I don't think that is a good 
approach.

> Adjust gradle build of geode-examples JAR files
> ---
>
> Key: GEODE-2743
> URL: https://issues.apache.org/jira/browse/GEODE-2743
> Project: Geode
>  Issue Type: Improvement
>Reporter: Karen Smoler Miller
>
> With a versioned build of geode-examples, the JAR file created for any 
> specific example (right now there are 2, replicated and partitioned) has a 
> version number in its file name.  This makes it difficult or impossible to 
> write a robust shell script that must place that JAR file on the classpath.  
> One idea floated was to just grab whatever JAR file was in the build/libs 
> directory and use it on the classpath.  That doesn't work if the developer 
> running the examples has used 2 (or more) distinct version of Geode over 
> time, such that there are 2 (or more) JAR files in the build/libs directory.
> Another idea was to not use shell scripts to run the example.  Just inform 
> the developer how to form the correct gfsh commands.  This works, but it 
> makes the examples more effort for the developer, who can no longer 
> copy/paste any of the commands from the README instructions that explain how 
> to run the example. I think it also hobbles a developer of further examples.
> Since the examples should be fairly independent of which version of Geode is 
> actually running, my proposed solution is for the build to not inject a Geode 
> version number into the name of the JAR file. That is what this ticket is 
> meant to implement.
> Once this is done, both the replicated and partitioned examples will need to 
> be revised, since both have scripts that reference versioned files.  
> This will also decrease the effort of a release manager, since right now, to 
> have a working example, the release manager would need to update the 
> geode-examples gradle.properties file (this will always need to be done) and  
> the versioned file names that are embedded into an example's scripts.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Fwd: [VOTE] Apache Geode release - v1.1.1 RC2

[John Blum]

+0

I found a conflict in Apache Geode 1.1.0 dependencies, which is not an
extremely important issue (for this patch release), but something to be
conscious of going forward.

Currently, Geode is set to Apache Commons IO *2.3*...

https://github.com/apache/geode/blob/rel/v1.1.1.RC2/gradle/dependency-versions.properties#L32

But, *Spring Shell* 1.2.0.RELEASE...

https://github.com/apache/geode/blob/rel/v1.1.1.RC2/gradle/dependency-versions.properties#L98

... pulls in Apache Commons IO *2.4...*

https://github.com/spring-projects/spring-shell/blob/v1.2.0.RELEASE/gradle.properties#L6


This will be a problem for Geode 1.2.0, which is currently set to Apache
Commons IO *2.5*...

https://github.com/apache/geode/blob/develop/gradle/dependency-versions.properties#L27

Yet based on *Spring Shell* 1.2.0.RELEASE (and by extension Apache Commons
IO *2.4*)...

https://github.com/apache/geode/blob/develop/gradle/dependency-versions.properties#L83

Either the dependencies should align, or appropriate exclusions should be
added to Geode's dependencies.

Thanks,
-j




On Fri, Mar 31, 2017 at 9:58 AM, Bruce Schuchardt 
wrote:

> I don't want to give this a -1 but I'm trying to validate this build on
> Microsoft Windows 7 and am running into problems in geode-test.
>
> In a cygwin shell I ran this:
>
> > git checkout rel/v1.1.1.RC2
> > ./gradlew clean build
>
>blah, blah, blah & then this:
>
>:geode-core:test
>
>org.apache.geode.internal.cache.tier.sockets.command.Execut
> eFunction65Test
> > withOldSecurityShouldSucceedIfAuthorized FAILED
> java.lang.UnsatisfiedLinkError: Could not load library.
>Reasons: [*no jansi64-1.8 in java.library.path, no jansi-1.8 in
>java.library.path, no jansi in java.library.path, Native Library
>C:\cygwin\tmp\jansi-64-1.8.dll already loaded in another classloade*r]
>
>org.apache.geode.internal.cache.tier.sockets.command.Execut
> eFunction65Test
> > withOldSecurityShouldThrowIfNotAuthorized FAILED
> java.lang.NoClassDefFoundError: Could not initialize class
>org.apache.geode.internal.cache.tier.sockets.Message$$Enhan
> cerByMockitoWithCGLIB$$f116767d
>
>org.apache.geode.internal.cache.tier.sockets.command.Execut
> eFunction65Test
> > withIntegratedSecurityShouldSucceedIfAuthorized FAILED
> java.lang.NoClassDefFoundError: Could not initialize class
>org.apache.geode.internal.cache.tier.sockets.Message$$Enhan
> cerByMockitoWithCGLIB$$f116767d
>
>org.apache.geode.internal.cache.tier.sockets.command.Execut
> eFunction65Test
> > withIntegratedSecurityShouldThrowIfNotAuthorized FAILED
> java.lang.NoClassDefFoundError: Could not initialize class
>org.apache.geode.internal.cache.tier.sockets.Message$$Enhan
> cerByMockitoWithCGLIB$$f116767d
>
>org.apache.geode.internal.cache.tier.sockets.command.Execut
> eFunction65Test
> > nonSecureShouldSucceed FAILED
> java.lang.NoClassDefFoundError: Could not initialize class
>org.apache.geode.internal.cache.tier.sockets.Message$$Enhan
> cerByMockitoWithCGLIB$$f116767d
>
>org.apache.geode.internal.cache.tier.sockets.command.Execut
> eFunction66Test
> > withOldSecurityShouldSucceedIfAuthorized FAILED
> java.lang.UnsatisfiedLinkError: Could not load library.
>Reasons: [no jansi64-1.8 in java.library.path, no jansi-1.8 in
>java.library.path, no jansi in java.library.path, Native Library
>C:\cygwin\tmp\jansi-64-1.8.dll already loaded in another classloader]
>
>etc. there's a TON of this
>
>
>
> Le 3/31/2017 à 9:04 AM, Dick Cavender a écrit :
>
>> +1
>>
>> Built source and ran tests successfully on RH.
>>
>> Ran gfsh on binary dist to start and stop locator and system.
>>
>>
>> On 3/30/2017 4:58 PM, Anthony Baker wrote:
>>
>>> Please review and vote (especially if you are a Geode PMC member!).
>>>
>>> Anthony
>>>
>>>
>>>
>>
>


-- 
-John
john.blum10101 (skype)

Re: Review Request 58050: GEODE-2725: export logs --dir now honored when not connected via HTTP[S].

[Patrick Rhomberg]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58050/
---

(Updated March 31, 2017, 6:22 p.m.)


Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, Ken Howe, 
Kirk Lund, and Swapnil Bawaskar.


Changes
---

Suggested edits made.  Paths are now hardware agnostic, tests are cleaned.


Repository: geode


Description
---

export logs --dir refers to local filesystem when connected via HTTP and refers 
to the managers filesystem when connected via JMX.  This behavior will be 
changed in GEODE-2663.


Diffs (updated)
-

  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogCommand.java
 3f147c19a128dce78c51c31e6758e517cd2ab496 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java
 5b1f089c18c404f64929398f6015839eb783ccb4 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsIntegrationTest.java
 268fa397db253f12c0effdbf6faa5e822730144c 
  
geode-core/src/test/resources/org/apache/geode/management/internal/cli/commands/golden-help-offline.properties
 3c56def01ad58f98ea1707f4dd6b57e643e9eab1 


Diff: https://reviews.apache.org/r/58050/diff/4/

Changes: https://reviews.apache.org/r/58050/diff/3-4/


Testing
---

precheckin running.

Manual verification of behavior both with and without --dir option, both 
connected via HTTP and not.


Thanks,

Patrick Rhomberg

Re: Review Request 58050: GEODE-2725: export logs --dir now honored when not connected via HTTP[S].

[Jared Stewart]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58050/#review170749
---


Ship it!




Ship It!

- Jared Stewart


On March 31, 2017, 6:22 p.m., Patrick Rhomberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58050/
> ---
> 
> (Updated March 31, 2017, 6:22 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, Ken Howe, 
> Kirk Lund, and Swapnil Bawaskar.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> export logs --dir refers to local filesystem when connected via HTTP and 
> refers to the managers filesystem when connected via JMX.  This behavior will 
> be changed in GEODE-2663.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogCommand.java
>  3f147c19a128dce78c51c31e6758e517cd2ab496 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java
>  5b1f089c18c404f64929398f6015839eb783ccb4 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsIntegrationTest.java
>  268fa397db253f12c0effdbf6faa5e822730144c 
>   
> geode-core/src/test/resources/org/apache/geode/management/internal/cli/commands/golden-help-offline.properties
>  3c56def01ad58f98ea1707f4dd6b57e643e9eab1 
> 
> 
> Diff: https://reviews.apache.org/r/58050/diff/4/
> 
> 
> Testing
> ---
> 
> precheckin running.
> 
> Manual verification of behavior both with and without --dir option, both 
> connected via HTTP and not.
> 
> 
> Thanks,
> 
> Patrick Rhomberg
> 
>

Re: Review Request 58090: GEODE-2738: Occurred should be spelled with two Rs.

[Jared Stewart]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58090/#review170750
---


Ship it!




Ship It!

- Jared Stewart


On March 31, 2017, 5:25 p.m., Patrick Rhomberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58090/
> ---
> 
> (Updated March 31, 2017, 5:25 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, Ken Howe, 
> Kirk Lund, and Swapnil Bawaskar.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Minor but extensive correction of "occured" to "occurred."
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/DataSerializer.java 
> 627661a8ebbf5f8ffc6a5d2edff6c08f99a4035e 
>   
> geode-core/src/main/java/org/apache/geode/cache/client/internal/ExecuteFunctionNoAckOp.java
>  def738938cc10546a157111ef93c6720cefbbdf2 
>   
> geode-core/src/main/java/org/apache/geode/cache/client/internal/ExecuteRegionFunctionNoAckOp.java
>  06f02d1e6dd2250ef88cc794837905cd678052c0 
>   
> geode-core/src/main/java/org/apache/geode/cache/client/internal/LiveServerPinger.java
>  32d0f8e62096ed714f8eebae6b16f49e0a33e32c 
>   
> geode-core/src/main/java/org/apache/geode/cache/query/internal/AbstractCompiledValue.java
>  d635e024a9fa9cf8e3a7ae812744817ef071be13 
>   
> geode-core/src/main/java/org/apache/geode/cache/query/internal/CompiledSelect.java
>  9b775570ce01e696dc73b8523ff088e585ddf399 
>   
> geode-core/src/main/java/org/apache/geode/cache/query/internal/OrderByComparator.java
>  b9d6026c61209c3e32183f470de05ae41bd17285 
>   
> geode-core/src/main/java/org/apache/geode/cache/query/internal/QueryUtils.java
>  8eaa74a5dad5b8edbed28e9798a7f325fc9bffcf 
>   
> geode-core/src/main/java/org/apache/geode/cache/query/internal/cq/CqAttributesImpl.java
>  7aeee1d95101a95284516a45395a678283eb91b2 
>   
> geode-core/src/main/java/org/apache/geode/cache/query/internal/index/AbstractIndex.java
>  96a3c833f4028cdd2e53c6fb7d74a169e8c8e465 
>   
> geode-core/src/main/java/org/apache/geode/cache/query/internal/index/CompactRangeIndex.java
>  80568f513c5fed3a03d6b6929cb2f3083ecad9aa 
>   
> geode-core/src/main/java/org/apache/geode/cache/query/internal/index/HashIndex.java
>  023fbb465960f366dbe901b586602ed961047b49 
>   
> geode-core/src/main/java/org/apache/geode/cache/query/internal/index/MemoryIndexStore.java
>  e9cd0709e224339ab46d2c3c17c87b3dcb96f1f8 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
>  987e4911272ba6c37046d8e39a1187b71556736d 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/InternalLocator.java
>  4ac2c9c705a344503fd247d39fbc980a27e2d403 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/AbstractRegionMap.java
>  eaababaf6be6041c72156a338c69fa81f10db4c5 
>   geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java 
> b97f4286b6e2352a4ec5637477641d868cb05a6c 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/DistributedRegion.java
>  b9cdfd75c19f3425dacc8f99c1bc399248230b71 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/DistributedRegionFunctionStreamingMessage.java
>  1de8d3b3b97a090a549dbcd866436f8d571fe81e 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
>  15755175fc16609e0341d8c9e97039b5b83ce5d2 
>   geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java 
> 45540eebda466805bedc6ee08fc69203ae278c8b 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/MemberFunctionStreamingMessage.java
>  d0dd08466c0053dfd3f0b1dc58cc68c1c9ce01ad 
>   geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java 
> ca9468d503f5930fb20efa191335ba72d9b081ff 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/PRQueryProcessor.java
>  6df39713fa7986e3ecd6e4c72bd0c7819235472c 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegion.java
>  173f35c73d33c2e88d5b41e7a04055c423908127 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegionDataStore.java
>  5ddf0cb66e2f2e503336a2705a57a6000edd6128 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/PlaceHolderDiskRegion.java
>  db01162aeeba8113c208565d683e71a41d0f6d00 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/ProxyRegionMap.java 
> 92c7b6f8e90a3382e7ce00064581d69f9706fcd3 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/UpdateEntryVersionOperation.java
>  f82f0ce5d92420f27ba8c260069221ee6605254c 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/control/HeapMemoryMonitor.java
>  afc9a23aafba2c1f993b30546f24cd2b5d6a0126 
>   
> geode-core/src/main/java/org/apache/geode/in

[GitHub] geode pull request #436: GEODE-2725: export logs now honors --dir when conne...

[PurelyApplied]

GitHub user PurelyApplied opened a pull request:

https://github.com/apache/geode/pull/436

GEODE-2725: export logs now honors --dir when connected via JMX, with 
respect to the manager's filesystem.

Unchanged behavior of --dir when connected via HTTP.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/PurelyApplied/geode bugfix/GEODE-2725

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/436.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #436


commit 4aa22c1b79dc905f6fcca2398e01a3bb5b9b3da6
Author: Patrick Rhomberg 
Date:   2017-03-30T18:02:20Z

GEODE-2725: export logs now honors --dir when connected via JMX, with 
respect to the manager's filesystem.

commit ea6042339855b3565f5aa1aa91c3986a8a390fe4
Author: Patrick Rhomberg 
Date:   2017-03-31T18:54:06Z

Merge branch 'develop' into bugfix/GEODE-2725

In ExportLogsIntegrationTest, temporarily reverted use of 
LocalLocatorStarterRule back to LocatorStarterRule
for access to the locator working directory.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2725) export logs does not honor --dir

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15951497#comment-15951497
 ] 

ASF GitHub Bot commented on GEODE-2725:
---

GitHub user PurelyApplied opened a pull request:

https://github.com/apache/geode/pull/436

GEODE-2725: export logs now honors --dir when connected via JMX, with 
respect to the manager's filesystem.

Unchanged behavior of --dir when connected via HTTP.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/PurelyApplied/geode bugfix/GEODE-2725

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/436.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #436


commit 4aa22c1b79dc905f6fcca2398e01a3bb5b9b3da6
Author: Patrick Rhomberg 
Date:   2017-03-30T18:02:20Z

GEODE-2725: export logs now honors --dir when connected via JMX, with 
respect to the manager's filesystem.

commit ea6042339855b3565f5aa1aa91c3986a8a390fe4
Author: Patrick Rhomberg 
Date:   2017-03-31T18:54:06Z

Merge branch 'develop' into bugfix/GEODE-2725

In ExportLogsIntegrationTest, temporarily reverted use of 
LocalLocatorStarterRule back to LocatorStarterRule
for access to the locator working directory.




> export logs does not honor --dir
> 
>
> Key: GEODE-2725
> URL: https://issues.apache.org/jira/browse/GEODE-2725
> Project: Geode
>  Issue Type: Sub-task
>  Components: gfsh, logging
>Reporter: Swapnil Bawaskar
>Assignee: Patrick Rhomberg
>
> When connected to locator via jmx, run the following command:
> {noformat}
> gfsh>export logs --dir=tmp
> {noformat}
> Observer that the dir option is ignored:
> {noformat}
> Logs exported to the connected member's file system: 
> /Users/sbawaskar/apache/geode/geode-assembly/build/install/apache-geode/loc1/exportedLogs_1490721273215.zip
> {noformat}
> The --tmp option is honored when connected via http.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #436: GEODE-2725: export logs now honors --dir when conne...

[PurelyApplied]

Github user PurelyApplied closed the pull request at:

https://github.com/apache/geode/pull/436


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2725) export logs does not honor --dir

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15951512#comment-15951512
 ] 

ASF GitHub Bot commented on GEODE-2725:
---

Github user PurelyApplied closed the pull request at:

https://github.com/apache/geode/pull/436


> export logs does not honor --dir
> 
>
> Key: GEODE-2725
> URL: https://issues.apache.org/jira/browse/GEODE-2725
> Project: Geode
>  Issue Type: Sub-task
>  Components: gfsh, logging
>Reporter: Swapnil Bawaskar
>Assignee: Patrick Rhomberg
>
> When connected to locator via jmx, run the following command:
> {noformat}
> gfsh>export logs --dir=tmp
> {noformat}
> Observer that the dir option is ignored:
> {noformat}
> Logs exported to the connected member's file system: 
> /Users/sbawaskar/apache/geode/geode-assembly/build/install/apache-geode/loc1/exportedLogs_1490721273215.zip
> {noformat}
> The --tmp option is honored when connected via http.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #437: GEODE-2653: Fix testRemoveMember and remove FlakyTe...

[galen-pivotal]

GitHub user galen-pivotal opened a pull request:

https://github.com/apache/geode/pull/437

GEODE-2653: Fix testRemoveMember and remove FlakyTest.

And do some cleanup while I'm here:
 * Change Mockito's `any` to `isA`.
 * Replace some `Thread.sleep()` calls with Awaitility calls.
 * Remove our `MethodExecuted` class -- this can be done with 
Mockito's`verify()`.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/galen-pivotal/geode feature/GEODE-2653

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/437.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #437


commit 6ffdee107a000d781c37f9b924b5e56197fbec06
Author: Galen OSullivan 
Date:   2017-03-31T18:44:54Z

GEODE-2653: Fix testRemoveMember and remove FlakyTest.

Test removed self instead of the other member, and used the `any`
matcher instead of `isA`.

commit f0dfd1fc2b468b0482a08726df3b587da05d7102
Author: Galen OSullivan 
Date:   2017-03-31T19:07:23Z

Cleanup GMSJoinLeaveJUnitTest.

* Change Mockito's `any` to `isA`.
* Replace some `Thread.sleep()` calls with Awaitility calls.
* Remove our `MethodExecuted` class -- this can be done with Mockito's
  `verify()`.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native pull request #83: GEODE-2691: Fix function execution attributes...

[dgkimura]

GitHub user dgkimura opened a pull request:

https://github.com/apache/geode-native/pull/83

GEODE-2691: Fix function execution attributes mismatch

Fixes function execution invocation which previously passed in attributes 
that
function execute would compare to the server's view of the registered 
function
attributes. Since the previously passed in attributes were deprecated there 
is
nothing to compare. Instead we should accept the attributes that the server
returns.

Testing: Function execution tests pass

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dgkimura/geode-native feature/GEODE-2691

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/83.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #83


commit c97ef8358c9a9b625316380c823eea029230c5ba
Author: David Kimura 
Date:   2017-03-31T18:33:59Z

GEODE-2691: Fix function execution attributes mismatch

Fixes function execution invocation which previously passed in attributes 
that
function execute would compare to the server's view of the registered 
function
attributes. Since the previously passed in attributes were deprecated there 
is
nothing to compare. Instead we should accept the attributes that the server
returns.

Testing: Function execution tests pass




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2691) Function execution failure with property disable-chunk-handler-thread enabled.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15951515#comment-15951515
 ] 

ASF GitHub Bot commented on GEODE-2691:
---

GitHub user dgkimura opened a pull request:

https://github.com/apache/geode-native/pull/83

GEODE-2691: Fix function execution attributes mismatch

Fixes function execution invocation which previously passed in attributes 
that
function execute would compare to the server's view of the registered 
function
attributes. Since the previously passed in attributes were deprecated there 
is
nothing to compare. Instead we should accept the attributes that the server
returns.

Testing: Function execution tests pass

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dgkimura/geode-native feature/GEODE-2691

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/83.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #83


commit c97ef8358c9a9b625316380c823eea029230c5ba
Author: David Kimura 
Date:   2017-03-31T18:33:59Z

GEODE-2691: Fix function execution attributes mismatch

Fixes function execution invocation which previously passed in attributes 
that
function execute would compare to the server's view of the registered 
function
attributes. Since the previously passed in attributes were deprecated there 
is
nothing to compare. Instead we should accept the attributes that the server
returns.

Testing: Function execution tests pass




> Function execution failure with property disable-chunk-handler-thread enabled.
> --
>
> Key: GEODE-2691
> URL: https://issues.apache.org/jira/browse/GEODE-2691
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>Priority: Critical
>
> If property {{disable-chunk-handler-thread}} enabled the function execution 
> fails with
> {{Unknown message type 61 in response, possible serialization mismatch}} 
> message.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2653) GMSJoinLeaveJUnitTest.testRemoveMember fails with AssertionError

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15951514#comment-15951514
 ] 

ASF GitHub Bot commented on GEODE-2653:
---

GitHub user galen-pivotal opened a pull request:

https://github.com/apache/geode/pull/437

GEODE-2653: Fix testRemoveMember and remove FlakyTest.

And do some cleanup while I'm here:
 * Change Mockito's `any` to `isA`.
 * Replace some `Thread.sleep()` calls with Awaitility calls.
 * Remove our `MethodExecuted` class -- this can be done with 
Mockito's`verify()`.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/galen-pivotal/geode feature/GEODE-2653

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/437.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #437


commit 6ffdee107a000d781c37f9b924b5e56197fbec06
Author: Galen OSullivan 
Date:   2017-03-31T18:44:54Z

GEODE-2653: Fix testRemoveMember and remove FlakyTest.

Test removed self instead of the other member, and used the `any`
matcher instead of `isA`.

commit f0dfd1fc2b468b0482a08726df3b587da05d7102
Author: Galen OSullivan 
Date:   2017-03-31T19:07:23Z

Cleanup GMSJoinLeaveJUnitTest.

* Change Mockito's `any` to `isA`.
* Replace some `Thread.sleep()` calls with Awaitility calls.
* Remove our `MethodExecuted` class -- this can be done with Mockito's
  `verify()`.




> GMSJoinLeaveJUnitTest.testRemoveMember fails with AssertionError
> 
>
> Key: GEODE-2653
> URL: https://issues.apache.org/jira/browse/GEODE-2653
> Project: Geode
>  Issue Type: Bug
>  Components: membership, tests
>Reporter: Kirk Lund
>Assignee: Galen O'Sullivan
>  Labels: Flaky
>
> Intermittent failure stack:
> {noformat}
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeaveJUnitTest
>  > testRemoveMember FAILED
> java.lang.AssertionError
> at org.junit.Assert.fail(Assert.java:86)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.junit.Assert.assertTrue(Assert.java:52)
> at 
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeaveJUnitTest.testRemoveMember(GMSJoinLeaveJUnitTest.java:337)
> {noformat}
> This test looks like it's flaky due to the Thread sleep:
> {noformat}
>   @Test
>   public void testRemoveMember() throws Exception {
> initMocks();
> prepareAndInstallView(mockMembers[0], createMemberList(mockMembers[0], 
> gmsJoinLeaveMemberId));
> MethodExecuted removeMessageSent = new MethodExecuted();
> 
> when(messenger.send(any(RemoveMemberMessage.class))).thenAnswer(removeMessageSent);
> gmsJoinLeave.remove(mockMembers[0], "removing for test");
> Thread.sleep(ServiceConfig.MEMBER_REQUEST_COLLECTION_INTERVAL * 2);
> assertTrue(removeMessageSent.methodExecuted);
>   }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2744) Dependency version conflict between spring shell and commons IO

[Anthony Baker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anthony Baker updated GEODE-2744:
-
Priority: Minor  (was: Major)

> Dependency version conflict between spring shell and commons IO
> ---
>
> Key: GEODE-2744
> URL: https://issues.apache.org/jira/browse/GEODE-2744
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Reporter: Anthony Baker
>Priority: Minor
>
> Spring Shell v1.2.0.RELEASE depends on commons-io-2.4.
> In Geode v1.1.x, we specify commons-io-2.3.
> In Geode v1.2.0-SNAPSHOT, we specify commons-2.5.
> We should make this consistent or add an exclusion rule.
> http://mail-archives.apache.org/mod_mbox/geode-dev/201703.mbox/%3cCAF3UAT0K=5_xocgx_yquj+frdfk2hbkqv4wu04ao2pdvfof...@mail.gmail.com%3e



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2744) Dependency version conflict between spring shell and commons IO

[Anthony Baker (JIRA)]

Anthony Baker created GEODE-2744:


 Summary: Dependency version conflict between spring shell and 
commons IO
 Key: GEODE-2744
 URL: https://issues.apache.org/jira/browse/GEODE-2744
 Project: Geode
  Issue Type: Bug
  Components: build
Reporter: Anthony Baker


Spring Shell v1.2.0.RELEASE depends on commons-io-2.4.

In Geode v1.1.x, we specify commons-io-2.3.

In Geode v1.2.0-SNAPSHOT, we specify commons-2.5.

We should make this consistent or add an exclusion rule.

http://mail-archives.apache.org/mod_mbox/geode-dev/201703.mbox/%3cCAF3UAT0K=5_xocgx_yquj+frdfk2hbkqv4wu04ao2pdvfof...@mail.gmail.com%3e




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: [VOTE] Apache Geode release - v1.1.1 RC2

[Anthony Baker]

Thanks for the bug report.  I filed this as 
https://issues.apache.org/jira/browse/GEODE-2744.

Anthony

> On Mar 31, 2017, at 11:20 AM, John Blum  wrote:
> 
> +0
> 
> I found a conflict in Apache Geode 1.1.0 dependencies, which is not an
> extremely important issue (for this patch release), but something to be
> conscious of going forward.
> 
> Currently, Geode is set to Apache Commons IO *2.3*...
> 
> https://github.com/apache/geode/blob/rel/v1.1.1.RC2/gradle/dependency-versions.properties#L32
> 
> But, *Spring Shell* 1.2.0.RELEASE...
> 
> https://github.com/apache/geode/blob/rel/v1.1.1.RC2/gradle/dependency-versions.properties#L98
> 
> ... pulls in Apache Commons IO *2.4...*
> 
> https://github.com/spring-projects/spring-shell/blob/v1.2.0.RELEASE/gradle.properties#L6
> 
> 
> This will be a problem for Geode 1.2.0, which is currently set to Apache
> Commons IO *2.5*...
> 
> https://github.com/apache/geode/blob/develop/gradle/dependency-versions.properties#L27
> 
> Yet based on *Spring Shell* 1.2.0.RELEASE (and by extension Apache Commons
> IO *2.4*)...
> 
> https://github.com/apache/geode/blob/develop/gradle/dependency-versions.properties#L83
> 
> Either the dependencies should align, or appropriate exclusions should be
> added to Geode's dependencies.
> 
> Thanks,
> -j
> 
> 
> 
> 
> On Fri, Mar 31, 2017 at 9:58 AM, Bruce Schuchardt 
> wrote:
> 
>> I don't want to give this a -1 but I'm trying to validate this build on
>> Microsoft Windows 7 and am running into problems in geode-test.
>> 
>> In a cygwin shell I ran this:
>> 
>>> git checkout rel/v1.1.1.RC2
>>> ./gradlew clean build
>> 
>>   blah, blah, blah & then this:
>> 
>>   :geode-core:test
>> 
>>   org.apache.geode.internal.cache.tier.sockets.command.Execut
>> eFunction65Test
>>> withOldSecurityShouldSucceedIfAuthorized FAILED
>>java.lang.UnsatisfiedLinkError: Could not load library.
>>   Reasons: [*no jansi64-1.8 in java.library.path, no jansi-1.8 in
>>   java.library.path, no jansi in java.library.path, Native Library
>>   C:\cygwin\tmp\jansi-64-1.8.dll already loaded in another classloade*r]
>> 
>>   org.apache.geode.internal.cache.tier.sockets.command.Execut
>> eFunction65Test
>>> withOldSecurityShouldThrowIfNotAuthorized FAILED
>>java.lang.NoClassDefFoundError: Could not initialize class
>>   org.apache.geode.internal.cache.tier.sockets.Message$$Enhan
>> cerByMockitoWithCGLIB$$f116767d
>> 
>>   org.apache.geode.internal.cache.tier.sockets.command.Execut
>> eFunction65Test
>>> withIntegratedSecurityShouldSucceedIfAuthorized FAILED
>>java.lang.NoClassDefFoundError: Could not initialize class
>>   org.apache.geode.internal.cache.tier.sockets.Message$$Enhan
>> cerByMockitoWithCGLIB$$f116767d
>> 
>>   org.apache.geode.internal.cache.tier.sockets.command.Execut
>> eFunction65Test
>>> withIntegratedSecurityShouldThrowIfNotAuthorized FAILED
>>java.lang.NoClassDefFoundError: Could not initialize class
>>   org.apache.geode.internal.cache.tier.sockets.Message$$Enhan
>> cerByMockitoWithCGLIB$$f116767d
>> 
>>   org.apache.geode.internal.cache.tier.sockets.command.Execut
>> eFunction65Test
>>> nonSecureShouldSucceed FAILED
>>java.lang.NoClassDefFoundError: Could not initialize class
>>   org.apache.geode.internal.cache.tier.sockets.Message$$Enhan
>> cerByMockitoWithCGLIB$$f116767d
>> 
>>   org.apache.geode.internal.cache.tier.sockets.command.Execut
>> eFunction66Test
>>> withOldSecurityShouldSucceedIfAuthorized FAILED
>>java.lang.UnsatisfiedLinkError: Could not load library.
>>   Reasons: [no jansi64-1.8 in java.library.path, no jansi-1.8 in
>>   java.library.path, no jansi in java.library.path, Native Library
>>   C:\cygwin\tmp\jansi-64-1.8.dll already loaded in another classloader]
>> 
>>   etc. there's a TON of this
>> 
>> 
>> 
>> Le 3/31/2017 à 9:04 AM, Dick Cavender a écrit :
>> 
>>> +1
>>> 
>>> Built source and ran tests successfully on RH.
>>> 
>>> Ran gfsh on binary dist to start and stop locator and system.
>>> 
>>> 
>>> On 3/30/2017 4:58 PM, Anthony Baker wrote:
>>> 
 Please review and vote (especially if you are a Geode PMC member!).
 
 Anthony
 
 
 
>>> 
>> 
> 
> 
> -- 
> -John
> john.blum10101 (skype)

[jira] [Updated] (GEODE-2744) Dependency version conflict between spring shell and commons IO

[Anthony Baker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anthony Baker updated GEODE-2744:
-
Affects Version/s: 1.1.0

> Dependency version conflict between spring shell and commons IO
> ---
>
> Key: GEODE-2744
> URL: https://issues.apache.org/jira/browse/GEODE-2744
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Affects Versions: 1.1.0
>Reporter: Anthony Baker
>Priority: Minor
>
> Spring Shell v1.2.0.RELEASE depends on commons-io-2.4.
> In Geode v1.1.x, we specify commons-io-2.3.
> In Geode v1.2.0-SNAPSHOT, we specify commons-2.5.
> We should make this consistent or add an exclusion rule.
> http://mail-archives.apache.org/mod_mbox/geode-dev/201703.mbox/%3cCAF3UAT0K=5_xocgx_yquj+frdfk2hbkqv4wu04ao2pdvfof...@mail.gmail.com%3e



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 58080: GEODE-2420: Add classes to estimated the size of exported logs

[Ken Howe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58080/
---

(Updated March 31, 2017, 7:55 p.m.)


Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, Kirk Lund, 
and Patrick Rhomberg.


Changes
---

Updates from review


Repository: geode


Description
---

- New Function class added with tests
- Code to invoke new function added, but disabled, in ExportLogsCommand
- New option added, but disabled, for specifying size limit for exported
  logs
- Refactoring: extracted the interceptor from ExportLogsCommand
- Refactoring: renamed ExportLogCommand to ExportLogsCommand
- New Serializable class to return the log size estimate to the command
- Tests for the log sizing related classes

This is work-in-progress that is adds sizing estimation for exported logs, but 
the code is currently not called by ExportLogsCommand. Follow-on work will use 
the new sizing estimation to provide warnings to the user if exporting logs may 
fill up disks on servers or the locator.


Diffs (updated)
-

  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogCommand.java
 3f147c19a128dce78c51c31e6758e517cd2ab496 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogsInterceptor.java
 PRE-CREATION 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/ExportLogsFunction.java
 cbdf1c4bc28554a8fbec3740c566ee07c69b4ac9 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/ExportedLogsSizeInfo.java
 PRE-CREATION 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/SizeExportLogsFunction.java
 PRE-CREATION 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java
 5b1f089c18c404f64929398f6015839eb783ccb4 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/util/LogSizer.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsCommandTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsDUnitTest.java
 95edd426da8b8f39bb1486661d8c307d43f170d6 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsFileSizeLimitTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsIntegrationTest.java
 268fa397db253f12c0effdbf6faa5e822730144c 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsInterceptorJUnitTest.java
 573701fd7f48c8c1b72c0f71993a4adea7bdbe8b 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsStatsDUnitTest.java
 5a4d274a751a6e22fcfbc0c5e6bd5dff39e3b938 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsTestSuite.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/LogLevelInterceptorTest.java
 41b971534fd83c87f33751fa46454e158315f6ae 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/ExportedLogsSizeInfoTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/SizeExportLogsFunctionCacheTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/SizeExportLogsFunctionFileTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/SizeExportLogsTestSuite.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/util/LogSizerTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java
 6ae82da58923fdf3a44217c1773a40d8ff1001bc 
  
geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedDataSerializables.txt
 2f5a5cdf8c59e90625fe01c3306462e9277ab4e1 
  
geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedSerializables.txt
 397ec14c0bbbea277d378eefcaecfdb90cc9e224 


Diff: https://reviews.apache.org/r/58080/diff/2/

Changes: https://reviews.apache.org/r/58080/diff/1-2/


Testing
---

Precheckin is running

I need to debug one test of the new class that is still failing:

org.apache.geode.management.internal.cli.functions.SizeExportLogsFunctionCacheTest
 > withFunctionError_shouldThrow FAILED
org.apache.geode.GemFireConfigException: The locators attribute can not be 
empty when the mcast-port attribute is non-zero.
at 
org.apache.geode.distributed.internal.InternalDistributedSystem.initialize(InternalDistributedSystem.java:558)
at 
org.apache.geode.distributed.internal.InternalDistributedSystem.newInstance(InternalDistributedSystem.java:299)
at 
org.apache.geode.distributed.DistributedSystem.connect(DistributedSy

[jira] [Commented] (GEODE-2743) Adjust gradle build of geode-examples JAR files

[Karen Smoler Miller (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15951564#comment-15951564
 ] 

Karen Smoler Miller commented on GEODE-2743:


I'm talking about an application's JAR, where the application is built as part 
of a particular geode-examples repo example.  The partitioned example builds a 
JAR for the Producer, Consumer, EmployeeKey, and EmployeeData classes.  Today 
(before Geode 1.2 is released), the gradle build names this JAR file 
{{partitioned-1.2.0-SNAPSHOT.jar}}.  I want this JAR file to be named 
partitioned.jar, or similar, but without the '1.2.0-SNAPSHOT' portion.  This 
JAR represents code used in the example that ought to work with pretty much any 
version of Geode, unless there is some remarkably drastic change to the API.

> Adjust gradle build of geode-examples JAR files
> ---
>
> Key: GEODE-2743
> URL: https://issues.apache.org/jira/browse/GEODE-2743
> Project: Geode
>  Issue Type: Improvement
>Reporter: Karen Smoler Miller
>
> With a versioned build of geode-examples, the JAR file created for any 
> specific example (right now there are 2, replicated and partitioned) has a 
> version number in its file name.  This makes it difficult or impossible to 
> write a robust shell script that must place that JAR file on the classpath.  
> One idea floated was to just grab whatever JAR file was in the build/libs 
> directory and use it on the classpath.  That doesn't work if the developer 
> running the examples has used 2 (or more) distinct version of Geode over 
> time, such that there are 2 (or more) JAR files in the build/libs directory.
> Another idea was to not use shell scripts to run the example.  Just inform 
> the developer how to form the correct gfsh commands.  This works, but it 
> makes the examples more effort for the developer, who can no longer 
> copy/paste any of the commands from the README instructions that explain how 
> to run the example. I think it also hobbles a developer of further examples.
> Since the examples should be fairly independent of which version of Geode is 
> actually running, my proposed solution is for the build to not inject a Geode 
> version number into the name of the JAR file. That is what this ticket is 
> meant to implement.
> Once this is done, both the replicated and partitioned examples will need to 
> be revised, since both have scripts that reference versioned files.  
> This will also decrease the effort of a release manager, since right now, to 
> have a working example, the release manager would need to update the 
> geode-examples gradle.properties file (this will always need to be done) and  
> the versioned file names that are embedded into an example's scripts.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2231) Create new partitioning example

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15951576#comment-15951576
 ] 

ASF subversion and git services commented on GEODE-2231:


Commit d551b7c7e999ee7f9774f9d84b72c3a06a770fd7 in geode-examples's branch 
refs/heads/develop from [~karensmolermiller]
[ https://git-wip-us.apache.org/repos/asf?p=geode-examples.git;h=d551b7c ]

GEODE-2231 A partitioned region example

- partitioned/README.md has instructions for running this
example


> Create new partitioning example
> ---
>
> Key: GEODE-2231
> URL: https://issues.apache.org/jira/browse/GEODE-2231
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>Priority: Minor
>
> Add a new example to the geode-examples that demonstrates partitioning.
> The example will use the same structure as the replicated example, starting 2 
> servers that host a partitioned region (with no redundant copies).  Run the 
> producer to populate the region.  Run the consumer to see the contents of the 
> region. Then, stop one of the servers and run the consumer again to notice 
> that only roughly half (with 2 servers and hopefully a reasonable hash) of 
> the entries are present.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-examples pull request #3: GEODE-2231 A partitioned region example

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode-examples/pull/3


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2231) Create new partitioning example

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15951578#comment-15951578
 ] 

ASF subversion and git services commented on GEODE-2231:


Commit 912f7b8ddca82ded1b67456d9c70f3179639cb30 in geode-examples's branch 
refs/heads/develop from [~karensmolermiller]
[ https://git-wip-us.apache.org/repos/asf?p=geode-examples.git;h=912f7b8 ]

GEODE-2231 tweak partitioned geode-examples per reviews

- revise README.md to address review comments
- remove unneeded comments


> Create new partitioning example
> ---
>
> Key: GEODE-2231
> URL: https://issues.apache.org/jira/browse/GEODE-2231
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>Priority: Minor
>
> Add a new example to the geode-examples that demonstrates partitioning.
> The example will use the same structure as the replicated example, starting 2 
> servers that host a partitioned region (with no redundant copies).  Run the 
> producer to populate the region.  Run the consumer to see the contents of the 
> region. Then, stop one of the servers and run the consumer again to notice 
> that only roughly half (with 2 servers and hopefully a reasonable hash) of 
> the entries are present.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2231) Create new partitioning example

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15951579#comment-15951579
 ] 

ASF GitHub Bot commented on GEODE-2231:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode-examples/pull/3


> Create new partitioning example
> ---
>
> Key: GEODE-2231
> URL: https://issues.apache.org/jira/browse/GEODE-2231
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>Priority: Minor
>
> Add a new example to the geode-examples that demonstrates partitioning.
> The example will use the same structure as the replicated example, starting 2 
> servers that host a partitioned region (with no redundant copies).  Run the 
> producer to populate the region.  Run the consumer to see the contents of the 
> region. Then, stop one of the servers and run the consumer again to notice 
> that only roughly half (with 2 servers and hopefully a reasonable hash) of 
> the entries are present.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2231) Create new partitioning example

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15951577#comment-15951577
 ] 

ASF subversion and git services commented on GEODE-2231:


Commit e3e9f756e8a464dc7c67a1035620f68ff17223cf in geode-examples's branch 
refs/heads/develop from [~karensmolermiller]
[ https://git-wip-us.apache.org/repos/asf?p=geode-examples.git;h=e3e9f75 ]

GEODE-2231 Revise partitioning example

- remove spurious .iml files
- simplify by removing BaseClient base class
- only demonstate good distribution of keys
- revise README.md


> Create new partitioning example
> ---
>
> Key: GEODE-2231
> URL: https://issues.apache.org/jira/browse/GEODE-2231
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>Priority: Minor
>
> Add a new example to the geode-examples that demonstrates partitioning.
> The example will use the same structure as the replicated example, starting 2 
> servers that host a partitioned region (with no redundant copies).  Run the 
> producer to populate the region.  Run the consumer to see the contents of the 
> region. Then, stop one of the servers and run the consumer again to notice 
> that only roughly half (with 2 servers and hopefully a reasonable hash) of 
> the entries are present.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2231) Create new partitioning example

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15951580#comment-15951580
 ] 

ASF subversion and git services commented on GEODE-2231:


Commit 47008179efd65bfefac6ee8a6b3ee54719240e2c in geode-examples's branch 
refs/heads/develop from [~karensmolermiller]
[ https://git-wip-us.apache.org/repos/asf?p=geode-examples.git;h=4700817 ]

Merge branch 'feature/GEODE-2231' into develop

  This closes #3


> Create new partitioning example
> ---
>
> Key: GEODE-2231
> URL: https://issues.apache.org/jira/browse/GEODE-2231
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>Priority: Minor
>
> Add a new example to the geode-examples that demonstrates partitioning.
> The example will use the same structure as the replicated example, starting 2 
> servers that host a partitioned region (with no redundant copies).  Run the 
> producer to populate the region.  Run the consumer to see the contents of the 
> region. Then, stop one of the servers and run the consumer again to notice 
> that only roughly half (with 2 servers and hopefully a reasonable hash) of 
> the entries are present.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-examples issue #3: GEODE-2231 A partitioned region example

[karensmolermiller]

Github user karensmolermiller commented on the issue:

https://github.com/apache/geode-examples/pull/3
  
Thanks everyone for all the reviews, help, and suggestions.  I've merged 
this partitioned example into develop.  There is always more work that can 
improve this example, as well as the examples as a whole.  I opened GEODE-2743 
as one suggested improvement.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2231) Create new partitioning example

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15951583#comment-15951583
 ] 

ASF GitHub Bot commented on GEODE-2231:
---

Github user karensmolermiller commented on the issue:

https://github.com/apache/geode-examples/pull/3
  
Thanks everyone for all the reviews, help, and suggestions.  I've merged 
this partitioned example into develop.  There is always more work that can 
improve this example, as well as the examples as a whole.  I opened GEODE-2743 
as one suggested improvement.


> Create new partitioning example
> ---
>
> Key: GEODE-2231
> URL: https://issues.apache.org/jira/browse/GEODE-2231
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>Priority: Minor
>
> Add a new example to the geode-examples that demonstrates partitioning.
> The example will use the same structure as the replicated example, starting 2 
> servers that host a partitioned region (with no redundant copies).  Run the 
> producer to populate the region.  Run the consumer to see the contents of the 
> region. Then, stop one of the servers and run the consumer again to notice 
> that only roughly half (with 2 servers and hopefully a reasonable hash) of 
> the entries are present.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-2231) Create new partitioning example

[Karen Smoler Miller (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karen Smoler Miller resolved GEODE-2231.

Resolution: Fixed

> Create new partitioning example
> ---
>
> Key: GEODE-2231
> URL: https://issues.apache.org/jira/browse/GEODE-2231
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>Priority: Minor
> Fix For: 1.2.0
>
>
> Add a new example to the geode-examples that demonstrates partitioning.
> The example will use the same structure as the replicated example, starting 2 
> servers that host a partitioned region (with no redundant copies).  Run the 
> producer to populate the region.  Run the consumer to see the contents of the 
> region. Then, stop one of the servers and run the consumer again to notice 
> that only roughly half (with 2 servers and hopefully a reasonable hash) of 
> the entries are present.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2231) Create new partitioning example

[Karen Smoler Miller (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karen Smoler Miller updated GEODE-2231:
---
Fix Version/s: 1.2.0

> Create new partitioning example
> ---
>
> Key: GEODE-2231
> URL: https://issues.apache.org/jira/browse/GEODE-2231
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>Priority: Minor
> Fix For: 1.2.0
>
>
> Add a new example to the geode-examples that demonstrates partitioning.
> The example will use the same structure as the replicated example, starting 2 
> servers that host a partitioned region (with no redundant copies).  Run the 
> producer to populate the region.  Run the consumer to see the contents of the 
> region. Then, stop one of the servers and run the consumer again to notice 
> that only roughly half (with 2 servers and hopefully a reasonable hash) of 
> the entries are present.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #83: GEODE-2691: Fix function execution attributes...

[PivotalSarge]

Github user PivotalSarge commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/83#discussion_r109242439
  
--- Diff: src/cppcache/src/ExecutionImpl.cpp ---
@@ -100,33 +94,31 @@ ResultCollectorPtr ExecutionImpl::execute(const char* 
fn, uint32_t timeout,
   bool serverIsHA = false;
   bool serverOptimizeForWrite = false;
 
-  if (verifyFuncArgs) {
-std::vector* attr = getFunctionAttributes(fn);
-{
+  std::vector* attr = getFunctionAttributes(fn);
+  {
--- End diff --

What is the purpose of this curly-brace block? Is there an RAII instance in 
there?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2691) Function execution failure with property disable-chunk-handler-thread enabled.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15951591#comment-15951591
 ] 

ASF GitHub Bot commented on GEODE-2691:
---

Github user PivotalSarge commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/83#discussion_r109242439
  
--- Diff: src/cppcache/src/ExecutionImpl.cpp ---
@@ -100,33 +94,31 @@ ResultCollectorPtr ExecutionImpl::execute(const char* 
fn, uint32_t timeout,
   bool serverIsHA = false;
   bool serverOptimizeForWrite = false;
 
-  if (verifyFuncArgs) {
-std::vector* attr = getFunctionAttributes(fn);
-{
+  std::vector* attr = getFunctionAttributes(fn);
+  {
--- End diff --

What is the purpose of this curly-brace block? Is there an RAII instance in 
there?


> Function execution failure with property disable-chunk-handler-thread enabled.
> --
>
> Key: GEODE-2691
> URL: https://issues.apache.org/jira/browse/GEODE-2691
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>Priority: Critical
>
> If property {{disable-chunk-handler-thread}} enabled the function execution 
> fails with
> {{Unknown message type 61 in response, possible serialization mismatch}} 
> message.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2708) Update Gradle Wrapper to Gradle 3

[Mark Bretl (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15951620#comment-15951620
 ] 

Mark Bretl commented on GEODE-2708:
---

Using Gradle 3.4.1, I executed './gradlew clean build' and the build was 
successful. There were some deprecation warnings, but those can be cleaned up 
after.

Running 'precheckin' to verify functionality with other types of tests.

> Update Gradle Wrapper to Gradle 3
> -
>
> Key: GEODE-2708
> URL: https://issues.apache.org/jira/browse/GEODE-2708
> Project: Geode
>  Issue Type: Task
>  Components: build
>Reporter: Galen O'Sullivan
>
> It looks like we're still running on a very old version of Gradle. This may 
> be related to incremental builds not working properly.
> {code}
> $ ./gradlew --version
> 
> Gradle 2.14.1
> 
> Build time:   2016-07-18 06:38:37 UTC
> Revision: d9e2113d9fb05a5caabba61798bdb8dfdca83719
> Groovy:   2.4.4
> Ant:  Apache Ant(TM) version 1.9.6 compiled on June 29 2015
> JVM:  1.8.0_111 (Oracle Corporation 25.111-b14)
> OS:   Mac OS X 10.12.3 x86_64
> $ gradle --version
> 
> Gradle 3.4.1
> 
> Build time:   2017-03-03 19:45:41 UTC
> Revision: 9eb76efdd3d034dc506c719dac2955efb5ff9a93
> Groovy:   2.4.7
> Ant:  Apache Ant(TM) version 1.9.6 compiled on June 29 2015
> JVM:  1.8.0_111 (Oracle Corporation 25.111-b14)
> OS:   Mac OS X 10.12.3 x86_64
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: [VOTE] Apache Geode release - v1.1.1 RC2

[Anthony Baker]

> On Mar 31, 2017, at 9:58 AM, Bruce Schuchardt  wrote:
> 
> I don't want to give this a -1 but I'm trying to validate this build on 
> Microsoft Windows 7 and am running into problems in geode-test.

I agree.  I checked this and found the build error on windows goes back before 
v1.0.0-incubating.M2.  The develop branch doesn’t seem to exhibit this problem.

Anthony

[jira] [Commented] (GEODE-2638) A GatewaySender fails to start if it attempts to connect to a remote locator that is an unresolvable hostname

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15951661#comment-15951661
 ] 

ASF subversion and git services commented on GEODE-2638:


Commit ac6937e99b6d839c4c4f1fe250ce4433eee7e53b in geode's branch 
refs/heads/develop from [~barry.oglesby]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=ac6937e ]

GEODE-2638: Updated tests to not hardcode unknown host name


> A GatewaySender fails to start if it attempts to connect to a remote locator 
> that is an unresolvable hostname
> -
>
> Key: GEODE-2638
> URL: https://issues.apache.org/jira/browse/GEODE-2638
> Project: Geode
>  Issue Type: Bug
>  Components: wan
>Reporter: Barry Oglesby
> Fix For: 1.2.0
>
>
> A GatewaySender fails to start if it attempts to connect to a remote locator 
> that is an unresolvable hostname.
> An exception like below is thrown:
> {noformat}
> [severe 2017/03/08 16:34:14.927 PST ln-1  GatewaySender_ny_3> tid=0x3a] Message dispatch failed due to unexpected 
> exception..
> org.apache.geode.InternalGemFireException: Failed getting host from name:  
> unknown
>   at 
> org.apache.geode.internal.admin.remote.DistributionLocatorId.(DistributionLocatorId.java:132)
>   at 
> org.apache.geode.internal.cache.wan.AbstractRemoteGatewaySender.initProxy(AbstractRemoteGatewaySender.java:104)
>   at 
> org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher.initializeConnection(GatewaySenderEventRemoteDispatcher.java:372)
>   at 
> org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher.(GatewaySenderEventRemoteDispatcher.java:78)
>   at 
> org.apache.geode.internal.cache.wan.parallel.RemoteParallelGatewaySenderEventProcessor.initializeEventDispatcher(RemoteParallelGatewaySenderEventProcessor.java:74)
>   at 
> org.apache.geode.internal.cache.wan.AbstractGatewaySenderEventProcessor.setRunningStatus(AbstractGatewaySenderEventProcessor.java:1063)
>   at 
> org.apache.geode.internal.cache.wan.AbstractGatewaySenderEventProcessor.run(AbstractGatewaySenderEventProcessor.java:1035)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Fwd: [VOTE] Apache Geode release - v1.1.1 RC2

[Bruce Schuchardt]

I tried the 1.1.0 tag and had the same problem so maybe this isn't a 
show-stopper for 1.1.1.


As a side note, I commented out the runtime dependency of geode-core on 
jansi and "gradlew clean build" finished successfully as did a handlful 
of distributedTests.



Le 3/31/2017 à 9:58 AM, Bruce Schuchardt a écrit :
I don't want to give this a -1 but I'm trying to validate this build 
on Microsoft Windows 7 and am running into problems in geode-test.


In a cygwin shell I ran this:

> git checkout rel/v1.1.1.RC2
> ./gradlew clean build

blah, blah, blah & then this:

:geode-core:test

org.apache.geode.internal.cache.tier.sockets.command.ExecuteFunction65Test
> withOldSecurityShouldSucceedIfAuthorized FAILED
java.lang.UnsatisfiedLinkError: Could not load library.
Reasons: [*no jansi64-1.8 in java.library.path, no jansi-1.8 in
java.library.path, no jansi in java.library.path, Native Library
C:\cygwin\tmp\jansi-64-1.8.dll already loaded in another classloade*r]

org.apache.geode.internal.cache.tier.sockets.command.ExecuteFunction65Test
> withOldSecurityShouldThrowIfNotAuthorized FAILED
java.lang.NoClassDefFoundError: Could not initialize class

org.apache.geode.internal.cache.tier.sockets.Message$$EnhancerByMockitoWithCGLIB$$f116767d

org.apache.geode.internal.cache.tier.sockets.command.ExecuteFunction65Test
> withIntegratedSecurityShouldSucceedIfAuthorized FAILED
java.lang.NoClassDefFoundError: Could not initialize class

org.apache.geode.internal.cache.tier.sockets.Message$$EnhancerByMockitoWithCGLIB$$f116767d

org.apache.geode.internal.cache.tier.sockets.command.ExecuteFunction65Test
> withIntegratedSecurityShouldThrowIfNotAuthorized FAILED
java.lang.NoClassDefFoundError: Could not initialize class

org.apache.geode.internal.cache.tier.sockets.Message$$EnhancerByMockitoWithCGLIB$$f116767d

org.apache.geode.internal.cache.tier.sockets.command.ExecuteFunction65Test
> nonSecureShouldSucceed FAILED
java.lang.NoClassDefFoundError: Could not initialize class

org.apache.geode.internal.cache.tier.sockets.Message$$EnhancerByMockitoWithCGLIB$$f116767d

org.apache.geode.internal.cache.tier.sockets.command.ExecuteFunction66Test
> withOldSecurityShouldSucceedIfAuthorized FAILED
java.lang.UnsatisfiedLinkError: Could not load library.
Reasons: [no jansi64-1.8 in java.library.path, no jansi-1.8 in
java.library.path, no jansi in java.library.path, Native Library
C:\cygwin\tmp\jansi-64-1.8.dll already loaded in another classloader]

etc. there's a TON of this


Le 3/31/2017 à 9:04 AM, Dick Cavender a écrit :

+1

Built source and ran tests successfully on RH.

Ran gfsh on binary dist to start and stop locator and system.


On 3/30/2017 4:58 PM, Anthony Baker wrote:

Please review and vote (especially if you are a Geode PMC member!).

Anthony

Re: [VOTE] Apache Geode release - v1.1.1 RC2

[Anthony Baker]

Interesting.  jansi has been upgraded on develop from 1.8 -> 1.14.

> On Mar 31, 2017, at 2:19 PM, Bruce Schuchardt  wrote:
> 
> I tried the 1.1.0 tag and had the same problem so maybe this isn't a 
> show-stopper for 1.1.1.
> 
> As a side note, I commented out the runtime dependency of geode-core on jansi 
> and "gradlew clean build" finished successfully as did a handlful of 
> distributedTests.
> 
> 
> Le 3/31/2017 à 9:58 AM, Bruce Schuchardt a écrit :
>> I don't want to give this a -1 but I'm trying to validate this build on 
>> Microsoft Windows 7 and am running into problems in geode-test.
>> 
>> In a cygwin shell I ran this:
>> 
>> > git checkout rel/v1.1.1.RC2
>> > ./gradlew clean build
>> 
>>blah, blah, blah & then this:
>> 
>>:geode-core:test
>> 
>>org.apache.geode.internal.cache.tier.sockets.command.ExecuteFunction65Test
>>> withOldSecurityShouldSucceedIfAuthorized FAILED
>>java.lang.UnsatisfiedLinkError: Could not load library.
>>Reasons: [*no jansi64-1.8 in java.library.path, no jansi-1.8 in
>>java.library.path, no jansi in java.library.path, Native Library
>>C:\cygwin\tmp\jansi-64-1.8.dll already loaded in another classloade*r]
>> 
>>org.apache.geode.internal.cache.tier.sockets.command.ExecuteFunction65Test
>>> withOldSecurityShouldThrowIfNotAuthorized FAILED
>>java.lang.NoClassDefFoundError: Could not initialize class
>>
>> org.apache.geode.internal.cache.tier.sockets.Message$$EnhancerByMockitoWithCGLIB$$f116767d
>> 
>>org.apache.geode.internal.cache.tier.sockets.command.ExecuteFunction65Test
>>> withIntegratedSecurityShouldSucceedIfAuthorized FAILED
>>java.lang.NoClassDefFoundError: Could not initialize class
>>
>> org.apache.geode.internal.cache.tier.sockets.Message$$EnhancerByMockitoWithCGLIB$$f116767d
>> 
>>org.apache.geode.internal.cache.tier.sockets.command.ExecuteFunction65Test
>>> withIntegratedSecurityShouldThrowIfNotAuthorized FAILED
>>java.lang.NoClassDefFoundError: Could not initialize class
>>
>> org.apache.geode.internal.cache.tier.sockets.Message$$EnhancerByMockitoWithCGLIB$$f116767d
>> 
>>org.apache.geode.internal.cache.tier.sockets.command.ExecuteFunction65Test
>>> nonSecureShouldSucceed FAILED
>>java.lang.NoClassDefFoundError: Could not initialize class
>>
>> org.apache.geode.internal.cache.tier.sockets.Message$$EnhancerByMockitoWithCGLIB$$f116767d
>> 
>>org.apache.geode.internal.cache.tier.sockets.command.ExecuteFunction66Test
>>> withOldSecurityShouldSucceedIfAuthorized FAILED
>>java.lang.UnsatisfiedLinkError: Could not load library.
>>Reasons: [no jansi64-1.8 in java.library.path, no jansi-1.8 in
>>java.library.path, no jansi in java.library.path, Native Library
>>C:\cygwin\tmp\jansi-64-1.8.dll already loaded in another classloader]
>> 
>>etc. there's a TON of this
>> 
>> 
>> Le 3/31/2017 à 9:04 AM, Dick Cavender a écrit :
>>> +1
>>> 
>>> Built source and ran tests successfully on RH.
>>> 
>>> Ran gfsh on binary dist to start and stop locator and system.
>>> 
>>> 
>>> On 3/30/2017 4:58 PM, Anthony Baker wrote:
 Please review and vote (especially if you are a Geode PMC member!).
 
 Anthony
 
 
>>> 
>> 
> 

Re: Review Request 58080: GEODE-2420: Add classes to estimated the size of exported logs

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58080/#review170788
---


Ship it!




Ship It!

- Kirk Lund


On March 31, 2017, 7:55 p.m., Ken Howe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58080/
> ---
> 
> (Updated March 31, 2017, 7:55 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, Kirk 
> Lund, and Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> - New Function class added with tests
> - Code to invoke new function added, but disabled, in ExportLogsCommand
> - New option added, but disabled, for specifying size limit for exported
>   logs
> - Refactoring: extracted the interceptor from ExportLogsCommand
> - Refactoring: renamed ExportLogCommand to ExportLogsCommand
> - New Serializable class to return the log size estimate to the command
> - Tests for the log sizing related classes
> 
> This is work-in-progress that is adds sizing estimation for exported logs, 
> but the code is currently not called by ExportLogsCommand. Follow-on work 
> will use the new sizing estimation to provide warnings to the user if 
> exporting logs may fill up disks on servers or the locator.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogCommand.java
>  3f147c19a128dce78c51c31e6758e517cd2ab496 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogsInterceptor.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/ExportLogsFunction.java
>  cbdf1c4bc28554a8fbec3740c566ee07c69b4ac9 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/ExportedLogsSizeInfo.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/SizeExportLogsFunction.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java
>  5b1f089c18c404f64929398f6015839eb783ccb4 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/util/LogSizer.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsCommandTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsDUnitTest.java
>  95edd426da8b8f39bb1486661d8c307d43f170d6 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsFileSizeLimitTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsIntegrationTest.java
>  268fa397db253f12c0effdbf6faa5e822730144c 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsInterceptorJUnitTest.java
>  573701fd7f48c8c1b72c0f71993a4adea7bdbe8b 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsStatsDUnitTest.java
>  5a4d274a751a6e22fcfbc0c5e6bd5dff39e3b938 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsTestSuite.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/LogLevelInterceptorTest.java
>  41b971534fd83c87f33751fa46454e158315f6ae 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/ExportedLogsSizeInfoTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/SizeExportLogsFunctionCacheTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/SizeExportLogsFunctionFileTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/SizeExportLogsTestSuite.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/util/LogSizerTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java
>  6ae82da58923fdf3a44217c1773a40d8ff1001bc 
>   
> geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedDataSerializables.txt
>  2f5a5cdf8c59e90625fe01c3306462e9277ab4e1 
>   
> geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedSerializables.txt
>  397ec14c0bbbea277d378eefcaecfdb90cc9e224 
> 
> 
> Diff: https://reviews.apache.org/r/58080/diff/2/
> 
> 
> Testing
> ---
> 
> Precheckin is running
> 
> I need to debug one test of the new class that is still failing:
> 
> org.apache.geode.management.internal.cli.functions.SizeExportLogsFunctionCacheTest
>  > withFunctionError_shouldThrow FAILED
>

Re: Review Request 58010: GEODE-2716: export logs default behavior changed from filtering at log level INFO to ALL.

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58010/#review170789
---


Ship it!




Ship It!

- Kirk Lund


On March 30, 2017, 7:19 p.m., Patrick Rhomberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58010/
> ---
> 
> (Updated March 30, 2017, 7:19 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, Ken Howe, 
> Kirk Lund, and Swapnil Bawaskar.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Added relevant unit and dUnit tests.  Moved default value variable to 
> ExportLogsCommand and deleted the now-unused LogService.DEFAULT_LOG_LEVEL
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/internal/logging/LogService.java 
> 1f8a564 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogCommand.java
>  3f147c1 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/ExportLogsFunction.java
>  cbdf1c4 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsDUnitTest.java
>  95edd42 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/ExportLogsFunctionTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/58010/diff/2/
> 
> 
> Testing
> ---
> 
> precheckin running.
> 
> 
> Thanks,
> 
> Patrick Rhomberg
> 
>

[GitHub] geode-native pull request #84: GEODE-2513 Unbranding docs: Added Geode logos...

[davebarnes97]

GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode-native/pull/84

GEODE-2513 Unbranding docs: Added Geode logos to doc headers.

Added Geode logos to the documentation's top frame and at the top of 
individual topics. Patterned after the Geode website, with a white-on-black 
logo in the browser frame and a color-on-white log in the page body.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davebarnes97/geode-native 
feature/GEODE-2513-branding

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/84.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #84


commit 8a940fdcd72129bc84ca6c77ef1cd0e6d4ff6ab5
Author: Dave Barnes 
Date:   2017-03-31T21:47:55Z

GEODE-2513 Unbranding docs: Added Geode logos to doc headers.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2513) Geode Native docs: rebrand to match open-source software

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15951688#comment-15951688
 ] 

ASF GitHub Bot commented on GEODE-2513:
---

GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode-native/pull/84

GEODE-2513 Unbranding docs: Added Geode logos to doc headers.

Added Geode logos to the documentation's top frame and at the top of 
individual topics. Patterned after the Geode website, with a white-on-black 
logo in the browser frame and a color-on-white log in the page body.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davebarnes97/geode-native 
feature/GEODE-2513-branding

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/84.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #84


commit 8a940fdcd72129bc84ca6c77ef1cd0e6d4ff6ab5
Author: Dave Barnes 
Date:   2017-03-31T21:47:55Z

GEODE-2513 Unbranding docs: Added Geode logos to doc headers.




> Geode Native docs: rebrand to match open-source software
> 
>
> Key: GEODE-2513
> URL: https://issues.apache.org/jira/browse/GEODE-2513
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Dave Barnes
>
> The newly-contributed Geode Native doc sources contain some GemFire artifacts 
> that have been purged from the open-source code. Docs should be updated to 
> match. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native issue #84: GEODE-2513 Unbranding docs: Added Geode logos to doc...

[davebarnes97]

Github user davebarnes97 commented on the issue:

https://github.com/apache/geode-native/pull/84
  

![docs-branding-os-client](https://cloud.githubusercontent.com/assets/13138489/24570739/112e7296-1622-11e7-9f01-55b0402bf200.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2513) Geode Native docs: rebrand to match open-source software

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15951698#comment-15951698
 ] 

ASF GitHub Bot commented on GEODE-2513:
---

Github user davebarnes97 commented on the issue:

https://github.com/apache/geode-native/pull/84
  

![docs-branding-os-client](https://cloud.githubusercontent.com/assets/13138489/24570739/112e7296-1622-11e7-9f01-55b0402bf200.png)



> Geode Native docs: rebrand to match open-source software
> 
>
> Key: GEODE-2513
> URL: https://issues.apache.org/jira/browse/GEODE-2513
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Dave Barnes
>
> The newly-contributed Geode Native doc sources contain some GemFire artifacts 
> that have been purged from the open-source code. Docs should be updated to 
> match. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: [VOTE] Apache Geode release - v1.1.1 RC2

[Bruce Schuchardt]

It seems to work fine once I remove that dependency.  I booted up a 
server and a pub/sub cluster and it all worked fine.


Le 3/31/2017 à 1:56 PM, Anthony Baker a écrit :

On Mar 31, 2017, at 9:58 AM, Bruce Schuchardt  wrote:

I don't want to give this a -1 but I'm trying to validate this build on 
Microsoft Windows 7 and am running into problems in geode-test.

I agree.  I checked this and found the build error on windows goes back before 
v1.0.0-incubating.M2.  The develop branch doesn’t seem to exhibit this problem.

Anthony

[RESULT] [VOTE] Apache Geode release - v1.1.1 RC2

[Anthony Baker]

The vote passes with 6 +1 votes (5 binding) and 2 +0 votes.

+1 Swapnil Bawaskar (binding)
+0 Kirk Lund (binding)
+1 Mark Bretl (binding)
+1 Jared Stewart (binding)
+1 Dick Cavender
+1 Udo Kohlmeyer (binding)
+1 Xiaojian Zhou (binding)
+0 John Blum (binding)

Vote thread:
http://mail-archives.apache.org/mod_mbox/geode-dev/201703.mbox/%3ccaewge-eidovl10w-zaquo4+229c31z6fteov-w0qjqmsp+c...@mail.gmail.com%3e

Thanks,
Anthony


On Mon, Mar 27, 2017 at 10:18 PM, Anthony Baker  wrote:
> This is the second release candidate of the release for Apache Geode,
> version 1.1.1.
>
> It fixes the following issues:
>   
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318420&version=12340271
>
> *** Please download, test and vote by Thursday, March 30, 2200 hrs US
> Pacific. ***
>
> Note that we are voting upon the source (tag):
>   rel/v1.1.1.RC2
>   
> https://git-wip-us.apache.org/repos/asf?p=geode.git;a=tag;h=refs/tags/rel/v1.1.1.RC2
>
> Commit ID: e2081044ea0afca1cb38d62c7f34e7363b45ad97
>
> Source and binary files:
>   https://dist.apache.org/repos/dist/dev/geode/1.1.1.RC2/
>
> Maven staging repo:
>   https://repository.apache.org/content/repositories/orgapachegeode-1018
>
> Geode's KEYS file containing PGP keys we use to sign the release:
>   https://github.com/apache/geode/blob/release/1.1.1/KEYS
>
> pub  4096R/C72CFB64 2015-10-01
> Fingerprint=948E 8234 14BE 693A 7F74  ABBE 19DB CAEE C72C FB64
>
>
> Thanks,
> Anthony

Re: Review Request 58080: GEODE-2420: Add classes to estimated the size of exported logs

[Ken Howe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58080/
---

(Updated March 31, 2017, 10:35 p.m.)


Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, Kirk Lund, 
and Patrick Rhomberg.


Repository: geode


Description
---

- New Function class added with tests
- Code to invoke new function added, but disabled, in ExportLogsCommand
- New option added, but disabled, for specifying size limit for exported
  logs
- Refactoring: extracted the interceptor from ExportLogsCommand
- Refactoring: renamed ExportLogCommand to ExportLogsCommand
- New Serializable class to return the log size estimate to the command
- Tests for the log sizing related classes

This is work-in-progress that is adds sizing estimation for exported logs, but 
the code is currently not called by ExportLogsCommand. Follow-on work will use 
the new sizing estimation to provide warnings to the user if exporting logs may 
fill up disks on servers or the locator.


Diffs
-

  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogCommand.java
 3f147c19a128dce78c51c31e6758e517cd2ab496 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogsInterceptor.java
 PRE-CREATION 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/ExportLogsFunction.java
 cbdf1c4bc28554a8fbec3740c566ee07c69b4ac9 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/ExportedLogsSizeInfo.java
 PRE-CREATION 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/SizeExportLogsFunction.java
 PRE-CREATION 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java
 5b1f089c18c404f64929398f6015839eb783ccb4 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/util/LogSizer.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsCommandTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsDUnitTest.java
 95edd426da8b8f39bb1486661d8c307d43f170d6 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsFileSizeLimitTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsIntegrationTest.java
 268fa397db253f12c0effdbf6faa5e822730144c 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsInterceptorJUnitTest.java
 573701fd7f48c8c1b72c0f71993a4adea7bdbe8b 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsStatsDUnitTest.java
 5a4d274a751a6e22fcfbc0c5e6bd5dff39e3b938 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsTestSuite.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/LogLevelInterceptorTest.java
 41b971534fd83c87f33751fa46454e158315f6ae 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/ExportedLogsSizeInfoTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/SizeExportLogsFunctionCacheTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/SizeExportLogsFunctionFileTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/SizeExportLogsTestSuite.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/util/LogSizerTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java
 6ae82da58923fdf3a44217c1773a40d8ff1001bc 
  
geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedDataSerializables.txt
 2f5a5cdf8c59e90625fe01c3306462e9277ab4e1 
  
geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedSerializables.txt
 397ec14c0bbbea277d378eefcaecfdb90cc9e224 


Diff: https://reviews.apache.org/r/58080/diff/2/


Testing (updated)
---

Precheckin is running

I need to debug one test of the new class that is still failing:

org.apache.geode.management.internal.cli.functions.SizeExportLogsFunctionCacheTest
 > withFunctionError_shouldThrow FAILED
org.apache.geode.GemFireConfigException: The locators attribute can not be 
empty when the mcast-port attribute is non-zero.
at 
org.apache.geode.distributed.internal.InternalDistributedSystem.initialize(InternalDistributedSystem.java:558)
at 
org.apache.geode.distributed.internal.InternalDistributedSystem.newInstance(InternalDistributedSystem.java:299)
at 
org.apache.geode.distributed.DistributedSystem.connect(DistributedSystem.java:206)
at org.apache.geode.cache.CacheFactory.create(CacheFactory.java:216)
 

[jira] [Commented] (GEODE-2670) Update pulse endpoint interceptors

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15951740#comment-15951740
 ] 

ASF subversion and git services commented on GEODE-2670:


Commit e2081044ea0afca1cb38d62c7f34e7363b45ad97 in geode's branch 
refs/heads/master from [~jinmeiliao]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=e208104 ]

GEODE-2670: Update pulse endpoint interceptors

(cherry picked from commit 5b71c4b5b99a62063453535c9604df7e4be460fe)


> Update pulse endpoint interceptors
> --
>
> Key: GEODE-2670
> URL: https://issues.apache.org/jira/browse/GEODE-2670
> Project: Geode
>  Issue Type: Bug
>  Components: pulse, security
>Reporter: Jinmei Liao
>Assignee: Jinmei Liao
> Fix For: 1.2.0, 1.1.1
>
>
> Steps to reproduce:
> 1) in gfsh, start up a locator with a security manager
> 2) in the browser, try to connect to pulse: http://localhost:7070/pulse
> 3) when presented a login page, try a invalid username/password.
> 4) when getting "incorrect password" hint, use the same username, try using 
> the correct password for that user. It would still say "incorrect password".
> Also, repeat above step 1 and 2, 
> 3), use a correct username and password that only have cluster:read previlage.
> 4) try to access the dataBrowser.html, expect to get denied access, but is 
> still able to access. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #510 was SUCCESSFUL (with 1843 tests)

[Spring CI]

---
Spring Data GemFire > Nightly-ApacheGeode > #510 was successful.
---
Scheduled
1845 tests in total.

https://build.spring.io/browse/SGF-NAG-510/





--
This message is automatically generated by Atlassian Bamboo

Passed: apache/geode#2282 (rel/v1.1.1 - e208104)

[Travis CI]

Build Update for apache/geode
-

Build: #2282
Status: Passed

Duration: 7 minutes and 34 seconds
Commit: e208104 (rel/v1.1.1)
Author: Jinmei Liao
Message: GEODE-2670: Update pulse endpoint interceptors

(cherry picked from commit 5b71c4b5b99a62063453535c9604df7e4be460fe)

View the changeset: https://github.com/apache/geode/compare/rel/v1.1.1

View the full build log and details: 
https://travis-ci.org/apache/geode/builds/217363513

--

You can configure recipients for build notifications in your .travis.yml file. 
See https://docs.travis-ci.com/user/notifications

Re: Review Request 58050: GEODE-2725: export logs --dir now honored when not connected via HTTP[S].

[Patrick Rhomberg]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58050/
---

(Updated March 31, 2017, 11:16 p.m.)


Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, Ken Howe, 
Kirk Lund, and Swapnil Bawaskar.


Changes
---

Very prematurely closed this before.  Inherited HTTP test class exploded.  
Thanks to jstewart for smashing that out.


Repository: geode


Description
---

export logs --dir refers to local filesystem when connected via HTTP and refers 
to the managers filesystem when connected via JMX.  This behavior will be 
changed in GEODE-2663.


Diffs (updated)
-

  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogCommand.java
 3f147c1 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java
 5b1f089 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsIntegrationTest.java
 9a39298 
  
geode-core/src/test/resources/org/apache/geode/management/internal/cli/commands/golden-help-offline.properties
 3c56def 
  
geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsOverHttpIntegrationTest.java
 90f16ea 


Diff: https://reviews.apache.org/r/58050/diff/5/

Changes: https://reviews.apache.org/r/58050/diff/4-5/


Testing (updated)
---

precheckin running.


Thanks,

Patrick Rhomberg

[GitHub] geode-native pull request #82: GEODE-2736: Fixed orphaned worker threads

[mhansonp]

Github user mhansonp commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/82#discussion_r109271745
  
--- Diff: 
src/cppcache/integration-test/testThinClientPoolExecuteFunctionThrowsException.cpp
 ---
@@ -0,0 +1,362 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#define ROOT_NAME "testThinClientPoolExecuteFunctionThrowsException"
+
+#include "fw_dunit.hpp"
+#include "ThinClientHelper.hpp"
+#include "testobject/VariousPdxTypes.hpp"
+
+#include 
+#include 
+
+using namespace PdxTests;
+/* This is to test
+1- funtion execution on pool
+ */
+
+#define CLIENT1 s1p1
+#define LOCATOR1 s2p1
+#define SERVER s2p2
+
+bool isLocalServer = false;
+bool isLocator = false;
+bool isPoolWithEndpoint = false;
+
+const char* locHostPort =
+CacheHelper::getLocatorHostPort(isLocator, isLocalServer, 1);
+const char* poolRegNames[] = {"partition_region", "PoolRegion2"};
+
+const char* serverGroup = "ServerGroup1";
+
+char* getFuncIName = (char*)"MultiGetFunctionI";
+char* putFuncIName = (char*)"MultiPutFunctionI";
+char* getFuncName = (char*)"MultiGetFunction";
+char* putFuncName = (char*)"MultiPutFunction";
+char* rjFuncName = (char*)"RegionOperationsFunction";
+char* exFuncName = (char*)"ExceptionHandlingFunction";
+char* exFuncNameSendException = (char*)"executeFunction_SendException";
+char* exFuncNamePdxType = (char*)"PdxFunctionTest";
+char* FEOnRegionPrSHOP = (char*)"FEOnRegionPrSHOP";
+char* FEOnRegionPrSHOP_OptimizeForWrite =
+(char*)"FEOnRegionPrSHOP_OptimizeForWrite";
+char* FETimeOut = (char*)"FunctionExecutionTimeOut";
+
+#define verifyGetResults() 
   \
+bool found = false;
 \
+for (int j = 0; j < 34; j++) { 
 \
+  if (j % 2 == 0) continue;
 \
+  sprintf(buf, "VALUE--%d", j);
 \
+  if (strcmp(buf, 
dynCast(resultList->operator[](i))\
+ ->asChar()) == 0) {   \
+LOGINFO(   
 \
+   
 "buf = %s " \
+   
 "dynCast(resultList->operator[](i))->asChar() " \
+   
 "= %s ",\
+   
 buf,\
+   
 dynCast(resultList->operator[](i))->asChar());  \
+   
 found = true;   \
+   
 break;  \
+  }
 \
+}  
 \
+ASSERT(found, "this returned value is invalid");
+
+#define verifyGetKeyResults()  
   \
+bool found = false;
 \
+for (int j = 0; j < 34; j++) { 
 \
+  if (j % 2 == 0) continue;
 \
+  sprintf(buf, "KEY--%d", j);   

[jira] [Commented] (GEODE-2736) Native client thread pool get stuck sometimes during rolling restart

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15951875#comment-15951875
 ] 

ASF GitHub Bot commented on GEODE-2736:
---

Github user mhansonp commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/82#discussion_r109271745
  
--- Diff: 
src/cppcache/integration-test/testThinClientPoolExecuteFunctionThrowsException.cpp
 ---
@@ -0,0 +1,362 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#define ROOT_NAME "testThinClientPoolExecuteFunctionThrowsException"
+
+#include "fw_dunit.hpp"
+#include "ThinClientHelper.hpp"
+#include "testobject/VariousPdxTypes.hpp"
+
+#include 
+#include 
+
+using namespace PdxTests;
+/* This is to test
+1- funtion execution on pool
+ */
+
+#define CLIENT1 s1p1
+#define LOCATOR1 s2p1
+#define SERVER s2p2
+
+bool isLocalServer = false;
+bool isLocator = false;
+bool isPoolWithEndpoint = false;
+
+const char* locHostPort =
+CacheHelper::getLocatorHostPort(isLocator, isLocalServer, 1);
+const char* poolRegNames[] = {"partition_region", "PoolRegion2"};
+
+const char* serverGroup = "ServerGroup1";
+
+char* getFuncIName = (char*)"MultiGetFunctionI";
+char* putFuncIName = (char*)"MultiPutFunctionI";
+char* getFuncName = (char*)"MultiGetFunction";
+char* putFuncName = (char*)"MultiPutFunction";
+char* rjFuncName = (char*)"RegionOperationsFunction";
+char* exFuncName = (char*)"ExceptionHandlingFunction";
+char* exFuncNameSendException = (char*)"executeFunction_SendException";
+char* exFuncNamePdxType = (char*)"PdxFunctionTest";
+char* FEOnRegionPrSHOP = (char*)"FEOnRegionPrSHOP";
+char* FEOnRegionPrSHOP_OptimizeForWrite =
+(char*)"FEOnRegionPrSHOP_OptimizeForWrite";
+char* FETimeOut = (char*)"FunctionExecutionTimeOut";
+
+#define verifyGetResults() 
   \
+bool found = false;
 \
+for (int j = 0; j < 34; j++) { 
 \
+  if (j % 2 == 0) continue;
 \
+  sprintf(buf, "VALUE--%d", j);
 \
+  if (strcmp(buf, 
dynCast(resultList->operator[](i))\
+ ->asChar()) == 0) {   \
+LOGINFO(   
 \
+   
 "buf = %s " \
+   
 "dynCast(resultList->operator[](i))->asChar() " \
+   
 "= %s ",\
+   
 buf,\
+   
 dynCast(resultList->operator[](i))->asChar());  \
+   
 found = true;   \
+   
 break;  \
+  }
 \
+}  
 \
+ASSERT(found, "this returned value is invalid");
+
+#define verifyGetKeyResults()  
   \
+bool found = false;

Re: [VOTE] Apache Geode release - v1.1.1 RC2

[Avinash Dongre]

+1
Built from sources
Sanity check with gfsh

Thanks
Avinash


On Sat, Apr 1, 2017 at 3:28 AM, Bruce Schuchardt 
wrote:

> It seems to work fine once I remove that dependency.  I booted up a server
> and a pub/sub cluster and it all worked fine.
>
>
> Le 3/31/2017 à 1:56 PM, Anthony Baker a écrit :
>
>> On Mar 31, 2017, at 9:58 AM, Bruce Schuchardt 
>>> wrote:
>>>
>>> I don't want to give this a -1 but I'm trying to validate this build on
>>> Microsoft Windows 7 and am running into problems in geode-test.
>>>
>> I agree.  I checked this and found the build error on windows goes back
>> before v1.0.0-incubating.M2.  The develop branch doesn’t seem to exhibit
>> this problem.
>>
>> Anthony
>>
>>
>

[GitHub] geode issue #321: [GEODE-1577] Unhelpful generic types on Execution.execute

[upthewaterspout]

Github user upthewaterspout commented on the issue:

https://github.com/apache/geode/pull/321
  
+1 these latest changes look good to me!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-1577) Unhelpful generic types on Execution.execute

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15951979#comment-15951979
 ] 

ASF GitHub Bot commented on GEODE-1577:
---

Github user upthewaterspout commented on the issue:

https://github.com/apache/geode/pull/321
  
+1 these latest changes look good to me!


> Unhelpful generic types on Execution.execute
> 
>
> Key: GEODE-1577
> URL: https://issues.apache.org/jira/browse/GEODE-1577
> Project: Geode
>  Issue Type: Bug
>  Components: functions
>Reporter: Dan Smith
>
> The execute methods of the function service Execution class returns a 
> ResultCollector with wildcards for the type.
> {code}  
> public ResultCollector execute(
>   Function function) throws FunctionException;
> {code}
> Wildcards are supposed to be used in APIs where the type doesn't matter, for 
> example counting the elements in a list. By returning a ResultCollector with 
> wildcards, we're essentially forcing the user to cast the result collector.
> At a minimum they should be able to pick the type of result collector
> {code}
>   public  ResultCollector execute(
>   Function function) throws FunctionException;
> {code}
> But maybe it would make more sense to parameterize Execution itself. Then the 
> compiler could ensure that the types used by withCollector and the types used 
> by execute match.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)