----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58050/ -----------------------------------------------------------
(Updated March 31, 2017, 11:16 p.m.) Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, Ken Howe, Kirk Lund, and Swapnil Bawaskar. Changes ------- Very prematurely closed this before. Inherited HTTP test class exploded. Thanks to jstewart for smashing that out. Repository: geode Description ------- export logs --dir refers to local filesystem when connected via HTTP and refers to the managers filesystem when connected via JMX. This behavior will be changed in GEODE-2663. Diffs (updated) ----- geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogCommand.java 3f147c1 geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java 5b1f089 geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsIntegrationTest.java 9a39298 geode-core/src/test/resources/org/apache/geode/management/internal/cli/commands/golden-help-offline.properties 3c56def geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsOverHttpIntegrationTest.java 90f16ea Diff: https://reviews.apache.org/r/58050/diff/5/ Changes: https://reviews.apache.org/r/58050/diff/4-5/ Testing (updated) ------- precheckin running. Thanks, Patrick Rhomberg
